Re: [MM] [PATCH 2/2] novatel-lte: skip soft reset if modem is newly plugged in
On 02/15/2013 06:26 PM, Ben Chan wrote: > I was also wondering if that's needed. I guess soft-resetting the modem > helps clear any unknown settings on the modem before ModemManager starts > managing it. For a hotplugged modem, I'd assume it is managed by > ModemManager from the beginning and have the right settings set. > > But if you think it's better/safer to soft reset the modem after > disabling/re-enabling it, we can reset the hotplugged value. > I pushed some changes to git master which actually apply your logic to all modems, among other things. Would be good if you try git master with your modems. -- Aleksander ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [MM] [PATCH 2/2] novatel-lte: skip soft reset if modem is newly plugged in
I was also wondering if that's needed. I guess soft-resetting the modem
helps clear any unknown settings on the modem before ModemManager starts
managing it. For a hotplugged modem, I'd assume it is managed by
ModemManager from the beginning and have the right settings set.
But if you think it's better/safer to soft reset the modem after
disabling/re-enabling it, we can reset the hotplugged value.
- Ben
On Fri, Feb 15, 2013 at 1:21 AM, Aleksander Morgado
wrote:
> Hey Ben,
>
> Some thoughts about this patch (which is already merged).
>
> On 01/18/2013 08:11 AM, Ben Chan wrote:
> > +static void
> > +modem_init (MMIfaceModem *self,
> > +GAsyncReadyCallback callback,
> > +gpointer user_data)
> > +{
> > +MMAtSerialPort *primary;
> > +GSimpleAsyncResult *result;
> > +guint init_sequence_index;
> > +
> > +result = g_simple_async_result_new (G_OBJECT (self),
> > +callback,
> > +user_data,
> > +modem_init);
> > +
> > +primary = mm_base_modem_peek_port_primary (MM_BASE_MODEM (self));
> > +if (!primary) {
> > +g_simple_async_result_set_error (
> > +result,
> > +MM_CORE_ERROR,
> > +MM_CORE_ERROR_FAILED,
> > +"Need primary AT port to run modem init sequence");
> > +g_simple_async_result_complete_in_idle (result);
> > +g_object_unref (result);
> > +return;
> > +}
> > +
> > +/* Skip ATZ if the device was hotplugged. */
> > +init_sequence_index = mm_base_modem_get_hotplugged (MM_BASE_MODEM
> (self)) ? 1 : 0;
> > +
> > +mm_base_modem_at_sequence_full (MM_BASE_MODEM (self),
> > +primary,
> > +
> &modem_init_sequence[init_sequence_index],
> > +NULL, /*
> response_processor_context */
> > +NULL, /*
> response_processor_context_free */
> > +NULL, /* cancellable */
> > +
> (GAsyncReadyCallback)modem_init_sequence_ready,
> > +result);
>
> Just wondering, shouldn't you reset the 'hotplugged' property in the
> base modem as soon as you check it the first time? If it's left set to
> TRUE, ATZ will not be sent after disabling and re-enabling the modem.
>
> --
> Aleksander
>
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [MM] [PATCH 2/2] novatel-lte: skip soft reset if modem is newly plugged in
Hey Ben,
Some thoughts about this patch (which is already merged).
On 01/18/2013 08:11 AM, Ben Chan wrote:
> +static void
> +modem_init (MMIfaceModem *self,
> +GAsyncReadyCallback callback,
> +gpointer user_data)
> +{
> +MMAtSerialPort *primary;
> +GSimpleAsyncResult *result;
> +guint init_sequence_index;
> +
> +result = g_simple_async_result_new (G_OBJECT (self),
> +callback,
> +user_data,
> +modem_init);
> +
> +primary = mm_base_modem_peek_port_primary (MM_BASE_MODEM (self));
> +if (!primary) {
> +g_simple_async_result_set_error (
> +result,
> +MM_CORE_ERROR,
> +MM_CORE_ERROR_FAILED,
> +"Need primary AT port to run modem init sequence");
> +g_simple_async_result_complete_in_idle (result);
> +g_object_unref (result);
> +return;
> +}
> +
> +/* Skip ATZ if the device was hotplugged. */
> +init_sequence_index = mm_base_modem_get_hotplugged (MM_BASE_MODEM
> (self)) ? 1 : 0;
> +
> +mm_base_modem_at_sequence_full (MM_BASE_MODEM (self),
> +primary,
> +
> &modem_init_sequence[init_sequence_index],
> +NULL, /* response_processor_context */
> +NULL, /*
> response_processor_context_free */
> +NULL, /* cancellable */
> +
> (GAsyncReadyCallback)modem_init_sequence_ready,
> +result);
Just wondering, shouldn't you reset the 'hotplugged' property in the
base modem as soon as you check it the first time? If it's left set to
TRUE, ATZ will not be sent after disabling and re-enabling the modem.
--
Aleksander
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [MM] [PATCH 2/2] novatel-lte: skip soft reset if modem is newly plugged in
On 18/01/13 08:11, Ben Chan wrote: > Soft resetting a Novatel LTE modem can a significant amount of time > (3-4 seconds). If the modem is newly plugged in, skip the unnecessary > soft reset when enabling the modem. > --- Merged, thanks! -- Aleksander ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
[MM] [PATCH 2/2] novatel-lte: skip soft reset if modem is newly plugged in
Soft resetting a Novatel LTE modem can a significant amount of time
(3-4 seconds). If the modem is newly plugged in, skip the unnecessary
soft reset when enabling the modem.
---
plugins/novatel/mm-broadband-modem-novatel-lte.c | 108 ++
1 files changed, 108 insertions(+), 0 deletions(-)
diff --git a/plugins/novatel/mm-broadband-modem-novatel-lte.c
b/plugins/novatel/mm-broadband-modem-novatel-lte.c
index 08954b5..d32c397 100644
--- a/plugins/novatel/mm-broadband-modem-novatel-lte.c
+++ b/plugins/novatel/mm-broadband-modem-novatel-lte.c
@@ -43,6 +43,112 @@ G_DEFINE_TYPE_EXTENDED (MMBroadbandModemNovatelLte,
mm_broadband_modem_novatel_l
G_IMPLEMENT_INTERFACE (MM_TYPE_IFACE_MODEM_3GPP,
iface_modem_3gpp_init));
/*/
+/* Initializing the modem (Modem interface) */
+
+static gboolean
+modem_init_finish (MMIfaceModem *self,
+ GAsyncResult *res,
+ GError **error)
+{
+return !g_simple_async_result_propagate_error (G_SIMPLE_ASYNC_RESULT
(res), error);
+}
+
+static void
+modem_init_sequence_ready (MMBaseModem *self,
+ GAsyncResult *res,
+ GSimpleAsyncResult *simple)
+{
+GError *error = NULL;
+
+mm_base_modem_at_sequence_full_finish (MM_BASE_MODEM (self), res, NULL,
&error);
+if (error)
+g_simple_async_result_take_error (simple, error);
+else {
+MMAtSerialPort *secondary;
+
+/* Disable echo in secondary port as well, if any */
+secondary = mm_base_modem_peek_port_secondary (MM_BASE_MODEM (self));
+if (secondary)
+/* No need to wait for the reply */
+mm_base_modem_at_command_full (MM_BASE_MODEM (self),
+ secondary,
+ "E0",
+ 3,
+ FALSE,
+ FALSE, /* raw */
+ NULL, /* cancellable */
+ NULL,
+ NULL);
+
+g_simple_async_result_set_op_res_gboolean (simple, TRUE);
+}
+
+g_simple_async_result_complete (simple);
+g_object_unref (simple);
+}
+
+static const MMBaseModemAtCommand modem_init_sequence[] = {
+/* Init command. ITU rec v.250 (6.1.1) says:
+ * The DTE should not include additional commands on the same command
line
+ * after the Z command because such commands may be ignored.
+ * So run ATZ alone.
+ */
+{ "Z", 6, FALSE, mm_base_modem_response_processor_no_result_continue
},
+
+/* Ensure echo is off after the init command */
+{ "E0 V1", 3, FALSE, NULL },
+
+/* Some phones (like Blackberries) don't support +CMEE=1, so make it
+ * optional. It completely violates 3GPP TS 27.007 (9.1) but what can we
do...
+ */
+{ "+CMEE=1", 3, FALSE, NULL },
+
+/* Additional OPTIONAL initialization */
+{ "X4 &C1", 3, FALSE, NULL },
+
+{ NULL }
+};
+
+static void
+modem_init (MMIfaceModem *self,
+GAsyncReadyCallback callback,
+gpointer user_data)
+{
+MMAtSerialPort *primary;
+GSimpleAsyncResult *result;
+guint init_sequence_index;
+
+result = g_simple_async_result_new (G_OBJECT (self),
+callback,
+user_data,
+modem_init);
+
+primary = mm_base_modem_peek_port_primary (MM_BASE_MODEM (self));
+if (!primary) {
+g_simple_async_result_set_error (
+result,
+MM_CORE_ERROR,
+MM_CORE_ERROR_FAILED,
+"Need primary AT port to run modem init sequence");
+g_simple_async_result_complete_in_idle (result);
+g_object_unref (result);
+return;
+}
+
+/* Skip ATZ if the device was hotplugged. */
+init_sequence_index = mm_base_modem_get_hotplugged (MM_BASE_MODEM (self))
? 1 : 0;
+
+mm_base_modem_at_sequence_full (MM_BASE_MODEM (self),
+primary,
+&modem_init_sequence[init_sequence_index],
+NULL, /* response_processor_context */
+NULL, /* response_processor_context_free
*/
+NULL, /* cancellable */
+
(GAsyncReadyCallback)modem_init_sequence_ready,
+result);
+}
+
+/*/
/* Create Bearer (Modem interface) */
static MMBearer *
@@ -637,6 +743,8 @@ mm_broadband_modem_novatel_lte_init
(MMBroadbandModemNovatelLte *self)
static void
iface_modem_init (MMIfaceModem *i
