Re: [ModemManager] Two SMS bugs in the new code
On Sun, 2012-05-06 at 18:59 +0200, Aleksander Morgado wrote: Hey Nathan, On 04/26/2012 01:58 AM, Nathan Williams wrote: 1. When a new single-part message arrives, an Added signal is sent but the Completed signal is not sent. We emit Added if we got a singlepart message or whenever we get the first part of a multipart message. In the latter case, the state of the SMS will be RECEIVING, until the last part is received and the message assembled, which is when the state of the SMS goes to RECEIVED. I would vote for completely removing the Completed emitted in the Messaging interface; and instead just rely on each SMS state changes... At least that was my original idea when I skipped emitting the Completed signal all together. Since we have individual message state, Completed doesn't seem that useful. They would be exactly the same thing except the state conveys more information, which is more useful than Completed. Dan 2. Multipart messages don't seem to work - the multipart bit isn't getting set correctly somewhere?. Yes, it wasn't being set properly; fixed here: http://cgit.freedesktop.org/ModemManager/ModemManager/commit/?id=df1f21d17f6923145926fba5be38cff947254cae Could you test it with that fix in? ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [ModemManager] Two SMS bugs in the new code
Hey Nathan, On 04/26/2012 01:58 AM, Nathan Williams wrote: 1. When a new single-part message arrives, an Added signal is sent but the Completed signal is not sent. We emit Added if we got a singlepart message or whenever we get the first part of a multipart message. In the latter case, the state of the SMS will be RECEIVING, until the last part is received and the message assembled, which is when the state of the SMS goes to RECEIVED. I would vote for completely removing the Completed emitted in the Messaging interface; and instead just rely on each SMS state changes... At least that was my original idea when I skipped emitting the Completed signal all together. 2. Multipart messages don't seem to work - the multipart bit isn't getting set correctly somewhere?. Yes, it wasn't being set properly; fixed here: http://cgit.freedesktop.org/ModemManager/ModemManager/commit/?id=df1f21d17f6923145926fba5be38cff947254cae Could you test it with that fix in? -- Aleksander ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
[ModemManager] Two SMS bugs in the new code
1. When a new single-part message arrives, an Added signal is sent but the Completed signal is not sent. 2. Multipart messages don't seem to work - the multipart bit isn't getting set correctly somewhere?. See logs: 2012-04-25T16:56:55.500166-07:00 localhost ModemManager[1238]: debug [1335398215.499970] [mm-at-serial-port.c:385] debug_log(): (ttyACM1): -- 'CRLF+CMTI: ME,10CRLF' 2012-04-25T16:56:55.500351-07:00 localhost ModemManager[1238]: debug [1335398215.500199] [mm-serial-port.c:929] mm_serial_port_open(): (ttyACM1) device open count is 2 (open) 2012-04-25T16:56:55.500554-07:00 localhost ModemManager[1238]: debug [1335398215.500420] [mm-at-serial-port.c:385] debug_log(): (ttyACM0): -- 'CRLF+CMTI: ME,10CRLF' 2012-04-25T16:56:55.500781-07:00 localhost ModemManager[1238]: debug [1335398215.500646] [mm-at-serial-port.c:385] debug_log(): (ttyACM1): -- 'AT+CMGR=10CR' 2012-04-25T16:56:55.528526-07:00 localhost ModemManager[1238]: debug [1335398215.528348] [mm-at-serial-port.c:385] debug_log(): (ttyACM1): -- 'CRLF+CMGR: 0,,159CRLF07912160130320F5440B916171056429F521405291650569A00500034C0201A9E8F41C949E83C2207B599E07B1DFEE33885E9ED3' 2012-04-25T16:56:55.529131-07:00 localhost ModemManager[1238]: debug [1335398215.528832] [mm-at-serial-port.c:385] debug_log(): (ttyACM1): -- '41E4F23C7D7697C920FA1B54C697E5E3F4BC0C6AD7D9F434081E96D341E3303C2C4EB3D3F4BC0B94A483E6E8779D4D06CDD1EF3BA80E0785E7A0B7BB0C6A97E7F3F0B9CC02B9DF7450780EA2DFDF2C50780EA2A3CBA0BA9B5C96B3F369F71954768FDFE4B4FB0C9297E1F2F2BCECA6CF41CRLF' 2012-04-25T16:56:55.529514-07:00 localhost ModemManager[1238]: debug [1335398215.529373] [mm-at-serial-port.c:385] debug_log(): (ttyACM1): -- 'CRLFOKCRLF' 2012-04-25T16:56:55.529856-07:00 localhost ModemManager[1238]: debug [1335398215.529719] [mm-broadband-modem.c:4186] sms_part_ready(): Correctly parsed PDU (10) 2012-04-25T16:56:55.530756-07:00 localhost ModemManager[1238]: debug [1335398215.530554] [mm-iface-modem-messaging.c:344] mm_iface_modem_messaging_take_part(): Couldn't take part in SMS list: 'This SMS is not a multipart message' 2012-04-25T16:56:55.530851-07:00 localhost ModemManager[1238]: debug [1335398215.530692] [mm-serial-port.c:969] mm_serial_port_close(): (ttyACM1) device open count is 1 (close) 2012-04-25T16:56:57.392557-07:00 localhost ModemManager[1238]: debug [1335398217.392363] [mm-at-serial-port.c:385] debug_log(): (ttyACM0): -- 'CRLF+CMTI: ME,11CRLF' 2012-04-25T16:56:57.392741-07:00 localhost ModemManager[1238]: debug [1335398217.392588] [mm-serial-port.c:929] mm_serial_port_open(): (ttyACM1) device open count is 2 (open) 2012-04-25T16:56:57.393086-07:00 localhost ModemManager[1238]: debug [1335398217.392845] [mm-at-serial-port.c:385] debug_log(): (ttyACM1): -- 'CRLF+CMTI: ME,11CRLF' 2012-04-25T16:56:57.393325-07:00 localhost ModemManager[1238]: debug [1335398217.393184] [mm-at-serial-port.c:385] debug_log(): (ttyACM1): -- 'AT+CMGR=11CR' 2012-04-25T16:56:57.421656-07:00 localhost ModemManager[1238]: debug [1335398217.421476] [mm-at-serial-port.c:385] debug_log(): (ttyACM1): -- 'CRLF+CMGR: 0,,63CRLF07912160130320F6440B916171056429F521405291651569320500034C0202E9E8301D44479741F0B09C3E0785E56590BCCC0ED3C' 2012-04-25T16:56:57.421966-07:00 localhost ModemManager[1238]: debug [1335398217.421821] [mm-at-serial-port.c:385] debug_log(): (ttyACM1): -- 'B6410FD0D7ABBCBA0B0FB4D4797E52E10CRLFCRLFOKCRLF' 2012-04-25T16:56:57.422362-07:00 localhost ModemManager[1238]: debug [1335398217.422207] [mm-broadband-modem.c:4186] sms_part_ready(): Correctly parsed PDU (11) 2012-04-25T16:56:57.423165-07:00 localhost ModemManager[1238]: debug [1335398217.422971] [mm-iface-modem-messaging.c:344] mm_iface_modem_messaging_take_part(): Couldn't take part in SMS list: 'This SMS is not a multipart message' - Nathan ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
