Re: [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
On Fri, 2011-04-08 at 12:00 -0400, Nathan Williams wrote: > Sure, updated patch attached. Pushed, thanks. Dan > > - Nathan > > On Thu, Apr 7, 2011 at 6:45 PM, Dan Williams wrote: > On Thu, 2011-04-07 at 18:09 -0400, Nathan Williams wrote: > > As it says in the patch, this is necessary to distinguish > between 7- > > and 8-character messages, since both are encoded in 7 > octets. > > > Can you fix up the testcases too? > > src/tests/test_unpack_gsm7: ** > ERROR:test-charsets.c:103:test_unpack_gsm7: assertion failed > (unpacked_len == sizeof (expected)): (11 == 12) > > Dan > > > > ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
Sure, updated patch attached. - Nathan On Thu, Apr 7, 2011 at 6:45 PM, Dan Williams wrote: > On Thu, 2011-04-07 at 18:09 -0400, Nathan Williams wrote: > > As it says in the patch, this is necessary to distinguish between 7- > > and 8-character messages, since both are encoded in 7 octets. > > Can you fix up the testcases too? > > src/tests/test_unpack_gsm7: ** > ERROR:test-charsets.c:103:test_unpack_gsm7: assertion failed (unpacked_len > == sizeof (expected)): (11 == 12) > > Dan > > > mm-patch-gsm7-2 Description: Binary data ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
On Thu, 2011-04-07 at 17:45 -0500, Dan Williams wrote: > On Thu, 2011-04-07 at 18:09 -0400, Nathan Williams wrote: > > As it says in the patch, this is necessary to distinguish between 7- > > and 8-character messages, since both are encoded in 7 octets. > > Can you fix up the testcases too? > > src/tests/test_unpack_gsm7: ** > ERROR:test-charsets.c:103:test_unpack_gsm7: assertion failed (unpacked_len == > sizeof (expected)): (11 == 12) You should be able to run 'make check' and reproduce the issue if you've configured with --with-tests=yes. Dan ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
On Thu, 2011-04-07 at 18:09 -0400, Nathan Williams wrote: > As it says in the patch, this is necessary to distinguish between 7- > and 8-character messages, since both are encoded in 7 octets. Can you fix up the testcases too? src/tests/test_unpack_gsm7: ** ERROR:test-charsets.c:103:test_unpack_gsm7: assertion failed (unpacked_len == sizeof (expected)): (11 == 12) Dan ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
[PATCH] ModemManager: Change length input to gsm7 to take the number of characters rather than octets
As it says in the patch, this is necessary to distinguish between 7- and 8-character messages, since both are encoded in 7 octets. - Nathan mm-patch-gsm7 Description: Binary data ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
