Re: [PATCH] libnm-util: fix Bridge priority default (rh #1073664)

2014-03-14 Thread Thomas Haller
On Fri, 2014-03-07 at 18:05 -0600, Dan Williams wrote:
 Due to a misread of the kernel code, the bridge priority default
 when STP was enabled was 0x80 instead of 0x8000.

Acked-by: Thomas Haller thal...@redhat.com


signature.asc
Description: This is a digitally signed message part
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: [PATCH] libnm-util: fix Bridge priority default (rh #1073664)

2014-03-14 Thread Dan Williams
On Fri, 2014-03-14 at 17:18 +0100, Thomas Haller wrote:
 On Fri, 2014-03-07 at 18:05 -0600, Dan Williams wrote:
  Due to a misread of the kernel code, the bridge priority default
  when STP was enabled was 0x80 instead of 0x8000.
 
 Acked-by: Thomas Haller thal...@redhat.com

Thanks, pushed to git master.

Dan

___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list


[PATCH] libnm-util: fix Bridge priority default (rh #1073664)

2014-03-07 Thread Dan Williams
Due to a misread of the kernel code, the bridge priority default
when STP was enabled was 0x80 instead of 0x8000.
---
 libnm-util/nm-setting-bridge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libnm-util/nm-setting-bridge.c b/libnm-util/nm-setting-bridge.c
index 10c6190..32bfa33 100644
--- a/libnm-util/nm-setting-bridge.c
+++ b/libnm-util/nm-setting-bridge.c
@@ -464,15 +464,15 @@ nm_setting_bridge_class_init (NMSettingBridgeClass 
*setting_class)
 (object_class, PROP_PRIORITY,
  g_param_spec_uint (NM_SETTING_BRIDGE_PRIORITY,
 Priority,
 Sets the Spanning Tree Protocol (STP) 
priority 
 for this bridge.  Lower values are 
'better'; the 
 lowest priority bridge will be elected 
the root 
 bridge.,
-0, G_MAXUINT16, 0x80,
+0, G_MAXUINT16, 0x8000,
 G_PARAM_READWRITE | G_PARAM_CONSTRUCT | 
NM_SETTING_PARAM_INFERRABLE));
 
/**
 * NMSettingBridge:forward-delay:
 *
 * The Spanning Tree Protocol (STP) forwarding delay, in seconds.
 *
-- 
1.8.5.3


___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list