Re: [PATCH 0/3] Support for ADSL modems v3
On Fri, May 20, 2011 at 12:30 AM, Dan Williams d...@redhat.com wrote: Great work, I've pushed this to the 'adsl' branch which I just created off git master. Lets keep testing and after 0.9 comes out we'll merge this right into 0.9.2. Any further patches you post can get dumped right into the 'adsl' branch, which I'll try to keep up-to-date with master through periodic merges. Great, thanks :) (I cleaned up a few things; I also made the VPI/VCI properties of the NMSettingAdsl uints since that just makes the validation easier; also memory leak when reading the carrier code where 'path' and 'contents' weren't getting freed) Excellent, I 'm sorry for these mistakes but I don't have much free time, so I sent the patches as soon as I got a working connection, to avoid the case of me becoming MIA for a while and having the patches bitrot. Thanks a lot for fixing the problems :) Thanks again! Thank you for NetworkManager :) Pantelis ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
[PATCH 0/3] Support for ADSL modems v3
This is the third version, with some minor bugfixes. Pantelis Koukousoulas (3): ADSL: Settings and initial scaffolding ADSL: Carrier Handling and PPP support ADSL: Add libnm-glib and nmcli code cli/src/connections.c| 66 - cli/src/devices.c|4 + cli/src/settings.c | 50 cli/src/settings.h |2 + include/NetworkManager.h |3 + introspection/Makefile.am|1 + introspection/nm-device-adsl.xml | 15 + libnm-glib/Makefile.am |6 + libnm-glib/libnm-glib.ver|4 +- libnm-glib/nm-device-adsl.c | 236 +++ libnm-glib/nm-device-adsl.h | 62 libnm-glib/nm-device.c | 10 +- libnm-util/Makefile.am |2 + libnm-util/libnm-util.ver| 12 + libnm-util/nm-connection.c | 25 ++- libnm-util/nm-connection.h |2 + libnm-util/nm-setting-adsl.c | 541 ++ libnm-util/nm-setting-adsl.h | 97 ++ src/Makefile.am |6 + src/nm-device-adsl.c | 596 ++ src/nm-device-adsl.h | 60 src/nm-device.c |8 +- src/nm-udev-manager.c| 49 +++- src/ppp-manager/nm-ppp-manager.c | 31 ++- src/settings/nm-settings.c |2 + 25 files changed, 1870 insertions(+), 20 deletions(-) create mode 100644 introspection/nm-device-adsl.xml create mode 100644 libnm-glib/nm-device-adsl.c create mode 100644 libnm-glib/nm-device-adsl.h create mode 100644 libnm-util/nm-setting-adsl.c create mode 100644 libnm-util/nm-setting-adsl.h create mode 100644 src/nm-device-adsl.c create mode 100644 src/nm-device-adsl.h -- 1.7.4.1 ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
