Re: [Patch][nm-applet] Fix: scope change from system to user will lose VPN secrets
On Wed, 2010-10-20 at 13:21 +0800, cee1 wrote: > Hi all, > > > This patch covers a problem of losing VPN secrets when switching > connection from system scope to user scope, the detailed traceback is > in this > thread: > http://mail.gnome.org/archives/networkmanager-list/2010-October/msg00083.html > > > nm-applet deletes a connection and then calls delete_cb to clear VPN > plugin-specific data in user scope. delete_cb calls > "nm_connection_get_scope" to detect a user scope connection, this is > not correct when updating a connection from system scope to user > scope(nma will set scope to new_scope first). Good catch. Pushed to 0.8.x and git master, thanks! Dan ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
[Patch][nm-applet] Fix: scope change from system to user will lose VPN secrets
Hi all, This patch covers a problem of losing VPN secrets when switching connection from system scope to user scope, the detailed traceback is in this thread: http://mail.gnome.org/archives/networkmanager-list/2010-October/msg00083.html nm-applet deletes a connection and then calls delete_cb to clear VPN plugin-specific data in user scope. delete_cb calls "nm_connection_get_scope" to detect a user scope connection, this is not correct when updating a connection from system scope to user scope(nma will set scope to new_scope first). -- Regards, - cee1 0001-Fix-scope-change-system-user-will-lost-VPN-specific-.patch Description: Binary data ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
