[Patch] Mark devices disabled on suse

[Tambet Ingo]

Hey,

Here's a small patch to mark devices disabled when they're disabled in
yast.

Tambet
Index: ChangeLog
===
RCS file: /cvs/gnome/NetworkManager/ChangeLog,v
retrieving revision 1.866.2.140
diff -u -r1.866.2.140 ChangeLog
--- ChangeLog	27 Nov 2006 21:38:07 -	1.866.2.140
+++ ChangeLog	30 Nov 2006 09:44:58 -
@@ -1,3 +1,8 @@
+2006-11-30  Tambet Ingo  [EMAIL PROTECTED]
+
+	* src/backends/NetworkManagerSuSE.c (nm_system_device_get_system_config):
+	Mark device as disabled when the STARTMODE variable is either 'off' or 'manual'.
+
 2006-11-27  Dan Williams  [EMAIL PROTECTED]
 
 	Patch from Christian Persch [EMAIL PROTECTED]
Index: src/backends/NetworkManagerSuSE.c
===
RCS file: /cvs/gnome/NetworkManager/src/backends/NetworkManagerSuSE.c,v
retrieving revision 1.32.2.25
diff -u -r1.32.2.25 NetworkManagerSuSE.c
--- src/backends/NetworkManagerSuSE.c	8 Nov 2006 09:20:55 -	1.32.2.25
+++ src/backends/NetworkManagerSuSE.c	30 Nov 2006 09:44:58 -
@@ -518,6 +518,17 @@
 		free (buf);
 	}
 
+	if ((buf = svGetValue (file, STARTMODE)))
+	{
+		nm_debug (STARTMODE=%s, buf);
+		if (!strcasecmp (buf, off) || !strcasecmp (buf, manual))
+		{
+			nm_info (System configuration disables device %s, nm_device_get_iface (dev));
+			sys_data-system_disabled = TRUE;
+		}
+		free (buf);
+	}
+
 	if ((buf = svGetValue (file, MTU)))
 	{
 		guint32 mtu;
___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list

Re: [Patch] Mark devices disabled on suse

[Dan Williams]

On Thu, 2006-11-30 at 11:49 +0200, Tambet Ingo wrote:
 Hey,
 
 Here's a small patch to mark devices disabled when they're disabled in
 yast.

Sure; feel free to update the SUSE backend as much as you want.

Dan

 Tambet
 ___
 NetworkManager-list mailing list
 NetworkManager-list@gnome.org
 http://mail.gnome.org/mailman/listinfo/networkmanager-list

___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list

Re: [Patch] Mark devices disabled on suse

[Robert Love]

On Thu, 2006-11-30 at 11:49 +0200, Tambet Ingo wrote:

 Here's a small patch to mark devices disabled when they're disabled in
 yast.

I have one concern about this...people might have various settings as
their STARTMODE from when they used ifup, NetworkManager currently
works, and then they upgrade and one of their devices stops working.

This is specifically an issue with manual, because some users might
have had the wired interface set as auto and the wireless set as
manual.

Note also we have NM_CONTROLLED as a possible option, to allow users to
disable NM for one interface.

Your call, though.

Robert


___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list