[nm-applet][0.8.4][PATCH] trivial: fix possible uninitialized variable usage
Date: Thu, 27 Jan 2011 10:59:37 -0600 […] arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb --sysroot=/oe/build-angstrom-next/angstrom-dev/s ysroots/armv7a-angstrom-linux-gnueabi -DHAVE_CONFIG_H -I. -I.. -pthread -DORBIT2=1 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/incl ude/dbus-1.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/dbus-1.0/include -I/oe/build-angstrom-next/angstrom-dev/sysro ots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/include -I/home/paul /oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/NetworkManager -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-lin ux-gnueabi/usr/include/libnm-glib -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gtk-2.0 -I/oe/build-angstrom-next/an gstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/gtk-2.0/include -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/atk-1. 0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/cairo -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstro m-linux-gnueabi/usr/include/pango-1.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/pixman-1 -I/oe/build-angstrom-ne xt/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/freetype2 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/lib png12 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gconf/2 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-a ngstrom-linux-gnueabi/usr/include/orbit-2.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gnome-keyring-1 -DICONDIR=\/usr /share/icons\ -DUIDIR=\/usr/share/nm-applet\ -DBINDIR=\/usr/bin\ -DSYSCONFDIR=\/etc\ -DLIBEXECDIR=\/usr/libexec\ -DAUTOSTARTDIR=\/etc/xdg/autostart\ -DVPN_NAM E_FILES_DIR=\/etc/NetworkManager/VPN\ -DNMALOCALEDIR=\/usr/share/locale\ -DG_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DATK_DISABLE_DEPRECATED -DATK_DISABLE_SINGLE_INC LUDES -DPANGO_DISABLE_DEPRECATED -DPANGO_DISABLE_SINGLE_INCLUDES -DGDK_DISABLE_DEPRECATED -DGDK_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_SINGLE_ INCLUDES -DGTK_DISABLE_DEPRECATED -DGTK_DISABLE_SINGLE_INCLUDES -DGCONF_DISABLE_DEPRECATED -DGCONF_DISABLE_SINGLE_INCLUDES -DBONOBO_DISABLE_DEPRECATED -DBONOBO_DISABLE_SINGLE_INCLU DES -DBONOBO_UI_DISABLE_DEPRECATED -DBONOBO_UI_DISABLE_SINGLE_INCLUDES -DGNOME_DISABLE_DEPRECATED -DGNOME_DISABLE_SINGLE_INCLUDES -DLIBGLADE_DISABLE_DEPRECATED -DLIBGLADE_DISABLE_S INGLE_INCLUDES -DVTE_DISABLE_DEPRECATED -DVTE_DISABLE_SINGLE_INCLUDES -DGNOME_VFS_DISABLE_DEPRECATED -DGNOME_VFS_DISABLE_SINGLE_INCLUDES -DWNCK_DISABLE_DEPRECATED -DWNCK_DISABLE_SI NGLE_INCLUDES -DLIBSOUP_DISABLE_DEPRECATED -DLIBSOUP_DISABLE_SINGLE_INCLUDES -I../src/marshallers -I../src/utils -I../src/gconf-helpers -I../src/wireless-security -Wall -Werror - std=gnu89 -fexpensive-optimizations -fomit-frame-pointer -frename-registers -O2 -ggdb2 -Wshadow -Wmissing-declarations -Wmissing-prototypes -Wdeclaration-after-statement -Wfloat-eq ual -Wno-unused-parameter -Wno-sign-compare -fno-strict-aliasing -MT nm_applet-applet-dialogs.o -MD -MP -MF .deps/nm_applet-applet-dialogs.Tpo -c -o nm_applet-applet-dialogs.o `tes t -f 'applet-dialogs.c' || echo './'`applet-dialogs.c […] cc1: warnings being treated as errors applet-dialogs.c: In function 'applet_info_dialog_show': applet-dialogs.c:331:22: error: 'method' may be used uninitialized in this function make[3]: *** [nm_applet-applet-dialogs.o] Error 1 --- Unfortunately this patch is only in master and was not applied to 0.8.4 so that the build fails with the above error message [1]. Therefore in OpenEmbedded we need to pass `--enable-more-warings=no` to `configure`. This is a cherry-pick from master to a branch based on the tag 0.8.4. Maybe a 0.8.4.1 release is planned. --- src/applet-dialogs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/applet-dialogs.c b/src/applet-dialogs.c index 42f3d2b..5965a75 100644 --- a/src/applet-dialogs.c +++ b/src/applet-dialogs.c @@ -328,7 +328,7 @@ info_dialog_add_page (GtkNotebook *notebook, GtkTable *table; guint32 speed = 0; char *str; - const char *iface, *method; + const char *iface, *method = NULL; NMIP4Config
Re: [nm-applet][0.8.4][PATCH] trivial: fix possible uninitialized variable usage
On Mon, 2011-05-09 at 13:15 +0200, Paul Menzel wrote: Date: Thu, 27 Jan 2011 10:59:37 -0600 […] arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb --sysroot=/oe/build-angstrom-next/angstrom-dev/s ysroots/armv7a-angstrom-linux-gnueabi -DHAVE_CONFIG_H -I. -I.. -pthread -DORBIT2=1 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/incl ude/dbus-1.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/dbus-1.0/include -I/oe/build-angstrom-next/angstrom-dev/sysro ots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/include -I/home/paul /oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/NetworkManager -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-lin ux-gnueabi/usr/include/libnm-glib -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gtk-2.0 -I/oe/build-angstrom-next/an gstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/gtk-2.0/include -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/atk-1. 0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/cairo -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstro m-linux-gnueabi/usr/include/pango-1.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/pixman-1 -I/oe/build-angstrom-ne xt/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/freetype2 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/lib png12 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gconf/2 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-a ngstrom-linux-gnueabi/usr/include/orbit-2.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gnome-keyring-1 -DICONDIR=\/usr /share/icons\ -DUIDIR=\/usr/share/nm-applet\ -DBINDIR=\/usr/bin\ -DSYSCONFDIR=\/etc\ -DLIBEXECDIR=\/usr/libexec\ -DAUTOSTARTDIR=\/etc/xdg/autostart\ -DVPN_NAM E_FILES_DIR=\/etc/NetworkManager/VPN\ -DNMALOCALEDIR=\/usr/share/locale\ -DG_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DATK_DISABLE_DEPRECATED -DATK_DISABLE_SINGLE_INC LUDES -DPANGO_DISABLE_DEPRECATED -DPANGO_DISABLE_SINGLE_INCLUDES -DGDK_DISABLE_DEPRECATED -DGDK_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_SINGLE_ INCLUDES -DGTK_DISABLE_DEPRECATED -DGTK_DISABLE_SINGLE_INCLUDES -DGCONF_DISABLE_DEPRECATED -DGCONF_DISABLE_SINGLE_INCLUDES -DBONOBO_DISABLE_DEPRECATED -DBONOBO_DISABLE_SINGLE_INCLU DES -DBONOBO_UI_DISABLE_DEPRECATED -DBONOBO_UI_DISABLE_SINGLE_INCLUDES -DGNOME_DISABLE_DEPRECATED -DGNOME_DISABLE_SINGLE_INCLUDES -DLIBGLADE_DISABLE_DEPRECATED -DLIBGLADE_DISABLE_S INGLE_INCLUDES -DVTE_DISABLE_DEPRECATED -DVTE_DISABLE_SINGLE_INCLUDES -DGNOME_VFS_DISABLE_DEPRECATED -DGNOME_VFS_DISABLE_SINGLE_INCLUDES -DWNCK_DISABLE_DEPRECATED -DWNCK_DISABLE_SI NGLE_INCLUDES -DLIBSOUP_DISABLE_DEPRECATED -DLIBSOUP_DISABLE_SINGLE_INCLUDES -I../src/marshallers -I../src/utils -I../src/gconf-helpers -I../src/wireless-security -Wall -Werror - std=gnu89 -fexpensive-optimizations -fomit-frame-pointer -frename-registers -O2 -ggdb2 -Wshadow -Wmissing-declarations -Wmissing-prototypes -Wdeclaration-after-statement -Wfloat-eq ual -Wno-unused-parameter -Wno-sign-compare -fno-strict-aliasing -MT nm_applet-applet-dialogs.o -MD -MP -MF .deps/nm_applet-applet-dialogs.Tpo -c -o nm_applet-applet-dialogs.o `tes t -f 'applet-dialogs.c' || echo './'`applet-dialogs.c […] cc1: warnings being treated as errors applet-dialogs.c: In function 'applet_info_dialog_show': applet-dialogs.c:331:22: error: 'method' may be used uninitialized in this function make[3]: *** [nm_applet-applet-dialogs.o] Error 1 --- Unfortunately this patch is only in master and was not applied to 0.8.4 so that the build fails with the above error message [1]. Therefore in OpenEmbedded we need to pass `--enable-more-warings=no` to `configure`. This is a cherry-pick from master to a branch based on the tag 0.8.4. Yeah, that got fixed in commit bbe547f7985498e0bc353ccd2e8e6f9a4a89249b right after 0.8.4 was released; we probably should do a 0.8.6 soon just for kicks anyway. Not a bad idea to speed up releases and get good fixes out sooner. Dan ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [nm-applet][0.8.4][PATCH] trivial: fix possible uninitialized variable usage
Am Montag, den 09.05.2011, 13:17 -0500 schrieb Dan Williams: On Mon, 2011-05-09 at 13:15 +0200, Paul Menzel wrote: Date: Thu, 27 Jan 2011 10:59:37 -0600 […] arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb --sysroot=/oe/build-angstrom-next/angstrom-dev/s ysroots/armv7a-angstrom-linux-gnueabi -DHAVE_CONFIG_H -I. -I.. -pthread -DORBIT2=1 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/incl ude/dbus-1.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/dbus-1.0/include -I/oe/build-angstrom-next/angstrom-dev/sysro ots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/include -I/home/paul /oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/NetworkManager -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-lin ux-gnueabi/usr/include/libnm-glib -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gtk-2.0 -I/oe/build-angstrom-next/an gstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/gtk-2.0/include -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/atk-1. 0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/cairo -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstro m-linux-gnueabi/usr/include/pango-1.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/pixman-1 -I/oe/build-angstrom-ne xt/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/freetype2 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/lib png12 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gconf/2 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-a ngstrom-linux-gnueabi/usr/include/orbit-2.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gnome-keyring-1 -DICONDIR=\/usr /share/icons\ -DUIDIR=\/usr/share/nm-applet\ -DBINDIR=\/usr/bin\ -DSYSCONFDIR=\/etc\ -DLIBEXECDIR=\/usr/libexec\ -DAUTOSTARTDIR=\/etc/xdg/autostart\ -DVPN_NAM E_FILES_DIR=\/etc/NetworkManager/VPN\ -DNMALOCALEDIR=\/usr/share/locale\ -DG_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DATK_DISABLE_DEPRECATED -DATK_DISABLE_SINGLE_INC LUDES -DPANGO_DISABLE_DEPRECATED -DPANGO_DISABLE_SINGLE_INCLUDES -DGDK_DISABLE_DEPRECATED -DGDK_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_SINGLE_ INCLUDES -DGTK_DISABLE_DEPRECATED -DGTK_DISABLE_SINGLE_INCLUDES -DGCONF_DISABLE_DEPRECATED -DGCONF_DISABLE_SINGLE_INCLUDES -DBONOBO_DISABLE_DEPRECATED -DBONOBO_DISABLE_SINGLE_INCLU DES -DBONOBO_UI_DISABLE_DEPRECATED -DBONOBO_UI_DISABLE_SINGLE_INCLUDES -DGNOME_DISABLE_DEPRECATED -DGNOME_DISABLE_SINGLE_INCLUDES -DLIBGLADE_DISABLE_DEPRECATED -DLIBGLADE_DISABLE_S INGLE_INCLUDES -DVTE_DISABLE_DEPRECATED -DVTE_DISABLE_SINGLE_INCLUDES -DGNOME_VFS_DISABLE_DEPRECATED -DGNOME_VFS_DISABLE_SINGLE_INCLUDES -DWNCK_DISABLE_DEPRECATED -DWNCK_DISABLE_SI NGLE_INCLUDES -DLIBSOUP_DISABLE_DEPRECATED -DLIBSOUP_DISABLE_SINGLE_INCLUDES -I../src/marshallers -I../src/utils -I../src/gconf-helpers -I../src/wireless-security -Wall -Werror - std=gnu89 -fexpensive-optimizations -fomit-frame-pointer -frename-registers -O2 -ggdb2 -Wshadow -Wmissing-declarations -Wmissing-prototypes -Wdeclaration-after-statement -Wfloat-eq ual -Wno-unused-parameter -Wno-sign-compare -fno-strict-aliasing -MT nm_applet-applet-dialogs.o -MD -MP -MF .deps/nm_applet-applet-dialogs.Tpo -c -o nm_applet-applet-dialogs.o `tes t -f 'applet-dialogs.c' || echo './'`applet-dialogs.c […] cc1: warnings being treated as errors applet-dialogs.c: In function 'applet_info_dialog_show': applet-dialogs.c:331:22: error: 'method' may be used uninitialized in this function make[3]: *** [nm_applet-applet-dialogs.o] Error 1 --- Unfortunately this patch is only in master and was not applied to 0.8.4 so that the build fails with the above error message [1]. Therefore in OpenEmbedded we need to pass `--enable-more-warings=no` to `configure`. This is a cherry-pick from master to a branch based on the tag 0.8.4. Yeah, that got fixed in commit bbe547f7985498e0bc353ccd2e8e6f9a4a89249b right after 0.8.4 was released; Strange. I cherry picked commit cc472cea1021dee90714703380a79e326aa0e681 Author: Dan Williams d...@redhat.com Date: Thu Jan 27 10:59:37 2011 -0600 trivial: fix possible
Re: [nm-applet][0.8.4][PATCH] trivial: fix possible uninitialized variable usage
On Mon, 2011-05-09 at 21:50 +0200, Paul Menzel wrote: Am Montag, den 09.05.2011, 13:17 -0500 schrieb Dan Williams: On Mon, 2011-05-09 at 13:15 +0200, Paul Menzel wrote: Date: Thu, 27 Jan 2011 10:59:37 -0600 […] arm-angstrom-linux-gnueabi-gcc -march=armv7-a -mtune=cortex-a8 -mfpu=neon -mfloat-abi=softfp -mthumb-interwork -mno-thumb --sysroot=/oe/build-angstrom-next/angstrom-dev/s ysroots/armv7a-angstrom-linux-gnueabi -DHAVE_CONFIG_H -I. -I.. -pthread -DORBIT2=1 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/incl ude/dbus-1.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/dbus-1.0/include -I/oe/build-angstrom-next/angstrom-dev/sysro ots/armv7a-angstrom-linux-gnueabi/usr/include/glib-2.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/glib-2.0/include -I/home/paul /oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/NetworkManager -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-lin ux-gnueabi/usr/include/libnm-glib -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gtk-2.0 -I/oe/build-angstrom-next/an gstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/lib/gtk-2.0/include -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/atk-1. 0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/cairo -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstro m-linux-gnueabi/usr/include/pango-1.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/pixman-1 -I/oe/build-angstrom-ne xt/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/freetype2 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/lib png12 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gconf/2 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-a ngstrom-linux-gnueabi/usr/include/orbit-2.0 -I/oe/build-angstrom-next/angstrom-dev/sysroots/armv7a-angstrom-linux-gnueabi/usr/include/gnome-keyring-1 -DICONDIR=\/usr /share/icons\ -DUIDIR=\/usr/share/nm-applet\ -DBINDIR=\/usr/bin\ -DSYSCONFDIR=\/etc\ -DLIBEXECDIR=\/usr/libexec\ -DAUTOSTARTDIR=\/etc/xdg/autostart\ -DVPN_NAM E_FILES_DIR=\/etc/NetworkManager/VPN\ -DNMALOCALEDIR=\/usr/share/locale\ -DG_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DATK_DISABLE_DEPRECATED -DATK_DISABLE_SINGLE_INC LUDES -DPANGO_DISABLE_DEPRECATED -DPANGO_DISABLE_SINGLE_INCLUDES -DGDK_DISABLE_DEPRECATED -DGDK_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_SINGLE_ INCLUDES -DGTK_DISABLE_DEPRECATED -DGTK_DISABLE_SINGLE_INCLUDES -DGCONF_DISABLE_DEPRECATED -DGCONF_DISABLE_SINGLE_INCLUDES -DBONOBO_DISABLE_DEPRECATED -DBONOBO_DISABLE_SINGLE_INCLU DES -DBONOBO_UI_DISABLE_DEPRECATED -DBONOBO_UI_DISABLE_SINGLE_INCLUDES -DGNOME_DISABLE_DEPRECATED -DGNOME_DISABLE_SINGLE_INCLUDES -DLIBGLADE_DISABLE_DEPRECATED -DLIBGLADE_DISABLE_S INGLE_INCLUDES -DVTE_DISABLE_DEPRECATED -DVTE_DISABLE_SINGLE_INCLUDES -DGNOME_VFS_DISABLE_DEPRECATED -DGNOME_VFS_DISABLE_SINGLE_INCLUDES -DWNCK_DISABLE_DEPRECATED -DWNCK_DISABLE_SI NGLE_INCLUDES -DLIBSOUP_DISABLE_DEPRECATED -DLIBSOUP_DISABLE_SINGLE_INCLUDES -I../src/marshallers -I../src/utils -I../src/gconf-helpers -I../src/wireless-security -Wall -Werror - std=gnu89 -fexpensive-optimizations -fomit-frame-pointer -frename-registers -O2 -ggdb2 -Wshadow -Wmissing-declarations -Wmissing-prototypes -Wdeclaration-after-statement -Wfloat-eq ual -Wno-unused-parameter -Wno-sign-compare -fno-strict-aliasing -MT nm_applet-applet-dialogs.o -MD -MP -MF .deps/nm_applet-applet-dialogs.Tpo -c -o nm_applet-applet-dialogs.o `tes t -f 'applet-dialogs.c' || echo './'`applet-dialogs.c […] cc1: warnings being treated as errors applet-dialogs.c: In function 'applet_info_dialog_show': applet-dialogs.c:331:22: error: 'method' may be used uninitialized in this function make[3]: *** [nm_applet-applet-dialogs.o] Error 1 --- Unfortunately this patch is only in master and was not applied to 0.8.4 so that the build fails with the above error message [1]. Therefore in OpenEmbedded we need to pass `--enable-more-warings=no` to `configure`. This is a cherry-pick from master to a branch based on the tag 0.8.4. Yeah, that got fixed in commit bbe547f7985498e0bc353ccd2e8e6f9a4a89249b right after 0.8.4 was released; Strange. I cherry picked commit cc472cea1021dee90714703380a79e326aa0e681 Author: Dan Williams d...@redhat.com
Re: [nm-applet][0.8.4][PATCH] trivial: fix possible uninitialized variable usage
Am Montag, den 09.05.2011, 15:08 -0500 schrieb Dan Williams: On Mon, 2011-05-09 at 21:50 +0200, Paul Menzel wrote: Am Montag, den 09.05.2011, 13:17 -0500 schrieb Dan Williams: […] Yeah, that got fixed in commit bbe547f7985498e0bc353ccd2e8e6f9a4a89249b right after 0.8.4 was released; Strange. I cherry picked commit cc472cea1021dee90714703380a79e326aa0e681 Author: Dan Williams d...@redhat.com Date: Thu Jan 27 10:59:37 2011 -0600 trivial: fix possible uninitialized variable usage which seems to address the exact same issues. Do you know why I cannot find the commit you referenced in any branch? $ git branch --contains cc472cea1021dee90714703380a79e326aa0e681 master $ git branch --contains bbe547f7985498e0bc353ccd2e8e6f9a4a89249b $ git --version git version 1.7.5.1 It's on the NMA_0_8 branch, which is the stable 0.8.x series branch. Do you have that branched locally? That could be the issue though I don't know why; http://git.gnome.org/browse/network-manager-applet/commit/?h=NMA_0_8id=bbe547f7985498e0bc353ccd2e8e6f9a4a89249b You are right, I did not have a local checkout. `-a` comes to the rescue. $ git branch -a --contains bbe547f7985498e0bc353ccd2e8e6f9a4a89249b remotes/origin/NMA_0_8 Thanks, Paul signature.asc Description: This is a digitally signed message part ___ networkmanager-list mailing list networkmanager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
