Re: Latest Fedora 7 NM can't disable wireless

2007-06-27 Thread Dan Williams
On Tue, 2007-06-26 at 22:08 +, Matthew Saltzman wrote:
 On Tue, 2007-06-26 at 23:42 +0200, dragoran wrote:
  sorry attached the wrong patch.
  this is the working one (also set the variable to true in this case)
 
 Seems to work here (Dan's original one didn't).

Ah, right.  Ok, will apply and push the update, thanks.

Dan


___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-27 Thread Dan Williams
On Wed, 2007-06-27 at 09:09 -0400, Dan Williams wrote:
 On Tue, 2007-06-26 at 22:08 +, Matthew Saltzman wrote:
  On Tue, 2007-06-26 at 23:42 +0200, dragoran wrote:
   sorry attached the wrong patch.
   this is the working one (also set the variable to true in this case)
  
  Seems to work here (Dan's original one didn't).
 
 Ah, right.  Ok, will apply and push the update, thanks.

Can you guys try the RPMs here?

http://koji.fedoraproject.org/packages/NetworkManager/0.6.5/7.fc7/

It's got a slightly modified fix from what dragoran posted.

Thanks,
Dan


___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-27 Thread dragoran

On 6/27/07, Dan Williams [EMAIL PROTECTED] wrote:


On Wed, 2007-06-27 at 09:09 -0400, Dan Williams wrote:
 On Tue, 2007-06-26 at 22:08 +, Matthew Saltzman wrote:
  On Tue, 2007-06-26 at 23:42 +0200, dragoran wrote:
   sorry attached the wrong patch.
   this is the working one (also set the variable to true in this case)
 
  Seems to work here (Dan's original one didn't).

 Ah, right.  Ok, will apply and push the update, thanks.

Can you guys try the RPMs here?

http://koji.fedoraproject.org/packages/NetworkManager/0.6.5/7.fc7/

It's got a slightly modified fix from what dragoran posted.



works fine thx.
___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-27 Thread Matthew Saltzman
On Wed, 2007-06-27 at 19:08 +0200, dragoran wrote:
 
 
 On 6/27/07, Dan Williams [EMAIL PROTECTED] wrote:
 On Wed, 2007-06-27 at 09:09 -0400, Dan Williams wrote:
  On Tue, 2007-06-26 at 22:08 +, Matthew Saltzman wrote:
   On Tue, 2007-06-26 at 23:42 +0200, dragoran wrote:
sorry attached the wrong patch. 
this is the working one (also set the variable to true
 in this case)
  
   Seems to work here (Dan's original one didn't).
 
  Ah, right.  Ok, will apply and push the update, thanks. 
 
 Can you guys try the RPMs here?
 
 http://koji.fedoraproject.org/packages/NetworkManager/0.6.5/7.fc7/
 
 It's got a slightly modified fix from what dragoran posted.
 
 works fine thx. 

Seems OK here, too.

 
 
 
 

___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread Matthew Saltzman
I updated to NetworkManager-0.6.5-6.fc7 last night.  Now, when I
right-click on the nm-applet icon, the Enable Wireless checkbox is
greyed out and I can't set or unset the check mark.

This was not the case with the previous version.


___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread Antonio Bulgheroni

Dear Matthew,
I'm using F7 and I've updated this morning to
NetworkManager-0.6.5-6.fc7and on my KNetworkManager tray icon, I still
have the ability to switch off
the wireless.

Which applet are you using?

cheers,

Antonio

--
Antonio Bulgheroni, PhD

Computers have a lot in common with air conditioners:
Once you open WINDOWS, they stop working properly.

On 6/26/07, Matthew Saltzman [EMAIL PROTECTED] wrote:


I updated to NetworkManager-0.6.5-6.fc7 last night.  Now, when I
right-click on the nm-applet icon, the Enable Wireless checkbox is
greyed out and I can't set or unset the check mark.

This was not the case with the previous version.


___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list

___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread Matthew Saltzman
On Tue, 2007-06-26 at 18:56 +0200, Antonio Bulgheroni wrote:
 Dear Matthew,
  I'm using F7 and I've updated this morning to
 NetworkManager-0.6.5-6.fc7 and on my KNetworkManager tray icon, I
 still have the ability to switch off the wireless.
 
 Which applet are you using? 

The GNOME nm-applet.

 
 cheers,
 
 Antonio
 
 -- 
 Antonio Bulgheroni, PhD
 
 Computers have a lot in common with air conditioners:
 Once you open WINDOWS, they stop working properly. 
 
 On 6/26/07, Matthew Saltzman [EMAIL PROTECTED] wrote:
 I updated to NetworkManager-0.6.5-6.fc7 last night.  Now, when
 I
 right-click on the nm-applet icon, the Enable Wireless
 checkbox is
 greyed out and I can't set or unset the check mark.
 
 This was not the case with the previous version. 
 
 
 ___
 NetworkManager-list mailing list
 NetworkManager-list@gnome.org
 http://mail.gnome.org/mailman/listinfo/networkmanager-list
 

___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread Dan Williams
On Tue, 2007-06-26 at 12:45 -0400, Matthew Saltzman wrote:
 I updated to NetworkManager-0.6.5-6.fc7 last night.  Now, when I
 right-click on the nm-applet icon, the Enable Wireless checkbox is
 greyed out and I can't set or unset the check mark.
 
 This was not the case with the previous version.

Is your wireless rfkilled?  NM will gray out the enable/disable wireless
checkbox if it thinks that the hardware has killed the radio.  Can you
do a dump of 'lshal' and grab the section for killswitch, if any?

Dan


___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread dragoran

On 6/26/07, Dan Williams [EMAIL PROTECTED] wrote:


On Tue, 2007-06-26 at 12:45 -0400, Matthew Saltzman wrote:
 I updated to NetworkManager-0.6.5-6.fc7 last night.  Now, when I
 right-click on the nm-applet icon, the Enable Wireless checkbox is
 greyed out and I can't set or unset the check mark.

 This was not the case with the previous version.

Is your wireless rfkilled?  NM will gray out the enable/disable wireless
checkbox if it thinks that the hardware has killed the radio.  Can you
do a dump of 'lshal' and grab the section for killswitch, if any?



its the same here it seems if the rfkill is not supported in hal  nm greyes
this option out.

Dan



___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list

___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread Matthew Saltzman
On Tue, 2007-06-26 at 13:59 -0400, Dan Williams wrote:
 On Tue, 2007-06-26 at 12:45 -0400, Matthew Saltzman wrote:
  I updated to NetworkManager-0.6.5-6.fc7 last night.  Now, when I
  right-click on the nm-applet icon, the Enable Wireless checkbox is
  greyed out and I can't set or unset the check mark.
  
  This was not the case with the previous version.
 
 Is your wireless rfkilled?  NM will gray out the enable/disable wireless
 checkbox if it thinks that the hardware has killed the radio.  Can you
 do a dump of 'lshal' and grab the section for killswitch, if any?

My T41 doesn't have a physical killswitch, and there is no killswitch
string in lshal.  The relevant parts AFAICT are (MAC addresses
censored):

udi = '/org/freedesktop/Hal/devices/pci_8086_4220'
  info.bus = 'pci'  (string)
  info.linux.driver = 'ipw2200'  (string)
  info.parent = '/org/freedesktop/Hal/devices/pci_8086_2448'  (string)
  info.product = 'PRO/Wireless 2200BG Network Connection'  (string)
  info.subsystem = 'pci'  (string)
  info.udi = '/org/freedesktop/Hal/devices/pci_8086_4220'  (string)
  info.vendor = 'Intel Corporation'  (string)
  linux.hotplug_type = 2  (0x2)  (int)
  linux.subsystem = 'pci'  (string)
  linux.sysfs_path = '/sys/devices/pci:00/:00:1e.0/:02:02.0'
(strin
g)
  pci.device_class = 2  (0x2)  (int)
  pci.device_protocol = 0  (0x0)  (int)
  pci.device_subclass = 128  (0x80)  (int)
  pci.linux.sysfs_path =
'/sys/devices/pci:00/:00:1e.0/:02:02.0'  (s
tring)
  pci.product = 'PRO/Wireless 2200BG Network Connection'  (string)
  pci.product_id = 16928  (0x4220)  (int)
  pci.subsys_product_id = 10001  (0x2711)  (int)
  pci.subsys_vendor = 'Intel Corporation'  (string)
  pci.subsys_vendor_id = 32902  (0x8086)  (int)
  pci.vendor = 'Intel Corporation'  (string)
  pci.vendor_id = 32902  (0x8086)  (int)

udi = '/org/freedesktop/Hal/devices/net_xx_xx_xx_xx_xx_xx'
  info.capabilities = {'net', 'net.80211'} (string list)
  info.category = 'net.80211'  (string)
  info.parent = '/org/freedesktop/Hal/devices/pci_8086_4220'  (string)
  info.product = 'WLAN Interface'  (string)
  info.udi = '/org/freedesktop/Hal/devices/net_xx_xx_xx_xx_xx_xx'
(string)
  linux.hotplug_type = 2  (0x2)  (int)
  linux.subsystem = 'net'  (string)
  linux.sysfs_path = '/sys/class/net/eth1'  (string)
  net.80211.mac_address = xx  (0x)  (uint64)
  net.address = '00:13:ce:85:d3:46'  (string)
  net.arp_proto_hw_id = 1  (0x1)  (int)
  net.interface = 'eth1'  (string)
  net.linux.ifindex = 7  (0x7)  (int)
  net.originating_device = '/org/freedesktop/Hal/devices/pci_8086_4220'
(string
)
  net.physical_device = '/org/freedesktop/Hal/devices/pci_8086_4220'
(string)

 
 Dan
 
 

___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread Jon Escombe
Dan Williams wrote:
 On Tue, 2007-06-26 at 12:45 -0400, Matthew Saltzman wrote:
   
 I updated to NetworkManager-0.6.5-6.fc7 last night.  Now, when I
 right-click on the nm-applet icon, the Enable Wireless checkbox is
 greyed out and I can't set or unset the check mark.

 This was not the case with the previous version.
 

 Is your wireless rfkilled?  NM will gray out the enable/disable wireless
 checkbox if it thinks that the hardware has killed the radio.  Can you
 do a dump of 'lshal' and grab the section for killswitch, if any?

 Dan

   

Just tried the same here with Fedora7, Lenovo T60, and ipw3945. Flipping 
the kill switch grays out the checkbox, but it remains gray once 
re-enabled and re-connected

Regards,
Jon.
___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread Dan Williams
On Tue, 2007-06-26 at 20:51 +0200, dragoran wrote:
 
 
 On 6/26/07, Dan Williams [EMAIL PROTECTED] wrote:
 On Tue, 2007-06-26 at 12:45 -0400, Matthew Saltzman wrote:
  I updated to NetworkManager-0.6.5-6.fc7 last night.  Now,
 when I
  right-click on the nm-applet icon, the Enable Wireless
 checkbox is
  greyed out and I can't set or unset the check mark. 
 
  This was not the case with the previous version.
 
 Is your wireless rfkilled?  NM will gray out the
 enable/disable wireless
 checkbox if it thinks that the hardware has killed the
 radio.  Can you
 do a dump of 'lshal' and grab the section for killswitch, if
 any?
 
 its the same here it seems if the rfkill is not supported in hal  nm
 greyes this option out. 

Eek, that's not right.

Dan

 
 Dan
 
 
 ___
 NetworkManager-list mailing list
 NetworkManager-list@gnome.org
 http://mail.gnome.org/mailman/listinfo/networkmanager-list
 

___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread dragoran

On 6/26/07, Dan Williams [EMAIL PROTECTED] wrote:


On Tue, 2007-06-26 at 20:51 +0200, dragoran wrote:


 On 6/26/07, Dan Williams [EMAIL PROTECTED] wrote:
 On Tue, 2007-06-26 at 12:45 -0400, Matthew Saltzman wrote:
  I updated to NetworkManager-0.6.5-6.fc7 last night.  Now,
 when I
  right-click on the nm-applet icon, the Enable Wireless
 checkbox is
  greyed out and I can't set or unset the check mark.
 
  This was not the case with the previous version.

 Is your wireless rfkilled?  NM will gray out the
 enable/disable wireless
 checkbox if it thinks that the hardware has killed the
 radio.  Can you
 do a dump of 'lshal' and grab the section for killswitch, if
 any?

 its the same here it seems if the rfkill is not supported in hal  nm
 greyes this option out.

Eek, that's not right.



ok, so it must be some other bug than (its always greyed out here; using
ipw3945). If you have any idea how to debug this or if you need any logs
fell free to ask ;)
___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread Dan Williams
On Tue, 2007-06-26 at 16:51 -0400, Dan Williams wrote:
 On Tue, 2007-06-26 at 20:51 +0200, dragoran wrote:
  
  
  On 6/26/07, Dan Williams [EMAIL PROTECTED] wrote:
  On Tue, 2007-06-26 at 12:45 -0400, Matthew Saltzman wrote:
   I updated to NetworkManager-0.6.5-6.fc7 last night.  Now,
  when I
   right-click on the nm-applet icon, the Enable Wireless
  checkbox is
   greyed out and I can't set or unset the check mark. 
  
   This was not the case with the previous version.
  
  Is your wireless rfkilled?  NM will gray out the
  enable/disable wireless
  checkbox if it thinks that the hardware has killed the
  radio.  Can you
  do a dump of 'lshal' and grab the section for killswitch, if
  any?
  
  its the same here it seems if the rfkill is not supported in hal  nm
  greyes this option out. 
 
 Eek, that's not right.

dragoran, Matthew, can you try the following SRPM and see if it works in
both cases (a) where there is no killswitch detected by HAL, and (b)
where there _is_ a killswitch detected by HAL?

http://people.redhat.com/dcbw/NetworkManager/NetworkManager-0.6.5-6.0.1.fc7.src.rpm

As root, rpm -Uhv that rpm.  cd into /usr/src/redhat/SPECS, then run:

rpmbuild -ba --target i386 NetworkManager.spec

(replace i386 with x86_64 if that's what you have)

If you have missing build dependencies, install those with yum.  The
resulting RPM will be in /usr/src/redhat/RPMS/i386, install the
NetworkManager one and see if it fixes the issue.  Let me know if you've
got questions.

The small fix would be that if you don't have killswitches, mark the
hardware RF as enabled.

Thanks,
Dan


___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread dragoran

On 6/26/07, Dan Williams [EMAIL PROTECTED] wrote:


On Tue, 2007-06-26 at 16:51 -0400, Dan Williams wrote:
 On Tue, 2007-06-26 at 20:51 +0200, dragoran wrote:
 
 
  On 6/26/07, Dan Williams [EMAIL PROTECTED]  wrote:
  On Tue, 2007-06-26 at 12:45 -0400, Matthew Saltzman wrote:
   I updated to NetworkManager-0.6.5-6.fc7 last night.  Now,
  when I
   right-click on the nm-applet icon, the Enable Wireless
  checkbox is
   greyed out and I can't set or unset the check mark.
  
   This was not the case with the previous version.
 
  Is your wireless rfkilled?  NM will gray out the
  enable/disable wireless
  checkbox if it thinks that the hardware has killed the
  radio.  Can you
  do a dump of 'lshal' and grab the section for killswitch, if
  any?
 
  its the same here it seems if the rfkill is not supported in hal  nm
  greyes this option out.

 Eek, that's not right.

dragoran, Matthew, can you try the following SRPM and see if it works in
both cases (a) where there is no killswitch detected by HAL, and (b)
where there _is_ a killswitch detected by HAL?


http://people.redhat.com/dcbw/NetworkManager/NetworkManager-0.6.5-6.0.1.fc7.src.rpm

As root, rpm -Uhv that rpm.  cd into /usr/src/redhat/SPECS, then run:

rpmbuild -ba --target i386 NetworkManager.spec

(replace i386 with x86_64 if that's what you have)

If you have missing build dependencies, install those with yum.  The
resulting RPM will be in /usr/src/redhat/RPMS/i386, install the
NetworkManager one and see if it fixes the issue.  Let me know if you've
got questions.

The small fix would be that if you don't have killswitches, mark the
hardware RF as enabled.



does not work here... seems to be the same.
ps:
1) the patch does not apply with -p1 changed to p0 in the spec file to get
it working
2) building as root isn't a good idea ;)

Thanks,

Dan



___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread dragoran

ok the attached patch fixes it for me.
when num_udis is 0 we still enter the loop (first iteration) which seems to
cause this problem.
skipping it by returning if num_udis = 0 fixes it.
diff -ru NetworkManager-0.6.5.orig/src/NetworkManager.c NetworkManager-0.6.5/src/NetworkManager.c
--- NetworkManager-0.6.5.orig/src/NetworkManager.c	2007-06-21 14:00:30.0 +0200
+++ NetworkManager-0.6.5/src/NetworkManager.c	2007-06-26 23:29:17.0 +0200
@@ -534,7 +534,8 @@
 	udis = libhal_find_device_by_capability (data-hal_ctx, killswitch, num_udis, error);
 	if (!udis)
 		return;
-
+	if(!num_udis)
+		return;
 	if (dbus_error_is_set (error)) {
 		nm_warning(Could not find killswitch devices: %s, error.message);
 		dbus_error_free (error);
___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread dragoran

sorry attached the wrong patch.
this is the working one (also set the variable to true in this case)
diff -ru NetworkManager-0.6.5.orig/src/NetworkManager.c NetworkManager-0.6.5/src/NetworkManager.c
--- NetworkManager-0.6.5.orig/src/NetworkManager.c	2007-06-21 14:00:30.0 +0200
+++ NetworkManager-0.6.5/src/NetworkManager.c	2007-06-26 23:35:29.0 +0200
@@ -532,8 +532,11 @@
 
 	dbus_error_init (error);
 	udis = libhal_find_device_by_capability (data-hal_ctx, killswitch, num_udis, error);
-	if (!udis)
+
+	if (!udis || !num_udis) {
+		data-hw_rf_enabled = TRUE; 
 		return;
+	}
 
 	if (dbus_error_is_set (error)) {
 		nm_warning(Could not find killswitch devices: %s, error.message);
___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: Latest Fedora 7 NM can't disable wireless

2007-06-26 Thread Matthew Saltzman
On Tue, 2007-06-26 at 23:42 +0200, dragoran wrote:
 sorry attached the wrong patch.
 this is the working one (also set the variable to true in this case)

Seems to work here (Dan's original one didn't).

-- 
Matthew Saltzman

Clemson University Math Sciences
mjs AT clemson DOT edu
http://www.math.clemson.edu/~mjs

___
NetworkManager-list mailing list
NetworkManager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list