Hi Shogun, On Tue, 2006-11-28 at 10:05 +0100, Shogun wrote:
> Hi guys... > I tried to compile NM with the latest CVS (20061128 - 09:58 UTC+2) and > it fails to build if DBUS 1.0 is installed. This is because it tries to > insert this flag: > DBUS_NAME_FLAG_PROHIBIT_REPLACEMENT > > I saw the code, and it seems that the flags should be replaced by > > DBUS_NAME_FLAG_DO_NOT_QUEUE; > > basing on this #if condition: > > #if (DBUS_VERSION_MAJOR == 0) && (DBUS_VERSION_MINOR >= 60) > > This is true for every DBUS < 1.0 but it fails with DBUS >= 1.0 so it > still insert DBUS...PROIHIBIT... which is undefined... > So i patched the #if as follows (see it in the attached patch too): > > +#if (DBUS_VERSION_MAJOR > 0) || ((DBUS_VERSION_MAJOR == 0) && > (DBUS_VERSION_MINOR >= 60)) Thanks for the patch. We have a fix [1] for this issue pending (it just was not yet been committed as my CVS account for gnome.org is currently not working). Timo [1] [PATCH] Fix flawed logic for flags passed to dbus_bus_request_name() http://mail.gnome.org/archives/networkmanager-list/2006-November/msg00070.html _______________________________________________ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list