Re: [PATCH] Don't generate a connection for unmanaged devices.

2014-03-31 Thread Dan Williams
On Mon, 2014-03-31 at 21:41 +0400, Mikhail Efremov wrote:
 Hello!
 
 I have a bridge that was created before the start of NM and it
 shouldn't be managed by NM. But NM ignores unmanaged specs from a
 plugin: device_has_config() always returns TRUE for bridges, so default
 connection is generated and NM tries to manage the bridge.
 Attached patch fixes this, although I'm not sure that's the right way.

What's the specific issue with NM managing the bridge?  Our goal is to
allow NM to manage *every* device without touching it if it's already
configured.  I know of one specific bug here with bridges that is a
problem (NM sets it up immediately), and we're working on fixing that.
If we fixed that, would it solve your issue?

Dan

___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: [PATCH] Don't generate a connection for unmanaged devices.

2014-03-31 Thread Dan Williams
On Mon, 2014-03-31 at 13:00 -0500, Dan Williams wrote:
 On Mon, 2014-03-31 at 21:41 +0400, Mikhail Efremov wrote:
  Hello!
  
  I have a bridge that was created before the start of NM and it
  shouldn't be managed by NM. But NM ignores unmanaged specs from a
  plugin: device_has_config() always returns TRUE for bridges, so default
  connection is generated and NM tries to manage the bridge.
  Attached patch fixes this, although I'm not sure that's the right way.
 
 What's the specific issue with NM managing the bridge?  Our goal is to
 allow NM to manage *every* device without touching it if it's already
 configured.  I know of one specific bug here with bridges that is a
 problem (NM sets it up immediately), and we're working on fixing that.
 If we fixed that, would it solve your issue?

I was too quick to reply, sorry for that.  The patch is obviously
correct and the unmanaged specs should be respected.  That said, we do
want to be in a place where unmanaged devices are no longer necessary.

Thanks!
Dan

___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list