Re: [patch NetworkManager 00/11] team driver related updates and fixes
On Thursday 22 of August 2013 16:20:32 Jiri Pirko wrote: Thu, Aug 22, 2013 at 03:47:24PM CEST, d...@gnome.org wrote: I committed the non-nmcli parts (with three small fixes: added spaces before ( in function calls [eg, teamdctl_alloc ()], fixed a build error when building without libteamdctl [error: unused variable 'priv'], and made a minor grammatical tweak to a log message). I'll leave the nmcli bits for jklimes to review since he knows that code a lot better. Okay, thanks a lot Dan. -- Dan The nmcli patches look right. I've applied them to master, and added some missing stuff as a new commit. Jirka ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [patch NetworkManager 00/11] team driver related updates and fixes
I committed the non-nmcli parts (with three small fixes: added spaces before ( in function calls [eg, teamdctl_alloc ()], fixed a build error when building without libteamdctl [error: unused variable 'priv'], and made a minor grammatical tweak to a log message). I'll leave the nmcli bits for jklimes to review since he knows that code a lot better. -- Dan ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [patch NetworkManager 00/11] team driver related updates and fixes
Thu, Aug 22, 2013 at 03:47:24PM CEST, d...@gnome.org wrote: I committed the non-nmcli parts (with three small fixes: added spaces before ( in function calls [eg, teamdctl_alloc ()], fixed a build error when building without libteamdctl [error: unused variable 'priv'], and made a minor grammatical tweak to a log message). I'll leave the nmcli bits for jklimes to review since he knows that code a lot better. Okay, thanks a lot Dan. -- Dan ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [patch NetworkManager 00/11] team driver related updates and fixes
On Fri, 2013-08-16 at 15:33 +0200, Jiri Pirko wrote: Jiri Pirko (11): cli: add team and team-slave detail printing cli: add team port setting cli: add config option for team devices ifcfg-rh writer: write DEVICETYPE for all team ports add libteamdctl for configure.ac nm-device-team: use libteamdctl team: use libteamdctl to update port config before enslave For some reason I don't see this patch (#7), is that a patch for the team utilities themselves? Dan nm-manager: do not fail if team device already exists nm-manager: fix goto in system_create_virtual_device() in team section team: kill existing teamd for same device name during teamd start phase cli: add missed setting name to nmc_team_slave_settings cli/src/connections.c | 19 cli/src/settings.c | 82 ++ configure.ac | 20 + src/Makefile.am| 8 src/devices/nm-device-team.c | 71 - src/nm-manager.c | 5 ++- src/settings/plugins/ifcfg-rh/writer.c | 5 ++- 7 files changed, 205 insertions(+), 5 deletions(-) ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [patch NetworkManager 00/11] team driver related updates and fixes
Fri, Aug 16, 2013 at 10:59:24PM CEST, d...@redhat.com wrote: On Fri, 2013-08-16 at 15:33 +0200, Jiri Pirko wrote: Jiri Pirko (11): cli: add team and team-slave detail printing cli: add team port setting cli: add config option for team devices ifcfg-rh writer: write DEVICETYPE for all team ports add libteamdctl for configure.ac nm-device-team: use libteamdctl team: use libteamdctl to update port config before enslave For some reason I don't see this patch (#7), is that a patch for the team utilities themselves? Nope. git send-email broke at the middle of series so I sent the rest manually. I'm going to resend 0007 again Sorry for inconvenience. Jiri Dan nm-manager: do not fail if team device already exists nm-manager: fix goto in system_create_virtual_device() in team section team: kill existing teamd for same device name during teamd start phase cli: add missed setting name to nmc_team_slave_settings cli/src/connections.c | 19 cli/src/settings.c | 82 ++ configure.ac | 20 + src/Makefile.am| 8 src/devices/nm-device-team.c | 71 - src/nm-manager.c | 5 ++- src/settings/plugins/ifcfg-rh/writer.c | 5 ++- 7 files changed, 205 insertions(+), 5 deletions(-) ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
