Re: NetworkManager 0.7 Released
On Friday 28 November 2008, Dan Williams wrote: > Hi, > > I tagged, branched, and uploaded tarballs for the NetworkManager 0.7 > release on Wednesday night. Thanks a lot, amazing work! Robert signature.asc Description: This is a digitally signed message part. ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: NetworkManager 0.7 Released
Dan Williams wrote: > On Mon, 2008-12-01 at 17:39 +, Sjoerd Simons wrote: >> On Mon, Dec 01, 2008 at 12:05:15PM -0500, Dan Williams wrote: >>> On Sun, 2008-11-30 at 15:02 +0100, Sjoerd Simons wrote: On Sat, Nov 29, 2008 at 10:50:40PM -0500, Dan Williams wrote: > On Sat, 2008-11-29 at 22:59 +0100, Sjoerd Simons wrote: > Well... libnm-util did, but libnm-util for 0.6 was only meant to be used > between the applet and NM itself. libnm_glib ABI/API should be the same > between 0.6 and 0.7, because the 0.7 libnm_glib actually includes all of > the 0.6 libnm_glib. The NM applet is still an external application though and libnm-util is still a proper library. So proper library versioning is still something that needs to be done. Especially if nothing actually used it, then bumping the soname shouldn't be a hassle. >>> I understand how it's supposed to work, yes, but if we don't break the >>> ABI/API going forward past 0.7, should we bump the soname and require a >>> recompile of everything that uses libnm-util and libnm-glib now? Or >>> just tell distros to set up a symlink? >> I don't understand the symlink comment.. I don't know how many distributions >> are already shipping NM 0.7 with the current sonames. Obviously if you're >> going >> to bump the soname, it should be done asap to minimize transition pain. >> >> Pratically, once people have started shipping a library with a new ABI but >> without a soname bump, you've already lost. Imho it still makes sense to bump >> the soname now and have those that shipped 0.7 very early go through the >> little >> bit of pain a soname transitions gives. As it will smoothen the 0.6 => 0.7 >> transition for those that still have to do that. But obviously i'm slightly >> biased here as Debian tends to care more about these things then most other >> distributions :) > > So you mean do a soname bump on the _stable_ branch of 0.7, for what > would be the 0.7.1 release, correct? I think we can get away with only bumping the soname of libnm-util. Strictly speaking we have removed interfaces from libnm_glib, but they were never part of the public ABI. So I think we are safe here. But we have added new interfaces. So the correct version-info for libnm-glib would be "1:0:1" libnm-glib-vpn is a new lib, starting with "0:0:0" For libnm-util we broke ABI, so "1:0:0" would be the version string. I've added a patch for that. 3rd party apps, that have linked against libnm_glib (In Debian we have evolution, liferea and krb5-auth-dialog) won't need recompilation. Apps depending on libnm-util (nm-applet, vpn plugins and knetworkmanager 0.7) will need recompilation. I would not start creating a libnm-util.so.0 symlink, if you have already released 0.7 packages of NM, but simply recompile those few packages mentioned above. And yes, I think Sjoerd intention is to have a 0.7.1 release with this fixed sonames. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? diff --git a/libnm-glib/Makefile.am b/libnm-glib/Makefile.am index a8b4aca..96b1d94 100644 --- a/libnm-glib/Makefile.am +++ b/libnm-glib/Makefile.am @@ -91,7 +91,8 @@ libnm_glib_la_LIBADD = \ $(GCONF_LIBS) \ $(GNOME_KEYRING_LIBS) -libnm_glib_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libnm_glib.ver +libnm_glib_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libnm_glib.ver \ + -version-info "1:0:1" noinst_PROGRAMS = libnm-glib-test @@ -103,7 +104,8 @@ libnm_glib_test_LDADD = libnm_glib.la $(top_builddir)/libnm-util/libnm-util.la $ libnm_glib_vpn_la_SOURCES = nm-vpn-plugin.c nm-vpn-plugin-ui-interface.c libnm_glib_vpn_la_CFLAGS = $(GLIB_CFLAGS) $(DBUS_CFLAGS) libnm_glib_vpn_la_LIBADD = $(top_builddir)/libnm-util/libnm-util.la $(GLIB_LIBS) $(DBUS_LIBS) -libnm_glib_vpn_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libnm_glib_vpn.ver +libnm_glib_vpn_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libnm_glib_vpn.ver \ + -version-info "0:0:0" nm-client-bindings.h: $(top_srcdir)/introspection/nm-manager-client.xml diff --git a/libnm-util/Makefile.am b/libnm-util/Makefile.am index ce72c16..5e96865 100644 --- a/libnm-util/Makefile.am +++ b/libnm-util/Makefile.am @@ -52,7 +52,8 @@ libnm_util_la_SOURCES= \ libnm_util_la_LIBADD = $(GLIB_LIBS) $(DBUS_LIBS) $(UUID_LIBS) -libnm_util_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libnm-util.ver +libnm_util_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libnm-util.ver \ + -version-info "1:0:0" if WITH_GNUTLS libnm_util_la_SOURCES += crypto_gnutls.c signature.asc Description: OpenPGP digital signature ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: NetworkManager 0.7 Released
On Mon, 2008-12-01 at 17:39 +, Sjoerd Simons wrote: > On Mon, Dec 01, 2008 at 12:05:15PM -0500, Dan Williams wrote: > > On Sun, 2008-11-30 at 15:02 +0100, Sjoerd Simons wrote: > > > On Sat, Nov 29, 2008 at 10:50:40PM -0500, Dan Williams wrote: > > > > On Sat, 2008-11-29 at 22:59 +0100, Sjoerd Simons wrote: > > > > Well... libnm-util did, but libnm-util for 0.6 was only meant to be used > > > > between the applet and NM itself. libnm_glib ABI/API should be the same > > > > between 0.6 and 0.7, because the 0.7 libnm_glib actually includes all of > > > > the 0.6 libnm_glib. > > > > > > The NM applet is still an external application though and libnm-util is > > > still a proper library. So proper library versioning is still something > > > that needs to be done. Especially if nothing actually used it, then > > > bumping > > > the soname shouldn't be a hassle. > > > > I understand how it's supposed to work, yes, but if we don't break the > > ABI/API going forward past 0.7, should we bump the soname and require a > > recompile of everything that uses libnm-util and libnm-glib now? Or > > just tell distros to set up a symlink? > > I don't understand the symlink comment.. I don't know how many distributions > are already shipping NM 0.7 with the current sonames. Obviously if you're > going > to bump the soname, it should be done asap to minimize transition pain. > > Pratically, once people have started shipping a library with a new ABI but > without a soname bump, you've already lost. Imho it still makes sense to bump > the soname now and have those that shipped 0.7 very early go through the > little > bit of pain a soname transitions gives. As it will smoothen the 0.6 => 0.7 > transition for those that still have to do that. But obviously i'm slightly > biased here as Debian tends to care more about these things then most other > distributions :) So you mean do a soname bump on the _stable_ branch of 0.7, for what would be the 0.7.1 release, correct? Dan ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: NetworkManager 0.7 Released
On Mon, Dec 01, 2008 at 12:05:15PM -0500, Dan Williams wrote: > On Sun, 2008-11-30 at 15:02 +0100, Sjoerd Simons wrote: > > On Sat, Nov 29, 2008 at 10:50:40PM -0500, Dan Williams wrote: > > > On Sat, 2008-11-29 at 22:59 +0100, Sjoerd Simons wrote: > > > Well... libnm-util did, but libnm-util for 0.6 was only meant to be used > > > between the applet and NM itself. libnm_glib ABI/API should be the same > > > between 0.6 and 0.7, because the 0.7 libnm_glib actually includes all of > > > the 0.6 libnm_glib. > > > > The NM applet is still an external application though and libnm-util is > > still > > a proper library. So proper library versioning is still something that > > needs to > > be done. Especially if nothing actually used it, then bumping the soname > > shouldn't be a hassle. > > I understand how it's supposed to work, yes, but if we don't break the > ABI/API going forward past 0.7, should we bump the soname and require a > recompile of everything that uses libnm-util and libnm-glib now? Or > just tell distros to set up a symlink? Ubuntu doesnt use that abi ... which is unfortunate in itself of course, but the natural consequence for landing a new API in the last few weeks before release. Bumping the soname for final 0.7 would help me at least to provide proper backports for intrepid ... or even would technically allow us to do a huge stable update to get the final bits in. - Alexander ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: NetworkManager 0.7 Released
On Mon, Dec 01, 2008 at 12:05:15PM -0500, Dan Williams wrote: > On Sun, 2008-11-30 at 15:02 +0100, Sjoerd Simons wrote: > > On Sat, Nov 29, 2008 at 10:50:40PM -0500, Dan Williams wrote: > > > On Sat, 2008-11-29 at 22:59 +0100, Sjoerd Simons wrote: > > > Well... libnm-util did, but libnm-util for 0.6 was only meant to be used > > > between the applet and NM itself. libnm_glib ABI/API should be the same > > > between 0.6 and 0.7, because the 0.7 libnm_glib actually includes all of > > > the 0.6 libnm_glib. > > > > The NM applet is still an external application though and libnm-util is > > still a proper library. So proper library versioning is still something > > that needs to be done. Especially if nothing actually used it, then bumping > > the soname shouldn't be a hassle. > > I understand how it's supposed to work, yes, but if we don't break the > ABI/API going forward past 0.7, should we bump the soname and require a > recompile of everything that uses libnm-util and libnm-glib now? Or > just tell distros to set up a symlink? I don't understand the symlink comment.. I don't know how many distributions are already shipping NM 0.7 with the current sonames. Obviously if you're going to bump the soname, it should be done asap to minimize transition pain. Pratically, once people have started shipping a library with a new ABI but without a soname bump, you've already lost. Imho it still makes sense to bump the soname now and have those that shipped 0.7 very early go through the little bit of pain a soname transitions gives. As it will smoothen the 0.6 => 0.7 transition for those that still have to do that. But obviously i'm slightly biased here as Debian tends to care more about these things then most other distributions :) Sjoerd -- Life may have no meaning, or, even worse, it may have a meaning of which you disapprove. ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: NetworkManager 0.7 Released
On Sun, 2008-11-30 at 15:02 +0100, Sjoerd Simons wrote: > On Sat, Nov 29, 2008 at 10:50:40PM -0500, Dan Williams wrote: > > On Sat, 2008-11-29 at 22:59 +0100, Sjoerd Simons wrote: > > Well... libnm-util did, but libnm-util for 0.6 was only meant to be used > > between the applet and NM itself. libnm_glib ABI/API should be the same > > between 0.6 and 0.7, because the 0.7 libnm_glib actually includes all of > > the 0.6 libnm_glib. > > The NM applet is still an external application though and libnm-util is still > a proper library. So proper library versioning is still something that needs > to > be done. Especially if nothing actually used it, then bumping the soname > shouldn't be a hassle. I understand how it's supposed to work, yes, but if we don't break the ABI/API going forward past 0.7, should we bump the soname and require a recompile of everything that uses libnm-util and libnm-glib now? Or just tell distros to set up a symlink? Dan > > What specifically doesn't work with the new libnm_glib that used to work > > with 0.6? AFAIK any 0.6 app linked against libnm_glib should still be > > able to use the new libnm_glib. > > Everything that uses nm_utils_essid_to_utf8 or nm_dbus_escape_object_path_item > for example, which were symbols exposed by libnm_glib. If these weren't meant > to be exposed then you might get away with not bumping the soname of -glib. As > only those that actually pay attention will notice. > > > What _doesn't_ work is parallel-installing NM 0.6 and NM 0.7. > > The deamon sure. > > > Ideally we don't break the libnm-util or libnm-glib API/ABI for post-0.7 > > unless we really have to, at which point the patch becomes useful... > > I don't think sticking your head in the sand and ignoring everything before > 0.7 > is responsible upstream maintaince. Things do break in ways they shouldn't > when > moving to 0.7 (the applet being the prime example here). Really bumping > sonames > is relatively and there are no excuses for not doing them when needed. > > But yes, proper library maintaince is hard and almost everybody gets it wrong > by not paying enough attention from the start to what actually their API/ABI > is... > > Sjoerd ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: NetworkManager 0.7 Released
Dan Williams wrote: > On Sat, 2008-11-29 at 22:59 +0100, Sjoerd Simons wrote: >> On Fri, Nov 28, 2008 at 01:02:37PM -0500, Dan Williams wrote: >>> Hi, >>> >>> I tagged, branched, and uploaded tarballs for the NetworkManager 0.7 >>> release on Wednesday night. Due to the US Thanksgiving holiday, there >>> wasn't time to mail out announcements until now. Thanks to everyone >>> (especially Tambet!) who helped push the 0.7 release out the door; it's >>> been a long 2 years. >> \o/ :) >> >>> Get it while it's hot: >>> >>> ftp://ftp.gnome.org/pub/gnome/sources/NetworkManager/0.7/ >>> ftp://ftp.gnome.org/pub/gnome/sources/network-manager-applet/0.7/ >>> >>> Over the next few weeks, we'll get a schedule and feature list together >>> for the next release. There's some great stuff queued up, and while we >>> can't get to all of it for whatever comes right after 0.7, we'll >>> certainly work hard to make the next major release cure both cancer >>> _and_ your connectivity problems. >> During the NM 0.7 cycle the ABI and/or API of both libnm-util and libnm-glib >> broke. Unfortunately the soname wasn't bumped :(. Attached patch bumps the > > Well... libnm-util did, but libnm-util for 0.6 was only meant to be used > between the applet and NM itself. libnm_glib ABI/API should be the same > between 0.6 and 0.7, because the 0.7 libnm_glib actually includes all of > the 0.6 libnm_glib. > Just some more data points to libnm-util: Not only nm-applet depends on it, but also all the vpn plugins (pptp,vpnc,openvpn). Then there is knetworkmanager 0.2.x which has a dependency on libnm-util, and gnome-main-menu [1], which links against libnm-util. Cheers, Michael [1] http://svn.gnome.org/viewvc/gnome-main-menu/ -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: NetworkManager 0.7 Released
On Sat, Nov 29, 2008 at 10:50:40PM -0500, Dan Williams wrote: > On Sat, 2008-11-29 at 22:59 +0100, Sjoerd Simons wrote: > Well... libnm-util did, but libnm-util for 0.6 was only meant to be used > between the applet and NM itself. libnm_glib ABI/API should be the same > between 0.6 and 0.7, because the 0.7 libnm_glib actually includes all of > the 0.6 libnm_glib. The NM applet is still an external application though and libnm-util is still a proper library. So proper library versioning is still something that needs to be done. Especially if nothing actually used it, then bumping the soname shouldn't be a hassle. > What specifically doesn't work with the new libnm_glib that used to work > with 0.6? AFAIK any 0.6 app linked against libnm_glib should still be > able to use the new libnm_glib. Everything that uses nm_utils_essid_to_utf8 or nm_dbus_escape_object_path_item for example, which were symbols exposed by libnm_glib. If these weren't meant to be exposed then you might get away with not bumping the soname of -glib. As only those that actually pay attention will notice. > What _doesn't_ work is parallel-installing NM 0.6 and NM 0.7. The deamon sure. > Ideally we don't break the libnm-util or libnm-glib API/ABI for post-0.7 > unless we really have to, at which point the patch becomes useful... I don't think sticking your head in the sand and ignoring everything before 0.7 is responsible upstream maintaince. Things do break in ways they shouldn't when moving to 0.7 (the applet being the prime example here). Really bumping sonames is relatively and there are no excuses for not doing them when needed. But yes, proper library maintaince is hard and almost everybody gets it wrong by not paying enough attention from the start to what actually their API/ABI is... Sjoerd -- The truth of a thing is the feel of it, not the think of it. -- Stanley Kubrick ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: NetworkManager 0.7 Released
On Sat, 2008-11-29 at 22:59 +0100, Sjoerd Simons wrote: > On Fri, Nov 28, 2008 at 01:02:37PM -0500, Dan Williams wrote: > > Hi, > > > > I tagged, branched, and uploaded tarballs for the NetworkManager 0.7 > > release on Wednesday night. Due to the US Thanksgiving holiday, there > > wasn't time to mail out announcements until now. Thanks to everyone > > (especially Tambet!) who helped push the 0.7 release out the door; it's > > been a long 2 years. > > \o/ :) > > > Get it while it's hot: > > > > ftp://ftp.gnome.org/pub/gnome/sources/NetworkManager/0.7/ > > ftp://ftp.gnome.org/pub/gnome/sources/network-manager-applet/0.7/ > > > > Over the next few weeks, we'll get a schedule and feature list together > > for the next release. There's some great stuff queued up, and while we > > can't get to all of it for whatever comes right after 0.7, we'll > > certainly work hard to make the next major release cure both cancer > > _and_ your connectivity problems. > > During the NM 0.7 cycle the ABI and/or API of both libnm-util and libnm-glib > broke. Unfortunately the soname wasn't bumped :(. Attached patch bumps the Well... libnm-util did, but libnm-util for 0.6 was only meant to be used between the applet and NM itself. libnm_glib ABI/API should be the same between 0.6 and 0.7, because the 0.7 libnm_glib actually includes all of the 0.6 libnm_glib. What specifically doesn't work with the new libnm_glib that used to work with 0.6? AFAIK any 0.6 app linked against libnm_glib should still be able to use the new libnm_glib. What _doesn't_ work is parallel-installing NM 0.6 and NM 0.7. Ideally we don't break the libnm-util or libnm-glib API/ABI for post-0.7 unless we really have to, at which point the patch becomes useful... Dan > soname of both of those to 1. For more info of how libtool versioning works > see: > http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info > > Thanks, > Sjoerd ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: NetworkManager 0.7 Released
On Fri, Nov 28, 2008 at 01:02:37PM -0500, Dan Williams wrote: > Hi, > > I tagged, branched, and uploaded tarballs for the NetworkManager 0.7 > release on Wednesday night. Due to the US Thanksgiving holiday, there > wasn't time to mail out announcements until now. Thanks to everyone > (especially Tambet!) who helped push the 0.7 release out the door; it's > been a long 2 years. \o/ :) > Get it while it's hot: > > ftp://ftp.gnome.org/pub/gnome/sources/NetworkManager/0.7/ > ftp://ftp.gnome.org/pub/gnome/sources/network-manager-applet/0.7/ > > Over the next few weeks, we'll get a schedule and feature list together > for the next release. There's some great stuff queued up, and while we > can't get to all of it for whatever comes right after 0.7, we'll > certainly work hard to make the next major release cure both cancer > _and_ your connectivity problems. During the NM 0.7 cycle the ABI and/or API of both libnm-util and libnm-glib broke. Unfortunately the soname wasn't bumped :(. Attached patch bumps the soname of both of those to 1. For more info of how libtool versioning works see: http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html#Updating-version-info Thanks, Sjoerd -- He who knows that enough is enough will always have enough. -- Lao Tsu Index: libnm-util/Makefile.am === --- libnm-util/Makefile.am (revision 4357) +++ libnm-util/Makefile.am (working copy) @@ -52,7 +52,8 @@ libnm_util_la_LIBADD = $(GLIB_LIBS) $(DBUS_LIBS) $(UUID_LIBS) -libnm_util_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libnm-util.ver +libnm_util_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libnm-util.ver \ + -version-info "1:0:0" if WITH_GNUTLS libnm_util_la_SOURCES += crypto_gnutls.c Index: libnm-glib/Makefile.am === --- libnm-glib/Makefile.am (revision 4357) +++ libnm-glib/Makefile.am (working copy) @@ -91,7 +91,8 @@ $(GCONF_LIBS) \ $(GNOME_KEYRING_LIBS) -libnm_glib_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libnm_glib.ver +libnm_glib_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libnm_glib.ver \ + -version-info "1:0:0" noinst_PROGRAMS = libnm-glib-test ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: NetworkManager 0.7 Released
On Fri, 2008-11-28 at 20:21 +0100, Michael Biebl wrote: > Dan Williams wrote: > > Hi, > > > > I tagged, branched, and uploaded tarballs for the NetworkManager 0.7 > > release on Wednesday night. Due to the US Thanksgiving holiday, there > > Congrats to the great release! > > Do you also plan to upload 0.7 tarballs for the vpn plugins? All three should now be uploaded in separate directories named after the individual plugins. Dan ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: NetworkManager 0.7 Released
Dan Williams wrote: > Hi, > > I tagged, branched, and uploaded tarballs for the NetworkManager 0.7 > release on Wednesday night. Due to the US Thanksgiving holiday, there Congrats to the great release! Do you also plan to upload 0.7 tarballs for the vpn plugins? Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? signature.asc Description: OpenPGP digital signature ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
