Re: network-manager 0.8.1-beta2 does not work with isc dhcp-clients 3.1.3 and 4.1.1

2010-06-02 Thread Andrew Pollock
On Sun, May 30, 2010 at 11:01:24PM +0200, Thomas Schmidt wrote:
 Hi,
 
 Am Sonntag, den 30.05.2010, 20:24 +0200 schrieb Michael Biebl:
  NM 0.8.1 requires ISC dhcp-client with DHCPv6 support enabled.
  The isc-dhcp package from experimental has DHCPv6 support disabled, due to 
  build
  failures in the past, which have been sorted out in 4.1.1.
 
 Ok, thank you for the information.
 
  Hopefully Andrew finds the time to upload a new version with DHCPv6 support
  enabled (I CCed just in case).
 
 Yes, i really hope this too.

I'd appreciate if people interested in seeing DHCP v4 in Debian could test
out the packages I have in experimental and file bugs as necessary. At some
point, as time permits, I will upload these packages to unstable.

I've gone to great pains to make the new packages a drop in replacement for
the old v3 packages, but I've done limited testing myself due to resource
constraints at the moment.


signature.asc
Description: Digital signature
___
networkmanager-list mailing list
networkmanager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: network-manager 0.8.1-beta2 does not work with isc dhcp-clients 3.1.3 and 4.1.1

2010-06-02 Thread Dan Williams
On Sun, 2010-05-30 at 20:24 +0200, Michael Biebl wrote:
 On 30.05.2010 11:38, Thomas Schmidt wrote:
  Hi,
  
  i am currently testing the beta2 of network-manager 0.8.1 on my Debian
  Testing system, which has the isc dhcp3-client 3.1.3 installed by
  default.
  
  The new network-manager seems to use some commandline options for
  calling the dhcp-client which are not available in version 3.1.3 because
  i can see the following in the syslog:
  
 
 NM 0.8.1 requires ISC dhcp-client with DHCPv6 support enabled.
 The isc-dhcp package from experimental has DHCPv6 support disabled, due to 
 build
 failures in the past, which have been sorted out in 4.1.1.
 
 Hopefully Andrew finds the time to upload a new version with DHCPv6 support
 enabled (I CCed just in case).
 
 Not sure if he still plans to upload isc-dhcp 4.x to unstable so it has a 
 chance
 to get into squeeze.
 
 Of course I would prefer to have a newer dhcp version in Debian (and Ubuntu
 fwiw), on the other hand if NM 0.8.1 could safely fall back to not use dhcpv6 
 if
 older dhclient versions are detected, it would be even better.

I'll take a patch for that.  If we can autodetect the version of
dhclient at %configure time, lets AC_DEFINE something like
HAVE_DHCLIENT_V4 and if that's not defined, we fail any connection that
requests DHCPv6.  That part isn't hard.  Plus, then we can get the
arguments right when calling dhclient too.  I'd like to fix this as
well.

Dan


___
networkmanager-list mailing list
networkmanager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


network-manager 0.8.1-beta2 does not work with isc dhcp-clients 3.1.3 and 4.1.1

2010-05-30 Thread Thomas Schmidt
Hi,

i am currently testing the beta2 of network-manager 0.8.1 on my Debian
Testing system, which has the isc dhcp3-client 3.1.3 installed by
default.

The new network-manager seems to use some commandline options for
calling the dhcp-client which are not available in version 3.1.3 because
i can see the following in the syslog:

May 30 11:03:42 s710 NetworkManager[21976]: info Activation (eth0)
Beginning DHCPv4 transaction (timeout in 45 seconds)
May 30 11:03:42 s710 NetworkManager[21976]: info dhclient started with
pid 21983
May 30 11:03:42 s710 NetworkManager[21976]: info Activation (eth0)
Stage 3 of 5 (IP Configure Start) complete.
May 30 11:03:42 s710 dhclient: Internet Systems Consortium DHCP Client
V3.1.3
May 30 11:03:42 s710 dhclient: Copyright 2004-2009 Internet Systems
Consortium.
May 30 11:03:42 s710 dhclient: All rights reserved.
May 30 11:03:42 s710 dhclient: For info, please visit
https://www.isc.org/software/dhcp/
May 30 11:03:42 s710 dhclient: Usage: dhclient [-1dqrx] [-nw] [-p
port] [-s server]
May 30 11:03:42 s710 dhclient: [-cf config-file] [-lf lease-file][-pf
pid-file] [-e VAR=val]
May 30 11:03:42 s710 dhclient: [-sf script-file] [interface]
May 30 11:03:42 s710 NetworkManager[21976]: info (eth0): DHCPv4 client
pid 21983 exited with status 1

The same seems to happen with version 4.1.1 of the dhcp-client (Debian
package isc-dhcp-client, version 4.1.1-1):

May 30 11:30:30 s710 NetworkManager[5191]: info Activation (eth0)
Beginning DHCPv4 transaction (timeout in 45 seconds)
May 30 11:30:30 s710 NetworkManager[5191]: info dhclient started with
pid 5198
May 30 11:30:30 s710 NetworkManager[5191]: info Activation (eth0)
Stage 3 of 5 (IP Configure Start) complete.
May 30 11:30:30 s710 dhclient: Internet Systems Consortium DHCP Client
4.1.1
May 30 11:30:30 s710 dhclient: Copyright 2004-2010 Internet Systems
Consortium.
May 30 11:30:30 s710 dhclient: All rights reserved.
May 30 11:30:30 s710 dhclient: For info, please visit
https://www.isc.org/software/dhcp/
May 30 11:30:30 s710 dhclient: Usage: dhclient [-1dvrx] [-nw] [-p
port] [-s server]
May 30 11:30:30 s710 dhclient: [-cf config-file] [-lf
lease-file][-pf pid-file] [-e VAR=val]
May 30 11:30:30 s710 dhclient: [-sf script-file]
[interface]
May 30 11:30:30 s710 NetworkManager[5191]: info (eth0): DHCPv4 client
pid 5198 exited with status 1

So for me it seems that network-manager uses some commandline-options
which are not available in the Debian versions of the dhcp-clients.

I already did a short look at the src/dhcp-manager directory but i could
not find a part where i could print the whole commandline which is used
for calling the dhcp-client.


Regards,
Thomas

-- 
Thomas Schmidt, Debian VDR Team
http://pkg-vdr-dvb.alioth.debian.org/


signature.asc
Description: This is a digitally signed message part
___
networkmanager-list mailing list
networkmanager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: network-manager 0.8.1-beta2 does not work with isc dhcp-clients 3.1.3 and 4.1.1

2010-05-30 Thread Thomas Schmidt
Many thanks to Waldemar Brodkorb for the nice idea to get the used
commandline options.

The full call to dhclient looks like this on my system:

/sbin/dhclient -d -4 -sf /usr/lib/NetworkManager/nm-dhcp-client.action
-pf /var/run/dhclient-eth0.pid
-lf /var/lib/dhcp3/dhclient-5ef60aca-3b6e-4dd1-9523-4ae039288431-eth0.lease -cf 
/var/run/nm-dhclient-eth0.conf eth0

The problem is caused by the -4 parameter of the call.

The attached patch fixes it for me, but i do not know if this might
cause side effects on systems where the -4 option of dhclient 
is available.


Regards,
Thomas

-- 
Thomas Schmidt, Debian VDR Team
http://pkg-vdr-dvb.alioth.debian.org/
diff --git a/src/dhcp-manager/nm-dhcp-dhclient.c b/src/dhcp-manager/nm-dhcp-dhclient.c
index d7a6e32..518254f 100644
--- a/src/dhcp-manager/nm-dhcp-dhclient.c
+++ b/src/dhcp-manager/nm-dhcp-dhclient.c
@@ -490,7 +490,6 @@ dhclient_start (NMDHCPClient *client,
 	guint log_domain;
 
 	g_return_val_if_fail (priv-pid_file == NULL, -1);
-	g_return_val_if_fail (ip_opt != NULL, -1);
 
 	iface = nm_dhcp_client_get_iface (client);
 	uuid = nm_dhcp_client_get_uuid (client);
@@ -527,7 +526,9 @@ dhclient_start (NMDHCPClient *client,
 
 	g_ptr_array_add (argv, (gpointer) -d);
 
-	g_ptr_array_add (argv, (gpointer) ip_opt);
+	if (ip_opt != NULL) {
+		g_ptr_array_add (argv, (gpointer) ip_opt);
+	}
 
 	if (mode_opt)
 		g_ptr_array_add (argv, (gpointer) mode_opt);
@@ -581,7 +582,7 @@ real_ip4_start (NMDHCPClient *client,
 		return -1;
 	}
 
-	return dhclient_start (client, -4, NULL);
+	return dhclient_start (client, NULL, NULL);
 }
 
 static GPid


signature.asc
Description: This is a digitally signed message part
___
networkmanager-list mailing list
networkmanager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: network-manager 0.8.1-beta2 does not work with isc dhcp-clients 3.1.3 and 4.1.1

2010-05-30 Thread Michael Biebl
On 30.05.2010 20:24, Michael Biebl wrote:
 
 NM 0.8.1 requires ISC dhcp-client with DHCPv6 support enabled.
 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=549060

To clarify that: If ISC dhcp is compiled with --enable-dhcpv6, it gets a few new
commandline options. Comparing the output of dhclient --help, those seem to be:
-4 -6 -S -N -T -P

Cheers,
Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature
___
networkmanager-list mailing list
networkmanager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: network-manager 0.8.1-beta2 does not work with isc dhcp-clients 3.1.3 and 4.1.1

2010-05-30 Thread Michael Biebl
On 30.05.2010 11:38, Thomas Schmidt wrote:
 Hi,
 
 i am currently testing the beta2 of network-manager 0.8.1 on my Debian
 Testing system, which has the isc dhcp3-client 3.1.3 installed by
 default.
 
 The new network-manager seems to use some commandline options for
 calling the dhcp-client which are not available in version 3.1.3 because
 i can see the following in the syslog:
 

NM 0.8.1 requires ISC dhcp-client with DHCPv6 support enabled.
The isc-dhcp package from experimental has DHCPv6 support disabled, due to build
failures in the past, which have been sorted out in 4.1.1.

Hopefully Andrew finds the time to upload a new version with DHCPv6 support
enabled (I CCed just in case).

Not sure if he still plans to upload isc-dhcp 4.x to unstable so it has a chance
to get into squeeze.

Of course I would prefer to have a newer dhcp version in Debian (and Ubuntu
fwiw), on the other hand if NM 0.8.1 could safely fall back to not use dhcpv6 if
older dhclient versions are detected, it would be even better.

Cheers,
Michael



[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=549060
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature
___
networkmanager-list mailing list
networkmanager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list


Re: network-manager 0.8.1-beta2 does not work with isc dhcp-clients 3.1.3 and 4.1.1

2010-05-30 Thread Thomas Schmidt
Hi,

Am Sonntag, den 30.05.2010, 20:24 +0200 schrieb Michael Biebl:
 NM 0.8.1 requires ISC dhcp-client with DHCPv6 support enabled.
 The isc-dhcp package from experimental has DHCPv6 support disabled, due to 
 build
 failures in the past, which have been sorted out in 4.1.1.

Ok, thank you for the information.

 Hopefully Andrew finds the time to upload a new version with DHCPv6 support
 enabled (I CCed just in case).

Yes, i really hope this too.

 Not sure if he still plans to upload isc-dhcp 4.x to unstable so it has a 
 chance
 to get into squeeze.

 Of course I would prefer to have a newer dhcp version in Debian (and Ubuntu
 fwiw), on the other hand if NM 0.8.1 could safely fall back to not use dhcpv6 
 if
 older dhclient versions are detected, it would be even better.

I agree that a fallback to be compatible with the older dhclient would
be the best option.

Anyway, thank you very much for maintaining NM, i realy hope that NM
0.8.1 and Modemmanager 0.4, once they are released, will make it into
Squeeze because with this combination i can finally stop using
commandline tools to create a connection via DUN over Bluetooth to get
internet access while underway.


Regards,
Thomas

-- 
Thomas Schmidt, Debian VDR Team
http://pkg-vdr-dvb.alioth.debian.org/


signature.asc
Description: This is a digitally signed message part
___
networkmanager-list mailing list
networkmanager-list@gnome.org
http://mail.gnome.org/mailman/listinfo/networkmanager-list