Re: [Nfs-ganesha-devel] segv in mdc_up_invalidate (synchronous upcall)

2017-01-20 Thread Matt Benjamin
Responding to myself, in part:

Looks like fsal_export.super_export "works" but presumes there is one, or at 
least would if I can safely decide whether to pass super_export if present?  Or 
something.

Matt

- Original Message -
> From: "Matt Benjamin" 
> To: "NFS Ganesha Developers" 
> Cc: "Daniel Gryniewicz" 
> Sent: Friday, January 20, 2017 10:41:50 PM
> Subject: segv in mdc_up_invalidate (synchronous upcall)
> 
> 
> try-expire ev:
> 

[Nfs-ganesha-devel] segv in mdc_up_invalidate (synchronous upcall)

2017-01-20 Thread Matt Benjamin

try-expire ev: 

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Avoid both messages (hit and starting) when DRC cache is hit.

2017-01-20 Thread GerritHub
>From Malahal :

Malahal has uploaded a new change for review. ( 
https://review.gerrithub.io/343978


Change subject: Avoid both messages (hit and starting) when DRC cache is hit.
..

Avoid both messages (hit and starting) when DRC cache is hit.

Moved the "starting" message to log only for new entries.

Change-Id: Iac0d946bef078f532e62efa915fc2be086f3c3ef
Signed-off-by: Malahal Naineni 
---
M src/RPCAL/nfs_dupreq.c
1 file changed, 9 insertions(+), 8 deletions(-)



  git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha 
refs/changes/78/343978/1
-- 
To view, visit https://review.gerrithub.io/343978
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac0d946bef078f532e62efa915fc2be086f3c3ef
Gerrit-Change-Number: 343978
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Malahal 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix multiple threads handling the same drc with zero ref count

2017-01-20 Thread GerritHub
>From Malahal :

Malahal has uploaded a new change for review. ( 
https://review.gerrithub.io/343980


Change subject: Fix multiple threads handling the same drc with zero ref count
..

Fix multiple threads handling the same drc with zero ref count

nfs_dupreq_put_drc() drops the locks after decrementing the ref count to
zero. Imagine this thread not getting scheduled for a good amount of
time. The nfs_dupreq_get_drc() may bump up the ref count and recycle the
drc. The drc may eventually end up with zero ref count in another thread. At
this point we have two threads that are handling the same drc with zero
ref count. One thread may put it in the recycle list and the drc could
be freed before the other thread tries to access the drc! This may lead to
use after freed memory.

The fix here is to wait in the nfs_dupreq_get_drc until the first thread puts
the drc in the recycle queue.

Change-Id: I4d88bd401a5f266b4f7d75bfbeda9b91a329629b
Signed-off-by: Malahal Naineni 
---
M src/RPCAL/nfs_dupreq.c
1 file changed, 46 insertions(+), 9 deletions(-)



  git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha 
refs/changes/80/343980/1
-- 
To view, visit https://review.gerrithub.io/343980
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d88bd401a5f266b4f7d75bfbeda9b91a329629b
Gerrit-Change-Number: 343980
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Malahal 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MDCACHE - can't rename dirent if not in cache

2017-01-20 Thread GerritHub
>From Daniel Gryniewicz :

Daniel Gryniewicz has uploaded a new change for review. ( 
https://review.gerrithub.io/343969


Change subject: MDCACHE - can't rename dirent if not in cache
..

MDCACHE - can't rename dirent if not in cache

mdcache_dirent_find() can return success if the dirent is not found and
the cache is not trusted.  In this case, we can't rename the dirent, so
just return.

Change-Id: Ia47350395a1d7bc0064b84a565d60d549b793afa
Signed-off-by: Daniel Gryniewicz 
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha 
refs/changes/69/343969/1
-- 
To view, visit https://review.gerrithub.io/343969
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia47350395a1d7bc0064b84a565d60d549b793afa
Gerrit-Change-Number: 343969
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Daniel Gryniewicz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel