[Nfs-ganesha-devel] Stacked FSALs and fsal_export parameters and op_ctx

[Frank Filz]

Stacked FSALs often depend on op_ctx->fsal_export being set.

We also have lots of FSAL methods that take the fsal_export as a parameter.

I wonder if we would be better off removing the fsal_export parameters in
almost all cases, and instead expecting op_ctx->fsal_export to be set?

One danger is that if an FSAL method is called for a different export than
op_ctx->fsal_export, the subcall macros will end up changing
op_ctx->fsal_export and break the caller... It would be better that the
caller assure that op_ctx is properly set up (and save the current
op_ctx->fsal_export if necessary).

In any case, we probably need to audit anywhere op_ctx->fsal_export is not
set. I see that RQUOTA does not set it...

One advantage of making sure op_ctx->fsal_export is always set in the upper
layers is that it should ALSO set op_ctx->ctx_export.

We should also check for any place where op_ctx is NULL. We have
subcall_shutdown_raw that assumes op_ctx might not be set, and the only
place it is used is in calling sub_export release, with the result that that
was not actually working right in the DBUS unexport case where there wasn't
a proper op_ctx (though I wonder if that's also why shutdown reports an
extra ref to FSAL_PSEUDO, is there some point in shutdown where we don't
have an op_ctx?).

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: HASHTABLE: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390882


Change subject: HASHTABLE: Cleanup new checkpatch errors
..

HASHTABLE: Cleanup new checkpatch errors

Change-Id: Ide72a52987de228535c07cf5638da2d8632181d6
Signed-off-by: Frank S. Filz 
---
M src/hashtable/hashtable.c
1 file changed, 10 insertions(+), 12 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/82/390882/1
-- 
To view, visit https://review.gerrithub.io/390882
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide72a52987de228535c07cf5638da2d8632181d6
Gerrit-Change-Number: 390882
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MNT: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390873


Change subject: MNT: Cleanup new checkpatch errors
..

MNT: Cleanup new checkpatch errors

Change-Id: Idc725fe5915dabb8e301b1bd4e0a4b91b1f4fc2f
Signed-off-by: Frank S. Filz 
---
M src/Protocols/NFS/mnt_Dump.c
M src/Protocols/NFS/mnt_Mnt.c
M src/Protocols/NFS/mnt_Null.c
M src/Protocols/NFS/mnt_Umnt.c
M src/Protocols/NFS/mnt_UmntAll.c
5 files changed, 9 insertions(+), 9 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/73/390873/1
-- 
To view, visit https://review.gerrithub.io/390873
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc725fe5915dabb8e301b1bd4e0a4b91b1f4fc2f
Gerrit-Change-Number: 390873
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: SAL: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390880


Change subject: SAL: Cleanup new checkpatch errors
..

SAL: Cleanup new checkpatch errors

Change-Id: I2fab11037ae8543e81a2edd4a2294ceb609a9cb9
Signed-off-by: Frank S. Filz 
---
M src/SAL/nfs41_session_id.c
M src/SAL/nfs4_clientid.c
M src/SAL/nfs4_owner.c
M src/SAL/nfs4_recovery.c
M src/SAL/nfs4_state.c
M src/SAL/state_deleg.c
M src/SAL/state_lock.c
M src/SAL/state_share.c
M src/include/sal_data.h
9 files changed, 72 insertions(+), 73 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/80/390880/1
-- 
To view, visit https://review.gerrithub.io/390880
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fab11037ae8543e81a2edd4a2294ceb609a9cb9
Gerrit-Change-Number: 390880
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MDCACHE: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390868


Change subject: MDCACHE: Cleanup new checkpatch errors
..

MDCACHE: Cleanup new checkpatch errors

Change-Id: I744df098a9b4fc75d15e0044f6555a1e07d51df9
Signed-off-by: Frank S. Filz 
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.h
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
5 files changed, 24 insertions(+), 27 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/68/390868/1
-- 
To view, visit https://review.gerrithub.io/390868
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I744df098a9b4fc75d15e0044f6555a1e07d51df9
Gerrit-Change-Number: 390868
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: SUPPORT: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390884


Change subject: SUPPORT: Cleanup new checkpatch errors
..

SUPPORT: Cleanup new checkpatch errors

Change-Id: Ifc595d60f52ef38cbb957322f096b7ddd9fd8619
Signed-off-by: Frank S. Filz 
---
M src/include/server_stats_private.h
M src/support/bsd-base64.c
M src/support/client_mgr.c
M src/support/ds.c
M src/support/err_inject.c
M src/support/export_mgr.c
M src/support/exports.c
M src/support/nfs_creds.c
M src/support/nfs_filehandle_mgmt.c
M src/support/nfs_ip_name.c
M src/support/strlcpy.c
M src/support/strnlen.c
12 files changed, 76 insertions(+), 76 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/84/390884/1
-- 
To view, visit https://review.gerrithub.io/390884
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc595d60f52ef38cbb957322f096b7ddd9fd8619
Gerrit-Change-Number: 390884
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MainNFSD: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390871


Change subject: MainNFSD: Cleanup new checkpatch errors
..

MainNFSD: Cleanup new checkpatch errors

Change-Id: I5e7b9fcd169387eb4929067e135738666f12adca
Signed-off-by: Frank S. Filz 
---
M src/MainNFSD/nfs_admin_thread.c
M src/MainNFSD/nfs_init.c
M src/MainNFSD/nfs_lib.c
M src/MainNFSD/nfs_main.c
M src/MainNFSD/nfs_rpc_callback.c
M src/MainNFSD/nfs_rpc_callback_simulator.c
M src/MainNFSD/nfs_rpc_dispatcher_thread.c
M src/MainNFSD/nfs_rpc_tcp_socket_manager_thread.c
M src/MainNFSD/nfs_worker_thread.c
9 files changed, 56 insertions(+), 59 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/71/390871/1
-- 
To view, visit https://review.gerrithub.io/390871
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e7b9fcd169387eb4929067e135738666f12adca
Gerrit-Change-Number: 390871
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: VFS: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390865


Change subject: VFS: Cleanup new checkpatch errors
..

VFS: Cleanup new checkpatch errors

Change-Id: I759c57121457c8fa4186b95c4480517c0d973de3
Signed-off-by: Frank S. Filz 
---
M src/FSAL/FSAL_VFS/handle.c
M src/FSAL/FSAL_VFS/panfs/mds.c
2 files changed, 8 insertions(+), 12 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/65/390865/1
-- 
To view, visit https://review.gerrithub.io/390865
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I759c57121457c8fa4186b95c4480517c0d973de3
Gerrit-Change-Number: 390865
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: DBUS: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390881


Change subject: DBUS: Cleanup new checkpatch errors
..

DBUS: Cleanup new checkpatch errors

Change-Id: I0c996e15f70a351a76ad9108a29a937fd97c8d0a
Signed-off-by: Frank S. Filz 
---
M src/dbus/dbus_heartbeat.c
M src/dbus/dbus_server.c
2 files changed, 6 insertions(+), 8 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/81/390881/1
-- 
To view, visit https://review.gerrithub.io/390881
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c996e15f70a351a76ad9108a29a937fd97c8d0a
Gerrit-Change-Number: 390881
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: LOG: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390883


Change subject: LOG: Cleanup new checkpatch errors
..

LOG: Cleanup new checkpatch errors

Change-Id: Ic0e034732f4e29e9e01d0c6fad49c2ecd48c380d
Signed-off-by: Frank S. Filz 
---
M src/include/log.h
M src/log/log_functions.c
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/83/390883/1
-- 
To view, visit https://review.gerrithub.io/390883
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0e034732f4e29e9e01d0c6fad49c2ecd48c380d
Gerrit-Change-Number: 390883
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: RPCAL: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390879


Change subject: RPCAL: Cleanup new checkpatch errors
..

RPCAL: Cleanup new checkpatch errors

Change-Id: I8d866f47efdcc04de0fa35ded62d246eb0c6cb82
Signed-off-by: Frank S. Filz 
---
M src/RPCAL/gss_credcache.c
M src/RPCAL/nfs_dupreq.c
2 files changed, 5 insertions(+), 7 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/79/390879/1
-- 
To view, visit https://review.gerrithub.io/390879
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d866f47efdcc04de0fa35ded62d246eb0c6cb82
Gerrit-Change-Number: 390879
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: NFS4: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390875


Change subject: NFS4: Cleanup new checkpatch errors
..

NFS4: Cleanup new checkpatch errors

Change-Id: I2dd4e39d115449bd855f77187f9d98e357368eb2
Signed-off-by: Frank S. Filz 
---
M src/Protocols/NFS/nfs4_Compound.c
M src/Protocols/NFS/nfs4_op_close.c
M src/Protocols/NFS/nfs4_op_commit.c
M src/Protocols/NFS/nfs4_op_delegreturn.c
M src/Protocols/NFS/nfs4_op_exchange_id.c
M src/Protocols/NFS/nfs4_op_getdeviceinfo.c
M src/Protocols/NFS/nfs4_op_getdevicelist.c
M src/Protocols/NFS/nfs4_op_layoutcommit.c
M src/Protocols/NFS/nfs4_op_layoutget.c
M src/Protocols/NFS/nfs4_op_layoutreturn.c
M src/Protocols/NFS/nfs4_op_lock.c
M src/Protocols/NFS/nfs4_op_open.c
M src/Protocols/NFS/nfs4_op_open_confirm.c
M src/Protocols/NFS/nfs4_op_open_downgrade.c
M src/Protocols/NFS/nfs4_op_read.c
M src/Protocols/NFS/nfs4_op_reclaim_complete.c
M src/Protocols/NFS/nfs4_op_release_lockowner.c
M src/Protocols/NFS/nfs4_op_secinfo.c
M src/Protocols/NFS/nfs4_op_secinfo_no_name.c
M src/Protocols/NFS/nfs4_op_sequence.c
M src/Protocols/NFS/nfs4_op_setclientid_confirm.c
M src/Protocols/NFS/nfs4_op_xattr.c
M src/Protocols/NFS/nfs4_pseudo.c
23 files changed, 327 insertions(+), 427 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/75/390875/1
-- 
To view, visit https://review.gerrithub.io/390875
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dd4e39d115449bd855f77187f9d98e357368eb2
Gerrit-Change-Number: 390875
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: 9P: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390872


Change subject: 9P: Cleanup new checkpatch errors
..

9P: Cleanup new checkpatch errors

Change-Id: I481a4cbe21b5623f20f623ab30b04b23259e4918
Signed-off-by: Frank S. Filz 
---
M src/Protocols/9P/9p_flush_hook.c
M src/Protocols/9P/9p_lock.c
2 files changed, 3 insertions(+), 4 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/72/390872/1
-- 
To view, visit https://review.gerrithub.io/390872
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I481a4cbe21b5623f20f623ab30b04b23259e4918
Gerrit-Change-Number: 390872
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: RQUOTA: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390878


Change subject: RQUOTA: Cleanup new checkpatch errors
..

RQUOTA: Cleanup new checkpatch errors

Change-Id: I9115d5b8a7949b132b956639d79e2f096dcf1808
Signed-off-by: Frank S. Filz 
---
M src/Protocols/RQUOTA/rquota_Null.c
M src/Protocols/RQUOTA/rquota_getactivequota.c
M src/Protocols/RQUOTA/rquota_getquota.c
M src/Protocols/RQUOTA/rquota_setactivequota.c
M src/Protocols/RQUOTA/rquota_setquota.c
5 files changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/78/390878/1
-- 
To view, visit https://review.gerrithub.io/390878
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9115d5b8a7949b132b956639d79e2f096dcf1808
Gerrit-Change-Number: 390878
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: NLM: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390877


Change subject: NLM: Cleanup new checkpatch errors
..

NLM: Cleanup new checkpatch errors

Change-Id: I5366af45e9b2acaf3d4d1690ce27b7ce76046b12
Signed-off-by: Frank S. Filz 
---
M src/Protocols/NLM/nlm_Cancel.c
M src/Protocols/NLM/nlm_Free_All.c
M src/Protocols/NLM/nlm_Lock.c
M src/Protocols/NLM/nlm_Null.c
M src/Protocols/NLM/nlm_Share.c
M src/Protocols/NLM/nlm_Test.c
M src/Protocols/NLM/nlm_Unlock.c
M src/Protocols/NLM/nlm_Unshare.c
M src/Protocols/NLM/nlm_async.c
M src/Protocols/NLM/nlm_util.c
10 files changed, 107 insertions(+), 137 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/77/390877/1
-- 
To view, visit https://review.gerrithub.io/390877
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5366af45e9b2acaf3d4d1690ce27b7ce76046b12
Gerrit-Change-Number: 390877
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: NFS: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390876


Change subject: NFS: Cleanup new checkpatch errors
..

NFS: Cleanup new checkpatch errors

Change-Id: I75bd17c2cd20431b0c36aedbddd85cceb8c6c4ab
Signed-off-by: Frank S. Filz 
---
M src/Protocols/NFS/nfs_null.c
M src/Protocols/NFS/nfs_proto_tools.c
2 files changed, 38 insertions(+), 45 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/76/390876/1
-- 
To view, visit https://review.gerrithub.io/390876
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75bd17c2cd20431b0c36aedbddd85cceb8c6c4ab
Gerrit-Change-Number: 390876
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: NFS3: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390874


Change subject: NFS3: Cleanup new checkpatch errors
..

NFS3: Cleanup new checkpatch errors

Change-Id: I8d78ffc75fc254b4ba016bd35348ab4ef906badd
Signed-off-by: Frank S. Filz 
---
M src/Protocols/NFS/nfs3_access.c
M src/Protocols/NFS/nfs3_commit.c
M src/Protocols/NFS/nfs3_create.c
M src/Protocols/NFS/nfs3_fsinfo.c
M src/Protocols/NFS/nfs3_fsstat.c
M src/Protocols/NFS/nfs3_getattr.c
M src/Protocols/NFS/nfs3_link.c
M src/Protocols/NFS/nfs3_lookup.c
M src/Protocols/NFS/nfs3_mkdir.c
M src/Protocols/NFS/nfs3_mknod.c
M src/Protocols/NFS/nfs3_pathconf.c
M src/Protocols/NFS/nfs3_read.c
M src/Protocols/NFS/nfs3_readdir.c
M src/Protocols/NFS/nfs3_readdirplus.c
M src/Protocols/NFS/nfs3_readlink.c
M src/Protocols/NFS/nfs3_rename.c
M src/Protocols/NFS/nfs3_rmdir.c
M src/Protocols/NFS/nfs3_setattr.c
M src/Protocols/NFS/nfs3_symlink.c
M src/Protocols/NFS/nfs3_write.c
20 files changed, 176 insertions(+), 241 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/74/390874/1
-- 
To view, visit https://review.gerrithub.io/390874
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d78ffc75fc254b4ba016bd35348ab4ef906badd
Gerrit-Change-Number: 390874
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: GPFS: Clean up new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390864


Change subject: GPFS: Clean up new checkpatch errors
..

GPFS: Clean up new checkpatch errors

Change-Id: I34a1668d8d4216e60e46a1b11e41fbf8c79bc482
Signed-off-by: Frank S. Filz 
---
M src/FSAL/FSAL_GPFS/export.c
M src/FSAL/FSAL_GPFS/fsal_attrs.c
M src/FSAL/FSAL_GPFS/fsal_convert.c
M src/FSAL/FSAL_GPFS/fsal_create.c
M src/FSAL/FSAL_GPFS/fsal_fileop.c
M src/FSAL/FSAL_GPFS/fsal_internal.c
M src/FSAL/FSAL_GPFS/fsal_lock.c
M src/FSAL/FSAL_GPFS/fsal_mds.c
M src/FSAL/FSAL_GPFS/fsal_symlinks.c
M src/FSAL/FSAL_GPFS/fsal_up.c
10 files changed, 65 insertions(+), 70 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/64/390864/1
-- 
To view, visit https://review.gerrithub.io/390864
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I34a1668d8d4216e60e46a1b11e41fbf8c79bc482
Gerrit-Change-Number: 390864
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: PROXY: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390866


Change subject: PROXY: Cleanup new checkpatch errors
..

PROXY: Cleanup new checkpatch errors

Change-Id: I939f5faa5339f0d5fef89fa1e0d91d7cbefade2e
Signed-off-by: Frank S. Filz 
---
M src/FSAL/FSAL_PROXY/handle.c
M src/FSAL/FSAL_PROXY/handle_mapping/handle_mapping.c
M src/FSAL/FSAL_PROXY/handle_mapping/handle_mapping_db.c
3 files changed, 14 insertions(+), 12 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/66/390866/1
-- 
To view, visit https://review.gerrithub.io/390866
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I939f5faa5339f0d5fef89fa1e0d91d7cbefade2e
Gerrit-Change-Number: 390866
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: NULL: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390869


Change subject: NULL: Cleanup new checkpatch errors
..

NULL: Cleanup new checkpatch errors

Change-Id: Ieb84f4fef3df09fbcc9a16cdb57ea94cfaa4325b
Signed-off-by: Frank S. Filz 
---
M src/FSAL/Stackable_FSALs/FSAL_NULL/export.c
M src/FSAL/Stackable_FSALs/FSAL_NULL/handle.c
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/69/390869/1
-- 
To view, visit https://review.gerrithub.io/390869
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb84f4fef3df09fbcc9a16cdb57ea94cfaa4325b
Gerrit-Change-Number: 390869
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: CEPH: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390862


Change subject: CEPH: Cleanup new checkpatch errors
..

CEPH: Cleanup new checkpatch errors

Change-Id: I364aff7db1a143e554a07560f1878a56a372a9c7
Signed-off-by: Frank S. Filz 
---
M src/FSAL/FSAL_CEPH/ds.c
M src/FSAL/FSAL_CEPH/mds.c
2 files changed, 8 insertions(+), 9 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/62/390862/1
-- 
To view, visit https://review.gerrithub.io/390862
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I364aff7db1a143e554a07560f1878a56a372a9c7
Gerrit-Change-Number: 390862
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL and FSAL_UP: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390870


Change subject: FSAL and FSAL_UP: Cleanup new checkpatch errors
..

FSAL and FSAL_UP: Cleanup new checkpatch errors

Change-Id: I6efa95690dbee6d1af9de67df31d76932a426e24
Signed-off-by: Frank S. Filz 
---
M src/FSAL/access_check.c
M src/FSAL/common_pnfs.c
M src/FSAL/commonlib.c
M src/FSAL/fsal_helper.c
M src/FSAL_UP/fsal_up_top.c
M src/include/fsal_types.h
6 files changed, 21 insertions(+), 15 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/70/390870/1
-- 
To view, visit https://review.gerrithub.io/390870
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6efa95690dbee6d1af9de67df31d76932a426e24
Gerrit-Change-Number: 390870
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: RGW: Cleanup new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390867


Change subject: RGW: Cleanup new checkpatch errors
..

RGW: Cleanup new checkpatch errors

Change-Id: If42b81b3abcfde4561a0303a9a3521f2da55885a
Signed-off-by: Frank S. Filz 
---
M src/FSAL/FSAL_RGW/export.c
M src/FSAL/FSAL_RGW/internal.c
2 files changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/67/390867/1
-- 
To view, visit https://review.gerrithub.io/390867
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: If42b81b3abcfde4561a0303a9a3521f2da55885a
Gerrit-Change-Number: 390867
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: GLUSTER: Clean up new checkpatch errors

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390863


Change subject: GLUSTER: Clean up new checkpatch errors
..

GLUSTER: Clean up new checkpatch errors

Change-Id: Ib47c7c5e256ff3e7d6dd70fae486eb2cba704534
Signed-off-by: Frank S. Filz 
---
M src/FSAL/FSAL_GLUSTER/ds.c
M src/FSAL/FSAL_GLUSTER/export.c
M src/FSAL/FSAL_GLUSTER/gluster_internal.c
M src/FSAL/FSAL_GLUSTER/handle.c
M src/FSAL/FSAL_GLUSTER/mds.c
M src/FSAL/FSAL_GLUSTER/posix_acls.c
6 files changed, 92 insertions(+), 96 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/63/390863/1
-- 
To view, visit https://review.gerrithub.io/390863
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib47c7c5e256ff3e7d6dd70fae486eb2cba704534
Gerrit-Change-Number: 390863
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Update checkpatch.pl from kernel v4.15-rc2

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/390861


Change subject: Update checkpatch.pl from kernel v4.15-rc2
..

Update checkpatch.pl from kernel v4.15-rc2

Change-Id: I42b182912722bb7704cf20ebb93e0d5e0ab7a5df
Signed-off-by: Frank S. Filz 
---
M src/scripts/checkpatch.conf
M src/scripts/checkpatch.pl
2 files changed, 730 insertions(+), 247 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/61/390861/1
-- 
To view, visit https://review.gerrithub.io/390861
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I42b182912722bb7704cf20ebb93e0d5e0ab7a5df
Gerrit-Change-Number: 390861
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: ntirpc pullup - fix leak

[GerritHub]

>From Daniel Gryniewicz :

Daniel Gryniewicz has uploaded this change for review. ( 
https://review.gerrithub.io/390851


Change subject: ntirpc pullup - fix leak
..

ntirpc pullup - fix leak

This ntirpc pullup fixes a leak on startup if rpcb_findaddr returns an
empty address.

Change-Id: Iff945dbc5a645b0fd1bd8474f88d74bff49430bc
Signed-off-by: Daniel Gryniewicz 
---
M src/libntirpc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/51/390851/1
-- 
To view, visit https://review.gerrithub.io/390851
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff945dbc5a645b0fd1bd8474f88d74bff49430bc
Gerrit-Change-Number: 390851
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] leaky file handles in v2.5.4

[Wyllys Ingersoll]

There is a long standing issue in ganesha.nfsd
(https://github.com/nfs-ganesha/nfs-ganesha/issues/179) where the
server continues to hold a file descriptor for an exported directory
even after it has been un-exported.

The instructions for recreating it are trivial and listed in the issue
above. Is anyone looking into this ?

This is important because it causes problems on NFS servers when you
want/need to remove an export and unmount it from the system since the
kernel will not allow it to be unmounted if another process is holding
a file descriptor for that directory node.  The workaround is to
restart ganesha.nfsd but that can cause disruptions to existing shares
and should not be necessary.

Wyllys Ingersoll

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel