Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: "mdc_lookup" do not dispatch to FSAL

[Sachin Punadikar]

Bill,
The issue is always re-producible for the customer.
In another email chain, I have provided the Ganesha logs, which clearly
indicates the lookup do not goes to FSAL layer to fetch the more current
data if uncached is set to false.

On Fri, Feb 16, 2018 at 9:40 PM, William Allen Simpson <
william.allen.simp...@gmail.com> wrote:

> On 2/15/18 6:44 AM, GerritHub wrote:
>
>> Sachin Punadikar has uploaded this change for *review*.
>>
>> View Change 
>>
>> "mdc_lookup" do not dispatch to FSAL
>>
>> Are you sure?  Do you have an actual reproducible error case?
>
>
> "mdc_lookup" function first attempts to get the entry from cache
>> via function "mdc_try_get_cached". On getting ESATLE error, it
>> should dispatch to FSAL, but was again calling "mdc_try_get_cached".
>> Rectified code to make call to "mdc_lookup_uncached", so FSAL code
>> gets invoked.
>>
>> I'm not the mdcache expert, but don't think this is correct.  The
> comments already explain.
>
> It tries under read lock (fastest).  If stale, it write locks and
> tries again.  If still fails, at the uncached label, then it does
> the mdc_lookup_uncached().
>
> mdc_try_get_cached() is likely faster than mdc_lookup_uncached().
>
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>



-- 
with regards,
Sachin Punadikar
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: "mdc_lookup" do not dispatch to FSAL

[William Allen Simpson]

On 2/19/18 12:12 PM, Sachin Punadikar wrote:

Hi Bill,
I rechecked the logs & discussed with Daniel. I missed to see the log entries 
related to FSAL.
So for this customer it looks like FSAL issue than a Ganesha issue


Thanks for the update.  The default log levels don't always show enough.



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: "mdc_lookup" do not dispatch to FSAL

[William Allen Simpson]

On 2/15/18 6:44 AM, GerritHub wrote:

Sachin Punadikar has uploaded this change for *review*.

View Change 

"mdc_lookup" do not dispatch to FSAL


Are you sure?  Do you have an actual reproducible error case?



"mdc_lookup" function first attempts to get the entry from cache
via function "mdc_try_get_cached". On getting ESATLE error, it
should dispatch to FSAL, but was again calling "mdc_try_get_cached".
Rectified code to make call to "mdc_lookup_uncached", so FSAL code
gets invoked.


I'm not the mdcache expert, but don't think this is correct.  The
comments already explain.

It tries under read lock (fastest).  If stale, it write locks and
tries again.  If still fails, at the uncached label, then it does
the mdc_lookup_uncached().

mdc_try_get_cached() is likely faster than mdc_lookup_uncached().

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: "mdc_lookup" do not dispatch to FSAL

[GerritHub]

>From Sachin Punadikar :

Sachin Punadikar has uploaded this change for review. ( 
https://review.gerrithub.io/400037


Change subject: "mdc_lookup" do not dispatch to FSAL
..

"mdc_lookup" do not dispatch to FSAL

"mdc_lookup" function first attempts to get the entry from cache
via function "mdc_try_get_cached". On getting ESATLE error, it
should dispatch to FSAL, but was again calling "mdc_try_get_cached".
Rectified code to make call to "mdc_lookup_uncached", so FSAL code
gets invoked.

Change-Id: Idf3eed7e64b285e862cccd7d4c5a1fa501633877
Signed-off-by: Sachin Punadikar 
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
1 file changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha 
refs/changes/37/400037/1
--
To view, visit https://review.gerrithub.io/400037
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf3eed7e64b285e862cccd7d4c5a1fa501633877
Gerrit-Change-Number: 400037
Gerrit-PatchSet: 1
Gerrit-Owner: Sachin Punadikar 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel