Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Embed rpc_msg in svc_req

[William Allen Simpson]

As promised on yesterday's call, I've merged all the updates to
libntirpc in this patch set 4, even though its title would indicate a
patch in the middle of the past month's worth of updates.

This is a boring patch.  It has no substantive changes.  It consists
entirely of formatting and symbol name changes.  It has been waiting
since US Thanksgiving weekend, and was originally 19 months ago.

--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Embed rpc_msg in svc_req

[William Allen Simpson]

On 1/4/17 1:35 PM, William Allen Simpson wrote:
> On 1/3/17 2:22 PM, GerritHub wrote:
>> Frank Filz *posted comments* on this change.
>>
>> Would nfs_core_param be short enough?
>>
>> There really isn't any reason to bundle all the different param 
>> structures in a structure. If we
>>
> Agreed, but not a focus of this patch.  It would be much more intrusive.
>
Looking at this today, turns out there is some kind of reason to have
3 and 4 level structs.  Mostly because GSS is conditionally compiled.

It's in gsh_config.h -- blame Adam Emerson.


>
>> #define nfs_core_param nfs_param.core_param
>>
> That would be nice.
>
Nope, already in use in typedef struct nfs_core_param.


> This one works now, as opposed to something better in the future.
>
Yep, my shorter contractions are a better long-term fit for this code.
They are clearer (defines having leading UPPER CASE), with fewer conflicts.


--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Embed rpc_msg in svc_req

[GerritHub]

>From :

william.allen.simp...@gmail.com has uploaded a new change for review. ( 
https://review.gerrithub.io/307526


Change subject: Embed rpc_msg in svc_req
..

Embed rpc_msg in svc_req

Avoids separate alloc/free -- this is much more efficient.

Remove obsolete pointer rq_clntcred.

Rename a couple of ambiguous deliberately misspelled symbols, as they
were still too long for some lines.  Now RPCM_ack and RPCM_rej.

Also, defined NFS_pcp, NFS_pcpco, and NFS_pcpp instead of
nfs_param.core_param.core_options and nfs_param.core_param.program
-- had become too long for some lines.

Use proper defined symbols for formatting standard typedefs.

Change-Id: I4b940182aa3abfd99d7dd049e0129f34de6a57a9
Signed-off-by: William Allen Simpson 
---
M src/FSAL/FSAL_PROXY/handle.c
M src/MainNFSD/nfs_rpc_dispatcher_thread.c
M src/MainNFSD/nfs_worker_thread.c
M src/Protocols/NFS/mnt_Mnt.c
M src/Protocols/NFS/nfs3_create.c
M src/Protocols/NFS/nfs3_fsstat.c
M src/Protocols/NFS/nfs3_getattr.c
M src/Protocols/NFS/nfs3_link.c
M src/Protocols/NFS/nfs3_lookup.c
M src/Protocols/NFS/nfs3_mkdir.c
M src/Protocols/NFS/nfs3_read.c
M src/Protocols/NFS/nfs3_readdir.c
M src/Protocols/NFS/nfs3_readlink.c
M src/Protocols/NFS/nfs3_remove.c
M src/Protocols/NFS/nfs3_rename.c
M src/Protocols/NFS/nfs3_rmdir.c
M src/Protocols/NFS/nfs3_setattr.c
M src/Protocols/NFS/nfs3_symlink.c
M src/Protocols/NFS/nfs3_write.c
M src/Protocols/NLM/nlm_Lock.c
M src/Protocols/RQUOTA/rquota_getquota.c
M src/Protocols/RQUOTA/rquota_setquota.c
M src/RPCAL/nfs_dupreq.c
M src/libntirpc
M src/support/exports.c
M src/support/nfs_creds.c
M src/support/server_stats.c
27 files changed, 321 insertions(+), 270 deletions(-)



  git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha 
refs/changes/26/307526/1
-- 
To view, visit https://review.gerrithub.io/307526
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b940182aa3abfd99d7dd049e0129f34de6a57a9
Gerrit-Change-Number: 307526
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: william.allen.simp...@gmail.com
--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel