Re: [Nmh-workers] test-slocal

2013-04-18 Thread Paul Fox
david wrote:
 > Paul F. wrote:
 > 
 > > so it looks to me like this command:
 > > 
 > > /home/pgf/src/pdom/nmh/nmh.git/test/testdir/inst/usr/local/nmh.git/lib/sl
 > > ocal -maildelivery 
 > > /home/pgf/src/pdom/nmh/nmh.git/test/testdir/Mail/maildeliv
 > > ery
 > > should have produced the .actual file, but didn't.  the contents of that
 > > maildelivery file is:
 > > * 1 qpipe A "/usr/bin/tee
 > > /home/pgf/src/pdom/nmh/nmh.git/test/testdir/13697.actual"
 > 
 > That looks right.  /usr/bin/tee will only be used if it
 > exists.
 > 
 > How about adding "-verbose -debug" here and then see if the test output
 > has any clues:
 > 
 > --- a/test/slocal/test-slocal
 > +++ b/test/slocal/test-slocal
 > @@ -80 +80 @@ EOF
 > -$slocal -maildelivery $md $mbox <"$MH_TEST_DIR"/Mail/inbox/1
 > +$slocal -verbose -debug -maildelivery $md $mbox <"$MH_TEST_DIR"/Mail/inbox/1
 > 
 > Maybe I'll add that to the test if that first non-trivial slocal fails.

that gives:

WARNING: /home/pgf/src/pdom/nmh/nmh.git/test/testdir/Mail/maildelivery has bad 
ownership/modes (su=0,uid=1000,owner=1000,mode=0100664)
(delivering to standard mail spool)
delivering to file "/home/pgf/src/pdom/nmh/nmh.git/test/testdir/Mail/maildrop" 
(mbox style), success.
+ check /home/pgf/src/pdom/nmh/nmh.git/test/testdir/Mail/inbox/1 
/home/pgf/src/pdom/nmh/nmh.git/test/testdir/3581.actual keep first
+ cmp /home/pgf/src/pdom/nmh/nmh.git/test/testdir/Mail/inbox/1 
/home/pgf/src/pdom/nmh/nmh.git/test/testdir/3581.actual
cmp: /home/pgf/src/pdom/nmh/nmh.git/test/testdir/3581.actual: No such file or 
directory
+ echo

+ diff -c /home/pgf/src/pdom/nmh/nmh.git/test/testdir/Mail/inbox/1 
/home/pgf/src/pdom/nmh/nmh.git/test/testdir/3581.actual
diff: /home/pgf/src/pdom/nmh/nmh.git/test/testdir/3581.actual: No such file or 
directory


--
 paul fox, p...@foxharp.boston.ma.us (arlington, ma, where it's 52.2 degrees)

___
Nmh-workers mailing list
Nmh-workers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/nmh-workers


Re: [Nmh-workers] test-slocal

2013-04-18 Thread David Levine
Paul wrote:

> WARNING: /home/pgf/src/pdom/nmh/nmh.git/test/testdir/Mail/maildelivery has
> bad ownership/modes (su=0,uid=1000,owner=1000,mode=0100664)
> (delivering to standard mail spool)

So you have a umask of 0002?

I'll add this to the test, that should fix it:

@@ -78,0 +79 @@ EOF
+chmod go-w $md

David

___
Nmh-workers mailing list
Nmh-workers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/nmh-workers


Re: [Nmh-workers] test-slocal

2013-04-18 Thread Paul Fox
david wrote:
 > Paul wrote:
 > 
 > > WARNING: /home/pgf/src/pdom/nmh/nmh.git/test/testdir/Mail/maildelivery has
 > > bad ownership/modes (su=0,uid=1000,owner=1000,mode=0100664)
 > > (delivering to standard mail spool)
 > 
 > So you have a umask of 0002?

yes.

 > 
 > I'll add this to the test, that should fix it:
 > 
 > @@ -78,0 +79 @@ EOF
 > +chmod go-w $md

fixed.  thanks!

paul
--
 paul fox, p...@foxharp.boston.ma.us (arlington, ma, where it's 53.2 degrees)

___
Nmh-workers mailing list
Nmh-workers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/nmh-workers


Re: [Nmh-workers] test-slocal

2013-04-18 Thread Lyndon Nerenberg

On 2013-04-18, at 8:16 AM, David Levine wrote:

> So you have a umask of 0002?
> 
> I'll add this to the test, that should fix it:

Why not set an explicit umask instead?

___
Nmh-workers mailing list
Nmh-workers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/nmh-workers


Re: [Nmh-workers] test-slocal

2013-04-18 Thread David Levine
Lyndon wrote:

> On 2013-04-18, at 8:16 AM, David Levine wrote:
> 
> > So you have a umask of 0002?
> > 
> > I'll add this to the test, that should fix it:
> 
> Why not set an explicit umask instead?

I prefer that the test suite not hide other situations where
it also might matter.  Though in this case, I don't think
there are any.

David


___
Nmh-workers mailing list
Nmh-workers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/nmh-workers


Re: [Nmh-workers] test-slocal

2013-04-19 Thread Ralph Corderoy
Hi,

Lyndon wrote:
> > So you have a umask of 0002?
> > I'll add this to the test, that should fix it:
> 
> Why not set an explicit umask instead?

That was my first thought, but then I considered if instead of fixing
that part of the environment at that low level whether it should be left
so the whole test-suite could be run under different umasks at a higher
level.  Similarly, SHELL could be /bin/csh sometimes.  ;-)

Cheers, Ralph.

___
Nmh-workers mailing list
Nmh-workers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/nmh-workers