[nodejs] Re: Curious question about node/lib/module.js

2013-04-11 Thread Dave Clements

I think this would be more of a design choice, overhead to requiring
modules is minimal - if the same module  in a parent module is
required in a child module I believe its already cached, plus
requiring is a one time only event at the beginning of execution the
already minimal cost of requiring is amortized over time.

All that function does is provide a shothand for checking that a
property belongs to an object (and not to an ibject inherited from).

On Apr 10, 1:50 pm, Arıl Bozoluk arlbozo...@gmail.com wrote:
 Hi,

  I'm new to Javascript world so this question might be pointless.

  Today I was roaming in node source code in github and something got my
 attention.

  In node/lib/util.js there is this function:

 function hasOwnProperty(obj, prop) {
   return Object.prototype.hasOwnProperty.call(obj, prop);

 }

 And in node/lib/module.js line:32 exact function created again instead of 
 requiring util.js.

 Is this an issue or requiring util.js is much more load than creating this 
 function again in module.js?

 Regards

-- 
-- 
Job Board: http://jobs.nodejs.org/
Posting guidelines: 
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups nodejs group.
To post to this group, send email to nodejs@googlegroups.com
To unsubscribe from this group, send email to
nodejs+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
nodejs group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to nodejs+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[nodejs] Re: Curious question about node/lib/module.js

2013-04-10 Thread Bradley Meck
I am very wary of the module system needing to load modules, the less 
external dependencies the better. That being said, you could use the built 
in util functions, but then if a user application modifies the util 
functions it will cause problems in module.js; tradeoffs.

-- 
-- 
Job Board: http://jobs.nodejs.org/
Posting guidelines: 
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups nodejs group.
To post to this group, send email to nodejs@googlegroups.com
To unsubscribe from this group, send email to
nodejs+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en

--- 
You received this message because you are subscribed to the Google Groups 
nodejs group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to nodejs+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.