[nodejs] Re: HTTP client request headers (lowercase) issue
Looks like this change stills in v0.8.15 of node.js, I'm trying to authenticate to an OAuth provider and I've the same problem. My provider is not able to recognize the authorization header. Do we have a fix for that issue? On Tuesday, March 8, 2011 9:43:56 PM UTC-3, Eran Hammer-Lahav wrote: > > A recent update changed how client request headers are sent to force all > headers to lowercase. This is causing problems with some well-established > (and non-compliant) servers which look for specific case-sensitive > formatting. My application is now failing on both the 'Authorization' and > 'Cookie' headers with some large providers. > > I see the value in changing incoming headers to lowercase, but it would be > better to leave outbound headers alone and allow applications to set the > headers to the exact format expected by the server in case of a misbehaving > provider. > > Can this be changed back? > > EHL > -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to nodejs@googlegroups.com To unsubscribe from this group, send email to nodejs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
[nodejs] Re: HTTP client request headers (lowercase) issue
On Dec 2, 10:06 am, Cristian Bullokles wrote: > 3. My node http client is sending lowercased headers in the request. > > I'm sending this headers: > > Authorization: Bearer > > and the http.request client is sending: > > authorization: Bearer How are you verifying the case of the header name? If you're testing with a node server and doing `console.dir(req.headers);` it will show a lowercase key in the object. However, if you use tcpdump/Wireshark/ etc., you will see the node http client _does_ send the header name as "Authorization." -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to nodejs@googlegroups.com To unsubscribe from this group, send email to nodejs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
[nodejs] Re: HTTP client request headers (lowercase) issue
I seem to be having this problem, not sure what the solution or workaround
is.
I'm writing the head as follows:
response.writeHead (200, {"Content-Type": "text/html",
"Access-Control-Allow-Origin": "fargo.io"});
When it shows up on the client, the header names are lowercased.
Happens in two clients, so I'm fairly sure it's the server doing this.
It doesn't look like this was resolved in 2012.
Help! :-)
Dave
On Tuesday, March 8, 2011 7:43:56 PM UTC-5, Eran Hammer-Lahav wrote:
>
> A recent update changed how client request headers are sent to force all
> headers to lowercase. This is causing problems with some well-established
> (and non-compliant) servers which look for specific case-sensitive
> formatting. My application is now failing on both the 'Authorization' and
> 'Cookie' headers with some large providers.
>
> I see the value in changing incoming headers to lowercase, but it would be
> better to leave outbound headers alone and allow applications to set the
> headers to the exact format expected by the server in case of a misbehaving
> provider.
>
> Can this be changed back?
>
> EHL
>
--
--
Job Board: http://jobs.nodejs.org/
Posting guidelines:
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to nodejs@googlegroups.com
To unsubscribe from this group, send email to
nodejs+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en
---
You received this message because you are subscribed to the Google Groups
"nodejs" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to nodejs+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[nodejs] Re: HTTP client request headers (lowercase) issue
What node version are you using? Works fine for me on v0.10.25:
$ cat test.js
require('http').createServer(function(req, res) {
res.writeHead(200, {Something: 'yep'})
res.end()
}).listen(3000)
$ node test.js &
[1] 85457
$ curl -v localhost:3000
* Adding handle: conn: 0x7fdc09004000
* Adding handle: send: 0
* Adding handle: recv: 0
* Curl_addHandleToPipeline: length: 1
* - Conn 0 (0x7fdc09004000) send_pipe: 1, recv_pipe: 0
* About to connect() to localhost port 3000 (#0)
* Trying ::1...
* Trying 127.0.0.1...
* Connected to localhost (127.0.0.1) port 3000 (#0)
> GET / HTTP/1.1
> User-Agent: curl/7.30.0
> Host: localhost:3000
> Accept: */*
>
< HTTP/1.1 200 OK
< Something: yep
< Date: Fri, 24 Jan 2014 06:59:58 GMT
< Connection: keep-alive
< Transfer-Encoding: chunked
<
* Connection #0 to host localhost left intact
On Friday, 24 January 2014 06:20:19 UTC+11, Dave Winer wrote:
>
> I seem to be having this problem, not sure what the solution or workaround
> is.
>
> I'm writing the head as follows:
>
> response.writeHead (200, {"Content-Type": "text/html",
> "Access-Control-Allow-Origin": "fargo.io"});
>
> When it shows up on the client, the header names are lowercased.
>
> Happens in two clients, so I'm fairly sure it's the server doing this.
>
> It doesn't look like this was resolved in 2012.
>
> Help! :-)
>
> Dave
>
>
>
> On Tuesday, March 8, 2011 7:43:56 PM UTC-5, Eran Hammer-Lahav wrote:
>>
>> A recent update changed how client request headers are sent to force all
>> headers to lowercase. This is causing problems with some well-established
>> (and non-compliant) servers which look for specific case-sensitive
>> formatting. My application is now failing on both the 'Authorization' and
>> 'Cookie' headers with some large providers.
>>
>> I see the value in changing incoming headers to lowercase, but it would
>> be better to leave outbound headers alone and allow applications to set the
>> headers to the exact format expected by the server in case of a misbehaving
>> provider.
>>
>> Can this be changed back?
>>
>> EHL
>>
>
--
--
Job Board: http://jobs.nodejs.org/
Posting guidelines:
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to nodejs@googlegroups.com
To unsubscribe from this group, send email to
nodejs+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en
---
You received this message because you are subscribed to the Google Groups
"nodejs" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to nodejs+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: [nodejs] Re: HTTP client request headers (lowercase) issue
AFAIK outgoing headers are not lowercased. Do you have a test case? danmilon. On Sat, Dec 1, 2012 at 10:01 PM, Cristian Bullokles wrote: > Looks like this change stills in v0.8.15 of node.js, I'm trying to > authenticate to an OAuth provider and I've the same problem. My provider is > not able to recognize the authorization header. > Do we have a fix for that issue? > > > > On Tuesday, March 8, 2011 9:43:56 PM UTC-3, Eran Hammer-Lahav wrote: >> >> A recent update changed how client request headers are sent to force all >> headers to lowercase. This is causing problems with some well-established >> (and non-compliant) servers which look for specific case-sensitive >> formatting. My application is now failing on both the 'Authorization' and >> 'Cookie' headers with some large providers. >> >> I see the value in changing incoming headers to lowercase, but it would be >> better to leave outbound headers alone and allow applications to set the >> headers to the exact format expected by the server in case of a misbehaving >> provider. >> >> Can this be changed back? >> >> EHL > > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to nodejs@googlegroups.com > To unsubscribe from this group, send email to > nodejs+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to nodejs@googlegroups.com To unsubscribe from this group, send email to nodejs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
Re: [nodejs] Re: HTTP client request headers (lowercase) issue
by default node.js sends headers in lowercase. by spec, HTTP headers are caseless. if someone does not treat them that way you email them and ask them why they suck at HTTP. On Dec 1, 2012, at December 1, 20124:50 PM, Dan Milon wrote: > AFAIK outgoing headers are not lowercased. Do you have a test case? > > danmilon. > > On Sat, Dec 1, 2012 at 10:01 PM, Cristian Bullokles > wrote: >> Looks like this change stills in v0.8.15 of node.js, I'm trying to >> authenticate to an OAuth provider and I've the same problem. My provider is >> not able to recognize the authorization header. >> Do we have a fix for that issue? >> >> >> >> On Tuesday, March 8, 2011 9:43:56 PM UTC-3, Eran Hammer-Lahav wrote: >>> >>> A recent update changed how client request headers are sent to force all >>> headers to lowercase. This is causing problems with some well-established >>> (and non-compliant) servers which look for specific case-sensitive >>> formatting. My application is now failing on both the 'Authorization' and >>> 'Cookie' headers with some large providers. >>> >>> I see the value in changing incoming headers to lowercase, but it would be >>> better to leave outbound headers alone and allow applications to set the >>> headers to the exact format expected by the server in case of a misbehaving >>> provider. >>> >>> Can this be changed back? >>> >>> EHL >> >> -- >> Job Board: http://jobs.nodejs.org/ >> Posting guidelines: >> https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines >> You received this message because you are subscribed to the Google >> Groups "nodejs" group. >> To post to this group, send email to nodejs@googlegroups.com >> To unsubscribe from this group, send email to >> nodejs+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/nodejs?hl=en?hl=en > > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to nodejs@googlegroups.com > To unsubscribe from this group, send email to > nodejs+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to nodejs@googlegroups.com To unsubscribe from this group, send email to nodejs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
Re: [nodejs] Re: HTTP client request headers (lowercase) issue
On Sun, Dec 2, 2012 at 2:07 AM, Mikeal Rogers wrote: > by default node.js sends headers in lowercase. The core http library sends headers as-is, it's only incoming headers that are lowercased. Maybe some frameworks force lowercase everywhere but node.js itself does not. -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to nodejs@googlegroups.com To unsubscribe from this group, send email to nodejs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
Re: [nodejs] Re: HTTP client request headers (lowercase) issue
I just tested this, and it seems it wont touch them. [1] I recall having this issue with S3 not recognizing lowercased content-length header. And explicitly setting the header key as Content-Length fixed it. [1] https://gist.github.com/4186458 danmilon. On Sun, Dec 2, 2012 at 3:07 AM, Mikeal Rogers wrote: > by default node.js sends headers in lowercase. by spec, HTTP headers are > caseless. if someone does not treat them that way you email them and ask them > why they suck at HTTP. > > On Dec 1, 2012, at December 1, 20124:50 PM, Dan Milon > wrote: > >> AFAIK outgoing headers are not lowercased. Do you have a test case? >> >> danmilon. >> >> On Sat, Dec 1, 2012 at 10:01 PM, Cristian Bullokles >> wrote: >>> Looks like this change stills in v0.8.15 of node.js, I'm trying to >>> authenticate to an OAuth provider and I've the same problem. My provider is >>> not able to recognize the authorization header. >>> Do we have a fix for that issue? >>> >>> >>> >>> On Tuesday, March 8, 2011 9:43:56 PM UTC-3, Eran Hammer-Lahav wrote: A recent update changed how client request headers are sent to force all headers to lowercase. This is causing problems with some well-established (and non-compliant) servers which look for specific case-sensitive formatting. My application is now failing on both the 'Authorization' and 'Cookie' headers with some large providers. I see the value in changing incoming headers to lowercase, but it would be better to leave outbound headers alone and allow applications to set the headers to the exact format expected by the server in case of a misbehaving provider. Can this be changed back? EHL >>> >>> -- >>> Job Board: http://jobs.nodejs.org/ >>> Posting guidelines: >>> https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines >>> You received this message because you are subscribed to the Google >>> Groups "nodejs" group. >>> To post to this group, send email to nodejs@googlegroups.com >>> To unsubscribe from this group, send email to >>> nodejs+unsubscr...@googlegroups.com >>> For more options, visit this group at >>> http://groups.google.com/group/nodejs?hl=en?hl=en >> >> -- >> Job Board: http://jobs.nodejs.org/ >> Posting guidelines: >> https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines >> You received this message because you are subscribed to the Google >> Groups "nodejs" group. >> To post to this group, send email to nodejs@googlegroups.com >> To unsubscribe from this group, send email to >> nodejs+unsubscr...@googlegroups.com >> For more options, visit this group at >> http://groups.google.com/group/nodejs?hl=en?hl=en > > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to nodejs@googlegroups.com > To unsubscribe from this group, send email to > nodejs+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to nodejs@googlegroups.com To unsubscribe from this group, send email to nodejs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
Re: [nodejs] Re: HTTP client request headers (lowercase) issue
headers core sets, like transfer-encoding and host will be lowercase. On Dec 1, 2012, at December 1, 20125:40 PM, Ben Noordhuis wrote: > On Sun, Dec 2, 2012 at 2:07 AM, Mikeal Rogers wrote: >> by default node.js sends headers in lowercase. > > The core http library sends headers as-is, it's only incoming headers > that are lowercased. > > Maybe some frameworks force lowercase everywhere but node.js itself does not. > > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to nodejs@googlegroups.com > To unsubscribe from this group, send email to > nodejs+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to nodejs@googlegroups.com To unsubscribe from this group, send email to nodejs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
Re: [nodejs] Re: HTTP client request headers (lowercase) issue
On Sun, Dec 2, 2012 at 3:53 AM, Mikeal Rogers wrote: > headers core sets, like transfer-encoding and host will be lowercase. Wrong again. Auto-added headers like Authorization, Date, Content-Length, Transfer-Encoding, etc. are all properly capitalized. -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to nodejs@googlegroups.com To unsubscribe from this group, send email to nodejs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
Re: [nodejs] Re: HTTP client request headers (lowercase) issue
Debugging my code with node-inspector I found the code below.
The problem is in line:
var key = name.toLowerCase();
What is the value added of lowercase headers in outgoing messages?
Regards
Cristian
File: http.js
Line 639 to 653
OutgoingMessage.prototype.setHeader = function(name, value) {
if (arguments.length < 2) {
throw new Error('`name` and `value` are required for setHeader().');
}
if (this._header) {
throw new Error('Can\'t set headers after they are sent.');
}
var key = name.toLowerCase();
this._headers = this._headers || {};
this._headerNames = this._headerNames || {};
this._headers[key] = value;
this._headerNames[key] = name;
};
On Sun, Dec 2, 2012 at 12:04 AM, Ben Noordhuis wrote:
> On Sun, Dec 2, 2012 at 3:53 AM, Mikeal Rogers
> wrote:
> > headers core sets, like transfer-encoding and host will be lowercase.
>
> Wrong again. Auto-added headers like Authorization, Date,
> Content-Length, Transfer-Encoding, etc. are all properly capitalized.
>
> --
> Job Board: http://jobs.nodejs.org/
> Posting guidelines:
> https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
> You received this message because you are subscribed to the Google
> Groups "nodejs" group.
> To post to this group, send email to nodejs@googlegroups.com
> To unsubscribe from this group, send email to
> nodejs+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/nodejs?hl=en?hl=en
>
--
Job Board: http://jobs.nodejs.org/
Posting guidelines:
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to nodejs@googlegroups.com
To unsubscribe from this group, send email to
nodejs+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en
Re: [nodejs] Re: HTTP client request headers (lowercase) issue
So, in that bit of code, if you do setHeader('x-FoO', 'baR'), then:
this._headers['x-foo'] === 'baR'
this._headerNames['x-foo'] === 'x-FoO'
Later, when it actually writes the header lines, it writes:
this._headerNames['x-foo'] + ': ' + this._headers['x-foo'] + '\r\n'
or in other words:
'x-FoO: baR\r\n'
just like you asked it to.
This code is about the outgoing headers that *your app* sends out.
(Ie, the HTTP response in a Server, or the HTTP request in a Client.)
Without theories about *why* it is, can you you clarify what you're
actually having problems with?
1. My node http server is sending lowercased headers in the response.
2. My node http server is receiving lowercased headers in the request.
3. My node http client is sending lowercased headers in the request.
4. My node http client is receiving lowercased headers in the response.
On Sat, Dec 1, 2012 at 8:04 PM, Cristian Bullokles
wrote:
> Debugging my code with node-inspector I found the code below.
> The problem is in line:
> var key = name.toLowerCase();
>
> What is the value added of lowercase headers in outgoing messages?
>
> Regards
> Cristian
>
> File: http.js
> Line 639 to 653
>
> OutgoingMessage.prototype.setHeader = function(name, value) {
> if (arguments.length < 2) {
> throw new Error('`name` and `value` are required for setHeader().');
> }
>
> if (this._header) {
> throw new Error('Can\'t set headers after they are sent.');
> }
>
> var key = name.toLowerCase();
> this._headers = this._headers || {};
> this._headerNames = this._headerNames || {};
> this._headers[key] = value;
> this._headerNames[key] = name;
> };
>
> On Sun, Dec 2, 2012 at 12:04 AM, Ben Noordhuis wrote:
>>
>> On Sun, Dec 2, 2012 at 3:53 AM, Mikeal Rogers
>> wrote:
>> > headers core sets, like transfer-encoding and host will be lowercase.
>>
>> Wrong again. Auto-added headers like Authorization, Date,
>> Content-Length, Transfer-Encoding, etc. are all properly capitalized.
>>
>> --
>> Job Board: http://jobs.nodejs.org/
>> Posting guidelines:
>> https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
>> You received this message because you are subscribed to the Google
>> Groups "nodejs" group.
>> To post to this group, send email to nodejs@googlegroups.com
>> To unsubscribe from this group, send email to
>> nodejs+unsubscr...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/nodejs?hl=en?hl=en
>
>
> --
> Job Board: http://jobs.nodejs.org/
> Posting guidelines:
> https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
> You received this message because you are subscribed to the Google
> Groups "nodejs" group.
> To post to this group, send email to nodejs@googlegroups.com
> To unsubscribe from this group, send email to
> nodejs+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/nodejs?hl=en?hl=en
--
Job Board: http://jobs.nodejs.org/
Posting guidelines:
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to nodejs@googlegroups.com
To unsubscribe from this group, send email to
nodejs+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en
Re: [nodejs] Re: HTTP client request headers (lowercase) issue
3. My node http client is sending lowercased headers in the request.
I'm sending this headers:
Authorization: Bearer
and the http.request client is sending:
authorization: Bearer
I hope that helps.
-CB
On Sun, Dec 2, 2012 at 3:53 AM, Isaac Schlueter wrote:
> So, in that bit of code, if you do setHeader('x-FoO', 'baR'), then:
>
> this._headers['x-foo'] === 'baR'
> this._headerNames['x-foo'] === 'x-FoO'
>
> Later, when it actually writes the header lines, it writes:
>
> this._headerNames['x-foo'] + ': ' + this._headers['x-foo'] + '\r\n'
>
> or in other words:
>
> 'x-FoO: baR\r\n'
>
> just like you asked it to.
>
> This code is about the outgoing headers that *your app* sends out.
> (Ie, the HTTP response in a Server, or the HTTP request in a Client.)
>
>
> Without theories about *why* it is, can you you clarify what you're
> actually having problems with?
>
> 1. My node http server is sending lowercased headers in the response.
> 2. My node http server is receiving lowercased headers in the request.
> 3. My node http client is sending lowercased headers in the request.
> 4. My node http client is receiving lowercased headers in the response.
>
>
>
>
>
> On Sat, Dec 1, 2012 at 8:04 PM, Cristian Bullokles
> wrote:
> > Debugging my code with node-inspector I found the code below.
> > The problem is in line:
> > var key = name.toLowerCase();
> >
> > What is the value added of lowercase headers in outgoing messages?
> >
> > Regards
> > Cristian
> >
> > File: http.js
> > Line 639 to 653
> >
> > OutgoingMessage.prototype.setHeader = function(name, value) {
> > if (arguments.length < 2) {
> > throw new Error('`name` and `value` are required for setHeader().');
> > }
> >
> > if (this._header) {
> > throw new Error('Can\'t set headers after they are sent.');
> > }
> >
> > var key = name.toLowerCase();
> > this._headers = this._headers || {};
> > this._headerNames = this._headerNames || {};
> > this._headers[key] = value;
> > this._headerNames[key] = name;
> > };
> >
> > On Sun, Dec 2, 2012 at 12:04 AM, Ben Noordhuis
> wrote:
> >>
> >> On Sun, Dec 2, 2012 at 3:53 AM, Mikeal Rogers
> >> wrote:
> >> > headers core sets, like transfer-encoding and host will be lowercase.
> >>
> >> Wrong again. Auto-added headers like Authorization, Date,
> >> Content-Length, Transfer-Encoding, etc. are all properly capitalized.
> >>
> >> --
> >> Job Board: http://jobs.nodejs.org/
> >> Posting guidelines:
> >> https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
> >> You received this message because you are subscribed to the Google
> >> Groups "nodejs" group.
> >> To post to this group, send email to nodejs@googlegroups.com
> >> To unsubscribe from this group, send email to
> >> nodejs+unsubscr...@googlegroups.com
> >> For more options, visit this group at
> >> http://groups.google.com/group/nodejs?hl=en?hl=en
> >
> >
> > --
> > Job Board: http://jobs.nodejs.org/
> > Posting guidelines:
> > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
> > You received this message because you are subscribed to the Google
> > Groups "nodejs" group.
> > To post to this group, send email to nodejs@googlegroups.com
> > To unsubscribe from this group, send email to
> > nodejs+unsubscr...@googlegroups.com
> > For more options, visit this group at
> > http://groups.google.com/group/nodejs?hl=en?hl=en
>
> --
> Job Board: http://jobs.nodejs.org/
> Posting guidelines:
> https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
> You received this message because you are subscribed to the Google
> Groups "nodejs" group.
> To post to this group, send email to nodejs@googlegroups.com
> To unsubscribe from this group, send email to
> nodejs+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/nodejs?hl=en?hl=en
>
--
Job Board: http://jobs.nodejs.org/
Posting guidelines:
https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines
You received this message because you are subscribed to the Google
Groups "nodejs" group.
To post to this group, send email to nodejs@googlegroups.com
To unsubscribe from this group, send email to
nodejs+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/nodejs?hl=en?hl=en
Re: [nodejs] Re: HTTP client request headers (lowercase) issue
Yeah, show me the failing test, please. On Sun, Dec 2, 2012 at 8:00 AM, mscdex wrote: > On Dec 2, 10:06 am, Cristian Bullokles > wrote: >> 3. My node http client is sending lowercased headers in the request. >> >> I'm sending this headers: >> >> Authorization: Bearer >> >> and the http.request client is sending: >> >> authorization: Bearer > > How are you verifying the case of the header name? If you're testing > with a node server and doing `console.dir(req.headers);` it will show > a lowercase key in the object. However, if you use tcpdump/Wireshark/ > etc., you will see the node http client _does_ send the header name as > "Authorization." > > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to nodejs@googlegroups.com > To unsubscribe from this group, send email to > nodejs+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to nodejs@googlegroups.com To unsubscribe from this group, send email to nodejs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
Re: [nodejs] Re: HTTP client request headers (lowercase) issue
Will, try... but now I'm guessing that I saw the debugguer but the reality is that it is sending the right headers. Let me check with wireshark. On Sun, Dec 2, 2012 at 4:17 PM, Isaac Schlueter wrote: > Yeah, show me the failing test, please. > > On Sun, Dec 2, 2012 at 8:00 AM, mscdex wrote: > > On Dec 2, 10:06 am, Cristian Bullokles > > wrote: > >> 3. My node http client is sending lowercased headers in the request. > >> > >> I'm sending this headers: > >> > >> Authorization: Bearer > >> > >> and the http.request client is sending: > >> > >> authorization: Bearer > > > > How are you verifying the case of the header name? If you're testing > > with a node server and doing `console.dir(req.headers);` it will show > > a lowercase key in the object. However, if you use tcpdump/Wireshark/ > > etc., you will see the node http client _does_ send the header name as > > "Authorization." > > > > -- > > Job Board: http://jobs.nodejs.org/ > > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > > You received this message because you are subscribed to the Google > > Groups "nodejs" group. > > To post to this group, send email to nodejs@googlegroups.com > > To unsubscribe from this group, send email to > > nodejs+unsubscr...@googlegroups.com > > For more options, visit this group at > > http://groups.google.com/group/nodejs?hl=en?hl=en > > -- > Job Board: http://jobs.nodejs.org/ > Posting guidelines: > https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines > You received this message because you are subscribed to the Google > Groups "nodejs" group. > To post to this group, send email to nodejs@googlegroups.com > To unsubscribe from this group, send email to > nodejs+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/nodejs?hl=en?hl=en > -- Job Board: http://jobs.nodejs.org/ Posting guidelines: https://github.com/joyent/node/wiki/Mailing-List-Posting-Guidelines You received this message because you are subscribed to the Google Groups "nodejs" group. To post to this group, send email to nodejs@googlegroups.com To unsubscribe from this group, send email to nodejs+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/nodejs?hl=en?hl=en
