Accumulo-Integration-Tests - Build # 533 - Aborted! -- master

[elserj]

Accumulo-Integration-Tests - Build # 533 - Aborted:

Check console output at 
https://secure.penguinsinabox.com/jenkins/job/Accumulo-Integration-Tests/533/ 
to view the results.

[jira] [Updated] (ACCUMULO-4008) accumulo compactions prevent datanode decommission

[Eric Newton (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ACCUMULO-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Newton updated ACCUMULO-4008:
--
Assignee: (was: Eric Newton)

> accumulo compactions prevent datanode decommission
> --
>
> Key: ACCUMULO-4008
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4008
> Project: Accumulo
>  Issue Type: Bug
>  Components: tserver
>Affects Versions: 1.5.3, 1.5.4, 1.6.0, 1.6.1, 1.6.2, 1.6.3, 1.7.0
>Reporter: Eric Newton
> Fix For: 1.8.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> See other issues with decommissioning: ACCUMULO-4004
> While decommissioning several racks, accumulo experienced an error closing 
> the result of a compaction.  In particular, the error was due to 
> insufficiently replicated blocks, and those blocks were on the decommissioned 
> racks.  However, the resulting files (with the extension ".rf_tmp" are not 
> deleted.  These abandoned files prevent the datanodes from finishing their 
> decommissioning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ACCUMULO-2493) BinaryFormatter needs to be refactored

[Matt Dailey (JIRA)]

[ 
https://issues.apache.org/jira/browse/ACCUMULO-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075928#comment-15075928
 ] 

Matt Dailey commented on ACCUMULO-2493:
---

I'll get back on this this weekend; so expect a patch on Monday 1/4/16.

> BinaryFormatter needs to be refactored
> --
>
> Key: ACCUMULO-2493
> URL: https://issues.apache.org/jira/browse/ACCUMULO-2493
> Project: Accumulo
>  Issue Type: Bug
>  Components: client
>Reporter: Mike Drob
>Assignee: Matt Dailey
>  Labels: newbie
> Fix For: 1.7.1, 1.8.0
>
>
> BinaryFormatter is currently used in a couple places in the shell, but the 
> code is hard to read and understand. There is a static getlength, which is 
> actually a setter, and all the instance calls end up going through 
> unnecessary static methods.
> This combination makes it hard to reuse BinaryFormatter objects, or even use 
> multiple, since the static state is likely to conflict.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ACCUMULO-4008) accumulo compactions prevent datanode decommission

[Eric Newton (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ACCUMULO-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Newton updated ACCUMULO-4008:
--
Fix Version/s: (was: 1.6.5)
   (was: 1.7.1)

> accumulo compactions prevent datanode decommission
> --
>
> Key: ACCUMULO-4008
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4008
> Project: Accumulo
>  Issue Type: Bug
>  Components: tserver
>Affects Versions: 1.5.3, 1.5.4, 1.6.0, 1.6.1, 1.6.2, 1.6.3, 1.7.0
>Reporter: Eric Newton
>Assignee: Eric Newton
> Fix For: 1.8.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> See other issues with decommissioning: ACCUMULO-4004
> While decommissioning several racks, accumulo experienced an error closing 
> the result of a compaction.  In particular, the error was due to 
> insufficiently replicated blocks, and those blocks were on the decommissioned 
> racks.  However, the resulting files (with the extension ".rf_tmp" are not 
> deleted.  These abandoned files prevent the datanodes from finishing their 
> decommissioning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ACCUMULO-3734) Possible bug in VisibilityConstraint

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ACCUMULO-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076014#comment-15076014
 ] 

ASF GitHub Bot commented on ACCUMULO-3734:
--

GitHub user keith-turner opened a pull request:

https://github.com/apache/accumulo/pull/59

ACCUMULO-3734 unescape auths when using AuthsContainer



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/keith-turner/accumulo ACCUMULO-3734

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/accumulo/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #59


commit 3363f50a1bc5f19a3d901159fdfbb80b0286d495
Author: Keith Turner 
Date:   2015-12-31T15:23:45Z

ACCUMULO-3734 unescape auths when using AuthsContainer




> Possible bug in VisibilityConstraint
> 
>
> Key: ACCUMULO-3734
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3734
> Project: Accumulo
>  Issue Type: Bug
>Reporter: Keith Turner
>Assignee: Keith Turner
> Fix For: 1.7.2, 1.8.0
>
>
> ACCUMULO-1681 modified which constructor from {{VisibilityEvaluator}} that  
> {{VisibilityConstraint}} uses.  After the modification {{escape()}} is no 
> longer called (the old constructor called escape, and the new one does not).  
> Not sure if this is a problem.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ACCUMULO-3734) Possible bug in VisibilityConstraint

[Keith Turner (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ACCUMULO-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Turner updated ACCUMULO-3734:
---
Fix Version/s: 1.6.5

> Possible bug in VisibilityConstraint
> 
>
> Key: ACCUMULO-3734
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3734
> Project: Accumulo
>  Issue Type: Bug
>Reporter: Keith Turner
>Assignee: Keith Turner
> Fix For: 1.6.5, 1.7.2, 1.8.0
>
>
> ACCUMULO-1681 modified which constructor from {{VisibilityEvaluator}} that  
> {{VisibilityConstraint}} uses.  After the modification {{escape()}} is no 
> longer called (the old constructor called escape, and the new one does not).  
> Not sure if this is a problem.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ACCUMULO-3734) Possible bug in VisibilityConstraint

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ACCUMULO-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076064#comment-15076064
 ] 

ASF GitHub Bot commented on ACCUMULO-3734:
--

Github user joshelser commented on the pull request:

https://github.com/apache/accumulo/pull/59#issuecomment-168224028
  
Minor nits, otherwise LGTM


> Possible bug in VisibilityConstraint
> 
>
> Key: ACCUMULO-3734
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3734
> Project: Accumulo
>  Issue Type: Bug
>Reporter: Keith Turner
>Assignee: Keith Turner
> Fix For: 1.6.5, 1.7.1, 1.8.0
>
>
> ACCUMULO-1681 modified which constructor from {{VisibilityEvaluator}} that  
> {{VisibilityConstraint}} uses.  After the modification {{escape()}} is no 
> longer called (the old constructor called escape, and the new one does not).  
> Not sure if this is a problem.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Accumulo-Pull-Requests - Build # 178 - Aborted

[Apache Jenkins Server]

The Apache Jenkins build system has built Accumulo-Pull-Requests (build #178)

Status: Aborted

Check console output at 
https://builds.apache.org/job/Accumulo-Pull-Requests/178/ to view the results.

[jira] [Commented] (ACCUMULO-3734) Possible bug in VisibilityConstraint

[Keith Turner (JIRA)]

[ 
https://issues.apache.org/jira/browse/ACCUMULO-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076026#comment-15076026
 ] 

Keith Turner commented on ACCUMULO-3734:


I looked and this problem exist in 1.6 also.  The patch is against 1.7, but I 
can pull it back to 1.6 and push it forward. 

> Possible bug in VisibilityConstraint
> 
>
> Key: ACCUMULO-3734
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3734
> Project: Accumulo
>  Issue Type: Bug
>Reporter: Keith Turner
>Assignee: Keith Turner
> Fix For: 1.6.5, 1.7.2, 1.8.0
>
>
> ACCUMULO-1681 modified which constructor from {{VisibilityEvaluator}} that  
> {{VisibilityConstraint}} uses.  After the modification {{escape()}} is no 
> longer called (the old constructor called escape, and the new one does not).  
> Not sure if this is a problem.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ACCUMULO-3734) Possible bug in VisibilityConstraint

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ACCUMULO-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076103#comment-15076103
 ] 

ASF GitHub Bot commented on ACCUMULO-3734:
--

Github user keith-turner commented on the pull request:

https://github.com/apache/accumulo/pull/59#issuecomment-168238911
  
@joshelser  thanks for looking at it.   I plan on pulling this back to 1.6, 
merging it forward,  and pushing it to apache Mon morning.


> Possible bug in VisibilityConstraint
> 
>
> Key: ACCUMULO-3734
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3734
> Project: Accumulo
>  Issue Type: Bug
>Reporter: Keith Turner
>Assignee: Keith Turner
> Fix For: 1.6.5, 1.7.1, 1.8.0
>
>
> ACCUMULO-1681 modified which constructor from {{VisibilityEvaluator}} that  
> {{VisibilityConstraint}} uses.  After the modification {{escape()}} is no 
> longer called (the old constructor called escape, and the new one does not).  
> Not sure if this is a problem.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ACCUMULO-3734) Possible bug in VisibilityConstraint

[Keith Turner (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ACCUMULO-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Turner updated ACCUMULO-3734:
---
Fix Version/s: (was: 1.7.2)
   1.7.1

> Possible bug in VisibilityConstraint
> 
>
> Key: ACCUMULO-3734
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3734
> Project: Accumulo
>  Issue Type: Bug
>Reporter: Keith Turner
>Assignee: Keith Turner
> Fix For: 1.6.5, 1.7.1, 1.8.0
>
>
> ACCUMULO-1681 modified which constructor from {{VisibilityEvaluator}} that  
> {{VisibilityConstraint}} uses.  After the modification {{escape()}} is no 
> longer called (the old constructor called escape, and the new one does not).  
> Not sure if this is a problem.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ACCUMULO-3734) Possible bug in VisibilityConstraint

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ACCUMULO-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076063#comment-15076063
 ] 

ASF GitHub Bot commented on ACCUMULO-3734:
--

Github user joshelser commented on a diff in the pull request:

https://github.com/apache/accumulo/pull/59#discussion_r48663588
  
--- Diff: 
core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java 
---
@@ -26,6 +28,58 @@
 public class VisibilityEvaluator {
   private AuthorizationContainer auths;
 
+  private static class UnescapingAuthorizationContainer implements 
AuthorizationContainer {
--- End diff --

Javadoc would be nice


> Possible bug in VisibilityConstraint
> 
>
> Key: ACCUMULO-3734
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3734
> Project: Accumulo
>  Issue Type: Bug
>Reporter: Keith Turner
>Assignee: Keith Turner
> Fix For: 1.6.5, 1.7.1, 1.8.0
>
>
> ACCUMULO-1681 modified which constructor from {{VisibilityEvaluator}} that  
> {{VisibilityConstraint}} uses.  After the modification {{escape()}} is no 
> longer called (the old constructor called escape, and the new one does not).  
> Not sure if this is a problem.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ACCUMULO-3734) Possible bug in VisibilityConstraint

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ACCUMULO-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076062#comment-15076062
 ] 

ASF GitHub Bot commented on ACCUMULO-3734:
--

Github user joshelser commented on a diff in the pull request:

https://github.com/apache/accumulo/pull/59#discussion_r48663556
  
--- Diff: 
core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java
 ---
@@ -113,6 +123,31 @@ public void testQuote() {
   }
 
   @Test
+  public void testUnescape() {
+assertEquals("a\"b", VisibilityEvaluator.unescape(new 
ArrayByteSequence("a\\\"b")).toString());
+assertEquals("a\\b", VisibilityEvaluator.unescape(new 
ArrayByteSequence("ab")).toString());
+assertEquals("a\\\"b", VisibilityEvaluator.unescape(new 
ArrayByteSequence("a\\\"b")).toString());
+assertEquals("\\\"", VisibilityEvaluator.unescape(new 
ArrayByteSequence("\\\"")).toString());
+assertEquals("a\\b\\c\\d", VisibilityEvaluator.unescape(new 
ArrayByteSequence("abcd")).toString());
+
+try {
+  VisibilityEvaluator.unescape(new ArrayByteSequence("a\\b"));
+  fail();
--- End diff --

An assertion message for the `fail()`'s would be nice.


> Possible bug in VisibilityConstraint
> 
>
> Key: ACCUMULO-3734
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3734
> Project: Accumulo
>  Issue Type: Bug
>Reporter: Keith Turner
>Assignee: Keith Turner
> Fix For: 1.6.5, 1.7.1, 1.8.0
>
>
> ACCUMULO-1681 modified which constructor from {{VisibilityEvaluator}} that  
> {{VisibilityConstraint}} uses.  After the modification {{escape()}} is no 
> longer called (the old constructor called escape, and the new one does not).  
> Not sure if this is a problem.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ACCUMULO-3509) Scanner lock cause Tablet lock, hence preventing idle scans from being swept, hence blocking SimpleTimer thread

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ACCUMULO-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076216#comment-15076216
 ] 

ASF GitHub Bot commented on ACCUMULO-3509:
--

GitHub user phrocker opened a pull request:

https://github.com/apache/accumulo/pull/60

ACCUMULO-3509: Allow cleanup state to be kept to avoid blocking tserv…

…er session sweep

By enabling state ( true/false) from the cleanup method, the change will 
avoid blocking
on a scan session being swept. if the session cleanup blocks because a 
ScanSession is
still being read, we may block until the ScanBatch returns for that 
ScanSession.

The change uses a simple semaphore ( purely because I like the word ) to 
attempt acquisition.
If that fails, we return false from the cleanup and reintroduce that 
Session back into
the queue to clean up.

Added unit test that in the error condition will show the missing scan 
sessions ( which are missing due to the cleanup being blocked)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/phrocker/accumulo-1 master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/accumulo/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #60


commit bbd2257a001d654a87b433bb387ad9fce402dbb8
Author: phrocker 
Date:   2015-12-31T15:16:49Z

ACCUMULO-3509: Allow cleanup state to be kept to avoid blocking tserver 
session sweep

By enabling state ( true/false) from the cleanup method, the change will 
avoid blocking
on a scan session being swept. if the session cleanup blocks because a 
ScanSession is
still being read, we may block until the ScanBatch returns for that 
ScanSession.

The change uses a simple semaphore ( purely because I like the word ) to 
attempt acquisition.
If that fails, we return false from the cleanup and reintroduce that 
Session back into
the queue to clean up.




> Scanner lock cause Tablet lock, hence preventing idle scans from being swept, 
> hence blocking SimpleTimer thread 
> 
>
> Key: ACCUMULO-3509
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3509
> Project: Accumulo
>  Issue Type: Bug
>  Components: tserver
>Affects Versions: 1.6.0
>Reporter: marco polo
>Assignee: marco polo
> Fix For: 1.8.0
>
>
> Synchronization with Tablet$Scanner via a read() will block close() being 
> called via the sweep method in TabletServer. As a result, the SimpleTimer 
> thread does not continue, and idle threads grow until the scan completes. 
> My patch, which is forthcoming, converts synchronized methods to use a fair 
> lock. If the lock is held by a read call, the close call will attempt to 
> obtain it, time out, and return indicating a close was not successful. The 
> sweep will continue, and the SimpleTimer thread will respawn later, 
> attempting closure on those Tablets at a later time. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Accumulo-Integration-Tests - Build # 534 - Still unstable! -- 1.6

[elserj]

Accumulo-Integration-Tests - Build # 534 - Still unstable:

Check console output at 
https://secure.penguinsinabox.com/jenkins/job/Accumulo-Integration-Tests/534/ 
to view the results.

Accumulo-Integration-Tests - Build # 535 - Aborted! -- 1.7

[elserj]

Accumulo-Integration-Tests - Build # 535 - Aborted:

Check console output at 
https://secure.penguinsinabox.com/jenkins/job/Accumulo-Integration-Tests/535/ 
to view the results.