[jira] [Created] (ACCUMULO-4712) API changes review for Accumulo
Andrey Ponomarenko created ACCUMULO-4712: Summary: API changes review for Accumulo Key: ACCUMULO-4712 URL: https://issues.apache.org/jira/browse/ACCUMULO-4712 Project: Accumulo Issue Type: Test Components: core Reporter: Andrey Ponomarenko Priority: Minor The review of API changes for the Accumulo library since 1.3.6 version: https://abi-laboratory.pro/java/tracker/timeline/accumulo/ The report is updated three times a week. Hope it will be helpful for users and maintainers of the library. The report is generated by https://github.com/lvc/japi-tracker Thank you. !Accumulo-1.png|API changes review! !Accumulo-2.png|API symbols timeline! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (ACCUMULO-4712) API changes review for Accumulo
[ https://issues.apache.org/jira/browse/ACCUMULO-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Ponomarenko updated ACCUMULO-4712: - Attachment: Accumulo-1.png Accumulo-2.png > API changes review for Accumulo > --- > > Key: ACCUMULO-4712 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4712 > Project: Accumulo > Issue Type: Test > Components: core >Reporter: Andrey Ponomarenko >Priority: Minor > Attachments: Accumulo-1.png, Accumulo-2.png > > > The review of API changes for the Accumulo library since 1.3.6 version: > https://abi-laboratory.pro/java/tracker/timeline/accumulo/ > The report is updated three times a week. Hope it will be helpful for users > and maintainers of the library. > The report is generated by https://github.com/lvc/japi-tracker > Thank you. > !Accumulo-1.png|API changes review! > !Accumulo-2.png|API symbols timeline! -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (ACCUMULO-2907) Invalidate "this may not be applicable for your security setup" warning from initialize
[ https://issues.apache.org/jira/browse/ACCUMULO-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Tubbs resolved ACCUMULO-2907. - Resolution: Fixed Thanks for the contribution, [~jmark99]. I've merged your changes onto version 2.0.0 (master) branch. I'm closing this for now. Personally, I think it's not necessary for 1.7/1.8, but if anybody is interested in back-porting this to 1.7 or 1.8, we can re-open or create a new issue for the backport. If you wish to be added to https://accumulo.apache.org/people/ page, you can do a pull request with your preferred details against: https://github.com/apache/accumulo-website/blob/master/pages/people.md We hope to see you contribute again! > Invalidate "this may not be applicable for your security setup" warning from > initialize > > > Key: ACCUMULO-2907 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2907 > Project: Accumulo > Issue Type: Improvement >Reporter: Josh Elser >Assignee: Mark Owens >Priority: Minor > Labels: newbie, pull-request-available > Fix For: 2.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > > The warning that is printed about setting a root password may not be > applicable for your security setup is invalid because the plugable > authentication modules do not manage the root user and it is expected that > there will always be a local root user with a password. > Remove the warning. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] ctubbsii closed pull request #301: ACCUMULO-2907 Invalidate "this may not be applicable for your security setup" warning from initialize
ctubbsii closed pull request #301: ACCUMULO-2907 Invalidate "this may not be applicable for your security setup" warning from initialize URL: https://github.com/apache/accumulo/pull/301 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (ACCUMULO-2907) Invalidate "this may not be applicable for your security setup" warning from initialize
[ https://issues.apache.org/jira/browse/ACCUMULO-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183239#comment-16183239 ] Mark Owens commented on ACCUMULO-2907: -- Replaced use of StringBuilder with String. > Invalidate "this may not be applicable for your security setup" warning from > initialize > > > Key: ACCUMULO-2907 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2907 > Project: Accumulo > Issue Type: Improvement >Reporter: Josh Elser >Assignee: Mark Owens >Priority: Minor > Labels: newbie, pull-request-available > Fix For: 2.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The warning that is printed about setting a root password may not be > applicable for your security setup is invalid because the plugable > authentication modules do not manage the root user and it is expected that > there will always be a local root user with a password. > Remove the warning. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] jmark99 commented on a change in pull request #301: ACCUMULO-2907 Invalidate "this may not be applicable for your security setup" warning from initialize
jmark99 commented on a change in pull request #301: ACCUMULO-2907 Invalidate
"this may not be applicable for your security setup" warning from initialize
URL: https://github.com/apache/accumulo/pull/301#discussion_r141462552
##
File path:
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
##
@@ -644,6 +644,25 @@ private String getRootUserName(Opts opts) throws
IOException {
return rootpass.getBytes(UTF_8);
}
+ /**
+ * Create warning message related to initial password, if appropriate.
+ *
+ * ACCUMULO-2907 Remove unnecessary security warning from console message
unless its actually appropriate.
+ * The warning message should only be displayed when the value of
instance.security.authenticator
+ * differs between the SiteConfiguration and the DefaultConfiguration values.
+ *
+ * @return String containing warning portion of console message.
+ */
+ private String getInitialPasswordWarning() {
+StringBuilder optionalWarning = new StringBuilder();
+Property authenticatorProperty = Property.INSTANCE_SECURITY_AUTHENTICATOR;
+if
(SiteConfiguration.getInstance().get(authenticatorProperty).equals(authenticatorProperty.getDefaultValue()))
+ optionalWarning.append(": ");
+else
+ optionalWarning.append(" (this may not be applicable for your security
setup): ");
+return optionalWarning.toString();
Review comment:
ACCUMULO-2907: Updated to replace StringBuilder usage with String.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ctubbsii commented on a change in pull request #301: ACCUMULO-2907 Invalidate "this may not be applicable for your security setup" warning from initialize
ctubbsii commented on a change in pull request #301: ACCUMULO-2907 Invalidate
"this may not be applicable for your security setup" warning from initialize
URL: https://github.com/apache/accumulo/pull/301#discussion_r141460788
##
File path:
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
##
@@ -644,6 +644,25 @@ private String getRootUserName(Opts opts) throws
IOException {
return rootpass.getBytes(UTF_8);
}
+ /**
+ * Create warning message related to initial password, if appropriate.
+ *
+ * ACCUMULO-2907 Remove unnecessary security warning from console message
unless its actually appropriate.
+ * The warning message should only be displayed when the value of
instance.security.authenticator
+ * differs between the SiteConfiguration and the DefaultConfiguration values.
+ *
+ * @return String containing warning portion of console message.
+ */
+ private String getInitialPasswordWarning() {
+StringBuilder optionalWarning = new StringBuilder();
+Property authenticatorProperty = Property.INSTANCE_SECURITY_AUTHENTICATOR;
+if
(SiteConfiguration.getInstance().get(authenticatorProperty).equals(authenticatorProperty.getDefaultValue()))
+ optionalWarning.append(": ");
+else
+ optionalWarning.append(" (this may not be applicable for your security
setup): ");
+return optionalWarning.toString();
Review comment:
Can probably avoid use of StringBuilder here, since there is only a single
string to return in each case, and it's not being concatenated with anything
else until outside the method. Other than that, this change looks good to me.
Thanks for the contribution!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (ACCUMULO-2907) Invalidate "this may not be applicable for your security setup" warning from initialize
[ https://issues.apache.org/jira/browse/ACCUMULO-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183143#comment-16183143 ] Mark Owens commented on ACCUMULO-2907: -- The pull request has been updated to only display the security warning message when appropriate and as described in the previous comments. > Invalidate "this may not be applicable for your security setup" warning from > initialize > > > Key: ACCUMULO-2907 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2907 > Project: Accumulo > Issue Type: Improvement >Reporter: Josh Elser >Assignee: Mark Owens >Priority: Minor > Labels: newbie, pull-request-available > Fix For: 2.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The warning that is printed about setting a root password may not be > applicable for your security setup is invalid because the plugable > authentication modules do not manage the root user and it is expected that > there will always be a local root user with a password. > Remove the warning. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (ACCUMULO-2907) Invalidate "this may not be applicable for your security setup" warning from initialize
[ https://issues.apache.org/jira/browse/ACCUMULO-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ACCUMULO-2907: - Labels: newbie pull-request-available (was: newbie) > Invalidate "this may not be applicable for your security setup" warning from > initialize > > > Key: ACCUMULO-2907 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2907 > Project: Accumulo > Issue Type: Improvement >Reporter: Josh Elser >Assignee: Mark Owens >Priority: Minor > Labels: newbie, pull-request-available > Fix For: 2.0.0 > > > The warning that is printed about setting a root password may not be > applicable for your security setup is invalid because the plugable > authentication modules do not manage the root user and it is expected that > there will always be a local root user with a password. > Remove the warning. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] jmark99 commented on issue #301: ACCUMULO-2907 Invalidate "this may not be applicable for your security setup" warning from initialize
jmark99 commented on issue #301: ACCUMULO-2907 Invalidate "this may not be applicable for your security setup" warning from initialize URL: https://github.com/apache/accumulo/pull/301#issuecomment-332635247 ACCUMULO-2907: Updated pull request to display security warning message only when applicable. Compare the value of instance.security.authenticator in the Site configuration to the default configuration. If the values differ then the warning message is displayed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
