date:20171201

[GitHub] ctubbsii commented on a change in pull request #44: ACCUMULO-4750 Created caching documentation

2017-12-01 Thread GitBox

ctubbsii commented on a change in pull request #44: ACCUMULO-4750 Created 
caching documentation
URL: https://github.com/apache/accumulo-website/pull/44#discussion_r154481332
 
 

 ##
 File path: _docs-2-0/administration/caching.md
 ##
 @@ -0,0 +1,46 @@
+---
+title: Caching
+category: administration
+order: 11
+---
+
+Accumulo tablet servers have a **block cache** that buffers data in memory to 
limit reads from disk.
+This caching has the following benefits:
+
+* reduces latency when reading data
+* helps alleviate hotspots in tables
+
+The block cache stores index and data blocks. A typical Accumulo read will 
perfrom a binary search
 
 Review comment:
   Never mind. I got confused with the phrasing. Perhaps "A typical read 
operation" instead?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ctubbsii commented on a change in pull request #44: ACCUMULO-4750 Created caching documentation

2017-12-01 Thread GitBox

ctubbsii commented on a change in pull request #44: ACCUMULO-4750 Created 
caching documentation
URL: https://github.com/apache/accumulo-website/pull/44#discussion_r154481279
 
 

 ##
 File path: _docs-2-0/administration/caching.md
 ##
 @@ -0,0 +1,46 @@
+---
+title: Caching
+category: administration
+order: 11
+---
+
+Accumulo tablet servers have a **block cache** that buffers data in memory to 
limit reads from disk.
+This caching has the following benefits:
+
+* reduces latency when reading data
+* helps alleviate hotspots in tables
+
+The block cache stores index and data blocks. A typical Accumulo read will 
perfrom a binary search
 
 Review comment:
   What is "a typical Accumulo"?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] keith-turner commented on a change in pull request #325: ACCUMULO-2341?

2017-12-01 Thread GitBox

keith-turner commented on a change in pull request #325: ACCUMULO-2341?
URL: https://github.com/apache/accumulo/pull/325#discussion_r154476081
 
 

 ##
 File path: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
 ##
 @@ -354,12 +354,8 @@ public void run() {
   }
 
   private static void stopServer(final ClientContext context, final boolean 
tabletServersToo) throws AccumuloException, AccumuloSecurityException {
-MasterClient.executeVoid(context, new 
ClientExec() {
-  @Override
-  public void execute(MasterClientService.Client client) throws Exception {
-client.shutdown(Tracer.traceInfo(), context.rpcCreds(), 
tabletServersToo);
-  }
-});
+MasterClient.executeVoidWithConnRetry(context,
 
 Review comment:
   executeVoidAdmin is ok with me


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (ACCUMULO-4750) Improve block cache documentation

2017-12-01 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/ACCUMULO-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ACCUMULO-4750:
-
Labels: pull-request-available  (was: )

> Improve block cache documentation
> -
>
> Key: ACCUMULO-4750
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4750
> Project: Accumulo
>  Issue Type: Task
>Reporter: Mike Walch
>Assignee: Mike Walch
>Priority: Minor
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] mikewalch opened a new pull request #44: ACCUMULO-4750 Created caching documentation

2017-12-01 Thread GitBox

mikewalch opened a new pull request #44: ACCUMULO-4750 Created caching 
documentation
URL: https://github.com/apache/accumulo-website/pull/44
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jomach commented on a change in pull request #325: ACCUMULO-2341?

2017-12-01 Thread GitBox

jomach commented on a change in pull request #325: ACCUMULO-2341?
URL: https://github.com/apache/accumulo/pull/325#discussion_r154458933
 
 

 ##
 File path: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
 ##
 @@ -354,12 +354,8 @@ public void run() {
   }
 
   private static void stopServer(final ClientContext context, final boolean 
tabletServersToo) throws AccumuloException, AccumuloSecurityException {
-MasterClient.executeVoid(context, new 
ClientExec() {
-  @Override
-  public void execute(MasterClientService.Client client) throws Exception {
-client.shutdown(Tracer.traceInfo(), context.rpcCreds(), 
tabletServersToo);
-  }
-});
+MasterClient.executeVoidWithConnRetry(context,
 
 Review comment:
   Should we agreed on a plan ? Probally having a executeVoidAdmin would be the 
way to go correct ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] keith-turner commented on a change in pull request #325: ACCUMULO-2341?

2017-12-01 Thread GitBox

keith-turner commented on a change in pull request #325: ACCUMULO-2341?
URL: https://github.com/apache/accumulo/pull/325#discussion_r154458309
 
 

 ##
 File path: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
 ##
 @@ -354,12 +354,8 @@ public void run() {
   }
 
   private static void stopServer(final ClientContext context, final boolean 
tabletServersToo) throws AccumuloException, AccumuloSecurityException {
-MasterClient.executeVoid(context, new 
ClientExec() {
-  @Override
-  public void execute(MasterClientService.Client client) throws Exception {
-client.shutdown(Tracer.traceInfo(), context.rpcCreds(), 
tabletServersToo);
-  }
-});
+MasterClient.executeVoidWithConnRetry(context,
 
 Review comment:
   ok I agree.  I was thinking only the admin task would call `executeVoid(ctx, 
exec, false)` everything else would continue to call the `executeVoid(ctx, 
exec)` that retries.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] keith-turner commented on a change in pull request #325: ACCUMULO-2341?

2017-12-01 Thread GitBox

keith-turner commented on a change in pull request #325: ACCUMULO-2341?
URL: https://github.com/apache/accumulo/pull/325#discussion_r154458309
 
 

 ##
 File path: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
 ##
 @@ -354,12 +354,8 @@ public void run() {
   }
 
   private static void stopServer(final ClientContext context, final boolean 
tabletServersToo) throws AccumuloException, AccumuloSecurityException {
-MasterClient.executeVoid(context, new 
ClientExec() {
-  @Override
-  public void execute(MasterClientService.Client client) throws Exception {
-client.shutdown(Tracer.traceInfo(), context.rpcCreds(), 
tabletServersToo);
-  }
-});
+MasterClient.executeVoidWithConnRetry(context,
 
 Review comment:
   ok I agree.  I was thinking only the admin task would call 
`executeVoid(exec, false)` everything else would continue to call the 
`executeVoid(exec)` that retries.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] keith-turner commented on a change in pull request #325: ACCUMULO-2341?

2017-12-01 Thread GitBox

keith-turner commented on a change in pull request #325: ACCUMULO-2341?
URL: https://github.com/apache/accumulo/pull/325#discussion_r154458309
 
 

 ##
 File path: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
 ##
 @@ -354,12 +354,8 @@ public void run() {
   }
 
   private static void stopServer(final ClientContext context, final boolean 
tabletServersToo) throws AccumuloException, AccumuloSecurityException {
-MasterClient.executeVoid(context, new 
ClientExec() {
-  @Override
-  public void execute(MasterClientService.Client client) throws Exception {
-client.shutdown(Tracer.traceInfo(), context.rpcCreds(), 
tabletServersToo);
-  }
-});
+MasterClient.executeVoidWithConnRetry(context,
 
 Review comment:
   ok I agree.  I was thinking only the admin task would call `executeVoid(..., 
false)`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jomach commented on a change in pull request #325: ACCUMULO-2341?

2017-12-01 Thread GitBox

jomach commented on a change in pull request #325: ACCUMULO-2341?
URL: https://github.com/apache/accumulo/pull/325#discussion_r154454411
 
 

 ##
 File path: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
 ##
 @@ -354,12 +354,8 @@ public void run() {
   }
 
   private static void stopServer(final ClientContext context, final boolean 
tabletServersToo) throws AccumuloException, AccumuloSecurityException {
-MasterClient.executeVoid(context, new 
ClientExec() {
-  @Override
-  public void execute(MasterClientService.Client client) throws Exception {
-client.shutdown(Tracer.traceInfo(), context.rpcCreds(), 
tabletServersToo);
-  }
-});
+MasterClient.executeVoidWithConnRetry(context,
 
 Review comment:
   From my understanding this gets called when some client tries to execute a 
operation on accumulo. Is this correct ? So if I have an application  having 
some networking timeout (let?s say the cable is out) then it will brake the 
application and the application will need to take care of retry. At the moment 
the code does already this. That?s my I think it would be better to have a 
method only for the admin tasks. Like starting stopping creating tables ... 
   
   Correct me if I?m wrong


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mikewalch closed pull request #43: ACCUMULO-4734 Changes from review of tour

2017-12-01 Thread GitBox

mikewalch closed pull request #43: ACCUMULO-4734 Changes from review of tour
URL: https://github.com/apache/accumulo-website/pull/43
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/_config.yml b/_config.yml
index 3ad02d8..3a2ab10 100644
--- a/_config.yml
+++ b/_config.yml
@@ -17,6 +17,7 @@ exclude: [vendor]
 latest_minor_release: 1.8
 latest_release: 1.8.1
 num_home_posts: 5
+javadoc_core: 
"https://static.javadoc.io/org.apache.accumulo/accumulo-core/1.8.1";
 
 # Build settings
 markdown: kramdown
diff --git a/tour/authorizations-code.md b/tour/authorizations-code.md
index 04ea47b..9858780 100644
--- a/tour/authorizations-code.md
+++ b/tour/authorizations-code.md
@@ -1,64 +1,69 @@
 ---
 title: Authorizations Code
 ---
+
+Below is a solution for the exercise.
+
 ```java
-// start writing your code here
-// Connect to Mini Accumulo as the root user and create a table called 
"GothamPD".
-Connector conn = mac.getConnector("root", "tourguide");
-conn.tableOperations().create("GothamPD");
+static void exercise(MiniAccumuloCluster mac) throws Exception {
+// Connect to Mini Accumulo as the root user and create a table called 
"GothamPD".
+Connector conn = mac.getConnector("root", "tourguide");
+conn.tableOperations().create("GothamPD");
 
-// Create a "secretIdentity" authorization & visibility
-final String secId = "secretIdentity";
-Authorizations auths = new Authorizations(secId);
-ColumnVisibility visibility = new ColumnVisibility(secId);
+// Create a "secretId" authorization & visibility
+final String secretId = "secretId";
+Authorizations auths = new Authorizations(secretId);
+ColumnVisibility colVis = new ColumnVisibility(secretId);
 
-// Create a user with the "secretIdentity" authorization and grant him 
read permissions on our table
-conn.securityOperations().createLocalUser("commissioner", new 
PasswordToken("gordanrocks"));
-conn.securityOperations().changeUserAuthorizations("commissioner", 
auths);
-conn.securityOperations().grantTablePermission("commissioner", 
"GothamPD", TablePermission.READ);
+// Create a user with the "secretId" authorization and grant him read 
permissions on our table
+conn.securityOperations().createLocalUser("commissioner", new 
PasswordToken("gordanrocks"));
+conn.securityOperations().changeUserAuthorizations("commissioner", auths);
+conn.securityOperations().grantTablePermission("commissioner", "GothamPD", 
TablePermission.READ);
 
-// Create 3 Mutation objects, securing the proper columns.
-Mutation mutation1 = new Mutation("id0001");
-mutation1.put("hero","alias", "Batman");
-mutation1.put("hero","name", visibility, "Bruce Wayne");
-mutation1.put("hero","wearsCape?", "true");
-Mutation mutation2 = new Mutation("id0002");
-mutation2.put("hero","alias", "Robin");
-mutation2.put("hero","name", visibility,"Dick Grayson");
-mutation2.put("hero","wearsCape?", "true");
-Mutation mutation3 = new Mutation("id0003");
-mutation3.put("villain","alias", "Joker");
-mutation3.put("villain","name", "Unknown");
-mutation3.put("villain","wearsCape?", "false");
+// Create 3 Mutation objects, securing the proper columns.
+Mutation mutation1 = new Mutation("id0001");
+mutation1.put("hero","alias", "Batman");
+mutation1.put("hero","name", colVis, "Bruce Wayne");
+mutation1.put("hero","wearsCape?", "true");
+Mutation mutation2 = new Mutation("id0002");
+mutation2.put("hero","alias", "Robin");
+mutation2.put("hero","name", colVis,"Dick Grayson");
+mutation2.put("hero","wearsCape?", "true");
+Mutation mutation3 = new Mutation("id0003");
+mutation3.put("villain","alias", "Joker");
+mutation3.put("villain","name", "Unknown");
+mutation3.put("villain","wearsCape?", "false");
 
-// Create a BatchWriter to the GothamPD table and add your mutations 
to it.
-// Once the BatchWriter is closed by the try w/ resources, data will 
be available to scans.
-try(BatchWriter writer = conn.createBatchWriter("GothamPD", new 
BatchWriterConfig())) {
-writer.addMutation(mutation1);
-writer.addMutation(mutation2);
-writer.addMutation(mutation3);
-}
+// Create a BatchWriter to the GothamPD table and add your mutations to it.
+// Once the BatchWriter is closed by the try w/ resources, data will be 
available to scans.
+try (BatchWriter writer = conn.createBatchWriter("GothamPD", new 
BatchWriterConfig())) {
+writer.addMutation(mutation1);
+writer.addMutation(mutation2);
+writer.addMutati

[GitHub] milleruntime commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour

2017-12-01 Thread GitBox

milleruntime commented on a change in pull request #43: ACCUMULO-4734 Changes 
from review of tour
URL: https://github.com/apache/accumulo-website/pull/43#discussion_r154428845
 
 

 ##
 File path: tour/authorizations-code.md
 ##
 @@ -1,64 +1,69 @@
 ---
 title: Authorizations Code
 ---
+
+Below is a solution for the exercise.
+
 ```java
-// start writing your code here
-// Connect to Mini Accumulo as the root user and create a table called 
"GothamPD".
-Connector conn = mac.getConnector("root", "tourguide");
-conn.tableOperations().create("GothamPD");
+static void exercise(MiniAccumuloCluster mac) throws Exception {
+// Connect to Mini Accumulo as the root user and create a table called 
"GothamPD".
+Connector conn = mac.getConnector("root", "tourguide");
+conn.tableOperations().create("GothamPD");
 
-// Create a "secretIdentity" authorization & visibility
-final String secId = "secretIdentity";
-Authorizations auths = new Authorizations(secId);
-ColumnVisibility visibility = new ColumnVisibility(secId);
+// Create a "viewSecretId" authorization & visibility
+final String viewSecretId = "viewSecretId";
 
 Review comment:
   That works.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour

2017-12-01 Thread GitBox

mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from 
review of tour
URL: https://github.com/apache/accumulo-website/pull/43#discussion_r154426075
 
 

 ##
 File path: tour/authorizations-code.md
 ##
 @@ -1,64 +1,69 @@
 ---
 title: Authorizations Code
 ---
+
+Below is a solution for the exercise.
+
 ```java
-// start writing your code here
-// Connect to Mini Accumulo as the root user and create a table called 
"GothamPD".
-Connector conn = mac.getConnector("root", "tourguide");
-conn.tableOperations().create("GothamPD");
+static void exercise(MiniAccumuloCluster mac) throws Exception {
+// Connect to Mini Accumulo as the root user and create a table called 
"GothamPD".
+Connector conn = mac.getConnector("root", "tourguide");
+conn.tableOperations().create("GothamPD");
 
-// Create a "secretIdentity" authorization & visibility
-final String secId = "secretIdentity";
-Authorizations auths = new Authorizations(secId);
-ColumnVisibility visibility = new ColumnVisibility(secId);
+// Create a "viewSecretId" authorization & visibility
+final String viewSecretId = "viewSecretId";
 
 Review comment:
   Fixed in ee62cbca.  I used `secretId` as it's shorter but I can go to 
`secretIdentity` if you want.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour

2017-12-01 Thread GitBox

mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from 
review of tour
URL: https://github.com/apache/accumulo-website/pull/43#discussion_r154426075
 
 

 ##
 File path: tour/authorizations-code.md
 ##
 @@ -1,64 +1,69 @@
 ---
 title: Authorizations Code
 ---
+
+Below is a solution for the exercise.
+
 ```java
-// start writing your code here
-// Connect to Mini Accumulo as the root user and create a table called 
"GothamPD".
-Connector conn = mac.getConnector("root", "tourguide");
-conn.tableOperations().create("GothamPD");
+static void exercise(MiniAccumuloCluster mac) throws Exception {
+// Connect to Mini Accumulo as the root user and create a table called 
"GothamPD".
+Connector conn = mac.getConnector("root", "tourguide");
+conn.tableOperations().create("GothamPD");
 
-// Create a "secretIdentity" authorization & visibility
-final String secId = "secretIdentity";
-Authorizations auths = new Authorizations(secId);
-ColumnVisibility visibility = new ColumnVisibility(secId);
+// Create a "viewSecretId" authorization & visibility
+final String viewSecretId = "viewSecretId";
 
 Review comment:
   Fixed in ee62cbca.  I used `secretId` as it's shorted but I can go to 
`secretIdentity` if you want.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour

2017-12-01 Thread GitBox

mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from 
review of tour
URL: https://github.com/apache/accumulo-website/pull/43#discussion_r154425893
 
 

 ##
 File path: tour/authorizations.md
 ##
 @@ -1,46 +1,49 @@
 ---
 title: Authorizations
 ---
-Authorizations are a set of Strings that enable a user to read protected data. 
A column visibility is a boolean expression 
+
+[Authorizations] are a set of Strings that enable a user to read protected 
data. A [ColumnVisibility] is a boolean expression
 that is evaluated using the authorizations provided by a scanner. If it 
evaluates to true, then the data is visible. 
 
 For example:
-* Bob scans with authorizations = { IT, User }
-* Tina scans with authorizations = { Admin, IT, User }
-* Row1:family1:qualifier1 has Visibility = { Admin && IT && User }
-* Bob will **not** see Row1:family1:qualifier1
-* Tina will see Row1:family1:qualifier1
+* Bob has authorizations `IT, User`
+* Tina has authorizations `Admin, IT, User`
+* The key `row1:family1:qualifier1` has visibility `Admin && IT && User`
+* Bob will **not** see `row1:family1:qualifier1`
 
 Review comment:
   Fixed in ee62cbca


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from review of tour

2017-12-01 Thread GitBox

mikewalch commented on a change in pull request #43: ACCUMULO-4734 Changes from 
review of tour
URL: https://github.com/apache/accumulo-website/pull/43#discussion_r154425855
 
 

 ##
 File path: tour/authorizations.md
 ##
 @@ -1,46 +1,49 @@
 ---
 title: Authorizations
 ---
-Authorizations are a set of Strings that enable a user to read protected data. 
A column visibility is a boolean expression 
+
+[Authorizations] are a set of Strings that enable a user to read protected 
data. A [ColumnVisibility] is a boolean expression
 that is evaluated using the authorizations provided by a scanner. If it 
evaluates to true, then the data is visible. 
 
 Review comment:
   Fixed in ee62cbca


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Accumulo-Master - Build # 2191 - Still Unstable

2017-12-01 Thread Apache Jenkins Server

The Apache Jenkins build system has built Accumulo-Master (build #2191)

Status: Still Unstable

Check console output at https://builds.apache.org/job/Accumulo-Master/2191/ to 
view the results.

[jira] [Created] (ACCUMULO-4750) Improve block cache documentation

2017-12-01 Thread Mike Walch (JIRA)

Mike Walch created ACCUMULO-4750:


 Summary: Improve block cache documentation
 Key: ACCUMULO-4750
 URL: https://issues.apache.org/jira/browse/ACCUMULO-4750
 Project: Accumulo
  Issue Type: Task
Reporter: Mike Walch
Assignee: Mike Walch
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (ACCUMULO-4743) Use tserver prefix for Cache config instead of general custom

2017-12-01 Thread Keith Turner (JIRA)


 [ 
https://issues.apache.org/jira/browse/ACCUMULO-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Turner resolved ACCUMULO-4743.

Resolution: Fixed

> Use tserver prefix for Cache config instead of general custom
> -
>
> Key: ACCUMULO-4743
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4743
> Project: Accumulo
>  Issue Type: Bug
>Reporter: Keith Turner
>Assignee: Jared R
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> In ACCUMULO-4463 caching implementations were made configurable.  At the time 
> config for a cache was placed under the {{general.custom.cache}} prefix.  The 
> idea was that a cache impl would be passed in a AccumuloConfiguration object 
> and it could grab whatever it wanted from {{general.custom.cache}}.  
> In ACCUMULO-4644 the cache API was changed to not use AccumuloConfiguration 
> because that type is not in the public API.  This removed the reason for 
> using general.custom in the first place.
> When trying to implement an external cache I discovered that I can not set 
> general.custom props in zookeeper.  However the cache class is a tserver 
> prefixed property can can be set in zookeeper.  For the 
> [accumulo-ohc|https://github.com/keith-turner/accumulo-ohc] I wanted to do 
> the following in the shell but could not set the general props.
> {noformat}
> config -s general.custom.cache.ohc.data.on-heap.maximumWeight=10
> config -s general.custom.cache.ohc.data.off-heap.capacity=100
> config -s tserver.cache.manager.class=accumulo.ohc.OhcCacheManager
> {noformat}
> I think it would be nice to change cache config prefix from 
> {{general.custom.cache..}} to 
> {{tserver.cache.config..}}.  Doing this would enable 
> setting up a cache in the shell like the following.
> {noformat}
> config -s tserver.cache.config.data.on-heap.maximumWeight=10
> config -s tserver.cache.config.data.off-heap.capacity=100
> config -s tserver.cache.manager.class=accumulo.ohc.OhcCacheManager
> {noformat}
> Part of the code for this prefix is at [BlockCacheManager.java line 
> 33|https://github.com/apache/accumulo/blob/d877a2df2943e48d70d99b96616844d0dff9a501/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java#L33]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ACCUMULO-4746) Create Builder for Mutation

2017-12-01 Thread Benjamin F (JIRA)


[ 
https://issues.apache.org/jira/browse/ACCUMULO-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274743#comment-16274743
 ] 

Benjamin F commented on ACCUMULO-4746:
--

I like the idea of a Fluent interface in this context. It works well since we 
certainly can't set everything in the constructor and lends well to creating 
mutations; fluency comes from making a new value from an old one which we 
always do with mutations. Plus this covers your use case of the caller just 
being able to chain overloaded methods such as 
`someMutation.mutate().family(foo)` without having too much concern if `foo` is 
a String or byte[]. 

My only (very small) concern is how well it will be able to flow semantically. 
I think changing the name of the `mutate` method as you mentioned in the code 
comment could solve this, having the action word mutate near the front of the 
chain seems like an action is being taken before I as the caller have set the 
values. This is the only potential change I could think of but I think the 
'new' term in my function name could be misleading and doesn't necessarily 
match up with what's in the `Mutation` class:

`m1.newRowChange()
.family(fam)
.qualifier("q1")
.set("v1")`

Using `newRowChange` matches up with the verbiage in the Accumulo book (pg.29, 
Introduction to the Client API) where the `Mutation` object is described as a 
set of changes applied to a single row. Having `set()` be the only action word 
in the chain makes it more apparent as an end to the chain. Overall I think 
this is a great direction to go.

> Create Builder for Mutation
> ---
>
> Key: ACCUMULO-4746
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4746
> Project: Accumulo
>  Issue Type: Sub-task
>  Components: client
>Reporter: Keith Turner
>Assignee: Benjamin F
> Fix For: 2.0.0
>
>
> Accumulo needs a builder for mutation similar to the one that was added for 
> Key.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (ACCUMULO-4743) Use tserver prefix for Cache config instead of general custom

2017-12-01 Thread Keith Turner (JIRA)


 [ 
https://issues.apache.org/jira/browse/ACCUMULO-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Turner reassigned ACCUMULO-4743:
--

Assignee: Jared R

> Use tserver prefix for Cache config instead of general custom
> -
>
> Key: ACCUMULO-4743
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4743
> Project: Accumulo
>  Issue Type: Bug
>Reporter: Keith Turner
>Assignee: Jared R
>  Labels: pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> In ACCUMULO-4463 caching implementations were made configurable.  At the time 
> config for a cache was placed under the {{general.custom.cache}} prefix.  The 
> idea was that a cache impl would be passed in a AccumuloConfiguration object 
> and it could grab whatever it wanted from {{general.custom.cache}}.  
> In ACCUMULO-4644 the cache API was changed to not use AccumuloConfiguration 
> because that type is not in the public API.  This removed the reason for 
> using general.custom in the first place.
> When trying to implement an external cache I discovered that I can not set 
> general.custom props in zookeeper.  However the cache class is a tserver 
> prefixed property can can be set in zookeeper.  For the 
> [accumulo-ohc|https://github.com/keith-turner/accumulo-ohc] I wanted to do 
> the following in the shell but could not set the general props.
> {noformat}
> config -s general.custom.cache.ohc.data.on-heap.maximumWeight=10
> config -s general.custom.cache.ohc.data.off-heap.capacity=100
> config -s tserver.cache.manager.class=accumulo.ohc.OhcCacheManager
> {noformat}
> I think it would be nice to change cache config prefix from 
> {{general.custom.cache..}} to 
> {{tserver.cache.config..}}.  Doing this would enable 
> setting up a cache in the shell like the following.
> {noformat}
> config -s tserver.cache.config.data.on-heap.maximumWeight=10
> config -s tserver.cache.config.data.off-heap.capacity=100
> config -s tserver.cache.manager.class=accumulo.ohc.OhcCacheManager
> {noformat}
> Part of the code for this prefix is at [BlockCacheManager.java line 
> 33|https://github.com/apache/accumulo/blob/d877a2df2943e48d70d99b96616844d0dff9a501/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java#L33]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] keith-turner closed pull request #328: ACCUMULO-4743 Replaced general custom with tserver prefix for cache config

2017-12-01 Thread GitBox

keith-turner closed pull request #328: ACCUMULO-4743 Replaced general custom 
with tserver prefix for cache config
URL: https://github.com/apache/accumulo/pull/328
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
 
b/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
index f19167c727..4c75c4dadb 100644
--- 
a/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
+++ 
b/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
@@ -30,14 +30,14 @@
 
   private final Map caches = new HashMap<>();
 
-  public static final String CACHE_PROPERTY_BASE = 
Property.GENERAL_ARBITRARY_PROP_PREFIX + "cache.";
+  public static final String CACHE_PROPERTY_BASE = Property.TSERV_PREFIX + 
"cache.config.";
 
   public static interface Configuration {
 
 /**
  * Before Accumulo's cache implementation was configurable, its built in 
caches had a configurable size. These sizes were specified by the system 
properties
- * {@code tserver.cache.data.size}, {@code tserver.cache.index.size}, and 
{code tserver.cache.summary.size}. This method returns the values of those
- * settings. The settings are made available, but cache implementations 
are under no obligation to use them.
+ * {@code tserver.cache.config.data.size}, {@code 
tserver.cache.config.index.size}, and {code tserver.cache.config.summary.size}. 
This method returns the
+ * values of those settings. The settings are made available, but cache 
implementations are under no obligation to use them.
  *
  */
 long getMaxSize(CacheType type);
@@ -54,17 +54,19 @@
  * This method provides a way for a cache implementation to access 
arbitrary configuration set by a user.
  *
  * 
- * Returns all Accumulo properties that have a prefix of {@code 
general.custom.cache...} or {@code 
general.custom.cache..default.}
- * with values for specific cache types overriding defaults.
+ * Returns all Accumulo properties that have a prefix of {@code 
tserver.cache.config...} or {@code 
tserver.cache.config..default.}
+ * with
+ * values for
+ * specific cache types overriding defaults.
  *
  * 
  * For example assume the following data is in Accumulo's system config.
  *
  * 
- * general.custom.cache.lru.default.evictAfter=3600
- * general.custom.cache.lru.default.loadFactor=.75
- * general.custom.cache.lru.index.loadFactor=.55
- * general.custom.cache.lru.data.loadFactor=.65
+ * tserver.cache.config.lru.default.evictAfter=3600
+ * tserver.cache.config.lru.default.loadFactor=.75
+ * tserver.cache.config.lru.index.loadFactor=.55
+ * tserver.cache.config.lru.data.loadFactor=.65
  * 
  *
  * 
@@ -123,7 +125,7 @@ public BlockCache getBlockCache(CacheType type) {
   protected abstract BlockCache createCache(Configuration conf, CacheType 
type);
 
   /**
-   * A convenience method that returns a string of the from {@code 
general.custom.cache..default.} this method is useful for configuring a 
cache
+   * A convenience method that returns a string of the from {@code 
tserver.cache.config..default.} this method is useful for configuring a 
cache
* manager.
*
* @param prefix
@@ -135,7 +137,7 @@ public static String getFullyQualifiedPropertyPrefix(String 
prefix) {
   }
 
   /**
-   * A convenience method that returns a string of the from {@code 
general.custom.cache...} this method is useful for configuring a 
cache manager.
+   * A convenience method that returns a string of the from {@code 
tserver.cache.config...} this method is useful for configuring a 
cache manager.
*
* @param prefix
*  A unique identifier that corresponds to a particular 
BlockCacheManager implementation.
diff --git 
a/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/impl/BlockCacheConfiguration.java
 
b/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/impl/BlockCacheConfiguration.java
index 7bf7503ff8..52f6c892c9 100644
--- 
a/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/impl/BlockCacheConfiguration.java
+++ 
b/core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/impl/BlockCacheConfiguration.java
@@ -41,7 +41,7 @@
   private final long summaryMaxSize;
 
   public BlockCacheConfiguration(AccumuloConfiguration conf) {
-genProps = 
conf.getAllPropertiesWithPrefix(Property.GENERAL_ARBITRARY_PROP_PREFIX);
+genProps = conf.getAllPropertiesWithPrefix(Property.TSERV_PREFIX);
 
 this.indexMaxSize = conf.getAsBytes(Property.TSERV_INDEXCACHE_SIZE);
 this.dataMaxSize =

Accumulo-Master - Build # 2190 - Unstable

2017-12-01 Thread Apache Jenkins Server

The Apache Jenkins build system has built Accumulo-Master (build #2190)

Status: Unstable

Check console output at https://builds.apache.org/job/Accumulo-Master/2190/ to 
view the results.

[GitHub] jkrdev commented on issue #328: ACCUMULO-4743 Replaced general custom with tserver prefix for cache config

2017-12-01 Thread GitBox

jkrdev commented on issue #328: ACCUMULO-4743 Replaced general custom with 
tserver prefix for cache config
URL: https://github.com/apache/accumulo/pull/328#issuecomment-348564063
 
 
   Great glad to hear that. alrighty. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] keith-turner closed pull request #321: ACCUMULO-4641 Added loading to cache API

2017-12-01 Thread GitBox

keith-turner closed pull request #321: ACCUMULO-4641 Added loading to cache API
URL: https://github.com/apache/accumulo/pull/321
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java 
b/core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java
index 301dfc530d..15c89ed3b8 100644
--- a/core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java
+++ b/core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java
@@ -23,10 +23,12 @@
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Set;
 import java.util.SortedSet;
 import java.util.concurrent.TimeUnit;
+import java.util.function.Supplier;
 
 import org.apache.accumulo.core.client.IteratorSetting;
 import org.apache.accumulo.core.client.Scanner;
@@ -95,10 +97,6 @@
   // block is accessed the entire thing is read into memory immediately 
allocating and deallocating
   // a decompressor. If the user does not read all data, no decompressors are 
left allocated.
   private static class NoopCache implements BlockCache {
-@Override
-public CacheEntry cacheBlock(String blockName, byte[] buf, boolean 
inMemory) {
-  return null;
-}
 
 @Override
 public CacheEntry cacheBlock(String blockName, byte[] buf) {
@@ -134,6 +132,43 @@ public long requestCount() {
 }
   };
 }
+
+@Override
+public CacheEntry getBlock(String blockName, Loader loader) {
+  Map depLoaders = loader.getDependencies();
+  Map depData;
+
+  switch (depLoaders.size()) {
+case 0:
+  depData = Collections.emptyMap();
+  break;
+case 1:
+  Entry entry = depLoaders.entrySet().iterator().next();
+  depData = Collections.singletonMap(entry.getKey(), 
getBlock(entry.getKey(), entry.getValue()).getBuffer());
+  break;
+default:
+  depData = new HashMap<>();
+  depLoaders.forEach((k, v) -> depData.put(k, getBlock(k, 
v).getBuffer()));
+  }
+
+  byte[] data = loader.load(Integer.MAX_VALUE, depData);
+
+  return new CacheEntry() {
+
+@Override
+public byte[] getBuffer() {
+  return data;
+}
+
+@Override
+public  T getIndex(Supplier supplier) {
+  return null;
+}
+
+@Override
+public void indexWeightChanged() {}
+  };
+}
   }
 
   RFileScanner(Opts opts) {
@@ -305,6 +340,7 @@ public SamplerConfiguration getSamplerConfiguration() {
   RFileSource[] sources = opts.in.getSources();
   List> readers = new 
ArrayList<>(sources.length);
   for (int i = 0; i < sources.length; i++) {
+// TODO may have been a bug with multiple files and caching in older 
version...
 FSDataInputStream inputStream = (FSDataInputStream) 
sources[i].getInputStream();
 readers.add(new RFile.Reader(new CachableBlockFile.Reader("source-" + 
i, inputStream, sources[i].getLength(), opts.in.getConf(), dataCache, 
indexCache,
 DefaultConfiguration.getInstance(;
diff --git 
a/core/src/main/java/org/apache/accumulo/core/client/rfile/RFileSummariesRetriever.java
 
b/core/src/main/java/org/apache/accumulo/core/client/rfile/RFileSummariesRetriever.java
index d3a83b0283..e4b3e057e7 100644
--- 
a/core/src/main/java/org/apache/accumulo/core/client/rfile/RFileSummariesRetriever.java
+++ 
b/core/src/main/java/org/apache/accumulo/core/client/rfile/RFileSummariesRetriever.java
@@ -86,9 +86,8 @@ public SummaryOptions endRow(Text endRow) {
 RFileSource[] sources = in.getSources();
 try {
   SummaryCollection all = new SummaryCollection();
-  for (int i = 0; i < sources.length; i++) {
-RFileSource source = sources[i];
-SummaryReader fileSummary = SummaryReader.load("source-"+i, conf, 
acuconf, source.getInputStream(), source.getLength(), summarySelector, factory);
+  for (RFileSource source : sources) {
+SummaryReader fileSummary = SummaryReader.load(conf, acuconf, 
source.getInputStream(), source.getLength(), summarySelector, factory);
 SummaryCollection sc = 
fileSummary.getSummaries(Collections.singletonList(new 
Gatherer.RowRange(startRow, endRow)));
 all.merge(sc, factory);
   }
diff --git 
a/core/src/main/java/org/apache/accumulo/core/file/blockfile/ABlockReader.java 
b/core/src/main/java/org/apache/accumulo/core/file/blockfile/ABlockReader.java
index 9f485d85d3..a0a7da8c7e 100644
--- 
a/core/src/main/java/org/apache/accumulo/core/file/blockfile/ABlockReader.java
+++ 
b/core/src/main/java/org/apache/accumulo/core/file/blockfile/ABlockReader.java
@@ -19,6 +19,9 @@

Accumulo-Master - Build # 2189 - Fixed

2017-12-01 Thread Apache Jenkins Server

The Apache Jenkins build system has built Accumulo-Master (build #2189)

Status: Fixed

Check console output at https://builds.apache.org/job/Accumulo-Master/2189/ to 
view the results.

[jira] [Assigned] (ACCUMULO-3185) Remove "walogs" directory from MAC instances

2017-12-01 Thread Keith Turner (JIRA)


 [ 
https://issues.apache.org/jira/browse/ACCUMULO-3185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Turner reassigned ACCUMULO-3185:
--

Assignee: Jared R

> Remove "walogs" directory from MAC instances
> 
>
> Key: ACCUMULO-3185
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3185
> Project: Accumulo
>  Issue Type: Task
>  Components: mini
>Affects Versions: 1.5.2, 1.6.1
>Reporter: Josh Elser
>Assignee: Jared R
>Priority: Trivial
>  Labels: newbie, pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Each MAC installation still makes a "walogs" directory which I'm guessing is 
> a holdover from pre-HDFS-WALs in 1.4. The directory appears to always be 
> empty and should not be created.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] keith-turner commented on a change in pull request #328: ACCUMULO-4743 Replaced general custom with tserver prefix for cache config

2017-12-01 Thread GitBox

keith-turner commented on a change in pull request #328: ACCUMULO-4743 Replaced 
general custom with tserver prefix for cache config
URL: https://github.com/apache/accumulo/pull/328#discussion_r154385273
 
 

 ##
 File path: 
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
 ##
 @@ -54,17 +54,19 @@
  * This method provides a way for a cache implementation to access 
arbitrary configuration set by a user.
  *
  * 
- * Returns all Accumulo properties that have a prefix of {@code 
general.custom.cache...} or {@code 
general.custom.cache..default.}
- * with values for specific cache types overriding defaults.
+ * Returns all Accumulo properties that have a prefix of {@code 
tserver.cache.config...} or {@code 
tserver.cache.config..default.}
+ * with
+ * values for
+ * specific cache types overriding defaults.
  *
  * 
  * For example assume the following data is in Accumulo's system config.
  *
  * 
- * general.custom.cache.lru.default.evictAfter=3600
- * general.custom.cache.lru.default.loadFactor=.75
- * general.custom.cache.lru.index.loadFactor=.55
- * general.custom.cache.lru.data.loadFactor=.65
+ * tserver.cache.lru.default.evictAfter=3600
 
 Review comment:
   these need to be updated with `config`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (ACCUMULO-3185) Remove "walogs" directory from MAC instances

2017-12-01 Thread Keith Turner (JIRA)


 [ 
https://issues.apache.org/jira/browse/ACCUMULO-3185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keith Turner resolved ACCUMULO-3185.

Resolution: Fixed

> Remove "walogs" directory from MAC instances
> 
>
> Key: ACCUMULO-3185
> URL: https://issues.apache.org/jira/browse/ACCUMULO-3185
> Project: Accumulo
>  Issue Type: Task
>  Components: mini
>Affects Versions: 1.5.2, 1.6.1
>Reporter: Josh Elser
>Priority: Trivial
>  Labels: newbie, pull-request-available
> Fix For: 2.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Each MAC installation still makes a "walogs" directory which I'm guessing is 
> a holdover from pre-HDFS-WALs in 1.4. The directory appears to always be 
> empty and should not be created.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] keith-turner closed pull request #329: ACCUMULO-3185 Removed references to walogs directory to stop it's creation.

2017-12-01 Thread GitBox

keith-turner closed pull request #329: ACCUMULO-3185 Removed references to 
walogs directory to stop it's creation.
URL: https://github.com/apache/accumulo/pull/329
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java
 
b/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java
index 6fd25776fb..09dd7e5e7e 100644
--- 
a/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java
+++ 
b/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java
@@ -396,7 +396,6 @@ public MiniAccumuloClusterImpl(MiniAccumuloConfigImpl 
config) throws IOException
 if (!config.useExistingInstance()) {
   if (!config.useExistingZooKeepers())
 mkdirs(config.getZooKeeperDir());
-  mkdirs(config.getWalogDir());
   mkdirs(config.getAccumuloDir());
 }
 
diff --git 
a/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java
 
b/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java
index 0f4634d55b..8064358afa 100644
--- 
a/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java
+++ 
b/minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java
@@ -64,7 +64,6 @@
   private File zooKeeperDir;
   private File accumuloDir;
   private File logDir;
-  private File walogDir;
 
   private int zooKeeperPort = 0;
   private int configuredZooKeeperPort = 0;
@@ -125,7 +124,6 @@ MiniAccumuloConfigImpl initialize() {
   accumuloDir = new File(dir, "accumulo");
   zooKeeperDir = new File(dir, "zookeeper");
   logDir = new File(dir, "logs");
-  walogDir = new File(dir, "walogs");
 
   // Never want to override these if an existing instance, which may be 
using the defaults
   if (existingInstance == null || !existingInstance) {
@@ -445,10 +443,6 @@ public File getLogDir() {
 return logDir;
   }
 
-  File getWalogDir() {
-return walogDir;
-  }
-
   /**
* @param serverType
*  get configuration for this server type


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (ACCUMULO-4749) Need a bulk loading test equivalent to continuous ingest

2017-12-01 Thread Ivan Bella (JIRA)

Ivan Bella created ACCUMULO-4749:


 Summary: Need a bulk loading test equivalent to continuous ingest
 Key: ACCUMULO-4749
 URL: https://issues.apache.org/jira/browse/ACCUMULO-4749
 Project: Accumulo
  Issue Type: Improvement
  Components: test
Reporter: Ivan Bella


There are some known cases at least in past versions where bulk loading may 
fail leaving the ~blip in place but no transaction left to handle it.  This 
will result in directories of files being left around that are not loaded.  We 
should create a continuous ingest variant that uses bulk loading instead.  Then 
if this is run with agitation, the continuous ingest verification can find data 
that has been essentially orphaned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ACCUMULO-4748) Verification of continuous ingest with aggitation should check for orphaned files

2017-12-01 Thread Ivan Bella (JIRA)

Ivan Bella created ACCUMULO-4748:


 Summary: Verification of continuous ingest with aggitation should 
check for orphaned files
 Key: ACCUMULO-4748
 URL: https://issues.apache.org/jira/browse/ACCUMULO-4748
 Project: Accumulo
  Issue Type: Improvement
  Components: test
Reporter: Ivan Bella


We have found instances where files are being orphaned but we have not as of 
writing this ticket figured out why.  We should however expand the continuous 
ingest verification to check for orphaned files which we hypothesize will show 
up when agitation is when running continuous ingest.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] keith-turner commented on a change in pull request #325: ACCUMULO-2341?

2017-12-01 Thread GitBox

keith-turner commented on a change in pull request #325: ACCUMULO-2341?
URL: https://github.com/apache/accumulo/pull/325#discussion_r154384723
 
 

 ##
 File path: server/base/src/main/java/org/apache/accumulo/server/util/Admin.java
 ##
 @@ -354,12 +354,8 @@ public void run() {
   }
 
   private static void stopServer(final ClientContext context, final boolean 
tabletServersToo) throws AccumuloException, AccumuloSecurityException {
-MasterClient.executeVoid(context, new 
ClientExec() {
-  @Override
-  public void execute(MasterClientService.Client client) throws Exception {
-client.shutdown(Tracer.traceInfo(), context.rpcCreds(), 
tabletServersToo);
-  }
-});
+MasterClient.executeVoidWithConnRetry(context,
 
 Review comment:
   > What if we have some networking issue ? This way we cannot recover...
   
   Can you give me an example of the situation you are thinking of?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] milleruntime commented on issue #326: ACCUMULO-4745 Fixed broken links in tables table on monitor

2017-12-01 Thread GitBox

milleruntime commented on issue #326: ACCUMULO-4745 Fixed broken links in 
tables table on monitor
URL: https://github.com/apache/accumulo/pull/326#issuecomment-348535523
 
 
   Yeah I think that is fine.  You could also use the same branch and pull 
request.  Then we can squash your changes into one commit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Assigned] (ACCUMULO-4746) Create Builder for Mutation

2017-12-01 Thread Benjamin F (JIRA)


 [ 
https://issues.apache.org/jira/browse/ACCUMULO-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin F reassigned ACCUMULO-4746:


Assignee: Benjamin F

> Create Builder for Mutation
> ---
>
> Key: ACCUMULO-4746
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4746
> Project: Accumulo
>  Issue Type: Sub-task
>  Components: client
>Reporter: Keith Turner
>Assignee: Benjamin F
> Fix For: 2.0.0
>
>
> Accumulo needs a builder for mutation similar to the one that was added for 
> Key.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (ACCUMULO-4747) Create a unified upgrade reference

2017-12-01 Thread Mark Owens (JIRA)


 [ 
https://issues.apache.org/jira/browse/ACCUMULO-4747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Owens reassigned ACCUMULO-4747:


Assignee: Mark Owens

> Create a unified upgrade reference
> --
>
> Key: ACCUMULO-4747
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4747
> Project: Accumulo
>  Issue Type: Improvement
>  Components: docs
>Reporter: Mark Owens
>Assignee: Mark Owens
>Priority: Minor
>  Labels: documentation
>
> It could be helpful to have a page which provides upgrade instructions for 
> the various releases collected into one location. This page could then be 
> updated as needed as new versions are released. Prompted by someone needing 
> to upgrade for 1.4 to 1.8 and looking for a good location to find what steps 
> would be needed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] bfach10 commented on issue #326: ACCUMULO-4745 Fixed broken links in tables table on monitor

2017-12-01 Thread GitBox

bfach10 commented on issue #326: ACCUMULO-4745 Fixed broken links in tables 
table on monitor
URL: https://github.com/apache/accumulo/pull/326#issuecomment-348509692
 
 
   @milleruntime happy to work on those classes as well. Just keep it in this 
ticket?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jkrdev commented on a change in pull request #328: ACCUMULO-4743 Replaced general custom with tserver prefix for cache config

2017-12-01 Thread GitBox

jkrdev commented on a change in pull request #328: ACCUMULO-4743 Replaced 
general custom with tserver prefix for cache config
URL: https://github.com/apache/accumulo/pull/328#discussion_r154343257
 
 

 ##
 File path: 
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java
 ##
 @@ -30,7 +30,7 @@
 
   private final Map caches = new HashMap<>();
 
-  public static final String CACHE_PROPERTY_BASE = 
Property.GENERAL_ARBITRARY_PROP_PREFIX + "cache.";
+  public static final String CACHE_PROPERTY_BASE = Property.TSERV_PREFIX + 
"cache.";
 
 Review comment:
   I actually had that before, I will change it and rebuild and then hopefully 
it works with keith-turner/accumulo-ohc .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

38 matches

Mail list logo