[GitHub] milleruntime commented on a change in pull request #352: ACCUMULO-4771 Implement DataTables in Monitor

2018-01-09 Thread GitBox
milleruntime commented on a change in pull request #352: ACCUMULO-4771 
Implement DataTables in Monitor
URL: https://github.com/apache/accumulo/pull/352#discussion_r160547497
 
 

 ##
 File path: 
server/monitor/src/main/java/org/apache/accumulo/monitor/rest/tables/TableInformationList.java
 ##
 @@ -21,15 +21,15 @@
 
 /**
  *
- * Generates a list with table information
+ * Generates a list with table information. This is mainly used to populate 
DataTables
 
 Review comment:
   FYI I figured out how to tell DataTables to look for "table" vs "data".  Its 
easy I was just using the wrong json parameter.  This will make it so less 
changes are needed and we can use the POJOs already returned by our rest 
endpoints.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Assigned] (ACCUMULO-4158) Investigate using Google's error-prone

2018-01-09 Thread Mark Owens (JIRA)

 [ 
https://issues.apache.org/jira/browse/ACCUMULO-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Owens reassigned ACCUMULO-4158:


Assignee: Mark Owens

> Investigate using Google's error-prone
> --
>
> Key: ACCUMULO-4158
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4158
> Project: Accumulo
>  Issue Type: Improvement
>  Components: build
>Reporter: Michael Wall
>Assignee: Mark Owens
>Priority: Minor
>
> Google has a tool at http://errorprone.info.  From that page
> {quote}
> Using Error Prone to augment the compiler’s type analysis, you can catch more 
> mistakes before they cost you time, or end up as bugs in production.
> {quote}
> It requires java 1.8.  In the top level pom, replacing
> {code:xml}
> 
>   maven-compiler-plugin
>   
> ${java.ver}
> ${java.ver}
> true
> true
> true
>   
> 
> {code}
> with
> {code:xml}
> 
>   org.apache.maven.plugins
>   maven-compiler-plugin
>   3.3
>   
> javac-with-errorprone
> true
> 
> ${java.ver}
> ${java.ver}
> 
>   -Xep:ChainingConstructorIgnoresParameter:WARN
>   -Xep:LongLiteralLowerCaseSuffix:OFF
>   -Xep:SizeGreaterThanOrEqualsZero:WARN
>   -Xep:InvalidPatternSyntax:WARN
>   -Xep:TryFailThrowable:WARN
>   -Xep:NonOverridingEquals:OFF
> 
> true
>   
>   
> 
> 
>   com.google.errorprone
>   error_prone_core
>   2.0.8
> 
> 
>   org.codehaus.plexus
>   plexus-compiler-javac-errorprone
>   2.5
> 
>   
> 
> {code}
> in the 1.6 branch and runing 'mvn compile' yielded the following. 
> {noformat}
> [INFO] Scanning for projects...
> [INFO] 
> 
> [INFO] Reactor Build Order:
> [INFO] 
> [INFO] Apache Accumulo Project
> [INFO] Apache Accumulo Trace
> [INFO] Apache Accumulo Fate
> [INFO] Apache Accumulo Start
> [INFO] Apache Accumulo Core
> [INFO] Apache Accumulo Simple Examples
> [INFO] Apache Accumulo Server Base
> [INFO] Apache Accumulo GC Server
> [INFO] Apache Accumulo Master Server
> [INFO] Apache Accumulo Monitor Server
> [INFO] Apache Accumulo Tracer Server
> [INFO] Apache Accumulo Tablet Server
> [INFO] Apache Accumulo MiniCluster
> [INFO] Apache Accumulo Native Libraries
> [INFO] Apache Accumulo Testing
> [INFO] Apache Accumulo Proxy
> [INFO] Apache Accumulo
> [INFO] Apache Accumulo Documentation
> [INFO] Apache Accumulo Maven Plugin
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Apache Accumulo Project 1.6.6-SNAPSHOT
> [INFO] 
> 
> ...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Apache Accumulo Trace 1.6.6-SNAPSHOT
> [INFO] 
> 
> ...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Apache Accumulo Fate 1.6.6-SNAPSHOT
> [INFO] 
> 
> ...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Apache Accumulo Start 1.6.6-SNAPSHOT
> [INFO] 
> 
> ...
> [INFO]
>  
> [INFO] 
> 
> [INFO] Building Apache Accumulo Core 1.6.6-SNAPSHOT
> [INFO] 
> 
> ...
> [INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @ 
> accumulo-core ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 595 source files to 
> /Users/mjwall/NetBeansProjects/accumulo-mjwall/core/target/classes
> /Users/mjwall/NetBeansProjects/accumulo-mjwall/core/src/main/java/org/apache/accumulo/core/data/Value.java:80:
>  warning: [ChainingConstructorIgnoresParameter] The called constructor 
> acc

[GitHub] milleruntime commented on issue #352: ACCUMULO-4771 Implement DataTables in Monitor

2018-01-09 Thread GitBox
milleruntime commented on issue #352: ACCUMULO-4771 Implement DataTables in 
Monitor
URL: https://github.com/apache/accumulo/pull/352#issuecomment-356385931
 
 
   I am going to close this PR so I can rebase, dropping the unnecessary 
commits.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] milleruntime commented on issue #352: ACCUMULO-4771 Implement DataTables in Monitor

2018-01-09 Thread GitBox
milleruntime commented on issue #352: ACCUMULO-4771 Implement DataTables in 
Monitor
URL: https://github.com/apache/accumulo/pull/352#issuecomment-356385440
 
 
   The more I think about wrapping the current REST endpoints, the more I 
realize that just complicates the backend. I am thinking the Monitor should be 
as simple as possible with everything useful that was in the old one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] milleruntime commented on issue #352: ACCUMULO-4771 Implement DataTables in Monitor

2018-01-09 Thread GitBox
milleruntime commented on issue #352: ACCUMULO-4771 Implement DataTables in 
Monitor
URL: https://github.com/apache/accumulo/pull/352#issuecomment-356381781
 
 
   What do you guys think of 5373bb25fb49a83fd8fa1f565b683fe62738110f ?  It is 
a wrapper for DataTables so any JSON object we want to render we could just 
wrap with the class.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services