[jira] [Assigned] (ACCUMULO-4158) Investigate using Google's error-prone
[
https://issues.apache.org/jira/browse/ACCUMULO-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Owens reassigned ACCUMULO-4158:
Assignee: (was: Mark Owens)
> Investigate using Google's error-prone
> --
>
> Key: ACCUMULO-4158
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4158
> Project: Accumulo
> Issue Type: Improvement
> Components: build
>Reporter: Michael Wall
>Priority: Minor
> Attachments: ep-main.summary, ep-tests.summary
>
>
> Google has a tool at http://errorprone.info. From that page
> {quote}
> Using Error Prone to augment the compiler’s type analysis, you can catch more
> mistakes before they cost you time, or end up as bugs in production.
> {quote}
> It requires java 1.8. In the top level pom, replacing
> {code:xml}
>
> maven-compiler-plugin
>
> ${java.ver}
> ${java.ver}
> true
> true
> true
>
>
> {code}
> with
> {code:xml}
>
> org.apache.maven.plugins
> maven-compiler-plugin
> 3.3
>
> javac-with-errorprone
> true
>
> ${java.ver}
> ${java.ver}
>
> -Xep:ChainingConstructorIgnoresParameter:WARN
> -Xep:LongLiteralLowerCaseSuffix:OFF
> -Xep:SizeGreaterThanOrEqualsZero:WARN
> -Xep:InvalidPatternSyntax:WARN
> -Xep:TryFailThrowable:WARN
> -Xep:NonOverridingEquals:OFF
>
> true
>
>
>
>
> com.google.errorprone
> error_prone_core
> 2.0.8
>
>
> org.codehaus.plexus
> plexus-compiler-javac-errorprone
> 2.5
>
>
>
> {code}
> in the 1.6 branch and runing 'mvn compile' yielded the following.
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] Apache Accumulo Project
> [INFO] Apache Accumulo Trace
> [INFO] Apache Accumulo Fate
> [INFO] Apache Accumulo Start
> [INFO] Apache Accumulo Core
> [INFO] Apache Accumulo Simple Examples
> [INFO] Apache Accumulo Server Base
> [INFO] Apache Accumulo GC Server
> [INFO] Apache Accumulo Master Server
> [INFO] Apache Accumulo Monitor Server
> [INFO] Apache Accumulo Tracer Server
> [INFO] Apache Accumulo Tablet Server
> [INFO] Apache Accumulo MiniCluster
> [INFO] Apache Accumulo Native Libraries
> [INFO] Apache Accumulo Testing
> [INFO] Apache Accumulo Proxy
> [INFO] Apache Accumulo
> [INFO] Apache Accumulo Documentation
> [INFO] Apache Accumulo Maven Plugin
> [INFO]
>
> [INFO]
>
> [INFO] Building Apache Accumulo Project 1.6.6-SNAPSHOT
> [INFO]
>
> ...
> [INFO]
>
> [INFO]
>
> [INFO] Building Apache Accumulo Trace 1.6.6-SNAPSHOT
> [INFO]
>
> ...
> [INFO]
>
> [INFO]
>
> [INFO] Building Apache Accumulo Fate 1.6.6-SNAPSHOT
> [INFO]
>
> ...
> [INFO]
>
> [INFO]
>
> [INFO] Building Apache Accumulo Start 1.6.6-SNAPSHOT
> [INFO]
>
> ...
> [INFO]
>
> [INFO]
>
> [INFO] Building Apache Accumulo Core 1.6.6-SNAPSHOT
> [INFO]
>
> ...
> [INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @
> accumulo-core ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 595 source files to
> /Users/mjwall/NetBeansProjects/accumulo-mjwall/core/target/classes
> /Users/mjwall/NetBeansProjects/accumulo-mjwall/core/src/main/java/org/apache/accumulo/core/data/Value.java:80:
> warning:
[jira] [Assigned] (ACCUMULO-4158) Investigate using Google's error-prone
[
https://issues.apache.org/jira/browse/ACCUMULO-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Owens reassigned ACCUMULO-4158:
Assignee: Mark Owens
> Investigate using Google's error-prone
> --
>
> Key: ACCUMULO-4158
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4158
> Project: Accumulo
> Issue Type: Improvement
> Components: build
>Reporter: Michael Wall
>Assignee: Mark Owens
>Priority: Minor
>
> Google has a tool at http://errorprone.info. From that page
> {quote}
> Using Error Prone to augment the compiler’s type analysis, you can catch more
> mistakes before they cost you time, or end up as bugs in production.
> {quote}
> It requires java 1.8. In the top level pom, replacing
> {code:xml}
>
> maven-compiler-plugin
>
> ${java.ver}
> ${java.ver}
> true
> true
> true
>
>
> {code}
> with
> {code:xml}
>
> org.apache.maven.plugins
> maven-compiler-plugin
> 3.3
>
> javac-with-errorprone
> true
>
> ${java.ver}
> ${java.ver}
>
> -Xep:ChainingConstructorIgnoresParameter:WARN
> -Xep:LongLiteralLowerCaseSuffix:OFF
> -Xep:SizeGreaterThanOrEqualsZero:WARN
> -Xep:InvalidPatternSyntax:WARN
> -Xep:TryFailThrowable:WARN
> -Xep:NonOverridingEquals:OFF
>
> true
>
>
>
>
> com.google.errorprone
> error_prone_core
> 2.0.8
>
>
> org.codehaus.plexus
> plexus-compiler-javac-errorprone
> 2.5
>
>
>
> {code}
> in the 1.6 branch and runing 'mvn compile' yielded the following.
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] Apache Accumulo Project
> [INFO] Apache Accumulo Trace
> [INFO] Apache Accumulo Fate
> [INFO] Apache Accumulo Start
> [INFO] Apache Accumulo Core
> [INFO] Apache Accumulo Simple Examples
> [INFO] Apache Accumulo Server Base
> [INFO] Apache Accumulo GC Server
> [INFO] Apache Accumulo Master Server
> [INFO] Apache Accumulo Monitor Server
> [INFO] Apache Accumulo Tracer Server
> [INFO] Apache Accumulo Tablet Server
> [INFO] Apache Accumulo MiniCluster
> [INFO] Apache Accumulo Native Libraries
> [INFO] Apache Accumulo Testing
> [INFO] Apache Accumulo Proxy
> [INFO] Apache Accumulo
> [INFO] Apache Accumulo Documentation
> [INFO] Apache Accumulo Maven Plugin
> [INFO]
>
> [INFO]
>
> [INFO] Building Apache Accumulo Project 1.6.6-SNAPSHOT
> [INFO]
>
> ...
> [INFO]
>
> [INFO]
>
> [INFO] Building Apache Accumulo Trace 1.6.6-SNAPSHOT
> [INFO]
>
> ...
> [INFO]
>
> [INFO]
>
> [INFO] Building Apache Accumulo Fate 1.6.6-SNAPSHOT
> [INFO]
>
> ...
> [INFO]
>
> [INFO]
>
> [INFO] Building Apache Accumulo Start 1.6.6-SNAPSHOT
> [INFO]
>
> ...
> [INFO]
>
> [INFO]
>
> [INFO] Building Apache Accumulo Core 1.6.6-SNAPSHOT
> [INFO]
>
> ...
> [INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @
> accumulo-core ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 595 source files to
> /Users/mjwall/NetBeansProjects/accumulo-mjwall/core/target/classes
> /Users/mjwall/NetBeansProjects/accumulo-mjwall/core/src/main/java/org/apache/accumulo/core/data/Value.java:80:
> warning: [ChainingConstructorIgnoresParameter] The called constructor
>
