[jira] [Commented] (ACCUMULO-2418) replace empty loops in tests with simple count method
[ https://issues.apache.org/jira/browse/ACCUMULO-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914746#comment-13914746 ] ASF subversion and git services commented on ACCUMULO-2418: --- Commit eab028a4894c363c112df051ceebbd5584075769 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from [~ecn] [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=eab028a ] ACCUMULO-2418 use utility method to count iterables > replace empty loops in tests with simple count method > - > > Key: ACCUMULO-2418 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2418 > Project: Accumulo > Issue Type: Bug > Components: test >Reporter: Eric Newton >Assignee: Eric Newton >Priority: Trivial > Fix For: 1.6.0 > > > While fixing ACCUMULO-2405, I created a simple method to eliminate a loop. > There are many tests that could use this method. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ACCUMULO-2418) replace empty loops in tests with simple count method
[ https://issues.apache.org/jira/browse/ACCUMULO-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914748#comment-13914748 ] ASF subversion and git services commented on ACCUMULO-2418: --- Commit eab028a4894c363c112df051ceebbd5584075769 in accumulo's branch refs/heads/master from [~ecn] [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=eab028a ] ACCUMULO-2418 use utility method to count iterables > replace empty loops in tests with simple count method > - > > Key: ACCUMULO-2418 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2418 > Project: Accumulo > Issue Type: Bug > Components: test >Reporter: Eric Newton >Assignee: Eric Newton >Priority: Trivial > Fix For: 1.6.0 > > > While fixing ACCUMULO-2405, I created a simple method to eliminate a loop. > There are many tests that could use this method. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ACCUMULO-2418) replace empty loops in tests with simple count method
[ https://issues.apache.org/jira/browse/ACCUMULO-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914766#comment-13914766 ] ASF subversion and git services commented on ACCUMULO-2418: --- Commit b9bc5e259dc990bd1e03e0decc8aa6510a91b290 in accumulo's branch refs/heads/master from [~ecn] [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=b9bc5e2 ] ACCUMULO-2418 add fail message back > replace empty loops in tests with simple count method > - > > Key: ACCUMULO-2418 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2418 > Project: Accumulo > Issue Type: Bug > Components: test >Reporter: Eric Newton >Assignee: Eric Newton >Priority: Trivial > Fix For: 1.6.0 > > > While fixing ACCUMULO-2405, I created a simple method to eliminate a loop. > There are many tests that could use this method. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ACCUMULO-2418) replace empty loops in tests with simple count method
[
https://issues.apache.org/jira/browse/ACCUMULO-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914757#comment-13914757
]
Mike Drob commented on ACCUMULO-2418:
-
minor nit: you dropped the fail message from {{NoMutationRecoveryIT.java}} when
it could have been part of the assert.
{noformat}
-for (@SuppressWarnings("unused") Entry refs : getLogRefs(conn,
MetadataTable.NAME)) {
- fail("should not have any refs");
-}
+assertEquals(0, FunctionalTestUtils.count(getLogRefs(conn,
MetadataTable.NAME)));
{noformat}
> replace empty loops in tests with simple count method
> -
>
> Key: ACCUMULO-2418
> URL: https://issues.apache.org/jira/browse/ACCUMULO-2418
> Project: Accumulo
> Issue Type: Bug
> Components: test
>Reporter: Eric Newton
>Assignee: Eric Newton
>Priority: Trivial
> Fix For: 1.6.0
>
>
> While fixing ACCUMULO-2405, I created a simple method to eliminate a loop.
> There are many tests that could use this method.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (ACCUMULO-2418) replace empty loops in tests with simple count method
[ https://issues.apache.org/jira/browse/ACCUMULO-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914765#comment-13914765 ] ASF subversion and git services commented on ACCUMULO-2418: --- Commit b9bc5e259dc990bd1e03e0decc8aa6510a91b290 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from [~ecn] [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=b9bc5e2 ] ACCUMULO-2418 add fail message back > replace empty loops in tests with simple count method > - > > Key: ACCUMULO-2418 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2418 > Project: Accumulo > Issue Type: Bug > Components: test >Reporter: Eric Newton >Assignee: Eric Newton >Priority: Trivial > Fix For: 1.6.0 > > > While fixing ACCUMULO-2405, I created a simple method to eliminate a loop. > There are many tests that could use this method. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (ACCUMULO-2418) replace empty loops in tests with simple count method
[ https://issues.apache.org/jira/browse/ACCUMULO-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13914768#comment-13914768 ] Eric Newton commented on ACCUMULO-2418: --- Good catch, thanks! > replace empty loops in tests with simple count method > - > > Key: ACCUMULO-2418 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2418 > Project: Accumulo > Issue Type: Bug > Components: test >Reporter: Eric Newton >Assignee: Eric Newton >Priority: Trivial > Fix For: 1.6.0 > > > While fixing ACCUMULO-2405, I created a simple method to eliminate a loop. > There are many tests that could use this method. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
