Re: [I] HostRegexTableLoadBalancer logging change for migrations [accumulo]

2024-07-26 Thread via GitHub


ctubbsii commented on issue #4469:
URL: https://github.com/apache/accumulo/issues/4469#issuecomment-2252196638

   Closing due to lack of response, and it seems like this is fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] HostRegexTableLoadBalancer logging change for migrations [accumulo]

2024-07-26 Thread via GitHub


ctubbsii closed issue #4469: HostRegexTableLoadBalancer logging change for 
migrations
URL: https://github.com/apache/accumulo/issues/4469


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] HostRegexTableLoadBalancer logging change for migrations [accumulo]

2024-07-05 Thread via GitHub


ddanielr commented on issue #4469:
URL: https://github.com/apache/accumulo/issues/4469#issuecomment-2211389540

   @dtspence are the changes in https://github.com/apache/accumulo/pull/4592 
sufficient for this issue? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] HostRegexTableLoadBalancer logging change for migrations [accumulo]

2024-04-18 Thread via GitHub


dtspence commented on issue #4469:
URL: https://github.com/apache/accumulo/issues/4469#issuecomment-2065620709

   @EdColeman 
   > As for the level change: The logging config is dynamic and can be changed 
at run-time. Why is it insufficient to set the HostRegexTableLoadBlancer to 
trace if that level of detail is necessary to troubleshoot? Maybe some debug 
level statements could be added that provide a summary (and maybe that's 
provided by logging the number?).
   
   Thank you - in the particular issue we encountered - it took some time 
investigating (another team was performing the restart of the cluster) and I 
did not look at the code until later to see the TRACE statement. We encountered 
an issue again today and set the class to TRACE level to learn more about the 
problem.
   
   @ddanielr 
   > We could make the change to add the summary count of moved, then if 
"moved" hasn't progressed in 5min, bump the "TRACE" message to "DEBUG"
   We've done similar things in the code to help with "spammy" messages without 
requiring log4j2.property file changes.
   f98c87c
   
   Thank you - this sounds like a good idea. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] HostRegexTableLoadBalancer logging change for migrations [accumulo]

2024-04-18 Thread via GitHub


ddanielr commented on issue #4469:
URL: https://github.com/apache/accumulo/issues/4469#issuecomment-2063821160

   > 1. Log the migrations that are not moving as DEBUG. The message is 
currently TRACE.
   To avoid the logging option changes, we could probably take a look at this 
and do some caching. 
   
   > Rather than just changing the level, is there something that could provide 
a summary, maybe with counts of #moved, #to be moved, #seen before but not 
moved,... Something that would be a one-liner, but sufficient to show progress, 
amount of work remaining. Then, if that points to something not making 
progress, that would trigger modifying the log level if needed.
   
   We could make the change to add the summary count of moved, then if "moved" 
hasn't progressed in 5min, bump the "TRACE" message to "DEBUG"
   We've done similar things in the code to help with "spammy" messages without 
requiring log4j2.property file changes.
   
https://github.com/apache/accumulo/commit/f98c87cb5798c781364a7773d17b1325a73b9f5d
 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] HostRegexTableLoadBalancer logging change for migrations [accumulo]

2024-04-18 Thread via GitHub


EdColeman commented on issue #4469:
URL: https://github.com/apache/accumulo/issues/4469#issuecomment-2063771291

   There seems two parts to this request.  Logging the number of migrations 
separately seems helpful.
   
   As for the level change:  The logging config is dynamic and can be changed 
at run-time.  Why is it insufficient to set the HostRegexTableLoadBlancer to 
trace if that level of detail is necessary to troubleshoot?  Maybe some debug 
level statements could be added that provide a summary (and maybe that's 
provided by logging the number?).
   
   Often, we seem to ping-pong with logging in these cases.  It's needed in a 
rare case so the level is elevated - then later a different issue occurs and 
it's noticed that the logging is excessive when things are operating as 
expected and are not providing useful information, so the log level is then 
reduced.
   
   Rather than just changing the level, is there something that could provide a 
summary, maybe with counts of #moved, #to be moved, #seen before but not 
moved,...  Something that would be a one-liner, but sufficient to show 
progress, amount of work remaining.  Then, if that points to something not 
making progress, that would trigger modifying the log level if needed.
   
   I am not saying that this change may be unnecessary or helpful in this 
situation - rather just asking the question to see if there is something that 
may add more value (even if it's more work).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] HostRegexTableLoadBalancer logging change for migrations [accumulo]

2024-04-18 Thread via GitHub


ddanielr commented on issue #4469:
URL: https://github.com/apache/accumulo/issues/4469#issuecomment-2063693600

   Feature request is a logging change to assist with troubleshooting. 
   Should probably look at any other balancer code and update those as well. 
   
   Might be worth looking into if this is something that can be handled at a 
higher level in `3.1` vs in each individual balancer. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org