DO NOT REPLY [Bug 45718] Enhance bzip2 for Hadoop
https://issues.apache.org/bugzilla/show_bug.cgi?id=45718 --- Comment #1 from Stefan Bodewig <[EMAIL PROTECTED]> 2008-10-06 02:09:34 PST --- If I had to point at the piece of code inside Ant's source tree that is the least understood one (by the current set of active committers) I'd immediately choose the bzip2 package. I completely agree with the reasons why the code could and should be changed (though I might argue that using commons-compress instead of Ant's libraries might be better if all you want is compression), but don't think anybody around Ant currently knows the BZIP2 algorithm well enough to actually make the changes. Patches with tests are certainly welcome ;-) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 45944] Bug using the file element as a nested element in the Copy task
https://issues.apache.org/bugzilla/show_bug.cgi?id=45944 Stefan Bodewig <[EMAIL PROTECTED]> changed: What|Removed |Added CC||notifications@ant.apache.org AssignedTo|notifications@ant.apache.org|[EMAIL PROTECTED] Target Milestone|--- |1.8.0 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
svn commit: r702138 - in /ant/core/trunk/src: main/org/apache/tools/ant/taskdefs/Copy.java tests/antunit/taskdefs/copy-test.xml
Author: bodewig
Date: Mon Oct 6 05:44:29 2008
New Revision: 702138
URL: http://svn.apache.org/viewvc?rev=702138&view=rev
Log:
(disabled) tests for PR 45944
Added:
ant/core/trunk/src/tests/antunit/taskdefs/copy-test.xml (with props)
Modified:
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Copy.java
Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Copy.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Copy.java?rev=702138&r1=702137&r2=702138&view=diff
==
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Copy.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Copy.java Mon Oct 6
05:44:29 2008
@@ -567,8 +567,10 @@
}
}
}
+
private void iterateOverBaseDirs(
HashSet baseDirs, HashMap dirsByBasedir, HashMap filesByBasedir) {
+
Iterator iter = baseDirs.iterator();
while (iter.hasNext()) {
File f = (File) iter.next();
Added: ant/core/trunk/src/tests/antunit/taskdefs/copy-test.xml
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/tests/antunit/taskdefs/copy-test.xml?rev=702138&view=auto
==
--- ant/core/trunk/src/tests/antunit/taskdefs/copy-test.xml (added)
+++ ant/core/trunk/src/tests/antunit/taskdefs/copy-test.xml Mon Oct 6 05:44:29
2008
@@ -0,0 +1,63 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Propchange: ant/core/trunk/src/tests/antunit/taskdefs/copy-test.xml
--
svn:eol-style = native
DO NOT REPLY [Bug 45944] Bug using the file element as a nested element in the Copy task
https://issues.apache.org/bugzilla/show_bug.cgi?id=45944 Stefan Bodewig <[EMAIL PROTECTED]> changed: What|Removed |Added Component|Core|Core tasks OS/Version|Linux |All --- Comment #1 from Stefan Bodewig <[EMAIL PROTECTED]> 2008-10-06 05:52:37 PST --- The issue here is that a file resource represents an absolute path unless you also set the basedir attribute. If you don't specify a mapper, the identity-mapper will be used in order to determine the target file name, which in the case of an absolute path is the file itself. If you change you example to either or it will copy the files. I completely agree this is inconsistent with the docs, but I think the docs are wrong and need to talk about resources returning absolute paths. I don't really know how is supposed to pick the target file names from our examples - flatten seems both reasonable and arbitrary. Before I go any further, I'm going to raise this on the dev list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
DO NOT REPLY [Bug 45944] Bug using the file element as a nested element in the Copy task
https://issues.apache.org/bugzilla/show_bug.cgi?id=45944 --- Comment #2 from Stefan Bodewig <[EMAIL PROTECTED]> 2008-10-06 06:27:38 PST --- (In reply to comment #1) > > > > > > should have been -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
svn commit: r702176 - in /ant/core/trunk/src/tests/antunit/taskdefs/optional/depend: ./ depend-test.xml
Author: bodewig Date: Mon Oct 6 08:25:46 2008 New Revision: 702176 URL: http://svn.apache.org/viewvc?rev=702176&view=rev Log: (disabled) testcase for Bug 45916 Added: ant/core/trunk/src/tests/antunit/taskdefs/optional/depend/ ant/core/trunk/src/tests/antunit/taskdefs/optional/depend/depend-test.xml (with props) Added: ant/core/trunk/src/tests/antunit/taskdefs/optional/depend/depend-test.xml URL: http://svn.apache.org/viewvc/ant/core/trunk/src/tests/antunit/taskdefs/optional/depend/depend-test.xml?rev=702176&view=auto == --- ant/core/trunk/src/tests/antunit/taskdefs/optional/depend/depend-test.xml (added) +++ ant/core/trunk/src/tests/antunit/taskdefs/optional/depend/depend-test.xml Mon Oct 6 08:25:46 2008 @@ -0,0 +1,70 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Propchange: ant/core/trunk/src/tests/antunit/taskdefs/optional/depend/depend-test.xml -- svn:eol-style = native
DO NOT REPLY [Bug 45916] Depend task may remove (inner) classes without source files
https://issues.apache.org/bugzilla/show_bug.cgi?id=45916 Stefan Bodewig <[EMAIL PROTECTED]> changed: What|Removed |Added CC||notifications@ant.apache.org AssignedTo|notifications@ant.apache.org|[EMAIL PROTECTED] Target Milestone|--- |1.8.0 --- Comment #1 from Stefan Bodewig <[EMAIL PROTECTED]> 2008-10-06 08:26:18 PST --- OK, it seems it depends on the JDK since the test seems to pass on JDK 1.4 (but to be totally sure I need to fix what looks like a JAR handle leak in first). "the test" is a modified version of your test that I committed as svn revision 702176. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug.
[jira] Commented: (IVY-931) Ivy badly attempt to locate a 'working@' dependency revision when the dependency revision is not set in a pom
[ https://issues.apache.org/jira/browse/IVY-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637125#action_12637125 ] Xavier Hanin commented on IVY-931: -- I'm pretty sure it fails, but a try with the latest version would be nice. > Ivy badly attempt to locate a 'working@' dependency revision when the > dependency revision is not set in a pom > --- > > Key: IVY-931 > URL: https://issues.apache.org/jira/browse/IVY-931 > Project: Ivy > Issue Type: Bug >Affects Versions: 2.0-RC1 >Reporter: Xavier Hanin > > If in a pom a dependency is declared without revision, Ivy interprets it as a > 'working@' revision, which is very confusing. This may happen for > instance when Ivy cannot locate a parent pom which contains a > dependencyManagement section. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
DO NOT REPLY [Bug 45955] New: doesn't close JARs in classpath
https://issues.apache.org/bugzilla/show_bug.cgi?id=45955 Summary: doesn't close JARs in classpath Product: Ant Version: 1.7.1 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Optional Tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] CC: notifications@ant.apache.org see the currently disabled test for bug 45916 - tearDown fails since A.jar can't be removed on Windows. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
svn commit: r702188 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/optional/depend/AntAnalyzer.java src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java src/tests/
Author: bodewig
Date: Mon Oct 6 09:15:08 2008
New Revision: 702188
URL: http://svn.apache.org/viewvc?rev=702188&view=rev
Log:
make sure closes JARs. PR 45955.
Modified:
ant/core/trunk/WHATSNEW
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/AntAnalyzer.java
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
ant/core/trunk/src/tests/antunit/taskdefs/optional/depend/depend-test.xml
Modified: ant/core/trunk/WHATSNEW
URL:
http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?rev=702188&r1=702187&r2=702188&view=diff
==
--- ant/core/trunk/WHATSNEW (original)
+++ ant/core/trunk/WHATSNEW Mon Oct 6 09:15:08 2008
@@ -229,6 +229,9 @@
* could miss multi-character begin tokens in some cases.
Bugzilla Report 45094.
+ * didn't close JARs that were part of the classpath.
+ Bugzilla Report 45955.
+
Other changes:
--
Modified:
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/AntAnalyzer.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/AntAnalyzer.java?rev=702188&r1=702187&r2=702188&view=diff
==
---
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/AntAnalyzer.java
(original)
+++
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/AntAnalyzer.java
Mon Oct 6 09:15:08 2008
@@ -26,6 +26,7 @@
import java.util.Vector;
import java.util.zip.ZipEntry;
import java.util.zip.ZipFile;
+import org.apache.tools.ant.util.FileUtils;
import org.apache.tools.ant.util.depend.AbstractAnalyzer;
/**
@@ -96,9 +97,7 @@
analyzedDeps.put(dependency, dependency);
}
} finally {
-if (inStream != null) {
-inStream.close();
-}
+FileUtils.close(inStream);
if (zipFile != null) {
zipFile.close();
}
Modified:
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java?rev=702188&r1=702187&r2=702188&view=diff
==
---
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
(original)
+++
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
Mon Oct 6 09:15:08 2008
@@ -201,9 +201,7 @@
}
}
} finally {
-if (in != null) {
-in.close();
-}
+FileUtils.close(in);
}
return dependencyMap;
@@ -238,9 +236,7 @@
}
}
} finally {
-if (pw != null) {
-pw.close();
-}
+FileUtils.close(pw);
}
}
}
@@ -373,7 +369,9 @@
if (checkPath != null) {
// now determine which jars each class depends upon
classpathDependencies = new Hashtable();
-AntClassLoader loader = getProject().createClassLoader(checkPath);
+AntClassLoader loader = null;
+try {
+loader = getProject().createClassLoader(checkPath);
Hashtable classpathFileCache = new Hashtable();
Object nullFileMarker = new Object();
@@ -426,6 +424,11 @@
}
}
}
+} finally {
+if (loader != null) {
+loader.cleanup();
+}
+}
}
// write the dependency cache to the disk
Modified:
ant/core/trunk/src/tests/antunit/taskdefs/optional/depend/depend-test.xml
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/tests/antunit/taskdefs/optional/depend/depend-test.xml?rev=702188&r1=702187&r2=702188&view=diff
==
--- ant/core/trunk/src/tests/antunit/taskdefs/optional/depend/depend-test.xml
(original)
+++ ant/core/trunk/src/tests/antunit/taskdefs/optional/depend/depend-test.xml
Mon Oct 6 09:15:08 2008
@@ -61,6 +61,7 @@
+
DO NOT REPLY [Bug 45955] doesn't close JARs in classpath
https://issues.apache.org/bugzilla/show_bug.cgi?id=45955 Stefan Bodewig <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Target Milestone|--- |1.8.0 --- Comment #1 from Stefan Bodewig <[EMAIL PROTECTED]> 2008-10-06 09:15:20 PST --- svn revision 702189 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
svn commit: r702190 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
Author: bodewig
Date: Mon Oct 6 09:16:38 2008
New Revision: 702190
URL: http://svn.apache.org/viewvc?rev=702190&view=rev
Log:
whitespace
Modified:
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
Modified:
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java?rev=702190&r1=702189&r2=702190&view=diff
==
---
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
(original)
+++
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/depend/Depend.java
Mon Oct 6 09:16:38 2008
@@ -214,7 +214,7 @@
* @exception IOException if the dependency file cannot be written out.
*/
private void writeCachedDependencies(Hashtable dependencyMap)
- throws IOException {
+throws IOException {
if (cache != null) {
PrintWriter pw = null;
try {
@@ -229,7 +229,7 @@
pw.println(CLASSNAME_PREPEND + className);
Vector dependencyList
- = (Vector) dependencyMap.get(className);
+= (Vector) dependencyMap.get(className);
int size = dependencyList.size();
for (int x = 0; x < size; x++) {
pw.println(dependencyList.elementAt(x));
@@ -373,57 +373,57 @@
try {
loader = getProject().createClassLoader(checkPath);
-Hashtable classpathFileCache = new Hashtable();
-Object nullFileMarker = new Object();
-for (Enumeration e = dependencyMap.keys(); e.hasMoreElements();) {
-String className = (String) e.nextElement();
-Vector dependencyList = (Vector) dependencyMap.get(className);
-Hashtable dependencies = new Hashtable();
-classpathDependencies.put(className, dependencies);
-Enumeration e2 = dependencyList.elements();
-while (e2.hasMoreElements()) {
-String dependency = (String) e2.nextElement();
-Object classpathFileObject
-= classpathFileCache.get(dependency);
-if (classpathFileObject == null) {
-classpathFileObject = nullFileMarker;
-
-if (!dependency.startsWith("java.")
-&& !dependency.startsWith("javax.")) {
-URL classURL
-= loader.getResource(dependency.replace('.',
'/') + ".class");
-if (classURL != null) {
-if (classURL.getProtocol().equals("jar")) {
-String jarFilePath = classURL.getFile();
-int classMarker = jarFilePath.indexOf('!');
-jarFilePath = jarFilePath.substring(0,
classMarker);
-if (jarFilePath.startsWith("file:")) {
+Hashtable classpathFileCache = new Hashtable();
+Object nullFileMarker = new Object();
+for (Enumeration e = dependencyMap.keys();
e.hasMoreElements();) {
+String className = (String) e.nextElement();
+Vector dependencyList = (Vector)
dependencyMap.get(className);
+Hashtable dependencies = new Hashtable();
+classpathDependencies.put(className, dependencies);
+Enumeration e2 = dependencyList.elements();
+while (e2.hasMoreElements()) {
+String dependency = (String) e2.nextElement();
+Object classpathFileObject
+= classpathFileCache.get(dependency);
+if (classpathFileObject == null) {
+classpathFileObject = nullFileMarker;
+
+if (!dependency.startsWith("java.")
+&& !dependency.startsWith("javax.")) {
+URL classURL
+=
loader.getResource(dependency.replace('.', '/') + ".class");
+if (classURL != null) {
+if (classURL.getProtocol().equals("jar")) {
+String jarFilePath =
classURL.getFile();
+int classMarker =
jarFilePath.indexOf('!');
+jarFilePath = jarFilePath.substring(0,
classMarker);
+if (jarFilePath.startsWith("file:")) {
+classpathFileObj
DO NOT REPLY [Bug 45916] Depend task may remove (inner) classes without source files
https://issues.apache.org/bugzilla/show_bug.cgi?id=45916 Stefan Bodewig <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |ASSIGNED OS/Version|Linux |All Platform|PC |All --- Comment #2 from Stefan Bodewig <[EMAIL PROTECTED]> 2008-10-06 09:20:16 PST --- after fixing bug 45955 I can confirm that the problem doesn't show up on JDK 1.4.2, but this is because b.Main$1 doesn't seem to know that it depends on a.B at all. Am looking into fixing it for Java5+. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
DO NOT REPLY [Bug 45944] Bug using the file element as a nested element in the Copy task
https://issues.apache.org/bugzilla/show_bug.cgi?id=45944 --- Comment #3 from Stefan Bodewig <[EMAIL PROTECTED]> 2008-10-06 09:21:02 PST --- note that the example says flatten="true", so it is correct (but needs more explanations). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.
[jira] Commented: (IVY-761) The m2 parser doesn't recognize sources and javadocs
[ https://issues.apache.org/jira/browse/IVY-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637131#action_12637131 ] Simon Brunning commented on IVY-761: While this may be a duplicate, it doesn't appear to have been fixed. > The m2 parser doesn't recognize sources and javadocs > > > Key: IVY-761 > URL: https://issues.apache.org/jira/browse/IVY-761 > Project: Ivy > Issue Type: Improvement > Components: Maven Compatibility >Affects Versions: 2.0.0-beta-2 >Reporter: Nicolas Lalevée > > When using the ibibio resolver, the generated ivy.xml doesn't include source > and javadoc artifacts declaration. > AFAIU the Maven doc, the pom.xml doesn't declare them. They declare themself > by being available or not. > IvyDE does this check itself, so it works fine in Eclipse. So some code > should be ported from IvyDE to Ivy. Then we will be able to get the source > also with an ant task. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-936) CLONE -The m2 parser doesn't recognize sources and javadocs
[ https://issues.apache.org/jira/browse/IVY-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637132#action_12637132 ] Simon Brunning commented on IVY-936: Doesn't appear to have been fixed as of 2.0 rc-1. > CLONE -The m2 parser doesn't recognize sources and javadocs > --- > > Key: IVY-936 > URL: https://issues.apache.org/jira/browse/IVY-936 > Project: Ivy > Issue Type: Improvement > Components: Maven Compatibility >Affects Versions: 2.0.0-beta-2 >Reporter: Simon Brunning > > When using the ibibio resolver, the generated ivy.xml doesn't include source > and javadoc artifacts declaration. > AFAIU the Maven doc, the pom.xml doesn't declare them. They declare themself > by being available or not. > IvyDE does this check itself, so it works fine in Eclipse. So some code > should be ported from IvyDE to Ivy. Then we will be able to get the source > also with an ant task. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (IVY-936) CLONE -The m2 parser doesn't recognize sources and javadocs
CLONE -The m2 parser doesn't recognize sources and javadocs --- Key: IVY-936 URL: https://issues.apache.org/jira/browse/IVY-936 Project: Ivy Issue Type: Improvement Components: Maven Compatibility Affects Versions: 2.0.0-beta-2 Reporter: Simon Brunning When using the ibibio resolver, the generated ivy.xml doesn't include source and javadoc artifacts declaration. AFAIU the Maven doc, the pom.xml doesn't declare them. They declare themself by being available or not. IvyDE does this check itself, so it works fine in Eclipse. So some code should be ported from IvyDE to Ivy. Then we will be able to get the source also with an ant task. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-936) Can't use latest.release for pom dependencies
[ https://issues.apache.org/jira/browse/IVY-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maarten Coene updated IVY-936: -- Affects Version/s: (was: 2.0.0-beta-2) 2.0-RC1 Assignee: Maarten Coene Summary: Can't use latest.release for pom dependencies (was: CLONE -The m2 parser doesn't recognize sources and javadocs) > Can't use latest.release for pom dependencies > - > > Key: IVY-936 > URL: https://issues.apache.org/jira/browse/IVY-936 > Project: Ivy > Issue Type: Improvement > Components: Maven Compatibility >Affects Versions: 2.0-RC1 >Reporter: Simon Brunning >Assignee: Maarten Coene > > When using the ibibio resolver, the generated ivy.xml doesn't include source > and javadoc artifacts declaration. > AFAIU the Maven doc, the pom.xml doesn't declare them. They declare themself > by being available or not. > IvyDE does this check itself, so it works fine in Eclipse. So some code > should be ported from IvyDE to Ivy. Then we will be able to get the source > also with an ant task. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-936) Can't use latest.release for pom dependencies
[ https://issues.apache.org/jira/browse/IVY-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637215#action_12637215 ] Maarten Coene commented on IVY-936: --- I've updated the title to the real problem... The problem occurred with the following dependency: > Can't use latest.release for pom dependencies > - > > Key: IVY-936 > URL: https://issues.apache.org/jira/browse/IVY-936 > Project: Ivy > Issue Type: Improvement > Components: Maven Compatibility >Affects Versions: 2.0-RC1 >Reporter: Simon Brunning >Assignee: Maarten Coene > > When using the ibibio resolver, the generated ivy.xml doesn't include source > and javadoc artifacts declaration. > AFAIU the Maven doc, the pom.xml doesn't declare them. They declare themself > by being available or not. > IvyDE does this check itself, so it works fine in Eclipse. So some code > should be ported from IvyDE to Ivy. Then we will be able to get the source > also with an ant task. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-936) Can't use latest.release for pom dependencies
[ https://issues.apache.org/jira/browse/IVY-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637216#action_12637216 ] Maarten Coene commented on IVY-936: --- workaround: use "latest.integration" > Can't use latest.release for pom dependencies > - > > Key: IVY-936 > URL: https://issues.apache.org/jira/browse/IVY-936 > Project: Ivy > Issue Type: Improvement > Components: Maven Compatibility >Affects Versions: 2.0-RC1 >Reporter: Simon Brunning >Assignee: Maarten Coene > > When using the ibibio resolver, the generated ivy.xml doesn't include source > and javadoc artifacts declaration. > AFAIU the Maven doc, the pom.xml doesn't declare them. They declare themself > by being available or not. > IvyDE does this check itself, so it works fine in Eclipse. So some code > should be ported from IvyDE to Ivy. Then we will be able to get the source > also with an ant task. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
svn commit: r702262 - in /ant/ivy/core/trunk: CHANGES.txt src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
Author: maartenc
Date: Mon Oct 6 14:02:33 2008
New Revision: 702262
URL: http://svn.apache.org/viewvc?rev=702262&view=rev
Log:
FIX: Can't use latest.release for pom dependencies (IVY-936)
Modified:
ant/ivy/core/trunk/CHANGES.txt
ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
Modified: ant/ivy/core/trunk/CHANGES.txt
URL:
http://svn.apache.org/viewvc/ant/ivy/core/trunk/CHANGES.txt?rev=702262&r1=702261&r2=702262&view=diff
==
--- ant/ivy/core/trunk/CHANGES.txt (original)
+++ ant/ivy/core/trunk/CHANGES.txt Mon Oct 6 14:02:33 2008
@@ -101,6 +101,7 @@
- FIX: Can't download files containing space or + in their names by HTTP
(IVY-923)
- FIX: Maven2 parser doesn't support POMs with as root (IVY-932)
- FIX: Default retrieve, publish and deliver patterns doesn't include the
[classifier] token (IVY-935)
+- FIX: Can't use latest.release for pom dependencies (IVY-936)
2.0.0-rc1
=
Modified:
ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
URL:
http://svn.apache.org/viewvc/ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java?rev=702262&r1=702261&r2=702262&view=diff
==
---
ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
(original)
+++
ant/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/m2/PomModuleDescriptorBuilder.java
Mon Oct 6 14:02:33 2008
@@ -215,6 +215,12 @@
public void setModuleRevId(String groupId, String artifactId, String
version) {
mrid = ModuleRevisionId.newInstance(groupId, artifactId, version);
ivyModuleDescriptor.setModuleRevisionId(mrid);
+
+if ((version == null) || version.endsWith("SNAPSHOT")) {
+ivyModuleDescriptor.setStatus("integration");
+} else {
+ivyModuleDescriptor.setStatus("release");
+}
}
public void setHomePage(String homePage) {
[jira] Resolved: (IVY-934) ivy:buildnumber Task can cause ivy:resolve to 'hang' forever
[
https://issues.apache.org/jira/browse/IVY-934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maarten Coene resolved IVY-934.
---
Resolution: Duplicate
ok, I'll mark this issue as duplicate of IVY-930
> ivy:buildnumber Task can cause ivy:resolve to 'hang' forever
>
>
> Key: IVY-934
> URL: https://issues.apache.org/jira/browse/IVY-934
> Project: Ivy
> Issue Type: Bug
>Affects Versions: 2.0-RC1
> Environment: fedora-core 9, jdk1.6..11, ant 1.7.0
>Reporter: Hans Lund
>
> if the ivy:buildnumber ant task fails (when a module has not been published
> -yet ) later ivy:resolve ant tasks that do not have an explicit revision
> hangs forever.
> preconditions: resolving over http to single repository.
> Steps to reproduce:
> ivy.xml with some dependencies like:
>
> conf="test->default"/>
> conf="default->default" />
>
> buildfile with:
>
>module="bug" />
>
>
>
>
>
>
> pattern="${ivy.lib.dir}/[artifact].[ext]"/>
>
> now ant - verbose ivy-buildnumber-resolve-bug gives to following stacktrace:
> [ivy:resolve] using ivy parser to parse file:/home/halu/IvyBug/ivy.xml
> [ivy:resolve] :: resolving dependencies :: org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED]
> [ivy:resolve] confs: [default, master, compile, provided, runtime,
> test, system, optional]
> [ivy:resolve] validate = true
> [ivy:resolve] refresh = false
> [ivy:resolve] resolving dependencies for configuration 'default'
> [ivy:resolve] == resolving dependencies for org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED] [default]
> [ivy:resolve] == resolving dependencies for org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED] [runtime]
> [ivy:resolve] == resolving dependencies for org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED] [compile]
> [ivy:resolve] == resolving dependencies for org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED] [master]
> [ivy:resolve] == resolving dependencies org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED]>org.mortbay.jetty#jetty;6.+ [default->default]
> [ivy:resolve] : Checking cache for: dependency: org.mortbay.jetty#jetty;6.+
> {default=[default]}
> [ivy:resolve] no cached resolved revision for org.mortbay.jetty#jetty;6.+
> [ivy:resolve] no cached resolved revision for org.mortbay.jetty#jetty;6.+
> [ivy:resolve] tried
> http://localhost/repository/org.mortbay.jetty/jetty/ivys/ivy-[revision].xml
> freeze ... +c
> C[ivy:resolve] WARN: problem while listing resources in
> http://localhost/repository/org.mortbay.jetty/jetty/ivys with local-repo:
> [ivy:resolve] WARN: java.lang.IllegalStateException Connection factory has
> been shutdown.
> [ivy:resolve] tried
> http://localhost/repository/org.mortbay.jetty/jetty/jars/jetty-[revision].jar
> [ivy:resolve] WARN: problem while listing resources in
> http://hudson.msrd.multi-support.com/repository/org.mortbay.jetty/jetty/jars
> with local-repo:
> [ivy:resolve] WARN: java.lang.IllegalStateException Connection factory has
> been shutdown.
> [ivy:resolve] Multisupport-IvyRepository: no ivy file nor artifact
> found for org.mortbay.jetty#jetty;6.+
> [ivy:resolve] WARN: module not found: org.mortbay.jetty#jetty;6.+
> [ivy:resolve] WARN: local-repo: tried
> [ivy:resolve] WARN:
> http://localhost/repository/org.mortbay.jetty/jetty/ivys/ivy-[revision].xml
> [ivy:resolve] WARN: -- artifact org.mortbay.jetty#jetty;6.+!jetty.jar:
> [ivy:resolve] WARN:
> http://localhost/repository/org.mortbay.jetty/jetty/jars/jetty-[revision].jar
> [ivy:resolve] resolving dependencies for configuration 'master'
> [ivy:resolve] == resolving dependencies for org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED] [master]
> [ivy:resolve] resolving dependencies for configuration 'compile'
> [ivy:resolve] == resolving dependencies for org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED] [compile]
> [ivy:resolve] resolving dependencies for configuration 'provided'
> [ivy:resolve] == resolving dependencies for org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED] [provided]
> [ivy:resolve] resolving dependencies for configuration 'runtime'
> [ivy:resolve] == resolving dependencies for org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED] [runtime]
> [ivy:resolve] == resolving dependencies for org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED] [compile]
> [ivy:resolve] resolving dependencies for configuration 'test'
> [ivy:resolve] == resolving dependencies for org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED] [test]
> [ivy:resolve] == resolving dependencies org.bug#ivybuildnumberbug;[EMAIL
> PROTECTED]>junit#junit;3.8.2 [test->default]
> [ivy:resolve] : Checking cache for: dependency: junit#junit;3.8.2
> {test=[default]}
--
This message is automatically gene
[jira] Updated: (IVY-936) Can't use latest.release for pom dependencies
[ https://issues.apache.org/jira/browse/IVY-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maarten Coene updated IVY-936: -- Issue Type: Bug (was: Improvement) > Can't use latest.release for pom dependencies > - > > Key: IVY-936 > URL: https://issues.apache.org/jira/browse/IVY-936 > Project: Ivy > Issue Type: Bug > Components: Maven Compatibility >Affects Versions: 2.0-RC1 >Reporter: Simon Brunning >Assignee: Maarten Coene > Fix For: trunk > > > When using the ibibio resolver, the generated ivy.xml doesn't include source > and javadoc artifacts declaration. > AFAIU the Maven doc, the pom.xml doesn't declare them. They declare themself > by being available or not. > IvyDE does this check itself, so it works fine in Eclipse. So some code > should be ported from IvyDE to Ivy. Then we will be able to get the source > also with an ant task. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (IVY-936) Can't use latest.release for pom dependencies
[ https://issues.apache.org/jira/browse/IVY-936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maarten Coene resolved IVY-936. --- Resolution: Fixed Fix Version/s: trunk I've fixed your problem in SVN trunk. Could you give it a try with trunk version of latest snapshot from http://teamcity.jetbrains.com/viewLog.html?&buildTypeId=bt125&buildId=lastSuccessful ? > Can't use latest.release for pom dependencies > - > > Key: IVY-936 > URL: https://issues.apache.org/jira/browse/IVY-936 > Project: Ivy > Issue Type: Improvement > Components: Maven Compatibility >Affects Versions: 2.0-RC1 >Reporter: Simon Brunning >Assignee: Maarten Coene > Fix For: trunk > > > When using the ibibio resolver, the generated ivy.xml doesn't include source > and javadoc artifacts declaration. > AFAIU the Maven doc, the pom.xml doesn't declare them. They declare themself > by being available or not. > IvyDE does this check itself, so it works fine in Eclipse. So some code > should be ported from IvyDE to Ivy. Then we will be able to get the source > also with an ant task. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-881) Ivy incorrectly searches for an artifact if it contains / in the name
[
https://issues.apache.org/jira/browse/IVY-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637247#action_12637247
]
Maarten Coene commented on IVY-881:
---
Could you try the following as workaround:
{noformat}
{noformat}
> Ivy incorrectly searches for an artifact if it contains / in the name
> -
>
> Key: IVY-881
> URL: https://issues.apache.org/jira/browse/IVY-881
> Project: Ivy
> Issue Type: Bug
> Components: Core
>Reporter: Pavel Sher
>Assignee: Xavier Hanin
>
> Yesterday (2008-Aug-11) I've build Ivy from the sources and found that Ivy
> cannot download artifact with / in its name. It seems the bug can be
> reproduced on windows only.
> I have the following ivy.xml:
>
>
>
>
>
>matcher="glob" />
>
>
>
> I tried to debug Ivy source code, and it looks like the problem is somewhere
> near this code (IvyNode.java):
> 789: Map allArtifacts = new HashMap();
> for (int i = 0; i < confs.length; i++) {
> Artifact[] arts = md.getArtifacts(confs[i]);
> for (int j = 0; j < arts.length; j++) {
> allArtifacts.put(arts[j].getId().getArtifactId(),
> arts[j]);
> }
> }
> The produced Map of all artifacts contains dir\path-to-artifact instead of
> dir/path-to-artifact. And because of this matcher cannot find the required
> artifact. In Ivy-2.0-beta2 such artifacts were downloaded without problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
svn commit: r702350 - in /ant/core/trunk/src: main/org/apache/tools/ant/ main/org/apache/tools/ant/taskdefs/ main/org/apache/tools/ant/taskdefs/optional/unix/ main/org/apache/tools/ant/types/selectors
Author: bodewig
Date: Mon Oct 6 22:35:58 2008
New Revision: 702350
URL: http://svn.apache.org/viewvc?rev=702350&view=rev
Log:
factor out symlink methods into a separate utils class
Added:
ant/core/trunk/src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java
(with props)
Modified:
ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Delete.java
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
ant/core/trunk/src/main/org/apache/tools/ant/types/selectors/TokenizedPath.java
ant/core/trunk/src/main/org/apache/tools/ant/util/FileUtils.java
ant/core/trunk/src/tests/junit/org/apache/tools/ant/DirectoryScannerTest.java
ant/core/trunk/src/tests/junit/org/apache/tools/ant/taskdefs/optional/unix/SymlinkTest.java
Modified: ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java?rev=702350&r1=702349&r2=702350&view=diff
==
--- ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java
(original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/DirectoryScanner.java Mon Oct
6 22:35:58 2008
@@ -42,6 +42,7 @@
import org.apache.tools.ant.types.selectors.TokenizedPattern;
import org.apache.tools.ant.util.CollectionUtils;
import org.apache.tools.ant.util.FileUtils;
+import org.apache.tools.ant.util.SymbolicLinkUtils;
import org.apache.tools.ant.util.VectorSet;
/**
@@ -187,6 +188,10 @@
/** Helper. */
private static final FileUtils FILE_UTILS = FileUtils.getFileUtils();
+/** Helper. */
+private static final SymbolicLinkUtils SYMLINK_UTILS =
+SymbolicLinkUtils.getSymbolicLinkUtils();
+
/**
* Patterns which should be excluded by default.
*
@@ -821,8 +826,7 @@
excludes = nullExcludes ? new String[0] : excludes;
if (basedir != null && !followSymlinks
-&& FILE_UTILS.isSymbolicLink(basedir.getParentFile(),
- basedir.getName())) {
+&& SYMLINK_UTILS.isSymbolicLink(basedir)) {
basedir = null;
}
@@ -1178,7 +1182,7 @@
ArrayList noLinks = new ArrayList();
for (int i = 0; i < newfiles.length; i++) {
try {
-if (FILE_UTILS.isSymbolicLink(dir, newfiles[i])) {
+if (SYMLINK_UTILS.isSymbolicLink(dir, newfiles[i])) {
String name = vpath + newfiles[i];
File file = new File(dir, newfiles[i]);
(file.isDirectory()
@@ -1788,7 +1792,7 @@
if (directoryNamesFollowed.size() >= maxLevelsOfSymlinks
&& CollectionUtils.frequency(directoryNamesFollowed, dirName)
>= maxLevelsOfSymlinks
-&& FILE_UTILS.isSymbolicLink(parent, dirName)) {
+&& SYMLINK_UTILS.isSymbolicLink(parent, dirName)) {
ArrayList files = new ArrayList();
File f = FILE_UTILS.resolveFile(parent, dirName);
Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Delete.java
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Delete.java?rev=702350&r1=702349&r2=702350&view=diff
==
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Delete.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Delete.java Mon Oct
6 22:35:58 2008
@@ -57,7 +57,7 @@
import org.apache.tools.ant.types.selectors.MajoritySelector;
import org.apache.tools.ant.types.selectors.ContainsRegexpSelector;
import org.apache.tools.ant.types.selectors.modifiedselector.ModifiedSelector;
-import org.apache.tools.ant.util.FileUtils;
+import org.apache.tools.ant.util.SymbolicLinkUtils;
/**
* Deletes a file or directory, or set of files defined by a fileset.
@@ -107,14 +107,15 @@
protected boolean usedMatchingTask = false;
// by default, remove matching empty dirs
protected boolean includeEmpty = false;
+// CheckStyle:VisibilityModifier ON
private int verbosity = Project.MSG_VERBOSE;
private boolean quiet = false;
private boolean failonerror = true;
private boolean deleteOnExit = false;
private Resources rcs = null;
-private static FileUtils FILE_UTILS = FileUtils.getFileUtils();
-// CheckStyle:VisibilityModifier ON
+private static SymbolicLinkUtils SYMLINK_UTILS =
+SymbolicLinkUtils.getSymbolicLinkUtils();
/**
* Set the name of a single file to be removed.
@@ -760,8 +761,7 @@
private boolean isDanglingSymlink(File f) {
try {
-return FILE_UTILS.isDanglingSymbol
