date:20200619

[GitHub] [incubator-apisix] membphis commented on issue #1736: request help: stream_proxy the parameters of the proxy

2020-06-19 Thread GitBox



membphis commented on issue #1736:
URL: 
https://github.com/apache/incubator-apisix/issues/1736#issuecomment-646477523


   we should support this feature, welcome PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] moonming commented on issue #1737: bug: limit-count plugin threshold is not exceeded, but the request is limited

2020-06-19 Thread GitBox



moonming commented on issue #1737:
URL: 
https://github.com/apache/incubator-apisix/issues/1737#issuecomment-646482232


   @Donghui0 can not reproduced in my side.  
   Can you provide reproduction steps?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] FunnySunshine520 opened a new issue #1738: bug: Without directory /tmp/apisix_cores, the system will not work

2020-06-19 Thread GitBox



FunnySunshine520 opened a new issue #1738:
URL: https://github.com/apache/incubator-apisix/issues/1738


   ### Issue description
   if directory /tmp/apisix_cores does not exist and use "make reload" to 
reload the system. Then this system is not working properly
   
   ### Environment
   * OS
   
   ### Minimal test code / Steps to reproduce the issue
   1. Delete catalog /tmp/apisix_cores
   2. Execute command: make reload
   
   ### What's the actual result? (including assertion message & call stack if 
applicable)
   the system is not working properly
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] shibingli commented on a change in pull request #1659: [bugfix] Create service support string type ID. Fix #1654

2020-06-19 Thread GitBox



shibingli commented on a change in pull request #1659:
URL: https://github.com/apache/incubator-apisix/pull/1659#discussion_r442698816



##
File path: t/admin/services.t
##
@@ -26,12 +26,12 @@ run_tests;
 
 __DATA__
 
-=== TEST 1: set service(id: 1)
+=== TEST 1: set service(id: 5eeb3dc90f747328b2930b0b)

Review comment:
   Add t/admin/services-string-id.t
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix-docker] lingsamuel opened a new issue #59: gcr.azk8s.cn no longer public

2020-06-19 Thread GitBox



lingsamuel opened a new issue #59:
URL: https://github.com/apache/incubator-apisix-docker/issues/59


   Reference: 
https://github.com/Azure/container-service-for-azure-china/issues/58#issuecomment-630765201



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[incubator-apisix-website] 01/01: add translate doc.

2020-06-19 Thread wenming

This is an automated email from the ASF dual-hosted git repository.

wenming pushed a commit to branch release-english
in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git

commit 7fc05fc2255a304c797ac5ab91029c301678cf9d
Author: WenMing 
AuthorDate: Fri Jun 19 16:26:15 2020 +0800

add translate doc.
---
 content/contribute/release/index.en.md | 128 -
 content/contribute/release/index.zh.md |  14 ++--
 2 files changed, 68 insertions(+), 74 deletions(-)

diff --git a/content/contribute/release/index.en.md 
b/content/contribute/release/index.en.md
index fa1f66d..4020900 100644
--- a/content/contribute/release/index.en.md
+++ b/content/contribute/release/index.en.md
@@ -6,56 +6,55 @@ include_footer: true
 
 
   
-GPG 设置
+GPG Settings
 
-安装 GPG
-在 GnuPG 官网下载安装包。 GnuPG 的 1.x 版本和 2.x 版本的命令有细微差别，下列说明以 GnuPG-2.1.23 
版本为例。
-安装完成后，执行以下命令查看版本号。
+Install GPG
+Download GnuPG from https://gnupg.org/download/index.html. There are 
differences between the 1.x and 2.x versions of the GnuPG commands, and the 
following descriptions are based on the GnuPG 2.x versions.
+After the installation is complete, execute the following command to 
check the version.
 {{< highlight go "linenos=table" >}}
 gpg --version
 {{< / highlight >}}
-创建 Key
-安装完成后，执行以下命令创建key。
-GnuPG-2.x可使用：
+Create Key
+Execute the following command to create the key:
+GnuPG-2.x：
 {{< highlight go "linenos=table" >}}
 gpg --full-gen-key
 {{< / highlight >}}
-GnuPG-1.x可使用：
+GnuPG-1.x：
 {{< highlight go "linenos=table" >}}
 gpg --gen-key
 {{< / highlight >}}
-根据提示完成key：
-注意：请使用Apache mail生成GPG的Key。
+Follow the instructions to generate key：
+Note: Please use Apache email address to generate the 
GPG Key.
 {{< highlight go "linenos=table" >}}
 {{% contribute/release/gpg-key-generator %}}
 {{< / highlight >}}
-查看生成的key
+View the generated key:
 {{< highlight go "linenos=table" >}}
 gpg --list-keys
 {{< / highlight >}}
-执行结果：
+The example result：
 {{< highlight go "linenos=table" >}}
-// 笔者本地电脑
 $ gpg --list-keys
 /home/resty/.gnupg/pubring.gpg
 --
-pub   4096R/30B5FD72 2020-01-02  
+pub   4096R/30B5FD72 2020-01-02
 uid   Yuansheng Wang 
 sub   4096R/3D2F913D 2020-01-02
 {{< / highlight >}}
-其中 30B5FD72 为公钥 ID。
-将公钥同步到服务器
-命令如下：
+And `30B5FD72` is the ID of pub key
+Synchronizing the public key to the server
+The steps are as follows:
 {{< highlight go "linenos=table" >}}
-// 最后参数是上面生成的公钥 ID。
+// The last parameter is the public key ID generated above
 $ gpg --keyserver hkp://pool.sks-keyservers.net --send-key 30B5FD72
 gpg: sending key 30B5FD72 to hkp server pool.sks-keyservers.net
 {{< / highlight >}}
-pool.sks-keyservers.net为随意挑选的https://sks-keyservers.net/status/"; 
target="_blank">公钥服务器，每个服务器之间是自动同步的，选任意一个即可。
-id.apache.org 中录入 Key Fingerprint
-获取 Key Fingerprint
+pool.sks-keyservers.net is one of https://sks-keyservers.net/status/"; target="_blank">pub key 
servers,the pub key will be automatically synchronized between each server, 
just choose any one.
+Add `Key Fingerprint` to id.apache.org 
+get Key Fingerprint
 {{< highlight go "linenos=table" >}}
-# 注意下方 Key fingerprint 部分
+# Note the `Key fingerprint` section below.
 $ gpg --list-keys --fingerprint
 /home/resty/.gnupg/pubring.gpg
 --
@@ -64,65 +63,60 @@ include_footer: true
 uid  Yuansheng Wang 
 sub   4096R/3D2F913D 2020-01-02
 {{< / highlight >}}
-登录 id.apache.org 填写 Key Fingerprint
-点击左下角的 Submit changes... 按钮提交保存。
-Apache svn 中添加自己的 GPG 公钥
-下载 svn 目录
+Login id.apache.org and submit Key Fingerprint
+Add your GPG key to Apache svn
+download APISIX svn
 {{< highlight go "linenos=table" >}}
-$ svn --username=${Apache 用户名} co 
https://dist.apache.org/repos/dist/dev/incubator/apisix
+$ svn --username=${Apache username} co 
https://dist.apache.org/repos/dist/dev/incubator/apisix
 {{< / highlight >}}
-进入 apisix 目录并查看其中文件:
 {{< highlight go "linenos=table" >}}
-$ cd apisix 
+$ cd apisix
 $ ls
 KEYS
 {{< / highlight >}}
-导出公钥到追加到 KEYS 文件：
+Export the public key and append to the KEYS file.
 {{< highlight go "linenos=table" >}}
-$ gpg -a --export ${GPG用户名}  >> KEYS
+$ gpg -a --export ${GPG username}  >> KEYS
 {{< / highlight >}}
-提交修改后的 KEYS 文件，把公钥信息保存到 svn 服务器：
+Commit the modified KEYS file, saving the public key to the svn 
server.
 {{< highlight go "linenos=table" >}}
-$ svn --username=${Apache 用户名} commit -m "added ${Apache 邮箱} gpg pub key"
+$ svn --username=${Apache username} commit -m "added ${Apache email} gpg 
pub key"
 Authentication realm:

[incubator-apisix-website] branch release-english created (now 7fc05fc)

2020-06-19 Thread wenming

This is an automated email from the ASF dual-hosted git repository.

wenming pushed a change to branch release-english
in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git.


  at 7fc05fc  add translate doc.

This branch includes the following new commits:

 new 7fc05fc  add translate doc.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[GitHub] [incubator-apisix-website] moonming opened a new pull request #49: doc: add translate doc for release guide.

2020-06-19 Thread GitBox



moonming opened a new pull request #49:
URL: https://github.com/apache/incubator-apisix-website/pull/49


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix-website] juzhiyuan merged pull request #49: doc: add translate doc for release guide.

2020-06-19 Thread GitBox



juzhiyuan merged pull request #49:
URL: https://github.com/apache/incubator-apisix-website/pull/49


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[incubator-apisix-website] branch master updated: add translate doc. (#49)

2020-06-19 Thread juzhiyuan

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git


The following commit(s) were added to refs/heads/master by this push:
 new 2fcfa30  add translate doc. (#49)
2fcfa30 is described below

commit 2fcfa302fae06729bcf336315628c6eb8dc5a963
Author: Wen Ming 
AuthorDate: Fri Jun 19 16:29:50 2020 +0800

add translate doc. (#49)
---
 content/contribute/release/index.en.md | 128 -
 content/contribute/release/index.zh.md |  14 ++--
 2 files changed, 68 insertions(+), 74 deletions(-)

diff --git a/content/contribute/release/index.en.md 
b/content/contribute/release/index.en.md
index fa1f66d..4020900 100644
--- a/content/contribute/release/index.en.md
+++ b/content/contribute/release/index.en.md
@@ -6,56 +6,55 @@ include_footer: true
 
 
   
-GPG 设置
+GPG Settings
 
-安装 GPG
-在 GnuPG 官网下载安装包。 GnuPG 的 1.x 版本和 2.x 版本的命令有细微差别，下列说明以 GnuPG-2.1.23 
版本为例。
-安装完成后，执行以下命令查看版本号。
+Install GPG
+Download GnuPG from https://gnupg.org/download/index.html. There are 
differences between the 1.x and 2.x versions of the GnuPG commands, and the 
following descriptions are based on the GnuPG 2.x versions.
+After the installation is complete, execute the following command to 
check the version.
 {{< highlight go "linenos=table" >}}
 gpg --version
 {{< / highlight >}}
-创建 Key
-安装完成后，执行以下命令创建key。
-GnuPG-2.x可使用：
+Create Key
+Execute the following command to create the key:
+GnuPG-2.x：
 {{< highlight go "linenos=table" >}}
 gpg --full-gen-key
 {{< / highlight >}}
-GnuPG-1.x可使用：
+GnuPG-1.x：
 {{< highlight go "linenos=table" >}}
 gpg --gen-key
 {{< / highlight >}}
-根据提示完成key：
-注意：请使用Apache mail生成GPG的Key。
+Follow the instructions to generate key：
+Note: Please use Apache email address to generate the 
GPG Key.
 {{< highlight go "linenos=table" >}}
 {{% contribute/release/gpg-key-generator %}}
 {{< / highlight >}}
-查看生成的key
+View the generated key:
 {{< highlight go "linenos=table" >}}
 gpg --list-keys
 {{< / highlight >}}
-执行结果：
+The example result：
 {{< highlight go "linenos=table" >}}
-// 笔者本地电脑
 $ gpg --list-keys
 /home/resty/.gnupg/pubring.gpg
 --
-pub   4096R/30B5FD72 2020-01-02  
+pub   4096R/30B5FD72 2020-01-02
 uid   Yuansheng Wang 
 sub   4096R/3D2F913D 2020-01-02
 {{< / highlight >}}
-其中 30B5FD72 为公钥 ID。
-将公钥同步到服务器
-命令如下：
+And `30B5FD72` is the ID of pub key
+Synchronizing the public key to the server
+The steps are as follows:
 {{< highlight go "linenos=table" >}}
-// 最后参数是上面生成的公钥 ID。
+// The last parameter is the public key ID generated above
 $ gpg --keyserver hkp://pool.sks-keyservers.net --send-key 30B5FD72
 gpg: sending key 30B5FD72 to hkp server pool.sks-keyservers.net
 {{< / highlight >}}
-pool.sks-keyservers.net为随意挑选的https://sks-keyservers.net/status/"; 
target="_blank">公钥服务器，每个服务器之间是自动同步的，选任意一个即可。
-id.apache.org 中录入 Key Fingerprint
-获取 Key Fingerprint
+pool.sks-keyservers.net is one of https://sks-keyservers.net/status/"; target="_blank">pub key 
servers,the pub key will be automatically synchronized between each server, 
just choose any one.
+Add `Key Fingerprint` to id.apache.org 
+get Key Fingerprint
 {{< highlight go "linenos=table" >}}
-# 注意下方 Key fingerprint 部分
+# Note the `Key fingerprint` section below.
 $ gpg --list-keys --fingerprint
 /home/resty/.gnupg/pubring.gpg
 --
@@ -64,65 +63,60 @@ include_footer: true
 uid  Yuansheng Wang 
 sub   4096R/3D2F913D 2020-01-02
 {{< / highlight >}}
-登录 id.apache.org 填写 Key Fingerprint
-点击左下角的 Submit changes... 按钮提交保存。
-Apache svn 中添加自己的 GPG 公钥
-下载 svn 目录
+Login id.apache.org and submit Key Fingerprint
+Add your GPG key to Apache svn
+download APISIX svn
 {{< highlight go "linenos=table" >}}
-$ svn --username=${Apache 用户名} co 
https://dist.apache.org/repos/dist/dev/incubator/apisix
+$ svn --username=${Apache username} co 
https://dist.apache.org/repos/dist/dev/incubator/apisix
 {{< / highlight >}}
-进入 apisix 目录并查看其中文件:
 {{< highlight go "linenos=table" >}}
-$ cd apisix 
+$ cd apisix
 $ ls
 KEYS
 {{< / highlight >}}
-导出公钥到追加到 KEYS 文件：
+Export the public key and append to the KEYS file.
 {{< highlight go "linenos=table" >}}
-$ gpg -a --export ${GPG用户名}  >> KEYS
+$ gpg -a --export ${GPG username}  >> KEYS
 {{< / highlight >}}
-提交修改后的 KEYS 文件，把公钥信息保存到 svn 服务器：
+Commit the modified KEYS file, saving the public key to the svn 
server.
 {{< highlight go "linenos=table" >}}
-$ svn --username=${Apache 用户名} commit -m "added ${Apa

[incubator-apisix-website] branch asf-site updated: Deploy to GitHub pages

2020-06-19 Thread github-bot

This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new d75f531  Deploy to GitHub pages
d75f531 is described below

commit d75f531945e9c4ab34dd66c2fc9bbad009b32f6c
Author: github-actions[bot] 
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Fri Jun 19 08:30:09 2020 +

Deploy to GitHub pages
---
 contribute/index.xml |  13 ++--
 contribute/release/index.html| 147 ++-
 index.xml|  13 ++--
 zh/contribute/release/index.html |  12 ++--
 4 files changed, 82 insertions(+), 103 deletions(-)

diff --git a/contribute/index.xml b/contribute/index.xml
index 6532df2..5205762 100644
--- a/contribute/index.xml
+++ b/contribute/index.xml
@@ -77,14 +77,11 @@ If you have apprehensions regarding APISIX’s security or 
you discover vulnerab
   Tue, 07 Jan 2020 11:46:04 +0800
   
   https://apisix.incubator.apache.org/contribute/release/
-  GPG 设置 安装 GPG 在 GnuPG 官网下载安装包。 GnuPG 的 1.x 版本和 2.x 
版本的命令有细微差别，下列说明以 GnuPG-2.1.23 版本为例。
-安装完成后，执行以下命令查看版本号。
-1 2  gpg --version创建 Key 安装完成后，执行以下命令创建key。
-GnuPG-2.x可使用：
-1 2  gpg --full-gen-keyGnuPG-1.x可使用：
-1 2  gpg --gen-key根据提示完成key：
-注意：请使用Apache mail生成GPG的Key。
-1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 
30 31 32 33 34  gpg (GnuPG) 2.
+  GPG Settings Install GPG Download GnuPG from 
https://gnupg.org/download/index.html. There are differences between the 1.x 
and 2.x versions of the GnuPG commands, and the following descriptions are 
based on the GnuPG 2.x versions.
+After the installation is complete, execute the following command to check the 
version.
+1 2  gpg --versionCreate Key Execute the following command to create the 
key:
+GnuPG-2.x：
+1 2  gpg --full-gen-keyGnuPG-1.
 
 
   
diff --git a/contribute/release/index.html b/contribute/release/index.html
index deb07fd..00b7cb8 100644
--- a/contribute/release/index.html
+++ b/contribute/release/index.html
@@ -4,14 +4,11 @@
 
 
 
-
+https://gnupg.org/download/index.html. There are differences between 
the 1.x and 2.x versions of the GnuPG commands, and the following descriptions 
are based on the GnuPG 2.x versions.
+After the installation is complete, execute the following command to check the 
version.
+1 2  gpg --versionCreate Key Execute the following command to create the 
key:
+GnuPG-2.x：
+1 2  gpg --full-gen-keyGnuPG-1." />
 
 https://apisix.incubator.apache.org/contribute/release/"; />
 
@@ -233,11 +230,11 @@ GnuPG-2.x可使用：
 
 
   
-GPG 设置
+GPG Settings
 
-安装 GPG
-在 GnuPG 官网下载安装包。 GnuPG 的 1.x 版本和 2.x 版本的命令有细微差别，下列说明以 GnuPG-2.1.23 
版本为例。
-安装完成后，执行以下命令查看版本号。
+Install GPG
+Download GnuPG from https://gnupg.org/download/index.html. There are 
differences between the 1.x and 2.x versions of the GnuPG commands, and the 
following descriptions are based on the GnuPG 2.x versions.
+After the installation is complete, execute the following command to 
check the version.
 
 
 1
@@ -248,9 +245,9 @@ GnuPG-2.x可使用：
 
 
 
-创建 Key
-安装完成后，执行以下命令创建key。
-GnuPG-2.x可使用：
+Create Key
+Execute the following command to create the key:
+GnuPG-2.x：
 
 
 1
@@ -261,7 +258,7 @@ GnuPG-2.x可使用：
 
 
 
-GnuPG-1.x可使用：
+GnuPG-1.x：
 
 
 1
@@ -272,8 +269,8 @@ GnuPG-2.x可使用：
 
 
 
-根据提示完成key：
-注意：请使用Apache mail生成GPG的Key。
+Follow the instructions to generate key：
+Note: Please use Apache email address to generate the 
GPG Key.
 
 
  1
@@ -348,7 +345,7 @@ GnuPG-2.x可使用：
 
 
 
-查看生成的key
+View the generated key:
 
 
 1
@@ -359,7 +356,7 @@ GnuPG-2.x可使用：
 
 
 
-执行结果：
+The example result：
 
 
 1
@@ -369,22 +366,20 @@ GnuPG-2.x可使用：
 5
 6
 7
-8
 
 
-// 笔者本地电脑
-$ gpg --list-keys
+$ gpg --list-keys
 /home/resty/.gnupg/pubring.gpg
 --
-pub   4096R/30B5FD72 2020-01-02  
+pub   4096R/30B5FD72 2020-01-02
 uid   Yuansheng Wang 

 sub   4096R/3D2F913D 2020-01-02
 
 
 
-其中 30B5FD72 为公钥 ID。
-将公钥同步到服务器
-命令如下：
+And `30B5FD72` is the ID of pub key
+Synchronizing the public key to the server
+The steps are as follows:
 
 
 1
@@ -393,15 +388,15 @@ GnuPG-2.x可使用：
 4
 
 
-// 
最后参数是上面生成的公钥 ID。
+// The last 
parameter is the public key ID generated above
 $ gpg --keyserver hkp://pool.sks-keyservers.net --send-key 30B5FD72
 gpg: sending 
key 30B5FD72 to hkp server pool.sks-
 
 
-pool.sks-keyservers.net为随意挑选的https://sks-keyservers.net/status/"; 
target="_blank">公钥服务器，每个服务器之间是自动同步的，选任意一个即可。
-id.apache.org 中录入 Key Fingerprint
-获取 Key Fingerprint
+pool.sks-keyservers.net is one of https://sks

[GitHub] [incubator-apisix-website] juzhiyuan closed issue #35: Translate Release Guide in English

2020-06-19 Thread GitBox



juzhiyuan closed issue #35:
URL: https://github.com/apache/incubator-apisix-website/issues/35


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix-docker] gxthrj commented on issue #59: gcr.azk8s.cn no longer public

2020-06-19 Thread GitBox



gxthrj commented on issue #59:
URL: 
https://github.com/apache/incubator-apisix-docker/issues/59#issuecomment-646517243


   the image has been changed, used `gcr.io/etcd-development/etcd:v3.3.12` now
   
https://github.com/apache/incubator-apisix-docker/blob/f3db8c3e3f6860ef32af2d4373ab864d1b55a178/example/docker-compose.yml#L25



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] Donghui0 commented on issue #1737: bug: limit-count plugin threshold is not exceeded, but the request is limited

2020-06-19 Thread GitBox



Donghui0 commented on issue #1737:
URL: 
https://github.com/apache/incubator-apisix/issues/1737#issuecomment-646544945


   In my production env,  total 117 routes.   basically, each route is 
configured with  limit-count plugin.
   Whether there will be conflicts ?  
   Or the current limit rule becomes a global limit rule for all routers ?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] Donghui0 commented on issue #1737: bug: limit-count plugin threshold is not exceeded, but the request is limited

2020-06-19 Thread GitBox



Donghui0 commented on issue #1737:
URL: 
https://github.com/apache/incubator-apisix/issues/1737#issuecomment-646546329


   If a large number of routes use this plugin, do we need to increase 
PLUGIN_ITEMS_COUNT in lrucache.lua  ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[incubator-apisix] branch v1.4 created (now 7307797)

2020-06-19 Thread sshniro

This is an automated email from the ASF dual-hosted git repository.

sshniro pushed a change to branch v1.4
in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git.


  at 7307797  feature: support the use of independent files to implement 
the load a… (#1732)

No new revisions were added by this update.

[GitHub] [incubator-apisix-docker] lingsamuel commented on issue #59: gcr.azk8s.cn no longer public

2020-06-19 Thread GitBox



lingsamuel commented on issue #59:
URL: 
https://github.com/apache/incubator-apisix-docker/issues/59#issuecomment-646559131


   What's this?
   
https://github.com/apache/incubator-apisix-docker/blob/f3db8c3e3f6860ef32af2d4373ab864d1b55a178/example/docker-compose.yml#L23-L24



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] moonming commented on issue #1737: bug: limit-count plugin threshold is not exceeded, but the request is limited

2020-06-19 Thread GitBox



moonming commented on issue #1737:
URL: 
https://github.com/apache/incubator-apisix/issues/1737#issuecomment-646559664


you can increase the size of shared dict: 
https://github.com/apache/incubator-apisix/blob/master/bin/apisix#L178, which 
is LRU.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] moonming commented on issue #1737: bug: limit-count plugin threshold is not exceeded, but the request is limited

2020-06-19 Thread GitBox



moonming commented on issue #1737:
URL: 
https://github.com/apache/incubator-apisix/issues/1737#issuecomment-646559781


   > conflicts
   
   No, it will not conflict



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] moonming edited a comment on issue #1737: bug: limit-count plugin threshold is not exceeded, but the request is limited

2020-06-19 Thread GitBox



moonming edited a comment on issue #1737:
URL: 
https://github.com/apache/incubator-apisix/issues/1737#issuecomment-646559781


   > In my production env, total 117 routes. basically, each route is 
configured with limit-count plugin.
   Whether there will be conflicts ?
   
   No, it will not conflict



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] Akayeshmantha commented on pull request #1708: feature(echo): support header filter and access phases.

2020-06-19 Thread GitBox



Akayeshmantha commented on pull request #1708:
URL: https://github.com/apache/incubator-apisix/pull/1708#issuecomment-646626547


   @agile6v  @membphis  I think we can merge this right and will start on 
working the other phases 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis opened a new pull request #1739: bugfix: the id can be string object, which contains `^[a-zA-Z0-9-_]+$`.

2020-06-19 Thread GitBox



membphis opened a new pull request #1739:
URL: https://github.com/apache/incubator-apisix/pull/1739


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox



membphis commented on pull request #1727:
URL: https://github.com/apache/incubator-apisix/pull/1727#issuecomment-646631199


   > need add in the README.md
   
   
https://github.com/apache/incubator-apisix/pull/1727/files#diff-e8976e35ba880b8daf3c56fa658dd2b5
   
   DONE



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1659: [bugfix] Create service support string type ID. Fix #1654

2020-06-19 Thread GitBox



membphis commented on a change in pull request #1659:
URL: https://github.com/apache/incubator-apisix/pull/1659#discussion_r442839067



##
File path: apisix/admin/services.lua
##
@@ -47,15 +43,15 @@ local function check_conf(id, conf, need_id)
 return nil, {error_msg = "wrong service id"}
 end
 
-
 core.log.info("schema: ", core.json.delay_encode(core.schema.service))
 core.log.info("conf  : ", core.json.delay_encode(conf))
 local ok, err = core.schema.check(core.schema.service, conf)
 if not ok then
 return nil, {error_msg = "invalid configuration: " .. err}
 end
 
-if need_id and not tonumber(id) then
+local id_match, _ = ngx_re.match(id, "^[0-9a-zA-Z]{1,}$", "jo")

Review comment:
   I found that this is not a general solution to this problem.
   
   Because not only `service` id has this problem.
   
   So I create another PR: https://github.com/apache/incubator-apisix/pull/1739
   
   You can submit your test cases after #1739 merged.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1731: request help:

2020-06-19 Thread GitBox



membphis commented on issue #1731:
URL: 
https://github.com/apache/incubator-apisix/issues/1731#issuecomment-646637367


   I think only support DNS-based Service Discovery for `nacos` is not enough.
   
   The `nacos` call it `Dynamic Configuration Management`, Apache APISIX need 
to support both of them.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1731: request help:

2020-06-19 Thread GitBox



membphis commented on issue #1731:
URL: 
https://github.com/apache/incubator-apisix/issues/1731#issuecomment-646637891


   > nacos supports DNS-based Service Discovery,
   
   It needs to be written into the document.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis merged pull request #1708: feature(echo): support header filter and access phases.

2020-06-19 Thread GitBox



membphis merged pull request #1708:
URL: https://github.com/apache/incubator-apisix/pull/1708


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[incubator-apisix] branch master updated: feature(echo): support header filter and access phases. (#1708)

2020-06-19 Thread membphis

This is an automated email from the ASF dual-hosted git repository.

membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new f8f104d  feature(echo): support header filter and access phases. 
(#1708)
f8f104d is described below

commit f8f104dc0f22567dfbe9e731cd32e73101d42c63
Author: Ayeshmantha Perera 
AuthorDate: Fri Jun 19 15:33:20 2020 +0200

feature(echo): support header filter and access phases. (#1708)
---
 apisix/plugins/echo.lua |  48 -
 t/plugin/echo.t | 270 +++-
 2 files changed, 312 insertions(+), 6 deletions(-)

diff --git a/apisix/plugins/echo.lua b/apisix/plugins/echo.lua
index a4ea4e3..76ab4e5 100644
--- a/apisix/plugins/echo.lua
+++ b/apisix/plugins/echo.lua
@@ -15,8 +15,11 @@
 -- limitations under the License.
 --
 local core = require("apisix.core")
+local pairs   = pairs
+local type= type
 local ngx = ngx
 
+
 local schema = {
 type = "object",
 properties = {
@@ -31,6 +34,15 @@ local schema = {
 after_body = {
 description = "body after the modification of filter phase.",
 type = "string"
+},
+headers = {
+description = "new headers for repsonse",
+type = "object",
+minProperties = 1,
+},
+auth_value = {
+description = "auth value",
+type = "string"
 }
 },
 anyOf = {
@@ -50,8 +62,24 @@ local _M = {
 schema = schema,
 }
 
-
 function _M.check_schema(conf)
+if conf.headers then
+conf.headers_arr = {}
+
+for field, value in pairs(conf.headers) do
+if type(field) == 'string'
+and (type(value) == 'string' or type(value) == 'number') 
then
+if #field == 0 then
+return false, 'invalid field length in header'
+end
+core.table.insert(conf.headers_arr, field)
+core.table.insert(conf.headers_arr, value)
+else
+return false, 'invalid type as header value'
+end
+end
+end
+
 return core.schema.check(schema, conf)
 end
 
@@ -70,4 +98,22 @@ function _M.body_filter(conf, ctx)
 ngx.arg[2] = true
 end
 
+function _M.access(conf, ctx)
+local value = core.request.header(ctx, "Authorization")
+
+if value ~= conf.auth_value then
+return 401, "unauthorized body"
+end
+
+end
+
+function _M.header_filter(conf, ctx)
+if conf.headers_arr then
+local field_cnt = #conf.headers_arr
+for i = 1, field_cnt, 2 do
+ngx.header[conf.headers_arr[i]] = conf.headers_arr[i+1]
+end
+end
+end
+
 return _M
diff --git a/t/plugin/echo.t b/t/plugin/echo.t
index af5b25d..7040820 100644
--- a/t/plugin/echo.t
+++ b/t/plugin/echo.t
@@ -81,7 +81,12 @@ done
 "plugins": {
 "echo": {
 "before_body": "before the body modification ",
-"body":"hello upstream"
+"body":"hello upstream",
+ "headers": {
+"Location":"https://www.iresty.com";,
+"Authorization": "userpass"
+ },
+ "auth_value" : "userpass"
 }
 },
 "upstream": {
@@ -98,8 +103,12 @@ done
 "plugins": {
"echo": {
 "before_body": "before the body modification ",
-"body":"hello upstream"
-}
+"body":"hello upstream",
+"headers": {
+"Location":"https://www.iresty.com";
+ },
+ "auth_value" : "userpass"
+   }
 },
 "upstream": {
 "nodes": {
@@ -133,8 +142,13 @@ passed
 === TEST 4: access
 --- request
 GET /hello
+--- more_headers
+Authorization: userpass
 --- response_body chomp
 before the body modification hello upstream
+--- response_headers
+Location: https://www.iresty.com
+Authorization: userpass
 --- no_error_log
 [error]
 --- wait: 0.2
@@ -151,7 +165,11 @@ before the body modification hello upstream
  [[{
 "plugins": {
 "echo": {
-"before_body": "before the body modification "
+"before_body": "before the body modification ",
+

[GitHub] [incubator-apisix] membphis commented on pull request #1708: feature(echo): support header filter and access phases.

2020-06-19 Thread GitBox



membphis commented on pull request #1708:
URL: https://github.com/apache/incubator-apisix/pull/1708#issuecomment-646638433


   @Akayeshmantha merged, many thx



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1713: request help: add auth for etcd

2020-06-19 Thread GitBox



membphis commented on issue #1713:
URL: 
https://github.com/apache/incubator-apisix/issues/1713#issuecomment-646639410


   support etcd v3 is a big event. I hope we can start this step asap.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1699: request help: how to custom apisix home directory

2020-06-19 Thread GitBox



membphis commented on issue #1699:
URL: 
https://github.com/apache/incubator-apisix/issues/1699#issuecomment-646641849


   Do you want to customize the path in the production environment or the local 
development environment?
   
   production environment: soft link is a good way. eg: /usr/local/apisix -> 
/home/work/apisix



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis edited a comment on issue #1699: request help: how to custom apisix home directory

2020-06-19 Thread GitBox



membphis edited a comment on issue #1699:
URL: 
https://github.com/apache/incubator-apisix/issues/1699#issuecomment-646641849


   Do you want to customize the path in the production environment or the local 
development environment?
   
   production environment: soft link is a good way. eg: /usr/local/apisix -> 
/home/work/apisix
   development environment: git clone + 
https://github.com/apache/incubator-apisix/blob/master/doc/how-to-build.md#3-manage-startstop-apisix-server



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1715: bug: healthcheck bug

2020-06-19 Thread GitBox



membphis commented on issue #1715:
URL: 
https://github.com/apache/incubator-apisix/issues/1715#issuecomment-646644644


   please update your version first. I remember we have fixed such a bug.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1548: Support Groups for consumers

2020-06-19 Thread GitBox



membphis commented on issue #1548:
URL: 
https://github.com/apache/incubator-apisix/issues/1548#issuecomment-646647729


   I am very interested in this feature.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox



spacewander commented on a change in pull request #1727:
URL: https://github.com/apache/incubator-apisix/pull/1727#discussion_r442850805



##
File path: apisix/plugins/uri-blocker.lua
##
@@ -0,0 +1,85 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local core = require("apisix.core")
+local re_compile = require("resty.core.regex").re_match_compile
+local re_find = ngx.re.find
+local ipairs = ipairs
+
+local schema = {
+type = "object",
+properties = {
+block_rules = {
+type = "array",
+items = {
+type = "string",
+minLength = 1,
+maxLength = 4096,
+},
+uniqueItems = true
+},
+rejected_code = {
+type = "integer",
+minimum = 200,
+default = 403
+},
+},
+required = {"block_rules"},
+}
+
+
+local plugin_name = "uri-blocker"
+
+local _M = {
+version = 0.1,
+priority = 2900,
+name = plugin_name,
+schema = schema,
+}
+
+
+function _M.check_schema(conf)
+local ok, err = core.schema.check(schema, conf)
+if not ok then
+return false, err
+end
+
+local block_rules = {}
+for i, re_rule in ipairs(conf.block_rules) do
+local ok, err = re_compile(re_rule, "j")
+-- core.log.warn("ok: ", tostring(ok), " err: ", tostring(err), " 
re_rule: ", re_rule)
+if not ok then
+return false, err
+end
+block_rules[i] = re_rule
+end
+
+conf.block_rules_concat = core.table.concat(block_rules, "|")
+core.log.info("concat block_rules: ", conf.block_rules_concat)
+return true
+end
+
+
+function _M.rewrite(conf, ctx)
+core.log.info("uri: ", ctx.var.request_uri)

Review comment:
   Better to also log the block uri pattern?

##
File path: doc/plugins/uri-blocker.md
##
@@ -0,0 +1,96 @@
+
+
+[Chinese](uri-blocker.md)
+
+# Summary
+
+- [**Name**](#name)
+- [**Attributes**](#attributes)
+- [**How To Enable**](#how-to-enable)
+- [**Test Plugin**](#test-plugin)
+- [**Disable Plugin**](#disable-plugin)
+
+## Name
+
+The plugin helps we intercept user requests, we only need to indicate the 
`block_rules`.
+
+## Attributes
+
+|Name  |Requirement  |Description|
+|- ||---|
+|block_rules  |required|Regular filter rule array. Each of these items is a 
regular rule. If the current request URI hits any one of them, set the response 
code to rejected_code to exit the current user request. Example: `["root.exe", 
"root.m+"]`.|

Review comment:
   Better to escape the dot in the doc.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] agile6v commented on pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox



agile6v commented on pull request #1727:
URL: https://github.com/apache/incubator-apisix/pull/1727#issuecomment-646896513


   Also, What's the differences between `doc/zh-cn/README.md` and 
`doc/README_CN.md`?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox



membphis commented on a change in pull request #1727:
URL: https://github.com/apache/incubator-apisix/pull/1727#discussion_r443085739



##
File path: doc/plugins/uri-blocker.md
##
@@ -0,0 +1,96 @@
+
+
+[Chinese](uri-blocker.md)
+
+# Summary
+
+- [**Name**](#name)
+- [**Attributes**](#attributes)
+- [**How To Enable**](#how-to-enable)
+- [**Test Plugin**](#test-plugin)
+- [**Disable Plugin**](#disable-plugin)
+
+## Name
+
+The plugin helps we intercept user requests, we only need to indicate the 
`block_rules`.
+
+## Attributes
+
+|Name  |Requirement  |Description|
+|- ||---|
+|block_rules  |required|Regular filter rule array. Each of these items is a 
regular rule. If the current request URI hits any one of them, set the response 
code to rejected_code to exit the current user request. Example: `["root.exe", 
"root.m+"]`.|

Review comment:
   do you mean remove the dot at the end this line?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox



membphis commented on pull request #1727:
URL: https://github.com/apache/incubator-apisix/pull/1727#issuecomment-646921302


   > Also, What's the differences between `doc/zh-cn/README.md` and 
`doc/README_CN.md`?
   
   fix this later. it should be one file.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox



membphis commented on pull request #1727:
URL: https://github.com/apache/incubator-apisix/pull/1727#issuecomment-646922700


   > We could add a test case for multiple rules and test it.
   
   added, good catch.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1689: Use ipv4 API turn out 403 error

2020-06-19 Thread GitBox



membphis commented on issue #1689:
URL: 
https://github.com/apache/incubator-apisix/issues/1689#issuecomment-646926148


   @zheng11581 do you have fixed?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis opened a new issue #1740: safe: Apache APISIX security configuration

2020-06-19 Thread GitBox



membphis opened a new issue #1740:
URL: https://github.com/apache/incubator-apisix/issues/1740


   check the current nginx.conf if it has any security problem.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1693: request help: apisix supports running as root user

2020-06-19 Thread GitBox



membphis commented on issue #1693:
URL: 
https://github.com/apache/incubator-apisix/issues/1693#issuecomment-646926475


   > I think we need an Apache APISIX security configuration specification.
   
   that is another question. I have created a new issue: 
https://github.com/apache/incubator-apisix/issues/1740



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis edited a comment on issue #1693: request help: apisix supports running as root user

2020-06-19 Thread GitBox



membphis edited a comment on issue #1693:
URL: 
https://github.com/apache/incubator-apisix/issues/1693#issuecomment-646926475


   > I think we need an Apache APISIX security configuration specification.
   
   that is another question. I have created a new issue: 
https://github.com/apache/incubator-apisix/issues/1740
   
   we can close this issue. @Miss-you 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1686: request help: Does the protocol support custom transformations

2020-06-19 Thread GitBox



membphis commented on issue #1686:
URL: 
https://github.com/apache/incubator-apisix/issues/1686#issuecomment-646927368


   @guoziqin it needs some work to support custom transformations. if you need 
any help, please let me know.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on issue #1680: Is etcd configuration support v3 api

2020-06-19 Thread GitBox



membphis commented on issue #1680:
URL: 
https://github.com/apache/incubator-apisix/issues/1680#issuecomment-646927775


   lua-resty-etcd already supports etcd v3, welcome PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] membphis edited a comment on issue #1680: Is etcd configuration support v3 api

2020-06-19 Thread GitBox



membphis edited a comment on issue #1680:
URL: 
https://github.com/apache/incubator-apisix/issues/1680#issuecomment-646927775


   lua-resty-etcd already supports etcd v3, welcome PR.
   
   https://github.com/api7/lua-resty-etcd/blob/master/api_v3.md



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] wangxiaolong100 opened a new issue #1741: request help: openid-connect plugin with hydra not working as expected

2020-06-19 Thread GitBox



wangxiaolong100 opened a new issue #1741:
URL: https://github.com/apache/incubator-apisix/issues/1741


   ### Issue description
   openid-connect can not block not active access token.
   
   hydra introspect endpoint return
   
   `
   HTTP/1.1 200 OK
   Content-Type: application/json
   Date: Sat, 20 Jun 2020 03:05:56 GMT
   Content-Length: 17
   
   {"active":false}
   `
   
   plugin use respons body as X-Userinfo, but body acture mean access token is 
not active.
   
   ### Environment
   
   * apisix version (cmd: `apisix version`): 1.3
   * OS: Docker
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1727: feature: implemented plugin `uri-blocklist` .

2020-06-19 Thread GitBox



spacewander commented on a change in pull request #1727:
URL: https://github.com/apache/incubator-apisix/pull/1727#discussion_r443096855



##
File path: doc/plugins/uri-blocker.md
##
@@ -0,0 +1,96 @@
+
+
+[Chinese](uri-blocker.md)
+
+# Summary
+
+- [**Name**](#name)
+- [**Attributes**](#attributes)
+- [**How To Enable**](#how-to-enable)
+- [**Test Plugin**](#test-plugin)
+- [**Disable Plugin**](#disable-plugin)
+
+## Name
+
+The plugin helps we intercept user requests, we only need to indicate the 
`block_rules`.
+
+## Attributes
+
+|Name  |Requirement  |Description|
+|- ||---|
+|block_rules  |required|Regular filter rule array. Each of these items is a 
regular rule. If the current request URI hits any one of them, set the response 
code to rejected_code to exit the current user request. Example: `["root.exe", 
"root.m+"]`.|

Review comment:
   If we need to match `.exe` as an extension, we should use `\.exe` 
instead.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] zheng11581 commented on issue #1689: Use ipv4 API turn out 403 error

2020-06-19 Thread GitBox



zheng11581 commented on issue #1689:
URL: 
https://github.com/apache/incubator-apisix/issues/1689#issuecomment-646938774


   no i didn't.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] shibingli closed pull request #1659: [bugfix] Create service support string type ID. Fix #1654

2020-06-19 Thread GitBox



shibingli closed pull request #1659:
URL: https://github.com/apache/incubator-apisix/pull/1659


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-apisix] shibingli commented on pull request #1659: [bugfix] Create service support string type ID. Fix #1654

2020-06-19 Thread GitBox



shibingli commented on pull request #1659:
URL: https://github.com/apache/incubator-apisix/pull/1659#issuecomment-646942517


   Merger  #1739 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

51 matches

Mail list logo