[incubator-apisix-website] branch master updated: Update index.zh.md
This is an automated email from the ASF dual-hosted git repository. agile6v pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/master by this push: new d8a5303 Update index.zh.md d8a5303 is described below commit d8a53037b3ada57e27efdab478f962f451025181 Author: agile6v AuthorDate: Tue Jun 30 15:35:31 2020 +0800 Update index.zh.md --- content/contribute/release/index.zh.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/contribute/release/index.zh.md b/content/contribute/release/index.zh.md index a72230c..8a81c30 100644 --- a/content/contribute/release/index.zh.md +++ b/content/contribute/release/index.zh.md @@ -162,8 +162,8 @@ include_footer: true http://mail-archives.apache.org/mod_mbox/incubator-general/202004.mbox/%3ccabzgmxfal247-9u4ehabxrezhkjykzhh2izuiu2jdtx7zg4...@mail.gmail.com%3e";>点击此处查看参考邮件 发起投票邮件后需要等待72小时，然后统计投票结果并发送一封 result 邮件到 gene...@incubator.apache.org。 发 announce 邮件 https://lists.apache.org/thread.html/r67093ed9a5fbe106dc5066c283f225544f5ae14248df061019d1062e%40%3Cgeneral.incubator.apache.org%3E";>点击此处查看参考邮件 在 d...@apisix.apache.org 和 gene...@incubator.apache.org 两个邮件列表发起 announce 邮件 -移动安装包到 release 目录下 -将RC版本的安装包修改为正式版以后移动到 https://dist.apache.org/repos/dist/release/incubator/apisix/";>此地址 +将安装包从 dev 移动到 release 目录下 +包名中的RC去掉后，将 KEYS 文件以及安装包移动到 https://dist.apache.org/repos/dist/release/incubator/apisix/";>此地址 更新下载信息 更新http://apisix.apache.org/downloads/";>此地址 的下载信息，源码在 https://github.com/apache/incubator-apisix-website
[incubator-apisix-website] branch asf-site updated: Deploy to GitHub pages
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 2b61be4 Deploy to GitHub pages 2b61be4 is described below commit 2b61be423f72a8f2e7f8ace19726da8473cdb45a Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> AuthorDate: Tue Jun 30 07:37:23 2020 + Deploy to GitHub pages --- zh/contribute/release/index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zh/contribute/release/index.html b/zh/contribute/release/index.html index 4bdd43e..a485dfe 100644 --- a/zh/contribute/release/index.html +++ b/zh/contribute/release/index.html @@ -623,8 +623,8 @@ GnuPG-2.x可使用： http://mail-archives.apache.org/mod_mbox/incubator-general/202004.mbox/%3ccabzgmxfal247-9u4ehabxrezhkjykzhh2izuiu2jdtx7zg4...@mail.gmail.com%3e";>点击此处查看参考邮件 发起投票邮件后需要等待72小时，然后统计投票结果并发送一封 result 邮件到 gene...@incubator.apache.org。 发 announce 邮件 https://lists.apache.org/thread.html/r67093ed9a5fbe106dc5066c283f225544f5ae14248df061019d1062e%40%3Cgeneral.incubator.apache.org%3E";>点击此处查看参考邮件 在 d...@apisix.apache.org 和 gene...@incubator.apache.org 两个邮件列表发起 announce 邮件 -移动安装包到 release 目录下 -将RC版本的安装包修改为正式版以后移动到 https://dist.apache.org/repos/dist/release/incubator/apisix/";>此地址 +将安装包从 dev 移动到 release 目录下 +包名中的RC去掉后，将 KEYS 文件以及安装包移动到 https://dist.apache.org/repos/dist/release/incubator/apisix/";>此地址 更新下载信息 更新http://apisix.apache.org/downloads/";>此地址 的下载信息，源码在 https://github.com/apache/incubator-apisix-website
[GitHub] [incubator-apisix] griffenliu opened a new pull request #1782: fix https://github.com/apache/incubator-apisix/issues/1667
griffenliu opened a new pull request #1782: URL: https://github.com/apache/incubator-apisix/pull/1782 ### Issues resolved Fix #1667 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-apisix-website] branch master updated: Update index.zh.md
This is an automated email from the ASF dual-hosted git repository. agile6v pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 0d7352d Update index.zh.md 0d7352d is described below commit 0d7352da34d472a5f5634f5ec9fef8769e92fa0d Author: agile6v AuthorDate: Tue Jun 30 16:09:01 2020 +0800 Update index.zh.md --- content/contribute/release/index.zh.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/contribute/release/index.zh.md b/content/contribute/release/index.zh.md index 8a81c30..2ee67c6 100644 --- a/content/contribute/release/index.zh.md +++ b/content/contribute/release/index.zh.md @@ -163,7 +163,7 @@ include_footer: true 发 announce 邮件 https://lists.apache.org/thread.html/r67093ed9a5fbe106dc5066c283f225544f5ae14248df061019d1062e%40%3Cgeneral.incubator.apache.org%3E";>点击此处查看参考邮件 在 d...@apisix.apache.org 和 gene...@incubator.apache.org 两个邮件列表发起 announce 邮件 将安装包从 dev 移动到 release 目录下 -包名中的RC去掉后，将 KEYS 文件以及安装包移动到 https://dist.apache.org/repos/dist/release/incubator/apisix/";>此地址 +去掉包名中的 RC，将 KEYS 文件以及安装包移动到 https://dist.apache.org/repos/dist/release/incubator/apisix/";>此地址 更新下载信息 更新http://apisix.apache.org/downloads/";>此地址 的下载信息，源码在 https://github.com/apache/incubator-apisix-website
[incubator-apisix-website] branch asf-site updated: Deploy to GitHub pages
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 831ea64 Deploy to GitHub pages 831ea64 is described below commit 831ea640e42a4f9e51bdf756827000565bfdcfd1 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> AuthorDate: Tue Jun 30 08:09:21 2020 + Deploy to GitHub pages --- zh/contribute/release/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zh/contribute/release/index.html b/zh/contribute/release/index.html index a485dfe..be3f550 100644 --- a/zh/contribute/release/index.html +++ b/zh/contribute/release/index.html @@ -624,7 +624,7 @@ GnuPG-2.x可使用： 发 announce 邮件 https://lists.apache.org/thread.html/r67093ed9a5fbe106dc5066c283f225544f5ae14248df061019d1062e%40%3Cgeneral.incubator.apache.org%3E";>点击此处查看参考邮件 在 d...@apisix.apache.org 和 gene...@incubator.apache.org 两个邮件列表发起 announce 邮件 将安装包从 dev 移动到 release 目录下 -包名中的RC去掉后，将 KEYS 文件以及安装包移动到 https://dist.apache.org/repos/dist/release/incubator/apisix/";>此地址 +去掉包名中的 RC，将 KEYS 文件以及安装包移动到 https://dist.apache.org/repos/dist/release/incubator/apisix/";>此地址 更新下载信息 更新http://apisix.apache.org/downloads/";>此地址 的下载信息，源码在 https://github.com/apache/incubator-apisix-website
[incubator-apisix-website] branch asf-site updated: Deploy to GitHub pages
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 4c68119 Deploy to GitHub pages 4c68119 is described below commit 4c68119e7b6d79ffd5e2f723780a8ad8d7cbf48f Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> AuthorDate: Tue Jun 30 08:10:47 2020 + Deploy to GitHub pages --- contribute/release/index.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contribute/release/index.html b/contribute/release/index.html index 3f8419f..eae75db 100644 --- a/contribute/release/index.html +++ b/contribute/release/index.html @@ -609,7 +609,7 @@ GnuPG-2.x： send announce https://lists.apache.org/thread.html/r67093ed9a5fbe106dc5066c283f225544f5ae14248df061019d1062e%40%3Cgeneral.incubator.apache.org%3E";>Click here to view the reference email send announce email to d...@apisix.apache.org and gene...@incubator.apache.org move package from dev to dist -Remove `rc` from the package name, and move to https://dist.apache.org/repos/dist/release/incubator/apisix/";> address +Remove `rc` from the package name, move KEYS and package to https://dist.apache.org/repos/dist/release/incubator/apisix/";> address update download page update http://apisix.apache.org/downloads/";> address , source repo is https://github.com/apache/incubator-apisix-website
[incubator-apisix-website] branch master updated: Update index.en.md
This is an automated email from the ASF dual-hosted git repository. agile6v pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/master by this push: new bd388a0 Update index.en.md bd388a0 is described below commit bd388a0e93f2faac77cbe0de43254140e16c92f7 Author: agile6v AuthorDate: Tue Jun 30 16:10:23 2020 +0800 Update index.en.md --- content/contribute/release/index.en.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/contribute/release/index.en.md b/content/contribute/release/index.en.md index 19aede7..0e69bef 100644 --- a/content/contribute/release/index.en.md +++ b/content/contribute/release/index.en.md @@ -157,7 +157,7 @@ include_footer: true send announce https://lists.apache.org/thread.html/r67093ed9a5fbe106dc5066c283f225544f5ae14248df061019d1062e%40%3Cgeneral.incubator.apache.org%3E";>Click here to view the reference email send announce email to d...@apisix.apache.org and gene...@incubator.apache.org move package from dev to dist -Remove `rc` from the package name, and move to https://dist.apache.org/repos/dist/release/incubator/apisix/";> address +Remove `rc` from the package name, move KEYS and package to https://dist.apache.org/repos/dist/release/incubator/apisix/";> address update download page update http://apisix.apache.org/downloads/";> address , source repo is https://github.com/apache/incubator-apisix-website
[incubator-apisix] tag 1.4 created (now 953eb40)
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to tag 1.4 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. at 953eb40 (commit) No new revisions were added by this update.
[GitHub] [incubator-apisix] moonming opened a new pull request #1783: rocks: fixed wrong source of 1.4.
moonming opened a new pull request #1783: URL: https://github.com/apache/incubator-apisix/pull/1783 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] zcadqe897 opened a new issue #1784: bug: /admin/routes return {"error_msg":"missing configurations"}
zcadqe897 opened a new issue #1784:
URL: https://github.com/apache/incubator-apisix/issues/1784
### Issue description
If there are too many uris, return {"error_msg":"missing configurations"}
cURL：
curl -v -s ${GATEWAY}/apisix/admin/routes -H "X-API-KEY: $ADMINKEY" -X POST
-d "
{
\"uris\": [$uris],
\"hosts\": [$DOMAINS],
\"service_id\": \"1\",
\"desc\": \"apisix\"
}"
error.log：
2020/06/30 16:36:06 [warn] 119916#119916: *857380 a client request body is
buffered to a temporary file /usr/local/apisix/client_body_temp/03,
client: 1.14.31.17, server: , request: "POST /apisix/admin/routes HTTP/1.1",
host: "1.2.6.2:9080"
### Environment
* apisix version (cmd: `apisix version`):1.3
* OS:CentOS
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-apisix] wangxiaochuang opened a new pull request #1785: sync_times need to reset
wangxiaochuang opened a new pull request #1785: URL: https://github.com/apache/incubator-apisix/pull/1785 just like the title said NOTE: Please read the Contributing.md guidelines before submitting your patch: https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one ### Summary SUMMARY_HERE ### Full changelog * [Implement ...] * [Add related tests] * ... ### Issues resolved Fix #XXX This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] wasabihu opened a new issue #1786: bug: dashboard ignores admin api and Upstream data
wasabihu opened a new issue #1786:
URL: https://github.com/apache/incubator-apisix/issues/1786
### Issue description
dashboard ignores admin api and Upstream data
**ETCD data**
主要是 dashboard 的bug , 对比一下etcd 的数据就会发现， 加插件的时候会把某些参数漏掉了, 这里是少了 upstream 参数 。
### Environment
* apisix version (cmd: `apisix version`): 1.3
* OS: centos7
### Minimal test code / Steps to reproduce the issue
1. `curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
{
"uri": "/healthz",
"upstream": {
"type": "roundrobin",
"nodes": {
"go-consul-test.service.consul:8082": 1
}
}
}'
`
2. 用dashboard 为路由加上 限流插件 ( add limit-req plugins )
3. curl http://127.0.0.1:9080/healthz ， 出现 502
reference : https://gist.github.com/moonming/32aed4922ea428db1abfe2edfd730b3a
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-apisix-dashboard] ko-han opened a new pull request #289: Now the add plug-in option is available for searching
ko-han opened a new pull request #289: URL: https://github.com/apache/incubator-apisix-dashboard/pull/289 What a good improvement. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-apisix-dashboard] branch master-vue updated: feat: make plugin select form filterable (#289)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master-vue in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git The following commit(s) were added to refs/heads/master-vue by this push: new d412b73 feat: make plugin select form filterable (#289) d412b73 is described below commit d412b73ede896567eefd7c0637a7f908fc3eea00 Author: ko han AuthorDate: Tue Jun 30 22:22:01 2020 +0800 feat: make plugin select form filterable (#289) --- src/views/schema/routes/edit.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/src/views/schema/routes/edit.vue b/src/views/schema/routes/edit.vue index 9123bbd..b5d2b4d 100644 --- a/src/views/schema/routes/edit.vue +++ b/src/views/schema/routes/edit.vue @@ -175,6 +175,7 @@ :value="null" class="plugin-select" placeholder="Select a Plugin" + filterable @change="showPlugin" >
[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #289: Now the add plug-in option is available for searching
juzhiyuan merged pull request #289: URL: https://github.com/apache/incubator-apisix-dashboard/pull/289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] juzhiyuan commented on issue #1786: bug: dashboard ignores admin api and Upstream data
juzhiyuan commented on issue #1786: URL: https://github.com/apache/incubator-apisix/issues/1786#issuecomment-651825613 We are rebuilding the new plugin page by using react jsonschema form, will be added next week. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix-dashboard] wasabihu opened a new issue #290: bug: dashboard ignores admin api and Upstream data
wasabihu opened a new issue #290:
URL: https://github.com/apache/incubator-apisix-dashboard/issues/290
### Issue description
dashboard ignores admin api and Upstream data
**ETCD data**
主要是 dashboard 的bug , 对比一下etcd 的数据就会发现， 加插件的时候会把某些参数漏掉了, 这里是少了 upstream 参数 。
### Environment
* apisix version (cmd: `apisix version`): 1.3
* OS: centos7
### Minimal test code / Steps to reproduce the issue
1. `curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
{
"uri": "/healthz",
"upstream": {
"type": "roundrobin",
"nodes": {
"go-consul-test.service.consul:8082": 1
}
}
}'
`
2. 用dashboard 为路由加上 限流插件 ( add limit-req plugins )
3. curl http://127.0.0.1:9080/healthz ， 出现 502
reference : https://gist.github.com/moonming/32aed4922ea428db1abfe2edfd730b3a
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-apisix] membphis opened a new issue #1787: change: the plugin `cors` is not an authentication type plugin
membphis opened a new issue #1787: URL: https://github.com/apache/incubator-apisix/issues/1787 plugin `cors` is not an authentication type plugin, we need to remove this line: https://github.com/apache/incubator-apisix/blob/master/apisix/plugins/cors.lua#L74 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] membphis merged pull request #1785: sync_times need to reset
membphis merged pull request #1785: URL: https://github.com/apache/incubator-apisix/pull/1785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-apisix] branch master updated: bugfix(config etcd): when we reset the fetched data, `sync_times` also needs to be reset. (#1785)
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 3061aee bugfix(config etcd): when we reset the fetched data, `sync_times` also needs to be reset. (#1785) 3061aee is described below commit 3061aeefa326a21c6b27db0d85cd6d485a3b58e1 Author: jackstraw <932698...@qq.com> AuthorDate: Wed Jul 1 09:28:00 2020 +0800 bugfix(config etcd): when we reset the fetched data, `sync_times` also needs to be reset. (#1785) --- apisix/core/config_etcd.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/apisix/core/config_etcd.lua b/apisix/core/config_etcd.lua index dd0a548..fbb6df8 100644 --- a/apisix/core/config_etcd.lua +++ b/apisix/core/config_etcd.lua @@ -308,6 +308,7 @@ local function sync_data(self) key = short_key(self, self.values[i].key) self.values_hash[key] = i end +self.sync_times = 0 end self.conf_version = self.conf_version + 1
[GitHub] [incubator-apisix-dashboard] gxthrj opened a new pull request #291: fix use Put method when upstream update
gxthrj opened a new pull request #291: URL: https://github.com/apache/incubator-apisix-dashboard/pull/291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #291: fix use Put method when upstream update
juzhiyuan merged pull request #291: URL: https://github.com/apache/incubator-apisix-dashboard/pull/291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-apisix-dashboard] branch master updated: fix use Put method when upstream update (#291)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 3c3ed5d fix use Put method when upstream update (#291)
3c3ed5d is described below
commit 3c3ed5d3915dcb866ca58f995e8054f06f7da895
Author: kv
AuthorDate: Wed Jul 1 09:50:25 2020 +0800
fix use Put method when upstream update (#291)
---
api/service/upstream.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/api/service/upstream.go b/api/service/upstream.go
index 466045b..2b0a851 100644
--- a/api/service/upstream.go
+++ b/api/service/upstream.go
@@ -189,7 +189,7 @@ func (aur *ApisixUpstreamRequest) Update()
(*ApisixUpstreamResponse, error) {
return nil, err
} else {
fmt.Println(string(b))
- if resp, err := utils.Patch(url, b); err != nil {
+ if resp, err := utils.Put(url, b); err != nil {
logger.Error(err.Error())
return nil, err
} else {
[GitHub] [incubator-apisix] membphis commented on issue #1667: bug: global-rule error when enable_debug=true
membphis commented on issue #1667:
URL:
https://github.com/apache/incubator-apisix/issues/1667#issuecomment-652140810
many thanks to your PR, and I confirmed it should be a bug.
I write a patch for this bug. You can take a look at this, and we need some
test cases to confirm we fixed this bug:
```diff
diff --git a/apisix/init.lua b/apisix/init.lua
index 41295f0..3ecb999 100644
--- a/apisix/init.lua
+++ b/apisix/init.lua
@@ -252,7 +252,7 @@ function _M.http_access_phase()
api_ctx.conf_id = global_rule.value.id
core.table.clear(plugins)
-api_ctx.plugins = plugin.filter(global_rule, plugins)
+api_ctx.plugins = plugin.filter(global_rule, plugins, true)
run_plugin("rewrite", plugins, api_ctx)
run_plugin("access", plugins, api_ctx)
end
@@ -445,8 +445,7 @@ local function common_phase(phase_name)
local plugins = core.tablepool.fetch("plugins", 32, 0)
local values = api_ctx.global_rules.values
for _, global_rule in config_util.iterate_values(values) do
-core.table.clear(plugins)
-plugins = plugin.filter(global_rule, plugins)
+plugins = plugin.filter(global_rule, plugins, true)
run_plugin(phase_name, plugins, api_ctx)
end
core.tablepool.release("plugins", plugins)
diff --git a/apisix/plugin.lua b/apisix/plugin.lua
index 075d058..8267ae1 100644
--- a/apisix/plugin.lua
+++ b/apisix/plugin.lua
@@ -232,14 +232,35 @@ function _M.api_routes()
end
-function _M.filter(user_route, plugins)
+local function set_response_header_by_debug_flag(plugins, dry_run)
+if dry_run then
+return
+end
+
+if not local_conf or not local_conf.apisix.enable_debug then
+return
+end
+
+if #plugins == 0 then
+core.response.set_header("Apisix-Plugins", "no plugin")
+end
+
+local t = {}
+for i = 1, #plugins, 2 do
+core.table.insert(t, plugins[i].name)
+end
+core.response.set_header("Apisix-Plugins", core.table.concat(t, ", "))
+end
+
+
+function _M.filter(user_route, plugins, dry_run)
plugins = plugins or core.table.new(#local_plugins * 2, 0)
+core.table.clear(plugins)
+
local user_plugin_conf = user_route.value.plugins
if user_plugin_conf == nil or
core.table.nkeys(user_plugin_conf) == 0 then
-if local_conf and local_conf.apisix.enable_debug then
-core.response.set_header("Apisix-Plugins", "no plugin")
-end
+set_response_header_by_debug_flag(plugins, dry_run)
return plugins
end
@@ -253,14 +274,7 @@ function _M.filter(user_route, plugins)
end
end
-if local_conf.apisix.enable_debug then
-local t = {}
-for i = 1, #plugins, 2 do
-core.table.insert(t, plugins[i].name)
-end
-core.response.set_header("Apisix-Plugins", core.table.concat(t, ",
"))
-end
-
+set_response_header_by_debug_flag(plugins, dry_run)
return plugins
end
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1782: fix https://github.com/apache/incubator-apisix/issues/1667
membphis commented on pull request #1782: URL: https://github.com/apache/incubator-apisix/pull/1782#issuecomment-652140960 @griffenliu please take a look at this comment https://github.com/apache/incubator-apisix/issues/1667#issuecomment-652140810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on a change in pull request #1782: fix https://github.com/apache/incubator-apisix/issues/1667
membphis commented on a change in pull request #1782: URL: https://github.com/apache/incubator-apisix/pull/1782#discussion_r448073576 ## File path: apisix/plugin.lua ## @@ -237,7 +237,7 @@ function _M.filter(user_route, plugins) local user_plugin_conf = user_route.value.plugins if user_plugin_conf == nil or core.table.nkeys(user_plugin_conf) == 0 then -if local_conf and local_conf.apisix.enable_debug then +if local_conf and local_conf.apisix.enable_debug and not ngx.headers_sent then Review comment: https://github.com/apache/incubator-apisix/issues/1667#issuecomment-652140810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix-docker] moonming opened a new issue #60: auto build docker images for dockerhub
moonming opened a new issue #60: URL: https://github.com/apache/incubator-apisix-docker/issues/60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] morrme opened a new pull request #1788: remove authentication type for cors plugin
morrme opened a new pull request #1788: URL: https://github.com/apache/incubator-apisix/pull/1788 ### Summary Removes the 'auth' type for the cors plugin ### Full changelog * removed the 'auth' line ### Issues resolved Fix #1787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] griffenliu closed pull request #1782: fix https://github.com/apache/incubator-apisix/issues/1667
griffenliu closed pull request #1782: URL: https://github.com/apache/incubator-apisix/pull/1782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] wingsjj opened a new issue #1789: bug: The test case does not take into account tengine
wingsjj opened a new issue #1789: URL: https://github.com/apache/incubator-apisix/issues/1789 ### Issue description When I tried to migrate CI from Travis to GitHub action, I found that this test case does not pass when using Tengine. https://github.com/wingsjj/incubator-apisix/runs/824980221?check_suite_focus=true#step:6:130 ### Environment * apisix version (cmd: `apisix version`): 1.4 * OS: Ubuntu 18.04 ### Minimal test code / Steps to reproduce the issue 1.https://github.com/wingsjj/incubator-apisix/runs/824980221?check_suite_focus=true#step:6:130 2.https://github.com/apache/incubator-apisix/blob/master/t/node/remote-addr-ipv6.t#L117 ### What's the actual result? (including assertion message & call stack if applicable) > Failed test 'TEST 4: IPv6 /hello - response_body - response is expected (repeated req 0, req 0)' > at /home/runner/work/incubator-apisix/incubator-apisix/test-nginx/lib/Test/Nginx/Socket.pm line 1589. > @@ -3,7 +3,7 @@ > received: HTTP/1.1 200 OK > received: Content-Type: text/plain > received: Connection: close > -received: Server: openresty > +received: Server: Tengine > received: > received: hello world > failed to receive a line: closed [] > Test Summary Report > --- > t/node/remote-addr-ipv6.t(Wstat: 256 Tests: 15 Failed: 1) > Failed test: 11 > Non-zero exit status: 1 > Files=119, Tests=3969, 959 wallclock secs ( 0.95 usr 0.18 sys + 130.74 cusr 27.03 csys = 158.90 CPU) > Result: FAIL > ##[error]Process completed with exit code 1. ### What's the expected result? Test case passed successfully. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] ko-han commented on pull request #1779: The 'get_plugin_list' API sorts the return list base on priority
ko-han commented on pull request #1779: URL: https://github.com/apache/incubator-apisix/pull/1779#issuecomment-652201023 > @ko-han please fix test case in `t/admin/plugins.t ` Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on issue #1789: bug: The test case does not take into account tengine
membphis commented on issue #1789: URL: https://github.com/apache/incubator-apisix/issues/1789#issuecomment-652201356 you can update the test case if you need This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on issue #1780: consul serviece create route limit req report 502
membphis commented on issue #1780: URL: https://github.com/apache/incubator-apisix/issues/1780#issuecomment-652203880 please provide more information. eg: the version of apisix, your route, etc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on issue #1784: bug: /admin/routes return {"error_msg":"missing configurations"}
membphis commented on issue #1784: URL: https://github.com/apache/incubator-apisix/issues/1784#issuecomment-652204886 @nic-chen please take a look at this issue, do you think we need to update the `client max body size` in `nginx.conf` ? Writes to a temporary file is not a good way which is slower. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-apisix] branch master updated: change: remove authentication type for cors plugin (#1788)
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git
The following commit(s) were added to refs/heads/master by this push:
new a9d60f9 change: remove authentication type for cors plugin (#1788)
a9d60f9 is described below
commit a9d60f97c5586b53e16c9e7c9769ce0e1aaced20
Author: morrme
AuthorDate: Wed Jul 1 00:52:47 2020 -0500
change: remove authentication type for cors plugin (#1788)
fix #1787
---
apisix/plugins/cors.lua | 1 -
1 file changed, 1 deletion(-)
diff --git a/apisix/plugins/cors.lua b/apisix/plugins/cors.lua
index f44eac5..9fe91c9 100644
--- a/apisix/plugins/cors.lua
+++ b/apisix/plugins/cors.lua
@@ -71,7 +71,6 @@ local schema = {
local _M = {
version = 0.1,
priority = 4000,
-type = 'auth',
name = plugin_name,
schema = schema,
}
[GitHub] [incubator-apisix] membphis merged pull request #1788: remove authentication type for cors plugin
membphis merged pull request #1788: URL: https://github.com/apache/incubator-apisix/pull/1788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] membphis closed issue #1787: change: the plugin `cors` is not an authentication type plugin
membphis closed issue #1787: URL: https://github.com/apache/incubator-apisix/issues/1787 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1788: remove authentication type for cors plugin
membphis commented on pull request #1788: URL: https://github.com/apache/incubator-apisix/pull/1788#issuecomment-652207432 @morrme merged, many thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
