[GitHub] [apisix-dashboard] AllenLi1990 opened a new issue #381: can not start with docker
AllenLi1990 opened a new issue #381: URL: https://github.com/apache/apisix-dashboard/issues/381 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ - ] Bug - [ ] Requirements - [ ] Feature or performance improvement - [ ] Other ___ ### Question - What do you want to know? can not start apisix-dashboard with docker. CONTAINER IDIMAGE COMMAND CREATED STATUS PORTS NAMES 27083ec44749apache/apisix:dev "sh -c '/usr/bin/api…" 3 minutes ago Restarting (1) 7 seconds ago dashboard_apisix_1 [C]: at 0x562c561cd320 /usr/local/openresty/luajit/bin/luajit: /usr/local/apisix/deps/share/lua/5.1/tinyyaml.lua:698: bad argument #1 to 'sfind' (string expected, got nil) stack traceback: [C]: in function 'sfind' /usr/local/apisix/deps/share/lua/5.1/tinyyaml.lua:698: in function 'parsedocuments' /usr/local/apisix/deps/share/lua/5.1/tinyyaml.lua:760: in function 'read_yaml_conf' /usr/bin/apisix:679: in function /usr/bin/apisix:936: in main chunk [C]: at 0x562891b9e320 ___ ### Bug - Which version of Apache APISIX Dashboard, OS and Broswer? ubuntu-1604 - What happened? just start with docker ___ ### Requirement or improvement - nothing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2079: fix proxy_set_header Host $host may lose port info
membphis commented on pull request #2079: URL: https://github.com/apache/apisix/pull/2079#issuecomment-675844667 pls add test cases This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] halfcrazy opened a new pull request #2079: fix proxy_set_header Host $host may lost port info
halfcrazy opened a new pull request #2079: URL: https://github.com/apache/apisix/pull/2079 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis opened a new issue #2078: test: confirm APISIX works normally when the etcd is shutdown
membphis opened a new issue #2078: URL: https://github.com/apache/apisix/issues/2078 need to add a new test. for confirming APISIX works normally when the etcd is shutdown. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2077: bugfix: service discovery duplicate request service information in Eureka #2076
membphis commented on pull request #2077: URL: https://github.com/apache/apisix/pull/2077#issuecomment-675836867 please rebase your branch with `master` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] frank0417 commented on pull request #2077: bugfix: service discovery duplicate request service information in Eureka #2076
frank0417 commented on pull request #2077: URL: https://github.com/apache/apisix/pull/2077#issuecomment-675836494 fix #2076 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] frank0417 opened a new pull request #2077: bugfix: service discovery duplicate request service information in Eureka #2076
frank0417 opened a new pull request #2077: URL: https://github.com/apache/apisix/pull/2077 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #380: README I18n
juzhiyuan opened a new issue #380: URL: https://github.com/apache/apisix-dashboard/issues/380 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirements - [x] Feature or performance improvement - [ ] Other ___ ### Question - What do you want to know? We need a README in Chinese ___ ### Bug - Which version of Apache APISIX Dashboard, OS and Broswer? None - What happened? If possible, provide a way to reproduce the error. None ___ ### Requirement or improvement - Please describe your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] frank0417 commented on issue #2076: bug: service discovery duplicate request service information in Eureka
frank0417 commented on issue #2076: URL: https://github.com/apache/apisix/issues/2076#issuecomment-675831504 add ngx.worker.id()==0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] frank0417 opened a new issue #2076: bug: service discovery duplicate request service information in Eureka
frank0417 opened a new issue #2076: URL: https://github.com/apache/apisix/issues/2076 ### Issue description Service discovery duplicate request service information in Eureka ### Environment * apisix version (cmd: `apisix version`): * OS:linux centos ### Minimal test code / Steps to reproduce the issue 1.set enable_dev_mode:false 2.service discovery center:eureka ### What's the actual result? (including assertion message & call stack if applicable) multiple workers execute repeat fetch_full_registry ### What's the expected result? only one This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat(doc): update deploy manually doc
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 25571ef feat(doc): update deploy manually doc 25571ef is described below commit 25571ef7fadd946650b6301562ab0bd77632ed04 Author: 琚致远 AuthorDate: Wed Aug 19 11:20:48 2020 +0800 feat(doc): update deploy manually doc --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5f82c63..36b4f62 100644 --- a/README.md +++ b/README.md @@ -92,7 +92,7 @@ $ yarn install $ yarn build ``` -5. The bundled files are under `/dist` folder if the step 4 is successful, then we recommend using `nginx` to handle those files, please install `nginx` manually, then refer to the nginx conf `docker/nginx.conf`. +5. The bundled files are under `/dist` folder if the step 4 is successful, then we recommend using `nginx` to handle those files, please install `nginx` manually, then refer to the nginx conf `compose/dashboard_conf/nginx.conf`. 6. Move files under `dist` folder to nginx's default html folder, then visit `http://127.0.0.1` in your browser. ## Development
[GitHub] [apisix] gxthrj commented on issue #2070: request help: can not running pod in k8s，Readiness probe failed: dial tcp 10.244.0.54:9080: connect: connection refused
gxthrj commented on issue #2070: URL: https://github.com/apache/apisix/issues/2070#issuecomment-675814928 It is very strange, apisix on `note2` started successfully, but apisix on the other two nodes failed to start, please check the local apisix image of the other two nodes to make sure it is the latest version. also, please change `imagePullPolicy: IfNotPresent` to `imagePullPolicy: Always`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #2075: request help: Is 'k8s_deployment_info' in upstream supported in latest few versions?
membphis closed issue #2075: URL: https://github.com/apache/apisix/issues/2075 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2075: request help: Is 'k8s_deployment_info' in upstream supported in latest few versions?
membphis commented on issue #2075: URL: https://github.com/apache/apisix/issues/2075#issuecomment-675804609 k8s_deployment_info + ingress controller ，should work together. the `ingress controller` will translate it to real upstream nodes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ShynHan commented on issue #2068: request help: How to ensure the security of the interface for obtaining jwt-auth token?
ShynHan commented on issue #2068: URL: https://github.com/apache/apisix/issues/2068#issuecomment-675801221 @moonming Sorry, witch channel can be use Chinese? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #2062: bug: not find any matched route 404
membphis closed issue #2062: URL: https://github.com/apache/apisix/issues/2062 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] OnlyPiglet commented on issue #2074: prometheus no memory when high qps request help:
OnlyPiglet commented on issue #2074: URL: https://github.com/apache/apisix/issues/2074#issuecomment-675793450 @membphis yes,that's what I am concerned the Lua GC 64 model .MyMemory is 16GB,The Cpu is 4 cores This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] houshunwei opened a new issue #2075: request help: Is 'k8s_deployment_info' in upstream supported in latest few versions?
houshunwei opened a new issue #2075:
URL: https://github.com/apache/apisix/issues/2075
### Issue description
1. I add a route with upstream like this:
```
curl http://10.234.59.13:8880/apisix/admin/routes/1101 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"methods": ["POST", "GET"],
"uri": "/test",
"upstream": {
"type": "roundrobin",
"k8s_deployment_info": {
"namespace": "my-domain",
"deploy_name": "my-deploy",
"backend_type": "pod",
"port": 8001
}
}
}'
```
2. Got `502 Bad Gateway` when request.
when i request `http://{docker-ip}:9080/test`, i got `502 Bad Gateway`.
detail logs in error.log:
```
2020/08/18 23:53:25 [error] 185#185: *31949449 [lua] balancer.lua:254:
load_balancer(): failed to pick server: no valid upstream node while connecting
to upstream, client: 10.233.64.1, server: , request: "GET /test HTTP/1.1"
```
3. No source code for `k8s_deployment_info`
I have tried to find k8s_deployment_info related code. But
k8s_deployment_info only exists in doc and schema_define.lua.
Question：Is 'k8s_deployment_info' in upstream supported in latest few
versions?
### Environment
* apisix version (cmd: `apisix version`): APISIX 1.4
* OS: docker, centos7
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] longshang commented on issue #2066: request help: support sign API
longshang commented on issue #2066: URL: https://github.com/apache/apisix/issues/2066#issuecomment-675502137 > @longshang > Please use English in the public channel, thx OK，thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dualc edited a comment on issue #2062: bug: not find any matched route 404
dualc edited a comment on issue #2062: URL: https://github.com/apache/apisix/issues/2062#issuecomment-675483467 I have met the same problem when used 1.4 version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] powermanlc commented on issue #2062: bug: not find any matched route 404
powermanlc commented on issue #2062: URL: https://github.com/apache/apisix/issues/2062#issuecomment-675496814 > > > using 1.4 version,I have met the same problemn > > > > > > Thanks for your advice. I will compared 1.3 version and 1.4 version code difference. and as quickly as possible upgrade 1.4version. > > sorry，words fail to me，I mean，I have met the same problem when used the 1.4 version，it occurrd random，3% chance to raise，maybe we should try to use 1.5 version thanks，i got it. i solved it by reload nginx. it's very effective. I also encountered 404 problems at 3%, after reload two days no 404 problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2062: bug: not find any matched route 404
membphis commented on issue #2062: URL: https://github.com/apache/apisix/issues/2062#issuecomment-675495530 @dualc https://github.com/apache/apisix/issues/2067#issuecomment-675232331 you can take a look at this, it may help you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2074: prometheus no memory when high qps request help:
membphis commented on issue #2074: URL: https://github.com/apache/apisix/issues/2074#issuecomment-675494088 Do you enabled Lua GC 64 model? And what is the size of your memory? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dualc edited a comment on issue #2062: bug: not find any matched route 404
dualc edited a comment on issue #2062: URL: https://github.com/apache/apisix/issues/2062#issuecomment-675483467 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dualc commented on issue #2062: bug: not find any matched route 404
dualc commented on issue #2062: URL: https://github.com/apache/apisix/issues/2062#issuecomment-675490900 > > using 1.4 version,I have met the same problemn > > Thanks for your advice. I will compared 1.3 version and 1.4 version code difference. and as quickly as possible upgrade 1.4version. sorry，words fail to me，I mean，I have met the same problem when used the 1.4 version，it occurrd random，3% chance to raise，maybe we should try to use 1.5 version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] powermanlc commented on issue #2062: bug: not find any matched route 404
powermanlc commented on issue #2062: URL: https://github.com/apache/apisix/issues/2062#issuecomment-675486287 > using 1.4 version,I have met the same problemn Thanks for your advice. I will compared 1.3 version and 1.4 version code difference. and as quickly as possible upgrade 1.4version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] OnlyPiglet edited a comment on issue #2074: prometheus no memory when high qps request help:
OnlyPiglet edited a comment on issue #2074: URL: https://github.com/apache/apisix/issues/2074#issuecomment-675484892 @membphis there is a flame graph https://user-images.githubusercontent.com/46953658/90519987-562a1380-e19b-11ea-8061-3a0990f2473e.png;> I am not sure if this will be useful to solve this problem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] OnlyPiglet edited a comment on issue #2074: prometheus no memory when high qps request help:
OnlyPiglet edited a comment on issue #2074: URL: https://github.com/apache/apisix/issues/2074#issuecomment-675484892 @membphis there is a fire flame https://user-images.githubusercontent.com/46953658/90519987-562a1380-e19b-11ea-8061-3a0990f2473e.png;> I am not sure if this will be useful to solve this problem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] OnlyPiglet edited a comment on issue #2074: prometheus no memory when high qps request help:
OnlyPiglet edited a comment on issue #2074: URL: https://github.com/apache/apisix/issues/2074#issuecomment-675484892 there is a fire flame https://user-images.githubusercontent.com/46953658/90519987-562a1380-e19b-11ea-8061-3a0990f2473e.png;> I am not sure if this will be useful to solve this problem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] OnlyPiglet commented on issue #2074: prometheus no memory when high qps request help:
OnlyPiglet commented on issue #2074: URL: https://github.com/apache/apisix/issues/2074#issuecomment-675484892 there is a fire flame https://user-images.githubusercontent.com/46953658/90519987-562a1380-e19b-11ea-8061-3a0990f2473e.png;> I am not sure if this will be helpful This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dualc edited a comment on issue #2062: bug: not find any matched route 404
dualc edited a comment on issue #2062: URL: https://github.com/apache/apisix/issues/2062#issuecomment-675483467 using 1.4 version,I have met the same problemn This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dualc commented on issue #2062: bug: not find any matched route 404
dualc commented on issue #2062: URL: https://github.com/apache/apisix/issues/2062#issuecomment-675483467 using 4.4 version,I have met the same problemn This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] OnlyPiglet commented on issue #1510: request help:
OnlyPiglet commented on issue #1510: URL: https://github.com/apache/apisix/issues/1510#issuecomment-675478698 @membphis thanks a lot This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] OnlyPiglet closed issue #1510: request help:
OnlyPiglet closed issue #1510: URL: https://github.com/apache/apisix/issues/1510 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] OnlyPiglet commented on issue #2074: prometheus no memory when high qps request help:
OnlyPiglet commented on issue #2074: URL: https://github.com/apache/apisix/issues/2074#issuecomment-675474865 we cloudn't add the limit of lua or luajit right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] OnlyPiglet edited a comment on issue #2074: prometheus no memory when high qps request help:
OnlyPiglet edited a comment on issue #2074: URL: https://github.com/apache/apisix/issues/2074#issuecomment-675473410 @membphis I sorry I have destory the colud server, this is the only info about this error,the error link the file of promethues/exporter.lua ``core.table.concat(prometheus:metric_data())`` ``` shell lua entry thread aborted: memory allocation error: not enough memory ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] OnlyPiglet edited a comment on issue #2074: prometheus no memory when high qps request help:
OnlyPiglet edited a comment on issue #2074: URL: https://github.com/apache/apisix/issues/2074#issuecomment-675473410 @membphis I sorry I have destory the colud server, this is the only info about this error,the error link the file of promethues/exporter.lua table.contact(peometheus:merics_data()) ``` shell lua entry thread aborted: memory allocation error: not enough memory ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] OnlyPiglet commented on issue #2074: prometheus no memory when high qps request help:
OnlyPiglet commented on issue #2074: URL: https://github.com/apache/apisix/issues/2074#issuecomment-675473410 @membphis I sorry I have destory the colud server, this is the only info about this error,the error link the file of promethues/exporter.lua table.contact(peometheus:merics_data()) ``` lua entry thread aborted: memory allocation error: not enough memory ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2074: prometheus no memory when high qps request help:
membphis commented on issue #2074: URL: https://github.com/apache/apisix/issues/2074#issuecomment-675471859 please provide a full error log. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] OnlyPiglet opened a new issue #2074: prometheus no memory when high qps request help:
OnlyPiglet opened a new issue #2074: URL: https://github.com/apache/apisix/issues/2074 ### Issue description when at a high qps scene, the promethues will report a error about the exporter no memory allocted table.contact(peometheus:merics_data()) ### Environment * apisix version (cmd: `apisix version`): * OS: centos 7.7 64 位 it seem's the reason is the limit of luajit or lua itself,how can I solve this.thanks for helping This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis edited a comment on issue #1942: request help: benchmark with Envoy and other gateways
membphis edited a comment on issue #1942: URL: https://github.com/apache/apisix/issues/1942#issuecomment-675461890 article: https://segmentfault.com/a/119023671822 gist: https://gist.github.com/aifeiasdf/9fc4585f6404e3a0a70c568c2a14b9c9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #1942: request help: benchmark with Envoy and other gateways
membphis commented on issue #1942: URL: https://github.com/apache/apisix/issues/1942#issuecomment-675461890 https://gist.github.com/aifeiasdf/9fc4585f6404e3a0a70c568c2a14b9c9 https://segmentfault.com/a/119023671822 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #1942: request help: benchmark with Envoy and other gateways
membphis closed issue #1942: URL: https://github.com/apache/apisix/issues/1942 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: chore: should improve the prometheus metric naming (#2073)
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 36bb0a8 chore: should improve the prometheus metric naming (#2073)
36bb0a8 is described below
commit 36bb0a8d3ebe12d9425e33e273371770450d3e60
Author: 罗泽轩
AuthorDate: Tue Aug 18 20:42:05 2020 +0800
chore: should improve the prometheus metric naming (#2073)
By looking at name like `apisix_bandwidth` or `apisix_http_latency`,
it is hard to guess their units. Also, it is not so clear for where does
the overhead come from for `apisix_http_overhead` at the first glance.
---
apisix/plugins/prometheus/exporter.lua | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/apisix/plugins/prometheus/exporter.lua
b/apisix/plugins/prometheus/exporter.lua
index 82ccf45..6547456 100644
--- a/apisix/plugins/prometheus/exporter.lua
+++ b/apisix/plugins/prometheus/exporter.lua
@@ -69,6 +69,14 @@ function _M.init()
clear_tab(metrics)
+-- Newly added metrics should follow the naming best pratices described in
+-- https://prometheus.io/docs/practices/naming/#metric-names
+-- For example,
+-- 1. Add unit as the suffix
+-- 2. Add `_total` as the suffix if the metric type is counter
+-- 3. Use base unit
+-- We keep the old metric names for the compatibility.
+
-- across all services
prometheus = base_prometheus.init("prometheus-metrics", "apisix_")
metrics.connections = prometheus:gauge("nginx_http_current_connections",
@@ -93,11 +101,12 @@ function _M.init()
{"code", "route", "service", "node"})
metrics.latency = prometheus:histogram("http_latency",
-"HTTP request latency per service in APISIX",
+"HTTP request latency in milliseconds per service in APISIX",
{"type", "service", "node"}, DEFAULT_BUCKETS)
metrics.overhead = prometheus:histogram("http_overhead",
-"HTTP request overhead per service in APISIX",
+"HTTP request overhead added by APISIX in milliseconds per service " ..
+"in APISIX",
{"type", "service", "node"}, DEFAULT_BUCKETS)
metrics.bandwidth = prometheus:counter("bandwidth",
[GitHub] [apisix] membphis merged pull request #2073: chore: should improve the prometheus metric naming
membphis merged pull request #2073: URL: https://github.com/apache/apisix/pull/2073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #1971: bugfix: create the health checker in `access` phase, allow to call `y…
membphis commented on a change in pull request #1971:
URL: https://github.com/apache/apisix/pull/1971#discussion_r472149623
##
File path: apisix/upstream.lua
##
@@ -52,41 +60,112 @@ end
_M.set = set_directly
+local function create_checker(upstream, healthcheck_parent)
+if healthcheck == nil then
+healthcheck = require("resty.healthcheck")
+end
+local checker = healthcheck.new({
+name = "upstream#" .. healthcheck_parent.key,
+shm_name = "upstream-healthcheck",
+checks = upstream.checks,
+})
+
+local host = upstream.checks and upstream.checks.active
+ and upstream.checks.active.host
+local port = upstream.checks and upstream.checks.active
+ and upstream.checks.active.port
+for _, node in ipairs(upstream.nodes) do
+local ok, err = checker:add_target(node.host, port or node.port, host)
+if not ok then
+core.log.error("failed to add new health check target: ",
+ node.host, ":", port or node.port, " err: ", err)
+end
+end
+
+if upstream.parent then
+core.table.insert(upstream.parent.clean_handlers, function ()
+core.log.info("try to release checker: ", tostring(checker))
+checker:stop()
+end)
+
+else
+core.table.insert(healthcheck_parent.clean_handlers, function ()
+core.log.info("try to release checker: ", tostring(checker))
+checker:stop()
+end)
+end
+
+core.log.info("create new checker: ", tostring(checker))
+return checker
+end
+
+
+local function fetch_healthchecker(upstream, healthcheck_parent, version)
+if not upstream.checks then
+return
+end
+
+local checker = lrucache_checker(upstream, version,
+ create_checker, upstream,
+ healthcheck_parent)
+return checker
+end
+
+
function _M.set_by_route(route, api_ctx)
if api_ctx.upstream_conf then
core.log.warn("upstream node has been specified, ",
"cannot be set repeatedly")
-return true
+return
end
local up_id = route.value.upstream_id
if up_id then
if not upstreams then
-return false, "need to create a etcd instance for fetching "
+return 500, "need to create a etcd instance for fetching "
.. "upstream information"
end
local up_obj = upstreams:get(tostring(up_id))
if not up_obj then
-return false, "failed to find upstream by id: " .. up_id
+return 500, "failed to find upstream by id: " .. up_id
end
core.log.info("upstream: ", core.json.delay_encode(up_obj))
local up_conf = up_obj.dns_value or up_obj.value
set_directly(api_ctx, up_conf.type .. "#upstream_" .. up_id,
up_obj.modifiedIndex, up_conf, up_obj)
-return true
+return
end
local up_conf = (route.dns_value and route.dns_value.upstream)
or route.value.upstream
if not up_conf then
-return false, "missing upstream configuration in Route or Service"
+return 500, "missing upstream configuration in Route or Service"
+end
+
+if up_conf.service_name then
+if not discovery then
+return 500, "discovery is uninitialized"
+end
+up_conf.nodes = discovery.nodes(up_conf.service_name)
end
set_directly(api_ctx, up_conf.type .. "#route_" .. route.value.id,
api_ctx.conf_version, up_conf, route)
-return true
+
+local nodes_count = up_conf.nodes and #up_conf.nodes or 0
+if nodes_count == 0 then
+return 502, "no valid upstream node"
+end
+
+if nodes_count > 1 then
+local checker = fetch_healthchecker(up_conf, route,
Review comment:
we can add this in new PR ^_^
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)
membphis commented on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-675453728 @backnero you need to provide the parameter of route and SSL object. then we can use it directly. we need a way to reproduce this issue for fixing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis removed a comment on issue #2045: bug: config of plugin `key-auth` for consumer shouldn't be empty
membphis removed a comment on issue #2045: URL: https://github.com/apache/apisix/issues/2045#issuecomment-672982410 you should use `markdown` way. take a look at this issue: https://github.com/apache/apisix/issues/2050#issue-677813921  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #2060: bug: got 500 response when PUT new upstream
membphis closed issue #2060: URL: https://github.com/apache/apisix/issues/2060 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: feature: divide config.yaml into two files config-custom.yaml & confi… (#2023)
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new cf882bd feature: divide config.yaml into two files config-custom.yaml
& confi… (#2023)
cf882bd is described below
commit cf882bda1e36abf00f57cbaeb9a77ddaa7edf8a7
Author: YuanSheng Wang
AuthorDate: Tue Aug 18 20:18:55 2020 +0800
feature: divide config.yaml into two files config-custom.yaml & confi…
(#2023)
* feature: divide config.yaml into two files config-custom.yaml &
config-default.yaml .
fix #1923
---
.travis/apisix_cli_test.sh | 46 +--
.travis/linux_apisix_master_luarocks_runner.sh | 6 +-
.travis/linux_openresty_mtls_runner.sh | 17 ++-
Makefile | 1 +
apisix/core.lua| 5 +-
apisix/core/config_local.lua | 108 ++-
bin/apisix | 68 +-
conf/{config.yaml => config-default.yaml} | 5 +
conf/config.yaml | 175 +
doc/architecture-design.md | 26 ++--
doc/plugin-develop.md | 4 +-
doc/zh-cn/architecture-design.md | 25 ++--
doc/zh-cn/plugin-develop.md| 4 +-
t/APISIX.pm| 27 ++--
t/admin/stream-routes-disable.t| 23 +---
t/admin/token.t| 20 +--
t/config-center-yaml/route-service.t | 19 +--
t/config-center-yaml/route-upstream.t | 19 +--
t/config-center-yaml/route.t | 19 +--
t/core/config-default.t| 93 +
t/core/config.t| 7 +-
t/core/profile.t | 14 +-
t/debug/debug-mode.t | 17 +--
t/discovery/eureka.t | 43 +++---
t/node/rr-balance.t| 9 --
t/node/upstream-node-dns.t | 23 +---
t/plugin/example.t | 3 +-
t/router/radixtree-host-uri.t | 20 +--
t/router/radixtree-host-uri2.t | 24 ++--
t/router/radixtree-uri-host.t | 24
t/router/radixtree-uri-keep-end-slash.t| 20 +--
t/router/radixtree-uri-multiple.t | 22
t/router/radixtree-uri-priority.t | 19 ---
t/router/radixtree-uri-sanity.t| 28
34 files changed, 460 insertions(+), 523 deletions(-)
diff --git a/.travis/apisix_cli_test.sh b/.travis/apisix_cli_test.sh
index 020a90a..bfa3ce3 100755
--- a/.travis/apisix_cli_test.sh
+++ b/.travis/apisix_cli_test.sh
@@ -47,7 +47,11 @@ fi
echo "passed: nginx.conf file contains reuseport configuration"
# check default ssl port
-sed -i 's/listen_port: 9443/listen_port: 8443/g' conf/config.yaml
+echo "
+apisix:
+ssl:
+listen_port: 8443
+" > conf/config.yaml
make init
@@ -66,8 +70,7 @@ fi
echo "passed: change default ssl port"
# check nameserver imported
-
-sed -i '/dns_resolver:/,+4s/^/#/' conf/config.yaml
+git checkout conf/config.yaml
make init
@@ -82,11 +85,15 @@ do
fi
done
-sed -i '/dns_resolver:/,+4s/^#//' conf/config.yaml
echo "passed: system nameserver imported"
# enable enable_dev_mode
-sed -i 's/enable_dev_mode: false/enable_dev_mode: true/g' conf/config.yaml
+git checkout conf/config.yaml
+
+echo "
+apisix:
+enable_dev_mode: true
+" > conf/config.yaml
make init
@@ -102,9 +109,11 @@ if [ $count -ne 0 ]; then
exit 1
fi
-git checkout conf/config.yaml
+echo "passed: enable enable_dev_mode"
+
+# check whether the 'worker_cpu_affinity' is in nginx.conf
-# check whether the 'worker_cpu_affinity' is in nginx.conf .
+git checkout conf/config.yaml
make init
@@ -118,8 +127,13 @@ echo "passed: nginx.conf file contains worker_cpu_affinity
configuration"
# check admin https enabled
-sed -i 's/\# port_admin: 9180/port_admin: 9180/' conf/config.yaml
-sed -i 's/\# https_admin: true/https_admin: true/' conf/config.yaml
+git checkout conf/config.yaml
+
+echo "
+apisix:
+port_admin: 9180
+https_admin: true
+" > conf/config.yaml
make init
@@ -137,14 +151,13 @@ if [ ! $code -eq 200 ]; then
exit 1
fi
+make stop
+
echo "passed: admin https enabled"
# rollback to the default
-make stop
-
-sed -i 's/port_admin: 9180/\# port_admin: 9180/' conf/config.yaml
-sed -i 's/https_admin: true/\# https_admin: true/' conf/config.yaml
+git checkout conf/config.yaml
make init
@@ -174,7 +187,12 @@ echo "passed: worker_shutdown_timeout in nginx.conf is ok"
# check worker processes number is configurable.
-sed -i 's/worker_processes:
[GitHub] [apisix] membphis closed issue #1923: feature: Divide config.yaml into two files config-custom.yaml & config-default.yaml
membphis closed issue #1923: URL: https://github.com/apache/apisix/issues/1923 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis merged pull request #2023: feature: divide config.yaml into two files config-custom.yaml & confi…
membphis merged pull request #2023: URL: https://github.com/apache/apisix/pull/2023 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #2073: chore: should improve the prometheus metric naming
spacewander opened a new pull request #2073: URL: https://github.com/apache/apisix/pull/2073 By looking at name like `apisix_bandwidth` or `apisix_http_latency`, it is hard to guess their units. Also, it is not so clear for where does the overhead come from for `apisix_http_overhead` at the first glance. ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2070: request help: can not running pod in k8s，Readiness probe failed: dial tcp 10.244.0.54:9080: connect: connection refused
membphis commented on issue #2070: URL: https://github.com/apache/apisix/issues/2070#issuecomment-675371726 it seems that you are using the latest `conf/config.yaml` file + old APISIX . you can update the APISIX or remove the plugin `request-id` . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhoujun24 edited a comment on issue #1991: request help: grpc-transcode plugin converts http/json parameters abnormally
zhoujun24 edited a comment on issue #1991:
URL: https://github.com/apache/apisix/issues/1991#issuecomment-675215902
@nic-chen Hello, When will this issue be fixed?
1. The grpc-transcode plugin, after the protocol conversion, the parameters
obtained by the back-end service are inconsistent with the HTTP request
parameters.
2. The response defined in .proto is a repeated string type. When the
backend response data is empty, the HTTP response data becomes {}, which should
be []. You can see in the previous Issue description
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zhoujun24 edited a comment on issue #1991: request help: grpc-transcode plugin converts http/json parameters abnormally
zhoujun24 edited a comment on issue #1991:
URL: https://github.com/apache/apisix/issues/1991#issuecomment-675215902
@nic-chen Hello, When will this issue be fixed?
1. The grpc-transcode plugin, after the protocol conversion, the parameters
obtained by the back-end service are inconsistent with the http request
parameters.
2. The response defined in .proto is a repeated string type. When the
backend response data is empty, the http response data becomes {}, which should
be []. You can see in the previous Issue description
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2071: request help: What is hosts in route?
membphis commented on issue #2071: URL: https://github.com/apache/apisix/issues/2071#issuecomment-675361027 1. please update your APISIX to latest version 1.5 2. the `域名` means the field which named `host`. it is the host of client request. ``` # curl http://127.0.0.1:9080/hello -H "host: foo.com" in this case, the host is foo.com ``` https://github.com/apache/apisix/blob/master/doc/admin-api.md#route  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #2071: request help: What is hosts in route?
membphis closed issue #2071: URL: https://github.com/apache/apisix/issues/2071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aifeiasdf commented on issue #953: request help: Any plan for supporting the SM1/SM2/SM3/SM4 cryptographic algorithm?
aifeiasdf commented on issue #953: URL: https://github.com/apache/apisix/issues/953#issuecomment-675321974 > I am not an expert of SMx algorithms. But it seems that @toruneko's https://github.com/toruneko/lua-resty-crypto supports them, though it doesn't detect if the OpenSSL version is high enough. It seem that this project can only do smX compute on L7 application, if I want to do smx handshake on L4 handshake, I have to implement extra C code on Nginx C module This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming opened a new issue #2072: upgrade skywalking plugin to support skywalking 8.0
moonming opened a new issue #2072: URL: https://github.com/apache/apisix/issues/2072 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] csh995426531 commented on issue #2070: request help: can not running pod in k8s，Readiness probe failed: dial tcp 10.244.0.54:9080: connect: connection refused
csh995426531 commented on issue #2070: URL: https://github.com/apache/apisix/issues/2070#issuecomment-675315384 apisix/logs/error.log content is  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
