[GitHub] [apisix] gy09535 commented on pull request #2121: fix: limit count config not effective

[GitBox]

gy09535 commented on pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#issuecomment-681575628


   > @gy09535 please add test cases, thx
   added



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] wanghuashun commented on issue #416: after update master, login return error again

[GitBox]

wanghuashun commented on issue #416:
URL: 
https://github.com/apache/apisix-dashboard/issues/416#issuecomment-681573089


   前端的请求有问题 
   src\pages\User\components\LoginMethodPassword.tsx
   98行
const result = await request('/user/login',
   改成  const result = await request('http://192.168.3.124:8000/user/login',
   http://192.168.3.124:8080 后端(go)的api地址 之后就好了



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] wanghuashun commented on issue #416: after update master, login return error again

[GitBox]

wanghuashun commented on issue #416:
URL: 
https://github.com/apache/apisix-dashboard/issues/416#issuecomment-681568512


   我前天就遇见了  解决了   登陆不上是因为前端的一个地方。   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] wanghuashun removed a comment on issue #416: after update master, login return error again

[GitBox]

wanghuashun removed a comment on issue #416:
URL: 
https://github.com/apache/apisix-dashboard/issues/416#issuecomment-681568512


   我前天就遇见了  解决了   登陆不上是因为前端的一个地方。   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #416: after update master, login return error again

[GitBox]

juzhiyuan commented on issue #416:
URL: 
https://github.com/apache/apisix-dashboard/issues/416#issuecomment-681465390


   @bzp2010 would involve this issue :D 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2001: add ewma balancer

[GitBox]

moonming commented on pull request #2001:
URL: https://github.com/apache/apisix/pull/2001#issuecomment-681348703


   I will help to fix license issue after this PR merged.
   
   Thanks,
   Ming Wen
   Twitter: _WenMing
   
   
   redynasc  于2020年8月27日周四 上午10:52写道：
   
   > the license issue is not fixed, which is MUST fixed before next release.
   > I added the "Apache ApiSix Subcomponent" section to the license file
   > I don't know how to solve this problem and need help
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis closed issue #2088: request help: Update plugin's schema fault-injection

[GitBox]

membphis closed issue #2088:
URL: https://github.com/apache/apisix/issues/2088


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated: plugin(fault-injection): use draft7 way to rewrite the JSON Schema. (#2105)

[membphis]

This is an automated email from the ASF dual-hosted git repository.

membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 4d5ecc1  plugin(fault-injection): use draft7 way to rewrite the JSON 
Schema. (#2105)
4d5ecc1 is described below

commit 4d5ecc1a4001d3c511f0f540076561aa8cd53d03
Author: YuanSheng Wang 
AuthorDate: Thu Aug 27 11:47:04 2020 +0800

plugin(fault-injection): use draft7 way to rewrite the JSON Schema. (#2105)

fix #2088
---
 apisix/plugins/fault-injection.lua   | 7 +--
 doc/plugins/fault-injection.md   | 4 ++--
 doc/zh-cn/plugins/fault-injection.md | 8 
 3 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/apisix/plugins/fault-injection.lua 
b/apisix/plugins/fault-injection.lua
index 3e72494..8484352 100644
--- a/apisix/plugins/fault-injection.lua
+++ b/apisix/plugins/fault-injection.lua
@@ -19,6 +19,7 @@ local sleep = ngx.sleep
 
 local plugin_name   = "fault-injection"
 
+
 local schema = {
 type = "object",
 properties = {
@@ -28,19 +29,20 @@ local schema = {
 http_status = {type = "integer", minimum = 200},
 body = {type = "string", minLength = 0},
 },
-required = {"http_status"}
+minProperties = 1,
 },
 delay = {
 type = "object",
 properties = {
 duration = {type = "number", minimum = 0},
 },
-required = {"duration"}
+minProperties = 1,
 }
 },
 minProperties = 1,
 }
 
+
 local _M = {
 version = 0.1,
 priority = 11000,
@@ -48,6 +50,7 @@ local _M = {
 schema = schema,
 }
 
+
 function _M.check_schema(conf)
 local ok, err = core.schema.check(schema, conf)
 if not ok then
diff --git a/doc/plugins/fault-injection.md b/doc/plugins/fault-injection.md
index 30ab7db..f2e9681 100644
--- a/doc/plugins/fault-injection.md
+++ b/doc/plugins/fault-injection.md
@@ -27,9 +27,9 @@ Fault injection plugin, this plugin can be used with other 
plugins and will be e
 
 |Name  |Requirement  |Description|
 |--- |-|--|
-|abort.http_status|required|user-specified http code returned to the client|
+|abort.http_status|optional|user-specified http code returned to the client|
 |abort.body|optional|response data returned to the client|
-|delay.duration|required|delay time(can be decimal)|
+|delay.duration|optional|delay time(can be decimal)|
 
 Note: `abort` and `delay` must have at least one.
 
diff --git a/doc/zh-cn/plugins/fault-injection.md 
b/doc/zh-cn/plugins/fault-injection.md
index e5d8b3b..9274173 100644
--- a/doc/zh-cn/plugins/fault-injection.md
+++ b/doc/zh-cn/plugins/fault-injection.md
@@ -27,11 +27,11 @@
 
 |名称|必须|描述|
 |--- |-|--|
-|abort.http_status|是|返回给客户端的 http 状态码|
-|abort.body|否|返回给客户端的响应数据|
-|delay.duration|是|延迟时间，可以指定小数|
+|abort.http_status|可选|返回给客户端的 http 状态码|
+|abort.body|可选|返回给客户端的响应数据|
+|delay.duration|可选|延迟时间，可以指定小数|
 
-注：参数 abort 和 delay 至少要存在一个
+注：参数 abort 和 delay 至少要存在一个。
 
 ## 示例
 

[GitHub] [apisix] membphis merged pull request #2105: plugin(fault-injection): use draft7 way to rewrite the JSON Schema.

[GitBox]

membphis merged pull request #2105:
URL: https://github.com/apache/apisix/pull/2105


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2105: plugin(fault-injection): use draft7 way to rewrite the JSON Schema.

[GitBox]

membphis commented on a change in pull request #2105:
URL: https://github.com/apache/apisix/pull/2105#discussion_r478058278



##
File path: apisix/plugins/fault-injection.lua
##
@@ -28,26 +29,28 @@ local schema = {
 http_status = {type = "integer", minimum = 200},
 body = {type = "string", minLength = 0},

Review comment:
   we do not need default value. the default `http_status` is `200` for 
nginx.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] redynasc removed a comment on pull request #2001: add ewma balancer

[GitBox]

redynasc removed a comment on pull request #2001:
URL: https://github.com/apache/apisix/pull/2001#issuecomment-681312416


   > the license issue is not fixed, which is MUST fixed before next release.
   I added the "Apache ApiSix Subcomponent" section to the license file
   I don't know how to solve this problem and need help



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] redynasc commented on pull request #2001: add ewma balancer

[GitBox]

redynasc commented on pull request #2001:
URL: https://github.com/apache/apisix/pull/2001#issuecomment-681312612


   > the license issue is not fixed, which is MUST fixed before next release.
   
   I added the "Apache ApiSix Subcomponent" section to the license file
   I don't know how to solve this problem and need help



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] redynasc commented on pull request #2001: add ewma balancer

[GitBox]

redynasc commented on pull request #2001:
URL: https://github.com/apache/apisix/pull/2001#issuecomment-681312416


   > the license issue is not fixed, which is MUST fixed before next release.
   I added the "Apache ApiSix Subcomponent" section to the license file
   I don't know how to solve this problem and need help



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] imjoey commented on issue #416: after update master, login return error again

[GitBox]

imjoey commented on issue #416:
URL: 
https://github.com/apache/apisix-dashboard/issues/416#issuecomment-681311381


   > Looks like the manager api couldn't connect the MySQL because of incorrect 
username or password, please check.
   > 
   > BTW, we are planning to use other lightweight DB to replace MySQL, it will 
take some time to finish this work.
   
   @juzhiyuan Could you please elaborate which lightweight DB will be the 
alternative, as well as the reason? Maybe we could help, with pleasure.  
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] gxthrj opened a new issue #2126: [DISCUSS]How do we control `host delivery`

[GitBox]

gxthrj opened a new issue #2126:
URL: https://github.com/apache/apisix/issues/2126


   ### Issue description
   
   - Questions
   
   We know that APISIX will pass the request host to upstream by default, and 
the host can be rewritten through the `proxy-rewrite` plugin, but in some 
scenarios, this makes it difficult for us to use.
   
   - Suggestions
   
   The processing of the host by the gateway is roughly divided into three 
situations:
   1. Pass the host.
   2. Do not pass host.
   3. Rewrite host.
   
   The first and second points are two very common situations. 
   the last point is very special, we can realized by `proxy-rewrite` plugin.
   
   Whether to transfer host is more like a mark, which acts on route or 
upstream, we need a switch to control it conveniently.
   
   ### Environment
   
   * apisix version : 1.5
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #416: after update master, login return error again

[GitBox]

juzhiyuan commented on issue #416:
URL: 
https://github.com/apache/apisix-dashboard/issues/416#issuecomment-681308868


   Looks like the manager api couldn't connect the MySQL because of incorrect 
username or password, please check.
   
   BTW, we are planning to use other lightweight DB to replace MySQL, it will 
take some time to finish this work.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #415: Feat:added pluginChart

[GitBox]

juzhiyuan merged pull request #415:
URL: https://github.com/apache/apisix-dashboard/pull/415


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran opened a new issue #416: after update master, login return error again

[GitBox]

liuxiran opened a new issue #416:
URL: https://github.com/apache/apisix-dashboard/issues/416


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirements
   - [ ] Feature or performance improvement
   - [ ] Other
   
   ___
   ### Question
   - What do you want to know?
   
   ___
   ### Bug
   - Which version of Apache APISIX Dashboard, OS and Broswer?
   latest master branch
   
   
   
   - What happened?
   If possible, provide a way to reproduce the error.
   
   [test case]:
   
   1. use docker-compose to develop project,  use admin/admin to login
   
   1. return error
   
   request info:
   
   
   ![2020-08-27 
10-06-40屏幕截图](https://user-images.githubusercontent.com/2561857/91375605-baa93a80-e84d-11ea-80d3-43c03641b402.png)
   
   ![2020-08-27 
10-07-14屏幕截图](https://user-images.githubusercontent.com/2561857/91375572-a2392000-e84d-11ea-9d91-99fc710ce87e.png)
   
   and at the same time, the dashboard_manager docker container has been 
restarting
   ![2020-08-27 
10-09-31屏幕截图](https://user-images.githubusercontent.com/2561857/91375740-0cea5b80-e84e-11ea-804f-df1ddc320105.png)
   
   logs：
   ![2020-08-27 
10-15-27屏幕截图](https://user-images.githubusercontent.com/2561857/91375828-41f6ae00-e84e-11ea-8017-de0f184331b7.png)
   
   
   
   
   ___
   ### Requirement or improvement
   - Please describe your requirements or improvement suggestions.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan opened a new issue #69: update header logo

[GitBox]

juzhiyuan opened a new issue #69:
URL: https://github.com/apache/apisix-website/issues/69


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #415: Feat:added pluginChart

[GitBox]

juzhiyuan commented on pull request #415:
URL: https://github.com/apache/apisix-dashboard/pull/415#issuecomment-681251995


   You should add some NOTICE like this one[1] for custom dependencies(plugin & 
ui & chart)
   
   [1] https://github.com/apache/apisix-dashboard/blob/master/LICENSE#L227
   [2] 
https://github.com/apache/apisix-dashboard/blob/master/licenses/LICENSE-dag-to-lua.txt



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #415: Feat:added pluginChart

[GitBox]

juzhiyuan commented on a change in pull request #415:
URL: https://github.com/apache/apisix-dashboard/pull/415#discussion_r477875175



##
File path: src/pages/Route/components/Step3/index.tsx
##
@@ -0,0 +1,54 @@
+import React, { useState } from 'react';
+import { Radio, Tooltip } from 'antd';
+import { QuestionCircleOutlined } from '@ant-design/icons';
+import { isChrome } from 'react-device-detect';
+import { PluginPage, PluginPageType } from '@api7-dashboard/plugin';
+import PluginChart from '@api7-dashboard/pluginchart';
+
+type Props = {
+  data: PluginPageType.PluginData;
+  onChange(data: PluginPageType.PluginData): void;
+};
+
+type Mode = 'NORMAL' | 'DRAW';
+
+const Page: React.FC = ({ data, onChange }) => {
+  const { plugins = {}, script = {} } = data;
+
+  // NOTE: Currently only compatible with chrome
+  const type = Object.keys(script).length === 0 || !isChrome ? 'NORMAL' : 
'DRAW';
+  const [mode, setMode] = useState(type);
+
+  return (
+<>
+  
+ {
+setMode(e.target.value);
+  }}
+>
+  普通模式
+  
+插件编排
+  
+
+{Boolean(!isChrome) && (
+  
+

Review comment:
   NOTE: i18n would be added in the later PR @moonming 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #415: Feat:added pluginChart

[GitBox]

LiteSun opened a new pull request #415:
URL: https://github.com/apache/apisix-dashboard/pull/415


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   added pluginChart



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on a change in pull request #2092: bug: removed default access token for Admin API.

[GitBox]

moonming commented on a change in pull request #2092:
URL: https://github.com/apache/apisix/pull/2092#discussion_r477824853



##
File path: .travis/apisix_cli_test.sh
##
@@ -23,7 +23,14 @@
 
 set -ex
 
-git checkout conf/config.yaml
+cat > conf/config.yaml < conf/config.yaml <

[GitHub] [apisix] moonming commented on a change in pull request #2092: bug: removed default access token for Admin API.

[GitBox]

moonming commented on a change in pull request #2092:
URL: https://github.com/apache/apisix/pull/2092#discussion_r477822484



##
File path: conf/config.yaml
##
@@ -21,3 +21,13 @@
 # host:
 #   - "http://127.0.0.1:2379;
 #
+#
+# If you want specify the Admin API token, this is an example:
+#
+# apisix:
+# admin_key:
+# -
+# name: "admin"
+# key:  **# <-- replace with a random key

Review comment:
   how about empty? user don't know `**` is invalid key.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2121: fix: limit count config not effective

[GitBox]

moonming commented on pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#issuecomment-681198918


   @gy09535 please add test cases, thx



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

moonming commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-681198221


   > No, apisix and etcd will not in the same machine. Shuyang Wu 
 于 2020年8月26日周三 下午9:51写道：
   > […](#)
   > *@Yiyiyimu* commented on this pull request. -- 
In apisix/core/etcd.lua <[#2036 
(comment)](https://github.com/apache/apisix/pull/2036#discussion_r477316914)>: 
> local _M = {version = 0.1} +local prefix_v3 = { + ["3.5"] = "/v3", + ["3.4"] 
= "/v3", + ["3.3"] = "/v3beta", + ["3.2"] = "/v3alpha", +} + + +-- TODO: 
Default lua-resty-etcd version auto-detection is broken, so directly get 
version from cmd +-- we don't need to call this so many times, need to save it 
in some place +local function etcd_version_from_cmd() + local cmd = "export 
ETCDCTL_API=3 && etcdctl version" etcdctl would be installed alongside with 
etcd — You are receiving this because you were mentioned. Reply to this email 
directly, view it on GitHub <[#2036 
(comment)](https://github.com/apache/apisix/pull/2036#discussion_r477316914)>, 
or unsubscribe 

 .
   
   I created  a new issue for this: 
https://github.com/apache/apisix/issues/2125, CI should be adjusted to find 
such problems



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming opened a new issue #2125: request help: move etcd cluster in docker for CI

[GitBox]

moonming opened a new issue #2125:
URL: https://github.com/apache/apisix/issues/2125


   The Apache APISIX node and etcd are deployed on the same machine in CI. 
   But in actual user environment, these two are deployed separately. We need 
to deploy Apache APISIX nodes and etcd cluster separately in CI, so as to be 
closer to the real environment and to find more potential bugs



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2079: fix proxy_set_header Host $host may lose port info

[GitBox]

membphis commented on pull request #2079:
URL: https://github.com/apache/apisix/pull/2079#issuecomment-680990053


   > Test case added.
   
   "proxy_set_header Host $host may lose port info, use http_host instead."
   
   we need to add test for this case



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

membphis commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-680972604


   > @membphis it seems I could not directly reply in your comment on "etcd v2 
version".
   > The original implementation should directly use the version detection in 
lua-resty-etcd, but it is somehow not working, as I stated here: [#2036 
(comment)](https://github.com/apache/apisix/pull/2036#discussion_r475052806)
   
   here is another way, you can make a try:
   
   ```
   $ curl http://127.0.0.1:2379/version
   {"etcdserver":"3.2.26","etcdcluster":"3.2.0"}%
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

membphis commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-680969971


   @Yiyiyimu that is another problem. you can take a look at the doc of 
lua-nginx-module: 
https://github.com/openresty/lua-nginx-module#cosockets-not-available-everywhere



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu edited a comment on pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

Yiyiyimu edited a comment on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-680966931


   @membphis it seems I could not directly reply in your comment on "etcd v2 
version".
   The original implementation should directly use the version detection in 
lua-resty-etcd, but it is somehow not working, as I stated here: 
https://github.com/apache/apisix/pull/2036#discussion_r475052806



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-680966931


   @membphis it seems I could not reply to your comment on "etcd v2 version".
   The original implementation should directly use the version detection in 
lua-resty-etcd, but it is somehow not working, as I stated here: 
https://github.com/apache/apisix/pull/2036#discussion_r475052806



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

membphis commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r477402880



##
File path: bin/apisix
##
@@ -870,35 +870,21 @@ local function init_etcd(show_output)
 
 local host_count = #(yaml_conf.etcd.host)
 
--- check whether the user has enabled etcd v2 protocol
-for index, host in ipairs(yaml_conf.etcd.host) do
-uri = host .. "/v2/keys"
-local cmd = "curl -i -m ".. timeout * 2 .. " -o /dev/null -s -w 
%{http_code} " .. uri
-local res = excute_cmd(cmd)
-if res == "404" then
-io.stderr:write(string.format("failed: please make sure that you 
have enabled the v2 protocol of etcd on %s.\n", host))
-return
-end
-end
-
 local etcd_ok = false
 for index, host in ipairs(yaml_conf.etcd.host) do
 
 local is_success = true
-uri = host .. "/v2/keys" .. (etcd_conf.prefix or "")
 
 for _, dir_name in ipairs({"/routes", "/upstreams", "/services",

Review comment:
   we can remove those `for` code in etcd v3 now, it is useless

##
File path: apisix/core/etcd.lua
##
@@ -15,11 +15,38 @@
 -- limitations under the License.
 --
 local fetch_local_conf = require("apisix.core.config_local").local_conf
-local etcd = require("resty.etcd")
-local clone_tab = require("table.clone")
+local etcd = require("resty.etcd")
+local clone_tab= require("table.clone")
+local io   = io
+local type = type
+local ipairs   = ipairs
+local string   = string
+local tonumber = tonumber
 
 local _M = {version = 0.1}
 
+local prefix_v3 = {
+["3.5"] = "/v3",
+["3.4"] = "/v3",
+["3.3"] = "/v3beta",
+["3.2"] = "/v3alpha",
+}
+
+
+-- TODO: Default lua-resty-etcd version auto-detection is broken, so directly 
get version from cmd
+--  we don't need to call this so many times, need to save it in some 
place
+local function etcd_version_from_cmd()
+local cmd = "export ETCDCTL_API=3 && etcdctl version"

Review comment:
   here is an example code: 
https://github.com/api7/lua-resty-etcd/blob/master/lib/resty/etcd.lua#L17

##
File path: apisix/core/etcd.lua
##
@@ -15,11 +15,38 @@
 -- limitations under the License.
 --
 local fetch_local_conf = require("apisix.core.config_local").local_conf
-local etcd = require("resty.etcd")
-local clone_tab = require("table.clone")
+local etcd = require("resty.etcd")
+local clone_tab= require("table.clone")
+local io   = io
+local type = type
+local ipairs   = ipairs
+local string   = string
+local tonumber = tonumber
 
 local _M = {version = 0.1}
 
+local prefix_v3 = {
+["3.5"] = "/v3",
+["3.4"] = "/v3",
+["3.3"] = "/v3beta",
+["3.2"] = "/v3alpha",
+}
+
+
+-- TODO: Default lua-resty-etcd version auto-detection is broken, so directly 
get version from cmd
+--  we don't need to call this so many times, need to save it in some 
place
+local function etcd_version_from_cmd()
+local cmd = "export ETCDCTL_API=3 && etcdctl version"

Review comment:
   If we only fetch the etcd version, we can use `etcd` v2 library, it 
should work fine.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-680923213


   > No, apisix and etcd will not in the same machine. 
   
   If they are not on the same machine, could etcdctl installed on apisix's 
machine connect to the other machine's etcd?
   
   If not and the only way to connect the other machine's etcd is through gRPC 
gateway, I think I'll some more time on this feature.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r477341702



##
File path: apisix/core/etcd.lua
##
@@ -44,24 +73,143 @@ end
 _M.new = new
 
 
+local function kvs2node(kvs)
+local node = {}
+node.key = kvs.key
+node.value = kvs.value
+node.createdIndex = tonumber(kvs.create_revision)
+node.modifiedIndex = tonumber(kvs.mod_revision)
+return node
+end
+
+
+local function notfound(res)
+res.body.message = "Key not found"
+res.reason = "Not found"
+res.status = 404
+return res
+end
+
+
+function _M.postget(res, realkey)
+if res.body.error == "etcdserver: user name is empty" then
+return nil, "insufficient credentials code: 401"
+end
+
+res.headers["X-Etcd-Index"] = res.body.header.revision
+

Review comment:
   I changed:
   `postget`  ->  `get_res_format`
   `postwatch`  ->  `watch_res_format`
   
   Maybe that would be more readable





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

moonming commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-680909763


   No, apisix and etcd will not in the same machine.
   
   Shuyang Wu  于 2020年8月26日周三 下午9:51写道：
   
   > *@Yiyiyimu* commented on this pull request.
   > --
   >
   > In apisix/core/etcd.lua
   > :
   >
   > >
   >  local _M = {version = 0.1}
   >
   > +local prefix_v3 = {
   > +["3.5"] = "/v3",
   > +["3.4"] = "/v3",
   > +["3.3"] = "/v3beta",
   > +["3.2"] = "/v3alpha",
   > +}
   > +
   > +
   > +-- TODO: Default lua-resty-etcd version auto-detection is broken, so 
directly get version from cmd
   > +--  we don't need to call this so many times, need to save it in 
some place
   > +local function etcd_version_from_cmd()
   > +local cmd = "export ETCDCTL_API=3 && etcdctl version"
   >
   > etcdctl would be installed alongside with etcd
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r477334858



##
File path: apisix/core/etcd.lua
##
@@ -15,11 +15,38 @@
 -- limitations under the License.
 --
 local fetch_local_conf = require("apisix.core.config_local").local_conf
-local etcd = require("resty.etcd")
-local clone_tab = require("table.clone")
+local etcd = require("resty.etcd")
+local clone_tab= require("table.clone")
+local io   = io
+local type = type
+local ipairs   = ipairs
+local string   = string
+local tonumber = tonumber
 
 local _M = {version = 0.1}
 
+local prefix_v3 = {
+["3.5"] = "/v3",
+["3.4"] = "/v3",
+["3.3"] = "/v3beta",
+["3.2"] = "/v3alpha",
+}
+
+
+-- TODO: Default lua-resty-etcd version auto-detection is broken, so directly 
get version from cmd
+--  we don't need to call this so many times, need to save it in some 
place
+local function etcd_version_from_cmd()
+local cmd = "export ETCDCTL_API=3 && etcdctl version"
+local t, err = io.popen(cmd)
+if not t then
+return nil, "failed to execute command: " .. cmd .. ", error info:" .. 
err
+end
+local data = t:read("*all")
+t:close()
+return prefix_v3[data:sub(-4,-2)]
+end
+_M.etcd_version_from_cmd = etcd_version_from_cmd

Review comment:
   Thank you!
   fixed





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r477333950



##
File path: t/core/etcd-auth.t
##
@@ -18,23 +18,28 @@ BEGIN {
 $ENV{"ETCD_ENABLE_AUTH"} = "true"
 }
 
-use t::APISIX 'no_plan';
+use t::APISIX;
 
 repeat_each(1);
 no_long_string();
 no_root_location();
 log_level("info");
 
-# Authentication is enabled at etcd and credentials are set
-system('etcdctl --endpoints="http://127.0.0.1:2379; -u root:5tHkHhYkjr6cQY 
user add root:5tHkHhYkjr6cQY');
-system('etcdctl --endpoints="http://127.0.0.1:2379; -u root:5tHkHhYkjr6cQY 
auth enable');
-system('etcdctl --endpoints="http://127.0.0.1:2379; -u root:5tHkHhYkjr6cQY 
role revoke --path "/*" -rw guest');
+my $etcd_version = `etcdctl version`;
+if ($etcd_version =~ /etcdctl version: 3.2/) {
+plan(skip_all => "skip for etcd version v3.2");
+} else {

Review comment:
   I'm not so sure about this. I couldn't find relevant changes in etcd 
v3.3 CHANGELOG. I did this because 1. the lua-resty-etcd side auth test also 
skips v3.2 and 2. there are errors using the current test in v3.2.
   
   I'm in a hurry these days and I'll fix it later. I think it could be fixed.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r477322262



##
File path: apisix/core/etcd.lua
##
@@ -15,11 +15,38 @@
 -- limitations under the License.
 --
 local fetch_local_conf = require("apisix.core.config_local").local_conf
-local etcd = require("resty.etcd")
-local clone_tab = require("table.clone")
+local etcd = require("resty.etcd")
+local clone_tab= require("table.clone")
+local io   = io
+local type = type
+local ipairs   = ipairs
+local string   = string
+local tonumber = tonumber
 
 local _M = {version = 0.1}
 
+local prefix_v3 = {
+["3.5"] = "/v3",
+["3.4"] = "/v3",
+["3.3"] = "/v3beta",
+["3.2"] = "/v3alpha",

Review comment:
   The official apt source - which is used right now for apisix -  
currently only supports v3.2.x. 
   We could support v3.4 by using etcd github source if needed, but there are 
chances that the etcd deployed in users' environment is below v3.4





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r477318270



##
File path: apisix/core/etcd.lua
##
@@ -44,24 +73,143 @@ end
 _M.new = new
 
 
+local function kvs2node(kvs)
+local node = {}
+node.key = kvs.key
+node.value = kvs.value
+node.createdIndex = tonumber(kvs.create_revision)
+node.modifiedIndex = tonumber(kvs.mod_revision)
+return node
+end
+
+
+local function notfound(res)
+res.body.message = "Key not found"
+res.reason = "Not found"
+res.status = 404
+return res
+end
+
+
+function _M.postget(res, realkey)
+if res.body.error == "etcdserver: user name is empty" then
+return nil, "insufficient credentials code: 401"
+end
+
+res.headers["X-Etcd-Index"] = res.body.header.revision
+

Review comment:
   It is to transfer the etcd v3 output structure to the same as the 
original v2, to keep all the interfaces the same.
   Maybe they need to have a better function name





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r477316914



##
File path: apisix/core/etcd.lua
##
@@ -15,11 +15,38 @@
 -- limitations under the License.
 --
 local fetch_local_conf = require("apisix.core.config_local").local_conf
-local etcd = require("resty.etcd")
-local clone_tab = require("table.clone")
+local etcd = require("resty.etcd")
+local clone_tab= require("table.clone")
+local io   = io
+local type = type
+local ipairs   = ipairs
+local string   = string
+local tonumber = tonumber
 
 local _M = {version = 0.1}
 
+local prefix_v3 = {
+["3.5"] = "/v3",
+["3.4"] = "/v3",
+["3.3"] = "/v3beta",
+["3.2"] = "/v3alpha",
+}
+
+
+-- TODO: Default lua-resty-etcd version auto-detection is broken, so directly 
get version from cmd
+--  we don't need to call this so many times, need to save it in some 
place
+local function etcd_version_from_cmd()
+local cmd = "export ETCDCTL_API=3 && etcdctl version"

Review comment:
   etcdctl would be installed alongside with etcd





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

Yiyiyimu commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r477316456



##
File path: .travis/linux_apisix_current_luarocks_runner.sh
##
@@ -50,7 +50,8 @@ script() {
 sudo service etcd stop
 mkdir -p ~/etcd-data
 /usr/bin/etcd --listen-client-urls 'http://0.0.0.0:2379' 
--advertise-client-urls='http://0.0.0.0:2379' --data-dir ~/etcd-data > 
/dev/null 2>&1 &
-etcd --version
+etcdctl --version
+export ETCDCTL_API=3

Review comment:
   Before etcd v3.4, etcd would use v2 API as default, thus we need to set 
it to v3





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #410: grafana

[GitBox]

juzhiyuan commented on issue #410:
URL: 
https://github.com/apache/apisix-dashboard/issues/410#issuecomment-680875437


   Maybe you are visiting this HTTP website under HTTPS mode? Could you please 
provide more detailed info?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] wanghuashun commented on issue #410: grafana

[GitBox]

wanghuashun commented on issue #410:
URL: 
https://github.com/apache/apisix-dashboard/issues/410#issuecomment-680814910


   可以访问的



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #414: fix(authentication): change login api url

[GitBox]

juzhiyuan merged pull request #414:
URL: https://github.com/apache/apisix-dashboard/pull/414


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: fix(authentication): change login api url (#414)

[juzhiyuan]

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new 9a2cd71  fix(authentication): change login api url (#414)
9a2cd71 is described below

commit 9a2cd719f19d0d73114f8e4ca8f3b4c1b4981747
Author: bzp2010 
AuthorDate: Wed Aug 26 17:34:46 2020 +0800

fix(authentication): change login api url (#414)

* fix(authentication): change manager API login path

* fix(authentication): change authentication unit test

* fix(authentication): clean nginx.conf codes

* fix(authentication): change login URL of front end

* fix(authentication): change authentication filter rule
---
 api/filter/authentication.go  | 2 +-
 api/route/authentication.go   | 2 +-
 api/route/authentication_test.go  | 4 ++--
 compose/dashboard_conf/nginx.conf | 7 ---
 src/pages/User/components/LoginMethodPassword.tsx | 3 +--
 5 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/api/filter/authentication.go b/api/filter/authentication.go
index 11c1561..0a2bfde 100644
--- a/api/filter/authentication.go
+++ b/api/filter/authentication.go
@@ -27,7 +27,7 @@ import (
 
 func Authentication() gin.HandlerFunc {
return func(c *gin.Context) {
-   if c.Request.URL.Path != "/user/login" && 
strings.HasPrefix(c.Request.URL.Path,"/apisix") {
+   if c.Request.URL.Path != "/apisix/admin/user/login" && 
strings.HasPrefix(c.Request.URL.Path,"/apisix") {
tokenStr := c.GetHeader("Authorization")
 
// verify token
diff --git a/api/route/authentication.go b/api/route/authentication.go
index c19fa6a..9834895 100644
--- a/api/route/authentication.go
+++ b/api/route/authentication.go
@@ -30,7 +30,7 @@ type UserSession struct {
 }
 
 func AppendAuthentication(r *gin.Engine) *gin.Engine {
-   r.POST("/user/login", userLogin)
+   r.POST("/apisix/admin/user/login", userLogin)
return r
 }
 
diff --git a/api/route/authentication_test.go b/api/route/authentication_test.go
index 0cc0214..89c1b4b 100644
--- a/api/route/authentication_test.go
+++ b/api/route/authentication_test.go
@@ -28,7 +28,7 @@ var token string
 func TestUserLogin(t *testing.T) {
   // password error
   handler.
-Post("/user/login").
+Post("/apisix/admin/user/login").
 Header("Content-Type", "application/x-www-form-urlencoded").
 Body("username=admin=admin1").
 Expect(t).
@@ -37,7 +37,7 @@ func TestUserLogin(t *testing.T) {
 
   // login success
   sessionResponse := handler.
-Post("/user/login").
+Post("/apisix/admin/user/login").
 Header("Content-Type", "application/x-www-form-urlencoded").
 Body("username=admin=admin").
 Expect(t).
diff --git a/compose/dashboard_conf/nginx.conf 
b/compose/dashboard_conf/nginx.conf
index 497780d..3735dd8 100644
--- a/compose/dashboard_conf/nginx.conf
+++ b/compose/dashboard_conf/nginx.conf
@@ -15,13 +15,6 @@ server {
 try_files $uri $uri/ /index.html;
 }
 
-location /user/login {
-if ( $request_method = 'POST' ) { #HERE
-proxy_pass http://manager:8080;
-}
-try_files $uri $uri/ /index.html;
-}
-
 location /apisix/admin {
 proxy_pass http://manager:8080/apisix/admin;
 }
diff --git a/src/pages/User/components/LoginMethodPassword.tsx 
b/src/pages/User/components/LoginMethodPassword.tsx
index da0e384..504f739 100644
--- a/src/pages/User/components/LoginMethodPassword.tsx
+++ b/src/pages/User/components/LoginMethodPassword.tsx
@@ -95,7 +95,7 @@ const LoginMethodPassword: UserModule.LoginMethod = {
   submit: async (data) => {
 if (data.username !== '' && data.password !== '') {
   try {
-const result = await request('/user/login', {
+const result = await request('/apisix/admin/user/login', {
   method: 'POST',
   requestType: 'form',
   prefix: '',
@@ -127,7 +127,6 @@ const LoginMethodPassword: UserModule.LoginMethod = {
 }
   },
   logout: () => {
-console.log('password logout');
 localStorage.removeItem('token');
   },
 };

[GitHub] [apisix] gy09535 opened a new issue #2124: request help: should apisix support dynamic configuration?

[GitBox]

gy09535 opened a new issue #2124:
URL: https://github.com/apache/apisix/issues/2124


   ### Issue description
   Sometime we should get some configs such as authorization  service url, we 
can put this configs in apisix config or plugin config.
   If we put this in  apisix config ,when we change config we should restart 
apisix, And if we put in plugin config, We should change all plugin configs.
   Should we support a global  dynamic configuration which can be change on the 
admin api?
   
   ### Environment
   
   * apisix version (cmd: `apisix version`):1.5
   * OS:
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] bzp2010 opened a new pull request #414: Next fix login route

[GitBox]

bzp2010 opened a new pull request #414:
URL: https://github.com/apache/apisix-dashboard/pull/414


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   Modifying the login URL to achieve the compatibility of nginx forwarding.
   Modification involves Manager API and front end.
   - How to fix?
   Change login URL to `/apisix/admin/user/login` from `/user/login` , add an 
prefix.
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

moonming commented on a change in pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#discussion_r477143439



##
File path: .travis/linux_openresty_mtls_runner.sh
##
@@ -94,7 +94,8 @@ script() {
 sudo service etcd stop
 mkdir -p ~/etcd-data
 /usr/bin/etcd --listen-client-urls 'http://0.0.0.0:2379' 
--advertise-client-urls='http://0.0.0.0:2379' --data-dir ~/etcd-data > 
/dev/null 2>&1 &
-etcd --version
+etcdctl --version
+export ETCDCTL_API=3

Review comment:
   ditto

##
File path: .travis/linux_apisix_current_luarocks_runner.sh
##
@@ -50,7 +50,8 @@ script() {
 sudo service etcd stop
 mkdir -p ~/etcd-data
 /usr/bin/etcd --listen-client-urls 'http://0.0.0.0:2379' 
--advertise-client-urls='http://0.0.0.0:2379' --data-dir ~/etcd-data > 
/dev/null 2>&1 &
-etcd --version
+etcdctl --version
+export ETCDCTL_API=3

Review comment:
   why need `export ETCDCTL_API=3`? Is etcd support v3 by default in CI?

##
File path: apisix/core/etcd.lua
##
@@ -15,11 +15,38 @@
 -- limitations under the License.
 --
 local fetch_local_conf = require("apisix.core.config_local").local_conf
-local etcd = require("resty.etcd")
-local clone_tab = require("table.clone")
+local etcd = require("resty.etcd")
+local clone_tab= require("table.clone")
+local io   = io
+local type = type
+local ipairs   = ipairs
+local string   = string
+local tonumber = tonumber
 
 local _M = {version = 0.1}
 
+local prefix_v3 = {
+["3.5"] = "/v3",
+["3.4"] = "/v3",
+["3.3"] = "/v3beta",
+["3.2"] = "/v3alpha",
+}
+
+
+-- TODO: Default lua-resty-etcd version auto-detection is broken, so directly 
get version from cmd
+--  we don't need to call this so many times, need to save it in some 
place
+local function etcd_version_from_cmd()
+local cmd = "export ETCDCTL_API=3 && etcdctl version"
+local t, err = io.popen(cmd)
+if not t then
+return nil, "failed to execute command: " .. cmd .. ", error info:" .. 
err
+end
+local data = t:read("*all")
+t:close()
+return prefix_v3[data:sub(-4,-2)]
+end
+_M.etcd_version_from_cmd = etcd_version_from_cmd

Review comment:
   if `etcd_version_from_cmd` failed, `_M.etcd_version_from_cmd` will be 
`nil`, is test case cover this?

##
File path: bin/apisix
##
@@ -870,35 +870,21 @@ local function init_etcd(show_output)
 
 local host_count = #(yaml_conf.etcd.host)
 
--- check whether the user has enabled etcd v2 protocol
-for index, host in ipairs(yaml_conf.etcd.host) do
-uri = host .. "/v2/keys"
-local cmd = "curl -i -m ".. timeout * 2 .. " -o /dev/null -s -w 
%{http_code} " .. uri
-local res = excute_cmd(cmd)
-if res == "404" then
-io.stderr:write(string.format("failed: please make sure that you 
have enabled the v2 protocol of etcd on %s.\n", host))
-return
-end
-end
-
 local etcd_ok = false
 for index, host in ipairs(yaml_conf.etcd.host) do
 
 local is_success = true
-uri = host .. "/v2/keys" .. (etcd_conf.prefix or "")
 
 for _, dir_name in ipairs({"/routes", "/upstreams", "/services",
"/plugins", "/consumers", "/node_status",
"/ssl", "/global_rules", "/stream_routes",
"/proto"}) do
-local cmd = "curl " .. uri .. dir_name
-.. "?prev_exist=false -X PUT -d dir=true "
-.. "--connect-timeout " .. timeout
-.. " --max-time " .. timeout * 2 .. " --retry 1 2>&1"
+local res = require("posix.stdlib").setenv("ETCDCTL_API", 3)
+local key =  (etcd_conf.prefix or "") .. dir_name .. "/"
+local cmd = "etcdctl --endpoints=" .. host .. " put " .. key .. " 
init_dir"

Review comment:
   `etcdctl` maybe not install in apisix node

##
File path: t/core/etcd-auth.t
##
@@ -18,23 +18,28 @@ BEGIN {
 $ENV{"ETCD_ENABLE_AUTH"} = "true"
 }
 
-use t::APISIX 'no_plan';
+use t::APISIX;
 
 repeat_each(1);
 no_long_string();
 no_root_location();
 log_level("info");
 
-# Authentication is enabled at etcd and credentials are set
-system('etcdctl --endpoints="http://127.0.0.1:2379; -u root:5tHkHhYkjr6cQY 
user add root:5tHkHhYkjr6cQY');
-system('etcdctl --endpoints="http://127.0.0.1:2379; -u root:5tHkHhYkjr6cQY 
auth enable');
-system('etcdctl --endpoints="http://127.0.0.1:2379; -u root:5tHkHhYkjr6cQY 
role revoke --path "/*" -rw guest');
+my $etcd_version = `etcdctl version`;
+if ($etcd_version =~ /etcdctl version: 3.2/) {
+plan(skip_all => "skip for etcd version v3.2");
+} else {

Review comment:
   why etcd 3.2 is special？

##
File path: apisix/core/etcd.lua
##
@@ -15,11 +15,38 @@
 -- limitations under the License.
 --
 local 

[apisix-dashboard] branch master updated: feat: support generate `script` for APISIX (#411)

[juzhiyuan]

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new d37c11b  feat: support generate `script` for APISIX (#411)
d37c11b is described below

commit d37c11b4f05d2dd52165995e1bd81fb2b89eeaef
Author: nic-chen <33000667+nic-c...@users.noreply.github.com>
AuthorDate: Wed Aug 26 16:56:28 2020 +0800

feat: support generate `script` for APISIX (#411)

* feat: support generate `script` for APISIX

* not run in `/root` dir

* add  `config.yaml` for APISIX

* fix path
---
 api/build.sh => .github/apisix-config.yaml |  24 +++---
 .github/workflows/api_ci.yml   |  40 +++---
 .github/workflows/api_cicd.yml |  41 ++
 LICENSE|  11 ++-
 api/Dockerfile |  22 +++--
 api/build.sh   |   2 +-
 api/conf/conf.go   |  16 ++--
 api/route/route.go |   6 ++
 api/script/db/schema.sql   |   1 +
 api/service/route.go   |  41 ++
 api/service/route_test.go  | 124 +
 compose/manager_conf/build.sh  |   2 +-
 LICENSE => licenses/LICENSE-dag-to-lua.txt |  24 ++
 13 files changed, 277 insertions(+), 77 deletions(-)

diff --git a/api/build.sh b/.github/apisix-config.yaml
similarity index 60%
copy from api/build.sh
copy to .github/apisix-config.yaml
index 09e6e01..2ff8ceb 100644
--- a/api/build.sh
+++ b/.github/apisix-config.yaml
@@ -1,5 +1,4 @@
-#!/bin/sh
-#  
+#
 # Licensed to the Apache Software Foundation (ASF) under one or more
 # contributor license agreements.  See the NOTICE file distributed with
 # this work for additional information regarding copyright ownership.
@@ -15,17 +14,14 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
+# If you want to set the specified configuration value, you can set the new
+# in this file. For example if you want to specify the etcd address:
+#
 
-export ENV=prod
-pwd=`pwd`
-
-sed -i -e "s%#mysqlAddress#%`echo $MYSQL_SERVER_ADDRESS`%g" ${pwd}/conf.json
-sed -i -e "s%#mysqlUser#%`echo $MYSQL_USER`%g" ${pwd}/conf.json
-sed -i -e "s%#mysqlPWD#%`echo $MYSQL_PASSWORD`%g" ${pwd}/conf.json
-sed -i -e "s%#syslogAddress#%`echo $SYSLOG_HOST`%g" ${pwd}/conf.json
-sed -i -e "s%#apisixBaseUrl#%`echo $APISIX_BASE_URL`%g" ${pwd}/conf.json
-sed -i -e "s%#apisixApiKey#%`echo $APISIX_API_KEY`%g" ${pwd}/conf.json
-
-cd /root/manager-api
-exec ./manager-api
+etcd:
+  host:
+- "http://etcd:2379;
 
+apisix:
+  allow_admin:  # 
http://nginx.org/en/docs/http/ngx_http_access_module.html#allow
+- 0.0.0.0/0  # If we don't set any IP list, then any IP access 
is allowed by default.
diff --git a/.github/workflows/api_ci.yml b/.github/workflows/api_ci.yml
index ec906da..039f26c 100644
--- a/.github/workflows/api_ci.yml
+++ b/.github/workflows/api_ci.yml
@@ -23,13 +23,6 @@ jobs:
 env:
   ALLOW_NONE_AUTHENTICATION: yes
 
-  apisix:
-image: johz/apisix:v1.4-github-action
-env:
-  APISIX_ETCD_HOST: http://etcd:2379
-ports:
-  - 9080:9080
-
   mysql:
 image: mysql:8.0
 env:
@@ -43,14 +36,39 @@ jobs:
 
 - uses: actions/checkout@v2
 
+- name: run apisix
+  run: |
+network=$(docker network ls | grep github_network | awk '{print $2}')
+docker run --name apisix  -d -p 9080:9080 \
+-v ${{ github.workspace 
}}/.github/apisix-config.yaml:/usr/local/apisix/conf/config.yaml \
+--network "$network" --network-alias apisix \
+apache/apisix:dev
+sleep 5
+docker logs apisix
+
 - name: setting up database
   run: |
 mysql -h 127.0.0.1 --port 3306 -u root -p123456  < 
./api/script/db/schema.sql
 
-- name: setup go
-  uses: actions/setup-go@v1
-  with:
-go-version: '1.13'
+- name: ping apisix
+  run: |
+curl 127.0.0.1:9080
+
+- name: get lua lib
+  run: |
+wget https://github.com/api7/dag-to-lua/archive/v1.0.tar.gz
+sudo mkdir -p /go/api7-manager-api/dag-to-lua/
+tar -zxvf v1.0.tar.gz
+sudo mv ./dag-to-lua-1.0/lib/* /go/api7-manager-api/dag-to-lua/
+
+- name: install runtime
+  run: |
+sudo apt-get update
+sudo apt-get install lua5.1
+sudo add-apt-repository ppa:longsleep/golang-backports
+sudo apt update
+export GO111MOUDULE=on
+sudo apt install golang-1.14-go
 
 - name: run test
   working-directory: ./api
diff --git a/.github/workflows/api_cicd.yml b/.github/workflows/api_cicd.yml
index a906135..43cb2ae 100644
--- 

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #411: feat: support generate `script` for APISIX

[GitBox]

juzhiyuan merged pull request #411:
URL: https://github.com/apache/apisix-dashboard/pull/411


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis merged pull request #2109: doc: add more companies to power-by page

[GitBox]

membphis merged pull request #2109:
URL: https://github.com/apache/apisix/pull/2109


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated (c54aec8 -> fad7894)

[membphis]

This is an automated email from the ASF dual-hosted git repository.

membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from c54aec8  feat: support custom access log format (#2122)
 add fad7894  doc: add more companies to power-by page  (#2109)

No new revisions were added by this update.

Summary of changes:
 doc/powered-by.md | 15 +++
 1 file changed, 11 insertions(+), 4 deletions(-)

[GitHub] [apisix] moonming commented on pull request #2036: feature: support etcd v3, by mocking v2 API

[GitBox]

moonming commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-680750236


   I need more time to review this PR, please take it open one more day.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis merged pull request #2122: feat: support custom access log format

[GitBox]

membphis merged pull request #2122:
URL: https://github.com/apache/apisix/pull/2122


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated (9070a4f -> c54aec8)

[membphis]

This is an automated email from the ASF dual-hosted git repository.

membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from 9070a4f  feature: implemented plugin `log-rotate`, rotate log by 
interval time. (#2097)
 add c54aec8  feat: support custom access log format (#2122)

No new revisions were added by this update.

Summary of changes:
 .travis/apisix_cli_test.sh | 23 +++
 bin/apisix |  2 +-
 conf/config-default.yaml   |  1 +
 3 files changed, 25 insertions(+), 1 deletion(-)

[GitHub] [apisix] membphis closed issue #2009: feature: support custom access log format

[GitBox]

membphis closed issue #2009:
URL: https://github.com/apache/apisix/issues/2009


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2001: add ewma balancer

[GitBox]

moonming commented on pull request #2001:
URL: https://github.com/apache/apisix/pull/2001#issuecomment-680748038


   the license issue is not fixed, which is MUST fixed before next release.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #2109: doc: add more companies to power-by page

[GitBox]

moonming commented on pull request #2109:
URL: https://github.com/apache/apisix/pull/2109#issuecomment-680746632


   I will update the user wall later.
   
   Thanks,
   Ming Wen
   Twitter: _WenMing
   
   
   Shuyang Wu  于2020年8月26日周三 下午1:55写道：
   
   > I think we need to update the company list image sync the image here and
   > in README before merge this PR
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming merged pull request #2097: feature: implemented plugin `log-rotate`, rotate log by interval time.

[GitBox]

moonming merged pull request #2097:
URL: https://github.com/apache/apisix/pull/2097


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated (0bb8f46 -> 9070a4f)

[wenming]

This is an automated email from the ASF dual-hosted git repository.

wenming pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from 0bb8f46  change: allow users to see warnings by default (#2116)
 add 9070a4f  feature: implemented plugin `log-rotate`, rotate log by 
interval time. (#2097)

No new revisions were added by this update.

Summary of changes:
 apisix/init.lua|   6 +
 apisix/plugins/log-rotate.lua  | 243 +
 conf/config-default.yaml   |   5 +
 doc/README.md  |   1 +
 doc/plugins/log-rotate.md  |  88 
 doc/zh-cn/README.md|   1 +
 doc/zh-cn/plugins/log-rotate.md|  82 +++
 .../log-rotate.t}  |  63 --
 8 files changed, 466 insertions(+), 23 deletions(-)
 create mode 100644 apisix/plugins/log-rotate.lua
 create mode 100644 doc/plugins/log-rotate.md
 create mode 100644 doc/zh-cn/plugins/log-rotate.md
 copy t/{admin/stream-routes-disable.t => plugin/log-rotate.t} (61%)

[GitHub] [apisix-dashboard] juzhiyuan closed issue #412: bug: submit setting grafana url without validation

[GitBox]

juzhiyuan closed issue #412:
URL: https://github.com/apache/apisix-dashboard/issues/412


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #413: fix: submit setting grafanaURl without validation

[GitBox]

juzhiyuan merged pull request #413:
URL: https://github.com/apache/apisix-dashboard/pull/413


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: fix: submit setting grafanaURl without validation (#413)

[juzhiyuan]

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new d006c66  fix: submit setting grafanaURl without validation (#413)
d006c66 is described below

commit d006c662a5b96b23a6161919cc7f3ccdca62bf70
Author: liuxiran 
AuthorDate: Wed Aug 26 15:29:31 2020 +0800

fix: submit setting grafanaURl without validation (#413)
---
 src/pages/Setting/Setting.tsx | 33 +
 1 file changed, 17 insertions(+), 16 deletions(-)

diff --git a/src/pages/Setting/Setting.tsx b/src/pages/Setting/Setting.tsx
index 65c1dab..3ef8141 100644
--- a/src/pages/Setting/Setting.tsx
+++ b/src/pages/Setting/Setting.tsx
@@ -46,24 +46,25 @@ const Setting: React.FC = () => {
   }, [canFetchGrafana]);
 
   const onSubmit = () => {
-const { grafanaURL } = form.getFieldsValue();
-Promise.all([
-  new Promise((resolve) => {
-if (canFetchGrafana) {
-  updateMonitorURL(grafanaURL).then(resolve);
-}
-resolve();
-  }),
-]).then(() => {
-  notification.success({
-message: formatMessage({
-  id: 'page.setting.notification.update.configuration.successfully',
+form.validateFields().then((value) => {
+  Promise.all([
+new Promise((resolve) => {
+  if (canFetchGrafana) {
+updateMonitorURL(value.grafanaURL).then(resolve);
+  }
+  resolve();
 }),
+  ]).then(() => {
+notification.success({
+  message: formatMessage({
+id: 'page.setting.notification.update.configuration.successfully',
+  }),
+});
+setTimeout(() => {
+  const redirect = getUrlQuery('redirect');
+  window.location.href = redirect ? decodeURIComponent(redirect) : '/';
+}, 500);
   });
-  setTimeout(() => {
-const redirect = getUrlQuery('redirect');
-window.location.href = redirect ? decodeURIComponent(redirect) : '/';
-  }, 500);
 });
   };
 

[GitHub] [apisix] ShiningRush commented on a change in pull request #2120: [key-auth]fix: skip consumer when config has no key

[GitBox]

ShiningRush commented on a change in pull request #2120:
URL: https://github.com/apache/apisix/pull/2120#discussion_r477075791



##
File path: t/plugin/key-auth.t
##
@@ -215,3 +215,56 @@ apikey: auth-13
 ["passed\n", "hello world\n"]
 --- no_error_log
 [error]
+
+
+
+=== TEST 9: add consumer with empty key
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/consumers',
+ngx.HTTP_PUT,
+[[{
+"username": "error",
+"plugins": {
+"key-auth": {
+}

Review comment:
   I think we should not simply throw errors in the consumer, but have a 
mechanism for the plugin to define its own verification behavior





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #413: fix: submit setting grafanaURl without validation

[GitBox]

liuxiran opened a new pull request #413:
URL: https://github.com/apache/apisix-dashboard/pull/413


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   fix issue:  #412 
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   send request after form validateFields 
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran opened a new issue #412: bug: submit setting grafana url without validation

[GitBox]

liuxiran opened a new issue #412:
URL: https://github.com/apache/apisix-dashboard/issues/412


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [ ] Requirements
   - [ ] Feature or performance improvement
   - [ ] Other
   
   ___
   ### Question
   - What do you want to know?
   
   ___
   ### Bug
   - Which version of Apache APISIX Dashboard, OS and Broswer?
   * master branch
   
   
   - What happened?
   If possible, provide a way to reproduce the error.
   [test case]
   
   1. in setting page, input grafanaURL : www.google.com, a prompt message 
appears：Address is illegality
   
   1. click [Submit] button, the submission should have failed, but in fact it 
succeeded.
   ___
   ### Requirement or improvement
   - Please describe your requirements or improvement suggestions.
   
   It is necessary to do an input alidate before submitting the form.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #411: feat: support generate `script` for APISIX

[GitBox]

nic-chen opened a new pull request #411:
URL: https://github.com/apache/apisix-dashboard/pull/411


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   ___
   ### New feature or improvement
   
   feat: support generate `script` for APISIX



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] membphis merged pull request #2116: change: allow users to see warnings by default

[GitBox]

membphis merged pull request #2116:
URL: https://github.com/apache/apisix/pull/2116


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated (cd6d355 -> 0bb8f46)

[membphis]

This is an automated email from the ASF dual-hosted git repository.

membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from cd6d355  doc: fix doc use 4 spaces instead of  key (#2108)
 add 0bb8f46  change: allow users to see warnings by default (#2116)

No new revisions were added by this update.

Summary of changes:
 .travis/apisix_cli_test.sh | 11 ++-
 bin/apisix |  2 +-
 2 files changed, 11 insertions(+), 2 deletions(-)

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #410: grafana

[GitBox]

juzhiyuan commented on issue #410:
URL: 
https://github.com/apache/apisix-dashboard/issues/410#issuecomment-680678671


   Could you visit this address directly in your browser?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org