[GitHub] [apisix] spacewander opened a new pull request #2350: feat: also call picker.after_balance before retry
spacewander opened a new pull request #2350: URL: https://github.com/apache/apisix/pull/2350 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] ShiningRush commented on pull request #534: feat: add store hub and flake id
ShiningRush commented on pull request #534: URL: https://github.com/apache/apisix-dashboard/pull/534#issuecomment-701402402 Don't mind, you can see the pr as a notification that those issue have already resolved : ) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #534: feat: add store hub and flake id
juzhiyuan commented on pull request #534: URL: https://github.com/apache/apisix-dashboard/pull/534#issuecomment-701384330 I don't know much about Golang, so ping @nic-chen @gxthrj @bzp2010 here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #961: doc(FAQ): how to use regex to match uri.
membphis closed issue #961: URL: https://github.com/apache/apisix/issues/961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #2273: test: add integration test
moonming commented on pull request #2273: URL: https://github.com/apache/apisix/pull/2273#issuecomment-701371853 Is this pr solving possible problems that might exist or is it solving real problems? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #533: Put bundled frontend files in Go
juzhiyuan opened a new issue #533: URL: https://github.com/apache/apisix-dashboard/issues/533 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #518: request help: dashboard 404
juzhiyuan closed issue #518: URL: https://github.com/apache/apisix-dashboard/issues/518 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #466: bug: a related to route basic-auth consumer should not be deleted
juzhiyuan commented on issue #466: URL: https://github.com/apache/apisix-dashboard/issues/466#issuecomment-701311931 > OK, I will consider this issue tomorrow, and may need to have little change in architecture. Hi @ShiningRush How about your consideration? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #500: Failed to compile dashboard
juzhiyuan commented on issue #500: URL: https://github.com/apache/apisix-dashboard/issues/500#issuecomment-701310987 but could @nic-chen give some suggestions about this issue? not sure if it's a bug or a tricky issue 樂 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #500: Failed to compile dashboard
juzhiyuan commented on issue #500: URL: https://github.com/apache/apisix-dashboard/issues/500#issuecomment-701310603 ok, we will test and resolve this issue before 1.6 release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #529: discuss: improve the UE of config Authentication plugins
juzhiyuan commented on issue #529: URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-701310124 I just put this feature in M1.7. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #529: discuss: improve the UE of config Authentication plugins
juzhiyuan commented on issue #529: URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-701309983 yep, let's implement your proposal first :D This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #532: fetching category for plugins from APISIX
juzhiyuan opened a new issue #532: URL: https://github.com/apache/apisix-dashboard/issues/532 related issue https://github.com/apache/apisix/issues/2308 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #529: discuss: improve the UE of config Authentication plugins
liuxiran commented on issue #529: URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-701298221 > Got your point, you mean for Auth plugins, we should only config it in Consumer instead of Route, and we COULD choose to enable or disable it in Route instead of cobfig, right? > > I agree to this proposal, how about others suggestions? > > cc @membphis @nic-chen @moonming ? yes you got my point @juzhiyuan 欄, and furthermore, if the authentication plugin can be turned into the consumer’s default support plugin, just like `proxy-rewrite` in route, that would be better, but the cost of plugin modification may be higher This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2308: request help: Provide the ability to view plug-in types
membphis commented on issue #2308: URL: https://github.com/apache/apisix/issues/2308#issuecomment-701293577 you are right ^_^ @juzhiyuan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch membphis-patch-1 updated (09b840a -> 5deeadf)
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch membphis-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. from 09b840a doc: field `key` should be optional in `upstream` object. add 05840ca test: wait for more time and check the error log, old way is unstable. (#2341) add 5deeadf Merge branch 'master' into membphis-patch-1 No new revisions were added by this update. Summary of changes: t/node/ewma.t | 2 +- t/node/invalid-route.t | 3 +++ t/node/invalid-service.t| 16 +--- t/node/invalid-upstream.t | 2 ++ t/node/service-empty.t | 1 - t/plugin/consumer-restriction.t | 1 + 6 files changed, 16 insertions(+), 9 deletions(-)
[GitHub] [apisix] membphis commented on pull request #2273: test: add integration test
membphis commented on pull request #2273: URL: https://github.com/apache/apisix/pull/2273#issuecomment-701291380 > and need to obtain related system resource occupation Only "relevant system resources" is not enough, we need to confirm the status of the APISIX instance before and after the test. For example, we need to check the used memory, network stats, etc. They are useful. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #531: 使用resful操作的记录并没有同步到dashboard
juzhiyuan closed issue #531: URL: https://github.com/apache/apisix-dashboard/issues/531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #531: 使用resful操作的记录并没有同步到dashboard
juzhiyuan commented on issue #531: URL: https://github.com/apache/apisix-dashboard/issues/531#issuecomment-701278456 https://github.com/apache/apisix-dashboard/milestone/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #531: 使用resful操作的记录并没有同步到dashboard
juzhiyuan commented on issue #531: URL: https://github.com/apache/apisix-dashboard/issues/531#issuecomment-701278377 MySQL will be removed in the next version, if you want to show all data created by Admin API directly, you should always use it or wait for the next version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #2308: request help: Provide the ability to view plug-in types
juzhiyuan commented on issue #2308: URL: https://github.com/apache/apisix/issues/2308#issuecomment-701268660 Just for sure, this feature will not only take effects on Auth plugins but also for all plugins, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #76: feat: update team page
juzhiyuan commented on pull request #76: URL: https://github.com/apache/apisix-website/pull/76#issuecomment-701266857 ping @moonming @LiteSun This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch juzhiyuan-patch-1 updated (42ccc33 -> ff509c5)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 42ccc33 feat: update team page add ff509c5 Update team.md No new revisions were added by this update. Summary of changes: docs/team.md | 2 ++ 1 file changed, 2 insertions(+)
[apisix] branch master updated (8947919 -> 05840ca)
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 8947919 bugfix: use correct version of etcd in linux_apisix_master_luarocks (#2343) add 05840ca test: wait for more time and check the error log, old way is unstable. (#2341) No new revisions were added by this update. Summary of changes: t/node/ewma.t | 2 +- t/node/invalid-route.t | 3 +++ t/node/invalid-service.t| 16 +--- t/node/invalid-upstream.t | 2 ++ t/node/service-empty.t | 1 - t/plugin/consumer-restriction.t | 1 + 6 files changed, 16 insertions(+), 9 deletions(-)
[GitHub] [apisix] membphis merged pull request #2341: test: wait for more time and then check the error log.
membphis merged pull request #2341: URL: https://github.com/apache/apisix/pull/2341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta edited a comment on pull request #2273: test: add integration test
idbeta edited a comment on pull request #2273: URL: https://github.com/apache/apisix/pull/2273#issuecomment-701258413 @spacewander When users use APISIX, some problems such as setting too many routes to cause high memory usage after *long time* running, or problems caused by abnormal operation of related components in the APISIX service. These problems may take *long* testing to discover, and need to obtain related system resource occupation. Our current test method cannot cover these scenarios well. so we can try another test method to cover these scenarios. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta commented on pull request #2273: test: add integration test
idbeta commented on pull request #2273: URL: https://github.com/apache/apisix/pull/2273#issuecomment-701258413 When users use APISIX, some problems such as setting too many routes to cause high memory usage after *long time* running, or problems caused by abnormal operation of related components in the APISIX service. These problems may take *long* testing to discover, and need to obtain related system resource occupation. Our current test method cannot cover these scenarios well. so we can try another test method to cover these scenarios. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #1610: plugin(prometheus): support to hot reload
membphis closed issue #1610: URL: https://github.com/apache/apisix/issues/1610 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #1610: plugin(prometheus): support to hot reload
membphis commented on issue #1610: URL: https://github.com/apache/apisix/issues/1610#issuecomment-701256367 yes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2151: feature: Best practice for jaeger
membphis commented on issue #2151: URL: https://github.com/apache/apisix/issues/2151#issuecomment-701254391 > I retry use this lua bridge to send data https://github.com/opentracing/lua-bridge-tracer/tree/master/src please confirm it can work with `cosocket`, for the C library, it can not call any socket if we use it in nginx Lua land. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] nic-chen commented on issue #2247: feat: `apisix-schema` tool can return the `jsonschema` of route, service, upstream and plugins
nic-chen commented on issue #2247: URL: https://github.com/apache/apisix/issues/2247#issuecomment-701249579 OK, let me do this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis edited a comment on issue #2247: feat: `apisix-schema` tool can return the `jsonschema` of route, service, upstream and plugins
membphis edited a comment on issue #2247:
URL: https://github.com/apache/apisix/issues/2247#issuecomment-701249164
another way, I think it is better than the pre one:
```lua
#!/usr/bin/env lua
-- fake "apisix.core.schema"
package.loaded["apisix.core.schema"] = {}
local schema = require("apisix.schema_def")
print(type(schema.route))
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2247: feat: `apisix-schema` tool can return the `jsonschema` of route, service, upstream and plugins
membphis commented on issue #2247:
URL: https://github.com/apache/apisix/issues/2247#issuecomment-701249164
another way, I think it is better than the pre one:
```
#!/usr/bin/env lua
-- fake "apisix.core.schema"
package.loaded["apisix.core.schema"] = {}
local schema = require("apisix.schema_def")
print(type(schema.route))
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #529: discuss: improve the UE of config Authentication plugins
nic-chen commented on issue #529: URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-701242135 agree +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis edited a comment on issue #2247: feat: `apisix-schema` tool can return the `jsonschema` of route, service, upstream and plugins
membphis edited a comment on issue #2247:
URL: https://github.com/apache/apisix/issues/2247#issuecomment-701241039
here is an example, @nic-chen you can take a look at this:
```lua
#!/usr/bin/env resty
local pkg_cpath_org = package.cpath
local pkg_path_org = package.path
local apisix_home = "./"
local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;"
.. apisix_home .. "/deps/lib/lua/5.1/?.so;"
local pkg_path = apisix_home .. "/?/init.lua;"
.. apisix_home .. "/deps/share/lua/5.1/?.lua;;"
package.cpath = pkg_cpath .. pkg_cpath_org
package.path = pkg_path .. pkg_path_org
-- local schema = require("apisix.schema_def")
-- ngx.say(json.encode(schema.route))
local json = require("cjson.safe")
local schema = require("apisix.plugins.limit-count")
ngx.say(json.encode(schema.schema))
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2247: feat: `apisix-schema` tool can return the `jsonschema` of route, service, upstream and plugins
membphis commented on issue #2247:
URL: https://github.com/apache/apisix/issues/2247#issuecomment-701241039
here is an example, @nic-chen you can take a look at this:
```lua
#!/usr/bin/env resty
local pkg_cpath_org = package.cpath
local pkg_path_org = package.path
local apisix_home = "./"
local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;"
.. apisix_home .. "/deps/lib/lua/5.1/?.so;"
local pkg_path = apisix_home .. "/?/init.lua;"
.. apisix_home .. "/deps/share/lua/5.1/?.lua;;"
package.cpath = pkg_cpath .. pkg_cpath_org
package.path = pkg_path .. pkg_path_org
-- local schema = require("apisix.schema_def")
-- ngx.say(json.encode(schema.route))
ngx.timer.at(0, function ( ... )
local json = require("cjson.safe")
local schema = require("apisix.plugins.limit-count")
ngx.say(json.encode(schema.schema))
end)
ngx.sleep(2)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #529: discuss: improve the UE of config Authentication plugins
membphis commented on issue #529: URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-701229844 agree with this proposal too. https://github.com/apache/apisix/issues/2308 , if we support this feature, the dashboard will easier. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] duzhenxun edited a comment on issue #487: Who is using APISIX？（欢迎使用 APISIX 的个人和公司在此留言）
duzhenxun edited a comment on issue #487: URL: https://github.com/apache/apisix/issues/487#issuecomment-554967797 Organization: 优信二手车(xin.com) Location: Beijing, China Contact: duzhen...@126.com Scenario: research,test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] duzhenxun edited a comment on issue #487: Who is using APISIX？（欢迎使用 APISIX 的个人和公司在此留言）
duzhenxun edited a comment on issue #487: URL: https://github.com/apache/apisix/issues/487#issuecomment-554967797 Organization: xin.com Location: Beijing, China Contact: duzhen...@126.com Scenario: research,test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2151: feature: Best practice for jaeger
gy09535 commented on issue #2151:
URL: https://github.com/apache/apisix/issues/2151#issuecomment-701219754
> Today I tried nginx-opentracing which build in openresy, really
complicated. Indeed, not suitable for integration into apisix.
>
> **Depend lib:**
> https://github.com/opentracing/opentracing-cpp
> https://github.com/jaegertracing/jaeger-client-cpp
> detail in:
[CMakeLists.txt](https://github.com/jaegertracing/jaeger-client-cpp/blob/master/CMakeLists.txt)
>
> **build option:**
>
> ```shell
> ./configure \
> --with-http_stub_status_module \
> --with-ipv6 \
> --with-http_v2_module \
> --with-http_realip_module \
> --without-luajit-gc64 \
> --with-compat \
> --add-dynamic-module=/path/nginx-opentracing/opentracing
> ```
>
> **Example:**
>
> ```
> load_module
/usr/local/openresty/nginx/modules/ngx_http_opentracing_module.so;
>
> events {}
>
> http {
> opentracing on;
>
> opentracing_load_tracer /usr/local/lib/libjaegertracing.so
./jaeger-config.json;
> upstream backend {
> server 127.0.0.1:8090;
> }
>
> server {
> error_log ./logs/debug.log debug;
> listen 8080;
> server_name localhost;
>
> location = / {
> opentracing_trace_locations off;
> proxy_pass http://backend;
> opentracing_propagate_context;
> }
> }
> }
> ```
>
> jaeger-config.json:
>
> ```json
> {
> "service_name": "openresty",
> "diabled": false,
> "reporter": {
> "logSpans": true,
> "endpoint":"http://192.168.0.14:14268/api/traces;
> },
> "sampler": {
> "type": "const",
> "param": "1"
> }
> }
> ```
>
> **Test:**
> `curl -iv http://127.0.0.1:8080`
>
> **UI:**
>
I retry use this lua bridge to send data
https://github.com/opentracing/lua-bridge-tracer/tree/master/src
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] membphis opened a new pull request #2349: doc: field `key` should be optional in `upstream` object.
membphis opened a new pull request #2349: URL: https://github.com/apache/apisix/pull/2349 ### What this PR does / why we need it: as title. ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] 01/01: doc: field `key` should be optional in `upstream` object.
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch membphis-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git commit 09b840a1f3afe12a7d9d0389a0ef8a05c3096a58 Author: YuanSheng Wang AuthorDate: Wed Sep 30 15:36:00 2020 +0800 doc: field `key` should be optional in `upstream` object. --- doc/admin-api.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/admin-api.md b/doc/admin-api.md index a130a67..29041c4 100644 --- a/doc/admin-api.md +++ b/doc/admin-api.md @@ -498,7 +498,7 @@ In addition to the basic complex equalization algorithm selection, APISIX's Upst |nodes |required if `k8s_deployment_info` not configured|Hash table, the key of the internal element is the upstream machine address list, the format is `Address + Port`, where the address part can be IP or domain name, such as `192.168.1.100:80`, `foo.com:80`, etc. Value is the weight of the node. In particular, when the weight value is `0`, it has a special meaning, which usually means that the upstream node is invalid and never wants to be selected.| |k8s_deployment_info|required if `nodes` not configured|fields: `namespace`、`deploy_name`、`service_name`、`port`、`backend_type`, `port` is number, `backend_type` is `pod` or `service`, others is string. | |hash_on |optional|This option is only valid if the `type` is `chash`. Supported types `vars`(Nginx variables), `header`(custom header), `cookie`, `consumer`, the default value is `vars`.| -|key |required|This option is only valid if the `type` is `chash`. Find the corresponding node `id` according to `hash_on` and `key`. When `hash_on` is set as `vars`, `key` is the required parameter, for now, it support nginx built-in variables like `uri, server_name, server_addr, request_uri, remote_port, remote_addr, query_string, host, hostname, arg_***`, `arg_***` is arguments in the request line, [Nginx variables list](http://nginx.org/en/docs/varindex.html). When `hash_ [...] +|key |optional|This option is only valid if the `type` is `chash`. Find the corresponding node `id` according to `hash_on` and `key`. When `hash_on` is set as `vars`, `key` is the required parameter, for now, it support nginx built-in variables like `uri, server_name, server_addr, request_uri, remote_port, remote_addr, query_string, host, hostname, arg_***`, `arg_***` is arguments in the request line, [Nginx variables list](http://nginx.org/en/docs/varindex.html). When `hash_ [...] |checks |optional|Configure the parameters of the health check. For details, refer to [health-check](health-check.md).| |retries |optional|Pass the request to the next upstream using the underlying Nginx retry mechanism, the retry mechanism is enabled by default and set the number of retries according to the number of backend nodes. If `retries` option is explicitly set, it will override the default value. `0` means disable retry mechanism.| |enable_websocket|optional| enable `websocket`(boolean), default `false`.|
[apisix] branch membphis-patch-1 created (now 09b840a)
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch membphis-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. at 09b840a doc: field `key` should be optional in `upstream` object. This branch includes the following new commits: new 09b840a doc: field `key` should be optional in `upstream` object. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [apisix-dashboard] tanjiancheng opened a new issue #531: 使用resful操作的记录并没有同步到dashboard
tanjiancheng opened a new issue #531:
URL: https://github.com/apache/apisix-dashboard/issues/531
我使用如下的方法操作增加一条路由配置，但是新版的后台是没有相关记录查看的，看了代码好像后台是保存到mysql，然后发布的时候再存储到etcd里，请问下如果这块直接用提供的resful接口操作怎么管理这块etcd和mysql的数据同步？
```
curl http://127.0.0.1:9080/apisix/admin/routes/111 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"methods": ["GET"],
"uri": "/grpctest",
"service_protocol": "grpc",
"plugins": {
"grpc-transcode": {
"proto_id": "1",
"service": "helloworld.Greeter",
"method": "SayHello"
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"10.11.131.117:50051": 1
}
}
}'
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #525: bug: Got 500 error when select redis policy in limit-count plugin
juzhiyuan commented on issue #525: URL: https://github.com/apache/apisix-dashboard/issues/525#issuecomment-701209962 ok then it should be a bug on plugin, let me fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2335: bug: why key is required in Upstream's request body?
membphis commented on issue #2335: URL: https://github.com/apache/apisix/issues/2335#issuecomment-701204677 we need to fix it doc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2345: feat: Add lables for route/consumer/service/ssl objects
membphis commented on pull request #2345: URL: https://github.com/apache/apisix/pull/2345#issuecomment-701203439 nice PR. LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tanjiancheng commented on issue #530: 插件配置->普通模式缺少grpc-transcode配置
tanjiancheng commented on issue #530: URL: https://github.com/apache/apisix-dashboard/issues/530#issuecomment-701199100 @juzhiyuan thanks，the plugin maybe have two feature 1、like /apisix/admin/proto/ to save proto file content 2、like /apisix/admin/routes/ to save route rules and upstream This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tanjiancheng edited a comment on issue #530: 插件配置->普通模式缺少grpc-transcode配置
tanjiancheng edited a comment on issue #530: URL: https://github.com/apache/apisix-dashboard/issues/530#issuecomment-701199100 @juzhiyuan thanks，the plugin maybe have two features 1、like /apisix/admin/proto/ to save proto file content 2、like /apisix/admin/routes/ to save route rules and upstream This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #525: bug: Got 500 error when select redis policy in limit-count plugin
nic-chen commented on issue #525: URL: https://github.com/apache/apisix-dashboard/issues/525#issuecomment-701197606 @liuxiran please take a look at the `limit-count`'s schema https://github.com/apache/apisix/blob/master/apisix/plugins/limit-count.lua#L77 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #517: bug：Did not check the settings of selected pulgins when ceate or edit consumer
juzhiyuan closed issue #517: URL: https://github.com/apache/apisix-dashboard/issues/517 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #517: bug：Did not check the settings of selected pulgins when ceate or edit consumer
juzhiyuan commented on issue #517: URL: https://github.com/apache/apisix-dashboard/issues/517#issuecomment-701189567 The schema for every enabled plugin would validate if it's ok to use, empty data is ok because some plugins allow this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #525: bug: Got 500 error when select redis policy in limit-count plugin
juzhiyuan commented on issue #525: URL: https://github.com/apache/apisix-dashboard/issues/525#issuecomment-701187900 @nic-chen, need your time to check this issue, not sure if it's related to this plugin's data. thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #530: 插件配置->普通模式缺少grpc-transcode配置
juzhiyuan commented on issue #530: URL: https://github.com/apache/apisix-dashboard/issues/530#issuecomment-701186059 not sure, let me have a check on its panel ASAP 樂 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2339: feature: breaker request by api
membphis commented on a change in pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#discussion_r497266741
##
File path: t/APISIX.pm
##
@@ -260,6 +261,17 @@ _EOC_
require("apisix").http_init_worker()
}
+# only for test
Review comment:
we need to delete those conf in `t/APISIX.PM`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] liuhengloveyou commented on a change in pull request #2339: feature: breaker request by api
liuhengloveyou commented on a change in pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#discussion_r497261311
##
File path: apisix/plugins/api-breaker.lua
##
@@ -0,0 +1,180 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local ngx = ngx
+local math = math
+local os = os
+local ipairs = ipairs
+local core = require("apisix.core")
+local plugin_name = "api-breaker"
+
+local shared_buffer = ngx.shared['plugin-'.. plugin_name]
+
+local schema = {
+type = "object",
+properties = {
+response_code = {
+type = "integer",
+minimum = 200,
+maximum = 599,
+},
+unhealthy = {
+type = "object",
+http_statuses = {
+type = "array",
+minItems = 1,
+items = {
+type = "integer",
+minimum = 500,
+maximum = 599,
+},
+uniqueItems = true,
+default = {500}
Review comment:
thand you a lot!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2339: feature: breaker request by api
membphis commented on a change in pull request #2339:
URL: https://github.com/apache/apisix/pull/2339#discussion_r497260469
##
File path: apisix/plugins/api-breaker.lua
##
@@ -0,0 +1,180 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local ngx = ngx
+local math = math
+local os = os
+local ipairs = ipairs
+local core = require("apisix.core")
+local plugin_name = "api-breaker"
+
+local shared_buffer = ngx.shared['plugin-'.. plugin_name]
+
+local schema = {
+type = "object",
+properties = {
+response_code = {
+type = "integer",
+minimum = 200,
+maximum = 599,
+},
+unhealthy = {
+type = "object",
+http_statuses = {
+type = "array",
+minItems = 1,
+items = {
+type = "integer",
+minimum = 500,
+maximum = 599,
+},
+uniqueItems = true,
+default = {500}
Review comment:
@liuhengloveyou your schema is wrong. you can use the common tools to
check it first.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
