[GitHub] [apisix] tokers opened a new pull request #2548: feat: support TLS connection with etcd.

2020-10-28 Thread GitBox


tokers opened a new pull request #2548:
URL: https://github.com/apache/apisix/pull/2548


   ### What this PR does / why we need it:
   
   Support the TLS connection when communicating with etcd cluster. We added a 
configuration item to custom the certificate verification. Whether to setup TLS 
connection or not depends on the endpoints' scheme, for instance, when 
endpoints are:
   
   ```
   etcd:
 host:
   - "https://127.0.0.1:2379";
   - "https://127.0.0.1:3379";
   ```
   
   APISIX will originate TLS connection automatically, and the Server Name 
Indication extention will be set by the endpoint host (`127.0.0.1` in above 
case).
   
   This PR depends on https://github.com/api7/lua-resty-etcd/pull/86.
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] gy09535 removed a comment on issue #2377: bug:Use zipkin plugin and limit-req plugin together, zipkin plugin can not work when is limit

2020-10-28 Thread GitBox


gy09535 removed a comment on issue #2377:
URL: https://github.com/apache/apisix/issues/2377#issuecomment-714862890


   I have change the priority of zipkin plugin, I think maybe we have another 
problem , can not span the right time of access and rewrite, should we change 
some code out plugin?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] gy09535 commented on pull request #2499: bugfix: fix zipkin plugin error when used with limit count plugin

2020-10-28 Thread GitBox


gy09535 commented on pull request #2499:
URL: https://github.com/apache/apisix/pull/2499#issuecomment-71569


   Is this PR can merge?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] Caelebs opened a new issue #615: v2.0-rc2 Build docker image error.

2020-10-28 Thread GitBox


Caelebs opened a new issue #615:
URL: https://github.com/apache/apisix-dashboard/issues/615


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [x] Bug
   - [ ] Requirements
   - [ ] Feature or performance improvement
   - [ ] Other
   
   ___
   ### Bug
   - Which version of Apache APISIX Dashboard, OS, and Browser?
   
   Failed to build docker image based on the current `v2.0-rc2` version. The 
error message is as follows
   
   ```
   Step 13/17 : RUN  cd /go/manager-api/build-tools  && lua schema-sync.lua 
> /go/manager-api/schema.json  && cd /go/manager-api/  && rm -rf 
/go/manager-api/build-tools/
---> Running in 8e282779783e
   lua: ./apisix/plugins/api-breaker.lua:25: attempt to index field 'shared' (a 
nil value)
   stack traceback:
./apisix/plugins/api-breaker.lua:25: in main chunk
[C]: in function 'require'
schema-sync.lua:128: in main chunk
[C]: ?
   The command '/bin/sh -c cd /go/manager-api/build-tools  && lua 
schema-sync.lua > /go/manager-api/schema.json  && cd /go/manager-api/  
&& rm -rf /go/manager-api/build-tools/' returned a non-zero code: 1
   ```
   
   Commands used to build the image `docker build -t 
apisix-manager-api:v2.0-rc2 .`
   Dashboard-manager-api version `v2.0-rc2`
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] juzhiyuan commented on issue #608: manager服务构建docker镜像使用了可能不稳定的 apisix:master 分支

2020-10-28 Thread GitBox


juzhiyuan commented on issue #608:
URL: 
https://github.com/apache/apisix-dashboard/issues/608#issuecomment-717809520


   added related issue https://github.com/apache/apisix-dashboard/issues/615



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on pull request #2499: bugfix: fix zipkin plugin error when used with limit count plugin

2020-10-28 Thread GitBox


membphis commented on pull request #2499:
URL: https://github.com/apache/apisix/pull/2499#issuecomment-717812067


   @nic-chen @moonming @spacewander do you have time to look at this PR?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] Caelebs commented on issue #615: v2.0-rc2 Build docker image error.

2020-10-28 Thread GitBox


Caelebs commented on issue #615:
URL: 
https://github.com/apache/apisix-dashboard/issues/615#issuecomment-717815408


   I tried to modify the Dockerfile and change the apisix code download address 
to 2.0release version, but new problems appeared in the build process. The 
content of my modification is as follows
   ```
   RUN  wget **https://github.com/apache/apisix/archive/2.0.zip** \
&& apt-get update && apt-get install zip -y \
&& unzip **2.0.zip** \
&& rm -rf /go/manager-api/build-tools/apisix/ \
&& mkdir -p /go/manager-api/build-tools/apisix \
&& mv **./apisix-2.0/apisix/*** /go/manager-api/build-tools/apisix/
   ```
   
   and the error message is `no such file or directory`
   
   ```
   Step 12/17 : COPY --from=build-env /usr/share/zoneinfo/Hongkong 
/etc/localtime
---> Using cache
---> 874bd2476b2f
   Step 13/17 : RUN  cd /go/manager-api/build-tools  && lua schema-sync.lua 
> /go/manager-api/schema.json  && cd /go/manager-api/  && rm -rf 
/go/manager-api/build-tools/
---> Running in 5b50cda236c4
   Removing intermediate container 5b50cda236c4
---> 6c9e7905c54d
   Step 14/17 : ADD ./dist /go/manager-api
   ADD failed: stat /var/lib/docker/tmp/docker-builder690428283/dist: no such 
file or directory
   ```
   
   @juzhiyuan 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] Caelebs edited a comment on issue #615: v2.0-rc2 Build docker image error.

2020-10-28 Thread GitBox


Caelebs edited a comment on issue #615:
URL: 
https://github.com/apache/apisix-dashboard/issues/615#issuecomment-717815408


   I tried to modify the Dockerfile and change the apisix code download address 
to 2.0 release version, but new problems appeared in the build process. The 
content of my modification is as follows
   ```
   RUN  wget **https://github.com/apache/apisix/archive/2.0.zip** \
&& apt-get update && apt-get install zip -y \
&& unzip **2.0.zip** \
&& rm -rf /go/manager-api/build-tools/apisix/ \
&& mkdir -p /go/manager-api/build-tools/apisix \
&& mv **./apisix-2.0/apisix/*** /go/manager-api/build-tools/apisix/
   ```
   
   and the error message is `no such file or directory`
   
   ```
   Step 12/17 : COPY --from=build-env /usr/share/zoneinfo/Hongkong 
/etc/localtime
---> Using cache
---> 874bd2476b2f
   Step 13/17 : RUN  cd /go/manager-api/build-tools  && lua schema-sync.lua 
> /go/manager-api/schema.json  && cd /go/manager-api/  && rm -rf 
/go/manager-api/build-tools/
---> Running in 5b50cda236c4
   Removing intermediate container 5b50cda236c4
---> 6c9e7905c54d
   Step 14/17 : ADD ./dist /go/manager-api
   ADD failed: stat /var/lib/docker/tmp/docker-builder690428283/dist: no such 
file or directory
   ```
   
   @juzhiyuan 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] Caelebs edited a comment on issue #615: v2.0-rc2 Build docker image error.

2020-10-28 Thread GitBox


Caelebs edited a comment on issue #615:
URL: 
https://github.com/apache/apisix-dashboard/issues/615#issuecomment-717815408


   I tried to modify the Dockerfile and change the apisix code download address 
to 2.0 release version, but new problems appeared in the build process. The 
content of my modification is as follows
   ```
   RUN  wget https://github.com/apache/apisix/archive/2.0.zip \
&& apt-get update && apt-get install zip -y \
&& unzip 2.0.zip \
&& rm -rf /go/manager-api/build-tools/apisix/ \
&& mkdir -p /go/manager-api/build-tools/apisix \
&& mv ./apisix-2.0/apisix/* /go/manager-api/build-tools/apisix/
   ```
   
   and the error message is `no such file or directory`
   
   ```
   Step 12/17 : COPY --from=build-env /usr/share/zoneinfo/Hongkong 
/etc/localtime
---> Using cache
---> 874bd2476b2f
   Step 13/17 : RUN  cd /go/manager-api/build-tools  && lua schema-sync.lua 
> /go/manager-api/schema.json  && cd /go/manager-api/  && rm -rf 
/go/manager-api/build-tools/
---> Running in 5b50cda236c4
   Removing intermediate container 5b50cda236c4
---> 6c9e7905c54d
   Step 14/17 : ADD ./dist /go/manager-api
   ADD failed: stat /var/lib/docker/tmp/docker-builder690428283/dist: no such 
file or directory
   ```
   
   @juzhiyuan 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] juzhiyuan commented on issue #615: v2.0-rc2 Build docker image error.

2020-10-28 Thread GitBox


juzhiyuan commented on issue #615:
URL: 
https://github.com/apache/apisix-dashboard/issues/615#issuecomment-717819615


   It seems that there still have something wrong when deploying the dashboard 
with Docker, these issues should be fixed before 2.1 release.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] nic-chen opened a new pull request #616: fix: using relative path to read conf

2020-10-28 Thread GitBox


nic-chen opened a new pull request #616:
URL: https://github.com/apache/apisix-dashboard/pull/616


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   ___
   ### Bugfix
   
   using relative path to read conf and json schema



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] nic-chen closed pull request #616: fix: using relative path to read conf

2020-10-28 Thread GitBox


nic-chen closed pull request #616:
URL: https://github.com/apache/apisix-dashboard/pull/616


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] nic-chen opened a new pull request #617: fix: using relative path to read conf

2020-10-28 Thread GitBox


nic-chen opened a new pull request #617:
URL: https://github.com/apache/apisix-dashboard/pull/617


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   ___
   ### Bugfix
   
   using relative path to read conf and json schema
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] gxthrj removed a comment on issue #2072: upgrade skywalking plugin to support skywalking 8.0

2020-10-28 Thread GitBox


gxthrj removed a comment on issue #2072:
URL: https://github.com/apache/apisix/issues/2072#issuecomment-717839708


   There are some files conflict



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] gxthrj commented on issue #2072: upgrade skywalking plugin to support skywalking 8.0

2020-10-28 Thread GitBox


gxthrj commented on issue #2072:
URL: https://github.com/apache/apisix/issues/2072#issuecomment-717839708


   There are some files conflict



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] gxthrj commented on pull request #2389: [WIP] feat: upgrade skywalking plugin to support skywalking 8.0 .

2020-10-28 Thread GitBox


gxthrj commented on pull request #2389:
URL: https://github.com/apache/apisix/pull/2389#issuecomment-717840113


   There are some files conflict



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] juzhiyuan merged pull request #617: fix: using relative path to read conf

2020-10-28 Thread GitBox


juzhiyuan merged pull request #617:
URL: https://github.com/apache/apisix-dashboard/pull/617


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-dashboard] branch v2.0 updated (ea9aba4 -> 1e10e8d)

2020-10-28 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a change to branch v2.0
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.


from ea9aba4  fix: ant-design/ant-design/issues/27396
 add 1e10e8d  fix: using relative path to read conf (#617)

No new revisions were added by this update.

Summary of changes:
 api/conf/conf.go | 8 ++--
 1 file changed, 6 insertions(+), 2 deletions(-)



[GitHub] [apisix] htwdjqr opened a new pull request #2549: doc:update install-dependencies.md

2020-10-28 Thread GitBox


htwdjqr opened a new pull request #2549:
URL: https://github.com/apache/apisix/pull/2549


   ### What this PR does / why we need it:
   update install-dependencies.md
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on pull request #2389: feat: upgrade skywalking plugin to support skywalking 8.0 .

2020-10-28 Thread GitBox


membphis commented on pull request #2389:
URL: https://github.com/apache/apisix/pull/2389#issuecomment-717896940


   @gxthrj @moonming fixed conflicts, please take a look when you have time.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] qiufeihai opened a new issue #2550: request help: how to serve static file with apisix

2020-10-28 Thread GitBox


qiufeihai opened a new issue #2550:
URL: https://github.com/apache/apisix/issues/2550


   ### Issue description
   how to serve static file with apisix
   
   ### Environment
   
   * apisix version (cmd: `apisix version`): 2.0
   * OS: Centos
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] lizeming commented on issue #2468: request help: The problem of rewriting HTTP request header ‘Host’

2020-10-28 Thread GitBox


lizeming commented on issue #2468:
URL: https://github.com/apache/apisix/issues/2468#issuecomment-717923773


 The problem of upgrading to the master branch still exists. Maybe my 
description is not clear enough, this is our test information under the master 
branch:
 Our scenario is: the Internet initiates a request to 10.xxx.xxx.199:9080, 
and the APISIX access request is transferred to the back-end service. The 
back-end service will splice the new address according to the Host field of the 
HTTP header to the requesting client.
 In Nginx, we use 'proxy_set_header Host $http_host' to replace the Host 
field, because we need to reserve port 9080, but it cannot be implemented in 
APISIX. The back-end service always returns the Host field with the original 
request port removed. See the example for details.
   
   
![Snipaste_2020-10-28_21-08-33](https://user-images.githubusercontent.com/897138/97439939-c60a0680-1961-11eb-891d-c74bd62f0679.jpg)
   
 We tried to rewrite the Host field through the proxy-rewrite plugin.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2468: request help: The problem of rewriting HTTP request header ‘Host’

2020-10-28 Thread GitBox


membphis commented on issue #2468:
URL: https://github.com/apache/apisix/issues/2468#issuecomment-717953015


   I think we should use `header_filter` phase to implement this feature.
   
   for nginx, I think it can not support this feature too, please confirm this.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis closed issue #2550: request help: how to serve static file with apisix

2020-10-28 Thread GitBox


membphis closed issue #2550:
URL: https://github.com/apache/apisix/issues/2550


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2550: request help: how to serve static file with apisix

2020-10-28 Thread GitBox


membphis commented on issue #2550:
URL: https://github.com/apache/apisix/issues/2550#issuecomment-717955655


   apisix is an API gateway. for static files, you can use another nginx 
upstream.
   
   client -> apisix -> nginx upstream(static file)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on pull request #2549: doc:update install-dependencies.md

2020-10-28 Thread GitBox


membphis commented on pull request #2549:
URL: https://github.com/apache/apisix/pull/2549#issuecomment-717967130


   Do we need to update the English version?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis merged pull request #2458: [doc]to correct some typo and incorrect examples in getting-started.md and syslog.md

2020-10-28 Thread GitBox


membphis merged pull request #2458:
URL: https://github.com/apache/apisix/pull/2458


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix] branch master updated: doc: fixed some typo and incorrect examples in getting-started.md and syslog.md (#2458)

2020-10-28 Thread membphis
This is an automated email from the ASF dual-hosted git repository.

membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new e472d2c  doc: fixed some typo and incorrect examples in 
getting-started.md and syslog.md (#2458)
e472d2c is described below

commit e472d2c2dbf667c0b40a61a24f917048cfdd2b09
Author: dabue <53054094+da...@users.noreply.github.com>
AuthorDate: Wed Oct 28 22:24:32 2020 +0800

doc: fixed some typo and incorrect examples in getting-started.md and 
syslog.md (#2458)

fix #2457
---
 doc/getting-started.md   |  2 +-
 doc/plugins/syslog.md| 33 +++--
 doc/zh-cn/getting-started.md |  2 +-
 doc/zh-cn/plugins/syslog.md  | 33 +++--
 4 files changed, 32 insertions(+), 38 deletions(-)

diff --git a/doc/getting-started.md b/doc/getting-started.md
index 65e1bea..25269ab 100644
--- a/doc/getting-started.md
+++ b/doc/getting-started.md
@@ -237,7 +237,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 
'X-API-KEY: edd1c9f034335f13
 Now you can invoke the route with the following command:
 
 ```bash
-curl -i -X GET http://127.0.0.1:9080/samplePrefix/get?param1=foo¶m2=bar -H 
'apikey: superSecretAPIKey'
+curl -i -X GET 'http://127.0.0.1:9080/samplePrefix/get?param1=foo¶m2=bar' 
-H 'apikey: superSecretAPIKey'
 ```
 
 ## APISIX Dashboard
diff --git a/doc/plugins/syslog.md b/doc/plugins/syslog.md
index 60f0e10..e61d6f9 100644
--- a/doc/plugins/syslog.md
+++ b/doc/plugins/syslog.md
@@ -57,25 +57,22 @@ This will provide the ability to send Log data requests as 
JSON objects.
 The following is an example on how to enable the sys-logger for a specific 
route.
 
 ```shell
-curl http://127.0.0.1:9080/apisix/admin/consumers -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
 {
-"username": "foo",
 "plugins": {
-  "plugins": {
-"syslog": {
- "host" : "127.0.0.1",
- "port" : 5044,
- "flush_limit" : 1
-  }
-   },
-  "upstream": {
-   "type": "roundrobin",
-   "nodes": {
-   "127.0.0.1:1980": 1
-   }
-  },
-  "uri": "/hello"
-}
+"syslog": {
+"host" : "127.0.0.1",
+"port" : 5044,
+"flush_limit" : 1
+}
+},
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+"127.0.0.1:1980": 1
+}
+},
+"uri": "/hello"
 }'
 ```
 
@@ -96,7 +93,7 @@ Remove the corresponding json configuration in the plugin 
configuration to disab
 APISIX plugins are hot-reloaded, therefore no need to restart APISIX.
 
 ```shell
-$ curl http://127.0.0.1:2379/apisix/admin/routes/1  -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d value='
+$ curl http://127.0.0.1:9080/apisix/admin/routes/1  -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
 {
 "methods": ["GET"],
 "uri": "/hello",
diff --git a/doc/zh-cn/getting-started.md b/doc/zh-cn/getting-started.md
index 5cbc1d8..0478d88 100644
--- a/doc/zh-cn/getting-started.md
+++ b/doc/zh-cn/getting-started.md
@@ -232,7 +232,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 
'X-API-KEY: edd1c9f034335f13
 现在可以使用以下命令调用路由:
 
 ```bash
-curl -i -X GET http://127.0.0.1:9080/samplePrefix/get?param1=foo¶m2=bar -H 
'apikey: superSecretAPIKey'
+curl -i -X GET 'http://127.0.0.1:9080/samplePrefix/get?param1=foo¶m2=bar' 
-H 'apikey: superSecretAPIKey'
 ```
 
 ## Apache APISIX 控制台
diff --git a/doc/zh-cn/plugins/syslog.md b/doc/zh-cn/plugins/syslog.md
index 11e9d01..e8fe5dd 100644
--- a/doc/zh-cn/plugins/syslog.md
+++ b/doc/zh-cn/plugins/syslog.md
@@ -57,25 +57,22 @@
 1. 下面例子展示了如何为指定路由开启 `sys-logger` 插件的。
 
 ```shell
-curl http://127.0.0.1:9080/apisix/admin/consumers -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
 {
-"username": "foo",
 "plugins": {
-  "plugins": {
-  "syslog": {
-   "host" : "127.0.0.1",
-   "port" : 5044,
-   "flush_limit" : 1
-}
-   },
-  "upstream": {
-   "type": "roundrobin",
-   "nodes": {
-   "127.0.0.1:1980": 1
-   }
-  },
-  "uri": "/hello"
-}
+"syslog": {
+"host" : "127.0.0.1",
+"port" : 5044,
+"flush_limit" : 1
+}
+},
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+"127.0.0.1:1980": 1
+}
+},
+"uri": "/hello"
 }'
 ```
 
@@ -96,

[GitHub] [apisix] membphis closed issue #2457: doc: typo in getting-started.md and the example in plugins/syslog.md#how-to-enable is wrong.

2020-10-28 Thread GitBox


membphis closed issue #2457:
URL: https://github.com/apache/apisix/issues/2457


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2547: doc(FAQ): add one item(how APISIX use etcd to update the configuration in milliseconds) in FAQ

2020-10-28 Thread GitBox


membphis commented on issue #2547:
URL: https://github.com/apache/apisix/issues/2547#issuecomment-717968492


   welcome to submit it by PR ^_^



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on pull request #2546: Health check for stream proxy

2020-10-28 Thread GitBox


membphis commented on pull request #2546:
URL: https://github.com/apache/apisix/pull/2546#issuecomment-717969287


   that is a big feature, I'll take a look at this PR later. 
   
   many thx for your contribution @redynasc 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2542: request help: configure route to only execute plugins

2020-10-28 Thread GitBox


membphis commented on issue #2542:
URL: https://github.com/apache/apisix/issues/2542#issuecomment-717971342


   what is the plugin `cgi-proxy`? do you set any upstream object in this 
plugin?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on pull request #2548: feat: support TLS connection with etcd.

2020-10-28 Thread GitBox


membphis commented on pull request #2548:
URL: https://github.com/apache/apisix/pull/2548#issuecomment-717972996


   missing test case ^_^



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2544: request help: Different routes have different access permission

2020-10-28 Thread GitBox


membphis commented on issue #2544:
URL: https://github.com/apache/apisix/issues/2544#issuecomment-717974019


   
https://github.com/apache/apisix/blob/master/doc/plugins/consumer-restriction.md
   
   I think you need this plugin. 
   
   please feel free to reopen this issue if you still have a problem with this 
issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis closed issue #2544: request help: Different routes have different access permission

2020-10-28 Thread GitBox


membphis closed issue #2544:
URL: https://github.com/apache/apisix/issues/2544


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on a change in pull request #2488: feat: add error-log-logger plugin

2020-10-28 Thread GitBox


membphis commented on a change in pull request #2488:
URL: https://github.com/apache/apisix/pull/2488#discussion_r513495284



##
File path: apisix/plugins/error-log-logger.lua
##
@@ -0,0 +1,235 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local plugin_name = "error-log-logger"
+local errlog = require "ngx.errlog"
+local batch_processor = require("apisix.utils.batch-processor")
+local table = core.table
+local ngx = ngx
+local tcp = ngx.socket.tcp
+local select = select
+local type = type
+local string = string
+local tostring = tostring
+local buffers
+local timer
+local schema = {
+type = "object",
+properties = {
+host = {type = "string"},
+port = {type = "integer", minimum = 0},
+tls = {type = "boolean", default = false},
+tls_options = {type = "string"},
+timeout = {type = "integer", minimum = 1, default= 3},
+keepalive = {type = "integer", minimum = 1, default= 30},
+name = {type = "string", default = "tcp logger"},
+level = {type = "string", default = "WARN"},
+batch_max_size = {type = "integer", minimum = 0, default = 1000},
+max_retry_count = {type = "integer", minimum = 0, default = 0},
+retry_delay = {type = "integer", minimum = 0, default = 1},
+buffer_duration = {type = "integer", minimum = 1, default = 60},
+inactive_timeout = {type = "integer", minimum = 1, default = 5},
+},
+additionalProperties = false,
+}
+
+local log_level = {
+STDERR =ngx.STDERR,
+EMERG  =ngx.EMERG,
+ALERT  =ngx.ALERT,
+CRIT   =ngx.CRIT,
+ERR=ngx.ERR,
+ERROR  =ngx.ERR,
+WARN   =ngx.WARN,
+NOTICE = ngx.NOTICE,
+INFO   =ngx.INFO,
+DEBUG  =ngx.DEBUG
+}
+
+local config = {
+name = plugin_name,
+timeout = 3,
+keepalive = 30,
+level = "WARN",
+tls = false,
+retry_delay = 1,
+batch_max_size = 1000,
+max_retry_count = 0,
+buffer_duration = 60,
+inactive_timeout = 5,
+}
+local _M = {
+version = 0.1,
+priority = 1091,
+name = plugin_name,
+schema = schema,
+}
+
+
+function _M.check_schema(conf)
+return core.schema.check(schema, conf)
+end
+
+
+local function try_attr(t, ...)
+local count = select('#', ...)
+for i = 1, count do
+local attr = select(i, ...)
+t = t[attr]
+if type(t) ~= "table" then
+return false
+end
+end
+
+return true
+end
+
+local function load_attr()
+local local_conf = core.config.local_conf()
+if try_attr(local_conf, "plugin_attr", plugin_name) then
+local attr = local_conf.plugin_attr[plugin_name]
+config.host = attr.host

Review comment:
   this is not a good way to set the default value. 
   
   we should use JSONSchema to check if it is valid and set the default value.
   
   you can take a look at this code: 
   
   
https://github.com/apache/apisix/blob/master/apisix/plugins/http-logger.lua#L58-L71

##
File path: apisix/plugins/error-log-logger.lua
##
@@ -0,0 +1,235 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local plugin_name = "error-log-logger"
+local errlog = require "ngx.errlog"
+local batch_processor = require("apisix.utils.batch-processor")
+local table = core.table
+local ngx = ngx
+local tcp = ngx.socket.tcp
+local se

[GitHub] [apisix] tokers commented on pull request #2548: feat: support TLS connection with etcd.

2020-10-28 Thread GitBox


tokers commented on pull request #2548:
URL: https://github.com/apache/apisix/pull/2548#issuecomment-717979616


   Will add test cases after the corresponding pr in lua-resty-etcd is merged.
   
   
   -- 
   Zhang Chao
   
   On 2020年10月28日 at 22:32:05, YuanSheng Wang (notificati...@github.com) wrote:
   
   > missing test case ^_^
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   >
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2533: request help: failed to set server peer [some-k8s-svc.default.svc.cluster.local:5202] err: no host allowed

2020-10-28 Thread GitBox


membphis commented on issue #2533:
URL: https://github.com/apache/apisix/issues/2533#issuecomment-717982064


   I do not why :( . Does anyone know this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2477: request help: add service_id as key to plugin limit-*

2020-10-28 Thread GitBox


membphis commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-717983234


   welcome to submit PR to support `service_id` for `limit-conn` or `limit-req`.
   
   they were should be the same as `limit-count`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2523: request help: jwt-auth plugin RS256 algorithm is not easy to use

2020-10-28 Thread GitBox


membphis commented on issue #2523:
URL: https://github.com/apache/apisix/issues/2523#issuecomment-717984956


   @tzssangglass Do you have any suggestions for this issue?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2520: bug: "failed to acquire the lock: timeout" in logs/error.log when setuping route at the first time

2020-10-28 Thread GitBox


membphis commented on issue #2520:
URL: https://github.com/apache/apisix/issues/2520#issuecomment-717988401


   Can we get this error message somehow?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2530: request help: [doc] need qucik-start

2020-10-28 Thread GitBox


membphis commented on issue #2530:
URL: https://github.com/apache/apisix/issues/2530#issuecomment-717990611


   welcome PR



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2531: doc(plugins/hmac-auth): generate signature should be more detailed

2020-10-28 Thread GitBox


membphis commented on issue #2531:
URL: https://github.com/apache/apisix/issues/2531#issuecomment-717990317


   welcome PR, LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] lizeming commented on issue #2468: request help: The problem of rewriting HTTP request header ‘Host’

2020-10-28 Thread GitBox


lizeming commented on issue #2468:
URL: https://github.com/apache/apisix/issues/2468#issuecomment-717991320


   Yes. Nginx also does not reserve the port number in the internal ‘host’ 
field.
   
   But there is a ‘host’ field in the header of the client request. The above 
'proxy_set_header Host $http_host' is replaced by the client's ‘host’ so as to 
retain the original requested port.
   
   For such scenarios, is it possible to provide apisix to modify the nginx 
configuration template to adapt to more use environments?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2530: request help: [doc] need qucik-start

2020-10-28 Thread GitBox


membphis commented on issue #2530:
URL: https://github.com/apache/apisix/issues/2530#issuecomment-717991292


   here is the related doc: 
https://github.com/apache/apisix/tree/master#get-started
   
   feel free to re-edit it for a better one.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis closed issue #2526: request help: admin-api error : key not found

2020-10-28 Thread GitBox


membphis closed issue #2526:
URL: https://github.com/apache/apisix/issues/2526


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2526: request help: admin-api error : key not found

2020-10-28 Thread GitBox


membphis commented on issue #2526:
URL: https://github.com/apache/apisix/issues/2526#issuecomment-717993816


   we have removed `mysql` in APISIX dashboard now.
   
   please make a try with the latest version `2.0`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis closed issue #2522: request help: jwt-auth plugin work on a route or a service

2020-10-28 Thread GitBox


membphis closed issue #2522:
URL: https://github.com/apache/apisix/issues/2522


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2522: request help: jwt-auth plugin work on a route or a service

2020-10-28 Thread GitBox


membphis commented on issue #2522:
URL: https://github.com/apache/apisix/issues/2522#issuecomment-717996658


   > curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
   > {
   > "methods": ["GET"],
   > "uri": "/index.html",
   > "plugins": {
   > "jwt-auth": {
   > "secret": "-BEGIN PUBLIC 
KEY-\nMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC50wrZORquQ1W6xS66Hvx9PA/Y\np1kL4GosLCDYCFFeuyHemdZCeDW+jzTfjdfDAExsZ4Z5/gNegOZC3nEIh/IDoEJH\nHMwziTz1jxh/7VXuFGvdZcIiaPpKS6EZ+dVx/NfYMcyY+1gf1ASxJghOD+9Np7Ie\npqKuAqxx1BVnk+rvmwIDAQAB\n-END
 PUBLIC KEY-\n"
   > }
   > },
   > "upstream": {
   > "type": "roundrobin",
   > "nodes": {
   > "39.97.63.215:80": 1
   > }
   > }
   > }'
   
   this is wrong.
   
   please take a look at this plugin: 
https://github.com/apache/apisix/blob/master/doc/plugins/jwt-auth.md
   
   I think you can find the right way to enable this plugin.
   
   please feel free to reopen this issue if you still have any problem.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis edited a comment on issue #2522: request help: jwt-auth plugin work on a route or a service

2020-10-28 Thread GitBox


membphis edited a comment on issue #2522:
URL: https://github.com/apache/apisix/issues/2522#issuecomment-717996658


   > curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
   > {
   > "methods": ["GET"],
   > "uri": "/index.html",
   > "plugins": {
   > "jwt-auth": {
   > "secret": "-BEGIN PUBLIC 
KEY-\nMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC50wrZORquQ1W6xS66Hvx9PA/Y\np1kL4GosLCDYCFFeuyHemdZCeDW+jzTfjdfDAExsZ4Z5/gNegOZC3nEIh/IDoEJH\nHMwziTz1jxh/7VXuFGvdZcIiaPpKS6EZ+dVx/NfYMcyY+1gf1ASxJghOD+9Np7Ie\npqKuAqxx1BVnk+rvmwIDAQAB\n-END
 PUBLIC KEY-\n"
   > }
   > },
   > "upstream": {
   > "type": "roundrobin",
   > "nodes": {
   > "39.97.63.215:80": 1
   > }
   > }
   > }'
   
   this is wrong.
   
   please take a look at this doc of plugin: 
https://github.com/apache/apisix/blob/master/doc/plugins/jwt-auth.md
   
   I think you can find the right way to enable this plugin.
   
   please feel free to reopen this issue if you still have any problem.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] jeffguorg commented on issue #2533: request help: failed to set server peer [some-k8s-svc.default.svc.cluster.local:5202] err: no host allowed

2020-10-28 Thread GitBox


jeffguorg commented on issue #2533:
URL: https://github.com/apache/apisix/issues/2533#issuecomment-717998181


   sorry to bother, but do you have any idea on this? @moonming 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2501: [discuss]: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-10-28 Thread GitBox


membphis commented on issue #2501:
URL: https://github.com/apache/apisix/issues/2501#issuecomment-717998727


   agree +1 ^_^



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on pull request #2509: feat: get schema by schema_type

2020-10-28 Thread GitBox


membphis commented on pull request #2509:
URL: https://github.com/apache/apisix/pull/2509#issuecomment-718000563


   > /apisix/admin/schema/plugins/{plugin_name}?schema_type=consumer
   
   I think this way is simpler and enough.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #2468: request help: The problem of rewriting HTTP request header ‘Host’

2020-10-28 Thread GitBox


membphis commented on issue #2468:
URL: https://github.com/apache/apisix/issues/2468#issuecomment-718003819


   > But there is a ‘host’ field in the header of the client request. The above 
'proxy_set_header Host $http_host' is replaced by the client's ‘host’ so as to 
retain the original requested port.
   
   can you show me an example of Nginx config about how to support this case 
via Nginx?
   I will try to find a better to resolve this issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis edited a comment on issue #2468: request help: The problem of rewriting HTTP request header ‘Host’

2020-10-28 Thread GitBox


membphis edited a comment on issue #2468:
URL: https://github.com/apache/apisix/issues/2468#issuecomment-718003819


   > But there is a ‘host’ field in the header of the client request. The above 
'proxy_set_header Host $http_host' is replaced by the client's ‘host’ so as to 
retain the originally requested port.
   
   can you show me an example of Nginx config about how to support this case 
via Nginx?
   I need it, for trying to find a better way to resolve this issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] nic-chen opened a new issue #618: [discussion] remove the dependency on `Lua` due to plugin orchestration

2020-10-28 Thread GitBox


nic-chen opened a new issue #618:
URL: https://github.com/apache/apisix-dashboard/issues/618


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [x] Question or discussion
   - [ ] Bug
   - [ ] Requirements
   - [ ] Feature or performance improvement
   - [ ] Other
   
   ___
   ### Requirements or improvement
   
   we could use Lua VM in Go to replace Lua
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] moonming merged pull request #2225: move etcd cluster in docker for CI

2020-10-28 Thread GitBox


moonming merged pull request #2225:
URL: https://github.com/apache/apisix/pull/2225


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] moonming commented on pull request #2225: move etcd cluster in docker for CI

2020-10-28 Thread GitBox


moonming commented on pull request #2225:
URL: https://github.com/apache/apisix/pull/2225#issuecomment-718020382


   @EnableAsync nice work 👍



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix] branch master updated (e472d2c -> 1dfc4cd)

2020-10-28 Thread wenming
This is an automated email from the ASF dual-hosted git repository.

wenming pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from e472d2c  doc: fixed some typo and incorrect examples in 
getting-started.md and syslog.md (#2458)
 add 1dfc4cd  CI: move etcd cluster in docker (#2225)

No new revisions were added by this update.

Summary of changes:
 .github/workflows/build.yml| 43 +++---
 .github/workflows/macOS.yml| 36 ++
 .travis/linux_apisix_current_luarocks_runner.sh|  8 +---
 .travis/linux_apisix_master_luarocks_runner.sh |  7 +---
 .travis/linux_openresty_mtls_runner.sh |  7 +---
 .travis/linux_openresty_runner.sh  |  8 +---
 .travis/linux_tengine_runner.sh|  8 +---
 ...nstall-etcd.sh => linux-install-etcd-client.sh} |  1 -
 8 files changed, 56 insertions(+), 62 deletions(-)
 create mode 100644 .github/workflows/macOS.yml
 copy utils/{install-etcd.sh => linux-install-etcd-client.sh} (95%)



[apisix] branch master updated (e472d2c -> 1dfc4cd)

2020-10-28 Thread wenming
This is an automated email from the ASF dual-hosted git repository.

wenming pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from e472d2c  doc: fixed some typo and incorrect examples in 
getting-started.md and syslog.md (#2458)
 add 1dfc4cd  CI: move etcd cluster in docker (#2225)

No new revisions were added by this update.

Summary of changes:
 .github/workflows/build.yml| 43 +++---
 .github/workflows/macOS.yml| 36 ++
 .travis/linux_apisix_current_luarocks_runner.sh|  8 +---
 .travis/linux_apisix_master_luarocks_runner.sh |  7 +---
 .travis/linux_openresty_mtls_runner.sh |  7 +---
 .travis/linux_openresty_runner.sh  |  8 +---
 .travis/linux_tengine_runner.sh|  8 +---
 ...nstall-etcd.sh => linux-install-etcd-client.sh} |  1 -
 8 files changed, 56 insertions(+), 62 deletions(-)
 create mode 100644 .github/workflows/macOS.yml
 copy utils/{install-etcd.sh => linux-install-etcd-client.sh} (95%)



[GitHub] [apisix] juzhiyuan commented on a change in pull request #2549: doc:update install-dependencies.md

2020-10-28 Thread GitBox


juzhiyuan commented on a change in pull request #2549:
URL: https://github.com/apache/apisix/pull/2549#discussion_r513828355



##
File path: doc/zh-cn/install-dependencies.md
##
@@ -40,15 +40,21 @@ CentOS 7
 wget http://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm
 sudo rpm -ivh epel-release-latest-7.noarch.rpm
 
+# 安装 etcd

Review comment:
   Please update this doc in English, too.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Yangzcy423911 opened a new issue #2551: apisix 2.X 支持etcd ssl配置吗,想共用k8s集群中的etcd

2020-10-28 Thread GitBox


Yangzcy423911 opened a new issue #2551:
URL: https://github.com/apache/apisix/issues/2551


   ### Issue description
   
   
   ### Environment
   
   * apisix version (cmd: `apisix version`):
   * OS:
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on a change in pull request #2524: CI : yaml style

2020-10-28 Thread GitBox


juzhiyuan commented on a change in pull request #2524:
URL: https://github.com/apache/apisix/pull/2524#discussion_r513843881



##
File path: .github/workflows/build.yml
##
@@ -12,7 +12,12 @@ jobs:
   fail-fast: false
   matrix:
 platform: [ubuntu-18.04]
-os_name: [linux_openresty, linux_tengine, 
linux_apisix_master_luarocks, linux_apisix_current_luarocks, 
linux_openresty_mtls]
+os_name:

Review comment:
   Then we may need to update the platform field, too.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] zhangguanzhang commented on issue #2530: request help: [doc] need qucik-start

2020-10-28 Thread GitBox


zhangguanzhang commented on issue #2530:
URL: https://github.com/apache/apisix/issues/2530#issuecomment-718296485


   This part of the information is too little, a more complete entry process 
document is needed



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] liuxiran commented on pull request #2509: feat: get schema by schema_type

2020-10-28 Thread GitBox


liuxiran commented on pull request #2509:
URL: https://github.com/apache/apisix/pull/2509#issuecomment-718296772


   LGTM
   
   tips:
   after this pr merged, jwt-auth also needs to add `consumer_schema` to the 
`_M` @Jaycean 
   
https://github.com/apache/apisix/blob/1dfc4cdacd620e6d59c3d4c75506ff80581612eb/apisix/plugins/jwt-auth.lua#L59
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on issue #2551: apisix 2.X 支持etcd ssl配置吗,想共用k8s集群中的etcd

2020-10-28 Thread GitBox


spacewander commented on issue #2551:
URL: https://github.com/apache/apisix/issues/2551#issuecomment-718298247


   See https://github.com/apache/apisix/pull/2548



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] liuxiran edited a comment on issue #2082: request help: Update plugin's schema

2020-10-28 Thread GitBox


liuxiran edited a comment on issue #2082:
URL: https://github.com/apache/apisix/issues/2082#issuecomment-698736589







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Yangzcy423911 commented on issue #2551: apisix 2.X 支持etcd ssl配置吗,想共用k8s集群中的etcd

2020-10-28 Thread GitBox


Yangzcy423911 commented on issue #2551:
URL: https://github.com/apache/apisix/issues/2551#issuecomment-718300433


   您好,没有找到关于TLS KEY的配置



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander opened a new pull request #2552: change: rename APIX_WORKER_PROCESSES to APISIX_WORKER_PROCESSES

2020-10-28 Thread GitBox


spacewander opened a new pull request #2552:
URL: https://github.com/apache/apisix/pull/2552


   Close #2517.
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan closed issue #2441: plugin(hmac-auth): update the schema

2020-10-28 Thread GitBox


juzhiyuan closed issue #2441:
URL: https://github.com/apache/apisix/issues/2441


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan merged pull request #2509: feat: get schema by schema_type

2020-10-28 Thread GitBox


juzhiyuan merged pull request #2509:
URL: https://github.com/apache/apisix/pull/2509


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Jaycean commented on pull request #2509: feat: get schema by schema_type

2020-10-28 Thread GitBox


Jaycean commented on pull request #2509:
URL: https://github.com/apache/apisix/pull/2509#issuecomment-718301182


   > LGTM
   > 
   > tips:
   > after this pr merged, jwt-auth also needs to add `consumer_schema` to the 
`_M` @Jaycean
   > 
https://github.com/apache/apisix/blob/1dfc4cdacd620e6d59c3d4c75506ff80581612eb/apisix/plugins/jwt-auth.lua#L59
   
   OK, I will submit a new PR unified addition to consumer_schema support



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on pull request #2509: feat: get schema by schema_type

2020-10-28 Thread GitBox


juzhiyuan commented on pull request #2509:
URL: https://github.com/apache/apisix/pull/2509#issuecomment-718301456


   > LGTM
   > 
   > tips:
   > after this pr merged, jwt-auth also needs to add `consumer_schema` to the 
`_M` @Jaycean
   > 
https://github.com/apache/apisix/blob/1dfc4cdacd620e6d59c3d4c75506ff80581612eb/apisix/plugins/jwt-auth.lua#L59
   
   - [ ] TODO this issue



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix] branch master updated (1dfc4cd -> d2aa1d8)

2020-10-28 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from 1dfc4cd  CI: move etcd cluster in docker (#2225)
 add d2aa1d8  feat: get schema by schema_type (#2509)

No new revisions were added by this update.

Summary of changes:
 apisix/admin/plugins.lua  |  7 ++-
 apisix/plugins/basic-auth.lua |  1 +
 apisix/plugins/hmac-auth.lua  |  1 +
 t/admin/plugins.t | 21 +
 t/plugin/basic-auth.t | 31 +++
 t/plugin/hmac-auth.t  | 30 ++
 6 files changed, 90 insertions(+), 1 deletion(-)



[GitHub] [apisix-dashboard] LiteSun opened a new pull request #619: feat: added frontend e2e test

2020-10-28 Thread GitBox


LiteSun opened a new pull request #619:
URL: https://github.com/apache/apisix-dashboard/pull/619


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   #614 
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   as title



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] liuxiran edited a comment on issue #2441: plugin(hmac-auth): update the schema

2020-10-28 Thread GitBox


liuxiran edited a comment on issue #2441:
URL: https://github.com/apache/apisix/issues/2441#issuecomment-714330623


   ok,  based on the results of the discussion above, I think this issue 
contains at least two modifications: 
   
   - [x] admin-api provides api like:
* `/apisix/admin/schema/plugins/{plugin_name}` to get plugin schema
* 
`/apisix/admin/schema/plugins/{plugin_name}?schema_type=consumer_schema` to get 
plugin consumer_schema
   
   - [ ] dashboard calls the corresponding api to get the correct schema.
   
   e.g:
   
   1. consumer wants to config hmac-auth plugin, then call 
`/apisix/admin/schema/plugins/hmac-auth?schema_type=consumer_schema` to get the 
config schema
   
   1. route wants to config hmac-auth plugin, then call 
`/apisix/admin/schema/plugins/hmac-auth` to get the config schema
   
   my partner and I will take this issue :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Jaycean opened a new issue #2553: bug: jwt-auth add consumer_schema to the _M

2020-10-28 Thread GitBox


Jaycean opened a new issue #2553:
URL: https://github.com/apache/apisix/issues/2553


   ### Issue description
   
   after this pr: #2509  merged, jwt-auth also needs to add consumer_schema to 
the _M
   I think the new `consumer_schema` can be reminded to add when it is added, 
it is very easy to miss
   please assigne to me @liuxiran 
   
https://github.com/apache/apisix/blob/1dfc4cdacd620e6d59c3d4c75506ff80581612eb/apisix/plugins/jwt-auth.lua#L59
   
   ### Environment
   
   * apisix version (cmd: `apisix version`): 2.0
   * OS: centos
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tokers commented on issue #2551: apisix 2.X 支持etcd ssl配置吗,想共用k8s集群中的etcd

2020-10-28 Thread GitBox


tokers commented on issue #2551:
URL: https://github.com/apache/apisix/issues/2551#issuecomment-718312030


   > 您好,没有找到关于TLS KEY的配置
   
   I bet you mean the client cert, key and ca certificate?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] tokers commented on issue #2551: apisix 2.X 支持etcd ssl配置吗,想共用k8s集群中的etcd

2020-10-28 Thread GitBox


tokers commented on issue #2551:
URL: https://github.com/apache/apisix/issues/2551#issuecomment-718311862


   @Yangzcy423911 Even after #2548 is merged, APISIX still cannot support the 
**mutual** TLS connection with etcd.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] LY-GO edited a comment on issue #2477: request help: add service_id as key to plugin limit-*

2020-10-28 Thread GitBox


LY-GO edited a comment on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-718314185


   > welcome to submit PR to support `service_id` for `limit-conn` or 
`limit-req`.
   > 
   > they were should be the same as `limit-count`.
   
   How can i require service_id through Euerka?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] LY-GO commented on issue #2477: request help: add service_id as key to plugin limit-*

2020-10-28 Thread GitBox


LY-GO commented on issue #2477:
URL: https://github.com/apache/apisix/issues/2477#issuecomment-718314185


   > welcome to submit PR to support `service_id` for `limit-conn` or 
`limit-req`.
   > 
   > they were should be the same as `limit-count`.
   
   How ca i require service_id through Euerka?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] thekingofworld opened a new issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox


thekingofworld opened a new issue #2554:
URL: https://github.com/apache/apisix/issues/2554


   ### Issue description
   After adding the official echo plugin, the output content did not meet 
expectations.
   
![image](https://user-images.githubusercontent.com/8169665/97518800-f1790980-19d2-11eb-82c9-ea2995b8f316.png)
   
   here is route config.
   
![image](https://user-images.githubusercontent.com/8169665/97518825-ffc72580-19d2-11eb-9fc7-591d2ea15c64.png)
   
   
   ### Environment
   
   * apisix version (cmd: `apisix version`):  `2.0`
   * OS: `mac os`
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] Caelebs commented on issue #615: v2.0-rc2 Build docker image error.

2020-10-28 Thread GitBox


Caelebs commented on issue #615:
URL: 
https://github.com/apache/apisix-dashboard/issues/615#issuecomment-718326560


   Before the 2.1 version is released, how should I modify the source code to 
build the manager-api docker image file?
   @juzhiyuan 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] lizeming commented on issue #2468: request help: The problem of rewriting HTTP request header ‘Host’

2020-10-28 Thread GitBox


lizeming commented on issue #2468:
URL: https://github.com/apache/apisix/issues/2468#issuecomment-718328570


   This is one of the business request chains. 
   
   This business has been around for a long time. 
   
   Request chain: client -> internet address(2xx.xxx.xxx.xx9:8096) -> 
pre-agent(172.xx.xxx.135:9080) -> business-agent(10.xx.xx.31:8096) -> business 
service(10.xx.xx.45)
   
   The following is a summary of the main configuration of the business chain:
   
   pre-agent(172.xx.xxx.135):
   ```
   http {
   server_tokens  off;
   includemime.types;
   default_type   application/octet-stream;
   proxy_redirect off;
   server {
   listen 9080;
   location / {
   proxy_set_header Host $http_host;
   proxy_pass http://10.xx.xx.31:8096;
   }
   }
   }
   ```
   
   business-agent(10.xx.xx.31):
   ```
   http {
   server_tokens  off;
   includemime.types;
   default_type   application/octet-stream;
   proxy_redirect off;
   
   server {
   listen 8096;
   location / {
   proxy_set_header Host $http_host;
   proxy_pass http://10.xx.xx.45:8080;
   }
   }
   }
   ```
   
   Request example:
   ```
   $ curl -v http://2xx.xxx.xxx.xx9:8096/crxxor/
   *   Trying 2xx.xxx.xxx.xx9:8096...
   * TCP_NODELAY set
   * Connected to 2xx.xxx.xxx.xx9 (2xx.xxx.xxx.xx9) port 8096 (#0)
   > GET /crxxor/ HTTP/1.1
   > Host: 2xx.xxx.xxx.xx9:8096
   > User-Agent: curl/7.68.0
   > Accept: */*
   >
   * Mark bundle as not supporting multiuse
   < HTTP/1.1 302 Found
   < connection: close
   < Content-Type: text/html;charset=utf-8
   < Content-Length: 0
   < Server: Openresty
   < Date: Thu, 29 Oct 2020 02:45:41 GMT
   < Set-Cookie: JSESSIONID=4664rfv5A55tgb11B6yhn67uj3; Path=/crxxor; 
HttpOnly
   < Location: http://2xx.xxx.xxx.xx9:8096/crxxor//login/loginManage/toLogin
   <
   * Closing connection 0
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] Jaycean opened a new pull request #2555: fix: jwt-auth add consumer_schema to the _M

2020-10-28 Thread GitBox


Jaycean opened a new pull request #2555:
URL: https://github.com/apache/apisix/pull/2555


   Signed-off-by: Jaycean 
   
   ### What this PR does / why we need it:
   fix: #2553 
   - jwt-auth add consumer_schema to the _M
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [x] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] htwdjqr commented on a change in pull request #2549: doc:update install-dependencies.md

2020-10-28 Thread GitBox


htwdjqr commented on a change in pull request #2549:
URL: https://github.com/apache/apisix/pull/2549#discussion_r513908283



##
File path: doc/zh-cn/install-dependencies.md
##
@@ -40,15 +40,21 @@ CentOS 7
 wget http://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm
 sudo rpm -ivh epel-release-latest-7.noarch.rpm
 
+# 安装 etcd

Review comment:
   It is copied from the English document,no need to update the English 
version.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] moonming commented on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox


moonming commented on issue #2554:
URL: https://github.com/apache/apisix/issues/2554#issuecomment-718332608


   @Akayeshmantha do you have time to take a look? thx



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] moonming commented on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox


moonming commented on issue #2554:
URL: https://github.com/apache/apisix/issues/2554#issuecomment-718332935


   @thekingofworld Can you copy the text of the command line? The picture is 
not easy to debug



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] thekingofworld commented on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox


thekingofworld commented on issue #2554:
URL: https://github.com/apache/apisix/issues/2554#issuecomment-718334757


   @moonming OK, here is text
   ```
   curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
   {
   "plugins": {
   "echo": {
   "before_body": "before the body modification "
   }
   },
   "upstream": {
   "nodes": {
   "127.0.0.1:8080": 1
   },
   "type": "roundrobin"
   },
   "uri": "/hello"
   }'
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] thekingofworld commented on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox


thekingofworld commented on issue #2554:
URL: https://github.com/apache/apisix/issues/2554#issuecomment-718336780


   the upstream `127.0.0.1:8080` is a simple http server, implemented through 
`Go` language
   
![image](https://user-images.githubusercontent.com/8169665/97522169-1755dc80-19da-11eb-8be2-46c9d1b87190.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[apisix-website] branch release-2.0 created (now 312cc68)

2020-10-28 Thread wenming
This is an automated email from the ASF dual-hosted git repository.

wenming pushed a change to branch release-2.0
in repository https://gitbox.apache.org/repos/asf/apisix-website.git.


  at 312cc68  doc: add 2.0 release.

This branch includes the following new commits:

 new 312cc68  doc: add 2.0 release.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




[apisix-website] 01/01: doc: add 2.0 release.

2020-10-28 Thread wenming
This is an automated email from the ASF dual-hosted git repository.

wenming pushed a commit to branch release-2.0
in repository https://gitbox.apache.org/repos/asf/apisix-website.git

commit 312cc68704bc161dc5e9a5a430164eb0a9b7b3fa
Author: WenMing 
AuthorDate: Thu Oct 29 11:30:20 2020 +0800

doc: add 2.0 release.
---
 docs/download.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/download.md b/docs/download.md
index 192b670..98d761d 100644
--- a/docs/download.md
+++ b/docs/download.md
@@ -12,6 +12,7 @@ Use the links below to download the Apache APISIX™ from one 
of our mirrors.
 
 | Version | Release Date | Downloads   



  |
 | --- |  | 
-
 |
+| 2.0 | 27/10/2020   | 
[source](https://www.apache.org/dyn/closer.cgi/apisix/2.0/apache-apisix-2.0-src.tgz)
 ([asc](https://downloads.apache.org/apisix/2.0/apache-apisix-2.0-src.tgz.asc) 
[sha512](https://downloads.apache.org/apisix/2.0/apache-apisix-2.0-src.tgz.sha512))
 | 1.5 | 05/08/2020   | 
[source](https://www.apache.org/dyn/closer.cgi/apisix/1.5/apache-apisix-1.5-src.tar.gz)
 
([asc](https://downloads.apache.org/apisix/1.5/apache-apisix-1.5-src.tar.gz.asc)
 
[sha512](https://downloads.apache.org/apisix/1.5/apache-apisix-1.5-src.tar.gz.sha512))
   |
 | 1.4.1   | 20/07/2020   | 
[source](https://www.apache.org/dyn/closer.cgi/apisix/1.4.1/apache-apisix-1.4.1-src.tar.gz)
 
([asc](https://downloads.apache.org/apisix/1.4.1/apache-apisix-1.4.1-src.tar.gz.asc)
 
[sha512](https://downloads.apache.org/apisix/1.4.1/apache-apisix-1.4.1-src.tar.gz.sha512))
   |
 | 1.4 | 29/06/2020   | 
[source](https://www.apache.org/dyn/closer.cgi/apisix/apisix/1.4/apache-apisix-1.4-incubating-src.tar.gz)
 
([asc](https://downloads.apache.org/apisix/apisix/1.4/apache-apisix-1.4-incubating-src.tar.gz.asc)
 
[sha512](https://downloads.apache.org/apisix/apisix/1.4/apache-apisix-1.4-incubating-src.tar.gz.sha512))
 |



[GitHub] [apisix-website] moonming opened a new pull request #80: doc: add 2.0 release.

2020-10-28 Thread GitBox


moonming opened a new pull request #80:
URL: https://github.com/apache/apisix-website/pull/80


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] nic-chen opened a new issue #620: requirement: issues to be solved after the `manager api` refactoring

2020-10-28 Thread GitBox


nic-chen opened a new issue #620:
URL: https://github.com/apache/apisix-dashboard/issues/620


   After the manager api refactoring, there are still many problems, as follow:
   
   1. Access log:
   Save to a local file, and can customize the path
   Support log rotate
   Support custom log format
   
   2.error log:
   Currently only panic logs are retained, errors are just respond by apis. we 
need to  retain error logs.
   Support custom error log level
   Support saving to a local file, and can customize the file path
   Support log rotate
   
   3. Support custom listening IP and port
   
   4. Support https, and custom cert and key path
   
   5. Support IP restriction
   
   6. ETCD configuration:
   Currently supports environment variable config, need to change to config in 
the config file
   Support https connection
   Support mTLS connection
   Support identity authentication
   
   7. Improve the ENV definition and deal with `dev`, `test` and `release` 
accordingly
   
   8. Support custom cup quantity
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] spacewander commented on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox


spacewander commented on issue #2554:
URL: https://github.com/apache/apisix/issues/2554#issuecomment-718337888


   It is a known issue.
   > NOTE: echo plugin is written as an example. There are some unhandled cases 
and you should not use it in the production!
   
   https://github.com/apache/apisix/blob/master/doc/plugins/echo.md
   
   The plugin doesn't set Content-Length correctly.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] dabue commented on a change in pull request #2488: feat: add error-log-logger plugin

2020-10-28 Thread GitBox


dabue commented on a change in pull request #2488:
URL: https://github.com/apache/apisix/pull/2488#discussion_r513924200



##
File path: apisix/plugins/error-log-logger.lua
##
@@ -0,0 +1,235 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements.  See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License.  You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core = require("apisix.core")
+local plugin_name = "error-log-logger"
+local errlog = require "ngx.errlog"
+local batch_processor = require("apisix.utils.batch-processor")
+local table = core.table
+local ngx = ngx
+local tcp = ngx.socket.tcp
+local select = select
+local type = type
+local string = string
+local tostring = tostring
+local buffers
+local timer
+local schema = {
+type = "object",
+properties = {
+host = {type = "string"},
+port = {type = "integer", minimum = 0},
+tls = {type = "boolean", default = false},
+tls_options = {type = "string"},
+timeout = {type = "integer", minimum = 1, default= 3},
+keepalive = {type = "integer", minimum = 1, default= 30},
+name = {type = "string", default = "tcp logger"},
+level = {type = "string", default = "WARN"},
+batch_max_size = {type = "integer", minimum = 0, default = 1000},
+max_retry_count = {type = "integer", minimum = 0, default = 0},
+retry_delay = {type = "integer", minimum = 0, default = 1},
+buffer_duration = {type = "integer", minimum = 1, default = 60},
+inactive_timeout = {type = "integer", minimum = 1, default = 5},
+},
+additionalProperties = false,
+}
+
+local log_level = {
+STDERR =ngx.STDERR,
+EMERG  =ngx.EMERG,
+ALERT  =ngx.ALERT,
+CRIT   =ngx.CRIT,
+ERR=ngx.ERR,
+ERROR  =ngx.ERR,
+WARN   =ngx.WARN,
+NOTICE = ngx.NOTICE,
+INFO   =ngx.INFO,
+DEBUG  =ngx.DEBUG
+}
+
+local config = {
+name = plugin_name,
+timeout = 3,
+keepalive = 30,
+level = "WARN",
+tls = false,
+retry_delay = 1,
+batch_max_size = 1000,
+max_retry_count = 0,
+buffer_duration = 60,
+inactive_timeout = 5,
+}
+local _M = {
+version = 0.1,
+priority = 1091,
+name = plugin_name,
+schema = schema,
+}
+
+
+function _M.check_schema(conf)
+return core.schema.check(schema, conf)
+end
+
+
+local function try_attr(t, ...)
+local count = select('#', ...)
+for i = 1, count do
+local attr = select(i, ...)
+t = t[attr]
+if type(t) ~= "table" then
+return false
+end
+end
+
+return true
+end
+
+local function load_attr()
+local local_conf = core.config.local_conf()
+if try_attr(local_conf, "plugin_attr", plugin_name) then
+local attr = local_conf.plugin_attr[plugin_name]
+config.host = attr.host

Review comment:
   has updated it 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] thekingofworld commented on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox


thekingofworld commented on issue #2554:
URL: https://github.com/apache/apisix/issues/2554#issuecomment-718339899


   @spacewander  > The plugin doesn't set Content-Length correctly.
   It seems to be the problem.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] thekingofworld edited a comment on issue #2554: request help: abnormal output after using echo plugin

2020-10-28 Thread GitBox


thekingofworld edited a comment on issue #2554:
URL: https://github.com/apache/apisix/issues/2554#issuecomment-718339899







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] nic-chen opened a new issue #621: requirement: Support custom listening IP and port for manager api

2020-10-28 Thread GitBox


nic-chen opened a new issue #621:
URL: https://github.com/apache/apisix-dashboard/issues/621


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [ ] Bug
   - [x] Requirements
   - [ ] Feature or performance improvement
   - [ ] Other
   
   ___
   ### Requirements or improvement
   
   Need to support custom listening IP and port for manager api
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix-dashboard] juzhiyuan commented on issue #615: v2.0-rc2 Build docker image error.

2020-10-28 Thread GitBox


juzhiyuan commented on issue #615:
URL: 
https://github.com/apache/apisix-dashboard/issues/615#issuecomment-718343149


   After discussions, we are going to fix this in 2.0 RC3, it will take no 
longer than 3 days.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   >