[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
codecov-io edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1) Report > Merging [#1245](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=desc) (b4f5310) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b659dfc6aff50ffbe7553824575a61aa69cbc409?el=desc) (b659dfc) will **decrease** coverage by `18.35%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1245 +/- ## === - Coverage 62.67% 44.31% -18.36% === Files 41 32-9 Lines2352 1963 -389 === - Hits 1474 870 -604 - Misses705 981 +276 + Partials 173 112 -61 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (-62.50%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (-27.66%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=footer). Last update [b659dfc...b4f5310](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3377: fix: ignore the case of configured host
Firstsawyou commented on a change in pull request #3377:
URL: https://github.com/apache/apisix/pull/3377#discussion_r561665732
##
File path: rockspec/apisix-master-0.rockspec
##
@@ -43,7 +43,7 @@ dependencies = {
"lua-resty-cookie = 0.1.0",
"lua-resty-session = 2.24",
"opentracing-openresty = 0.1",
-"lua-resty-radixtree = 2.6",
+"lua-resty-radixtree = 2.6.1",
Review comment:
Yes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #887: test: need e2e test to ensure JSONSchema default value works fine
nic-chen closed issue #887: URL: https://github.com/apache/apisix-dashboard/issues/887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #887: test: need e2e test to ensure JSONSchema default value works fine
nic-chen commented on issue #887: URL: https://github.com/apache/apisix-dashboard/issues/887#issuecomment-764450029 fixed by #906 and #1195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #192: chore: introduce ingress-types, rename ApisixTls to ApisixTLS
codecov-io edited a comment on pull request #192: URL: https://github.com/apache/apisix-ingress-controller/pull/192#issuecomment-764447488 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=h1) Report > Merging [#192](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=desc) (e81950f) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f5ee17fcabcaac24e70f6f3a24a2bd77099076de?el=desc) (f5ee17f) will **not change** coverage. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #192 +/- ## === Coverage 47.68% 47.68% === Files 32 32 Lines1883 1883 === Hits 898 898 Misses846 846 Partials 139 139 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3NlcnZpY2UuZ28=) | `0.00% <ø> (ø)` | | | [pkg/ingress/apisix/tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Rscy5nbw==) | `92.00% <0.00%> (ø)` | | | [pkg/ingress/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Vwc3RyZWFtLmdv) | `87.80% <100.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=footer). Last update [f5ee17f...e81950f](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #192: chore: introduce ingress-types, rename ApisixTls to ApisixTLS
tokers commented on pull request #192: URL: https://github.com/apache/apisix-ingress-controller/pull/192#issuecomment-764448797 @gxthrj Please take a look when you have time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1102: feat: import route from OpenAPI Specification3.0
juzhiyuan commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764448583 > Do we need to add **test cases** about > > 1. import a error file > 2. a file includes two or more APIs Yep This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
codecov-io edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1) Report > Merging [#1245](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=desc) (9cd063f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b659dfc6aff50ffbe7553824575a61aa69cbc409?el=desc) (b659dfc) will **decrease** coverage by `18.35%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1245 +/- ## === - Coverage 62.67% 44.31% -18.36% === Files 41 32-9 Lines2352 1963 -389 === - Hits 1474 870 -604 - Misses705 981 +276 + Partials 173 112 -61 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (-62.50%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (-27.66%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=footer). Last update [b659dfc...9cd063f](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-764447946 > it would be better to add three more test cases: > > * export a route created with upstream id > * export a route created with service which is created with upstream id > * export a route created with `basic-auth` plugin enabled I have added test cases for these three kinds of exports. Auth authentication has added the route export test cases opened by JWT plugin, and the following basic auth and API key will also be added. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #889: bug: manager-api allows adding route with uri and uris at the same time
nic-chen commented on issue #889: URL: https://github.com/apache/apisix-dashboard/issues/889#issuecomment-764448221 fixed by https://github.com/apache/apisix/pull/3008 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #889: bug: manager-api allows adding route with uri and uris at the same time
nic-chen closed issue #889: URL: https://github.com/apache/apisix-dashboard/issues/889 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean commented on a change in pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#discussion_r561660169
##
File path: api/test/e2e/route_export_test.go
##
@@ -0,0 +1,716 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package e2e
+
+import (
+ "net/http"
+ "strings"
+ "testing"
+)
+
+func TestRoute_Export(t *testing.T) {
+ exportStrR1 := `
+ "/hello_": {
+ "get": {
+ "operationId": "Get",
+ "requestBody": {},
+ "responses": {
+ "default": {
+ "description": ""
+ }
+ },
+ "security": [],
+ "x-apisix-enableWebsocket": false,
+ "x-apisix-hosts": ["foo.com",
"*.bar.com"],
+ "x-apisix-labels": {
+ "build": "16",
+ "env": "production",
+ "version": "v2"
+ },
+ "x-apisix-plugins": {
+ "limit-count": {
+ "count": 2,
+ "key": "remote_addr",
+ "rejected_code": 503,
+ "time_window": 60
+ }
+ },
+ "x-apisix-priority": 0,
+ "x-apisix-status": 1,
+ "x-apisix-upstream": {
+ "nodes": {
+ "172.16.238.20:1980": 1
+ },
+ "type": "roundrobin"
+ }
+ },
+ "post": {
+ "operationId": "Post",
+ "requestBody": {},
+ "responses": {
+ "default": {
+ "description": ""
+ }
+ },
+ "security": [],
+ "x-apisix-enableWebsocket": false,
+ "x-apisix-hosts": ["foo.com",
"*.bar.com"],
+ "x-apisix-labels": {
+ "build": "16",
+ "env": "production",
+ "version": "v2"
+ },
+ "x-apisix-plugins": {
+ "limit-count": {
+ "count": 2,
+ "key": "remote_addr",
+ "rejected_code": 503,
+ "time_window": 60
+ }
+ },
+ "x-apisix-priority": 0,
+ "x-apisix-status": 1,
+ "x-apisix-upstream": {
+ "nodes": {
+
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean commented on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-764447946 > it would be better to add three more test cases: > > * export a route created with upstream id > * export a route created with service which is created with upstream id > * export a route created with `basic-auth` plugin enabled > it would be better to add three more test cases: > > * export a route created with upstream id > * export a route created with service which is created with upstream id > * export a route created with `basic-auth` plugin enabled I have added test cases for these three kinds of exports. Auth authentication has added the route export test cases opened by JWT plugin, and the following basic auth and API key will also be added. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #192: chore: introduce ingress-types, rename ApisixTls to ApisixTLS
codecov-io commented on pull request #192: URL: https://github.com/apache/apisix-ingress-controller/pull/192#issuecomment-764447488 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=h1) Report > Merging [#192](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=desc) (3c5b0be) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f5ee17fcabcaac24e70f6f3a24a2bd77099076de?el=desc) (f5ee17f) will **not change** coverage. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #192 +/- ## === Coverage 47.68% 47.68% === Files 32 32 Lines1883 1883 === Hits 898 898 Misses846 846 Partials 139 139 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3NlcnZpY2UuZ28=) | `0.00% <ø> (ø)` | | | [pkg/ingress/apisix/tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Rscy5nbw==) | `92.00% <0.00%> (ø)` | | | [pkg/ingress/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Vwc3RyZWFtLmdv) | `87.80% <100.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=footer). Last update [f5ee17f...3c5b0be](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3372: feat: allow ETCD work without some special keys
Yiyiyimu commented on a change in pull request #3372:
URL: https://github.com/apache/apisix/pull/3372#discussion_r561659098
##
File path: apisix/core/config_etcd.lua
##
@@ -241,7 +241,11 @@ local function sync_data(self)
else
if not dir_res.nodes then
-dir_res.nodes = {}
+if dir_res.key then
+dir_res.nodes = { clone_tab(dir_res) }
Review comment:
Could you explain it a bit? I didn't get why could it solve the problem
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #192: chore: introduce ingress-types, rename ApisixTls to ApisixTLS
tokers opened a new pull request #192: URL: https://github.com/apache/apisix-ingress-controller/pull/192 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #679: feature: support https for `manager api`
nic-chen commented on issue #679: URL: https://github.com/apache/apisix-dashboard/issues/679#issuecomment-764445689 not urgent, we could move to next version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3372: feat: allow ETCD work without some special keys
Yiyiyimu commented on pull request #3372: URL: https://github.com/apache/apisix/pull/3372#issuecomment-764445514 Hi @yongboy it would be better if you write some test case to prove it's correctness This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3377: fix: ignore the case of configured host
spacewander commented on a change in pull request #3377:
URL: https://github.com/apache/apisix/pull/3377#discussion_r561655865
##
File path: rockspec/apisix-master-0.rockspec
##
@@ -43,7 +43,7 @@ dependencies = {
"lua-resty-cookie = 0.1.0",
"lua-resty-session = 2.24",
"opentracing-openresty = 0.1",
-"lua-resty-radixtree = 2.6",
+"lua-resty-radixtree = 2.6.1",
Review comment:
Better to use separate PR to update lua-resty-expr, as the fix doesn't
require to change it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #706: chore: need to write the error message into log
nic-chen commented on issue #706: URL: https://github.com/apache/apisix-dashboard/issues/706#issuecomment-764443679 fixed by #977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #706: chore: need to write the error message into log
nic-chen closed issue #706: URL: https://github.com/apache/apisix-dashboard/issues/706 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1102: feat: import route from OpenAPI Specification3.0
liuxiran commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764442783 Do we need to add **test cases** about 1. import a error file 2. a file includes two or more APIs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3377: fix: ignore the case of configured host
Firstsawyou commented on a change in pull request #3377:
URL: https://github.com/apache/apisix/pull/3377#discussion_r561654367
##
File path: rockspec/apisix-master-0.rockspec
##
@@ -43,7 +43,7 @@ dependencies = {
"lua-resty-cookie = 0.1.0",
"lua-resty-session = 2.24",
"opentracing-openresty = 0.1",
-"lua-resty-radixtree = 2.6",
+"lua-resty-radixtree = 2.6.1",
Review comment:
`lua-resty-expr` also released v1.1.0, I think it can be updated by the
way.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #886: test: need cross-testing between `manager api` and `admin api`
nic-chen commented on issue #886: URL: https://github.com/apache/apisix-dashboard/issues/886#issuecomment-764442067 We could handle it later, just before 3.0 version This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta edited a comment on issue #3380: bug: route's description input more than 200 Chinese characters, no error message, but the route is useless
idbeta edited a comment on issue #3380: URL: https://github.com/apache/apisix/issues/3380#issuecomment-764441819 > @idbeta > Can this issue be reproduced in the latest version of dashboard? Is there any error log in the APISIX size? > 1、can not more than 200 characters still can > 2、the route is useless no problem now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta commented on issue #3380: bug: route's description input more than 200 Chinese characters, no error message, but the route is useless
idbeta commented on issue #3380: URL: https://github.com/apache/apisix/issues/3380#issuecomment-764441819 > @idbeta > Can this issue be reproduced in the latest version of dashboard? Is there any error log in the APISIX size? > 1、Can not more than 200 characters still can > 2、the route is useless no problem now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1182: Dockerfile source code is COPY from the current version instead of remote download
juzhiyuan closed issue #1182: URL: https://github.com/apache/apisix-dashboard/issues/1182 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1182: Dockerfile source code is COPY from the current version instead of remote download
juzhiyuan commented on issue #1182: URL: https://github.com/apache/apisix-dashboard/issues/1182#issuecomment-764441363 The DockerHub maintains an image for Apache APISIX Dashboard[1], you could pull that image instead of the building by hand, and here is the issue[2] to track when to omit that Dockerfile. [1] https://hub.docker.com/r/apache/apisix-dashboard [2] https://github.com/apache/apisix-dashboard/issues/1265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3381: fix: markdownlint issue
moonming commented on pull request #3381: URL: https://github.com/apache/apisix/pull/3381#issuecomment-764440900 @Yiyiyimu thanks for you help This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on issue #3362: discuss: should we support the etcd missing some special keys case
Yiyiyimu commented on issue #3362: URL: https://github.com/apache/apisix/issues/3362#issuecomment-764439631 > I remember that if these keys (`/apisix/routes`, `/apisix/services`, etc.) do not exist, the ETCD watch will fail. > @Yiyiyimu please have a look. Yeah I remember the same. But lots of things got optimized after my attempt, and it would be great if we could get rid of them. I'll help to track the PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3383: request help: how do i know plugin Orchestration condition variables
spacewander commented on issue #3383: URL: https://github.com/apache/apisix/issues/3383#issuecomment-764439052 CC @juzhiyuan @nic-chen This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jaredhuang opened a new issue #3383: request help:
jaredhuang opened a new issue #3383: URL: https://github.com/apache/apisix/issues/3383 ### Issue description how do i know plugin Orchestration condition variables 。 In the video: [https://static.apiseven.com/low-code-api-gateway-example-en-US.mp4](https://static.apiseven.com/low-code-api-gateway-example-en-US.mp4) Condition is code == 403 , the keyword "code" is a variables? how do i know variables list ? ### Environment * apisix version (cmd: `apisix version`): 2.1 * OS: (cmd: `uname -a`) 5.8.0-1.el7.elrepo.x86_64 * OpenResty / Nginx version: (cmd: `nginx -V` or `openresty -V`) openresty/1.19.3.1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1238: sync plugins' testcases from apisix automatically
juzhiyuan commented on issue #1238: URL: https://github.com/apache/apisix-dashboard/issues/1238#issuecomment-764437885 all right, ping @membphis @nic-chen, any ideas about this feature? It seems a little cumbersome, if we could resolve this issue, there has no need to sync the dataset by hand anymore. But if we couldn't handle it easily and smoothly, we have to sync the dataset by hand. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1102: feat: import route from OpenAPI Specification3.0
liuxiran commented on a change in pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#discussion_r561648621
##
File path: api/test/e2e/import_test.go
##
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package e2e
+
+import (
+ "github.com/stretchr/testify/assert"
+ "github.com/tidwall/gjson"
+ "io/ioutil"
+ "net/http"
+ "path/filepath"
+ "testing"
+ "time"
+)
+
+func TestImport_default(t *testing.T) {
+ path, err := filepath.Abs("../testdata/import-test-default.yaml")
+ assert.Nil(t, err)
+
+ headers := map[string]string{
+ "Authorization": token,
+ }
+ files := []UploadFile{
+ {Name: "file", Filepath: path},
+ }
+ PostFile(ManagerAPIHost+"/apisix/admin/import", nil, files, headers)
+
+ // sleep for data sync
+ time.Sleep(sleepTime)
+
+ request, _ := http.NewRequest("GET",
ManagerAPIHost+"/apisix/admin/routes", nil)
+ request.Header.Add("Authorization", token)
+ resp, err := http.DefaultClient.Do(request)
+ assert.Nil(t, err)
+ defer resp.Body.Close()
+ respBody, _ := ioutil.ReadAll(resp.Body)
+ list := gjson.Get(string(respBody), "data.rows").Value().([]interface{})
+
+ var tests []HttpTestCase
+ for _, item := range list {
+ route := item.(map[string]interface{})
+ tc := HttpTestCase{
+ Desc: "route patch for update status(online)",
+ Object: ManagerApiExpect(t),
+ Method: http.MethodPatch,
+ Path: "/apisix/admin/routes/" +
route["id"].(string),
+ Body: `{"status":1}`,
+ Headers: map[string]string{"Authorization": token},
+ ExpectStatus: http.StatusOK,
+ Sleep:sleepTime,
+ }
+ tests = append(tests, tc)
+ }
+
+ // verify route
+ tests = append(tests, HttpTestCase{
+ Desc: "verify the route just imported",
+ Object: APISIXExpect(t),
+ Method: http.MethodGet,
+ Path: "/hello",
+ ExpectStatus: http.StatusOK,
+ ExpectBody: "hello world",
+ Sleep:sleepTime,
+ })
+
+ // delete test data
+ for _, item := range list {
+ route := item.(map[string]interface{})
+ tc := HttpTestCase{
+ Desc: "delete route",
+ Object: ManagerApiExpect(t),
+ Method: http.MethodDelete,
+ Path: "/apisix/admin/routes/" +
route["id"].(string),
+ Headers: map[string]string{"Authorization": token},
+ ExpectStatus: http.StatusOK,
+ }
+ tests = append(tests, tc)
+ }
+
+ for _, tc := range tests {
+ testCaseCheck(tc, t)
+ }
+}
+
+func TestImport_json(t *testing.T) {
+ path, err := filepath.Abs("../testdata/import-test.json")
+ assert.Nil(t, err)
+
+ headers := map[string]string{
+ "Authorization": token,
+ }
+ files := []UploadFile{
+ {Name: "file", Filepath: path},
+ }
+ PostFile(ManagerAPIHost+"/apisix/admin/import", nil, files, headers)
+
+ // sleep for data sync
+ time.Sleep(sleepTime)
+
+ request, _ := http.NewRequest("GET",
ManagerAPIHost+"/apisix/admin/routes", nil)
+ request.Header.Add("Authorization", token)
+ resp, err := http.DefaultClient.Do(request)
+ assert.Nil(t, err)
+ defer resp.Body.Close()
+ respBody, _ := ioutil.ReadAll(resp.Body)
+ list := gjson.Get(string(respBody), "data.rows").Value().([]interface{})
+
+ var tests []HttpTestCase
+ for _, item := range list {
+ route := item.(map[string]interface{})
+ tc := HttpTestCase{
+ Desc: "route
[GitHub] [apisix] Firstsawyou opened a new pull request #3382: chore: The 500 response code in the upstream.lua file was changed to 503 response code
Firstsawyou opened a new pull request #3382: URL: https://github.com/apache/apisix/pull/3382 ### What this PR does / why we need it: fix #3374 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2101: feat: customed config.yaml when apisix start
Yiyiyimu commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r561647161
##
File path: apisix/cli/ops.lua
##
@@ -390,6 +392,21 @@ local function start(env, ...)
end
end
+local parser = argparse()
+parser:argument("_", "Placeholder")
+parser:option("-c --config", "location of customized config.yaml")
+local args = parser:parse()
+local customized_yaml = args["config"]
+
+profile.apisix_home = env.apisix_home .. "/"
+local local_conf_path = profile:yaml_path("config")
+
+if customized_yaml then
+execute("mv " .. local_conf_path .. " " .. local_conf_path .. ".bak")
Review comment:
PTAL
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #758: [DISCUSS] Create a new file to generalize error response
starsz commented on issue #758: URL: https://github.com/apache/apisix-dashboard/issues/758#issuecomment-764434972 This will be discussed in M2.4 and finished in M2.5. cc @juzhiyuan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1161: Feat: remove the etcd dependency in the unit test
starsz commented on issue #1161: URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-764434550 This is a big project, I will finish part of them in M2.4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1127: bug: manager-api doesn't support PATCH method
starsz commented on issue #1127: URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-764434256 @juzhiyuan Help me move to M2.5. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] fukiki commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX
fukiki commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r561645938 ## File path: bin/apisix ## @@ -1,36 +1,41 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or more --- contributor license agreements. See the NOTICE file distributed with --- this work for additional information regarding copyright ownership. --- The ASF licenses this file to You under the Apache License, Version 2.0 --- (the "License"); you may not use this file except in compliance with --- the License. You may obtain a copy of the License at --- --- http://www.apache.org/licenses/LICENSE-2.0 --- --- Unless required by applicable law or agreed to in writing, software --- distributed under the License is distributed on an "AS IS" BASIS, --- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --- See the License for the specific language governing permissions and --- limitations under the License. --- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# -local pkg_cpath_org = package.cpath -local pkg_path_org = package.path +USE_LUA=true +LUA_VERSION=$(lua -v 2>&1 | grep -E -o "Lua [0-9]+.[0-9]+") -local apisix_home = "/usr/local/apisix" -local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;" - .. apisix_home .. "/deps/lib/lua/5.1/?.so;;" -local pkg_path = apisix_home .. "/deps/share/lua/5.1/?.lua;;" +if [ -s './apisix/cli/apisix.lua' ]; then +APISIX_LUA=./apisix/cli/apisix.lua +else +APISIX_LUA=/usr/share/lua/5.1/apisix/cli/apisix.lua Review comment: There are two installation paths for apisix, I would add conditions to distinguish it. @tokers @Fuchange This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu opened a new pull request #3381: fix CI
Yiyiyimu opened a new pull request #3381: URL: https://github.com/apache/apisix/pull/3381 Signed-off-by: yiyiyimu ### What this PR does / why we need it: Caused by #3368, an extra blank is not removed in time, so markdownlint would keep failing ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] fukiki commented on pull request #3368: doc: add good first issue links.
fukiki commented on pull request #3368: URL: https://github.com/apache/apisix/pull/3368#issuecomment-764433368 @moonming  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1127: bug: manager-api doesn't support PATCH method
starsz commented on issue #1127: URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-764432654 Not urgent, I think this should be done in M2.5. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] liodo198592 opened a new pull request #191: fix：BUGFIX #182 ,add write permisson of resource:leases in apisix_vie…
liodo198592 opened a new pull request #191: URL: https://github.com/apache/apisix-ingress-controller/pull/191 …w_clusterrole.yaml Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3374: Modify the 500 response code in the upstream.lua file to 503 response code
spacewander commented on issue #3374: URL: https://github.com/apache/apisix/issues/3374#issuecomment-764432581 OK, let's do it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] spacewander commented on issue #1238: sync plugins' testcases from apisix automatically
spacewander commented on issue #1238: URL: https://github.com/apache/apisix-dashboard/issues/1238#issuecomment-764432147 I don't any idea unless we modify the code of APISIX and dump the data we used. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3380: bug: route's description input more than 200 Chinese characters, no error message, but the route is useless
spacewander commented on issue #3380: URL: https://github.com/apache/apisix/issues/3380#issuecomment-764431095 @idbeta Can this issue be reproduced in the latest version of dashboard? Is there any error log in the APISIX size? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3380: bug: route's description input more than 200 Chinese characters, no error message, but the route is useless
spacewander commented on issue #3380: URL: https://github.com/apache/apisix/issues/3380#issuecomment-764428267 Hey guys. Something you don't make it correct from the beginning: https://github.com/api7/jsonschema/blob/b9375642eb2da0f20486a38025e511a12687b5d4/lib/jsonschema.lua#L365 The Lua implementation doesn't use `#` to get the length of data. Instead, it counts the string length instead of the string bytes. > If we need to limit the length of use input characters, we'd better limit the string length instead of string byte length Yes. We have already done this. Maybe there is something else causes the problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #190: * chore:add ginkgo check before e2e-test(apache #186)
codecov-io commented on pull request #190: URL: https://github.com/apache/apisix-ingress-controller/pull/190#issuecomment-764424799 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=h1) Report > Merging [#190](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=desc) (9db3fdd) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0615aea1228ae7a05f2c6dd230f74b2b38e46fc4?el=desc) (0615aea) will **decrease** coverage by `0.96%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=tree) ```diff @@Coverage Diff @@ ## master #190 +/- ## == - Coverage 48.65% 47.68% -0.97% == Files 30 32 +2 Lines1482 1883 +401 == + Hits 721 898 +177 - Misses675 846 +171 - Partials 86 139 +53 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `71.42% <0.00%> (-28.58%)` | :arrow_down: | | [pkg/apisix/service.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9zZXJ2aWNlLmdv) | `47.54% <0.00%> (-19.71%)` | :arrow_down: | | [pkg/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC91cHN0cmVhbS5nbw==) | `51.72% <0.00%> (-18.16%)` | :arrow_down: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `46.45% <0.00%> (-16.45%)` | :arrow_down: | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `53.84% <0.00%> (-11.73%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `31.77% <0.00%> (-7.12%)` | :arrow_down: | | [pkg/seven/state/builder.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL2J1aWxkZXIuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/seven/state/service\_worker.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL3NlcnZpY2Vfd29ya2VyLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `66.36% <0.00%> (ø)` | | | [pkg/id/idgen.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree#diff-cGtnL2lkL2lkZ2VuLmdv) | `100.00% <0.00%> (ø)` | | | ... and [2 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=footer). Last update [0615aea...9db3fdd](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] imjoey commented on pull request #3365: test: add shell script for run APISIX testcases on ARM64
imjoey commented on pull request #3365: URL: https://github.com/apache/apisix/pull/3365#issuecomment-764424135 @idbeta Just FYI, for redis 5.x ARM64 image, simply run `docker pull isrc.iscas.ac.cn/oepkgs/kubernetes/library/redis:5.0.5-alpine` to fetch the pre-built image. Noted that it's only for Kunpeng-920. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] cao19881125 opened a new pull request #190: * chore:add ginkgo check before e2e-test(apache #186)
cao19881125 opened a new pull request #190: URL: https://github.com/apache/apisix-ingress-controller/pull/190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1238: sync plugins' testcases from apisix automatically
juzhiyuan commented on issue #1238: URL: https://github.com/apache/apisix-dashboard/issues/1238#issuecomment-764423530 Hi @spacewander @starsz, do we have any quick ideas to export those test cases from Lua? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version
juzhiyuan commented on issue #1165: URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-764418795 **Backend** - Provide the `version_check` API; **Frontend** - Call the above API when the page first shows, once. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3344: feat: support gRPC over SSL
membphis commented on issue #3344: URL: https://github.com/apache/apisix/issues/3344#issuecomment-764418234 I think we can fix this issue in milestone 2.3 (this month) @JanLi-air This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #3380: bug: route's description input more than 200 Chinese characters, no error message, but the route is useless
juzhiyuan commented on issue #3380: URL: https://github.com/apache/apisix/issues/3380#issuecomment-764413569 @nic-chen Please leave your comments :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta opened a new issue #3380: bug: route's description input more than 200 Chinese characters, no error message, but the route is useless
idbeta opened a new issue #3380:
URL: https://github.com/apache/apisix/issues/3380
- Why do you submit this issue?
- [ ] Question or discussion
- [x] Bug
- [ ] Requirements
- [ ] Feature or performance improvement
- [ ] Other
Route's description can input more than 200 Chinese characters, no error,
but the route is useless.
In fact:
the route's useless, but the etcd will store the route data
```shell
$ curl http://127.0.0.1:9080/404.html
{"error_msg":"404 Route Not Found"}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2101: feat: customed config.yaml when apisix start
Yiyiyimu commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r561629722
##
File path: .travis/apisix_cli_test/test_main.sh
##
@@ -500,6 +500,43 @@ fi
sed -i 's/worker_processes: 2/worker_processes: auto/' conf/config.yaml
echo "passed: worker_processes number is configurable"
+# check customized config.yaml is copied and reverted.
+
+git checkout conf/config.yaml
+
+echo "
+apisix:
+admin_api_mtls:
+admin_ssl_cert: '../t/certs/apisix_admin_ssl.crt'
+admin_ssl_cert_key: '../t/certs/apisix_admin_ssl.key'
+port_admin: 9180
+https_admin: true
+" > conf/customized_config.yaml
+
+make init
+
+./bin/apisix start -c conf/customized_config.yaml
+
+code=$(curl -k -i -m 20 -o /dev/null -s -w %{http_code}
https://127.0.0.1:9180/apisix/admin/routes -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1')
+if [ ! $code -eq 200 ]; then
+echo "failed: customized config.yaml copied failed"
+exit 1
+fi
+# to revert the customized config and start a new one
+make stop
+
+./bin/apisix start
+
+code=$(curl -k -i -m 20 -o /dev/null -s -w %{http_code}
https://127.0.0.1:9180/apisix/admin/routes -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1')
Review comment:
Maybe I could compare if after `make stop`, is `config.yaml` still the
same with the original one
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2101: feat: customed config.yaml when apisix start
Yiyiyimu commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r561629415
##
File path: .travis/apisix_cli_test/test_main.sh
##
@@ -500,6 +500,43 @@ fi
sed -i 's/worker_processes: 2/worker_processes: auto/' conf/config.yaml
echo "passed: worker_processes number is configurable"
+# check customized config.yaml is copied and reverted.
+
+git checkout conf/config.yaml
+
+echo "
+apisix:
+admin_api_mtls:
+admin_ssl_cert: '../t/certs/apisix_admin_ssl.crt'
+admin_ssl_cert_key: '../t/certs/apisix_admin_ssl.key'
+port_admin: 9180
+https_admin: true
+" > conf/customized_config.yaml
+
+make init
+
+./bin/apisix start -c conf/customized_config.yaml
+
+code=$(curl -k -i -m 20 -o /dev/null -s -w %{http_code}
https://127.0.0.1:9180/apisix/admin/routes -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1')
+if [ ! $code -eq 200 ]; then
+echo "failed: customized config.yaml copied failed"
+exit 1
+fi
+# to revert the customized config and start a new one
+make stop
+
+./bin/apisix start
+
+code=$(curl -k -i -m 20 -o /dev/null -s -w %{http_code}
https://127.0.0.1:9180/apisix/admin/routes -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1')
Review comment:
This line would return code `0` since connection refused, so it would be
trapped and `clean_up` will execute
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] imjoey commented on pull request #3365: test: add shell script for run APISIX testcases on ARM64
imjoey commented on pull request #3365: URL: https://github.com/apache/apisix/pull/3365#issuecomment-764410536 > That is great, thank you. If want to run CI completely under ARM64, need to solve another problem is many CI-dependent docker images do not have an ARM64 version. > > > grpc_server_example —— no, we are working on it > > redis —— no @idbeta we have built two redis 5.x of images under ARM64 architecture, for Kunpeng-920 and for FT-2000 each. Where do you locate the images in? I'm happy to upload them if needed. > > mendhak/http-https-echo —— no > > sshniro/keycloak-apisix —— no > > bitnami/zookeeper —— no > > bitnami/kafka —— yes，ligato/kafka-arm64 > > bitinit/eureka —— no > > apache/skywalking-oap-server —— no @idbeta yep, this indeed is a tough problem. openEuler community is dedicating to the ARM64 docker images of various applications. I would keep an eye on it. Meanwhile, we could compile them locally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: doc: add good first issue links. (#3368)
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 985c354 doc: add good first issue links. (#3368) 985c354 is described below commit 985c35406645e12df1cc11dbf0eec18b6abc7066 Author: Wen Ming AuthorDate: Thu Jan 21 14:21:37 2021 +0800 doc: add good first issue links. (#3368) --- README.md| 66 +++- README_CN.md | 59 +++-- 2 files changed, 32 insertions(+), 93 deletions(-) diff --git a/README.md b/README.md index b12e6a6..13e1c50 100644 --- a/README.md +++ b/README.md @@ -19,51 +19,34 @@ # Apache APISIX +https://svn.apache.org/repos/asf/comdev/project-logos/originals/apisix.svg; alt="APISIX logo" height="150px" align="right" /> + [](https://github.com/apache/apisix/actions) [](https://github.com/apache/apisix/blob/master/LICENSE) - - https://github.com/apache/apisix;>English • - https://github.com/apache/apisix/blob/master/README_CN.md;>中文 - - - - https://apisix.apache.org/;>Website • - https://github.com/apache/apisix/tree/master/doc;>Docs • - https://github.com/apache/apisix-dashboard;>Dashboard • - https://twitter.com/apacheapisix;>Twitter - - -## What's Apache APISIX? - -Apache APISIX is a dynamic, real-time, high-performance API gateway, based on the Nginx library and etcd. +**Apache APISIX** is a dynamic, real-time, high-performance API gateway. APISIX provides rich traffic management features such as load balancing, dynamic upstream, canary release, circuit breaking, authentication, observability, and more. You can use Apache APISIX to handle traditional north-south traffic, as well as east-west traffic between services. -It can also be used as a k8s ingress controller. +It can also be used as a [k8s ingress controller](https://github.com/apache/apisix-ingress-controller). The technical architecture of Apache APISIX:  -## Contents - -- [Features](#features) -- [Documentation](#documentation) -- [Get Started](#get-started) -- [Benchmark](#benchmark) -- [Apache APISIX vs Kong](#apache-apisix-vs-kong) -- [Community](#community) -- [Videos And Articles](#videos-and-articles) -- [User Stories](#user-stories) -- [Who Uses APISIX?](#who-uses-apisix) -- [Landscape](#landscape) -- [Logos](#logos) -- [Contributing](#contributing) -- [Acknowledgments](#acknowledgments) -- [License](#license) +## Community + +- Mailing List: Mail to dev-subscr...@apisix.apache.org, follow the reply to subscribe the mailing list. +- QQ Group - 578997126 +- [Slack Workspace](http://s.apache.org/slack-invite) - join `#apisix` on our Slack to meet the team and ask questions +-  - follow and interact with us using hashtag `#ApacheAPISIX` +- [bilibili video](https://space.bilibili.com/551921247) +- **Good first issues**: + - [Apache APISIX](https://github.com/apache/apisix/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [Apache APISIX ingress controller](https://github.com/apache/apisix-ingress-controller/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [Apache APISIX dashboard](https://github.com/apache/apisix-dashboard/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) ## Features @@ -143,16 +126,13 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against - [Fault Injection](doc/plugins/fault-injection.md) - [REST Admin API](doc/admin-api.md): Using the REST Admin API to control Apache APISIX, which only allows 127.0.0.1 access by default, you can modify the `allow_admin` field in `conf/config.yaml` to specify a list of IPs that are allowed to call the Admin API. Also note that the Admin API uses key auth to verify the identity of the caller. **The `admin_key` field in `conf/config.yaml` needs to be modified before deployment to ensure security**. - External Loggers: Export access logs to external log management tools. ([HTTP Logger](doc/plugins/http-logger.md), [TCP Logger](doc/plugins/tcp-logger.md), [Kafka Logger](doc/plugins/kafka-logger.md), [UDP Logger](doc/plugins/udp-logger.md)) + - [Helm charts](https://github.com/apache/apisix-helm-chart) - **Highly scalable** - [Custom plugins](doc/plugin-develop.md): Allows hooking of common phases, such as `rewrite`, `access`, `header filer`, `body filter` and `log`, also allows to hook the `balancer` stage. - Custom load balancing algorithms: You can use custom load balancing algorithms during the `balancer` phase. - Custom routing: Support users to
[GitHub] [apisix] moonming merged pull request #3368: doc: add good first issue links.
moonming merged pull request #3368: URL: https://github.com/apache/apisix/pull/3368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Fuchange commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX
Fuchange commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r561623196 ## File path: bin/apisix ## @@ -1,36 +1,41 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or more --- contributor license agreements. See the NOTICE file distributed with --- this work for additional information regarding copyright ownership. --- The ASF licenses this file to You under the Apache License, Version 2.0 --- (the "License"); you may not use this file except in compliance with --- the License. You may obtain a copy of the License at --- --- http://www.apache.org/licenses/LICENSE-2.0 --- --- Unless required by applicable law or agreed to in writing, software --- distributed under the License is distributed on an "AS IS" BASIS, --- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --- See the License for the specific language governing permissions and --- limitations under the License. --- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# -local pkg_cpath_org = package.cpath -local pkg_path_org = package.path +USE_LUA=true +LUA_VERSION=$(lua -v 2>&1 | grep -E -o "Lua [0-9]+.[0-9]+") -local apisix_home = "/usr/local/apisix" -local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;" - .. apisix_home .. "/deps/lib/lua/5.1/?.so;;" -local pkg_path = apisix_home .. "/deps/share/lua/5.1/?.lua;;" +if [ -s './apisix/cli/apisix.lua' ]; then +APISIX_LUA=./apisix/cli/apisix.lua +else +APISIX_LUA=/usr/share/lua/5.1/apisix/cli/apisix.lua Review comment: i agree with you . if people installed apisix by `make install` , it will be ok. but if people installed it by apisix rpm-package , apisix.lua will in ` /usr/local/apisix/apisix/cli/ ` @tokers Should we integrate these two paths? After all, bash can't easily find multiple paths like Lua. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Fuchange commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX
Fuchange commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r561623196 ## File path: bin/apisix ## @@ -1,36 +1,41 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or more --- contributor license agreements. See the NOTICE file distributed with --- this work for additional information regarding copyright ownership. --- The ASF licenses this file to You under the Apache License, Version 2.0 --- (the "License"); you may not use this file except in compliance with --- the License. You may obtain a copy of the License at --- --- http://www.apache.org/licenses/LICENSE-2.0 --- --- Unless required by applicable law or agreed to in writing, software --- distributed under the License is distributed on an "AS IS" BASIS, --- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --- See the License for the specific language governing permissions and --- limitations under the License. --- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# -local pkg_cpath_org = package.cpath -local pkg_path_org = package.path +USE_LUA=true +LUA_VERSION=$(lua -v 2>&1 | grep -E -o "Lua [0-9]+.[0-9]+") -local apisix_home = "/usr/local/apisix" -local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;" - .. apisix_home .. "/deps/lib/lua/5.1/?.so;;" -local pkg_path = apisix_home .. "/deps/share/lua/5.1/?.lua;;" +if [ -s './apisix/cli/apisix.lua' ]; then +APISIX_LUA=./apisix/cli/apisix.lua +else +APISIX_LUA=/usr/share/lua/5.1/apisix/cli/apisix.lua Review comment: i agree with you . if people installed apisix by `make install` , it will be ok. but if people installed it by apisix rpm-package , apisix.lua will in ` /usr/local/apisix/apisix/cli/ ` Should we integrate these two paths? After all, bash can't easily find multiple paths like Lua. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey edited a comment on issue #1154: Resource create request should return the ultimate data
imjoey edited a comment on issue #1154: URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950 Hi all, since both #1277 and #1322 had been merged, I would close this issue. Please feel free to reopen it if anything unexpected. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey edited a comment on issue #1154: Resource create request should return the ultimate data
imjoey edited a comment on issue #1154: URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950 @tokers @juzhiyuan since both #1277 and #1322 had been merged, I would close this issue. Please feel free to reopen it if anything unexpected. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1154: Resource create request should return the ultimate data
imjoey commented on issue #1154: URL: https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950 @tokers @juzhiyuan since both #1277 and #1322 had been merged, I could close this issue. Please feel free to reopen it if anything unexpected. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey closed issue #1154: Resource create request should return the ultimate data
imjoey closed issue #1154: URL: https://github.com/apache/apisix-dashboard/issues/1154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta edited a comment on pull request #3365: test: add shell script for run APISIX testcases on ARM64
idbeta edited a comment on pull request #3365: URL: https://github.com/apache/apisix/pull/3365#issuecomment-764354513 > @idbeta Huawei is working on donating ARM CI resources to various open source community to leverage the ARM ecosystem. AFAIK, Apache Flink and Apache Kudu are both using the ARM virtual machines provisioned by [OpenLab Testing](https://openlabtesting.org) for ARM CI. So I could ask OpenLab for helping us delivering the ARM CI and version releases. That is great, thank you. If want to run CI completely under ARM64, need to solve another problem is many CI-dependent docker images do not have an ARM64 version. >grpc_server_example —— no, we are working on it redis —— no mendhak/http-https-echo —— no sshniro/keycloak-apisix —— no bitnami/zookeeper —— no bitnami/kafka —— yes，ligato/kafka-arm64 bitinit/eureka —— no apache/skywalking-oap-server —— no This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #3379: feat: remove restriction of label pattern to support Chinese
Firstsawyou commented on pull request #3379: URL: https://github.com/apache/apisix/pull/3379#issuecomment-764396783 Looks good to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX
tokers commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r561610634 ## File path: bin/apisix ## @@ -1,36 +1,41 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or more --- contributor license agreements. See the NOTICE file distributed with --- this work for additional information regarding copyright ownership. --- The ASF licenses this file to You under the Apache License, Version 2.0 --- (the "License"); you may not use this file except in compliance with --- the License. You may obtain a copy of the License at --- --- http://www.apache.org/licenses/LICENSE-2.0 --- --- Unless required by applicable law or agreed to in writing, software --- distributed under the License is distributed on an "AS IS" BASIS, --- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --- See the License for the specific language governing permissions and --- limitations under the License. --- +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# -local pkg_cpath_org = package.cpath -local pkg_path_org = package.path +USE_LUA=true +LUA_VERSION=$(lua -v 2>&1 | grep -E -o "Lua [0-9]+.[0-9]+") -local apisix_home = "/usr/local/apisix" -local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;" - .. apisix_home .. "/deps/lib/lua/5.1/?.so;;" -local pkg_path = apisix_home .. "/deps/share/lua/5.1/?.lua;;" +if [ -s './apisix/cli/apisix.lua' ]; then +APISIX_LUA=./apisix/cli/apisix.lua +else +APISIX_LUA=/usr/share/lua/5.1/apisix/cli/apisix.lua Review comment: I'm afraid the path is not so common, people may suffer "file not found" problem in different OS. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta edited a comment on pull request #3365: test: add shell script for run APISIX testcases on ARM64
idbeta edited a comment on pull request #3365: URL: https://github.com/apache/apisix/pull/3365#issuecomment-764354513 > @idbeta Huawei is working on donating ARM CI resources to various open source community to leverage the ARM ecosystem. AFAIK, Apache Flink and Apache Kudu are both using the ARM virtual machines provisioned by [OpenLab Testing](https://openlabtesting.org) for ARM CI. So I could ask OpenLab for helping us delivering the ARM CI and version releases. That is great, i am looking forward to it, thank you. If want to run CI completely under ARM64, need to solve another problem is many CI-dependent docker images do not have an ARM64 version. >grpc_server_example —— no, we are working on it redis —— no mendhak/http-https-echo —— no sshniro/keycloak-apisix —— no bitnami/zookeeper —— no bitnami/kafka —— yes，ligato/kafka-arm64 bitinit/eureka —— no apache/skywalking-oap-server —— no This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta commented on pull request #3365: test: add shell script for run APISIX testcases on ARM64
idbeta commented on pull request #3365: URL: https://github.com/apache/apisix/pull/3365#issuecomment-764354513 > @idbeta Huawei is working on donating ARM CI resources to various open source community to leverage the ARM ecosystem. AFAIK, Apache Flink and Apache Kudu are both using the ARM virtual machines provisioned by [OpenLab Testing](https://openlabtesting.org) for ARM CI. So I could ask OpenLab for helping us delivering the ARM CI and version releases. That is great, i am looking forward to it, thank you. If want to run CI completely under ARM64, need to solve another problem that many CI-dependent docker images do not have an ARM64 version. >grpc_server_example —— no, we are working on it redis —— no mendhak/http-https-echo —— no sshniro/keycloak-apisix —— no bitnami/zookeeper —— no bitnami/kafka —— yes，ligato/kafka-arm64 bitinit/eureka —— no apache/skywalking-oap-server —— no This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3379: feat: remove restriction of label pattern to support Chinese
tokers commented on a change in pull request #3379:
URL: https://github.com/apache/apisix/pull/3379#discussion_r561607289
##
File path: apisix/schema_def.lua
##
@@ -81,7 +81,6 @@ local remote_addr_def = {
local label_value_def = {
description = "value of label",
type = "string",
-pattern = [[^[a-zA-Z0-9-_.]+$]],
Review comment:
I think whitespaces should still be restricted.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3374: Modify the 500 response code in the upstream.lua file to 503 response code
Firstsawyou commented on issue #3374: URL: https://github.com/apache/apisix/issues/3374#issuecomment-764351519 > This will break the compatibility. Is there a strong reason to do the change? The 500 response code represents a problem caused by an error in the program code. However, this is caused by no upstream available. Obviously, the 500 response code is not standardized, which makes people understand that there is a bug in the code program. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1341: test: user can skip upstream when select service_id
guoqqqi opened a new pull request #1341: URL: https://github.com/apache/apisix-dashboard/pull/1341 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues resolve #1302 ___ ### New feature or improvement - Describe the details and related test reports. add test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2101: feat: customed config.yaml when apisix start
Yiyiyimu commented on a change in pull request #2101: URL: https://github.com/apache/apisix/pull/2101#discussion_r561602243 ## File path: Makefile ## @@ -98,7 +98,7 @@ endif ### stop: Stop the apisix server .PHONY: stop stop: default - $(OR_EXEC) -p $$PWD/ -c $$PWD/conf/nginx.conf -s stop + ./bin/apisix stop Review comment: sync to init/run This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1331: feat: Better design for the Create and Update methods of Store interface
imjoey commented on issue #1331:
URL:
https://github.com/apache/apisix-dashboard/issues/1331#issuecomment-764290323
@ShiningRush @starsz
I refer to the implementations of the `rest.Store` and `Storage` in
Kubernetes APIServer. From the following code snippet (refer to
https://github.com/kubernetes/apiserver/blob/5c8a24e0c50e5392e4766e59b41732074cd303c6/pkg/storage/interfaces.go#L214-L245
.), I get that the `Update` interface of `Storage` does not have returned
data, just as the `Storage` interface we defined in apisix-dashboard.
```go
// GuaranteedUpdate keeps calling 'tryUpdate()' to update key 'key' (of
type 'ptrToType')
// retrying the update until success if there is index conflict.
// Note that object passed to tryUpdate may change across invocations
of tryUpdate() if
// other writers are simultaneously updating it, so tryUpdate() needs
to take into account
// the current contents of the object when deciding how the update
object should look.
// If the key doesn't exist, it will return NotFound storage error if
ignoreNotFound=false
// or zero value in 'ptrToType' parameter otherwise.
// If the object to update has the same value as previous, it won't do
any update
// but will return the object in 'ptrToType' parameter.
// If 'cachedExistingObject' is non-nil, it can be used as a suggestion
about the
// current version of the object to avoid read operation from storage
to get it.
// However, the implementations have to retry in case suggestion is
stale.
//
// Example:
//
// s := /* implementation of Interface */
// err := s.GuaranteedUpdate(
// "myKey", {}, true,
// func(input runtime.Object, res ResponseMeta) (runtime.Object,
*uint64, error) {
// // Before each invocation of the user defined function,
"input" is reset to
// // current contents for "myKey" in database.
// curr := input.(*MyType) // Guaranteed to succeed.
//
// // Make the modification
// curr.Counter++
//
// // Return the modified object - return an error to stop
iterating. Return
// // a uint64 to alter the TTL on the object, or nil to keep it
the same value.
// return cur, nil, nil
//},
// )
GuaranteedUpdate(
ctx context.Context, key string, ptrToType runtime.Object,
ignoreNotFound bool,
precondtions *Preconditions, tryUpdate UpdateFunc,
cachedExistingObject runtime.Object) error
```
While regarding to the `Store`, we could see it does support returned the
new value for the `Update` interface, shown as below ( refer to
https://github.com/kubernetes/kubernetes/blob/a04b6e4b1671810ede5b8cacf4527741781d6fb9/staging/src/k8s.io/apiserver/pkg/registry/rest/rest.go#L276)
.
```go
// StandardStorage is an interface covering the common verbs. Provided for
testing whether a
// resource satisfies the normal storage methods. Use Storage when passing
opaque storage objects.
type StandardStorage interface {
Getter
Lister
CreaterUpdater
GracefulDeleter
CollectionDeleter
Watcher
}
// Updater is an object that can update an instance of a RESTful object.
type Updater interface {
// New returns an empty object that can be used with Update after
request data has been put into it.
// This object must be a pointer type for use with
Codec.DecodeInto([]byte, runtime.Object)
New() runtime.Object
// Update finds a resource in the storage and updates it. Some
implementations
// may allow updates creates the object - they should set the created
boolean
// to true.
Update(ctx context.Context, name string, objInfo UpdatedObjectInfo,
createValidation ValidateObjectFunc, updateValidation ValidateObjectUpdateFunc,
forceAllowCreate bool, options *metav1.UpdateOptions) (runtime.Object, bool,
error)
}
// CreaterUpdater is a storage object that must support both create and
update.
// Go prevents embedded interfaces that implement the same method.
type CreaterUpdater interface {
Creater
Update(ctx context.Context, name string, objInfo UpdatedObjectInfo,
createValidation ValidateObjectFunc, updateValidation ValidateObjectUpdateFunc,
forceAllowCreate bool, options *metav1.UpdateOptions) (runtime.Object, bool,
error)
}
```
So shall we keep the design the same as kubernetes for `Update` interface of
`Store` ? Very looking forward to your insights. @starsz @ShiningRush .
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[GitHub] [apisix] spacewander opened a new pull request #3379: feat: remove restriction of label pattern to support Chinese
spacewander opened a new pull request #3379: URL: https://github.com/apache/apisix/pull/3379 Fix #3378. Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3366: docs(traffic-split): update the vars example of the docs
Firstsawyou commented on a change in pull request #3366: URL: https://github.com/apache/apisix/pull/3366#discussion_r561595034 ## File path: doc/zh-cn/plugins/traffic-split.md ## @@ -55,12 +55,15 @@ traffic-split 插件使用户可以逐步引导各个上游之间的流量百分 traffic-split 插件主要由 `match` 和 `weighted_upstreams` 两部分组成，`match` 是自定义的条件规则，`weighted_upstreams` 是 upstream 的配置信息。如果配置 `match` 和 `weighted_upstreams` 信息，那么在 `match` 规则校验通过后，会根据 `weighted_upstreams` 中的 `weight` 值；引导插件中各个 upstream 之间的流量比例，否则，所有流量直接到达 `route` 或 `service` 上配置的 `upstream`。当然你也可以只配置 `weighted_upstreams` 部分，这样会直接根据 `weighted_upstreams` 中的 `weight` 值，引导插件中各个 upstream 之间的流量比例。 ->注：1、在 `match` 里，vars 中的表达式是 `and` 的关系，多个 `vars` 之间是 `or` 的关系。2、在插件的 weighted_upstreams 中只有 `weight` 值，表示到达 `route` 或 `service` 上配置的 upstream 流量权重值。如： +>注：1、在 `match` 里，vars 中的表达式是 `and` 的关系，多个 `vars` 之间是 `or` 的关系。2、在插件的 weighted_upstreams 中，若存在单独的 `weight` 字段，表示到达 `route` 或 `service` 上的 upstream 流量权重值。如： Review comment: updated. @tokers This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan opened a new issue #3378: Label feature doesn't support Chinese as key?
juzhiyuan opened a new issue #3378:
URL: https://github.com/apache/apisix/issues/3378
# Bug report
## Describe the bug
When I create a route with Label, an error occurred when using Chinese as
key.
## Expected behavior
A clear and concise description of what you expected to happen.
## Screenshots
## System information
- Version: master branch
## Additional context
```sh
$ curl 'http://139.217.190.60/apisix/admin/routes/337358106080052037' \
-X 'PUT' \
-H 'Accept: application/json' \
--data-binary
'{"name":"route_with_servicenoname","status":1,"methods":["GET","HEAD","POST","PUT","DELETE","OPTIONS","PATCH"],"priority":0,"uris":["/*"],"labels":{"分组1":"标签2","API_VERSION":"v1"},"vars":[],"upstream_id":"337065625484526491"}'
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3373: request help: The proxy-cache plugin overrides `Cache-Control` in upstream header.
spacewander commented on issue #3373: URL: https://github.com/apache/apisix/issues/3373#issuecomment-764257035 ``` proxy_hide_header Cache-Control; proxy_hide_header Expires; add_header Cache-Control $upstream_hdr_cache_control; add_header Expires $upstream_hdr_expires; add_header Apisix-Cache-Status $upstream_cache_status always; ``` We can remove them from the Nginx conf, and implement them in https://github.com/apache/apisix/blob/aff1a907a3671bd6610b304a54ebef47022ca6cf/apisix/plugins/proxy-cache.lua#L251 PR is welcome! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] imjoey commented on pull request #3365: test: add shell script for run APISIX testcases on ARM64
imjoey commented on pull request #3365: URL: https://github.com/apache/apisix/pull/3365#issuecomment-764245183 > —— I have talked with @membphis , it is not suitable for Apache project to use self-hosted method for CI testing, so it is good to provide manual testing script first. @idbeta Huawei is working on donating ARM CI resources to various open source community to leverage the ARM ecosystem. AFAIK, Apache Flink and Apache Kudu are both using the ARM virtual machines provisioned by [OpenLab Testing](https://openlabtesting.org) for ARM CI. So I could ask OpenLab for helping us delivering the ARM CI and version releases. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] unbeatablekb commented on pull request #3084: feat: add proxy_ssl_server_name
unbeatablekb commented on pull request #3084: URL: https://github.com/apache/apisix/pull/3084#issuecomment-764244848 @spacewander Thanks for your advice. I will do it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] unbeatablekb opened a new pull request #3084: feat: add proxy_ssl_server_name
unbeatablekb opened a new pull request #3084: URL: https://github.com/apache/apisix/pull/3084 ### What this PR does / why we need it: fix: #2988 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] unbeatablekb commented on pull request #3084: feat: add proxy_ssl_server_name
unbeatablekb commented on pull request #3084: URL: https://github.com/apache/apisix/pull/3084#issuecomment-764242549 @spacewander This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] unbeatablekb removed a comment on pull request #3084: feat: add proxy_ssl_server_name
unbeatablekb removed a comment on pull request #3084: URL: https://github.com/apache/apisix/pull/3084#issuecomment-764242549 @spacewander This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] unbeatablekb closed pull request #3084: feat: add proxy_ssl_server_name
unbeatablekb closed pull request #3084: URL: https://github.com/apache/apisix/pull/3084 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3372: feat: allow ETCD work without some special keys
spacewander commented on a change in pull request #3372:
URL: https://github.com/apache/apisix/pull/3372#discussion_r561589660
##
File path: apisix/core/config_etcd.lua
##
@@ -241,7 +241,11 @@ local function sync_data(self)
else
if not dir_res.nodes then
-dir_res.nodes = {}
+if dir_res.key then
+dir_res.nodes = { clone_tab(dir_res) }
+else
+dir_res.nodes = {}
+end
Review comment:
Should remove the keys:
https://github.com/apache/apisix/blob/aff1a907a3671bd6610b304a54ebef47022ca6cf/apisix/cli/etcd.lua#L206
to see if this idea works.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1102: feat: import route from OpenAPI Specification3.0
codecov-io edited a comment on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-752030848 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=h1) Report > Merging [#1102](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=desc) (a47ef38) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6d7f11a14c84c4f918827ae5f24befaf02bf681f?el=desc) (6d7f11a) will **decrease** coverage by `1.06%`. > The diff coverage is `46.61%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1102 +/- ## == - Coverage 62.79% 61.73% -1.07% == Files 41 42 +1 Lines2352 2595 +243 == + Hits 1477 1602 +125 - Misses700 791 +91 - Partials 175 202 +27 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `67.85% <ø> (ø)` | | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `81.25% <ø> (+18.75%)` | :arrow_up: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `55.46% <ø> (ø)` | | | [api/internal/handler/data\_loader/import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvaW1wb3J0Lmdv) | `43.34% <43.34%> (ø)` | | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `68.26% <66.66%> (+0.86%)` | :arrow_up: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `69.27% <75.00%> (+0.34%)` | :arrow_up: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `88.62% <100.00%> (+0.49%)` | :arrow_up: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `84.37% <100.00%> (+0.50%)` | :arrow_up: | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `70.83% <0.00%> (-6.25%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | | | ... and [7 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=footer). Last update [6d7f11a...a47ef38](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1300: Label feature doesn't support Chinese as key?
nic-chen commented on issue #1300: URL: https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-764231399 cc @spacewander This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3375: discuss: the discovery module need more features
spacewander commented on issue #3375: URL: https://github.com/apache/apisix/issues/3375#issuecomment-764228763 I am not quite understand what you need. But you can submit a PR first so we can discuss with the code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1300: Label feature doesn't support Chinese as key?
membphis commented on issue #1300: URL: https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-764226137 do we need to transfer this issue to APISIX? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1102: feat: import route from OpenAPI Specification3.0
codecov-io edited a comment on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-752030848 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=h1) Report > Merging [#1102](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=desc) (a47ef38) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6d7f11a14c84c4f918827ae5f24befaf02bf681f?el=desc) (6d7f11a) will **decrease** coverage by `18.22%`. > The diff coverage is `88.23%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1102 +/- ## === - Coverage 62.79% 44.57% -18.23% === Files 41 32-9 Lines2352 1972 -380 === - Hits 1477 879 -598 - Misses700 981 +281 + Partials 175 112 -63 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (-62.50%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <ø> (-55.47%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `46.52% <66.66%> (-20.87%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `58.10% <75.00%> (-10.83%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `80.83% <100.00%> (-7.29%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | ... and [26 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=footer). Last update [6d7f11a...a47ef38](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis edited a comment on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX
membphis edited a comment on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-764218287 please merge the code of master branch, CI failed ^_^ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3377: fix: ignore the case of configured host
spacewander opened a new pull request #3377: URL: https://github.com/apache/apisix/pull/3377 Fix #3357. Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta opened a new pull request #3376: CI: automatically check performance
idbeta opened a new pull request #3376: URL: https://github.com/apache/apisix/pull/3376 ### What this PR does / why we need it: automatically check performance in Actions. ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3374: Modify the 500 response code in the upstream.lua file to 503 response code
spacewander commented on issue #3374: URL: https://github.com/apache/apisix/issues/3374#issuecomment-764218407 This will break the compatibility. Is there a strong reason to do the change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX
membphis commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-764218287 please merge the code of master branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1300: Label feature doesn't support Chinese as key?
nic-chen commented on issue #1300: URL: https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-764217528 need support in APISIX first if we want to support it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1102: feat: import route from OpenAPI Specification3.0
codecov-io edited a comment on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-752030848 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=h1) Report > Merging [#1102](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=desc) (be06fbc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6d7f11a14c84c4f918827ae5f24befaf02bf681f?el=desc) (6d7f11a) will **decrease** coverage by `1.02%`. > The diff coverage is `46.61%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1102 +/- ## == - Coverage 62.79% 61.77% -1.03% == Files 41 42 +1 Lines2352 2595 +243 == + Hits 1477 1603 +126 - Misses700 787 +87 - Partials 175 205 +30 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `67.85% <ø> (ø)` | | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `81.25% <ø> (+18.75%)` | :arrow_up: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `55.46% <ø> (ø)` | | | [api/internal/handler/data\_loader/import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvaW1wb3J0Lmdv) | `43.34% <43.34%> (ø)` | | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `68.26% <66.66%> (+0.86%)` | :arrow_up: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `69.27% <75.00%> (+0.34%)` | :arrow_up: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `88.62% <100.00%> (+0.49%)` | :arrow_up: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `84.37% <100.00%> (+0.50%)` | :arrow_up: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `44.94% <0.00%> (-2.25%)` | :arrow_down: | | ... and [6 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=footer). Last update [6d7f11a...be06fbc](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
