date:20210122

[GitHub] [apisix] syzh opened a new pull request #3398: fix: upstream dns resolver failed response 503

2021-01-22 Thread GitBox



syzh opened a new pull request #3398:
URL: https://github.com/apache/apisix/pull/3398


   fixed issue #3342.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] gewei2000 commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-22 Thread GitBox



gewei2000 commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-765876941


   > The way of `/service_a/(.*)\\.(png|jpg|js|css)$` is correct, but I found 
that regular configuration is not supported in `uris`.
   
   bug?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers commented on issue #3112: request help: what is the use of item_release in lrucache.lua

2021-01-22 Thread GitBox



tokers commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-765872096


   @HelloBug0 Feel free to post any problems here if you need.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-22 Thread GitBox



Firstsawyou commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-765867436


   The way of `/service_a/(.*)\\.(png|jpg|js|css)$` is correct, but I found 
that regular configuration is not supported in `uris`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-22 Thread GitBox



Firstsawyou commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-765857555


   > @membphis @Firstsawyou
   
   Okay, let me check.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] gewei2000 commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-22 Thread GitBox



gewei2000 commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-765848337


   @membphis @Firstsawyou 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] HelloBug0 commented on issue #3112: request help: what is the use of item_release in lrucache.lua

2021-01-22 Thread GitBox



HelloBug0 commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-765838470


   Sorry to replay this later and not make myself clearly.
   Yeah, I'm willing to submit a PR, but before that, I want to spend more time 
studying APISIX code which is I am doing now. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] HelloBug0 commented on issue #3229: request help: Here is a big confusion about self.running in config.etcd.lua?

2021-01-22 Thread GitBox



HelloBug0 commented on issue #3229:
URL: https://github.com/apache/apisix/issues/3229#issuecomment-765831602


   It helps, really appreciated for you answers.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun closed issue #1213: The process of creating routes using dashboard needs improvement

2021-01-22 Thread GitBox



LiteSun closed issue #1213:
URL: https://github.com/apache/apisix-dashboard/issues/1213


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: feat: user can skip upstream when select service_id (#1302)

2021-01-22 Thread sunyi

This is an automated email from the ASF dual-hosted git repository.

sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new 6c3f35c  feat: user can skip upstream when select service_id (#1302)
6c3f35c is described below

commit 6c3f35ce7f0c6812004546dcf8483432e8bcb65b
Author: litesun 
AuthorDate: Fri Jan 22 23:51:59 2021 +0800

feat: user can skip upstream when select service_id (#1302)

* feat: user can skip upstream when select service_id

* feat: update code

* feat: update upstream

* fix: manual input

* feat: update CreateStep4

* fix: Select Upstream show empty string

* merge LiteSun/feat-route into test-route

* feat: auto fill DEFAULT_UPSTREAM

* test:  create route can skip upstream

* feat: update upstreamForm

* feat: update testcase

* feat: update upstream testcase

Co-authored-by: guoqqqi <979918...@qq.com>
---
 .../route/create-route-can-skip-upstream.spec.js   | 132 ++
 .../upstream/create_and_delete_upstream.spec.js|  10 +-
 web/src/components/Upstream/UpstreamForm.tsx   | 276 +++--
 web/src/pages/Route/Create.tsx |   7 +-
 .../Route/components/CreateStep4/CreateStep4.tsx   |   2 +-
 .../Route/components/Step2/RequestRewriteView.tsx  |   2 +
 web/src/pages/Route/transform.ts   |   5 +
 web/src/pages/Route/typing.d.ts|   2 +
 web/src/pages/Service/components/Step1.tsx |   1 +
 web/src/pages/Upstream/locales/en-US.ts|   4 +-
 10 files changed, 300 insertions(+), 141 deletions(-)

diff --git 
a/web/cypress/integration/route/create-route-can-skip-upstream.spec.js 
b/web/cypress/integration/route/create-route-can-skip-upstream.spec.js
new file mode 100644
index 000..af78885
--- /dev/null
+++ b/web/cypress/integration/route/create-route-can-skip-upstream.spec.js
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Can select service_id skip upstream in route', () => {
+  const data = {
+upstreamName: 'test_upstream',
+serviceName: 'test_service',
+routeName: 'test_route',
+ip: '127.0.0.1',
+  }
+  const domSelector = {
+name: '#name',
+nodes_0_host: '#nodes_0_host',
+upstream_id: '#upstream_id',
+input: ':input',
+customUpstream: '[title=Custom]',
+titleName: '[title=Name]',
+testService: '[title=test_service]',
+notification: '.ant-notification-notice-message',
+  };
+
+  beforeEach(() => {
+cy.login();
+  });
+
+  it('should create test upstream and service', () => {
+cy.visit('/');
+cy.contains('Upstream').click();
+cy.contains('Create').click();
+
+cy.get(domSelector.name).type(data.upstreamName);
+cy.get(domSelector.nodes_0_host).type(data.ip);
+cy.contains('Next').click();
+cy.contains('Submit').click();
+cy.get(domSelector.notification).should('contain', 'Create Upstream 
Successfully');
+
+cy.visit('/');
+cy.contains('Service').click();
+cy.contains('Create').click();
+cy.get(domSelector.name).type(data.serviceName);
+cy.get(domSelector.customUpstream).click();
+cy.contains(data.upstreamName).click();
+cy.contains('Next').click();
+cy.contains('Next').click();
+cy.contains('Submit').click();
+cy.get(domSelector.notification).should('contain', 'Create Service 
Successfully');
+  });
+
+  it('should skip upstream module after service is selected when creating 
route', () => {
+cy.visit('/');
+cy.contains('Route').click();
+cy.contains('Create').click();
+
+// The None option doesn't exist when service isn't selected
+cy.get(domSelector.name).type(data.routeName);
+cy.contains('Next').click();
+cy.get(domSelector.customUpstream).click();
+cy.contains('None').should('not.exist');
+
+cy.contains('Previous').click();
+cy.contains('None').click();
+cy.contains(data.serviceName).click();
+cy.contains('Next').click();
+
+// make sure upstream data can be saved
+

[GitHub] [apisix-dashboard] LiteSun merged pull request #1302: feat: user can skip upstream when select service_id

2021-01-22 Thread GitBox



LiteSun merged pull request #1302:
URL: https://github.com/apache/apisix-dashboard/pull/1302


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun closed issue #1278: bug(fe): route created with service can not use the service upstream

2021-01-22 Thread GitBox



LiteSun closed issue #1278:
URL: https://github.com/apache/apisix-dashboard/issues/1278


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1240: feat(fe): import and export routes

2021-01-22 Thread GitBox



codecov-io edited a comment on pull request #1240:
URL: https://github.com/apache/apisix-dashboard/pull/1240#issuecomment-756554309


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1240?src=pr=h1) 
Report
   > Merging 
[#1240](https://codecov.io/gh/apache/apisix-dashboard/pull/1240?src=pr=desc) 
(3892f5f) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/5f2232603588a47f902a90d974692a7c6bea535f?el=desc)
 (5f22326) will **increase** coverage by `6.58%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1240/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1240?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1240  +/-   ##
   ==
   + Coverage   42.44%   49.02%   +6.58% 
   ==
 Files  31   41  +10 
 Lines1932 2360 +428 
   ==
   + Hits  820 1157 +337 
   - Misses   1001 1009   +8 
   - Partials  111  194  +83 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1240?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1240/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=)
 | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1240/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `17.39% <0.00%> (-78.27%)` | :arrow_down: |
   | 
[api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1240/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=)
 | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
   | 
[api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1240/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==)
 | `16.66% <0.00%> (-53.34%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1240/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1240/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `57.59% <0.00%> (-22.41%)` | :arrow_down: |
   | 
[api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1240/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==)
 | `51.85% <0.00%> (-7.41%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1240/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `55.36% <0.00%> (-2.26%)` | :arrow_down: |
   | 
[api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1240/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==)
 | `0.00% <0.00%> (ø)` | |
   | 
[api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1240/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=)
 | `0.00% <0.00%> (ø)` | |
   | ... and [29 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1240/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1240?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1240?src=pr=footer).
 Last update 
[5f22326...3892f5f](https://codecov.io/gh/apache/apisix-dashboard/pull/1240?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1361: test: update code

2021-01-22 Thread GitBox



juzhiyuan commented on a change in pull request #1361:
URL: https://github.com/apache/apisix-dashboard/pull/1361#discussion_r562711279



##
File path: web/cypress/integration/route/create-route-can-skip-upstream.spec.js
##
@@ -0,0 +1,141 @@
+/*

Review comment:
   bad title

##
File path: web/cypress/integration/route/create-route-can-skip-upstream.spec.js
##
@@ -0,0 +1,141 @@
+/*

Review comment:
   test what





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



Jaycean commented on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765474916


   > > > > > > Hi, @Jaycean. Need unit test.
   > > > > > 
   > > > > > 
   > > > > > At present, the function interface needs to export the existing 
route data and ensure the correctness of the exported data, so I think E2E 
should be written more perfectly. I think if the simple unit test only tests 
whether the interface can export data, it does not represent whether the 
function of the interface is correct, and if the relevant route data is not 
created, the interface will not work normally use.
   > > > > 
   > > > > 
   > > > > Not agree with you.
   > > > > First of all, unit testing is very important. It helps find bugs 
easily and quickly if someone changes the code.And unit testing can cover more 
code than e2e test.
   > > > > For example, in this case.
   > > > > We need to test these situations at least:
   > > > > 
   > > > > 1. route can't found
   > > > > 2. Uris contain "*"
   > > > > 3. plugins with `request-validation`
   > > > > 4. different route method
   > > > >...
   > > > > 
   > > > > > and if the relevant route data is not created, the interface will 
not work normally use.
   > > > > 
   > > > > 
   > > > > We can mock data in etcd.
   > > > > See 
https://github.com/apache/apisix-dashboard/blob/master/api/internal/handler/server_info/server_info_test.go
 for more details.
   > > > 
   > > > 
   > > > @starsz Now I have encountered a problem in unit testing, exporting 
the data that needs to create route, upstream and service. After reading the 
example you gave me, I still don't know how to write it. Can you give me some 
advice. Thks
   > 
   > OK. Sorry, we don't have a doc to introduce the test contribute doc yet.
   > 
   > First, you should know the mock technology.
   > You can reference the doc: 
https://github.com/stretchr/testify#mock-package.
   > Mock provides a way to check input and give the return value that we want.
   > 
   > In your code, we should mock those function:
   > 
   > ```
   > routeStore.Get
   > routeStore.List
   > upstreamStore.Get
   > serviceStore.Get
   > ```
   > 
   > Second, IMO, you should write two testcases
   > One test case for `ExportRoutes`, like:
   > `TestDataLoader_ExportRoutes`
   > And another test case for `ExportAllRoutes`.like
   > `TestDataLoader_ExportAllRoutes`
   > 
   > Third, in those test case function.We should mock the store like:
   > 
   > ```
   > routeMockStore := {}
   > routeMockStore.On("Get", mock.Anything, mock.Anything).Run(func(args 
mock.Arguments) {
   >  id :=  args.Get(0).(string)
   > // here we can do some check on the id.
   > }).Return(tc.giveRet, tc.giveErr)
   > ```
   > 
   > Mock.Anything stands for the args when you called routeMockStore.Get.
   > tc.giveRet and tc.giveErr means what you want to get when called this line:
   > 
https://github.com/apache/apisix-dashboard/pull/1245/files#diff-195642dee38f4cdcc68921704b4b59dce5afc67d06074c1bc53004eb9b5dfc5eR70
   > The same as other mock functions.
   > 
   > Any feedback is welcome.
   
   Thank you very much. I'll try to write it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander closed issue #2916: request help: how to validates the requests by user

2021-01-22 Thread GitBox



spacewander closed issue #2916:
URL: https://github.com/apache/apisix/issues/2916


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran commented on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765473883


   Test cases are good for me



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3396: change: global rules should not be executed on the internal api

2021-01-22 Thread GitBox



spacewander commented on a change in pull request #3396:
URL: https://github.com/apache/apisix/pull/3396#discussion_r562699131



##
File path: apisix/init.lua
##
@@ -324,6 +324,28 @@ function _M.http_access_phase()
 
 core.ctx.set_vars_meta(api_ctx)
 
+local uri = api_ctx.var.uri
+if local_conf.apisix and local_conf.apisix.delete_uri_tail_slash then
+if str_byte(uri, #uri) == str_byte("/") then
+api_ctx.var.uri = str_sub(api_ctx.var.uri, 1, #uri - 1)
+core.log.info("remove the end of uri '/', current uri: ",
+  api_ctx.var.uri)
+end
+end
+
+if router.api.has_route_not_under_apisix() or

Review comment:
   Better to provide a switch to execute the global rule before matching 
internal API or don't execute the global rule. It is not skipped the internal 
API matched.
   
   > And I think if need to configure the plugin for the internal api, it is 
more appropriate to configure a route and then configure the plugin instead of 
using the global rule.
   
   We can't configure a plugin for internal API, this is the real problem.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1361: test: update code

2021-01-22 Thread GitBox



guoqqqi opened a new pull request #1361:
URL: https://github.com/apache/apisix-dashboard/pull/1361


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   resolve #1302 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander closed issue #2662: bug: Can't turn on Skywalking

2021-01-22 Thread GitBox



spacewander closed issue #2662:
URL: https://github.com/apache/apisix/issues/2662


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander closed issue #2118: request help: openid-connect JSON decode failed

2021-01-22 Thread GitBox



spacewander closed issue #2118:
URL: https://github.com/apache/apisix/issues/2118


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander closed issue #2487: request help: rpc error: code = Unavailable desc = connection closed

2021-01-22 Thread GitBox



spacewander closed issue #2487:
URL: https://github.com/apache/apisix/issues/2487


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #1861: Make admin APISIX response return JSON instead of HTML content

2021-01-22 Thread GitBox



spacewander commented on issue #1861:
URL: https://github.com/apache/apisix/issues/1861#issuecomment-765458582


   Surpassed by #3316 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander closed issue #1861: Make admin APISIX response return JSON instead of HTML content

2021-01-22 Thread GitBox



spacewander closed issue #1861:
URL: https://github.com/apache/apisix/issues/1861


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander closed issue #3388: bug: the balancer_ip is old, resulting in 504 timeout

2021-01-22 Thread GitBox



spacewander closed issue #3388:
URL: https://github.com/apache/apisix/issues/3388


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander closed issue #1780: consul serviece create route limit req report 502

2021-01-22 Thread GitBox



spacewander closed issue #1780:
URL: https://github.com/apache/apisix/issues/1780


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #1272: Support JWT scopes to allow or reject requests in OAuth2 plugin

2021-01-22 Thread GitBox



spacewander commented on issue #1272:
URL: https://github.com/apache/apisix/issues/1272#issuecomment-765454260


   Is it still in need?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



codecov-io edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1) 
Report
   > Merging 
[#1245](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=desc) 
(7414998) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/bb0a0575f9207fc57aacf79ab5f9defb4cb06166?el=desc)
 (bb0a057) will **increase** coverage by `0.82%`.
   > The diff coverage is `69.29%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1245  +/-   ##
   ==
   + Coverage   62.50%   63.32%   +0.82% 
   ==
 Files  41   42   +1 
 Lines2360 2601 +241 
   ==
   + Hits 1475 1647 +172 
   - Misses711  757  +46 
   - Partials  174  197  +23 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `62.50% <ø> (ø)` | |
   | 
[api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv)
 | `69.16% <69.16%> (ø)` | |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `84.37% <100.00%> (+0.50%)` | :arrow_up: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `85.44% <0.00%> (-0.64%)` | :arrow_down: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `50.50% <0.00%> (+2.02%)` | :arrow_up: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `74.48% <0.00%> (+4.08%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=footer).
 Last update 
[bb0a057...7414998](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



codecov-io edited a comment on pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-752030848


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=h1) 
Report
   > Merging 
[#1102](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=desc) 
(1caeb35) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/81dbdbfd639610b653f9ac7ed95c559aa890c5e3?el=desc)
 (81dbdbf) will **decrease** coverage by `18.56%`.
   > The diff coverage is `72.22%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1102   +/-   ##
   ===
   - Coverage   63.13%   44.56%   -18.57% 
   ===
 Files  41   32-9 
 Lines2360 1970  -390 
   ===
   - Hits 1490  878  -612 
   - Misses695  981  +286 
   + Partials  175  111   -64 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <ø> (-62.50%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <ø> (-55.47%)` | :arrow_down: |
   | 
[api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=)
 | `46.52% <66.66%> (-20.87%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `81.21% <72.72%> (-6.45%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `58.10% <75.00%> (-10.83%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-74.49%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | ... and [26 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=footer).
 Last update 
[81dbdbf...1caeb35](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727


   checklist:
   
   - [x] export route with host **(test2 coverd)**
   - [x] export route with hosts **(test1 coverd)**
   - [x] export route with uri **(test2 coverd)**
   - [x] export route with uris **(test1 coverd)**
   - [x] export route with upstream 
   - [x] export route with upstream_id **(test8 coverd)**
   - [x] export route with service_id(service create with upstream) **(test4 
coverd)**
   - [x] export route with upstream and service_id **(test6 coverd)**
   - [x] export route with service_id(service create with upstream_id) **(test6 
covered)**
   - [x] export route with labels and service_id(service create with labels)
   - [ ] export route without labels and service_id(service create with labels)
   - [x] export route with plugins and service_id(service create with plugins 
which is not the same as route's plugins)  **(test5 coverd)**
   - [x] export route with basic-auth plugin
   - [x] export route with jwt-auth plugin
   - [x] export route with key-auth plugin
   - [x] export route with request-validation (body_schema and header_schema) 
plugin
   - [x] export two routes **(test3 coverd)**



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



codecov-io edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1) 
Report
   > Merging 
[#1245](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=desc) 
(7414998) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/bb0a0575f9207fc57aacf79ab5f9defb4cb06166?el=desc)
 (bb0a057) will **decrease** coverage by `18.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1245   +/-   ##
   ===
   - Coverage   62.50%   44.31%   -18.19% 
   ===
 Files  41   32-9 
 Lines2360 1961  -399 
   ===
   - Hits 1475  869  -606 
   - Misses711  981  +270 
   + Partials  174  111   -63 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <ø> (-62.50%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-70.41%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=)
 | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
   | 
[api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=)
 | `63.82% <0.00%> (-27.66%)` | :arrow_down: |
   | 
[api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=)
 | `34.48% <0.00%> (-24.14%)` | :arrow_down: |
   | ... and [23 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=footer).
 Last update 
[bb0a057...7414998](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727


   checklist:
   
   - [x] export route with host **(test2 coverd)**
   - [x] export route with hosts **(test1 coverd)**
   - [x] export route with uri **(test2 coverd)**
   - [x] export route with uris **(test1 coverd)**
   - [x] export route with upstream 
   - [x] export route with upstream_id **(test8 coverd)**
   - [x] export route with service_id(service create with upstream) **(test4 
coverd)**
   - [x] export route with upstream and service_id **(test6 coverd)**
   - [x] export route with service_id(service create with upstream_id) **(test6 
covered)**
   - [ ] export route with labels and service_id(service create with labels)
   - [ ] export route without labels and service_id(service create with labels)
   - [x] export route with plugins and service_id(service create with plugins 
which is not the same as route's plugins)  **(test5 coverd)**
   - [x] export route with basic-auth plugin
   - [x] export route with jwt-auth plugin
   - [x] export route with key-auth plugin
   - [x] export route with request-validation (body_schema and header_schema) 
plugin
   - [x] export two routes **(test3 coverd)**



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi closed pull request #1360: feat: update code

2021-01-22 Thread GitBox



guoqqqi closed pull request #1360:
URL: https://github.com/apache/apisix-dashboard/pull/1360


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727


   checklist:
   
   - [x] export route with host **(test2 coverd)**
   - [x] export route with hosts **(test1 coverd)**
   - [x] export route with uri **(test2 coverd)**
   - [x] export route with uris **(test1 coverd)**
   - [x] export route with upstream 
   - [x] export route with upstream_id **(test8 coverd)**
   - [x] export route with service_id(service create with upstream) **(test4 
coverd)**
   - [x] export route with upstream and service_id **(test6 coverd)**
   - [x] export route with service_id(service create with upstream_id)
   - [ ] export route with labels and service_id(service create with labels)
   - [ ] export route without labels and service_id(service create with labels)
   - [x] export route with plugins and service_id(service create with plugins 
which is not the same as route's plugins)  **(test5 coverd)**
   - [x] export route with basic-auth plugin
   - [x] export route with jwt-auth plugin
   - [x] export route with key-auth plugin
   - [x] export route with request-validation (body_schema and header_schema) 
plugin
   - [x] export two routes **(test3 coverd)**



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727


   checklist:
   
   - [x] export route with host **(test2 coverd)**
   - [x] export route with hosts **(test1 coverd)**
   - [x] export route with uri **(test2 coverd)**
   - [x] export route with uris **(test1 coverd)**
   - [x] export route with upstream 
   - [x] export route with upstream_id **(test8 coverd)**
   - [x] export route with service_id(service create with upstream) **(test4 
coverd)**
   - [x] export route with upstream and service_id **(test6 coverd)**
   - [ ] export route with service_id(service create with upstream_id)
   - [ ] export route with labels and service_id(service create with labels)
   - [ ] export route without labels and service_id(service create with labels)
   - [x] export route with plugins and service_id(service create with plugins 
which is not the same as route's plugins)  **(test5 coverd)**
   - [x] export route with basic-auth plugin
   - [x] export route with jwt-auth plugin
   - [x] export route with key-auth plugin
   - [x] export route with request-validation (body_schema and header_schema) 
plugin
   - [x] export two routes **(test3 coverd)**



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



codecov-io edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1) 
Report
   > Merging 
[#1245](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=desc) 
(600c7c2) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/b659dfc6aff50ffbe7553824575a61aa69cbc409?el=desc)
 (b659dfc) will **decrease** coverage by `11.99%`.
   > The diff coverage is `69.29%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1245   +/-   ##
   ===
   - Coverage   62.67%   50.67%   -12.00% 
   ===
 Files  41   42+1 
 Lines2352 2601  +249 
   ===
   - Hits 1474 1318  -156 
   - Misses705 1065  +360 
   - Partials  173  218   +45 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `62.50% <ø> (ø)` | |
   | 
[api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv)
 | `69.16% <69.16%> (ø)` | |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `84.37% <100.00%> (+0.50%)` | :arrow_up: |
   | 
[api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=)
 | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `17.39% <0.00%> (-78.27%)` | :arrow_down: |
   | 
[api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=)
 | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
   | 
[api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==)
 | `16.66% <0.00%> (-70.00%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `44.11% <0.00%> (-32.36%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `56.32% <0.00%> (-31.80%)` | :arrow_down: |
   | ... and [17 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=footer).
 Last update 
[b659dfc...600c7c2](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1360: feat: update code

2021-01-22 Thread GitBox



codecov-io commented on pull request #1360:
URL: https://github.com/apache/apisix-dashboard/pull/1360#issuecomment-765401949


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1360?src=pr=h1) 
Report
   > Merging 
[#1360](https://codecov.io/gh/apache/apisix-dashboard/pull/1360?src=pr=desc) 
(ed56da0) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/749eeb58651c03b1d387d81a1d6f636f7fee93ae?el=desc)
 (749eeb5) will **increase** coverage by `4.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1360/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1360?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1360  +/-   ##
   ==
   + Coverage   44.36%   48.55%   +4.19% 
   ==
 Files  31   41  +10 
 Lines1961 2360 +399 
   ==
   + Hits  870 1146 +276 
   - Misses979 1020  +41 
   - Partials  112  194  +82 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1360?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1360/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=)
 | `0.00% <0.00%> (-88.10%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1360/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `17.39% <0.00%> (-78.27%)` | :arrow_down: |
   | 
[api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1360/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=)
 | `0.00% <0.00%> (-75.93%)` | :arrow_down: |
   | 
[api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1360/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==)
 | `16.66% <0.00%> (-53.34%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1360/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1360/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `44.11% <0.00%> (-32.36%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1360/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `55.06% <0.00%> (-24.94%)` | :arrow_down: |
   | 
[api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1360/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==)
 | `51.85% <0.00%> (-7.41%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1360/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `55.36% <0.00%> (-2.26%)` | :arrow_down: |
   | 
[api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1360/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=)
 | `50.00% <0.00%> (ø)` | |
   | ... and [28 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1360/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1360?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1360?src=pr=footer).
 Last update 
[749eeb5...ed56da0](https://codecov.io/gh/apache/apisix-dashboard/pull/1360?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1360: feat: update code

2021-01-22 Thread GitBox



guoqqqi opened a new pull request #1360:
URL: https://github.com/apache/apisix-dashboard/pull/1360


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   resolve #1302 
   
   ### New feature or improvement
   - Describe the details and related test reports.
   update code 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

2021-01-22 Thread GitBox



nic-chen commented on a change in pull request #3396:
URL: https://github.com/apache/apisix/pull/3396#discussion_r562625641



##
File path: t/node/global-rule.t
##
@@ -120,7 +120,34 @@ GET /hello
 
 
 
-=== TEST 6: delete global rule
+=== TEST 6: not limited
+--- request
+GET /apisix/nginx_status
+--- error_code: 200
+--- no_error_log
+[error]
+
+
+
+=== TEST 7: not limited

Review comment:
   @tokers  because it's testing the `limit-count` plugin here. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

2021-01-22 Thread GitBox



nic-chen commented on a change in pull request #3396:
URL: https://github.com/apache/apisix/pull/3396#discussion_r562624813



##
File path: apisix/init.lua
##
@@ -324,6 +324,28 @@ function _M.http_access_phase()
 
 core.ctx.set_vars_meta(api_ctx)
 
+local uri = api_ctx.var.uri
+if local_conf.apisix and local_conf.apisix.delete_uri_tail_slash then
+if str_byte(uri, #uri) == str_byte("/") then
+api_ctx.var.uri = str_sub(api_ctx.var.uri, 1, #uri - 1)
+core.log.info("remove the end of uri '/', current uri: ",
+  api_ctx.var.uri)
+end
+end
+
+if router.api.has_route_not_under_apisix() or

Review comment:
   @spacewander 
   I thought about it again. There shouldn't have a switch here. If skip the 
`if` branch and continue execution, a 404 will occur because the route does not 
exist.
   
   And I think if need to configure the plugin for the internal api, it is more 
appropriate to configure a route and then configure the plugin instead of using 
the global rule. 
   
   What do you think ? Looking forward to your opinion. Thanks.
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1302: feat: user can skip upstream when select service_id

2021-01-22 Thread GitBox



LiteSun commented on pull request #1302:
URL: https://github.com/apache/apisix-dashboard/pull/1302#issuecomment-765382732


   Ping 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen merged pull request #1359: fix: Skip the data directly in Storage level

2021-01-22 Thread GitBox



nic-chen merged pull request #1359:
URL: https://github.com/apache/apisix-dashboard/pull/1359


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated (81dbdbf -> bb0a057)

2021-01-22 Thread chenjunxu

This is an automated email from the ASF dual-hosted git repository.

chenjunxu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.


from 81dbdbf  fix: ignore the init_dir event when watching etcd events 
(#1344)
 add bb0a057  fix: Skip the data directly in Storage level (#1359)

No new revisions were added by this update.

Summary of changes:
 api/internal/core/storage/etcd.go | 50 +--
 api/internal/core/storage/storage.go  |  2 --
 api/internal/core/store/store.go  | 10 ---
 api/internal/core/store/store_test.go | 27 +++
 4 files changed, 34 insertions(+), 55 deletions(-)

[GitHub] [apisix-dashboard] nic-chen closed issue #1357: Why we need to skip it in store not storage?

2021-01-22 Thread GitBox



nic-chen closed issue #1357:
URL: https://github.com/apache/apisix-dashboard/issues/1357


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



nic-chen commented on pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-765366914


   > Do we need to add a test case about a route with as many props as possible
   
   sure



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] juzhiyuan opened a new issue #3397: Update Dashboard's screenshot

2021-01-22 Thread GitBox



juzhiyuan opened a new issue #3397:
URL: https://github.com/apache/apisix/issues/3397


   # Improve Docs
   
   ## Please describe which part of docs should be improved or typo fixed
   
   I see there have some pages[1] which still include 1.0 Dashboard's 
screenshot.
   
   [1] https://github.com/apache/apisix/blob/master/doc/plugins/zipkin.md
   [1] need to find out
   
   ## Describe the solution you'd like
   
   1. Remove those screenshots from documentation and folders;
   2. Take the latest screenshots from here[1].
   
   [1] https://github.com/apache/apisix-dashboard#demo
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-22 Thread GitBox



tokers commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r562585645



##
File path: bin/apisix
##
@@ -1,36 +1,43 @@
-#!/usr/bin/env lua
+#!/bin/bash
 
---
--- Licensed to the Apache Software Foundation (ASF) under one or more
--- contributor license agreements.  See the NOTICE file distributed with
--- this work for additional information regarding copyright ownership.
--- The ASF licenses this file to You under the Apache License, Version 2.0
--- (the "License"); you may not use this file except in compliance with
--- the License.  You may obtain a copy of the License at
---
--- http://www.apache.org/licenses/LICENSE-2.0
---
--- Unless required by applicable law or agreed to in writing, software
--- distributed under the License is distributed on an "AS IS" BASIS,
--- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
--- See the License for the specific language governing permissions and
--- limitations under the License.
---
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
 
-local pkg_cpath_org = package.cpath
-local pkg_path_org = package.path
+USE_LUA=true
+LUA_VERSION=$(lua -v 2>&1 | grep -E -o  "Lua [0-9]+.[0-9]+")
 
-local apisix_home = "/usr/local/apisix"
-local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;"
-  .. apisix_home .. "/deps/lib/lua/5.1/?.so;;"
-local pkg_path = apisix_home .. "/deps/share/lua/5.1/?.lua;;"
+if [ -s './apisix/cli/apisix.lua' ]; then
+APISIX_LUA=./apisix/cli/apisix.lua
+elif [ -s '/usr/share/lua/5.1/apisix/cli/apisix.lua' ]; then
+APISIX_LUA=/usr/share/lua/5.1/apisix/cli/apisix.lua

Review comment:
   Print value of package.path.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers commented on a change in pull request #3396: change: global rules should not be executed on the internal api

2021-01-22 Thread GitBox



tokers commented on a change in pull request #3396:
URL: https://github.com/apache/apisix/pull/3396#discussion_r562583252



##
File path: t/node/global-rule.t
##
@@ -120,7 +120,34 @@ GET /hello
 
 
 
-=== TEST 6: delete global rule
+=== TEST 6: not limited
+--- request
+GET /apisix/nginx_status
+--- error_code: 200
+--- no_error_log
+[error]
+
+
+
+=== TEST 7: not limited

Review comment:
   Why add a same test case?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers closed issue #159: chore: implement a script shell to check the version

2021-01-22 Thread GitBox



tokers closed issue #159:
URL: https://github.com/apache/apisix-ingress-controller/issues/159


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers merged pull request #200: chore: add check version script

2021-01-22 Thread GitBox



tokers merged pull request #200:
URL: https://github.com/apache/apisix-ingress-controller/pull/200


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-ingress-controller] branch master updated: chore: add check version script (#200)

2021-01-22 Thread tokers

This is an automated email from the ASF dual-hosted git repository.

tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git


The following commit(s) were added to refs/heads/master by this push:
 new f0ed89f  chore: add check version script (#200)
f0ed89f is described below

commit f0ed89f96976f68a8fd490f8ba686ffed52af71d
Author: rootlh <302824...@qq.com>
AuthorDate: Fri Jan 22 19:52:22 2021 +0800

chore: add check version script (#200)

* add:check version script

* add:check version script
---
 utils/check-version.sh | 40 
 1 file changed, 40 insertions(+)

diff --git a/utils/check-version.sh b/utils/check-version.sh
new file mode 100755
index 000..6afc50b
--- /dev/null
+++ b/utils/check-version.sh
@@ -0,0 +1,40 @@
+#!/bin/sh
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+ver=$1
+
+red='\e[0;41m'
+RED='\e[1;31m'
+green='\e[0;32m'
+GREEN='\e[1;32m'
+NC='\e[0m'
+
+# Makefile $ver
+matched=`grep "VERSION ?= [0-9][0-9.]*" -r Makefile`
+expected=`grep "VERSION ?= $ver" -r Makefile`
+
+if [ "$matched" = "$expected" ]; then
+echo -e "${green}passed: version $ver ${NC}"
+else
+echo -e "${RED}failed: version $ver ${NC}" 1>&2
+echo
+echo "-maybe wrong version-"
+echo "$matched"
+exit 1
+fi

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran commented on pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-765343958


   Do we need to add a test case about a route  with as many props as possible?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] lianghao208 commented on pull request #200: chore: add check version script

2021-01-22 Thread GitBox



lianghao208 commented on pull request #200:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/200#issuecomment-765337960


   
   > Just make sure the file is assigned executable permissions by default.
   
   @gxthrj Yes, it's assigned executable permissions by default.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727


   checklist:
   
   - [x] export route with host **(test2 coverd)**
   - [x] export route with hosts **(test1 coverd)**
   - [x] export route with uri **(test2 coverd)**
   - [x] export route with uris **(test1 coverd)**
   - [x] export route with upstream 
   - [x] export route with upstream_id **(test8 coverd)**
   - [x] export route with service_id(service create with upstream) **(test4 
coverd)**
   - [x] export route with upstream and service_id **(test6 coverd)**
   - [ ] export route with service_id(service create with upstream_id)
   - [ ] export route with labels and service_id(service create with labels)
   - [ ] export route without labels and service_id(service create with labels)
   - [x] export route with plugins and service_id(service create with plugins 
which is not the same as route's plugins)  **(test5 coverd)**
   - [x] export route with basic-auth plugin
   - [x] export route with jwt-auth plugin
   - [x] export route with key-auth plugin
   - [ ] export route with request-validation (body_schema and header_schema) 
plugin
   - [x] export two routes **(test3 coverd)**



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727


   checklist:
   
   - [x] export route with host **(test2 coverd)**
   - [x] export route with hosts **(test1 coverd)**
   - [x] export route with uri **(test2 coverd)**
   - [x] export route with uris **(test1 coverd)**
   - [x] export route with upstream 
   - [x] export route with upstream_id **(test8 coverd)**
   - [x] export route with service_id(service create with upstream) **(test4 
coverd)**
   - [x] export route with upstream and service_id **(test6 coverd)**
   - [ ] export route with service_id(service create with upstream_id)
   - [ ] export route with labels and service_id(service create with labels)
   - [ ] export route without labels and service_id(service create with labels)
   - [ ] export route with plugins and service_id(service create with plugins 
which is not the same as route's plugins)  **(test5 coverd)**
   - [x] export route with basic-auth plugin
   - [x] export route with jwt-auth plugin
   - [x] export route with key-auth plugin
   - [ ] export route with request-validation (body_schema and header_schema) 
plugin
   - [x] export two routes **(test3 coverd)**



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #2692: request help: got malformed version message: "" from etcd

2021-01-22 Thread GitBox



spacewander commented on issue #2692:
URL: https://github.com/apache/apisix/issues/2692#issuecomment-765332216


   Consider solved



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander closed issue #2692: request help: got malformed version message: "" from etcd

2021-01-22 Thread GitBox



spacewander closed issue #2692:
URL: https://github.com/apache/apisix/issues/2692


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



liuxiran commented on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727


   checklist:
   
   - [ ] export route with host
   - [ ] export route with hosts
   - [ ] export route with uri
   - [ ] export route with uris
   - [ ] export route with upstream
   - [ ] export route with upstream_id
   - [ ] export route with service_id(service create with upstream)
   - [ ] export route with service_id(service create with upstream_id)
   - [ ] export route with labels and service_id(service create with labels)
   - [ ] export route without labels and service_id(service create with labels)
   - [ ] export route with plugins and service_id(service create with plugins 
which is not the same as route's plugins)
   - [ ] export route with basic-auth plugin
   - [ ] export route with jwt-auth plugin
   - [ ] export route with key-auth plugin
   - [ ] export route with request-validation (body_schema and header_schema) 
plugin



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Fuchange commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-22 Thread GitBox



Fuchange commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r562522817



##
File path: bin/apisix
##
@@ -1,36 +1,43 @@
-#!/usr/bin/env lua
+#!/bin/bash
 
---
--- Licensed to the Apache Software Foundation (ASF) under one or more
--- contributor license agreements.  See the NOTICE file distributed with
--- this work for additional information regarding copyright ownership.
--- The ASF licenses this file to You under the Apache License, Version 2.0
--- (the "License"); you may not use this file except in compliance with
--- the License.  You may obtain a copy of the License at
---
--- http://www.apache.org/licenses/LICENSE-2.0
---
--- Unless required by applicable law or agreed to in writing, software
--- distributed under the License is distributed on an "AS IS" BASIS,
--- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
--- See the License for the specific language governing permissions and
--- limitations under the License.
---
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
 
-local pkg_cpath_org = package.cpath
-local pkg_path_org = package.path
+USE_LUA=true
+LUA_VERSION=$(lua -v 2>&1 | grep -E -o  "Lua [0-9]+.[0-9]+")
 
-local apisix_home = "/usr/local/apisix"
-local pkg_cpath = apisix_home .. "/deps/lib64/lua/5.1/?.so;"
-  .. apisix_home .. "/deps/lib/lua/5.1/?.so;;"
-local pkg_path = apisix_home .. "/deps/share/lua/5.1/?.lua;;"
+if [ -s './apisix/cli/apisix.lua' ]; then
+APISIX_LUA=./apisix/cli/apisix.lua
+elif [ -s '/usr/share/lua/5.1/apisix/cli/apisix.lua' ]; then
+APISIX_LUA=/usr/share/lua/5.1/apisix/cli/apisix.lua

Review comment:
   You're right. Do you have any way to query luapath in Bash? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers merged pull request #192: chore: introduce ingress-types, rename ApisixTls to ApisixTLS

2021-01-22 Thread GitBox



tokers merged pull request #192:
URL: https://github.com/apache/apisix-ingress-controller/pull/192


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1302: feat: user can skip upstream when select service_id

2021-01-22 Thread GitBox



codecov-io edited a comment on pull request #1302:
URL: https://github.com/apache/apisix-dashboard/pull/1302#issuecomment-760639257


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=h1) 
Report
   > Merging 
[#1302](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=desc) 
(909fc2f) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/749eeb58651c03b1d387d81a1d6f636f7fee93ae?el=desc)
 (749eeb5) will **increase** coverage by `0.11%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1302  +/-   ##
   ==
   + Coverage   44.36%   44.47%   +0.11% 
   ==
 Files  31   32   +1 
 Lines1961 1965   +4 
   ==
   + Hits  870  874   +4 
   - Misses979  980   +1 
   + Partials  112  111   -1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=)
 | `0.00% <0.00%> (ø)` | |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1302/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `81.48% <0.00%> (+1.48%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=footer).
 Last update 
[749eeb5...909fc2f](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



codecov-io edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1) 
Report
   > Merging 
[#1245](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=desc) 
(9ed0deb) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/b659dfc6aff50ffbe7553824575a61aa69cbc409?el=desc)
 (b659dfc) will **decrease** coverage by `18.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1245   +/-   ##
   ===
   - Coverage   62.67%   44.47%   -18.20% 
   ===
 Files  41   32-9 
 Lines2352 1965  -387 
   ===
   - Hits 1474  874  -600 
   - Misses705  980  +275 
   + Partials  173  111   -62 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <ø> (-62.50%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-70.41%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=)
 | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
   | 
[api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=)
 | `63.82% <0.00%> (-27.66%)` | :arrow_down: |
   | 
[api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=)
 | `34.48% <0.00%> (-24.14%)` | :arrow_down: |
   | ... and [23 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1245/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=footer).
 Last update 
[b659dfc...9ed0deb](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] idbeta commented on pull request #3365: test: add shell script for run APISIX testcases on ARM64

2021-01-22 Thread GitBox



idbeta commented on pull request #3365:
URL: https://github.com/apache/apisix/pull/3365#issuecomment-765280437


   > why not use dockerfile for it？
   
   This script is just a preliminary idea for the backup, not the final 
solution. If want to fully implement it, need to solve the problems mentioned 
above: 1, self-hosted;  2, CI-dependent docker images.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] idbeta commented on issue #3340: How to do fuzz testing on Apache APISIX

2021-01-22 Thread GitBox



idbeta commented on issue #3340:
URL: https://github.com/apache/apisix/issues/3340#issuecomment-765275479


   > the `WHY` is not enough from your proposal.
   
   Generally speaking, fuzzing is an effective method of security testing, but 
for APISIX, because APISIX handles massive amounts of data in the east-west 
direction, these data formats and contents are very different, so fuzzing can 
be used to check the stability and robustness of APISIX.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated (d698220 -> c8d35cd)

2021-01-22 Thread membphis

This is an automated email from the ASF dual-hosted git repository.

membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.


from d698220  fix: ignore the case of configured host (#3377)
 add c8d35cd  fix(standalone): require consumer's id to be the same as 
username (#3394)

No new revisions were added by this update.

Summary of changes:
 apisix/consumer.lua | 26 +-
 t/config-center-yaml/consumer.t | 29 +
 2 files changed, 50 insertions(+), 5 deletions(-)

[GitHub] [apisix] membphis merged pull request #3394: fix(standalone): require consumer's id to be the same as username

2021-01-22 Thread GitBox



membphis merged pull request #3394:
URL: https://github.com/apache/apisix/pull/3394


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] gewei2000 commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-22 Thread GitBox



gewei2000 commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-765268928


   > > > > Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in 
apisix, can it solve your problem?
   > > > 
   > > > 
   > > > this is not a best way in APISIX. we can use the Route + proxy cache 
plugin to implement this feature.
   > > > Route: match the request `/service_a/(.*)\.(png|jpg|js|css)$`
   > > > Proxy-cache plugin: implement the proxy and cache file.
   > > 
   > > 
   > > can not match any route
   > > route config
   > > ```
   > > {
   > >  "id": "1",
   > >  "name": "static_cache",
   > >  "plugins": {
   > >  "proxy-cache": {
   > >  "cache_zone": "disk_cache_one",
   > >  "cache_key": ["$host", "$uri", "$is_args", "$args"],
   > >  "cache_bypass": ["$arg_bypass"],
   > >  "cache_method": ["GET"],
   > >  "cache_http_status": [200],
   > >  "hide_cache_headers": true,
   > >  "no_cache": ["$arg_test"]
   > >  }
   > >  },
   > >  "upstream_id": "1",
   > >  "uris": ["/service_a/(.*)\\.(png|jpg|js|css)$"]
   > > }
   > > ```
   > > 
   > > 
   > > debug log
   > > ```
   > > 2021/01/22 13:52:53 [info] 39#39: *4987 [lua] init.lua:387: 
http_access_phase(): not find any matched route, client: 10.0.0.3, server: , 
request: "GET /service_a/111.png HTTP/1.1", host: "10.1.2.2:9081"
   > > ```
   > 
   > There is an extra `\` in this `/service_a/(.*)\\.(png|jpg|js|css)$` uris, 
which should look like this: `/service_a/(.*)\.(png|jpg|js|css)$`
   
   This is an escape character.
   
![image](https://user-images.githubusercontent.com/10362371/105472820-56dd4d80-5cd7-11eb-9219-56086d33da9e.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on issue #1351: bug: some apis bypassed authentication

2021-01-22 Thread GitBox



starsz commented on issue #1351:
URL: 
https://github.com/apache/apisix-dashboard/issues/1351#issuecomment-765266321


   Right. It's a bug.
   IMO, we can wrap those functions into droplet, because the droplet has 
updated before.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-22 Thread GitBox



starsz commented on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765262758


   > > > > > Hi, @Jaycean. Need unit test.
   > > > > 
   > > > > 
   > > > > At present, the function interface needs to export the existing 
route data and ensure the correctness of the exported data, so I think E2E 
should be written more perfectly. I think if the simple unit test only tests 
whether the interface can export data, it does not represent whether the 
function of the interface is correct, and if the relevant route data is not 
created, the interface will not work normally use.
   > > > 
   > > > 
   > > > Not agree with you.
   > > > First of all, unit testing is very important. It helps find bugs 
easily and quickly if someone changes the code.And unit testing can cover more 
code than e2e test.
   > > > For example, in this case.
   > > > We need to test these situations at least:
   > > > 
   > > > 1. route can't found
   > > > 2. Uris contain "*"
   > > > 3. plugins with `request-validation`
   > > > 4. different route method
   > > >...
   > > > 
   > > > > and if the relevant route data is not created, the interface will 
not work normally use.
   > > > 
   > > > 
   > > > We can mock data in etcd.
   > > > See 
https://github.com/apache/apisix-dashboard/blob/master/api/internal/handler/server_info/server_info_test.go
 for more details.
   > > 
   > > 
   > > @starsz Now I have encountered a problem in unit testing, exporting the 
data that needs to create route, upstream and service. After reading the 
example you gave me, I still don't know how to write it. Can you give me some 
advice. Thks
   
   OK. Sorry, we don't have a doc to introduce the test contribute doc yet.
   
   First, you should know the mock technology. 
   You can reference the doc: https://github.com/stretchr/testify#mock-package.
   Mock provides a way to check input and give the return value that we want.
   
   In your code, we should mock those function:
   ```
   routeStore.Get
   routeStore.List
   upstreamStore.Get
   serviceStore.Get
   ```
   
   Second, IMO, you should write two testcases
   One test case for `ExportRoutes`, like:
   `TestDataLoader_ExportRoutes` 
   And another test case for `ExportAllRoutes`.like 
   `TestDataLoader_ExportAllRoutes`
   
   Third, in those test case function.We should mock the store like:
   
   ```
   routeMockStore := {}
   routeMockStore.On("Get", mock.Anything, mock.Anything).Run(func(args 
mock.Arguments) {
id :=  args.Get(0).(string)
   // here we can do some check on the id.  
   }).Return(tc.giveRet, tc.giveErr)
   ```
   Mock.Anything stands for the args when you called routeMockStore.Get.
   tc.giveRet and tc.giveErr means what you want to get when called this line: 
   
https://github.com/apache/apisix-dashboard/pull/1245/files#diff-195642dee38f4cdcc68921704b4b59dce5afc67d06074c1bc53004eb9b5dfc5eR70
   The same as other mock functions.
   
   Any feedback is welcome.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3396: change: global rules should not be executed on the internal api

2021-01-22 Thread GitBox



spacewander commented on a change in pull request #3396:
URL: https://github.com/apache/apisix/pull/3396#discussion_r562493471



##
File path: apisix/init.lua
##
@@ -324,6 +324,28 @@ function _M.http_access_phase()
 
 core.ctx.set_vars_meta(api_ctx)
 
+local uri = api_ctx.var.uri
+if local_conf.apisix and local_conf.apisix.delete_uri_tail_slash then
+if str_byte(uri, #uri) == str_byte("/") then
+api_ctx.var.uri = str_sub(api_ctx.var.uri, 1, #uri - 1)
+core.log.info("remove the end of uri '/', current uri: ",
+  api_ctx.var.uri)
+end
+end
+
+if router.api.has_route_not_under_apisix() or

Review comment:
   Yes





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] lianghao208 commented on pull request #200: chore: add check version script

2021-01-22 Thread GitBox



lianghao208 commented on pull request #200:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/200#issuecomment-765257662


   @gxthrj PTAL, thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

2021-01-22 Thread GitBox



nic-chen commented on a change in pull request #3396:
URL: https://github.com/apache/apisix/pull/3396#discussion_r562488874



##
File path: apisix/init.lua
##
@@ -324,6 +324,28 @@ function _M.http_access_phase()
 
 core.ctx.set_vars_meta(api_ctx)
 
+local uri = api_ctx.var.uri
+if local_conf.apisix and local_conf.apisix.delete_uri_tail_slash then
+if str_byte(uri, #uri) == str_byte("/") then
+api_ctx.var.uri = str_sub(api_ctx.var.uri, 1, #uri - 1)
+core.log.info("remove the end of uri '/', current uri: ",
+  api_ctx.var.uri)
+end
+end
+
+if router.api.has_route_not_under_apisix() or

Review comment:
   @spacewander  do you mean a switch for it ?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] nic-chen commented on pull request #3396: change: global rules should not be executed on the internal api

2021-01-22 Thread GitBox



nic-chen commented on pull request #3396:
URL: https://github.com/apache/apisix/pull/3396#issuecomment-765255902


   > We need a test case for it.
   
   we have [test 
case](https://github.com/apache/apisix/pull/3396/files#diff-bdc9989c1ae307a5194244a61cec93ef98b83b41c0e0ae0180564cfb4bfb1981R123-R146)
 for it, : )



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #2076: bug: service discovery duplicate request service information in Eureka

2021-01-22 Thread GitBox



spacewander commented on issue #2076:
URL: https://github.com/apache/apisix/issues/2076#issuecomment-765249902


   Currently all the workers will fetch service info from Eureka.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] idbeta commented on issue #3391: [proposal]: add performance testing in CI

2021-01-22 Thread GitBox



idbeta commented on issue #3391:
URL: https://github.com/apache/apisix/issues/3391#issuecomment-765239640


   > I don’t think it’s a good idea to perform benchmark on github actions.
   > We cannot know the performance of the machine behind GH and how busy CI is.
   
   I quite agree with your point. What if testing is done via self-hosted? Is 
it possible to perform this test in the CI of the Apache project?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #3396: change: global rules should not be executed on the internal api

2021-01-22 Thread GitBox



spacewander commented on pull request #3396:
URL: https://github.com/apache/apisix/pull/3396#issuecomment-765239386


   We need a test case for it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3396: chore: global rules should not be executed on the internal api

2021-01-22 Thread GitBox



spacewander commented on a change in pull request #3396:
URL: https://github.com/apache/apisix/pull/3396#discussion_r562470528



##
File path: apisix/init.lua
##
@@ -324,6 +324,28 @@ function _M.http_access_phase()
 
 core.ctx.set_vars_meta(api_ctx)
 
+local uri = api_ctx.var.uri
+if local_conf.apisix and local_conf.apisix.delete_uri_tail_slash then
+if str_byte(uri, #uri) == str_byte("/") then
+api_ctx.var.uri = str_sub(api_ctx.var.uri, 1, #uri - 1)
+core.log.info("remove the end of uri '/', current uri: ",
+  api_ctx.var.uri)
+end
+end
+
+if router.api.has_route_not_under_apisix() or

Review comment:
   Maybe we can add a configuration in the `config.yaml` for it?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] gxthrj commented on issue #122: failed to paa rse yaml config: failed to merge, path[etcd->timeout] expect: number, but got: string

2021-01-22 Thread GitBox



gxthrj commented on issue #122:
URL: https://github.com/apache/apisix-docker/issues/122#issuecomment-765235440


   > 一定要检查下配置文件
   
   haha,It is a fair suggestion.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on issue #3391: [proposal]: add performance testing in CI

2021-01-22 Thread GitBox



moonming commented on issue #3391:
URL: https://github.com/apache/apisix/issues/3391#issuecomment-765231429


   I don’t think it’s a good idea to perform benchmark on github actions.
   We cannot know the performance of the machine behind GH and how busy CI is.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #199: chore: generate id instead let APISIX do it

2021-01-22 Thread GitBox



tokers commented on pull request #199:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/199#issuecomment-765229502


   @gxthrj Fixed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] idbeta commented on issue #3391: [proposal]: add performance testing in CI

2021-01-22 Thread GitBox



idbeta commented on issue #3391:
URL: https://github.com/apache/apisix/issues/3391#issuecomment-765228192


   > > @idbeta How could we know that "not differ too much" would happen, or 
"they are within an order of magnitude". Maybe we need some methods to get over 
those false positives, but not just "as long as"
   > 
   > I plan to change the APISIX's `worker_processes` from `auto` to `1`, then 
execute 10 times for each test, remove the highest and lowest values, find the 
average value, and compare it with the expected result (for example, I test 100 
times in one route scenario, get the average value is 18942.1789. I think it 
can be used as the expected value of this scenario. ), which should reduce 
false positives.
   
   @membphis Can you give some advice?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] nic-chen opened a new pull request #3396: chore: global rules should not be executed on the internal api

2021-01-22 Thread GitBox



nic-chen opened a new pull request #3396:
URL: https://github.com/apache/apisix/pull/3396


   ### What this PR does / why we need it:
   
   
   
   global rules should not be executed on the internal api, currently it will 
run `access` and `rewrite` of plugins in global rule, so we need to change it.
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [x] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] pengtaochang commented on issue #2208: Is Apache APISIX support strip_path in Kong?

2021-01-22 Thread GitBox



pengtaochang commented on issue #2208:
URL: https://github.com/apache/apisix/issues/2208#issuecomment-765227851


   
![image](https://user-images.githubusercontent.com/39374127/105465004-5770e680-5ccd-11eb-96fd-b31bfb102418.png)
   I using proxy_rewrite plugin achieve the strip_path feature. Hope it's 
helpful.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] gewei2000 edited a comment on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-22 Thread GitBox



gewei2000 edited a comment on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-765149345


   > > Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix, 
can it solve your problem?
   > 
   > this is not a best way in APISIX. we can use the Route + proxy cache 
plugin to implement this feature.
   > 
   > Route: match the request `/service_a/(.*)\.(png|jpg|js|css)$`
   > Proxy-cache plugin: implement the proxy and cache file.
   
   can not match any route
   
   route config
   ```
   {
"id": "1",
"name": "static_cache",
"plugins": {
"proxy-cache": {
"cache_zone": "disk_cache_one",
"cache_key": ["$host", "$uri", "$is_args", "$args"],
"cache_bypass": ["$arg_bypass"],
"cache_method": ["GET"],
"cache_http_status": [200],
"hide_cache_headers": true,
"no_cache": ["$arg_test"]
}
},
"upstream_id": "1",
"uris": ["/service_a/(.*)\\.(png|jpg|js|css)$"]
   }
   ```
   
   request url:
   ```
/service_a/111.png
   ```
   
   debug log:
   ```
   2021/01/22 13:52:53 [info] 39#39: *4987 [lua] init.lua:387: 
http_access_phase(): not find any matched route, client: 10.0.0.3, server: , 
request: "GET /service_a/111.png HTTP/1.1", host: "10.1.2.2:9081"
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-22 Thread GitBox



Firstsawyou commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-765225039


   > > > Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix, 
can it solve your problem?
   > > 
   > > 
   > > this is not a best way in APISIX. we can use the Route + proxy cache 
plugin to implement this feature.
   > > Route: match the request `/service_a/(.*)\.(png|jpg|js|css)$`
   > > Proxy-cache plugin: implement the proxy and cache file.
   > 
   > can not match any route
   > 
   > route config
   > 
   > ```
   > {
   >"id": "1",
   >"name": "static_cache",
   >"plugins": {
   >"proxy-cache": {
   >"cache_zone": "disk_cache_one",
   >"cache_key": ["$host", "$uri", "$is_args", "$args"],
   >"cache_bypass": ["$arg_bypass"],
   >"cache_method": ["GET"],
   >"cache_http_status": [200],
   >"hide_cache_headers": true,
   >"no_cache": ["$arg_test"]
   >}
   >},
   >"upstream_id": "1",
   >"uris": ["/service_a/(.*)\\.(png|jpg|js|css)$"]
   > }
   > ```
   > 
   > debug log
   > 
   > ```
   > 2021/01/22 13:52:53 [info] 39#39: *4987 [lua] init.lua:387: 
http_access_phase(): not find any matched route, client: 10.0.0.3, server: , 
request: "GET /service_a/111.png HTTP/1.1", host: "10.1.2.2:9081"
   > ```
   
   There is an extra `\` in this `/service_a/(.*)\\.(png|jpg|js|css)$` uris, 
which should look like this: `/service_a/(.*)\.(png|jpg|js|css)$`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-22 Thread GitBox



Firstsawyou commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-765220975


   > > not find any matched route,
   > 
   > Hi, @gewei2000 What is the `uri` you request for this route?
   
   Sorry, I saw it in the log information.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-22 Thread GitBox



Firstsawyou commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-765220256


   > not find any matched route,
   
   Hi, @gewei2000  What is the `uri` you request for this route?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #199: chore: generate id instead let APISIX do it

2021-01-22 Thread GitBox



gxthrj commented on pull request #199:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/199#issuecomment-765218542


   UT failed



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #192: chore: introduce ingress-types, rename ApisixTls to ApisixTLS

2021-01-22 Thread GitBox



gxthrj commented on pull request #192:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/192#issuecomment-765218073


   > > Need to update docs which contains `ApisixTls`.
   > 
   > The docs are all about CRD `ApisixTls`, considering the compatiblity, i 
didn't change the CRD name, so no doc need to be updated.
   
   OK



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #200: chore: add check version script

2021-01-22 Thread GitBox



codecov-io commented on pull request #200:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/200#issuecomment-765218068


   # 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr=h1)
 Report
   > Merging 
[#200](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr=desc)
 (7b4b7a5) into 
[master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/009db9bcc124398a789fe4aac59d2c74a7264927?el=desc)
 (009db9b) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200/graphs/tree.svg?width=650=150=pr=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master #200   +/-   ##
   ===
 Coverage   47.68%   47.68%   
   ===
 Files  32   32   
 Lines1883 1883   
   ===
 Hits  898  898   
 Misses846  846   
 Partials  139  139   
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr=footer).
 Last update 
[009db9b...7b4b7a5](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] lianghao208 opened a new pull request #200: chore: add check version script

2021-01-22 Thread GitBox



lianghao208 opened a new pull request #200:
URL: https://github.com/apache/apisix-ingress-controller/pull/200


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   #159 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] imjoey commented on pull request #1359: fix: Skip the data directly in Storage level

2021-01-22 Thread GitBox



imjoey commented on pull request #1359:
URL: https://github.com/apache/apisix-dashboard/pull/1359#issuecomment-765215648


   ping @ShiningRush  @tokers @nic-chen for reviewing. Thanks.
   
   BTW, regarding to the test cases, I had to admitted that at present I've no 
idea about how to check if the data in etcd is skipped. Any ideas? Much 
appreciated.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #199: chore: generate id instead let APISIX do it

2021-01-22 Thread GitBox



tokers opened a new pull request #199:
URL: https://github.com/apache/apisix-ingress-controller/pull/199


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   Previously, we don't generate resource id, instead, we resort to APISIX to 
do it, which is not so convenient when we try to get resource from APISIX (we'd 
have to list all resources in APISIX and find the target by fullname).
   
   Now, we generate resource id from fullname.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #199: chore: generate id instead let APISIX do it

2021-01-22 Thread GitBox



tokers commented on pull request #199:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/199#issuecomment-765215598


   @gxthrj 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

99 matches

Mail list logo