[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1102: feat: import route from OpenAPI Specification3.0
codecov-io edited a comment on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-752030848 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=h1) Report > Merging [#1102](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=desc) (4e06b76) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1bdcaa8df2fe2fa6caba23809e69e26c5ad7902d?el=desc) (1bdcaa8) will **decrease** coverage by `19.95%`. > The diff coverage is `31.72%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1102 +/- ## === - Coverage 62.29% 42.33% -19.96% === Files 42 34-8 Lines2395 2258 -137 === - Hits 1492 956 -536 - Misses722 1165 +443 + Partials 181 137 -44 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (-62.50%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <ø> (-55.47%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `47.56% <0.00%> (-23.66%)` | :arrow_down: | | [api/internal/handler/data\_loader/import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvaW1wb3J0Lmdv) | `29.96% <29.96%> (ø)` | | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `46.52% <66.66%> (-20.87%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `58.10% <75.00%> (-10.83%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `81.81% <100.00%> (-4.26%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.49%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | ... and [30 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1102/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=footer). Last update [1bdcaa8...4e06b76](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #191: fix：BUGFIX #182 ,add write permisson of resource:leases in apisix_vie…
tokers commented on pull request #191: URL: https://github.com/apache/apisix-ingress-controller/pull/191#issuecomment-766616677 @liodo198592 Is this PR ready for review? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #206: optimize endpoints controller
codecov-io commented on pull request #206: URL: https://github.com/apache/apisix-ingress-controller/pull/206#issuecomment-766616178 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/206?src=pr=h1) Report > Merging [#206](https://codecov.io/gh/apache/apisix-ingress-controller/pull/206?src=pr=desc) (3e92d8f) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/d9d22bb885f9a6dff6a4c2f74d9c5af2320d7423?el=desc) (d9d22bb) will **increase** coverage by `0.09%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/206?src=pr=tree) ```diff @@Coverage Diff @@ ## master #206 +/- ## == + Coverage 44.56% 44.66% +0.09% == Files 32 32 Lines2024 2024 == + Hits 902 904 +2 + Misses983 981 -2 Partials 139 139 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/206?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/206/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `3.96% <0.00%> (+1.98%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/206?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/206?src=pr=footer). Last update [d9d22bb...3e92d8f](https://codecov.io/gh/apache/apisix-ingress-controller/pull/206?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #204: fix: fix error check lint errors
tokers commented on pull request #204: URL: https://github.com/apache/apisix-ingress-controller/pull/204#issuecomment-766615975 @lianghao208 Well done! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers closed issue #202: Check go lint errors
tokers closed issue #202: URL: https://github.com/apache/apisix-ingress-controller/issues/202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #204: fix: fix error check lint errors
tokers merged pull request #204: URL: https://github.com/apache/apisix-ingress-controller/pull/204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: fix: fix error check lint errors (#204)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 5684cea fix: fix error check lint errors (#204)
5684cea is described below
commit 5684ceaa49d3d55e104ca5eeb00281b45d957c1f
Author: rootlh <302824...@qq.com>
AuthorDate: Mon Jan 25 15:41:38 2021 +0800
fix: fix error check lint errors (#204)
---
cmd/ingress/ingress_test.go | 4 +++-
pkg/ingress/controller/controller.go | 26 ++
pkg/seven/state/service_worker.go| 4 +++-
3 files changed, 24 insertions(+), 10 deletions(-)
diff --git a/cmd/ingress/ingress_test.go b/cmd/ingress/ingress_test.go
index 473c367..6d6d78a 100644
--- a/cmd/ingress/ingress_test.go
+++ b/cmd/ingress/ingress_test.go
@@ -83,7 +83,9 @@ func TestSignalHandler(t *testing.T) {
})
waitCh := make(chan struct{})
go func() {
- cmd.Execute()
+ if err := cmd.Execute(); err != nil {
+ log.Errorf("failed to execute command: %s", err)
+ }
close(waitCh)
}()
diff --git a/pkg/ingress/controller/controller.go
b/pkg/ingress/controller/controller.go
index 5f1805c..2669638 100644
--- a/pkg/ingress/controller/controller.go
+++ b/pkg/ingress/controller/controller.go
@@ -285,7 +285,9 @@ func (api6 *Api6Controller) ApisixRoute(controller
*Controller) {
api6.Api6ClientSet,
api6.SharedInformerFactory.Apisix().V1().ApisixRoutes(),
controller)
- arc.Run(api6.Stop)
+ if err := arc.Run(api6.Stop); err != nil {
+ log.Errorf("failed to run ApisixRouteController: %s", err)
+ }
}
func (api6 *Api6Controller) ApisixUpstream(controller *Controller) {
@@ -294,29 +296,37 @@ func (api6 *Api6Controller) ApisixUpstream(controller
*Controller) {
api6.Api6ClientSet,
api6.SharedInformerFactory.Apisix().V1().ApisixUpstreams(),
controller)
- auc.Run(api6.Stop)
+ if err := auc.Run(api6.Stop); err != nil {
+ log.Errorf("failed to run ApisixUpstreamController: %s", err)
+ }
}
func (api6 *Api6Controller) ApisixService(controller *Controller) {
- auc := BuildApisixServiceController(
+ asc := BuildApisixServiceController(
api6.KubeClientSet,
api6.Api6ClientSet,
api6.SharedInformerFactory.Apisix().V1().ApisixServices(),
controller)
- auc.Run(api6.Stop)
+ if err := asc.Run(api6.Stop); err != nil {
+ log.Errorf("failed to run ApisixServiceController: %s", err)
+ }
}
func (api6 *Api6Controller) ApisixTLS(controller *Controller) {
- auc := BuildApisixTlsController(
+ atc := BuildApisixTlsController(
api6.KubeClientSet,
api6.Api6ClientSet,
api6.SharedInformerFactory.Apisix().V1().ApisixTLSs(),
controller)
- auc.Run(api6.Stop)
+ if err := atc.Run(api6.Stop); err != nil {
+ log.Errorf("failed to run ApisixTlsController: %s", err)
+ }
}
func (api6 *Api6Controller) Endpoint(controller *Controller) {
- auc := BuildEndpointController(api6.KubeClientSet, controller)
+ ec := BuildEndpointController(api6.KubeClientSet, controller)
//conf.EndpointsInformer)
- auc.Run(api6.Stop)
+ if err := ec.Run(api6.Stop); err != nil {
+ log.Errorf("failed to run EndpointController: %s", err)
+ }
}
diff --git a/pkg/seven/state/service_worker.go
b/pkg/seven/state/service_worker.go
index 9ad1abe..8e19234 100644
--- a/pkg/seven/state/service_worker.go
+++ b/pkg/seven/state/service_worker.go
@@ -44,7 +44,9 @@ func (w *serviceWorker) start(rwg *RouteWorkerGroup) {
for {
select {
case event := <-w.Event:
- w.trigger(event, rwg)
+ if err := w.trigger(event, rwg); err != nil {
+ log.Errorf("failed to trigger event:
%s", err)
+ }
case <-w.Ctx.Done():
return
}
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1370: test: delete wait in test
codecov-io edited a comment on pull request #1370: URL: https://github.com/apache/apisix-dashboard/pull/1370#issuecomment-766559732 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=h1) Report > Merging [#1370](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=desc) (8d8654d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/7a157af60cc57fb49e5c1dcf2addca75c05857f1?el=desc) (7a157af) will **decrease** coverage by `14.06%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1370 +/- ## === - Coverage 62.62% 48.55% -14.07% === Files 41 42+1 Lines2360 2395 +35 === - Hits 1478 1163 -315 - Misses706 1032 +326 - Partials 176 200 +24 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `17.39% <0.00%> (-78.27%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `44.11% <0.00%> (-32.36%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `56.32% <0.00%> (-29.75%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `62.71% <0.00%> (-20.34%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `74.46% <0.00%> (-17.03%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `50.43% <0.00%> (-16.96%)` | :arrow_down: | | ... and [14 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=footer). Last update [7a157af...8d8654d](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1371: reduce plugin testcases' running time
juzhiyuan opened a new issue #1371: URL: https://github.com/apache/apisix-dashboard/issues/1371 # Feature request ## Please describe your feature  Plugin Test takes a long time to run. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766610459 In my opinion, from the perspective of apimix platform, I choose scheme a to satisfy the users of apimix platform A. The function that URI can be renamed is more open and friendly for users. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean commented on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766610459 In my opinion, from the perspective of apimix platform, I choose scheme a to satisfy the users of apimix platform. The function that URI can be renamed is more open and friendly for users. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1317: fix: cannot delete multiple plugins without page refreshing
juzhiyuan commented on pull request #1317: URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-766610362 @guoqqqi CI failed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #206: optimize endpoints controller
tokers commented on pull request #206: URL: https://github.com/apache/apisix-ingress-controller/pull/206#issuecomment-766609285 @gxthrj Please have a look when you have time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
juzhiyuan edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766607438 not sure how other platforms would resolve those issues, we should have a search. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
juzhiyuan commented on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766607438 not sure how other platforms would resolve those issues, we may have a search. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: chore: generate id instead let APISIX do it (#199)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new d9d22bb chore: generate id instead let APISIX do it (#199)
d9d22bb is described below
commit d9d22bb885f9a6dff6a4c2f74d9c5af2320d7423
Author: Alex Zhang
AuthorDate: Mon Jan 25 15:23:02 2021 +0800
chore: generate id instead let APISIX do it (#199)
---
Makefile | 3 ++
pkg/apisix/cluster.go | 31 -
pkg/apisix/resource.go | 4 ++
pkg/apisix/route.go| 47 +++
pkg/apisix/route_test.go | 13 +++---
pkg/apisix/service.go | 45 ++
pkg/apisix/service_test.go | 12 +++--
pkg/apisix/ssl.go | 61 ++--
pkg/apisix/ssl_test.go | 13 --
pkg/apisix/upstream.go | 45 ++
pkg/apisix/upstream_test.go| 12 +++--
pkg/seven/state/builder.go | 95 ++
pkg/seven/state/diff.go| 15 --
pkg/seven/state/service_worker.go | 13 ++
pkg/seven/state/solver.go | 6 +--
pkg/seven/state/sync.go| 15 --
pkg/seven/state/upstream_worker.go | 25 --
17 files changed, 287 insertions(+), 168 deletions(-)
diff --git a/Makefile b/Makefile
index a2c1411..1d01c1b 100644
--- a/Makefile
+++ b/Makefile
@@ -34,6 +34,7 @@
GITSHASYM="github.com/api7/ingress-controller/pkg/version._buildGitRevision"
BUILDOSSYM="github.com/api7/ingress-controller/pkg/version._buildOS"
GO_LDFLAGS ?= "-X=$(VERSYM)=$(VERSION) -X=$(GITSHASYM)=$(GITSHA)
-X=$(BUILDOSSYM)=$(OSNAME)/$(OSARCH)"
E2E_CONCURRENCY ?= 1
+E2E_SKIP_BUILD ?= 0
### build:Build apisix-ingress-controller
build:
@@ -75,9 +76,11 @@ endif
# build images to minikube node directly, it's an internal directive, so don't
# expose it's help message.
build-image-to-minikube:
+ifeq ($(E2E_SKIP_BUILD), 0)
@minikube version > /dev/null 2>&1 || (echo "ERROR: minikube is
required."; exit 1)
@eval $$(minikube docker-env);\
docker build -t apache/apisix-ingress-controller:$(IMAGE_TAG) .
+endif
### license-check:Do Apache License Header check
license-check:
diff --git a/pkg/apisix/cluster.go b/pkg/apisix/cluster.go
index 4a52412..b23e34f 100644
--- a/pkg/apisix/cluster.go
+++ b/pkg/apisix/cluster.go
@@ -255,6 +255,35 @@ func (s *cluster) do(req *http.Request) (*http.Response,
error) {
return s.cli.Do(req)
}
+func (s *cluster) getResource(ctx context.Context, url string) (*getResponse,
error) {
+ req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
+ if err != nil {
+ return nil, err
+ }
+ resp, err := s.do(req)
+ if err != nil {
+ return nil, err
+ }
+ defer drainBody(resp.Body, url)
+ if resp.StatusCode != http.StatusOK {
+ if resp.StatusCode == http.StatusNotFound {
+ return nil, cache.ErrNotFound
+ } else {
+ err = multierr.Append(err, fmt.Errorf("unexpected
status code %d", resp.StatusCode))
+ err = multierr.Append(err, fmt.Errorf("error message:
%s", readBody(resp.Body, url)))
+ }
+ return nil, err
+ }
+
+ var res getResponse
+
+ dec := json.NewDecoder(resp.Body)
+ if err := dec.Decode(); err != nil {
+ return nil, err
+ }
+ return , nil
+}
+
func (s *cluster) listResource(ctx context.Context, url string)
(*listResponse, error) {
req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
if err != nil {
@@ -281,7 +310,7 @@ func (s *cluster) listResource(ctx context.Context, url
string) (*listResponse,
}
func (s *cluster) createResource(ctx context.Context, url string, body
io.Reader) (*createResponse, error) {
- req, err := http.NewRequestWithContext(ctx, http.MethodPost, url, body)
+ req, err := http.NewRequestWithContext(ctx, http.MethodPut, url, body)
if err != nil {
return nil, err
}
diff --git a/pkg/apisix/resource.go b/pkg/apisix/resource.go
index 1c7ecc9..e411bf5 100644
--- a/pkg/apisix/resource.go
+++ b/pkg/apisix/resource.go
@@ -24,6 +24,10 @@ import (
v1 "github.com/api7/ingress-controller/pkg/types/apisix/v1"
)
+type getResponse struct {
+ Item item `json:"node"`
+}
+
// listResponse is the unified LIST response mapping of APISIX.
type listResponse struct {
Count string `json:"count"`
diff --git a/pkg/apisix/route.go b/pkg/apisix/route.go
index 51d9c9e..246f869 100644
--- a/pkg/apisix/route.go
+++ b/pkg/apisix/route.go
@@ -23,6 +23,7 @@ import (
"go.uber.org/zap"
[GitHub] [apisix-ingress-controller] tokers merged pull request #199: chore: generate id instead let APISIX do it
tokers merged pull request #199: URL: https://github.com/apache/apisix-ingress-controller/pull/199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on issue #1368: Update Deploy with RPM Doc
idbeta edited a comment on issue #1368: URL: https://github.com/apache/apisix-dashboard/issues/1368#issuecomment-766604184 The `Run` part of `deploy-with-rpm.md` should add description like this: without changing `/usr/local/apisix/dashboard/conf/conf.yaml`, you can visit http://127.0.0.1:9000 to use the dashboard with GUI, where the default username and password are `admin`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on issue #1368: Update Deploy with RPM Doc
idbeta commented on issue #1368: URL: https://github.com/apache/apisix-dashboard/issues/1368#issuecomment-766604184 `deploy-with-rpm.md` should add description like this: without changing `/usr/local/apisix/dashboard/conf/conf.yaml`, you can visit http://127.0.0.1:9000 to use the dashboard with GUI, where the default username and password are `admin`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #206: optimize endpoints controller
tokers opened a new pull request #206: URL: https://github.com/apache/apisix-ingress-controller/pull/206 This PR optimized the endpoints controller, now the controller won't push endpoints resources if the related upstream is not created, also, endpoints events will be retried if the pushing failed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
nic-chen commented on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766603524 I vote for option A, at least it can be imported and exported normally on APISIX platform. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
juzhiyuan edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766602482 because it's using `URI` as paths's `Key`, then data gets covered would happen. I would prefer adding a global prefix to avoid data lost. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
juzhiyuan commented on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766602482 because it's using `URI` as paths's `Key`, then data gets covered would happen. I would prefer adding a global prefix to avoid this happen. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3363: feat(fault-injection): support conditional fault injection using nginx variables
Firstsawyou commented on a change in pull request #3363:
URL: https://github.com/apache/apisix/pull/3363#discussion_r563501300
##
File path: apisix/plugins/fault-injection.lua
##
@@ -77,11 +151,30 @@ end
function _M.rewrite(conf, ctx)
core.log.info("plugin rewrite phase, conf: ", core.json.delay_encode(conf))
-if conf.delay and sample_hit(conf.delay.percentage) then
+local err
+local abort_vars = true
+if conf.abort and conf.abort.vars then
+abort_vars, err = vars_match(conf.abort.vars, ctx)
+if err then
+return 500, err
Review comment:
The log is recorded here:
[https://github.com/apache/apisix/pull/3363/files#diff-a2a9ef17c5a2a556f996066b04132d8dd9a848b31eff4a340f5b154283af98deR90
](https://github.com/apache/apisix/pull/3363/files#diff-a2a9ef17c5a2a556f996066b04132d8dd9a848b31eff4a340f5b154283af98deR90)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3363: feat(fault-injection): support conditional fault injection using nginx variables
Firstsawyou commented on a change in pull request #3363:
URL: https://github.com/apache/apisix/pull/3363#discussion_r563499801
##
File path: apisix/plugins/fault-injection.lua
##
@@ -64,6 +119,25 @@ local function sample_hit(percentage)
end
+local function vars_match(vars, ctx)
+local match_result
+for _, var in ipairs(vars) do
+local expr, err = expr.new(var)
+if err then
+core.log.error("vars expression does not match: ", err)
+return nil, err
+end
+
+match_result = expr:eval(ctx.var)
+if match_result then
+break
+end
+end
+
+return match_result, nil
+end
+
+
function _M.check_schema(conf)
local ok, err = core.schema.check(schema, conf)
Review comment:
updated.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on issue #3412: bug: kubernetes/deployment.yaml not work on kind
Yiyiyimu commented on issue #3412: URL: https://github.com/apache/apisix/issues/3412#issuecomment-766597701 Hi @spacewander! Do you know the reason for this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu opened a new issue #3412: bug: kubernetes/deployment.yaml could not working on kind
Yiyiyimu opened a new issue #3412: URL: https://github.com/apache/apisix/issues/3412 ### Issue description When deploy apisix on k8s in minikube, it works fine. But on kind, when apply apisix deployment, error would come as: ``` Events: Type Reason Age From Message -- --- Warning FailedMount 59m kubelet, kind-control-plane Unable to attach or mount volumes: unmounted volumes=[localtime], unattached volumes=[localtime default-token-k4dr7 apisix-config-yaml-configmap]: timed out waiting for the condition Warning FailedMount 47m (x2 over 50m) kubelet, kind-control-plane Unable to attach or mount volumes: unmounted volumes=[localtime], unattached volumes=[apisix-config-yaml-configmap localtime default-token-k4dr7]: timed out waiting for the condition Warning FailedMount 4m43s (x19 over 63m) kubelet, kind-control-plane Unable to attach or mount volumes: unmounted volumes=[localtime], unattached volumes=[default-token-k4dr7 apisix-config-yaml-configmap localtime]: timed out waiting for the condition Warning FailedMount 24s (x40 over 65m)kubelet, kind-control-plane MountVolume.SetUp failed for volume "localtime" : hostPath type check failed: /etc/localtime is not a file ``` So the error comes from the file existence check, which is https://github.com/apache/apisix/blob/6331e5d05734f19f398b8dbae7f0470ce6069c98/kubernetes/deployment.yaml#L104-L111 although the file does exist. Try to replace the symbolic link with the actual file, but it still not work. If removed the file check, the error would be like: ``` Error: failed to create containerd task: OCI runtime create failed: container_linux.go:349: starting container process caused "process_linux.go:449: container init caused \"rootfs_linux.go:58: mounting \\\"/etc/localtime\\\" to rootfs \\\"/run/containerd/io.containerd.runtime.v2.task/k8s.io/apisix-gw-deployment/rootfs\\\" at \\\"/run/containerd/io.containerd.runtime.v2.task/k8s.io/apisix-gw-deployment/rootfs/usr/share/zoneinfo/UTC\\\" caused \\\"not a directory\\\"\"": unknown ``` ### Environment * apisix version : master * OS: WSL2, Ubuntu 18.04 * kind version: v0.8.1 * k8s version: v1.18.2 ### Minimal test code / Steps to reproduce the issue Following https://github.com/apache/apisix/blob/master/kubernetes/README.md ### What's the actual result? (including assertion message & call stack if applicable) ### What's the expected result? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3363: feat(fault-injection): support conditional fault injection using nginx variables
Firstsawyou commented on a change in pull request #3363: URL: https://github.com/apache/apisix/pull/3363#discussion_r563498742 ## File path: doc/plugins/fault-injection.md ## @@ -30,11 +30,43 @@ Fault injection plugin, this plugin can be used with other plugins and will be e | abort.http_status | integer | required| | [200, ...] | user-specified http code returned to the client. | | abort.body| string | optional| || response data returned to the client. Nginx variable can be used inside, like `client addr: $remote_addr\n` | | abort.percentage | integer | optional| | [0, 100] | percentage of requests to be aborted.| +| abort.vars| array[] | optional| || The rules for executing fault injection will only be executed when the rules are matched. `vars` is a list consisting of one or more [[var, operator, val]] elements, like this: [[[var, operator, val],[var, operator, val]], ...]. For example: [[["arg_name", "==", "json"]]], indicating that the current request parameter name is json. The var here is consistent with the naming of Nginx internal variables, so request_uri, host, etc. can also be used; for the operator part, the currently supported operators are ==, ~=, ~~, >, <, in, has and !. For specific usage of operators, please see the `operator-list` part of [lua-resty-expr](https://github.com/api7/lua-resty-expr#operator-list). | | delay.duration| number | required| || delay time (can be decimal). | | delay.percentage | integer | optional| | [0, 100] | percentage of requests to be delayed.| +| delay.vars| array[] | optional| || Execute the request delay rule, and the request will be delayed only after the rule matches. `vars` is a list consisting of one or more [[var, operator, val]] elements, like this: [[[var, operator, val],[var, operator, val]], ...]. For example: [[["arg_name", "==", "json"]]], indicating that the current request parameter name is json. The var here is consistent with the naming of Nginx internal variables, so request_uri, host, etc. can also be used; for the operator part, the currently supported operators are ==, ~=, ~~, >, <, in, has and !. For specific usage of operators, please see the `operator-list` part of [lua-resty-expr](https://github.com/api7/lua-resty-expr#operator-list). | Note: One of `abort` and `delay` must be specified. +`vars` is composed of a three-level array structure, as shown below: + +```json +array[ +array[ +array[] +], +array[ +array[] +], +.. +] +``` + +It can implement the `and/or` relationship between rules flexibly, such as the following three expressions: + +```json +[ +[ +[ "arg_name","==","jack" ], +[ "arg_age","==",18 ] +], +[ +[ "arg_name2","==","allen" ] +] +] +``` + +Indicates that the relationship between the first two expressions is `and`, and the relationship between the first two expressions and the third expression is `or`. Review comment: updated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3363: feat(fault-injection): support conditional fault injection using nginx variables
Firstsawyou commented on a change in pull request #3363:
URL: https://github.com/apache/apisix/pull/3363#discussion_r563498525
##
File path: apisix/plugins/fault-injection.lua
##
@@ -15,13 +15,66 @@
-- limitations under the License.
--
local core = require("apisix.core")
+local expr = require("resty.expr.v1")
local sleep = core.sleep
local random = math.random
+local ipairs = ipairs
local plugin_name = "fault-injection"
+local vars_schema = {
Review comment:
updated.
##
File path: apisix/plugins/fault-injection.lua
##
@@ -64,6 +119,25 @@ local function sample_hit(percentage)
end
+local function vars_match(vars, ctx)
+local match_result
+for _, var in ipairs(vars) do
+local expr, err = expr.new(var)
+if err then
+core.log.error("vars expression does not match: ", err)
Review comment:
updated.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1316: GlobalPlugin List: cannot delete multiple plugins without page refreshing
juzhiyuan closed issue #1316: URL: https://github.com/apache/apisix-dashboard/issues/1316 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1317: fix: cannot delete multiple plugins without page refreshing
juzhiyuan merged pull request #1317: URL: https://github.com/apache/apisix-dashboard/pull/1317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (b0c531d -> 1bdcaa8)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from b0c531d fix(fe): update url regexp in online debug (#1326) add 1bdcaa8 fix: cannot delete multiple plugins without page refreshing (#1317) No new revisions were added by this update. Summary of changes: web/cypress/fixtures/plugin-list.json | 41 .../plugin/create_and_delete_plugin.spec.js| 61 ++ .../integration/plugin/schema-smocktest.spec.js| 72 + web/cypress/support/commands.js| 73 ++ web/src/pages/Plugin/List.tsx | 1 + 5 files changed, 177 insertions(+), 71 deletions(-) create mode 100644 web/cypress/fixtures/plugin-list.json create mode 100644 web/cypress/integration/plugin/create_and_delete_plugin.spec.js
[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766587292
> @liuxiran @nic-chen
> The unit test and test cases have been supplemented. In the process of
testing, I found a problem：
>
> * At present, the path data structure of OpenAPI 3 is used to store URIs,
and the data structure is map [string]. If the URI is repeated, the data will
be covered, if the repeated URIs are directly covered, only one URI can be
exported, which will lead to the loss of user data.
> * My idea is to add a uniform suffix after the same URI when exporting, so
that the import can recognize the URI
> For example：
>
> ```
> {
>"components": {},
>"info": {
>"title": "RoutesExport",
>"version": "3.0.0"
>},
>"openapi": "3.0.0",
>"paths": {
>"/hello": {
>"get": {}
>}
>"/hello-repeaturi1": {
>"get": {}
>}
>"/hello-repeaturi2": {
>"get": {}
>}
>}
> }
> ```
>
> * My method also has the risk of repeating the user named URI
> * Do you have any better suggestions? We can discuss them. Thks.
>OpenAPI defines a unique operation as a combination of a path and an HTTP
method. This means that two GET or two POST methods for the same path are not
allowed – even if they have different parameters (parameters have no effect on
uniqueness)
refer from https://swagger.io/docs/specification/paths-and-operations/
After communicating with @Jaycean and @nic-chen there are two alternative
solutions:
- A: add a uniform suffix after the same URI when exporting, and add a
description to the user guide.
This solution can meet the platform-wide data is not lost, the disadvantage
is that when users need to use the swagger file to generate documents or sdk,
they need to modified manually.
- B: return error when exporting routes with same URI
In this way exported OAS3.0 file can be used directly, with the
disadvantage that there may be data loss for APISIX. The remedy is that we
provide additional import and export of platform-wide data, in accordance with
the apisix data format.
Neither scheme is perfect though, which one do you perfer? any suggestions
are welcome, thanks a lot
@Jaycean @nic-chen @membphis @starsz @juzhiyuan @imjoey
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean commented on a change in pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#discussion_r563494858
##
File path: api/internal/handler/data_loader/route_export.go
##
@@ -0,0 +1,441 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package data_loader
+
+import (
+ "context"
+ "encoding/json"
+ "fmt"
+ "net/http"
+ "reflect"
+ "strings"
+
+ "github.com/apisix/manager-api/internal/core/entity"
+ "github.com/apisix/manager-api/internal/core/store"
+ "github.com/apisix/manager-api/internal/handler"
+ "github.com/apisix/manager-api/internal/log"
+ "github.com/apisix/manager-api/internal/utils"
+ "github.com/getkin/kin-openapi/openapi3"
+ "github.com/gin-gonic/gin"
+ "github.com/shiningrush/droplet"
+ "github.com/shiningrush/droplet/data"
+ "github.com/shiningrush/droplet/wrapper"
+ wgin "github.com/shiningrush/droplet/wrapper/gin"
+)
+
+type Handler struct {
+ routeStorestore.Interface
+ upstreamStore store.Interface
+ serviceStore store.Interface
+ consumerStore store.Interface
+}
+
+func NewHandler() (handler.RouteRegister, error) {
+ return {
+ routeStore:store.GetStore(store.HubKeyRoute),
+ upstreamStore: store.GetStore(store.HubKeyUpstream),
+ serviceStore: store.GetStore(store.HubKeyService),
+ consumerStore: store.GetStore(store.HubKeyConsumer),
+ }, nil
+}
+
+func (h *Handler) ApplyRoute(r *gin.Engine) {
+ r.POST("/apisix/admin/routes/export/:ids", wgin.Wraps(h.ExportRoutes,
+ wrapper.InputType(reflect.TypeOf(ExportInput{}
+ r.GET("/apisix/admin/exportall/routes", wgin.Wraps(h.ExportAllRoutes))
+}
+
+type ExportInput struct {
+ IDs string `auto_read:"ids,path"`
+}
+
+func (h *Handler) ExportRoutes(c droplet.Context) (interface{}, error) {
+ input := c.Input().(*ExportInput)
+ ids := strings.Split(input.IDs, ",")
+ routes := []*entity.Route{}
+
+ for _, id := range ids {
+ route, err := h.routeStore.Get(context.Background(), id)
+ if err != nil {
+ return nil, err
+ }
+ routes = append(routes, route.(*entity.Route))
+ }
+
+ swagger, err := h.routeToOpenApi3(routes)
+ if err != nil {
+ return nil, err
+ }
+ return swagger, nil
+}
+
+type AuthType string
+
+const (
+ BasicAuth AuthType = "basic-auth"
+ KeyAuth AuthType = "key-auth"
+ JWTAuth AuthType = "jwt-auth"
+)
+
+var (
+ openApi = "3.0.0"
+ title = "RoutesExport"
+ service interface{}
+ err error
+)
+
+func (h *Handler) ExportAllRoutes(c droplet.Context) (interface{}, error) {
+ routelist, err := h.routeStore.List(c.Context(), store.ListInput{})
+
+ if err != nil {
+ return nil, err
+ }
+
+ routes := []*entity.Route{}
+
+ for _, route := range routelist.Rows {
+ routes = append(routes, route.(*entity.Route))
+ }
+
+ swagger, err := h.routeToOpenApi3(routes)
+ if err != nil {
+ return nil, err
+ }
+ return swagger, nil
+}
+
+func (h *Handler) routeToOpenApi3(routes []*entity.Route) (*openapi3.Swagger,
error) {
+ paths := openapi3.Paths{}
+ paramsRefs := []*openapi3.ParameterRef{}
+ requestBody := {}
+ components := {}
+ secSchemas := openapi3.SecuritySchemes{}
+ servicePlugins := make(map[string]interface{})
+ plugins := make(map[string]interface{})
+ serviceLabels := make(map[string]string)
+ labels := make(map[string]string)
+
+ for _, route := range routes {
+ extensions := make(map[string]interface{})
+ pathItem := {}
+ path := openapi3.Operation{}
+ path.Summary = route.Desc
+ path.OperationID = route.Name
+
+ if route.ServiceID != nil {
+ serviceID := utils.InterfaceToString(route.ServiceID)
+ service, err =
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean commented on a change in pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#discussion_r563494403
##
File path: api/internal/handler/data_loader/route_export.go
##
@@ -0,0 +1,441 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package data_loader
+
+import (
+ "context"
+ "encoding/json"
+ "fmt"
+ "net/http"
+ "reflect"
+ "strings"
+
+ "github.com/apisix/manager-api/internal/core/entity"
+ "github.com/apisix/manager-api/internal/core/store"
+ "github.com/apisix/manager-api/internal/handler"
+ "github.com/apisix/manager-api/internal/log"
+ "github.com/apisix/manager-api/internal/utils"
+ "github.com/getkin/kin-openapi/openapi3"
+ "github.com/gin-gonic/gin"
+ "github.com/shiningrush/droplet"
+ "github.com/shiningrush/droplet/data"
+ "github.com/shiningrush/droplet/wrapper"
+ wgin "github.com/shiningrush/droplet/wrapper/gin"
+)
+
+type Handler struct {
+ routeStorestore.Interface
+ upstreamStore store.Interface
+ serviceStore store.Interface
+ consumerStore store.Interface
+}
+
+func NewHandler() (handler.RouteRegister, error) {
+ return {
+ routeStore:store.GetStore(store.HubKeyRoute),
+ upstreamStore: store.GetStore(store.HubKeyUpstream),
+ serviceStore: store.GetStore(store.HubKeyService),
+ consumerStore: store.GetStore(store.HubKeyConsumer),
+ }, nil
+}
+
+func (h *Handler) ApplyRoute(r *gin.Engine) {
+ r.POST("/apisix/admin/routes/export/:ids", wgin.Wraps(h.ExportRoutes,
+ wrapper.InputType(reflect.TypeOf(ExportInput{}
+ r.GET("/apisix/admin/exportall/routes", wgin.Wraps(h.ExportAllRoutes))
+}
+
+type ExportInput struct {
+ IDs string `auto_read:"ids,path"`
+}
+
+func (h *Handler) ExportRoutes(c droplet.Context) (interface{}, error) {
+ input := c.Input().(*ExportInput)
+ ids := strings.Split(input.IDs, ",")
+ routes := []*entity.Route{}
+
+ for _, id := range ids {
+ route, err := h.routeStore.Get(context.Background(), id)
+ if err != nil {
+ return nil, err
+ }
+ routes = append(routes, route.(*entity.Route))
+ }
+
+ swagger, err := h.routeToOpenApi3(routes)
+ if err != nil {
+ return nil, err
+ }
+ return swagger, nil
+}
+
+type AuthType string
+
+const (
+ BasicAuth AuthType = "basic-auth"
+ KeyAuth AuthType = "key-auth"
+ JWTAuth AuthType = "jwt-auth"
+)
+
+var (
+ openApi = "3.0.0"
+ title = "RoutesExport"
+ service interface{}
+ err error
+)
+
+func (h *Handler) ExportAllRoutes(c droplet.Context) (interface{}, error) {
+ routelist, err := h.routeStore.List(c.Context(), store.ListInput{})
+
+ if err != nil {
+ return nil, err
+ }
+
+ routes := []*entity.Route{}
+
+ for _, route := range routelist.Rows {
+ routes = append(routes, route.(*entity.Route))
+ }
+
+ swagger, err := h.routeToOpenApi3(routes)
+ if err != nil {
+ return nil, err
+ }
+ return swagger, nil
+}
+
+func (h *Handler) routeToOpenApi3(routes []*entity.Route) (*openapi3.Swagger,
error) {
+ paths := openapi3.Paths{}
+ paramsRefs := []*openapi3.ParameterRef{}
+ requestBody := {}
+ components := {}
+ secSchemas := openapi3.SecuritySchemes{}
+ servicePlugins := make(map[string]interface{})
+ plugins := make(map[string]interface{})
+ serviceLabels := make(map[string]string)
+ labels := make(map[string]string)
+
+ for _, route := range routes {
+ extensions := make(map[string]interface{})
+ pathItem := {}
+ path := openapi3.Operation{}
+ path.Summary = route.Desc
+ path.OperationID = route.Name
+
+ if route.ServiceID != nil {
+ serviceID := utils.InterfaceToString(route.ServiceID)
+ service, err =
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean commented on a change in pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#discussion_r563493790
##
File path: api/internal/handler/data_loader/route_export.go
##
@@ -0,0 +1,441 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package data_loader
+
+import (
+ "context"
+ "encoding/json"
+ "fmt"
+ "net/http"
+ "reflect"
+ "strings"
+
+ "github.com/apisix/manager-api/internal/core/entity"
+ "github.com/apisix/manager-api/internal/core/store"
+ "github.com/apisix/manager-api/internal/handler"
+ "github.com/apisix/manager-api/internal/log"
+ "github.com/apisix/manager-api/internal/utils"
+ "github.com/getkin/kin-openapi/openapi3"
+ "github.com/gin-gonic/gin"
+ "github.com/shiningrush/droplet"
+ "github.com/shiningrush/droplet/data"
+ "github.com/shiningrush/droplet/wrapper"
+ wgin "github.com/shiningrush/droplet/wrapper/gin"
+)
+
+type Handler struct {
+ routeStorestore.Interface
+ upstreamStore store.Interface
+ serviceStore store.Interface
+ consumerStore store.Interface
+}
+
+func NewHandler() (handler.RouteRegister, error) {
+ return {
+ routeStore:store.GetStore(store.HubKeyRoute),
+ upstreamStore: store.GetStore(store.HubKeyUpstream),
+ serviceStore: store.GetStore(store.HubKeyService),
+ consumerStore: store.GetStore(store.HubKeyConsumer),
+ }, nil
+}
+
+func (h *Handler) ApplyRoute(r *gin.Engine) {
+ r.POST("/apisix/admin/routes/export/:ids", wgin.Wraps(h.ExportRoutes,
+ wrapper.InputType(reflect.TypeOf(ExportInput{}
+ r.GET("/apisix/admin/exportall/routes", wgin.Wraps(h.ExportAllRoutes))
+}
+
+type ExportInput struct {
+ IDs string `auto_read:"ids,path"`
+}
+
+func (h *Handler) ExportRoutes(c droplet.Context) (interface{}, error) {
+ input := c.Input().(*ExportInput)
+ ids := strings.Split(input.IDs, ",")
+ routes := []*entity.Route{}
+
+ for _, id := range ids {
+ route, err := h.routeStore.Get(context.Background(), id)
Review comment:
no problem.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
liuxiran edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766587292
> @liuxiran @nic-chen
> The unit test and test cases have been supplemented. In the process of
testing, I found a problem：
>
> * At present, the path data structure of OpenAPI 3 is used to store URIs,
and the data structure is map [string]. If the URI is repeated, the data will
be covered, if the repeated URIs are directly covered, only one URI can be
exported, which will lead to the loss of user data.
> * My idea is to add a uniform suffix after the same URI when exporting, so
that the import can recognize the URI
> For example：
>
> ```
> {
>"components": {},
>"info": {
>"title": "RoutesExport",
>"version": "3.0.0"
>},
>"openapi": "3.0.0",
>"paths": {
>"/hello": {
>"get": {}
>}
>"/hello-repeaturi1": {
>"get": {}
>}
>"/hello-repeaturi2": {
>"get": {}
>}
>}
> }
> ```
>
> * My method also has the risk of repeating the user named URI
> * Do you have any better suggestions? We can discuss them. Thks.
>OpenAPI defines a unique operation as a combination of a path and an HTTP
method. This means that two GET or two POST methods for the same path are not
allowed – even if they have different parameters (parameters have no effect on
uniqueness)
refer from https://swagger.io/docs/specification/paths-and-operations/
After communicating with @Jaycean and @nic-chen there are three alternative
solutions:
- A: add a uniform suffix after the same URI when exporting, and add a
description to the user guide.
This solution can meet the platform-wide data is not lost, the disadvantage
is that when users need to use the swagger file to generate documents or sdk,
they need to modified manually.
- B: return error when exporting routes with same URI
In this way exported OAS3.0 file can be used directly, with the
disadvantage that there may be data loss for APISIX. The remedy is that we
provide additional import and export of platform-wide data, in accordance with
the apisix data format.
Neither scheme is perfect though, which one do you perfer? any suggestions
are welcome, thanks a lot
@Jaycean @nic-chen @membphis @starsz @juzhiyuan @imjoey
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
liuxiran commented on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766587292
> @liuxiran @nic-chen
> The unit test and test cases have been supplemented. In the process of
testing, I found a problem：
>
> * At present, the path data structure of OpenAPI 3 is used to store URIs,
and the data structure is map [string]. If the URI is repeated, the data will
be covered, if the repeated URIs are directly covered, only one URI can be
exported, which will lead to the loss of user data.
> * My idea is to add a uniform suffix after the same URI when exporting, so
that the import can recognize the URI
> For example：
>
> ```
> {
>"components": {},
>"info": {
>"title": "RoutesExport",
>"version": "3.0.0"
>},
>"openapi": "3.0.0",
>"paths": {
>"/hello": {
>"get": {}
>}
>"/hello-repeaturi1": {
>"get": {}
>}
>"/hello-repeaturi2": {
>"get": {}
>}
>}
> }
> ```
>
> * My method also has the risk of repeating the user named URI
> * Do you have any better suggestions? We can discuss them. Thks.
>OpenAPI defines a unique operation as a combination of a path and an HTTP
method. This means that two GET or two POST methods for the same path are not
allowed – even if they have different parameters (parameters have no effect on
uniqueness)
refer from https://swagger.io/docs/specification/paths-and-operations/
After communicating with @Jaycean and @nic-chen there are three alternative
solutions:
- A: add a uniform suffix after the same URI when exporting, and add a
description to the user guide.
This solution can meet the platform-wide data is not lost, the disadvantage
is that when users need to use the swagger file to generate documents or sdk,
they need to modified manually.
- B: return error when exporting routes with same URI
In this way exported OAS3.0 file can be used directly, with the
disadvantage that there may be data loss for APISIX. The remedy is that we
provide additional import and export of platform-wide data, in accordance with
the apisix data format.
which one do you perfer? any suggestions are welcome, thanks a lot
@Jaycean @nic-chen @membphis @starsz @juzhiyuan @imjoey
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1370: test: delete wait in test
codecov-io edited a comment on pull request #1370: URL: https://github.com/apache/apisix-dashboard/pull/1370#issuecomment-766559732 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=h1) Report > Merging [#1370](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=desc) (22b9d8d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/7a157af60cc57fb49e5c1dcf2addca75c05857f1?el=desc) (7a157af) will **decrease** coverage by `14.56%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1370 +/- ## === - Coverage 62.62% 48.05% -14.57% === Files 41 42+1 Lines2360 2395 +35 === - Hits 1478 1151 -327 - Misses706 1047 +341 - Partials 176 197 +21 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `17.39% <0.00%> (-78.27%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `44.11% <0.00%> (-32.36%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `55.06% <0.00%> (-31.02%)` | :arrow_down: | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `54.41% <0.00%> (-22.68%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `62.71% <0.00%> (-20.34%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `74.46% <0.00%> (-17.03%)` | :arrow_down: | | ... and [15 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=footer). Last update [7a157af...22b9d8d](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey merged pull request #1326: fix(fe): update url regexp in online debug
imjoey merged pull request #1326: URL: https://github.com/apache/apisix-dashboard/pull/1326 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (39aac5b -> b0c531d)
This is an automated email from the ASF dual-hosted git repository. majunjie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 39aac5b chore: add stop subcommand (#741) add b0c531d fix(fe): update url regexp in online debug (#1326) No new revisions were added by this update. Summary of changes: web/config/defaultSettings.ts | 8 +++ web/config/proxy.ts| 7 +-- web/cypress/integration/route/online-debug.spec.js | 68 ++ web/cypress/support/commands.js| 8 +-- web/src/components/Plugin/PluginDetail.tsx | 14 +++-- .../Route/components/DebugViews/DebugDrawView.tsx | 3 +- 6 files changed, 91 insertions(+), 17 deletions(-) create mode 100644 web/cypress/integration/route/online-debug.spec.js
[GitHub] [apisix-dashboard] imjoey closed issue #1325: allow - character in the OnlineDebug module
imjoey closed issue #1325: URL: https://github.com/apache/apisix-dashboard/issues/1325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz closed issue #741: Implmement sub-command like stop, restart for manager-api
starsz closed issue #741: URL: https://github.com/apache/apisix-dashboard/issues/741 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz merged pull request #1333: chore: add stop subcommand
starsz merged pull request #1333: URL: https://github.com/apache/apisix-dashboard/pull/1333 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: chore: add stop subcommand (#741)
This is an automated email from the ASF dual-hosted git repository.
starsz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 39aac5b chore: add stop subcommand (#741)
39aac5b is described below
commit 39aac5bd23d25dc08cfddbab4bc3e886362c
Author: Alex Zhang
AuthorDate: Mon Jan 25 14:14:21 2021 +0800
chore: add stop subcommand (#741)
---
Makefile | 3 +--
api/cmd/managerapi.go | 36 ++
api/internal/conf/conf.go | 1 +
api/internal/utils/pid.go | 53 ++
api/test/shell/cli_test.sh | 64 +-
docs/deploy.md | 5 +++-
6 files changed, 141 insertions(+), 21 deletions(-)
diff --git a/Makefile b/Makefile
index 79de9e0..0937206 100644
--- a/Makefile
+++ b/Makefile
@@ -69,8 +69,7 @@ api-run: api-default
### api-stop: Stop the manager-api
api-stop:
- kill $(ps aux | grep 'manager-api' | awk '{print $2}')
-
+ cd api && go run -ldflags "${GOLDFLAGS}" ./cmd/manager stop
### go-lint: Lint Go source code
.PHONY: go-lint
diff --git a/api/cmd/managerapi.go b/api/cmd/managerapi.go
index d36c3d8..d0dc1d0 100644
--- a/api/cmd/managerapi.go
+++ b/api/cmd/managerapi.go
@@ -60,6 +60,19 @@ func NewManagerAPICommand() *cobra.Command {
RunE: func(cmd *cobra.Command, args []string) error {
conf.InitConf()
log.InitLogger()
+
+ if err := utils.WritePID(conf.PIDPath); err != nil {
+ log.Errorf("failed to write pid: %s", err)
+ panic(err)
+ }
+ utils.AppendToClosers(func() error {
+ if err := os.Remove(conf.PIDPath); err != nil {
+ log.Errorf("failed to remove pid path:
%s", err)
+ return err
+ }
+ return nil
+ })
+
droplet.Option.Orchestrator = func(mws
[]droplet.Middleware) []droplet.Middleware {
var newMws []droplet.Middleware
// default middleware order: resp_reshape,
auto_input, traffic_log
@@ -119,5 +132,28 @@ func NewManagerAPICommand() *cobra.Command {
}
cmd.PersistentFlags().StringVarP(, "work-dir", "p", ".",
"current work directory")
+
+ cmd.AddCommand(newStopCommand())
+ return cmd
+}
+
+func newStopCommand() *cobra.Command {
+ cmd := {
+ Use: "stop",
+ Run: func(cmd *cobra.Command, args []string) {
+ pid, err := utils.ReadPID(conf.PIDPath)
+ if err != nil {
+ if syscall.ENOENT.Error() != err.Error() {
+ fmt.Fprintf(os.Stderr, "failed to get
manager-api pid: %s\n", err)
+ } else {
+ fmt.Fprintf(os.Stderr, "pid path %s
not found, is manager-api running?\n", conf.PIDPath)
+ }
+ return
+ }
+ if err := syscall.Kill(pid, syscall.SIGINT); err != nil
{
+ fmt.Fprintf(os.Stderr, "failed to kill
manager-api: %s", err)
+ }
+ },
+ }
return cmd
}
diff --git a/api/internal/conf/conf.go b/api/internal/conf/conf.go
index e01ef41..883b1a6 100644
--- a/api/internal/conf/conf.go
+++ b/api/internal/conf/conf.go
@@ -52,6 +52,7 @@ var (
UserList = make(map[string]User, 2)
AuthConf Authentication
SSLDefaultStatus = 1 //enable ssl by default
+ PIDPath = "/tmp/manager-api.pid"
)
type Etcd struct {
diff --git a/api/internal/utils/pid.go b/api/internal/utils/pid.go
new file mode 100644
index 000..066a4c3
--- /dev/null
+++ b/api/internal/utils/pid.go
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License
[GitHub] [apisix] idbeta commented on a change in pull request #3404: feat: chaos test on route could still works when etcd is down
idbeta commented on a change in pull request #3404:
URL: https://github.com/apache/apisix/pull/3404#discussion_r563442953
##
File path: .github/workflows/chaos.yml
##
@@ -0,0 +1,61 @@
+name: Chaos Test
+
+on: [push, pull_request]
+
+jobs:
+ build:
+runs-on: ubuntu-latest
+steps:
+- uses: actions/checkout@v2
+
+- name: setup go
+ uses: actions/setup-go@v2.1.3
+ with:
+go-version: '1.13'
+
+- name: Creating kind cluster
+ uses: helm/kind-action@v1.0.0-rc.1
+
+- name: Print cluster information
+ run: |
+kubectl config view
+kubectl cluster-info
+kubectl get nodes
+kubectl get pods -n kube-system
+helm version
+kubectl version
+- uses: actions/checkout@v2
+
+# TODO: should not use personal repo, while it's hard to modify a lot in
an archived repo. Could we use api7's repo?
+- name: Deploy Etcd Operator
+ run: |
+git clone https://github.com/yiyiyimu/etcd-operator.git --depth 1
+cd etcd-operator
+example/rbac/create_role.sh
+kubectl create -f example/deployment.yaml
+while [[ $(kubectl get pods -l app=etcd-operator -o
'jsonpath={..status.conditions[?(@.type=="Ready")].status}') != "True" ]]; do
echo "Waiting for pod running" && sleep 10; done
+kubectl create -f example/example-etcd-cluster.yaml
+while [[ $(kubectl get pods -l app=etcd -o
'jsonpath={..status.conditions[?(@.type=="Ready")].status}') != "True True
True" ]]; do echo "Waiting for pod running" && sleep 10; done
+
+- name: Deploy APISIX
+ run: |
+echo '
+dns_resolver:
+ - 10.96.0.10
+etcd:
+ host:
+- "http://etcd-cluster-client.default.svc.cluster.local:2379;
+' > conf/config.yaml
+example/rbac/create_role.sh
Review comment:
This line shouldn't be needed here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
starsz commented on a change in pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#discussion_r563474852
##
File path: api/internal/handler/data_loader/route_export.go
##
@@ -0,0 +1,441 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package data_loader
+
+import (
+ "context"
+ "encoding/json"
+ "fmt"
+ "net/http"
+ "reflect"
+ "strings"
+
+ "github.com/apisix/manager-api/internal/core/entity"
+ "github.com/apisix/manager-api/internal/core/store"
+ "github.com/apisix/manager-api/internal/handler"
+ "github.com/apisix/manager-api/internal/log"
+ "github.com/apisix/manager-api/internal/utils"
+ "github.com/getkin/kin-openapi/openapi3"
+ "github.com/gin-gonic/gin"
+ "github.com/shiningrush/droplet"
+ "github.com/shiningrush/droplet/data"
+ "github.com/shiningrush/droplet/wrapper"
+ wgin "github.com/shiningrush/droplet/wrapper/gin"
+)
+
+type Handler struct {
+ routeStorestore.Interface
+ upstreamStore store.Interface
+ serviceStore store.Interface
+ consumerStore store.Interface
+}
+
+func NewHandler() (handler.RouteRegister, error) {
+ return {
+ routeStore:store.GetStore(store.HubKeyRoute),
+ upstreamStore: store.GetStore(store.HubKeyUpstream),
+ serviceStore: store.GetStore(store.HubKeyService),
+ consumerStore: store.GetStore(store.HubKeyConsumer),
+ }, nil
+}
+
+func (h *Handler) ApplyRoute(r *gin.Engine) {
+ r.POST("/apisix/admin/routes/export/:ids", wgin.Wraps(h.ExportRoutes,
+ wrapper.InputType(reflect.TypeOf(ExportInput{}
+ r.GET("/apisix/admin/exportall/routes", wgin.Wraps(h.ExportAllRoutes))
+}
+
+type ExportInput struct {
+ IDs string `auto_read:"ids,path"`
+}
+
+func (h *Handler) ExportRoutes(c droplet.Context) (interface{}, error) {
+ input := c.Input().(*ExportInput)
+ ids := strings.Split(input.IDs, ",")
+ routes := []*entity.Route{}
+
+ for _, id := range ids {
+ route, err := h.routeStore.Get(context.Background(), id)
Review comment:
Hi, I think we need to avoid use context.Background here. We should use
c.Context().
##
File path: api/internal/handler/data_loader/route_export.go
##
@@ -0,0 +1,441 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package data_loader
+
+import (
+ "context"
+ "encoding/json"
+ "fmt"
+ "net/http"
+ "reflect"
+ "strings"
+
+ "github.com/apisix/manager-api/internal/core/entity"
+ "github.com/apisix/manager-api/internal/core/store"
+ "github.com/apisix/manager-api/internal/handler"
+ "github.com/apisix/manager-api/internal/log"
+ "github.com/apisix/manager-api/internal/utils"
+ "github.com/getkin/kin-openapi/openapi3"
+ "github.com/gin-gonic/gin"
+ "github.com/shiningrush/droplet"
+ "github.com/shiningrush/droplet/data"
+ "github.com/shiningrush/droplet/wrapper"
+ wgin "github.com/shiningrush/droplet/wrapper/gin"
+)
+
+type Handler struct {
+ routeStorestore.Interface
+ upstreamStore store.Interface
+ serviceStore store.Interface
+ consumerStore store.Interface
+}
+
+func NewHandler() (handler.RouteRegister, error) {
+ return {
+ routeStore:
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1370: test: delete wait in test
codecov-io edited a comment on pull request #1370: URL: https://github.com/apache/apisix-dashboard/pull/1370#issuecomment-766559732 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=h1) Report > Merging [#1370](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=desc) (3efc174) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/7a157af60cc57fb49e5c1dcf2addca75c05857f1?el=desc) (7a157af) will **increase** coverage by `0.21%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1370 +/- ## == + Coverage 62.62% 62.83% +0.21% == Files 41 41 Lines2360 2360 == + Hits 1478 1483 +5 + Misses706 702 -4 + Partials 176 175 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `70.83% <0.00%> (-6.25%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.34% <0.00%> (+1.26%)` | :arrow_up: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `50.50% <0.00%> (+2.02%)` | :arrow_up: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `74.48% <0.00%> (+4.08%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=footer). Last update [7a157af...3efc174](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1370: test: delete wait in test
codecov-io commented on pull request #1370: URL: https://github.com/apache/apisix-dashboard/pull/1370#issuecomment-766559732 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=h1) Report > Merging [#1370](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=desc) (3efc174) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/7a157af60cc57fb49e5c1dcf2addca75c05857f1?el=desc) (7a157af) will **decrease** coverage by `18.26%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1370 +/- ## === - Coverage 62.62% 44.36% -18.27% === Files 41 32-9 Lines2360 1961 -399 === - Hits 1478 870 -608 - Misses706 980 +274 + Partials 176 111 -65 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-62.50%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (-27.66%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `28.28% <0.00%> (-23.24%)` | :arrow_down: | | ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1370/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=footer). Last update [7a157af...3efc174](https://codecov.io/gh/apache/apisix-dashboard/pull/1370?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hnlq715 commented on issue #3406: feat: support gRPC HTTP mapping annotation for grpc trancode plugin
hnlq715 commented on issue #3406: URL: https://github.com/apache/apisix/issues/3406#issuecomment-766559300 This is a standard protocol which has no relations to specific languages. The situation is indeed to build a grpc gateway, but we do not need to define any api bussiness related config in the gateway(apisix), but in the protobuf directly. And all we need to do is just to open/close the `grpc trancode` plugin switch. Just like what envoy did. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] rogerogers commented on issue #3407: request help: no cors header return sometimes
rogerogers commented on issue #3407: URL: https://github.com/apache/apisix/issues/3407#issuecomment-766554763 > I can't see the word in your images. > You need to provide reproducible steps in text. It's just a browser request list, sometime no cors header return, but not always. like this `HTTP/1.1 200 OK Server: openresty Date: Mon, 25 Jan 2021 05:32:58 GMT Content-Type: text/plain; charset=utf-8 Transfer-Encoding: chunked Connection: keep-alive` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766539166
@liuxiran @nic-chen
The unit test and test cases have been supplemented. In the process of
testing, I found a problem：
- At present, the path data structure of OpenAPI 3 is used to store URIs,
and the data structure is map [string]. If the URI is repeated, the data will
be covered, if the repeated URIs are directly covered, only one URI can be
exported, which will lead to the loss of user data.
- My idea is to add a uniform suffix after the same URI when exporting, so
that the import can recognize the URI
For example：
```
{
"components": {},
"info": {
"title": "RoutesExport",
"version": "3.0.0"
},
"openapi": "3.0.0",
"paths": {
"/hello": {
"get": {}
}
"/hello-repeaturi1": {
"get": {}
}
"/hello-repeaturi2": {
"get": {}
}
}
}
```
- My method also has the risk of repeating the user named URI
- Do you have any better suggestions? We can discuss them. Thks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766539166
@liuxiran @nic-chen
The unit test and test cases have been supplemented. In the process of
testing, I found a problem：
- At present, the path data structure of OpenAPI 3 is used to store URIs,
and the data structure is map [string]. If the URI is repeated, the data will
be covered, if the repeated URIs are directly covered, only one URI can be
exported, which will lead to the loss of user data.
- My idea is to add a uniform suffix after the same URI when exporting, so
that the import can recognize the URI
For example：
```
{
"components": {},
"info": {
"title": "RoutesExport",
"version": "3.0.0"
},
"openapi": "3.0.0",
"paths": {
"/hello": {
"get": {}
}
"/hello-repeaturi2": {
"get": {}
}
"/hello-repeaturi2": {
"get": {}
}
}
}
```
- My method also has the risk of repeating the user named URI
- Do you have any better suggestions? We can discuss them. Thks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3396: change: global rules should not be executed on the internal api
spacewander commented on a change in pull request #3396:
URL: https://github.com/apache/apisix/pull/3396#discussion_r563469427
##
File path: apisix/init.lua
##
@@ -324,6 +324,28 @@ function _M.http_access_phase()
core.ctx.set_vars_meta(api_ctx)
+local uri = api_ctx.var.uri
+if local_conf.apisix and local_conf.apisix.delete_uri_tail_slash then
+if str_byte(uri, #uri) == str_byte("/") then
+api_ctx.var.uri = str_sub(api_ctx.var.uri, 1, #uri - 1)
+core.log.info("remove the end of uri '/', current uri: ",
+ api_ctx.var.uri)
+end
+end
+
+if router.api.has_route_not_under_apisix() or
Review comment:
OK. We can wait for it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache
Firstsawyou commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-766545537
> @gewei2000 @Firstsawyou here is an example, please take a look at, I think
it will help you:
>
> ```shell
> curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
> {
> "uri": "/service_a/*",
> "vars": [["uri", "~~", "(.jpg|.html)$"]],
> "upstream": {
> "type": "roundrobin",
> "nodes": {
> "127.0.0.1:1980": 1
> }
> }
> }'
> ```
@membphis Ok, I get it , thanks！
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1333: chore: add stop subcommand
codecov-io edited a comment on pull request #1333: URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-763274597 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1333?src=pr=h1) Report > Merging [#1333](https://codecov.io/gh/apache/apisix-dashboard/pull/1333?src=pr=desc) (35cb72e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8852e630f0c2890d6607ab56925f3c0aaf6144d8?el=desc) (8852e63) will **decrease** coverage by `0.28%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1333?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1333 +/- ## == - Coverage 44.31% 44.02% -0.29% == Files 32 33 +1 Lines1961 1976 +15 == + Hits 869 870 +1 - Misses981 995 +14 Partials 111 111 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1333?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1333/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | `0.00% <0.00%> (ø)` | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1333/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `81.01% <0.00%> (+0.63%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1333?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1333?src=pr=footer). Last update [8852e63...35cb72e](https://codecov.io/gh/apache/apisix-dashboard/pull/1333?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #3405: fix: SSL resource supports PATCH with sub path
Firstsawyou commented on pull request #3405: URL: https://github.com/apache/apisix/pull/3405#issuecomment-766541417 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lianghao208 commented on pull request #204: fix: fix error check lint errors
lianghao208 commented on pull request #204: URL: https://github.com/apache/apisix-ingress-controller/pull/204#issuecomment-766539795 I think Makefile already includes "make lint" https://github.com/apache/apisix-ingress-controller/blob/master/Makefile#L49-L52 ```bash lint: golangci-lint run ``` @tokers PTAL, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
Jaycean commented on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766539166
@liuxiran @nic-chen
The unit test and test cases have been supplemented. In the process of
testing, I found a problem：
- At present, the path data structure of OpenAPI 3 is used to store URIs,
and the data structure is map [string]. If the URI is repeated, the data will
be covered, if the repeated URIs are directly covered, only one URI can be
exported, which will lead to the loss of user data.
- My idea is to add a uniform suffix after the same URI when exporting, so
that the import can recognize the URI
For example：
```
{
"components": {},
"info": {
"title": "RoutesExport",
"version": "3.0.0"
},
"openapi": "3.0.0",
"paths": {
"/hello": {
"get": {}
}
"/hello-repeaturi2": {
"get": {}
}
"/hello-repeaturi2": {
"get": {}
}
}
}
```
- Do you have any better suggestions? We can discuss them. Thks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3406: feat: support gRPC HTTP mapping annotation for grpc trancode plugin
tokers commented on issue #3406: URL: https://github.com/apache/apisix/issues/3406#issuecomment-766538472 Yes we could. But in which case we can use it? AFAIK the use case is for bulding a grpc gateway like what etcd did. Another problem, does it support Lua ecosystem? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1370: test: delete wait in test
guoqqqi opened a new pull request #1370: URL: https://github.com/apache/apisix-dashboard/pull/1370 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches ### New feature or improvement - Describe the details and related test reports. Delete all wait in test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3390: request help: does the proxy_cache plugin support static resource cache
membphis commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-766533551 > I don't think it's a bug, maybe we need to support it. I think we have supported this case, please take a look at comment: https://github.com/apache/apisix/issues/3390#issuecomment-766533343 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3390: request help: does the proxy_cache plugin support static resource cache
membphis commented on issue #3390:
URL: https://github.com/apache/apisix/issues/3390#issuecomment-766533343
@gewei2000 @Firstsawyou here is an example, please take a look at, I think
it will help you:
```shell
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
{
"uri": "/service_a/*",
"vars": [["uri", "~~", "(.jpg|.html)$"]],
"upstream": {
"type": "roundrobin",
"nodes": {
"127.0.0.1:1980": 1
}
}
}'
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1318: feat: add store mock
juzhiyuan commented on pull request #1318: URL: https://github.com/apache/apisix-dashboard/pull/1318#issuecomment-766528141 is this urgent? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1319: chore: introduce ginkgo framework for backend E2E testing
juzhiyuan commented on pull request #1319: URL: https://github.com/apache/apisix-dashboard/pull/1319#issuecomment-766528097 any update? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (23d010c -> 8852e63)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 23d010c chore: upgrade protobuf to v1.3.2 (#1367) add 8852e63 chore: upgrade gjson to v1.6.7 (#1366) No new revisions were added by this update. Summary of changes: api/go.mod | 2 +- api/go.sum | 8 2 files changed, 5 insertions(+), 5 deletions(-)
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1333: chore: add stop subcommand
juzhiyuan commented on pull request #1333: URL: https://github.com/apache/apisix-dashboard/pull/1333#issuecomment-766527954 ping @tokers This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1366: build: upgrade gjson to v1.6.7
juzhiyuan merged pull request #1366: URL: https://github.com/apache/apisix-dashboard/pull/1366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1353: There is a vulnerability in gjson v1.6.1,upgrade recommended
juzhiyuan closed issue #1353: URL: https://github.com/apache/apisix-dashboard/issues/1353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1367: build: upgrade protobuf to v1.3.2
juzhiyuan commented on pull request #1367: URL: https://github.com/apache/apisix-dashboard/pull/1367#issuecomment-766527791 Thanks, all! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1352: There is a vulnerability in protobuf v1.3.1,upgrade recommended
juzhiyuan closed issue #1352: URL: https://github.com/apache/apisix-dashboard/issues/1352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1367: build: upgrade protobuf to v1.3.2
juzhiyuan merged pull request #1367: URL: https://github.com/apache/apisix-dashboard/pull/1367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (7a157af -> 23d010c)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 7a157af test: remove unnecessary wait in E2E (#1362) add 23d010c chore: upgrade protobuf to v1.3.2 (#1367) No new revisions were added by this update. Summary of changes: api/go.mod | 2 +- api/go.sum | 28 +++- 2 files changed, 20 insertions(+), 10 deletions(-)
[apisix] branch master updated (95a04d2 -> 8904011)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 95a04d2 fix(grpc-transcode): ienum_as_name to enum_as_name (#3352) add 8904011 chore: git ignore openwhisk to smoothly check license locally (#3408) No new revisions were added by this update. Summary of changes: .gitignore | 1 + 1 file changed, 1 insertion(+)
[GitHub] [apisix] spacewander merged pull request #3408: chore: git ignore openwhisk to smoothly check license locally
spacewander merged pull request #3408: URL: https://github.com/apache/apisix/pull/3408 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3411: feat: support gRPCS
spacewander opened a new pull request #3411: URL: https://github.com/apache/apisix/pull/3411 Fix #3344. Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu opened a new pull request #3410: chore: fix kubernetes yaml not working
Yiyiyimu opened a new pull request #3410: URL: https://github.com/apache/apisix/pull/3410 Signed-off-by: yiyiyimu ### What this PR does / why we need it: #3044 imports a format error in kubernetes/service.yaml https://github.com/apache/apisix/blob/34bcac8bf7a188edbfa9262626c4ec5347e5c495/kubernetes/service.yaml#L25-L43 What this PR does: - fix the format error - update default `apiVersion` of deployment - fix more format with [YAML Language Support by Red Hat](https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml) ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3398: fix: upstream dns resolver failed response 503
spacewander commented on pull request #3398: URL: https://github.com/apache/apisix/pull/3398#issuecomment-766525759 @syzh You just need to update the expected status code in the tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #204: fix: fix error check lint errors
codecov-io edited a comment on pull request #204: URL: https://github.com/apache/apisix-ingress-controller/pull/204#issuecomment-766522955 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=h1) Report > Merging [#204](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=desc) (4b71e01) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f0ed89f96976f68a8fd490f8ba686ffed52af71d?el=desc) (f0ed89f) will **decrease** coverage by `0.02%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=tree) ```diff @@Coverage Diff @@ ## master #204 +/- ## == - Coverage 47.68% 47.66% -0.03% == Files 32 32 Lines1883 1884 +1 == Hits 898 898 - Misses846 847 +1 Partials 139 139 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/seven/state/service\_worker.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL3NlcnZpY2Vfd29ya2VyLmdv) | `0.00% <0.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=footer). Last update [f0ed89f...4b71e01](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3407: request help: no cors header return sometimes
spacewander commented on issue #3407: URL: https://github.com/apache/apisix/issues/3407#issuecomment-766525609 I can't see the word in your images. You need to provide reproducible steps in text. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #77: Update Homepage
juzhiyuan commented on issue #77: URL: https://github.com/apache/apisix-website/issues/77#issuecomment-766525567 **Translation** 1. The Logo changed to a white silhouette, preferably vector graphics. 2. Copywriting needs to be simplified. 3. Buttons need icons. 4. Requires mouse hover highlighting. BTW, we are working on migration[1], but we could still continue resolving this one. [1] https://github.com/apache/apisix-website/pull/153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] moonming commented on issue #155: add feature and users section in homepage
moonming commented on issue #155: URL: https://github.com/apache/apisix-website/issues/155#issuecomment-766525295 and `Events & News` section too This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] zhangxiaohui123456 opened a new issue #205: request help:
zhangxiaohui123456 opened a new issue #205: URL: https://github.com/apache/apisix-ingress-controller/issues/205 ### Issue description When mTLS be supported of apisix-ingress? ### Environment * apisix version (2.1): * OS: (cmd: `uname -a`) * OpenResty / Nginx version: (cmd: `nginx -V` or `openresty -V`) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] moonming opened a new issue #155: add feature and users section in homepage
moonming opened a new issue #155: URL: https://github.com/apache/apisix-website/issues/155 The current homepage is too simple, need to add some Apache APISIX features description. And Apache APISIX has many users such as https://github.com/apache/apisix/issues/487, if we can add all logos and links of users will be great. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
codecov-io edited a comment on pull request #1317: URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr=h1) Report > Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr=desc) (ab5b869) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `18.80%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1317 +/- ## === + Coverage 44.19% 63.00% +18.80% === Files 31 41 +10 Lines1948 2360 +412 === + Hits 861 1487 +626 + Misses975 697 -278 - Partials 112 176 +64 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | `60.86% <0.00%> (ø)` | | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `77.08% <0.00%> (ø)` | | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `73.80% <0.00%> (ø)` | | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `51.51% <0.00%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `83.87% <0.00%> (ø)` | | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (ø)` | | | [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | | | [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | `0.00% <0.00%> (ø)` | | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `67.85% <0.00%> (ø)` | | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `50.00% <0.00%> (ø)` | | | ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr=footer). Last update [754f559...7cc3666](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1367: build: upgrade protobuf to v1.3.2
codecov-io edited a comment on pull request #1367: URL: https://github.com/apache/apisix-dashboard/pull/1367#issuecomment-766333978 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=h1) Report > Merging [#1367](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=desc) (08da042) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/446773f8f14038c4cd391a3ec4340da32e416bb0?el=desc) (446773f) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1367 +/- ## === Coverage 62.62% 62.62% === Files 41 41 Lines2360 2360 === Hits 1478 1478 Misses706 706 Partials 176 176 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `46.46% <0.00%> (-2.03%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.34% <0.00%> (+1.26%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=footer). Last update [446773f...08da042](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0
membphis commented on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-766524618 @Jaycean please merge the master branch, FE e2e test cases have been fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] moonming opened a new issue #154: host website by Apache APISIX
moonming opened a new issue #154: URL: https://github.com/apache/apisix-website/issues/154 apisix.apache.org is hosted by apache server now, can we host by Apache APISIX? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #77: Update Homepage
juzhiyuan commented on issue #77: URL: https://github.com/apache/apisix-website/issues/77#issuecomment-766524207 sure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] moonming commented on issue #77: Update Homepage
moonming commented on issue #77: URL: https://github.com/apache/apisix-website/issues/77#issuecomment-766524057 ping @juzhiyuan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1362: test: delete unnecessary wait in E2E
juzhiyuan merged pull request #1362: URL: https://github.com/apache/apisix-dashboard/pull/1362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1194: test: Check for unnecessary wait in FE e2e
juzhiyuan closed issue #1194: URL: https://github.com/apache/apisix-dashboard/issues/1194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: test: remove unnecessary wait in E2E (#1362)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 7a157af test: remove unnecessary wait in E2E (#1362)
7a157af is described below
commit 7a157af60cc57fb49e5c1dcf2addca75c05857f1
Author: guoqqqi <72343596+guoq...@users.noreply.github.com>
AuthorDate: Mon Jan 25 11:59:11 2021 +0800
test: remove unnecessary wait in E2E (#1362)
---
.../integration/consumer/create_and_delete_consumer.spec.js | 7 ---
web/cypress/integration/metrics/metrics-smoketest.spec.js | 2 --
web/cypress/integration/route/create-edit-delete-route.spec.js| 3 ---
web/cypress/integration/settings/settings-smoketest.spec.js | 8 +++-
4 files changed, 3 insertions(+), 17 deletions(-)
diff --git
a/web/cypress/integration/consumer/create_and_delete_consumer.spec.js
b/web/cypress/integration/consumer/create_and_delete_consumer.spec.js
index f94c260..fd68dd0 100644
--- a/web/cypress/integration/consumer/create_and_delete_consumer.spec.js
+++ b/web/cypress/integration/consumer/create_and_delete_consumer.spec.js
@@ -18,7 +18,6 @@
context('Create and Delete Consumer', () => {
const name = `consumerName${new Date().valueOf()}`;
- const sleepTime = 100;
const domSelectors = {
notification: '.ant-notification-notice-message',
pluginsCard: '.ant-card',
@@ -33,14 +32,12 @@ context('Create and Delete Consumer', () => {
// go to consumer create page
cy.visit('/');
cy.contains('Consumer').click();
-cy.wait(sleepTime * 5);
cy.contains('Create').click();
// basic information
cy.get('#username').type(name);
cy.get('#desc').type('desc_by_autotest');
cy.contains('Next').click();
-cy.wait(sleepTime * 3);
// plugin config
cy.contains(domSelectors.pluginsCard, 'key-auth').within(() => {
@@ -61,14 +58,12 @@ context('Create and Delete Consumer', () => {
});
cy.contains('button', 'Next').click();
cy.contains('button', 'Submit').click();
-cy.wait(sleepTime);
cy.get(domSelectors.notification).should('contain', 'Create Consumer
Successfully');
});
it('delete the consumer', () => {
cy.visit('/');
cy.contains('Consumer').click();
-cy.wait(sleepTime * 5);
cy.contains(name).siblings().contains('Delete').click();
cy.contains('button', 'Confirm').click();
cy.get(domSelectors.notification).should('contain', 'Delete Consumer
Successfully');
@@ -78,14 +73,12 @@ context('Create and Delete Consumer', () => {
// go to consumer create page
cy.visit('/');
cy.contains('Consumer').click();
-cy.wait(sleepTime * 5);
cy.contains('Create').click();
// basic information
cy.get('#username').type(name);
cy.get('#desc').type('desc_by_autotest');
cy.contains('Next').click();
-cy.wait(sleepTime * 3);
// plugin config
cy.contains(domSelectors.pluginsCard, 'key-auth').within(() => {
diff --git a/web/cypress/integration/metrics/metrics-smoketest.spec.js
b/web/cypress/integration/metrics/metrics-smoketest.spec.js
index cd10c4a..c616cf4 100644
--- a/web/cypress/integration/metrics/metrics-smoketest.spec.js
+++ b/web/cypress/integration/metrics/metrics-smoketest.spec.js
@@ -22,7 +22,6 @@ context('metrics page smoke test', () => {
};
beforeEach(() => {
-// init login
cy.login();
});
@@ -30,7 +29,6 @@ context('metrics page smoke test', () => {
// go to metrics page
cy.visit('/');
cy.contains('Metrics').click();
-cy.wait(500);
cy.url().should('contains', '/metrics');
cy.get(domSelectors.pageContent)
.children()
diff --git a/web/cypress/integration/route/create-edit-delete-route.spec.js
b/web/cypress/integration/route/create-edit-delete-route.spec.js
index 510efc6..2350ef1 100644
--- a/web/cypress/integration/route/create-edit-delete-route.spec.js
+++ b/web/cypress/integration/route/create-edit-delete-route.spec.js
@@ -62,7 +62,6 @@ context('Create and Delete Route', () => {
// go to step2
cy.contains('Next').click();
-cy.wait(sleepTime * 3);
cy.get('#nodes_0_host').type('12.12.12.12');
// go to step3
@@ -98,13 +97,11 @@ context('Create and Delete Route', () => {
cy.get('[title=Name]').type(name);
cy.contains('Search').click();
-cy.wait(1000);
cy.contains(name).siblings().contains('Edit').click();
cy.get('#name').clear().type(newName);
cy.get('#desc').clear().type('new desc');
cy.contains('Next').click();
-cy.wait(1000);
cy.contains('Next').click();
cy.contains('Next').click();
cy.contains('Submit').click();
diff --git a/web/cypress/integration/settings/settings-smoketest.spec.js
b/web/cypress/integration/settings/settings-smoketest.spec.js
index 3b8448d..33ae217 100644
---
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #204: fix: fix error check lint errors
codecov-io commented on pull request #204: URL: https://github.com/apache/apisix-ingress-controller/pull/204#issuecomment-766522955 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=h1) Report > Merging [#204](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=desc) (b59ed06) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/f0ed89f96976f68a8fd490f8ba686ffed52af71d?el=desc) (f0ed89f) will **increase** coverage by `0.08%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=tree) ```diff @@Coverage Diff @@ ## master #204 +/- ## == + Coverage 47.68% 47.77% +0.08% == Files 32 32 Lines1883 1884 +1 == + Hits 898 900 +2 + Misses846 845 -1 Partials 139 139 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/seven/state/service\_worker.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL3NlcnZpY2Vfd29ya2VyLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `3.96% <0.00%> (+1.98%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=footer). Last update [f0ed89f...b59ed06](https://codecov.io/gh/apache/apisix-ingress-controller/pull/204?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1366: build: upgrade gjson to v1.6.7
codecov-io edited a comment on pull request #1366: URL: https://github.com/apache/apisix-dashboard/pull/1366#issuecomment-766331624 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=h1) Report > Merging [#1366](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=desc) (b08eab7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/446773f8f14038c4cd391a3ec4340da32e416bb0?el=desc) (446773f) will **increase** coverage by `0.21%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1366 +/- ## == + Coverage 62.62% 62.83% +0.21% == Files 41 41 Lines2360 2360 == + Hits 1478 1483 +5 + Misses706 703 -3 + Partials 176 174 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `49.49% <0.00%> (+1.01%)` | :arrow_up: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `88.60% <0.00%> (+2.53%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=footer). Last update [446773f...b08eab7](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhangxiaohui123456 opened a new issue #3409: request help:
zhangxiaohui123456 opened a new issue #3409: URL: https://github.com/apache/apisix/issues/3409 ### Issue description When mTLS be supported of apisix-ingress? ### Environment * apisix version (2.1): * OS: (cmd: `uname -a`) * OpenResty / Nginx version: (cmd: `nginx -V` or `openresty -V`) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lianghao208 opened a new pull request #204: fix: fix error check lint errors
lianghao208 opened a new pull request #204: URL: https://github.com/apache/apisix-ingress-controller/pull/204 Please answer these questions before submitting a pull request - Why submit this pull request? - [X] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues #202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1367: build: upgrade protobuf to v1.3.2
codecov-io edited a comment on pull request #1367: URL: https://github.com/apache/apisix-dashboard/pull/1367#issuecomment-766333978 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=h1) Report > Merging [#1367](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=desc) (08da042) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/446773f8f14038c4cd391a3ec4340da32e416bb0?el=desc) (446773f) will **decrease** coverage by `18.26%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1367 +/- ## === - Coverage 62.62% 44.36% -18.27% === Files 41 32-9 Lines2360 1961 -399 === - Hits 1478 870 -608 - Misses706 980 +274 + Partials 176 111 -65 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-62.50%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (-27.66%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `28.28% <0.00%> (-23.24%)` | :arrow_down: | | ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1367/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=footer). Last update [446773f...08da042](https://codecov.io/gh/apache/apisix-dashboard/pull/1367?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1366: build: upgrade gjson to v1.6.7
codecov-io edited a comment on pull request #1366: URL: https://github.com/apache/apisix-dashboard/pull/1366#issuecomment-766331624 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=h1) Report > Merging [#1366](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=desc) (b08eab7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/446773f8f14038c4cd391a3ec4340da32e416bb0?el=desc) (446773f) will **decrease** coverage by `18.26%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1366 +/- ## === - Coverage 62.62% 44.36% -18.27% === Files 41 32-9 Lines2360 1961 -399 === - Hits 1478 870 -608 - Misses706 980 +274 + Partials 176 111 -65 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-62.50%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (-27.66%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `28.28% <0.00%> (-23.24%)` | :arrow_down: | | ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1366/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=footer). Last update [446773f...b08eab7](https://codecov.io/gh/apache/apisix-dashboard/pull/1366?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1362: test: delete unnecessary wait in E2E
codecov-io edited a comment on pull request #1362: URL: https://github.com/apache/apisix-dashboard/pull/1362#issuecomment-765897507 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1362?src=pr=h1) Report > Merging [#1362](https://codecov.io/gh/apache/apisix-dashboard/pull/1362?src=pr=desc) (a799612) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/446773f8f14038c4cd391a3ec4340da32e416bb0?el=desc) (446773f) will **decrease** coverage by `0.29%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1362?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1362 +/- ## == - Coverage 62.62% 62.33% -0.30% == Files 41 41 Lines2360 2360 == - Hits 1478 1471 -7 - Misses706 715 +9 + Partials 176 174 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1362?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1362/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `70.83% <0.00%> (-6.25%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1362/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `44.44% <0.00%> (-4.05%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1362/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1362?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1362?src=pr=footer). Last update [446773f...a799612](https://codecov.io/gh/apache/apisix-dashboard/pull/1362?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
