[GitHub] [apisix] spacewander commented on a change in pull request #3685: docs: Added title to markdown under `docs`
spacewander commented on a change in pull request #3685: URL: https://github.com/apache/apisix/pull/3685#discussion_r583446692 ## File path: docs/zh/latest/benchmark.md ## @@ -1,3 +1,7 @@ +--- +title: 测试 Review comment: benchmark is not test. ## File path: docs/en/latest/plugins/response-rewrite.md ## @@ -1,3 +1,7 @@ +--- +title: response rewrite Review comment: Should be `response-rewrite`? Please update other similar places. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3677: bug: proxy-cache plugin has side-effect even if it's not configured in any route
spacewander commented on issue #3677: URL: https://github.com/apache/apisix/issues/3677#issuecomment-786474377 Will you submit a fix? I have already provided a solution in that issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3680: docs: plugin-develop.md add to view all plugin priorities
spacewander commented on a change in pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#discussion_r583442614
##
File path: docs/en/latest/plugin-develop.md
##
@@ -103,7 +103,7 @@ local _M = {
}
```
-Note : The priority of the new plugin cannot be the same as the priority of
any existing plugin. In addition, plugins with a high priority value will be
executed first in a given phase (see the definition of `phase` in
[choose-phase-to-run](#choose-phase-to-run)). For example, the priority of
example-plugin is 0 and the priority of ip-restriction is 3000. Therefore, the
ip-restriction plugin will be executed first, then the example-plugin plugin.
+Note : The priority of the new plugin cannot be the same as the priority of
any existing plugin, you can view the priority of all plugins in the
[t/debug/debug-mode.t](../../../t/debug/debug-mode.t) file. In addition,
plugins with a high priority value will be executed first in a given phase (see
the definition of `phase` in [choose-phase-to-run](#choose-phase-to-run)). For
example, the priority of example-plugin is 0 and the priority of ip-restriction
is 3000. Therefore, the ip-restriction plugin will be executed first, then the
example-plugin plugin.
Review comment:
No, it is the official way to check the priority since users may add
their own plugins and those plugins can't be reflected in our test file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] guoqqqi opened a new pull request #3685: docs: Added title to markdown under `docs`
guoqqqi opened a new pull request #3685: URL: https://github.com/apache/apisix/pull/3685 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** Added title to markdown under docs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yntor opened a new issue #3684: request help: v2.3 dns端口如何修改
yntor opened a new issue #3684: URL: https://github.com/apache/apisix/issues/3684 版本2.3 由于consul dns默认端口为8600.apisix默认端口53。需要修改apisix配置。查看配置 # dns_resolver: # If not set, read from `/etc/resolv.conf` # - 1.1.1.1 # - 8.8.8.8 可以通过上面配置，但是dns端口配置没有说明。请帮忙看下怎么配置这个dns端口。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3682: chore: add safe limit to avoid infinite loop caused by bug
spacewander commented on a change in pull request #3682:
URL: https://github.com/apache/apisix/pull/3682#discussion_r583429123
##
File path: apisix/balancer/roundrobin.lua
##
@@ -18,12 +18,19 @@
local roundrobin = require("resty.roundrobin")
local core = require("apisix.core")
local nkeys = core.table.nkeys
+local pairs = pairs
local _M = {}
function _M.new(up_nodes, upstream)
+local safe_limit = 0
+for _, weight in pairs(up_nodes) do
+-- the weight can be zero
+safe_limit = safe_limit + weight + 1
Review comment:
The number of possible retry won't be larger than `weight + 1`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-control-plane] jbampton opened a new pull request #40: chore: remove unneeded whitespace before commas
jbampton opened a new pull request #40: URL: https://github.com/apache/apisix-control-plane/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: rewrite e2e test(upstream_test) with ginkgo (#1502)
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 10f6044 feat: rewrite e2e test(upstream_test) with ginkgo (#1502)
10f6044 is described below
commit 10f60447bb99a08a8ba1aa11ef684472176f80a0
Author: JinChen <36916582+jayc...@users.noreply.github.com>
AuthorDate: Fri Feb 26 15:14:46 2021 +0800
feat: rewrite e2e test(upstream_test) with ginkgo (#1502)
---
api/test/e2e/upstream_test.go | 607 -
api/test/e2enew/upstream/upstream_suite_test.go | 36 ++
api/test/e2enew/upstream/upstream_test.go | 680
3 files changed, 716 insertions(+), 607 deletions(-)
diff --git a/api/test/e2e/upstream_test.go b/api/test/e2e/upstream_test.go
deleted file mode 100644
index be2dd6f..000
--- a/api/test/e2e/upstream_test.go
+++ /dev/null
@@ -1,607 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package e2e
-
-import (
- "io/ioutil"
- "net/http"
- "testing"
-
- "github.com/stretchr/testify/assert"
-)
-
-// todo: the code to access the route should be encapsulated as a function,
like line 245-263, 316-327
-func TestUpstream_Create(t *testing.T) {
- tests := []HttpTestCase{
- {
- Desc: "use upstream that not exist",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path: "/apisix/admin/routes/r1",
- Body: `{
- "uri": "/hello",
- "upstream_id": "not-exists"
- }`,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusBadRequest,
- },
- {
- Desc: "create upstream",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path: "/apisix/admin/upstreams/1",
- Body: `{
- "name": "upstream1",
- "nodes": [{
- "host": "172.16.238.20",
- "port": 1980,
- "weight": 1
- }],
- "type": "roundrobin"
- }`,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- },
- {
- Desc: "check upstream exists by name",
- Object: ManagerApiExpect(t),
- Method: http.MethodGet,
- Path: "/apisix/admin/notexist/upstreams",
- Query:"name=upstream1",
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusBadRequest,
- ExpectBody: "Upstream name is reduplicate",
- Sleep:sleepTime,
- },
- {
- Desc: "upstream name list",
- Object: ManagerApiExpect(t),
- Method: http.MethodGet,
- Path: "/apisix/admin/names/upstreams",
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- ExpectBody: `"name":"upstream1"`,
- Sleep:sleepTime,
- },
- {
- Desc: "check upstream exists by name (exclude
it self)",
- Object: ManagerApiExpect(t),
- Method: http.MethodGet,
- Path: "/apisix/admin/notexist/upstreams",
-
[GitHub] [apisix-dashboard] nic-chen merged pull request #1502: feat: rewrite e2e test(upstream_test) with ginkgo
nic-chen merged pull request #1502: URL: https://github.com/apache/apisix-dashboard/pull/1502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] jbampton opened a new pull request #141: chore: fix spelling
jbampton opened a new pull request #141: URL: https://github.com/apache/apisix-docker/pull/141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #272: chore: fix spelling
codecov-io commented on pull request #272: URL: https://github.com/apache/apisix-ingress-controller/pull/272#issuecomment-786455635 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr=h1) Report > Merging [#272](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr=desc) (23ff6ad) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/5a8189024fb90b52f96602501ec3e0eb71dc5fc0?el=desc) (5a81890) will **decrease** coverage by `0.02%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr=tree) ```diff @@Coverage Diff @@ ## master #272 +/- ## == - Coverage 53.85% 53.83% -0.03% == Files 33 32 -1 Lines2245 2244 -1 == - Hits 1209 1208 -1 Misses879 879 Partials 157 157 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272/diff?src=pr=tree#diff-cGtnL2FwaXNpeC91cHN0cmVhbS5nbw==) | `46.24% <0.00%> (ø)` | | | [pkg/seven/state/builder.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL2J1aWxkZXIuZ28=) | `0.00% <ø> (ø)` | | | [pkg/version/version.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272/diff?src=pr=tree#diff-cGtnL3ZlcnNpb24vdmVyc2lvbi5nbw==) | `100.00% <ø> (ø)` | | | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272/diff?src=pr=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `73.97% <100.00%> (ø)` | | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272/diff?src=pr=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr=footer). Last update [5a81890...23ff6ad](https://codecov.io/gh/apache/apisix-ingress-controller/pull/272?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] jbampton opened a new pull request #272: chore: fix spelling
jbampton opened a new pull request #272: URL: https://github.com/apache/apisix-ingress-controller/pull/272 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3494: docs: update the docs of the prometheus plugin
moonming commented on a change in pull request #3494: URL: https://github.com/apache/apisix/pull/3494#discussion_r583421624 ## File path: docs/zh/latest/plugins/prometheus.md ## @@ -118,12 +118,49 @@ plugin_attr: ### 可有的指标 -* `Status codes`: upstream 服务返回的 HTTP 状态码，每个服务返回状态码的次数或者所有服务的状态码次数总和都可以统计到。 -* `Bandwidth`: 流经apisix的总带宽(可分出口带宽和入口带宽). 每个服务指标或者是所有服务指标的总和都可以统计到。 +* `Status codes`: upstream 服务返回的 HTTP 状态码，每个服务返回状态码的次数或者所有服务的状态码次数总和都可以统计到。具有的维度： Review comment: the doc is ready hard to read. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3494: docs: update the docs of the prometheus plugin
moonming commented on a change in pull request #3494: URL: https://github.com/apache/apisix/pull/3494#discussion_r583421215 ## File path: docs/zh/latest/plugins/prometheus.md ## @@ -118,12 +118,49 @@ plugin_attr: ### 可有的指标 -* `Status codes`: upstream 服务返回的 HTTP 状态码，每个服务返回状态码的次数或者所有服务的状态码次数总和都可以统计到。 -* `Bandwidth`: 流经apisix的总带宽(可分出口带宽和入口带宽). 每个服务指标或者是所有服务指标的总和都可以统计到。 +* `Status codes`: upstream 服务返回的 HTTP 状态码，每个服务返回状态码的次数或者所有服务的状态码次数总和都可以统计到。具有的维度： Review comment: I think you need add a issue for improve grammar, the writing skill is not good This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3494: docs: update the docs of the prometheus plugin
moonming commented on a change in pull request #3494: URL: https://github.com/apache/apisix/pull/3494#discussion_r583421215 ## File path: docs/zh/latest/plugins/prometheus.md ## @@ -118,12 +118,49 @@ plugin_attr: ### 可有的指标 -* `Status codes`: upstream 服务返回的 HTTP 状态码，每个服务返回状态码的次数或者所有服务的状态码次数总和都可以统计到。 -* `Bandwidth`: 流经apisix的总带宽(可分出口带宽和入口带宽). 每个服务指标或者是所有服务指标的总和都可以统计到。 +* `Status codes`: upstream 服务返回的 HTTP 状态码，每个服务返回状态码的次数或者所有服务的状态码次数总和都可以统计到。具有的维度： Review comment: I think you need add a issue for improve grammar and grammar, the writing skill is not good This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3682: chore: add safe limit to avoid infinite loop caused by bug
Firstsawyou commented on a change in pull request #3682:
URL: https://github.com/apache/apisix/pull/3682#discussion_r583416007
##
File path: apisix/balancer/roundrobin.lua
##
@@ -18,12 +18,19 @@
local roundrobin = require("resty.roundrobin")
local core = require("apisix.core")
local nkeys = core.table.nkeys
+local pairs = pairs
local _M = {}
function _M.new(up_nodes, upstream)
+local safe_limit = 0
+for _, weight in pairs(up_nodes) do
+-- the weight can be zero
+safe_limit = safe_limit + weight + 1
Review comment:
I don't understand, why is `weight` needed here?
Is it better than `safe_limit = safe_limit + 1` ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3494: docs: update the docs of the prometheus plugin
membphis commented on pull request #3494: URL: https://github.com/apache/apisix/pull/3494#issuecomment-786446705 ping @moonming This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #3663: bug: script does not work
membphis closed issue #3663: URL: https://github.com/apache/apisix/issues/3663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis merged pull request #3678: fix: script does not work when the route is bound to a service.
membphis merged pull request #3678: URL: https://github.com/apache/apisix/pull/3678 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (0b0a1c5 -> a6fbcce)
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 0b0a1c5 docs: fix markdown links (#3622)
add a6fbcce fix: script does not work when the route is bound to a
service. (#3678)
No new revisions were added by this update.
Summary of changes:
apisix/plugin.lua | 4 +++
t/{node/service-empty.t => script/script.t} | 54 -
2 files changed, 33 insertions(+), 25 deletions(-)
copy t/{node/service-empty.t => script/script.t} (67%)
[GitHub] [apisix-website] jbampton opened a new pull request #210: chore: fix spelling
jbampton opened a new pull request #210: URL: https://github.com/apache/apisix-website/pull/210 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3683: request help: error_log has garbled
Firstsawyou commented on issue #3683: URL: https://github.com/apache/apisix/issues/3683#issuecomment-786438995 > there's another error, why error_log has garbled? This is related to your request data. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on issue #1411: test: delete button in plugin drawer
guoqqqi commented on issue #1411: URL: https://github.com/apache/apisix-dashboard/issues/1411#issuecomment-786436597 Hi @stu01509 Thank you very much and looking forward to your PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] LiteSun merged pull request #209: fix: deploy issue cause by sync-docs.js
LiteSun merged pull request #209: URL: https://github.com/apache/apisix-website/pull/209 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: fix: deploy issue cause by sync-docs.js (#209)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new d34baf3 fix: deploy issue cause by sync-docs.js (#209)
d34baf3 is described below
commit d34baf30a2d4c05bf47a60df63d0d6177e672e4d
Author: qier222
AuthorDate: Fri Feb 26 14:04:13 2021 +0800
fix: deploy issue cause by sync-docs.js (#209)
---
sync-docs.js | 2 +-
website/src/pages/team.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sync-docs.js b/sync-docs.js
index abbe52e..e4cef75 100644
--- a/sync-docs.js
+++ b/sync-docs.js
@@ -77,7 +77,7 @@ const copyDocs = (source, target, projectName, locale) => {
console.log(`[${projectName}] write sidebar.json`);
const sidebar = {
-docs: { ...(configLatest.sidebar || {}) },
+docs: [...(configLatest.sidebar || {})],
};
fs.writeFileSync(`${target}/sidebars.json`, JSON.stringify(sidebar, null,
2));
};
diff --git a/website/src/pages/team.js b/website/src/pages/team.js
index fa7c56a..15933e6 100644
--- a/website/src/pages/team.js
+++ b/website/src/pages/team.js
@@ -301,7 +301,7 @@ function Team(props) {
APISIX's community actively, PMC and Committers will make decisions
to invite the contributor join Committers and PMC.
-
+
Start Contribute
[GitHub] [apisix] thekingofworld commented on issue #3683: request help: error_log has garbled
thekingofworld commented on issue #3683: URL: https://github.com/apache/apisix/issues/3683#issuecomment-786426301 there's another error, why error_log has garbled? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] qier222 opened a new pull request #209: fix: deploy issue cause by sync-docs.js
qier222 opened a new pull request #209: URL: https://github.com/apache/apisix-website/pull/209 Fixes: #[Add issue number here] Changes: Screenshots of the change: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3683: request help: error_log has garbled
Firstsawyou commented on issue #3683: URL: https://github.com/apache/apisix/issues/3683#issuecomment-786423792 It is not affected by the warning log, and `using uninitialized` has been fixed, please see here: https://github.com/apache/apisix/pull/3641/files This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj opened a new issue #34: feat: need CI to check whether the helm chart script can run successfully
gxthrj opened a new issue #34: URL: https://github.com/apache/apisix-helm-chart/issues/34 Just like other projects, we need to ensure the correctness of the script, such as CI in [apache/apisix-docker](https://github.com/apache/apisix-docker/blob/master/.github/workflows/apisix-alpine-docker-test.yaml) CI in [apache/apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/blob/master/.github/workflows/e2e-test-ci.yml) Is anyone interested in adding this CI ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: update dubbo test dataset (#1516)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 703667f feat: update dubbo test dataset (#1516)
703667f is described below
commit 703667f988ff8cf72d42a6d2065ce722da40103a
Author: litesun
AuthorDate: Fri Feb 26 13:25:17 2021 +0800
feat: update dubbo test dataset (#1516)
---
web/cypress/fixtures/plugin-dataset.json | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/web/cypress/fixtures/plugin-dataset.json
b/web/cypress/fixtures/plugin-dataset.json
index 5730d82..b097ea8 100644
--- a/web/cypress/fixtures/plugin-dataset.json
+++ b/web/cypress/fixtures/plugin-dataset.json
@@ -1390,5 +1390,22 @@
}
}
],
- "mqtt-proxy": []
+ "mqtt-proxy": [],
+ "dubbo-proxy": [
+{
+ "shouldValid": true,
+ "data": {
+"service_name": "org.apache.dubbo.backend.DemoService",
+"service_version": "0.0.0",
+"method": "hello"
+ }
+},
+{
+ "shouldValid": false,
+ "data": {
+"service_name": "org.apache.dubbo.backend.DemoService",
+"method": "hello"
+ }
+}
+ ]
}
[GitHub] [apisix-dashboard] LiteSun merged pull request #1516: feat(FE): add dubbo test
LiteSun merged pull request #1516: URL: https://github.com/apache/apisix-dashboard/pull/1516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Baoyuantop opened a new issue #208: Cannot find Contributor Guide page in team page
Baoyuantop opened a new issue #208: URL: https://github.com/apache/apisix-website/issues/208 **Actual Behaviour** When I click this button on page `https://apisix.apache.org/team`, it's show `The requested URL was not found on this server.` https://user-images.githubusercontent.com/30611190/109258404-30aa5080-7835-11eb-8849-60754cc9ce6e.png;> **Expected Behaviour** Should jump to Contributor Guide page. **Steps to reproduce it** **Screenshots of the issue** **Would you like to work on the issue?** The link of the button should be modified to `https://apisix.apache.org/docs/general/contributor-guide`, If this is the case, I can modify it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj merged pull request #31: feat: add ingress controller helm chart
gxthrj merged pull request #31: URL: https://github.com/apache/apisix-helm-chart/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated: feat: add ingress controller helm chart (#31)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new a6e9ee2 feat: add ingress controller helm chart (#31) a6e9ee2 is described below commit a6e9ee2630835113738a20ef1a25b978f83565c1 Author: Jun AuthorDate: Fri Feb 26 13:22:36 2021 +0800 feat: add ingress controller helm chart (#31) --- README.md | 1 + charts/apisix-ingress-controller/.helmignore | 23 +++ .../apisix-ingress-controller/Chart.yaml | 21 +-- .../apisix-ingress-controller/README.md| 25 +++- .../crds/customresourcedefinitions.yaml| 70 + .../apisix-ingress-controller/templates/NOTES.txt | 5 + .../templates/_helpers.tpl | 80 ++ .../templates/configmap.yaml | 41 + .../templates/deployment.yaml | 91 .../apisix-ingress-controller/templates/hpa.yaml | 44 ++ .../apisix-ingress-controller/templates/rbac.yaml | 165 + .../templates/service-account.yaml | 15 +- .../templates/service.yaml | 24 +-- charts/apisix-ingress-controller/values.yaml | 72 + 14 files changed, 646 insertions(+), 31 deletions(-) diff --git a/README.md b/README.md index c6e5057..5a622c9 100644 --- a/README.md +++ b/README.md @@ -23,3 +23,4 @@ Apache APISIX Helm Charts provide the installation of [Apache APISIX](https://gi - [Apache APISIX Helm Chart](https://github.com/apache/apisix-helm-chart/tree/master/charts/apisix) - [Apache APISIX Dashboard Helm Chart](https://github.com/apache/apisix-helm-chart/tree/master/charts/apisix-dashboard) +- [Apache APISIX Ingress Controller Helm Chart](https://github.com/apache/apisix-helm-chart/tree/master/charts/apisix-ingress-controller) diff --git a/charts/apisix-ingress-controller/.helmignore b/charts/apisix-ingress-controller/.helmignore new file mode 100644 index 000..0e8a0eb --- /dev/null +++ b/charts/apisix-ingress-controller/.helmignore @@ -0,0 +1,23 @@ +# Patterns to ignore when building packages. +# This supports shell glob matching, relative path matching, and +# negation (prefixed with !). Only one pattern per line. +.DS_Store +# Common VCS dirs +.git/ +.gitignore +.bzr/ +.bzrignore +.hg/ +.hgignore +.svn/ +# Common backup files +*.swp +*.bak +*.tmp +*.orig +*~ +# Various IDEs +.project +.idea/ +*.tmproj +.vscode/ diff --git a/README.md b/charts/apisix-ingress-controller/Chart.yaml similarity index 65% copy from README.md copy to charts/apisix-ingress-controller/Chart.yaml index c6e5057..80fa853 100644 --- a/README.md +++ b/charts/apisix-ingress-controller/Chart.yaml @@ -1,4 +1,3 @@ - - -# Apache APISIX Helm Charts - -Apache APISIX Helm Charts provide the installation of [Apache APISIX](https://github.com/apache/apisix#apache-apisix) components for kubernetes. - -- [Apache APISIX Helm Chart](https://github.com/apache/apisix-helm-chart/tree/master/charts/apisix) -- [Apache APISIX Dashboard Helm Chart](https://github.com/apache/apisix-helm-chart/tree/master/charts/apisix-dashboard) +apiVersion: v2 +name: apisix-ingress-controller +description: Apache APISIX Ingress Controller for Kubernetes +icon: https://apache.org/logos/res/apisix/apisix.png +keywords: + - ingress + - apisix + - nginx + - crd +type: application +version: 0.1.0 +appVersion: 0.2.0 diff --git a/README.md b/charts/apisix-ingress-controller/README.md similarity index 59% copy from README.md copy to charts/apisix-ingress-controller/README.md index c6e5057..741e625 100644 --- a/README.md +++ b/charts/apisix-ingress-controller/README.md @@ -17,9 +17,26 @@ # --> -# Apache APISIX Helm Charts +# Apache APISIX Ingress Controller Helm Chart -Apache APISIX Helm Charts provide the installation of [Apache APISIX](https://github.com/apache/apisix#apache-apisix) components for kubernetes. +## Prerequisites -- [Apache APISIX Helm Chart](https://github.com/apache/apisix-helm-chart/tree/master/charts/apisix) -- [Apache APISIX Dashboard Helm Chart](https://github.com/apache/apisix-helm-chart/tree/master/charts/apisix-dashboard) +- Kubernetes 1.12+ +- [Apache APISIX](https://github.com/apache/apisix#configure-and-installation) +- [Helm v3.0+](https://helm.sh/docs/intro/quickstart/#install-helm) + +## Install + +To install the chart with release name `apisix-ingress-controller`: + +```bash +helm install apisix-ingress-controller --namespace ingress-apisix . +``` + +## Uninstall + +To uninstall/delete the `apisix-ingress-controller` release: + +```bash +helm uninstall apisix-ingress-controller --namespace ingress-apisix +``` diff --git a/charts/apisix-ingress-controller/crds/customresourcedefinitions.yaml
[GitHub] [apisix] nic-chen commented on issue #3674: When multiple plugins are configured in plugin_config, only one takes effect
nic-chen commented on issue #3674: URL: https://github.com/apache/apisix/issues/3674#issuecomment-786418744 > Here is how I check it: > > ``` > > ￥ curl http://127.0.0.1:9080/test/root.exe -i > > HTTP/1.1 403 Forbidden > > Date: Fri, 26 Feb 2021 02:09:18 GMT > > Content-Type: text/html; charset=utf-8 > > Content-Length: 150 > > Connection: keep-alive > > Server: APISIX/2.3 > > X-VERSION: 1.0 > > > > > > 403 Forbidden > > > > 403 Forbidden > > openresty > > > > > > ``` Thanks, I will check it again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] JanLi-air commented on issue #3677: bug: proxy-cache plugin has side-effect even if it's not configured in any route
JanLi-air commented on issue #3677: URL: https://github.com/apache/apisix/issues/3677#issuecomment-786417524 > Similar like #3373? Yes, seems the same This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #140: ci: refactor ci and compose
gxthrj commented on a change in pull request #140:
URL: https://github.com/apache/apisix-docker/pull/140#discussion_r583388704
##
File path: Makefile
##
@@ -16,23 +16,23 @@
#
default: help
-APISIX_VERSION ?= 2.3
+APISIX_VERSION ?= latest
Review comment:
The version should be 2.3
We discussed before and decided to modify this version number to trigger CI
after each APISIX release.
##
File path: .github/workflows/apisix-docker-test.yaml
##
@@ -10,17 +10,32 @@ on:
jobs:
build:
+strategy:
+ fail-fast: false
+ matrix:
+platform:
+ - alpine
+ - centos
+ - alpine-local
+
runs-on: ubuntu-latest
+env:
+ APISIX_PATH: "./apisix-local"
steps:
- uses: actions/checkout@v2
- - name: Build and run
+
+ - name: Clone apisix for local test
+if: ${{ matrix.platform == 'alpine-local' }}
run: |
git clone http://github.com/apache/apisix apisix-local
- export APISIX_PATH="./apisix-local"
- make build-on-alpine-local
- docker-compose -f ./alpine-local/docker-compose.yaml up -d
+
+ - name: Build and run
+run: |
+ make build-on-${{ matrix.platform }}
Review comment:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1519: chore: fix spelling
LiteSun merged pull request #1519: URL: https://github.com/apache/apisix-dashboard/pull/1519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: chore: fix spelling (#1519)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 26b583c chore: fix spelling (#1519)
26b583c is described below
commit 26b583c75c1fb55507b5d4da1d6b4b0fcd63fe1e
Author: John Bampton
AuthorDate: Fri Feb 26 15:13:46 2021 +1000
chore: fix spelling (#1519)
---
CHANGELOG.md | 6 +++---
.../handler/route_online_debug/route_online_debug.go | 2 +-
api/internal/handler/upstream/upstream_test.go | 2 +-
api/test/e2e/route_export_test.go| 4 ++--
api/test/shell/cli_test.sh | 6 +++---
web/cypress/integration/route/import_export_route.spec.js| 4 ++--
web/cypress/integration/route/online-debug.spec.js | 4 ++--
web/cypress/plugins/index.js | 2 +-
web/src/components/Upstream/UpstreamForm.tsx | 12 ++--
9 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a7bb9f6..6d4713d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -60,7 +60,7 @@ This release mainly improves basic features, bugfix and adds
test cases.
### Test Case
-- Use ginkgo framwork to do backend E2E testing.
[#1319](https://github.com/apache/apisix-dashboard/pull/1319)
+- Use ginkgo framework to do backend E2E testing.
[#1319](https://github.com/apache/apisix-dashboard/pull/1319)
- Add action to check the version for release.
[#1418](https://github.com/apache/apisix-dashboard/pull/1418)
- Add test for make build.
[#1421](https://github.com/apache/apisix-dashboard/pull/1421)
- Remove the etcd dependency in part of unit test.
[#1169](https://github.com/apache/apisix-dashboard/pull/1469)
@@ -71,7 +71,7 @@ This release mainly improves basic features, bugfix and adds
test cases.
### Doc
-- Doc: add document for introducing bakend e2e test.
[#1381](https://github.com/apache/apisix-dashboard/pull/1381)
+- Doc: add document for introducing backend e2e test.
[#1381](https://github.com/apache/apisix-dashboard/pull/1381)
# 2.3.0
@@ -107,7 +107,7 @@ This release mainly improve basic features, bugfix and adds
test cases.
- Support access log for Manager API.
[#994](https://github.com/apache/apisix-dashboard/pull/994)
- Enhance error log for Manager API.
[#977](https://github.com/apache/apisix-dashboard/pull/977)
-- Integrate with code-mirror to have a fallback to plugins's render issue.
[#898](https://github.com/apache/apisix-dashboard/pull/898)
+- Integrate with code-mirror to have a fallback to plugins render issue.
[#898](https://github.com/apache/apisix-dashboard/pull/898)
- Support priority field in Route module.
[#1006](https://github.com/apache/apisix-dashboard/pull/1006)
- Add etcd basic auth support
[#951](https://github.com/apache/apisix-dashboard/pull/951)
diff --git a/api/internal/handler/route_online_debug/route_online_debug.go
b/api/internal/handler/route_online_debug/route_online_debug.go
index 3f8da4a..a419757 100644
--- a/api/internal/handler/route_online_debug/route_online_debug.go
+++ b/api/internal/handler/route_online_debug/route_online_debug.go
@@ -83,7 +83,7 @@ func (h *Handler) DebugRequestForwarding(c droplet.Context)
(interface{}, error)
return ret, err
}
- return {StatusCode: http.StatusBadRequest},
fmt.Errorf("protocol unspported %s", protocol)
+ return {StatusCode: http.StatusBadRequest},
fmt.Errorf("protocol unsupported %s", protocol)
}
type HTTPProtocolSupport struct {
diff --git a/api/internal/handler/upstream/upstream_test.go
b/api/internal/handler/upstream/upstream_test.go
index 6ea8c7c..85ef525 100644
--- a/api/internal/handler/upstream/upstream_test.go
+++ b/api/internal/handler/upstream/upstream_test.go
@@ -1406,7 +1406,7 @@ func TestUpstream_Patch(t *testing.T) {
}
}
-func TestUptreams_Delete(t *testing.T) {
+func TestUpstreams_Delete(t *testing.T) {
tests := []struct {
caseDesc string
giveInput *BatchDelete
diff --git a/api/test/e2e/route_export_test.go
b/api/test/e2e/route_export_test.go
index 24cffa8..9088a7b 100644
--- a/api/test/e2e/route_export_test.go
+++ b/api/test/e2e/route_export_test.go
@@ -318,7 +318,7 @@ func TestRoute_Export(t *testing.T) {
ExpectBody:
"{\"components\":{},\"info\":{\"title\":\"RoutesExport\",\"version\":\"3.0.0\"},\"openapi\":\"3.0.0\",\"paths\":{"
+ exportStrR2 + "," + exportStrR1 + "}}",
},
{
- Desc: "use the exportall inerface to export all
routes",
+ Desc: "use the exportall interface to export
all routes",
Object: ManagerApiExpect(t),
[apisix] branch master updated (7594072 -> 0b0a1c5)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 7594072 chore: update makefile install to install everything in conf (#3660) add 0b0a1c5 docs: fix markdown links (#3622) No new revisions were added by this update. Summary of changes: docs/en/latest/plugin-develop.md | 2 +- docs/zh/latest/plugins/node-status.md | 2 +- docs/zh/latest/plugins/server-info.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
[GitHub] [apisix] spacewander merged pull request #3622: docs: fix markdown links
spacewander merged pull request #3622: URL: https://github.com/apache/apisix/pull/3622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1502: feat: rewrite e2e test(upstream_test) with ginkgo
Jaycean commented on pull request #1502: URL: https://github.com/apache/apisix-dashboard/pull/1502#issuecomment-786406707 cc @starsz @imjoey @juzhiyuan PTAL. Thks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1411: test: delete button in plugin drawer
nic-chen commented on issue #1411: URL: https://github.com/apache/apisix-dashboard/issues/1411#issuecomment-786405491 @stu01509 thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1493: Support More selectors on List page
nic-chen commented on issue #1493: URL: https://github.com/apache/apisix-dashboard/issues/1493#issuecomment-786405272 @stu01509 thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3680: docs: plugin-develop.md add to view all plugin priorities
Firstsawyou commented on a change in pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#discussion_r583375797
##
File path: docs/en/latest/plugin-develop.md
##
@@ -103,7 +103,7 @@ local _M = {
}
```
-Note : The priority of the new plugin cannot be the same as the priority of
any existing plugin. In addition, plugins with a high priority value will be
executed first in a given phase (see the definition of `phase` in
[choose-phase-to-run](#choose-phase-to-run)). For example, the priority of
example-plugin is 0 and the priority of ip-restriction is 3000. Therefore, the
ip-restriction plugin will be executed first, then the example-plugin plugin.
+Note : The priority of the new plugin cannot be the same as the priority of
any existing plugin, you can view the priority of all plugins in the
[t/debug/debug-mode.t](../../../t/debug/debug-mode.t) file. In addition,
plugins with a high priority value will be executed first in a given phase (see
the definition of `phase` in [choose-phase-to-run](#choose-phase-to-run)). For
example, the priority of example-plugin is 0 and the priority of ip-restriction
is 3000. Therefore, the ip-restriction plugin will be executed first, then the
example-plugin plugin.
Review comment:
I think that `Control API` has obtained the schema data of all plugins,
and the content information is too much, and it is not intuitive to check the
priority of all plugins.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] thekingofworld opened a new issue #3683: request help:
thekingofworld opened a new issue #3683: URL: https://github.com/apache/apisix/issues/3683 ### Issue description 1. error_log has garbled 2. using uninitialized "uuid" variable error ### Environment * apisix version (cmd: `apisix version`): 2.1 * OS (cmd: `uname -a`): linux * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): openresty/1.17.8.1   any body can take a look? thanks a lot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] GBXing commented on issue #3673: request help: A node in the K8S environment ETCD cluster died, causing Apisix to fail
GBXing commented on issue #3673: URL: https://github.com/apache/apisix/issues/3673#issuecomment-786399263 @Yiyiyimu I incorporated resty.etcd 1.4.4 into the code test. The native works with IP configuration, but the domain name configuration in the K8S environment still gets an error：etcd-1.etcd.apisix.svc.cluster.local could not be resolved (3: Host not found) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1466: feat(fe): support file transfer in online debug
codecov-io edited a comment on pull request #1466: URL: https://github.com/apache/apisix-dashboard/pull/1466#issuecomment-782707636 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=h1) Report > Merging [#1466](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=desc) (d3f6eba) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e51323fccf8b7bf5490f3e59319bb1c10ea03c5f?el=desc) (e51323f) will **decrease** coverage by `13.12%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1466 +/- ## === - Coverage 68.61% 55.49% -13.13% === Files 48 48 Lines3056 3056 === - Hits 2097 1696 -401 - Misses718 1077 +359 - Partials 241 283 +42 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `54.25% <0.00%> (-37.24%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `34.69% <0.00%> (-34.19%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `60.24% <0.00%> (-26.51%)` | :arrow_down: | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: | | ... and [16 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=footer). Last update [e51323f...d3f6eba](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1466: feat(fe): support file transfer in online debug
Jaycean commented on pull request #1466: URL: https://github.com/apache/apisix-dashboard/pull/1466#issuecomment-786398703 > https://github.com/apache/apisix-dashboard/pull/1466/checks?check_run_id=1984404224 > Backend e2e failed, need @Jaycean to confirm. OK, let me check the E2E test case This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1466: feat(fe): support file transfer in online debug
codecov-io edited a comment on pull request #1466: URL: https://github.com/apache/apisix-dashboard/pull/1466#issuecomment-782707636 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=h1) Report > Merging [#1466](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=desc) (d3f6eba) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e51323fccf8b7bf5490f3e59319bb1c10ea03c5f?el=desc) (e51323f) will **decrease** coverage by `38.35%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1466 +/- ## === - Coverage 68.61% 30.26% -38.36% === Files 48 48 Lines3056 3056 === - Hits 2097 925 -1172 - Misses718 1928 +1210 + Partials 241 203 -38 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `8.91% <0.00%> (-72.28%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `21.27% <0.00%> (-70.22%)` | :arrow_down: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `20.56% <0.00%> (-68.23%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `33.33% <0.00%> (-57.15%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `11.73% <0.00%> (-57.15%)` | :arrow_down: | | ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=footer). Last update [e51323f...d3f6eba](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] LiteSun merged pull request #207: feat: add Install Apache APISIX from Helm Charts blogs
LiteSun merged pull request #207: URL: https://github.com/apache/apisix-website/pull/207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: feat: add Install Apache APISIX from Helm Charts blogs (#207)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new a49702c feat: add Install Apache APISIX from Helm Charts blogs (#207)
a49702c is described below
commit a49702c3b1540ed6f8e649d80006d8da4b9f44c2
Author: litesun
AuthorDate: Fri Feb 26 11:54:53 2021 +0800
feat: add Install Apache APISIX from Helm Charts blogs (#207)
---
...02-26-install-apache-apisix-from-helm-charts.md | 58 ++
1 file changed, 58 insertions(+)
diff --git a/website/blog/2021-02-26-install-apache-apisix-from-helm-charts.md
b/website/blog/2021-02-26-install-apache-apisix-from-helm-charts.md
new file mode 100644
index 000..6f14fe1
--- /dev/null
+++ b/website/blog/2021-02-26-install-apache-apisix-from-helm-charts.md
@@ -0,0 +1,58 @@
+---
+title: "Install Apache APISIX from Helm Charts"
+author: Chao Zhang
+authorURL: "https://github.com/tokers;
+authorImageURL:
"https://avatars.githubusercontent.com/u/10428333?s=400=f48ef50c5621a1616a3ede50221547e34270e061=4;
+---
+
+> [@tokers](https://github.com/tokers), Apache APISIX Committer from [Shenzhen
Zhiliu Technology Co.](https://www.apiseven.com/)
+>
+> Source:
+>
+> - https://github.com/apache/apisix
+> - https://github.com/apache/apisix-helm-chart
+
+A few days ago, [Zhiliu Inc](https://www.apiseven.com/) released an online
Helm Charts repository. Users can easily install Apache APISIX, Apache
apisix-dashboard and Apache apisix-ingress-controller from it (rather than
cloning the corresponding project in advance).
+
+## How To Use
+
+Just a few steps to install Apache APISIX
+
+1. Add the repository and fetch the update
+
+ ```
+ $ helm repo add apisix https://charts.apiseven.com
+ $ helm repo update
+ ```
+
+2. Check out the available charts in repository
+
+ ```
+ $ helm search repo apisix
+
+ NAMECHART VERSION APP VERSION DESCRIPTION
+ apisix/apisix 0.1.2 2.1.0 A Helm chart for
Apache APISIX
+ apisix/apisix-dashboard 0.1.0 2.3.0 A Helm chart for
Apache APISIX Dashboard
+ ```
+
+3. Install Apache APISIX to your Kubernetes cluster
+
+ ```
+ $ helm install apisix-gw apisix/apisix --namespace default
+
+ NAME: apisix-gw
+ LAST DEPLOYED: Fri Feb 19 11:34:14 2021
+ NAMESPACE: default
+ STATUS: deployed
+ REVISION: 1
+ TEST SUITE: None
+ NOTES:
+ 1. Get the application URL by running these commands:
+ export NODE_PORT=$(kubectl get --namespace default -o
jsonpath="{.spec.ports[0].nodePort}" services apisix-gw-gateway)
+ export NODE_IP=$(kubectl get nodes --namespace default -o
jsonpath="{.items[0].status.addresses[0].address}")
+ echo http://$NODE_IP:$NODE_PORT
+ ```
+
+## See Also
+
+- https://github.com/apache/apisix-helm-chart
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #944: Improve the Bug Report issue template
juzhiyuan commented on issue #944: URL: https://github.com/apache/apisix-dashboard/issues/944#issuecomment-786391914 Ya, we should standardized all repos :) welcome to send PR for one repo first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #206: Fix the "Add your company" link
juzhiyuan merged pull request #206: URL: https://github.com/apache/apisix-website/pull/206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: Fix the "Add your company" link (#206)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 76ac071 Fix the "Add your company" link (#206)
76ac071 is described below
commit 76ac0717df1785969a6c3a684b9c4317507ee875
Author: tuhaihe <113232173...@gmail.com>
AuthorDate: Fri Feb 26 11:47:20 2021 +0800
Fix the "Add your company" link (#206)
---
website/src/pages/index.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/website/src/pages/index.js b/website/src/pages/index.js
index 7abab75..a78e506 100644
--- a/website/src/pages/index.js
+++ b/website/src/pages/index.js
@@ -142,7 +142,7 @@ const Showcase = () => {
Are you using this project?{" "}
https://github.com/apache/apisix/blob/master/doc/powered-by.md;
+
href="https://github.com/apache/apisix/blob/master/docs/en/latest/powered-by.md;
target="_blank"
rel="noopener"
>
[apisix-website] branch add-blog updated (5569f51 -> 29887c0)
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a change to branch add-blog in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 5569f51 feat: add Install Apache APISIX from Helm Charts blogs add 29887c0 feat: update No new revisions were added by this update. Summary of changes: .../2021-02-26-install-apache-apisix-from-helm-charts.md | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-)
[GitHub] [apisix] spacewander opened a new pull request #3682: chore: add safe limit to avoid infinite loop caused by bug
spacewander opened a new pull request #3682: URL: https://github.com/apache/apisix/pull/3682 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on issue #1411: test: delete button in plugin drawer
stu01509 commented on issue #1411: URL: https://github.com/apache/apisix-dashboard/issues/1411#issuecomment-786388728 Hi @guoqqqi I'm interested in this issue, Could you assign this issue to me? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on issue #944: Improve the Bug Report issue template
stu01509 commented on issue #944: URL: https://github.com/apache/apisix-dashboard/issues/944#issuecomment-786387661 Can I pick this issue? btw I think maybe we can standardize all of APISIX's repo issue templates? It may help the user easily to submit the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] LiteSun opened a new pull request #207: feat: add Install Apache APISIX from Helm Charts blogs
LiteSun opened a new pull request #207: URL: https://github.com/apache/apisix-website/pull/207 Changes: Add Install Apache APISIX from Helm Charts blogs Screenshots of the change:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #3678: fix: script does not work when the route is bound to a service.
tzssangglass commented on a change in pull request #3678:
URL: https://github.com/apache/apisix/pull/3678#discussion_r583358769
##
File path: t/admin/script.t
##
@@ -0,0 +1,103 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+log_level('info');
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: add service and service has plugin
Review comment:
update
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix-website] 01/01: feat: add Install Apache APISIX from Helm Charts blogs
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch add-blog
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
commit 5569f511a8baad6b4743787b7d2b436f9eba02af
Author: litesun <7sunm...@gmail.com>
AuthorDate: Fri Feb 26 11:24:07 2021 +0800
feat: add Install Apache APISIX from Helm Charts blogs
---
...02-26-install-apache-apisix-from-helm-charts.md | 66 ++
1 file changed, 66 insertions(+)
diff --git a/website/blog/2021-02-26-install-apache-apisix-from-helm-charts.md
b/website/blog/2021-02-26-install-apache-apisix-from-helm-charts.md
new file mode 100644
index 000..fa3e41f
--- /dev/null
+++ b/website/blog/2021-02-26-install-apache-apisix-from-helm-charts.md
@@ -0,0 +1,66 @@
+---
+title: "Install Apache APISIX from Helm Charts"
+author: Chao Zhang
+authorURL: "https://github.com/tokers;
+authorImageURL:
"https://avatars.githubusercontent.com/u/10428333?s=400=f48ef50c5621a1616a3ede50221547e34270e061=4;
+---
+
+> [@tokers](https://github.com/tokers), Apache APISIX Committer from [Shenzhen
Zhiliu Technology Co.](https://www.apiseven.com/)
+>
+> Source:
+>
+> - https://github.com/apache/apisix
+> - https://github.com/apache/apisix-helm-chart
+
+A few days ago, [Zhiliu Inc](https://www.apiseven.com/) released an online
Helm Charts repository. Users can easily install Apache APISIX, Apache
apisix-dashboard and Apache apisix-ingress-controller from it (rather than
cloning the corresponding project in advance).
+
+## How To Use
+
+Just a few steps to install Apache APISIX
+
+1. Add the repository and fetch the update
+
+ ```
+ $ helm repo add apisix https://charts.apiseven.com
+ $ helm repo update
+ ```
+
+2. Check out the available charts in repository
+
+ ```
+ $ helm search repo apisix
+
+ NAMECHART VERSION APP VERSION DESCRIPTION
+ apisix/apisix 0.1.2 2.1.0 A Helm chart for
Apache APISIX
+ apisix/apisix-dashboard 0.1.0 2.3.0 A Helm chart for
Apache APISIX Dashboard
+ ```
+
+3. Install Apache APISIX to your Kubernetes cluster
+
+ ```
+ $ helm install apisix-gw apisix/apisix --namespace default
+
+ NAME: apisix-gw
+ LAST DEPLOYED: Fri Feb 19 11:34:14 2021
+ NAMESPACE: default
+ STATUS: deployed
+ REVISION: 1
+ TEST SUITE: None
+ ```
+
+NOTES:
+
+1. Get the application URL by running these commands:
+
+ ```
+ export NODE_PORT=$(kubectl get --namespace default -o
jsonpath="{.spec.ports[0].nodePort}" services apisix-gw-gateway)
+
+ export NODE_IP=$(kubectl get nodes --namespace default -o
jsonpath="{.items[0].status.addresses[0].address}")
+
+ echo http://$NODE_IP:$NODE_PORT
+
+ ```
+
+## See Also
+
+- https://github.com/apache/apisix-helm-chart
[apisix-website] branch add-blog created (now 5569f51)
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a change to branch add-blog in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at 5569f51 feat: add Install Apache APISIX from Helm Charts blogs This branch includes the following new commits: new 5569f51 feat: add Install Apache APISIX from Helm Charts blogs The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [apisix] idbeta commented on pull request #3667: test: add fuzzing case for the route with vars
idbeta commented on pull request #3667: URL: https://github.com/apache/apisix/pull/3667#issuecomment-786383610 > It is the solved problem I said at the noon. > Please merge master to make CI pass. Thanks for remind. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] idbeta commented on a change in pull request #3667: test: add fuzzing case for the route with vars
idbeta commented on a change in pull request #3667:
URL: https://github.com/apache/apisix/pull/3667#discussion_r583355974
##
File path: t/fuzzing/vars_route_test.py
##
@@ -0,0 +1,95 @@
+#! /usr/bin/env python
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import subprocess
+from public import *
+from boofuzz import *
+
+def create_route():
+command = '''curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H
'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"uri": "/parameter*",
+"vars": [
+["arg_name","==","jack"],
+["http_token","==","140b543013d988f4767277b6f45ba542"]
+],
+"upstream": {
+"nodes": {
+"127.0.0.1:": 1
+},
+"type": "roundrobin"
+}
+}'
+'''
+subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
shell=True)
+
+def main():
+fw = open(cur_dir() + "/test.log",'wb')
+fuzz_loggers = [FuzzLoggerText(file_handle=fw)]
+session = Session(
+target=Target(
+connection=TCPSocketConnection("127.0.0.1", 9080,
send_timeout=5.0, recv_timeout=5.0, server=False)
+),
+fuzz_loggers=fuzz_loggers,
+keep_web_open=False,
+)
+
+s_initialize(name="Request")
+with s_block("Request-Line"):
+s_group("Method", ['GET', 'HEAD', 'POST', 'PUT', 'DELETE', 'CONNECT',
'OPTIONS', 'TRACE'])
+s_delim(" ", name='space-1')
+s_string("/parameter?name=jack", name='Request-URI')
+s_delim(" ", name='space-2')
+s_string('HTTP/1.1', name='HTTP-Version')
+s_static("\r\n", name="Request-Line-CRLF")
+s_string("Host:", name="Host-Line")
+s_delim(" ", name="space-3")
+s_string("example.com", name="Host-Line-Value")
+s_static("\r\n", name="Host-Line-CRLF")
+s_string("Connection:", name="Connection-Line")
+s_delim(" ", name="space-4")
+s_string("Keep-Alive", name="Connection-Line-Value")
+s_static("\r\n", name="Connection-Line-CRLF")
+s_string("User-Agent:", name="User-Agent-Line")
+s_delim(" ", name="space-5")
+s_string("Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.1
(KHTML, like Gecko) Chrome/21.0.1180.83 Safari/537.1",
name="User-Agent-Line-Value")
+s_static("\r\n", name="User-Agent-Line-CRLF")
+s_string("token:", name="age-Line")
+s_delim(" ", name="space-6")
+s_string("140b543013d988f4767277b6f45ba542", name="age-Line-Value")
+s_static("\r\n", name="age-Line-CRLF")
+
+s_static("\r\n", "Request-CRLF")
+session.connect(s_get("Request"))
+session.fuzz()
+
+if __name__ == "__main__":
+# before test
+create_route()
+r1 = check_process()
+main()
+# after test
+boofuzz_log = cur_dir() + "/test.log"
+apisix_errorlog = "~/work/apisix/apisix/logs/error.log"
Review comment:
yes, let me fixed it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on issue #1493: Support More selectors on List page
stu01509 commented on issue #1493: URL: https://github.com/apache/apisix-dashboard/issues/1493#issuecomment-786380713 Hi @juzhiyuan Can you assign this issue to me? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1466: feat(fe): support file transfer in online debug
liuxiran commented on pull request #1466: URL: https://github.com/apache/apisix-dashboard/pull/1466#issuecomment-786375252 https://github.com/apache/apisix-dashboard/pull/1466/checks?check_run_id=1984404224 Backend e2e failed, need @Jaycean to confirm. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on issue #1407: i18n: Need more language support
stu01509 commented on issue #1407: URL: https://github.com/apache/apisix-dashboard/issues/1407#issuecomment-786374949 Hi @juzhiyuan, @LiteSun Can I add the Traditional Chinese? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] stu01509 opened a new pull request #3681: docs: fix broken links
stu01509 opened a new pull request #3681: URL: https://github.com/apache/apisix/pull/3681 ### What this PR does / why we need it: Fix **CNCF API Gateway Landscape** and **etcd Clustering Guide** links. ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1466: feat(fe): support file transfer in online debug
liuxiran commented on a change in pull request #1466:
URL: https://github.com/apache/apisix-dashboard/pull/1466#discussion_r583343479
##
File path: web/cypress/integration/route/online-debug.spec.js
##
@@ -40,21 +41,39 @@ context('Online debug', () => {
invalidUrls: [
'000'
],
+postUrl:
`${defaultSettings.serveUrlMap[SERVE_ENV].split('//')[1]}/apisix/admin/import/routes`,
+uploadFile: '../../../api/test/testdata/import/default.json',
+headerAuthorizationKey: 'Authorization',
+token: localStorage.getItem('token'),
+routeName: 'hello',
};
+ const domSelector = {
+debugDraw: '[data-cy=debug-draw]',
+deubugMethod: '[data-cy=debug-method]',
+debugProtocol: '[data-cy=debug-protocol]',
+debugFormDataKey0: '#dynamic_form_data_item_params_0_key',
+debugFormDataType0: '[data-cy=debug-formdata-type-0]',
+debugFormDataValue0: '#dynamic_form_data_item_params_0_value',
+debugFormDataFileButton0: '[data-cy=debug-upload-btn-0]',
+codeMirrorCOde: '.CodeMirror-code',
Review comment:
thanks, fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1466: feat(fe): support file transfer in online debug
LiteSun commented on a change in pull request #1466:
URL: https://github.com/apache/apisix-dashboard/pull/1466#discussion_r583337131
##
File path: web/cypress/integration/route/online-debug.spec.js
##
@@ -40,21 +41,39 @@ context('Online debug', () => {
invalidUrls: [
'000'
],
+postUrl:
`${defaultSettings.serveUrlMap[SERVE_ENV].split('//')[1]}/apisix/admin/import/routes`,
+uploadFile: '../../../api/test/testdata/import/default.json',
+headerAuthorizationKey: 'Authorization',
+token: localStorage.getItem('token'),
+routeName: 'hello',
};
+ const domSelector = {
+debugDraw: '[data-cy=debug-draw]',
+deubugMethod: '[data-cy=debug-method]',
+debugProtocol: '[data-cy=debug-protocol]',
+debugFormDataKey0: '#dynamic_form_data_item_params_0_key',
+debugFormDataType0: '[data-cy=debug-formdata-type-0]',
+debugFormDataValue0: '#dynamic_form_data_item_params_0_value',
+debugFormDataFileButton0: '[data-cy=debug-upload-btn-0]',
+codeMirrorCOde: '.CodeMirror-code',
Review comment:
```suggestion
codeMirrorCode: '.CodeMirror-code',
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] jbampton opened a new pull request #1519: chore: fix spelling
jbampton opened a new pull request #1519: URL: https://github.com/apache/apisix-dashboard/pull/1519 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Please add the corresponding test cases if necessary. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3678: fix: script does not work when the route is bound to a service.
tokers commented on a change in pull request #3678:
URL: https://github.com/apache/apisix/pull/3678#discussion_r583337740
##
File path: t/admin/script.t
##
@@ -0,0 +1,103 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+log_level('info');
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: add service and service has plugin
Review comment:
I misunderstood it when I first saw it... Maybe `add service which has
plugins` is better.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3674: When multiple plugins are configured in plugin_config, only one takes effect
spacewander commented on issue #3674: URL: https://github.com/apache/apisix/issues/3674#issuecomment-786361830 Here is how I check it: ``` ￥ curl http://127.0.0.1:9080/test/root.exe -i HTTP/1.1 403 Forbidden Date: Fri, 26 Feb 2021 02:09:18 GMT Content-Type: text/html; charset=utf-8 Content-Length: 150 Connection: keep-alive Server: APISIX/2.3 X-VERSION: 1.0 403 Forbidden 403 Forbidden openresty ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #271: docs: remove extra docs category
tokers merged pull request #271: URL: https://github.com/apache/apisix-ingress-controller/pull/271 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: docs: remove extra docs category (#271)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 5a81890 docs: remove extra docs category (#271)
5a81890 is described below
commit 5a8189024fb90b52f96602501ec3e0eb71dc5fc0
Author: 琚致远
AuthorDate: Fri Feb 26 10:11:37 2021 +0800
docs: remove extra docs category (#271)
---
docs/en/latest/config.json | 97 +++---
1 file changed, 49 insertions(+), 48 deletions(-)
diff --git a/docs/en/latest/config.json b/docs/en/latest/config.json
index 7e14180..bd47adf 100644
--- a/docs/en/latest/config.json
+++ b/docs/en/latest/config.json
@@ -1,51 +1,52 @@
{
"version": "0.3.0",
- "sidebar": {
-"docs": [
- {
-"type": "category",
-"label": "Getting Started",
-"items": ["design", "CRD-specification"]
- },
- {
-"type": "category",
-"label": "Samples",
-"items": [
- "samples/index",
- "samples/proxy-the-httpbin-service-with-ingress",
- "samples/proxy-the-httpbin-service"
-]
- },
- {
-"type": "category",
-"label": "Deployment",
-"items": [
- "deployments/ack",
- "deployments/aws",
- "deployments/azure",
- "deployments/gke",
- "deployments/k3s-rke",
- "deployments/kubesphere",
- "deployments/minikube",
- "deployments/tke"
-]
- },
- {
-"type": "doc",
-"id": "usage"
- },
- {
-"type": "doc",
-"id": "development"
- },
- {
-"type": "doc",
-"id": "contribute"
- },
- {
-"type": "doc",
-"id": "FAQ"
- }
-]
- }
+ "sidebar": [
+{
+ "type": "category",
+ "label": "Getting Started",
+ "items": [
+"design",
+"CRD-specification"
+ ]
+},
+{
+ "type": "category",
+ "label": "Samples",
+ "items": [
+"samples/index",
+"samples/proxy-the-httpbin-service-with-ingress",
+"samples/proxy-the-httpbin-service"
+ ]
+},
+{
+ "type": "category",
+ "label": "Deployment",
+ "items": [
+"deployments/ack",
+"deployments/aws",
+"deployments/azure",
+"deployments/gke",
+"deployments/k3s-rke",
+"deployments/kubesphere",
+"deployments/minikube",
+"deployments/tke"
+ ]
+},
+{
+ "type": "doc",
+ "id": "usage"
+},
+{
+ "type": "doc",
+ "id": "development"
+},
+{
+ "type": "doc",
+ "id": "contribute"
+},
+{
+ "type": "doc",
+ "id": "FAQ"
+}
+ ]
}
[GitHub] [apisix] spacewander commented on issue #3674: When multiple plugins are configured in plugin_config, only one takes effect
spacewander commented on issue #3674:
URL: https://github.com/apache/apisix/issues/3674#issuecomment-786360687
I try it at my side and can't reproduce it. My etcd data:
```
$ etcdctl get /apisix/routes --prefix
/apisix/routes/
init_dir
/apisix/routes/1
{"update_time":1614305330,"plugin_config_id":1,"create_time":1614235098,"priority":0,"uri":"\/test\/*","id":"1","upstream":{"pass_host":"pass","nodes":{"127.0.0.1:23790":1},"scheme":"http","hash_on":"vars","type":"roundrobin"},"status":1}
$ etcdctl get /apisix/plugin_config --prefix
/apisix/plugin_configs/
init_dir
/apisix/plugin_configs/1
{"id":"1","create_time":1614250686,"update_time":1614250856,"plugins":{"response-rewrite":{"headers":{"X-VERSION":"1.0"}},"uri-blocker":{"block_rules":["root.exe","root.m+"]}}}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers merged pull request #3660: chore: update makefile install to install everything in conf
tokers merged pull request #3660: URL: https://github.com/apache/apisix/pull/3660 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers closed issue #3657: bug: luarocks not pack `conf/debug.yaml` in
tokers closed issue #3657: URL: https://github.com/apache/apisix/issues/3657 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: chore: update makefile install to install everything in conf (#3660)
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 7594072 chore: update makefile install to install everything in conf (#3660) 7594072 is described below commit 7594072839f6c2b4fa1d0cb7f1486360e095b34b Author: Shuyang Wu AuthorDate: Fri Feb 26 10:05:41 2021 +0800 chore: update makefile install to install everything in conf (#3660) fix #3657 --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index dd4c91e..ffe3b3f 100644 --- a/Makefile +++ b/Makefile @@ -146,6 +146,7 @@ install: default $(INSTALL) conf/mime.types /usr/local/apisix/conf/mime.types $(INSTALL) conf/config.yaml /usr/local/apisix/conf/config.yaml $(INSTALL) conf/config-default.yaml /usr/local/apisix/conf/config-default.yaml + $(INSTALL) conf/debug.yaml /usr/local/apisix/conf/debug.yaml $(INSTALL) conf/cert/* /usr/local/apisix/conf/cert/ $(INSTALL) -d $(INST_LUADIR)/apisix
[GitHub] [apisix] tzssangglass commented on a change in pull request #3678: fix: script does not work when the route is bound to a service.
tzssangglass commented on a change in pull request #3678: URL: https://github.com/apache/apisix/pull/3678#discussion_r583322262 ## File path: t/admin/script.t ## @@ -0,0 +1,103 @@ +# Review comment: got This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3678: fix: script does not work when the route is bound to a service.
spacewander commented on a change in pull request #3678: URL: https://github.com/apache/apisix/pull/3678#discussion_r583315460 ## File path: t/admin/script.t ## @@ -0,0 +1,103 @@ +# Review comment: Can we add this under `t/script` instead? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3678: fix: script does not work when the route is bound to a service.
spacewander commented on a change in pull request #3678:
URL: https://github.com/apache/apisix/pull/3678#discussion_r583315052
##
File path: t/admin/script.t
##
@@ -0,0 +1,103 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+log_level('info');
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: add service and service has plugin
Review comment:
The title is correct, the service has plugin.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3675: ci: run chaos test on HEAD of PR
spacewander commented on pull request #3675: URL: https://github.com/apache/apisix/pull/3675#issuecomment-786338057 The chao test is down. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3677: bug: proxy-cache plugin has side-effect even if it's not configured in any route
spacewander commented on issue #3677: URL: https://github.com/apache/apisix/issues/3677#issuecomment-786337658 Similar like https://github.com/apache/apisix/issues/3373? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3672: chore: capitalize the constant
tokers commented on a change in pull request #3672: URL: https://github.com/apache/apisix/pull/3672#discussion_r583309777 ## File path: apisix/upstream.lua ## @@ -191,7 +191,7 @@ function _M.set_by_route(route, api_ctx) local new_nodes, err = dis.nodes(up_conf.service_name) if not new_nodes then -return http_code_upstream_unavailable, "no valid upstream node: " .. (err or "nil") +return HTTP_CODE_UPSTREAM_UNAVAILABLE, "no valid upstream node: " .. (err or "nil") Review comment: OK. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3678: fix: script does not work when the route is bound to a service.
tokers commented on a change in pull request #3678:
URL: https://github.com/apache/apisix/pull/3678#discussion_r583309437
##
File path: t/admin/script.t
##
@@ -0,0 +1,103 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+log_level('info');
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: add service and service has plugin
Review comment:
Title should be changed since you just add exactly one service.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3680: docs: plugin-develop.md add to view all plugin priorities
spacewander commented on a change in pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#discussion_r583309384
##
File path: docs/en/latest/plugin-develop.md
##
@@ -103,7 +103,7 @@ local _M = {
}
```
-Note : The priority of the new plugin cannot be the same as the priority of
any existing plugin. In addition, plugins with a high priority value will be
executed first in a given phase (see the definition of `phase` in
[choose-phase-to-run](#choose-phase-to-run)). For example, the priority of
example-plugin is 0 and the priority of ip-restriction is 3000. Therefore, the
ip-restriction plugin will be executed first, then the example-plugin plugin.
+Note : The priority of the new plugin cannot be the same as the priority of
any existing plugin, you can view the priority of all plugins in the
[t/debug/debug-mode.t](../../../t/debug/debug-mode.t) file. In addition,
plugins with a high priority value will be executed first in a given phase (see
the definition of `phase` in [choose-phase-to-run](#choose-phase-to-run)). For
example, the priority of example-plugin is 0 and the priority of ip-restriction
is 3000. Therefore, the ip-restriction plugin will be executed first, then the
example-plugin plugin.
Review comment:
I think it would be better to use control API:
https://github.com/apache/apisix/blob/master/docs/en/latest/control-api.md#get-v1schema
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1466: feat(fe): support file transfer in online debug
juzhiyuan commented on pull request #1466: URL: https://github.com/apache/apisix-dashboard/pull/1466#issuecomment-786285689 OK This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1466: feat(fe): support file transfer in online debug
liuxiran commented on pull request #1466: URL: https://github.com/apache/apisix-dashboard/pull/1466#issuecomment-786285273 everything is ready now, please take a look when you are free, thanks @juzhiyuan @LiteSun @bzp2010 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #3678: bugfix: fix script does not work when the route is bound to a service.
Firstsawyou commented on pull request #3678: URL: https://github.com/apache/apisix/pull/3678#issuecomment-786046907 Your PR title needs to look like this: `fix: script does not work when the route is bound to a service` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou opened a new pull request #3680: docs: plugin-develop.md add to view all plugin priorities
Firstsawyou opened a new pull request #3680: URL: https://github.com/apache/apisix/pull/3680 ### What this PR does / why we need it: Related issues: https://github.com/apache/apisix/issues/3652 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #3676: chore: update lua-resty-etcd to v1.4.4
tzssangglass commented on a change in pull request #3676:
URL: https://github.com/apache/apisix/pull/3676#discussion_r582981749
##
File path: rockspec/apisix-master-0.rockspec
##
@@ -34,7 +34,7 @@ dependencies = {
"lua-resty-ctxdump = 0.1-0",
"lua-resty-dns-client = 5.2.0",
"lua-resty-template = 1.9",
-"lua-resty-etcd = 1.4.3",
+"lua-resty-etcd = 1.4.4",
Review comment:
I can add health checks of etcd to apisix
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #3676: chore: update lua-resty-etcd to v1.4.4
tzssangglass commented on a change in pull request #3676:
URL: https://github.com/apache/apisix/pull/3676#discussion_r582981749
##
File path: rockspec/apisix-master-0.rockspec
##
@@ -34,7 +34,7 @@ dependencies = {
"lua-resty-ctxdump = 0.1-0",
"lua-resty-dns-client = 5.2.0",
"lua-resty-template = 1.9",
-"lua-resty-etcd = 1.4.3",
+"lua-resty-etcd = 1.4.4",
Review comment:
I can add health checks to apisix
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1518: feat: rewrite e2e test(upstream_chash_hash_on_test) with ginkgo
Jaycean opened a new pull request #1518: URL: https://github.com/apache/apisix-dashboard/pull/1518 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues #1500 ___ ### New feature or improvement - Rewrite e2e test(upstream_chash_hash_on_test) with ginkgo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #3678: bugfix: fix script does not work when the route is bound to a service.
tzssangglass commented on pull request #3678: URL: https://github.com/apache/apisix/pull/3678#issuecomment-786024555 @spacewander @membphis CI is ok, but I don't koow why PR title is solecistic This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1517: ci: auto generate and check rpm package
codecov-io edited a comment on pull request #1517: URL: https://github.com/apache/apisix-dashboard/pull/1517#issuecomment-786005951 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=h1) Report > Merging [#1517](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=desc) (f0de9e5) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/63f9059a3c7d2390e51e8f7b607afd4a1d052ce8?el=desc) (63f9059) will **decrease** coverage by `16.07%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1517 +/- ## === - Coverage 68.98% 52.91% -16.08% === Files 48 48 Lines3047 3056+9 === - Hits 2102 1617 -485 - Misses706 1169 +463 - Partials 239 270 +31 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `5.88% <0.00%> (-67.93%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `54.25% <0.00%> (-37.24%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `34.69% <0.00%> (-34.19%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `57.22% <0.00%> (-30.73%)` | :arrow_down: | | ... and [17 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=footer). Last update [63f9059...f0de9e5](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1517: ci: auto generate and check rpm package
codecov-io commented on pull request #1517: URL: https://github.com/apache/apisix-dashboard/pull/1517#issuecomment-786005951 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=h1) Report > Merging [#1517](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=desc) (c2bd4bd) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/63f9059a3c7d2390e51e8f7b607afd4a1d052ce8?el=desc) (63f9059) will **decrease** coverage by `6.94%`. > The diff coverage is `74.07%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1517 +/- ## == - Coverage 68.98% 62.04% -6.95% == Files 48 48 Lines3047 3056 +9 == - Hits 2102 1896 -206 - Misses706 907 +201 - Partials 239 253 +14 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=tree) | Coverage Δ | | |---|---|---| | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `74.50% <74.07%> (+0.70%)` | :arrow_up: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `56.25% <0.00%> (-43.75%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `25.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `50.00% <0.00%> (-24.49%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `30.00% <0.00%> (-20.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `48.27% <0.00%> (-10.35%)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1517/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=footer). Last update [63f9059...f0de9e5](https://codecov.io/gh/apache/apisix-dashboard/pull/1517?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz opened a new pull request #1517: ci: auto generate and check rpm package
starsz opened a new pull request #1517: URL: https://github.com/apache/apisix-dashboard/pull/1517 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### New feature or improvement - Describe the details and related test reports. We can support generate and check rpm package. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] juzhiyuan opened a new pull request #271: docs: remove extra docs category
juzhiyuan opened a new pull request #271: URL: https://github.com/apache/apisix-ingress-controller/pull/271  Remove extra docs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
