[GitHub] [apisix] nic-chen commented on issue #3239: feat: enhance plugin category

[GitBox]

nic-chen commented on issue #3239:
URL: https://github.com/apache/apisix/issues/3239#issuecomment-787017961


   > We already have defined the plugin category: 
https://github.com/apache/apisix/blob/master/docs/en/latest/README.md#plugins
   
   oh, yes, thanks!
   I will submit a PR to close this issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #3239: feat: enhance plugin category

[GitBox]

spacewander commented on issue #3239:
URL: https://github.com/apache/apisix/issues/3239#issuecomment-787007905


   We already have defined the plugin category: 
https://github.com/apache/apisix/blob/master/docs/en/latest/README.md#plugins



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass commented on issue #3692: [discuss]: enable etcd health check

[GitBox]

tzssangglass commented on issue #3692:
URL: https://github.com/apache/apisix/issues/3692#issuecomment-787000601


   > I think we need to resolve it in the APISIX side as lua-resty-etcd knows 
nothing about the resolver.
   
   agree, etcd `host` is meant to be each node of etcd, not a cluster, and 
using a k8s domain is equivalent to configuring a unique etcd cluster address, 
which does not match the meaning of `host`, so perhaps we can add an attribute 
to support etcd cluster address configuration



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] jbampton opened a new pull request #3693: feat: add Spanish translation of the FAQ

[GitBox]

jbampton opened a new pull request #3693:
URL: https://github.com/apache/apisix/pull/3693


   ### What this PR does / why we need it:
   
   Translates the FAQ to Spanish.
   
   refs #3587 
   
   ### Pre-submission checklist:
   
   * [X] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] iamayushdas commented on issue #274: docs: update the architecture diagram

[GitBox]

iamayushdas commented on issue #274:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/274#issuecomment-786997042


   Can you please be elaborative? What exactly to do.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3680: docs: plugin-develop.md add to view all plugin priorities

[GitBox]

Firstsawyou commented on a change in pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#discussion_r584031142



##
File path: docs/en/latest/plugin-develop.md
##
@@ -103,7 +103,7 @@ local _M = {
 }
 ```
 
-Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin. In addition, plugins with a high priority value will be 
executed first in a given phase (see the definition of `phase` in 
[choose-phase-to-run](#choose-phase-to-run)). For example, the priority of 
example-plugin is 0 and the priority of ip-restriction is 3000. Therefore, the 
ip-restriction plugin will be executed first, then the example-plugin plugin.
+Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin, you can use the `/v1/schema` method of [control 
API](./control-api.md) to view the priority of all plugins. In addition, 
plugins with a high priority value will be executed first in a given phase (see 
the definition of `phase` in [choose-phase-to-run](#choose-phase-to-run)). For 
example, the priority of example-plugin is 0 and the priority of ip-restriction 
is 3000. Therefore, the ip-restriction plugin will be executed first, then the 
example-plugin plugin.

Review comment:
   updated.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] membphis commented on issue #274: docs: update the architecture diagram

[GitBox]

membphis commented on issue #274:
URL: 
https://github.com/apache/apisix-ingress-controller/issues/274#issuecomment-786996203


   @gxthrj if you need the source file, please let me know. I can provide it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Bhanuji95 edited a comment on issue #3690: Support for AzureAD/OIDC integration with APISIX

[GitBox]

Bhanuji95 edited a comment on issue #3690:
URL: https://github.com/apache/apisix/issues/3690#issuecomment-786995866


   Hello @spacewander,
   
   There is no difference between AzureAD and OIDC, also azuread uses oidc 
authentication mechanism. Let me try the oidc provided by apisix. Thanks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Bhanuji95 commented on issue #3690: Support for AzureAD/OIDC integration with APISIX

[GitBox]

Bhanuji95 commented on issue #3690:
URL: https://github.com/apache/apisix/issues/3690#issuecomment-786995866


   Hello @spacewander,
   
   There is no difference between AzureAD and OIDC, also azuread uses oidc 
authentication mechanism. Let me try the oidc provided by apisix



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] membphis opened a new issue #274: docs: update the architecture diagram

[GitBox]

membphis opened a new issue #274:
URL: https://github.com/apache/apisix-ingress-controller/issues/274


   
   
![image](https://user-images.githubusercontent.com/6814606/109374178-521b4300-78ee-11eb-8315-4da896383f53.png)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3686: feat: support SRV record

[GitBox]

spacewander commented on a change in pull request #3686:
URL: https://github.com/apache/apisix/pull/3686#discussion_r584029441



##
File path: apisix/core/dns/client.lua
##
@@ -29,6 +31,67 @@ local _M = {
 }
 
 
+local function gcd(a, b)
+if b == 0 then
+return a
+end
+
+return gcd(b, a % b)
+end
+
+
+local function resolve_srv(client, answers)
+if #answers == 0 then
+return nil, "empty SRV record"
+end
+
+local resolved_answers = {}
+local answer_to_count = {}
+for _, answer in ipairs(answers) do
+if answer.type ~= client.TYPE_SRV then
+return nil, "mess SRV with other record"
+end
+
+local resolved, err = client.resolve(answer.target)
+if not resolved then
+local msg = "failed to resolve SRV record " .. answer.target .. ": 
" .. err
+return nil, msg
+end
+
+log.info("dns resolve SRV ", answer.target, ", result: ",
+ json.delay_encode(resolved))
+
+local weight = answer.weight
+if weight == 0 then
+weight = 1
+end
+
+local count = #resolved
+answer_to_count[answer] = count
+-- one target may have multiple resolved results
+for _, res in ipairs(resolved) do
+local copy = table.deepcopy(res)
+copy.weight = weight / count
+copy.port = answer.port
+insert_tab(resolved_answers, copy)
+end
+end
+
+-- find the least common multiple of the counts
+local lcm = answer_to_count[answers[1]]
+for i = 1, #answers do

Review comment:
   Solved





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3686: feat: support SRV record

[GitBox]

spacewander commented on a change in pull request #3686:
URL: https://github.com/apache/apisix/pull/3686#discussion_r584029064



##
File path: apisix/core/dns/client.lua
##
@@ -29,6 +31,67 @@ local _M = {
 }
 
 
+local function gcd(a, b)
+if b == 0 then
+return a
+end
+
+return gcd(b, a % b)
+end
+
+
+local function resolve_srv(client, answers)
+if #answers == 0 then
+return nil, "empty SRV record"
+end
+
+local resolved_answers = {}
+local answer_to_count = {}
+for _, answer in ipairs(answers) do
+if answer.type ~= client.TYPE_SRV then
+return nil, "mess SRV with other record"
+end
+
+local resolved, err = client.resolve(answer.target)
+if not resolved then
+local msg = "failed to resolve SRV record " .. answer.target .. ": 
" .. err
+return nil, msg
+end
+
+log.info("dns resolve SRV ", answer.target, ", result: ",
+ json.delay_encode(resolved))
+
+local weight = answer.weight

Review comment:
   Added: 
https://github.com/apache/apisix/pull/3686/files#diff-eeebb3321eff56ec1f7b883a6a08b29bbc6359cdd06407eca329772b9a619676R122





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #3239: feat: enhance plugin category

[GitBox]

spacewander commented on issue #3239:
URL: https://github.com/apache/apisix/issues/3239#issuecomment-786994311


   I think we should define the category first.
   What is the difference between `rewrite` and `traffic`?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #3692: [discuss]: enable etcd health check

[GitBox]

spacewander commented on issue #3692:
URL: https://github.com/apache/apisix/issues/3692#issuecomment-786993951


   I think we need to resolve it in the APISIX side as lua-resty-etcd knows 
nothing about the resolver.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #3690: Support for AzureAD/OIDC integration with APISIX

[GitBox]

spacewander commented on issue #3690:
URL: https://github.com/apache/apisix/issues/3690#issuecomment-786993841


   What is the difference between the AzureAD/OIDC and the OIDC we currently 
support? Is there official documentation for AzureAD/OIDC?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #3687: chore: no need to package documentation

[GitBox]

spacewander merged pull request #3687:
URL: https://github.com/apache/apisix/pull/3687


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated: chore: no need to package documentation (#3687)

[spacewander]

This is an automated email from the ASF dual-hosted git repository.

spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 343d484  chore: no need to package documentation (#3687)
343d484 is described below

commit 343d4841efc6dbfc6f3a7f487976664005d11cf8
Author: 罗泽轩 
AuthorDate: Sat Feb 27 11:07:23 2021 +0800

chore: no need to package documentation (#3687)

Signed-off-by: spacewander 
---
 Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Makefile b/Makefile
index ffe3b3f..bfd0c36 100644
--- a/Makefile
+++ b/Makefile
@@ -245,7 +245,6 @@ compress-tar:
./apisix \
./bin \
./conf \
-   ./doc \
./rockspec \
LICENSE \
Makefile \

[GitHub] [apisix] Firstsawyou commented on pull request #3680: docs: plugin-develop.md add to view all plugin priorities

[GitBox]

Firstsawyou commented on pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#issuecomment-786991855


   > how about add an official plugin priority list？
   
   I think adding a new API interface through `control API`, such as 
`/v1/plugins/priority`, the API only returns the priority value of all plugins, 
and they are in order.
   Have discussed with @spacewander  in the above review.  I will add an issue 
to discuss it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3680: docs: plugin-develop.md add to view all plugin priorities

[GitBox]

Firstsawyou commented on a change in pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#discussion_r584025990



##
File path: docs/en/latest/plugin-develop.md
##
@@ -103,7 +103,7 @@ local _M = {
 }
 ```
 
-Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin. In addition, plugins with a high priority value will be 
executed first in a given phase (see the definition of `phase` in 
[choose-phase-to-run](#choose-phase-to-run)). For example, the priority of 
example-plugin is 0 and the priority of ip-restriction is 3000. Therefore, the 
ip-restriction plugin will be executed first, then the example-plugin plugin.
+Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin, you can use the `/v1/schema` method of [control 
API](./control-api.md) to view the priority of all plugins. In addition, 
plugins with a high priority value will be executed first in a given phase (see 
the definition of `phase` in [choose-phase-to-run](#choose-phase-to-run)). For 
example, the priority of example-plugin is 0 and the priority of ip-restriction 
is 3000. Therefore, the ip-restriction plugin will be executed first, then the 
example-plugin plugin.

Review comment:
   > would better use a more clear & direct way, what do you think 
@spacewander @Firstsawyou?
   
   agree.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] Jaycean commented on issue #1521: bug: BE E2E test case is unstable

[GitBox]

Jaycean commented on issue #1521:
URL: 
https://github.com/apache/apisix-dashboard/issues/1521#issuecomment-786991179


   > @moonming @membphis
   > 
   > Regarding this issue, I have added sleep to the `RunTestCase` function to 
avoid omissions.
   > 
   > However, for test cases written by hand without calling RunTestCase, they 
can't avoid the issue yet. I will find a way to avoid the issue under this 
circumstances.
   > 
   > @Jaycean Thanks for the explanation.
   
   Yes, there is also my problem. I left it out when I wrote it by hand.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] nic-chen commented on issue #3239: feat: enhance plugin category

[GitBox]

nic-chen commented on issue #3239:
URL: https://github.com/apache/apisix/issues/3239#issuecomment-786990820


   @spacewander  @membphis @juzhiyuan @LiteSun 

   I tried to classify them, what do you think?
   
   **auth**
   basic-auth
   hmac-auth
   jwt-auth
   key-auth
   
   -- They are not related to consumers, but they also belong to the 
authentication category. How should we classify them?
   authz-keycloak
   openid-connect
   
   
   **log**
   error-log-logger
   http-logger
   kafka-logger
   log-rotate
   sls-logger
   syslog
   tcp-logger
   udp-logger
   wolf-rbac
   
   
   **metric**
   prometheus
   
   
   **proxy**
   dubbo-proxy
   grpc-transcode
   proxy-cache
   proxy-mirror
   
   
   **restriction**
   consumer-rejection
   cors
   fault-injection
   ip-restriction
   referer-restriction
   uri-blocker
   
   
   **rewrite**
   proxy-rewrite
   redirect
   response-rewrite
   
   
   **trace**
   skywalking
   zipkin
   
   
   **traffic**
   api-breaker
   limit-conn
   limit-count
   limit-req
   traffic-split
   
   
   **validation**
   request-validation
   
   
   **other**
   batch-requests
   node-status
   request-id
   server-info
   serverless-post-function
   serverless-pre-function
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #1521: bug: BE E2E test case is unstable

[GitBox]

nic-chen commented on issue #1521:
URL: 
https://github.com/apache/apisix-dashboard/issues/1521#issuecomment-786989923


   @moonming @membphis 
   
   Regarding this issue, I have added sleep to the `RunTestCase` function to 
avoid omissions.
   
   However, for test cases written by hand without calling RunTestCase, they 
can't avoid the issue yet. I will find a way to avoid  the issue under this 
circumstances. 
   
   @Jaycean  Thanks for the explanation.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on pull request #213: fix: #212

[GitBox]

juzhiyuan commented on pull request #213:
URL: https://github.com/apache/apisix-website/pull/213#issuecomment-786988145


   Agree, and how about other codes?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] qier222 commented on pull request #213: fix: #212

[GitBox]

qier222 commented on pull request #213:
URL: https://github.com/apache/apisix-website/pull/213#issuecomment-786980214


   I think "Apache" and "APISIX™️" should stay in one line, the fonts size can 
shrink down a little bit.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers commented on a change in pull request #3577: feat: support conditional response rewrite

[GitBox]

tokers commented on a change in pull request #3577:
URL: https://github.com/apache/apisix/pull/3577#discussion_r584015215



##
File path: doc/plugins/response-rewrite.md
##
@@ -45,6 +45,7 @@ response rewrite plugin, rewrite the content returned by the 
upstream as well as
 | body| string  | optional| || New `body` to 
client, and the content-length will be reset too.   

|
 | body_base64 | boolean | optional| false   || Identify if 
`body` in configuration need base64 decoded before rewrite to client.   

  |
 | headers | object  | optional| || Set the new 
`headers` for client, can set up multiple. If it exists already from upstream, 
will rewrite the header, otherwise will add the header. You can set the 
corresponding value to an empty string to remove a header. |
+| vars | array[]  | optional| || A DSL to evaluate 
with the given ngx.var. See `vars` 
[lua-resty-expr](https://github.com/api7/lua-resty-expr#operator-list). |

Review comment:
   Should mention here that "if `vars` is absent, rewrite operations will 
be executed unconditionally".





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers commented on issue #3692: [discuss]: enable etcd health check

[GitBox]

tokers commented on issue #3692:
URL: https://github.com/apache/apisix/issues/3692#issuecomment-786979362


   Yes, it just uses the FQDN since the underlying cosocket suite supports to 
resolve it according to the `resolver` directive in nginx.conf.
   
   We may, resolving the FQDN (and cache it) by ourselves in the level of 
lua-resty-etcd.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers commented on issue #3690: Support for AzureAD/OIDC integration with APISIX

[GitBox]

tokers commented on issue #3690:
URL: https://github.com/apache/apisix/issues/3690#issuecomment-786978746


   @Bhanuji95 Currently we don't implement it. Would you please to submit a PR 
to achieve this? Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers commented on a change in pull request #3680: docs: plugin-develop.md add to view all plugin priorities

[GitBox]

tokers commented on a change in pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#discussion_r584013961



##
File path: docs/en/latest/plugin-develop.md
##
@@ -103,7 +103,7 @@ local _M = {
 }
 ```
 
-Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin. In addition, plugins with a high priority value will be 
executed first in a given phase (see the definition of `phase` in 
[choose-phase-to-run](#choose-phase-to-run)). For example, the priority of 
example-plugin is 0 and the priority of ip-restriction is 3000. Therefore, the 
ip-restriction plugin will be executed first, then the example-plugin plugin.
+Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin, you can use the `/v1/schema` method of [control 
API](./control-api.md) to view the priority of all plugins. In addition, 
plugins with a high priority value will be executed first in a given phase (see 
the definition of `phase` in [choose-phase-to-run](#choose-phase-to-run)). For 
example, the priority of example-plugin is 0 and the priority of ip-restriction 
is 3000. Therefore, the ip-restriction plugin will be executed first, then the 
example-plugin plugin.

Review comment:
   Some typos.
   
   > The priority of the new plugin cannot be the same as the priority of any 
existing plugin
   
   Change to "The priority of the new plugin cannot be same to any existing 
ones".
   
   > plugins with a high priority
   
   Change to "plugins with higher priority".





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers commented on a change in pull request #3686: feat: support SRV record

[GitBox]

tokers commented on a change in pull request #3686:
URL: https://github.com/apache/apisix/pull/3686#discussion_r584012410



##
File path: apisix/core/dns/client.lua
##
@@ -29,6 +31,67 @@ local _M = {
 }
 
 
+local function gcd(a, b)
+if b == 0 then
+return a
+end
+
+return gcd(b, a % b)
+end
+
+
+local function resolve_srv(client, answers)
+if #answers == 0 then
+return nil, "empty SRV record"
+end
+
+local resolved_answers = {}
+local answer_to_count = {}
+for _, answer in ipairs(answers) do
+if answer.type ~= client.TYPE_SRV then
+return nil, "mess SRV with other record"
+end
+
+local resolved, err = client.resolve(answer.target)
+if not resolved then
+local msg = "failed to resolve SRV record " .. answer.target .. ": 
" .. err
+return nil, msg
+end
+
+log.info("dns resolve SRV ", answer.target, ", result: ",
+ json.delay_encode(resolved))
+
+local weight = answer.weight
+if weight == 0 then
+weight = 1
+end
+
+local count = #resolved
+answer_to_count[answer] = count
+-- one target may have multiple resolved results
+for _, res in ipairs(resolved) do
+local copy = table.deepcopy(res)
+copy.weight = weight / count
+copy.port = answer.port
+insert_tab(resolved_answers, copy)
+end
+end
+
+-- find the least common multiple of the counts
+local lcm = answer_to_count[answers[1]]
+for i = 1, #answers do

Review comment:
   We can iterate from `i = 2`.

##
File path: apisix/core/dns/client.lua
##
@@ -29,6 +31,67 @@ local _M = {
 }
 
 
+local function gcd(a, b)
+if b == 0 then
+return a
+end
+
+return gcd(b, a % b)
+end
+
+
+local function resolve_srv(client, answers)
+if #answers == 0 then
+return nil, "empty SRV record"
+end
+
+local resolved_answers = {}
+local answer_to_count = {}
+for _, answer in ipairs(answers) do
+if answer.type ~= client.TYPE_SRV then
+return nil, "mess SRV with other record"
+end
+
+local resolved, err = client.resolve(answer.target)
+if not resolved then
+local msg = "failed to resolve SRV record " .. answer.target .. ": 
" .. err
+return nil, msg
+end
+
+log.info("dns resolve SRV ", answer.target, ", result: ",
+ json.delay_encode(resolved))
+
+local weight = answer.weight

Review comment:
   I think the explantation to treat zero weight record to `1` 
https://github.com/apache/apisix/blob/3af2175629f727d0374b7f77dbdc3a510cf44d81/docs/en/latest/dns.md#srv-record,
 can also add here.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1522: fix(be): fix ci failed

[GitBox]

codecov-io edited a comment on pull request #1522:
URL: https://github.com/apache/apisix-dashboard/pull/1522#issuecomment-786972518


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=h1) 
Report
   > Merging 
[#1522](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=desc) 
(e413cde) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/10f60447bb99a08a8ba1aa11ef684472176f80a0?el=desc)
 (10f6044) will **increase** coverage by `0.35%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1522  +/-   ##
   ==
   + Coverage   68.55%   68.91%   +0.35% 
   ==
 Files  48   48  
 Lines3056 3056  
   ==
   + Hits 2095 2106  +11 
   + Misses722  710  -12 
   - Partials  239  240   +1 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `86.74% <0.00%> (-1.21%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `33.33% <0.00%> (ø)` | |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `74.48% <0.00%> (+4.08%)` | :arrow_up: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `50.00% <0.00%> (+8.18%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=footer).
 Last update 
[10f6044...e413cde](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1522: fix(be): fix ci failed

[GitBox]

codecov-io edited a comment on pull request #1522:
URL: https://github.com/apache/apisix-dashboard/pull/1522#issuecomment-786972518


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=h1) 
Report
   > Merging 
[#1522](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=desc) 
(e413cde) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/10f60447bb99a08a8ba1aa11ef684472176f80a0?el=desc)
 (10f6044) will **decrease** coverage by `6.28%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1522  +/-   ##
   ==
   - Coverage   68.55%   62.27%   -6.29% 
   ==
 Files  48   48  
 Lines3056 3056  
   ==
   - Hits 2095 1903 -192 
   - Misses722  904 +182 
   - Partials  239  249  +10 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `31.93% <0.00%> (-23.53%)` | :arrow_down: |
   | 
[api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=)
 | `30.00% <0.00%> (-20.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `54.08% <0.00%> (-16.33%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `76.47% <0.00%> (-8.83%)` | :arrow_down: |
   | 
[api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=)
 | `71.12% <0.00%> (-7.12%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `62.56% <0.00%> (-6.71%)` | :arrow_down: |
   | ... and [6 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=footer).
 Last update 
[10f6044...e413cde](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1522: fix(be): fix ci failed

[GitBox]

codecov-io commented on pull request #1522:
URL: https://github.com/apache/apisix-dashboard/pull/1522#issuecomment-786972518


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=h1) 
Report
   > Merging 
[#1522](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=desc) 
(e413cde) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/10f60447bb99a08a8ba1aa11ef684472176f80a0?el=desc)
 (10f6044) will **decrease** coverage by `16.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1522   +/-   ##
   ===
   - Coverage   68.55%   51.69%   -16.87% 
   ===
 Files  48   39-9 
 Lines3056 2600  -456 
   ===
   - Hits 2095 1344  -751 
   - Misses722 1082  +360 
   + Partials  239  174   -65 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-70.41%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=)
 | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [29 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1522/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=footer).
 Last update 
[10f6044...e413cde](https://codecov.io/gh/apache/apisix-dashboard/pull/1522?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] Jaycean commented on issue #1521: bug: BE E2E test case is unstable

[GitBox]

Jaycean commented on issue #1521:
URL: 
https://github.com/apache/apisix-dashboard/issues/1521#issuecomment-786972414


   @nic-chen @starsz @membphis 
   I think it's because the E2E test case didn't add sleep for data sync. Do 
you have any suggestions?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1522: fix(be): fix ci failedx

[GitBox]

Jaycean opened a new pull request #1522:
URL: https://github.com/apache/apisix-dashboard/pull/1522


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   #1521
   ___
   ### Bugfix
   - Description
   debug_ online_ route_ The test case of test E2E is unstable, which is easy 
to cause irregular CI failure.
   
   - How to fix?
   sleep for data sync
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] moonming commented on issue #1521: bug: BE E2E test case is unstable

[GitBox]

moonming commented on issue #1521:
URL: 
https://github.com/apache/apisix-dashboard/issues/1521#issuecomment-786958458


   @nic-chen @membphis How to solve this problem completely?  Appeared many 
times



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on pull request #3680: docs: plugin-develop.md add to view all plugin priorities

[GitBox]

moonming commented on pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#issuecomment-786957822


   how about add an official plugin priority list？



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on a change in pull request #3680: docs: plugin-develop.md add to view all plugin priorities

[GitBox]

juzhiyuan commented on a change in pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#discussion_r583977713



##
File path: docs/en/latest/plugin-develop.md
##
@@ -103,7 +103,7 @@ local _M = {
 }
 ```
 
-Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin. In addition, plugins with a high priority value will be 
executed first in a given phase (see the definition of `phase` in 
[choose-phase-to-run](#choose-phase-to-run)). For example, the priority of 
example-plugin is 0 and the priority of ip-restriction is 3000. Therefore, the 
ip-restriction plugin will be executed first, then the example-plugin plugin.
+Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin, you can use the `/v1/schema` method of [control 
API](./control-api.md) to view the priority of all plugins. In addition, 
plugins with a high priority value will be executed first in a given phase (see 
the definition of `phase` in [choose-phase-to-run](#choose-phase-to-run)). For 
example, the priority of example-plugin is 0 and the priority of ip-restriction 
is 3000. Therefore, the ip-restriction plugin will be executed first, then the 
example-plugin plugin.

Review comment:
   would better use a more clear & direct way, what do you think 
@spacewander @Firstsawyou?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on a change in pull request #3680: docs: plugin-develop.md add to view all plugin priorities

[GitBox]

juzhiyuan commented on a change in pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#discussion_r583977713



##
File path: docs/en/latest/plugin-develop.md
##
@@ -103,7 +103,7 @@ local _M = {
 }
 ```
 
-Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin. In addition, plugins with a high priority value will be 
executed first in a given phase (see the definition of `phase` in 
[choose-phase-to-run](#choose-phase-to-run)). For example, the priority of 
example-plugin is 0 and the priority of ip-restriction is 3000. Therefore, the 
ip-restriction plugin will be executed first, then the example-plugin plugin.
+Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin, you can use the `/v1/schema` method of [control 
API](./control-api.md) to view the priority of all plugins. In addition, 
plugins with a high priority value will be executed first in a given phase (see 
the definition of `phase` in [choose-phase-to-run](#choose-phase-to-run)). For 
example, the priority of example-plugin is 0 and the priority of ip-restriction 
is 3000. Therefore, the ip-restriction plugin will be executed first, then the 
example-plugin plugin.

Review comment:
   would better use a more clear & directly way, what do you think 
@spacewander @Firstsawyou ?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on a change in pull request #3680: docs: plugin-develop.md add to view all plugin priorities

[GitBox]

juzhiyuan commented on a change in pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#discussion_r583977537



##
File path: docs/en/latest/plugin-develop.md
##
@@ -103,7 +103,7 @@ local _M = {
 }
 ```
 
-Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin. In addition, plugins with a high priority value will be 
executed first in a given phase (see the definition of `phase` in 
[choose-phase-to-run](#choose-phase-to-run)). For example, the priority of 
example-plugin is 0 and the priority of ip-restriction is 3000. Therefore, the 
ip-restriction plugin will be executed first, then the example-plugin plugin.
+Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin, you can use the `/v1/schema` method of [control 
API](./control-api.md) to view the priority of all plugins. In addition, 
plugins with a high priority value will be executed first in a given phase (see 
the definition of `phase` in [choose-phase-to-run](#choose-phase-to-run)). For 
example, the priority of example-plugin is 0 and the priority of ip-restriction 
is 3000. Therefore, the ip-restriction plugin will be executed first, then the 
example-plugin plugin.

Review comment:
   `./control-api.md#get-v1schema`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on pull request #213: fix #212

[GitBox]

juzhiyuan commented on pull request #213:
URL: https://github.com/apache/apisix-website/pull/213#issuecomment-786933806


   cc @qier222 @guoqqqi to review this PR :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh opened a new pull request #213: fix #212

[GitBox]

1502shivam-singh opened a new pull request #213:
URL: https://github.com/apache/apisix-website/pull/213


   Fixes: #212 
   
   Changes:
   
   In this pull request I fixed the UI breaks that occurred when accessing the 
website on mobile (i.e. text animation breaking into two lines breaking the 
layout, unnecessary extra space in word leading the text animation) Replaced 
PNG logo on navbar with custom made SVG logo (Choice 2 set in this pull 
request) and increased size of CTA buttons with more padding and increased 
spacing. 
   
   Screenshots of the change:
   
   New SVG logo on navbar with matching size of text.
   
   
![Apache_After_mobile_nav](https://user-images.githubusercontent.com/57267960/109361699-76a3fa80-78af-11eb-9b1f-b5be59d11269.png)
   
   Fix for leading space after animation text
   
   
![Apache_After_mobile1](https://user-images.githubusercontent.com/57267960/109361834-c8e51b80-78af-11eb-95e9-270287206cfd.png)
   
   Fix for overflowing animation text 
   
   
![Apache_After_mobile2](https://user-images.githubusercontent.com/57267960/109361863-d7cbce00-78af-11eb-8eb7-3737f369109c.png)
   
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1518: feat: rewrite e2e test(upstream_chash_hash_on_test) with ginkgo

[GitBox]

juzhiyuan commented on pull request #1518:
URL: https://github.com/apache/apisix-dashboard/pull/1518#issuecomment-786893685


   ping @guoqqqi to take a look



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh commented on issue #212: Enhancement: fix visible breakages in website UI on mobile, PNG logo is pixelated and other changes for better UX.

[GitBox]

1502shivam-singh commented on issue #212:
URL: https://github.com/apache/apisix-website/issues/212#issuecomment-786859648


   Okay, so you also reduced the font-size for the heading (looks like to me) 
for high-performance to fit in, I am looking at keeping the original font size 
as it's better suited for hierarchal difference between the hero text and main 
heading. 
   
   The idea of using the `` tag only on mobile is a good idea  to solve 
that small gap issue and incidentally I also used this method , before 
stumbling over the fact that a leading space did the trick too.
   
   Regarding the full width buttons as I said, usually it's preferred that CTA 
(call to action) buttons should be less than 70% of the actual mobile device 
width, specially when you have more than one CTA buttons. Full width buttons 
are recommended when they are the only action that the user is supposed to take 
on the whole screen (example - App onboarding screen, you would have seen this 
too, buttons on bottom are full width).
   
![test](https://user-images.githubusercontent.com/57267960/109347143-ad224b00-7898-11eb-933c-564e52271543.png)
   
   The less than 70% because consider the situation of a miss-tap when 
scrolling on mobile. Having some free space with no interactive elements around 
helps in scrolling.
   
   
   
   And thanks for attending my small lecture on button user experience design 
藍藍藍



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tzssangglass opened a new issue #3692: [discuss]: enable etcd health check

[GitBox]

tzssangglass opened a new issue #3692:
URL: https://github.com/apache/apisix/issues/3692


   ### Issue description
   I saw this issues #3673 and this pr  #3676.
   I think it's time to enable the etcd health check feature.
   by the way, **etcd's `host` configuration, if it is in the form of 
`ip:port`, the health check takes effect,** if it is in the form of domain, the 
health check fails because etcd's node is hidden behind the domain and cannot 
be distinguished, so use the FQDN of etcd in k8s does not solve the issues 
#3673.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] Jaycean opened a new issue #1521: bug: BE E2E test case is unstable

[GitBox]

Jaycean opened a new issue #1521:
URL: https://github.com/apache/apisix-dashboard/issues/1521


   # Bug report
   
   ## Describe the bug
   
   A clear and concise description of what the bug is.
   
   ## How to Reproduce
   
   BE E2E test case is unstable
   
https://github.com/apache/apisix-dashboard/pull/1466/checks?check_run_id=1984404224
   
   BE E2E test case is unstable and appears again in PR：#1504, so it is 
directly repaired in #1504.
   
   commit: 
https://github.com/apache/apisix-dashboard/pull/1504/commits/de3a084bf038a1ef17576d5d20e3b611a141a4c0



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] qier222 commented on issue #212: Enhancement: fix visible breakages in website UI on mobile, PNG logo is pixelated and other changes for better UX.

[GitBox]

qier222 commented on issue #212:
URL: https://github.com/apache/apisix-website/issues/212#issuecomment-786778030


   This is my solution: I add a ` ` element between "Dynamic" and 
"Cloud-Native", only on mobile devices.
   
   https://user-images.githubusercontent.com/68148142/109332433-0db18800-7899-11eb-9d26-65b9e15a0ae4.png;>
   https://user-images.githubusercontent.com/68148142/109332484-2326b200-7899-11eb-8099-f8ad0b87e725.png;>
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1518: feat: rewrite e2e test(upstream_chash_hash_on_test) with ginkgo

[GitBox]

Jaycean commented on pull request #1518:
URL: https://github.com/apache/apisix-dashboard/pull/1518#issuecomment-786770725


   cc @juzhiyuan @liuxiran FE e2e test failed. PTAL.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh commented on issue #212: Enhancement: fix visible breakages in website UI on mobile, PNG logo is pixelated and other changes for better UX.

[GitBox]

1502shivam-singh commented on issue #212:
URL: https://github.com/apache/apisix-website/issues/212#issuecomment-786746827


   I feel the size in image 9 is fine. Making them full width would pull way 
too much attention to them and it breaks hierarchy and layout. As of hierarchy 
we should have focus hierarchy like this according to me : "Apache 
Apisix...Gateway" > buttons > "Provides rich.etcd." 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #272: chore: fix spelling

[GitBox]

gxthrj merged pull request #272:
URL: https://github.com/apache/apisix-ingress-controller/pull/272


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-ingress-controller] branch master updated: chore: fix spelling (#272)

[kvn]

This is an automated email from the ASF dual-hosted git repository.

kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git


The following commit(s) were added to refs/heads/master by this push:
 new 0c8f306  chore: fix spelling (#272)
0c8f306 is described below

commit 0c8f306cac9911ababb3c23700ac7ca1efc21833
Author: John Bampton 
AuthorDate: Sat Feb 27 02:19:54 2021 +1000

chore: fix spelling (#272)
---
 CHANGELOG.md| 2 +-
 cmd/ingress/ingress.go  | 2 +-
 conf/config-default.yaml| 4 ++--
 docs/en/latest/CRD-specification.md | 6 +++---
 docs/en/latest/FAQ.md   | 2 +-
 docs/en/latest/deployments/ack.md   | 2 +-
 docs/en/latest/deployments/aws.md   | 2 +-
 docs/en/latest/deployments/azure.md | 4 ++--
 docs/en/latest/deployments/gke.md   | 2 +-
 docs/en/latest/deployments/k3s-rke.md   | 4 ++--
 docs/en/latest/deployments/kubesphere.md| 2 +-
 docs/en/latest/deployments/minikube.md  | 2 +-
 docs/en/latest/deployments/tke.md   | 4 ++--
 docs/en/latest/development.md   | 2 +-
 pkg/apisix/upstream.go  | 2 +-
 pkg/config/config_test.go   | 2 +-
 pkg/ingress/controller/apisix_upstream.go   | 4 ++--
 pkg/ingress/controller/controller.go| 2 +-
 pkg/ingress/controller/ingress.go   | 2 +-
 pkg/kube/apisix/apis/config/v1/types.go | 6 +++---
 pkg/seven/apisix/plugins.go | 2 +-
 pkg/seven/state/builder.go  | 4 ++--
 pkg/types/apisix/v1/types.go| 4 ++--
 pkg/version/version.go  | 2 +-
 samples/deploy/configmap/apisix-ingress-cm.yaml | 2 +-
 test/e2e/README.md  | 2 +-
 test/e2e/ingress/resourcepushing.go | 2 +-
 test/e2e/scaffold/k8s.go| 2 +-
 test/e2e/testdata/apisix-gw-config.yaml | 2 +-
 29 files changed, 40 insertions(+), 40 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 195602e..cd51e7f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -81,7 +81,7 @@ This release mainly improve basic features, bugfix and adds 
test cases.
 
 ## Test case
 
-- Add E2E test enviroment. 
[#101](https://github.com/apache/apisix-ingress-controller/pull/101)
+- Add E2E test environment. 
[#101](https://github.com/apache/apisix-ingress-controller/pull/101)
 
 ## Bugfix
 
diff --git a/cmd/ingress/ingress.go b/cmd/ingress/ingress.go
index 213149b..d43f1cd 100644
--- a/cmd/ingress/ingress.go
+++ b/cmd/ingress/ingress.go
@@ -137,7 +137,7 @@ the apisix cluster and others are created`,

cmd.PersistentFlags().DurationVar(, 
"resync-interval", time.Minute, "the controller resync (with Kubernetes) 
interval, the minimum resync interval is 30s")
cmd.PersistentFlags().StringSliceVar(, 
"app-namespace", []string{config.NamespaceAll}, "namespaces that controller 
will watch for resources")
cmd.PersistentFlags().StringVar(, 
"ingress-class", config.IngressClass, "the class of an Ingress object is set 
using the field IngressClassName in Kubernetes clusters version v1.18.0 or 
higher or the annotation \"kubernetes.io/ingress.class\" (deprecated)")
-   cmd.PersistentFlags().StringVar(, 
"election-id", config.IngressAPISIXLeader, "election id used for compaign the 
controller leader")
+   cmd.PersistentFlags().StringVar(, 
"election-id", config.IngressAPISIXLeader, "election id used for campaign the 
controller leader")
cmd.PersistentFlags().StringVar(, 
"ingress-version", config.IngressNetworkingV1, "the supported ingress api group 
version, can be \"networking/v1beta1\" or \"networking/v1\" (for Kubernetes 
version v1.19.0 or higher)")
cmd.PersistentFlags().StringVar(, "apisix-base-url", 
"", "the base URL for APISIX admin api / manager api")
cmd.PersistentFlags().StringVar(, 
"apisix-admin-key", "", "admin key used for the authorization of APISIX admin 
api / manager api")
diff --git a/conf/config-default.yaml b/conf/config-default.yaml
index 55547a9..b5d81da 100644
--- a/conf/config-default.yaml
+++ b/conf/config-default.yaml
@@ -28,7 +28,7 @@ log_output: "stderr" # the output file path of error log, 
default is stderr, whe
  # programs easily.
 
 http_listen: ":8080"   # the HTTP Server listen address, default is ":8080"
-enable_profiling: true # enable profileing via web interfaces
+enable_profiling: true # enable profiling via web interfaces
# host:port/debug/pprof, default is true.
 
 # Kubernetes related configurations.
@@ -40,7 +40,7 @@ kubernetes:
# and the minimal resync interval is 
30s.
   app_namespaces: ["*"]# namespace list that controller will 
watch for 

[GitHub] [apisix-website] qier222 commented on issue #212: Enhancement: fix visible breakages in website UI on mobile, PNG logo is pixelated and other changes for better UX.

[GitBox]

qier222 commented on issue #212:
URL: https://github.com/apache/apisix-website/issues/212#issuecomment-786742266


   How about we make "View on GitHub" button and "Download" button as wide as 
screen width on mobile devices？



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] jp-gouin opened a new pull request #3691: Add filter on HTTP methods for consumer-restriction plugin

[GitBox]

jp-gouin opened a new pull request #3691:
URL: https://github.com/apache/apisix/pull/3691


   ### What this PR does / why we need it:
   Fix for #3635 
   Add the possibility to add `allowed_methods` for a user when `whitelist` is 
set.
   This will restrict the user to only performed the HTTP action matching the 
list specified in `allowed_method.methods`
   
   This is the format : 
   ```
   "plugins": {
   "key-auth": {},
   "consumer-restriction": {
   "whitelist": [
   "jack1"
   ],
   "allowed_methods":[{
 "user": "jack1",
 "methods": ["POST"]
   }]
   }
   }
   ```
   I choose to add a dedicated section instead of modifying the existing 
`whitelist` one because i think it's more readable. 
   When nothing is set , then only the whitelist is applied .
   And in order to set `allowed_methods` , `whitelist` is required.
   
   ### Pre-submission checklist:
   Test case updated with 2 basics tests 
   1. only allow `post` on resources and try to `get` the resource -> 
unauthorized
   2. Add `get`capability to the user and try to `get` the resource -> 
authorized
   
   Add 2 test cases for testing the plugin scheme 
   
   1. Only `allowed_methods` is set -> failed
   2. `allowed_methods` is set with `blacklist` -> failed
   
   English documentation updated , any help for the Chineese one would be 
appreciated.
   
   * [X] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [X] Have you added corresponding test cases?
   * [X] Have you modified the corresponding document?
   * [X] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] 1502shivam-singh opened a new issue #212: Enhancement: fix visible breakages in website UI on mobile, PNG logo is pixelated and other changes for better UX.

[GitBox]

1502shivam-singh opened a new issue #212:
URL: https://github.com/apache/apisix-website/issues/212


   Actual behaviour 
   Currently the website looks fine, but I have some changes to recommend. 
Currently the animation text in top hero section overflows to 2 lines when 
“high-performance” (image 1) comes up, and leading words have some margin from 
left breaking alignments (image 2 and 3)
   
   
   image 1
   
![Apache_before_mobile2](https://user-images.githubusercontent.com/57267960/109315764-e34bd480-7870-11eb-8f65-e13a8a09632d.png)
   
   
   image 2
   
![Apache_before_mobile1](https://user-images.githubusercontent.com/57267960/109315355-78020280-7870-11eb-8a46-1c92c35478c9.png)
   
   
   image 3
   
![InkedApache_before_mobile1_LI](https://user-images.githubusercontent.com/57267960/109316311-7e44ae80-7871-11eb-8143-6ffe167682e8.jpg)
   
   The PNG logo on navbar is pixelated and can be replaced with a SVG logo. 
(image 4) 
   
   
   image 4
   
![Apache_before_mobile_nav](https://user-images.githubusercontent.com/57267960/109316485-adf3b680-7871-11eb-9d1f-05f8501320f5.png)
   
   Also the button sizes and spacing on mobile are  not appropriate as a bigger 
size button would be better on mobile for touch and the buttons stick together 
vertically, here some spacing would be better.  (image 5)
   
   
   image 5
   
![InkedApache_before_mobilebuttons_LI](https://user-images.githubusercontent.com/57267960/109316847-09be3f80-7872-11eb-8b9c-867eca7048f0.jpg)
   
   Expected behaviour
   
   The expected result in the text animation in top hero is to keep the 
animated word in one single line, because overflow could break the text 
animation’s grey background leading to not so good results.
   
   For the logo, as I have said above a SVG logo would be better as its modern, 
doesn’t pixelate and saves file size.
   
   The buttons should be little bigger, than the current variant with some more 
padding. Also there should be proper spacing between the buttons to prevent 
mistouch.
   
   Steps to reproduce
   
   The text animation can be kept in one line by changing the word 
“high-performance” to a word with same meaning and smaller lexically. I 
recommend using “Performant” as it’s a synonym of “high-performance” 
([source](https://www.wordhippo.com/what-is/another-word-for/high-performing.html)).
 I personally have tested this word and it fits properly (check image below). 
For the extra margin a blank space after the space character did the trick.
   
   As far as the logo is concerned, I have designed three versions of your 
org’s logo as a SVG, you can check them here ([Figma 
link](https://www.figma.com/file/LeICU6ikwITGemfw8lBRs3/APISIX-Apache-swf?node-id=0%3A1))
 and tell which one you like.
   
   CSS changes will do the trick for the buttons. Appropriate margins and 
padding.
   
   After change screenshots
   Fixing text animations (image 6) and alignments (image 7) (due to margins) -
   
   
   image 6
   
![Apache_After_mobile2](https://user-images.githubusercontent.com/57267960/109317172-733e4e00-7872-11eb-9402-6ce2cd342efd.png)
   
   
   image 7
   
![Apache_After_mobile1](https://user-images.githubusercontent.com/57267960/109318042-63733980-7873-11eb-984a-102a685af6a7.png)
   
   After changing logo to SVG in one of the given options and changing title 
font-size to match logo size (image 8)-
   
   
   image 8
   
![Apache_After_mobile_nav](https://user-images.githubusercontent.com/57267960/109317451-bc8e9d80-7872-11eb-9d89-a23745f962b2.png)
   
   Changing button sizes, paddings and spacings (image 9) -
   
   
   image 9
   
![Apache_After_mobile1](https://user-images.githubusercontent.com/57267960/109317652-efd12c80-7872-11eb-942d-3818c2e7be03.png)
   
   @juzhiyuan I would like to take up this issue, as I have already done the 
necessary work to solve this issue. Also, if the figma link doesn't work in 
your country (maybe) for some reason, then please tell me I will share them 
here as images. 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Bhanuji95 opened a new issue #3690: Support for AzureAD/OIDC integration with APISIX

[GitBox]

Bhanuji95 opened a new issue #3690:
URL: https://github.com/apache/apisix/issues/3690


   Hello team,
   
   We are trying to integrate our APIs authentication with AzureAD/OIDC using 
apisix, can you please let us know how we can achieve this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1520: chore: remove whitespace before commas

[GitBox]

juzhiyuan merged pull request #1520:
URL: https://github.com/apache/apisix-dashboard/pull/1520


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: chore: remove whitespace before commas (#1520)

[juzhiyuan]

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new 4dd7b15  chore: remove whitespace before commas (#1520)
4dd7b15 is described below

commit 4dd7b15bd85c2b2b89b53a60ea7ff8f09f45cf8b
Author: John Bampton 
AuthorDate: Fri Feb 26 23:43:54 2021 +1000

chore: remove whitespace before commas (#1520)
---
 api/conf/conf.yaml| 2 +-
 api/test/docker/manager-api-conf.yaml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/api/conf/conf.yaml b/api/conf/conf.yaml
index a595de1..212f1e5 100644
--- a/api/conf/conf.yaml
+++ b/api/conf/conf.yaml
@@ -48,7 +48,7 @@ authentication:
   secret:
 secret  # secret for jwt token generation.
 # NOTE: Highly recommended to modify this value to 
protect `manager api`.
-# if it's default value, when `manager api` start , it 
will generate a random string to replace it.
+# if it's default value, when `manager api` start, it 
will generate a random string to replace it.
   expire_time: 3600 # jwt token expire time, in second
   users:# yamllint enable rule:comments-indentation
 - username: admin   # username and password for login `manager api`
diff --git a/api/test/docker/manager-api-conf.yaml 
b/api/test/docker/manager-api-conf.yaml
index ee1f783..0d987cc 100644
--- a/api/test/docker/manager-api-conf.yaml
+++ b/api/test/docker/manager-api-conf.yaml
@@ -33,7 +33,7 @@ conf:
 authentication:
   secret: secret # secret for jwt token generation.
  # *NOTE*: Highly recommended to modify this value 
to protect `manager api`.
- # if it's default value, when `manager api` start 
, it will generate a random string to replace it.
+ # if it's default value, when `manager api` 
start, it will generate a random string to replace it.
   expire_time: 3600  # jwt token expire time, in second
   users: # yamllint enable rule:comments-indentation
 - username: admin# username and password for login `manager api`

[GitHub] [apisix-website] juzhiyuan merged pull request #211: chore: remove trailing whitespace

[GitBox]

juzhiyuan merged pull request #211:
URL: https://github.com/apache/apisix-website/pull/211


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-website] branch master updated: chore: remove trailing whitespace (#211)

[juzhiyuan]

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git


The following commit(s) were added to refs/heads/master by this push:
 new 24379a5  chore: remove trailing whitespace (#211)
24379a5 is described below

commit 24379a52ccf4e22962866bdb28b4c3199777
Author: John Bampton 
AuthorDate: Fri Feb 26 23:43:07 2021 +1000

chore: remove trailing whitespace (#211)
---
 website/src/css/customTheme.css  | 2 +-
 website/src/pages/downloads/index.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/website/src/css/customTheme.css b/website/src/css/customTheme.css
index fc45cd9..b9b873e 100644
--- a/website/src/css/customTheme.css
+++ b/website/src/css/customTheme.css
@@ -350,7 +350,7 @@ a:hover {
   opacity: 0.88;
 }
 
-/* 
+/*
   Animations
 */
 
diff --git a/website/src/pages/downloads/index.js 
b/website/src/pages/downloads/index.js
index 87bc757..44596ee 100644
--- a/website/src/pages/downloads/index.js
+++ b/website/src/pages/downloads/index.js
@@ -78,7 +78,7 @@ export default (props) => {
 the mirrors.
 
 {`gpg -i KEYS
-  
+
 # or
 pgpk -a KEYS
 

[GitHub] [apisix-website] juzhiyuan merged pull request #210: chore: fix spelling

[GitBox]

juzhiyuan merged pull request #210:
URL: https://github.com/apache/apisix-website/pull/210


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-website] branch master updated (d34baf3 -> 7829cca)

[juzhiyuan]

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git.


from d34baf3  fix: deploy issue cause by sync-docs.js (#209)
 add 7829cca  chore: fix spelling (#210)

No new revisions were added by this update.

Summary of changes:
 website/blog/2021-01-21-run-ingress-apisix-on-amazon-eks.md   | 8 
 website/blog/2021-02-08-stable-product-delivery-with-cypress.md   | 4 ++--
 .../2020-12-23-release-apache-apisix-ingress-controller-0.1.0.md  | 2 +-
 website/events/2021-02-12-release-apache-apisix-dashboard-2.4.md  | 4 ++--
 4 files changed, 9 insertions(+), 9 deletions(-)

[GitHub] [apisix] juzhiyuan merged pull request #3685: docs: Added title to markdown under `docs`

[GitBox]

juzhiyuan merged pull request #3685:
URL: https://github.com/apache/apisix/pull/3685


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated: docs: Added title to markdown under `docs` (#3685)

[juzhiyuan]

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 9c5ba91  docs: Added title to markdown under `docs` (#3685)
9c5ba91 is described below

commit 9c5ba9184ad000ee97afe808ade029f4bebc1771
Author: guoqqqi <72343596+guoq...@users.noreply.github.com>
AuthorDate: Fri Feb 26 21:40:08 2021 +0800

docs: Added title to markdown under `docs` (#3685)
---
 docs/en/latest/admin-api.md|  6 +-
 docs/en/latest/architecture-design.md  |  4 
 docs/en/latest/aws.md  |  6 --
 docs/en/latest/batch-processor.md  |  6 --
 docs/en/latest/benchmark.md|  4 
 docs/en/latest/control-api.md  |  4 
 docs/en/latest/customize-nginx-configuration.md|  6 --
 docs/en/latest/debug-function.md   |  4 
 docs/en/latest/discovery.md|  6 --
 docs/en/latest/discovery/consul_kv.md  |  4 
 docs/en/latest/dns.md  |  4 
 .../examples/plugins-hmac-auth-generate-signature.md   |  6 --
 docs/en/latest/getting-started.md  |  6 +-
 docs/en/latest/grpc-proxy.md   |  6 --
 docs/en/latest/health-check.md |  6 +-
 docs/en/latest/how-to-build.md |  6 --
 docs/en/latest/https.md|  6 --
 docs/en/latest/install-dependencies.md | 18 ++
 docs/en/latest/mtls.md |  6 --
 docs/en/latest/plugin-develop.md   |  6 +-
 docs/en/latest/plugin-interceptors.md  |  6 --
 docs/en/latest/plugins.md  |  4 
 docs/en/latest/plugins/api-breaker.md  |  6 +-
 docs/en/latest/plugins/authz-keycloak.md   |  6 +-
 docs/en/latest/plugins/basic-auth.md   |  6 +-
 docs/en/latest/plugins/batch-requests.md   |  6 +-
 docs/en/latest/plugins/consumer-restriction.md |  6 +-
 docs/en/latest/plugins/cors.md |  6 +-
 docs/en/latest/plugins/dubbo-proxy.md  |  6 +-
 docs/en/latest/plugins/echo.md |  6 +-
 docs/en/latest/plugins/error-log-logger.md |  6 +-
 docs/en/latest/plugins/fault-injection.md  |  4 
 docs/en/latest/plugins/grpc-transcode.md   |  4 
 docs/en/latest/plugins/hmac-auth.md|  6 +-
 docs/en/latest/plugins/http-logger.md  |  6 +-
 docs/en/latest/plugins/ip-restriction.md   |  6 +-
 docs/en/latest/plugins/jwt-auth.md |  6 +-
 docs/en/latest/plugins/kafka-logger.md |  6 +-
 docs/en/latest/plugins/key-auth.md |  6 +-
 docs/en/latest/plugins/limit-conn.md   |  6 +-
 docs/en/latest/plugins/limit-count.md  |  6 +-
 docs/en/latest/plugins/limit-req.md|  6 +-
 docs/en/latest/plugins/log-rotate.md   |  4 
 docs/en/latest/plugins/mqtt-proxy.md   |  6 +-
 docs/en/latest/plugins/node-status.md  |  6 +-
 docs/en/latest/plugins/openid-connect.md   |  6 +-
 docs/en/latest/plugins/prometheus.md   |  6 --
 docs/en/latest/plugins/proxy-cache.md  |  6 --
 docs/en/latest/plugins/proxy-mirror.md |  6 --
 docs/en/latest/plugins/proxy-rewrite.md|  6 +-
 docs/en/latest/plugins/redirect.md |  6 +-
 docs/en/latest/plugins/referer-restriction.md  |  6 +-
 docs/en/latest/plugins/request-id.md   |  6 +-
 docs/en/latest/plugins/request-validation.md   |  6 +-
 docs/en/latest/plugins/response-rewrite.md |  6 +-
 docs/en/latest/plugins/server-info.md  |  6 +-
 docs/en/latest/plugins/serverless.md   |  6 +-
 docs/en/latest/plugins/skywalking.md   |  6 +-
 docs/en/latest/plugins/sls-logger.md   |  6 +-
 docs/en/latest/plugins/syslog.md   |  6 +-
 docs/en/latest/plugins/tcp-logger.md   |  6 +-
 docs/en/latest/plugins/traffic-split.md|  6 +-
 docs/en/latest/plugins/udp-logger.md   |  6 +-
 docs/en/latest/plugins/uri-blocker.md  |  6 +-
 docs/en/latest/plugins/wolf-rbac.md|  6 +-
 docs/en/latest/plugins/zipkin.md 

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3494: docs: update the docs of the prometheus plugin

[GitBox]

Firstsawyou commented on a change in pull request #3494:
URL: https://github.com/apache/apisix/pull/3494#discussion_r583633418



##
File path: docs/zh/latest/plugins/prometheus.md
##
@@ -118,12 +118,49 @@ plugin_attr:
 
 ### 可有的指标
 
-* `Status codes`: upstream 服务返回的 HTTP 状态码，每个服务返回状态码的次数或者所有服务的状态码次数总和都可以统计到。
-* `Bandwidth`: 流经apisix的总带宽(可分出口带宽和入口带宽). 每个服务指标或者是所有服务指标的总和都可以统计到。
+* `Status codes`: upstream 服务返回的 HTTP 
状态码，每个服务返回状态码的次数或者所有服务的状态码次数总和都可以统计到。具有的维度：

Review comment:
   added: [https://github.com/apache/apisix/issues/3689 
](https://github.com/apache/apisix/issues/3689)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou opened a new issue #3689: docs: the prometheus.md grammar improve

[GitBox]

Firstsawyou opened a new issue #3689:
URL: https://github.com/apache/apisix/issues/3689


   # Improve Docs
   
   the `prometheus.md` doc is hard to read. We need to improve the grammar of 
some of its sentence.
   
   E.g:  https://github.com/apache/apisix/pull/3494#discussion_r583421215



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1504: feat: rewrite e2e test(upstream_chash_query_string_arg_xxx_test) with ginkgo

[GitBox]

codecov-io edited a comment on pull request #1504:
URL: https://github.com/apache/apisix-dashboard/pull/1504#issuecomment-784716574


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=h1) 
Report
   > Merging 
[#1504](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=desc) 
(3d271ca) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/10f60447bb99a08a8ba1aa11ef684472176f80a0?el=desc)
 (10f6044) will **decrease** coverage by `1.24%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1504  +/-   ##
   ==
   - Coverage   68.55%   67.31%   -1.25% 
   ==
 Files  48   48  
 Lines3056 3056  
   ==
   - Hits 2095 2057  -38 
   - Misses722  765  +43 
   + Partials  239  234   -5 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==)
 | `5.88% <0.00%> (-68.63%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `81.25% <0.00%> (-18.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `64.70% <0.00%> (-1.18%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `87.34% <0.00%> (-0.61%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `33.33% <0.00%> (ø)` | |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `43.63% <0.00%> (+1.81%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=footer).
 Last update 
[10f6044...3d271ca](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1504: feat: rewrite e2e test(upstream_chash_query_string_arg_xxx_test) with ginkgo

[GitBox]

codecov-io edited a comment on pull request #1504:
URL: https://github.com/apache/apisix-dashboard/pull/1504#issuecomment-784716574


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=h1) 
Report
   > Merging 
[#1504](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=desc) 
(3d271ca) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/10f60447bb99a08a8ba1aa11ef684472176f80a0?el=desc)
 (10f6044) will **decrease** coverage by `16.89%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/graphs/tree.svg?width=650=150=pr=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1504   +/-   ##
   ===
   - Coverage   68.55%   51.65%   -16.90% 
   ===
 Files  48   39-9 
 Lines3056 2600  -456 
   ===
   - Hits 2095 1343  -752 
   - Misses722 1083  +361 
   + Partials  239  174   -65 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-70.41%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=)
 | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [29 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1504/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=footer).
 Last update 
[10f6044...3d271ca](https://codecov.io/gh/apache/apisix-dashboard/pull/1504?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming opened a new issue #3688: code style: avoid `from moudle_name import *` in fuzzing test of APISIX

[GitBox]

moonming opened a new issue #3688:
URL: https://github.com/apache/apisix/issues/3688


   still not fixed
   
   _Originally posted by @moonming in 
https://github.com/apache/apisix/pull/3667#discussion_r583597056_



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] idbeta commented on a change in pull request #3667: test: add fuzzing case for the route with vars

[GitBox]

idbeta commented on a change in pull request #3667:
URL: https://github.com/apache/apisix/pull/3667#discussion_r583598909



##
File path: t/fuzzing/public.py
##
@@ -20,14 +20,15 @@
 import subprocess
 import os
 import psutil
+from boofuzz import *

Review comment:
   This is the official usage. If it is changed to `import boofuzz`, the 
code will be very complicated. @moonming  





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] moonming commented on a change in pull request #3667: test: add fuzzing case for the route with vars

[GitBox]

moonming commented on a change in pull request #3667:
URL: https://github.com/apache/apisix/pull/3667#discussion_r583597056



##
File path: t/fuzzing/public.py
##
@@ -20,14 +20,15 @@
 import subprocess
 import os
 import psutil
+from boofuzz import *

Review comment:
   still not fixed





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1518: feat: rewrite e2e test(upstream_chash_hash_on_test) with ginkgo

[GitBox]

Jaycean commented on pull request #1518:
URL: https://github.com/apache/apisix-dashboard/pull/1518#issuecomment-786608504


   > @Jaycean is this pr ready ?
   
   Yes, but I'm going to check it again before opening it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] idbeta commented on pull request #3667: test: add fuzzing case for the route with vars

[GitBox]

idbeta commented on pull request #3667:
URL: https://github.com/apache/apisix/pull/3667#issuecomment-786608041


   ping @moonming 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] idbeta commented on a change in pull request #3667: test: add fuzzing case for the route with vars

[GitBox]

idbeta commented on a change in pull request #3667:
URL: https://github.com/apache/apisix/pull/3667#discussion_r583575318



##
File path: t/fuzzing/public.py
##
@@ -43,3 +44,27 @@ def check_process():
 process = {p.pid for p in children if "cache loader process" not in 
p.cmdline()[0]}
 process.add(parent.pid)
 return process
+
+def initfuzz():
+fw = open(cur_dir() + "/test.log",'wb')
+fuzz_loggers = [FuzzLoggerText(file_handle=fw)]
+session = Session(
+target=Target(
+connection=TCPSocketConnection("127.0.0.1", 9080, 
send_timeout=5.0, recv_timeout=5.0, server=False)
+),
+fuzz_loggers=fuzz_loggers,
+keep_web_open=False,
+)
+return session
+
+def runtest(create_route, run):

Review comment:
   sure





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #272: chore: fix spelling

[GitBox]

tokers commented on pull request #272:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/272#issuecomment-786588755


   OK，it doesn't matter :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3667: test: add fuzzing case for the route with vars

[GitBox]

spacewander commented on a change in pull request #3667:
URL: https://github.com/apache/apisix/pull/3667#discussion_r583568569



##
File path: t/fuzzing/public.py
##
@@ -43,3 +44,27 @@ def check_process():
 process = {p.pid for p in children if "cache loader process" not in 
p.cmdline()[0]}
 process.add(parent.pid)
 return process
+
+def initfuzz():
+fw = open(cur_dir() + "/test.log",'wb')
+fuzz_loggers = [FuzzLoggerText(file_handle=fw)]
+session = Session(
+target=Target(
+connection=TCPSocketConnection("127.0.0.1", 9080, 
send_timeout=5.0, recv_timeout=5.0, server=False)
+),
+fuzz_loggers=fuzz_loggers,
+keep_web_open=False,
+)
+return session
+
+def runtest(create_route, run):

Review comment:
   Should be `run_test`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] jbampton commented on pull request #272: chore: fix spelling

[GitBox]

jbampton commented on pull request #272:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/272#issuecomment-786564087


   Hey @tokers I used my editor to find these spelling mistakes so we can't add 
it to the CI.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] lilien1010 commented on a change in pull request #3577: feat: support conditional response rewrite

[GitBox]

lilien1010 commented on a change in pull request #3577:
URL: https://github.com/apache/apisix/pull/3577#discussion_r583543546



##
File path: t/plugin/response-rewrite.t
##
@@ -509,3 +509,96 @@ GET /t
 additional properties forbidden, found invalid_att
 --- no_error_log
 [error]
+
+
+
+=== TEST 17: add validate vars
+--- config
+location /t {
+content_by_lua_block {
+local plugin = require("apisix.plugins.response-rewrite")
+local ok, err = plugin.check_schema({
+vars = {
+{"status","==",200}

Review comment:
   added





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] idbeta commented on a change in pull request #3667: test: add fuzzing case for the route with vars

[GitBox]

idbeta commented on a change in pull request #3667:
URL: https://github.com/apache/apisix/pull/3667#discussion_r583541546



##
File path: t/fuzzing/serverless_route_test.py
##
@@ -100,12 +92,10 @@ def main():
 # before test

Review comment:
   I got it.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] lilien1010 commented on a change in pull request #3577: feat: support conditional response rewrite

[GitBox]

lilien1010 commented on a change in pull request #3577:
URL: https://github.com/apache/apisix/pull/3577#discussion_r583537135



##
File path: apisix/plugins/response-rewrite.lua
##
@@ -107,6 +143,11 @@ function _M.body_filter(conf, ctx)
 end
 
 function _M.header_filter(conf, ctx)
+ctx.reponse_rewrite_matched =  vars_matched(conf, ctx)

Review comment:
   fixed





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] Baoyuantop closed issue #208: Cannot find Contributor Guide page in team page

[GitBox]

Baoyuantop closed issue #208:
URL: https://github.com/apache/apisix-website/issues/208


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander opened a new pull request #3687: chore: no need to package documentation

[GitBox]

spacewander opened a new pull request #3687:
URL: https://github.com/apache/apisix/pull/3687


   Signed-off-by: spacewander 
   
   ### What this PR does / why we need it:
   
   
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, 
please discuss on the [mailing 
list](https://github.com/apache/apisix/tree/master#community) first**
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3680: docs: plugin-develop.md add to view all plugin priorities

[GitBox]

Firstsawyou commented on a change in pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#discussion_r583522486



##
File path: docs/en/latest/plugin-develop.md
##
@@ -103,7 +103,7 @@ local _M = {
 }
 ```
 
-Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin. In addition, plugins with a high priority value will be 
executed first in a given phase (see the definition of `phase` in 
[choose-phase-to-run](#choose-phase-to-run)). For example, the priority of 
example-plugin is 0 and the priority of ip-restriction is 3000. Therefore, the 
ip-restriction plugin will be executed first, then the example-plugin plugin.
+Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin, you can view the priority of all plugins in the 
[t/debug/debug-mode.t](../../../t/debug/debug-mode.t) file. In addition, 
plugins with a high priority value will be executed first in a given phase (see 
the definition of `phase` in [choose-phase-to-run](#choose-phase-to-run)). For 
example, the priority of example-plugin is 0 and the priority of ip-restriction 
is 3000. Therefore, the ip-restriction plugin will be executed first, then the 
example-plugin plugin.

Review comment:
   got it.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers commented on issue #3683: request help: error_log has garbled

[GitBox]

tokers commented on issue #3683:
URL: https://github.com/apache/apisix/issues/3683#issuecomment-786542780


   @thekingofworld Seems like some binary protocol frames were sent to the HTTP 
port.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers edited a comment on issue #3673: request help: A node in the K8S environment ETCD cluster died, causing Apisix to fail

[GitBox]

tokers edited a comment on issue #3673:
URL: https://github.com/apache/apisix/issues/3673#issuecomment-786541651


   @GBXing `etcd-1.etcd.apisix.svc.cluster.local` the FQDN seems not valid, 
what are the service name and the namespace?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers commented on issue #3673: request help: A node in the K8S environment ETCD cluster died, causing Apisix to fail

[GitBox]

tokers commented on issue #3673:
URL: https://github.com/apache/apisix/issues/3673#issuecomment-786541651


   @GBXing `etcd-1.etcd.apisix.svc.cluster.local` the FQDN seems not valid, 
what are the service name and the namespace.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1517: ci: auto generate and check rpm package

[GitBox]

nic-chen commented on pull request #1517:
URL: https://github.com/apache/apisix-dashboard/pull/1517#issuecomment-786540911


   @starsz  CI failed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] tokers merged pull request #3681: docs: fix broken links

[GitBox]

tokers merged pull request #3681:
URL: https://github.com/apache/apisix/pull/3681


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix] branch master updated: docs: fix broken links (#3681)

[tokers]

This is an automated email from the ASF dual-hosted git repository.

tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git


The following commit(s) were added to refs/heads/master by this push:
 new 12fb8eb  docs: fix broken links (#3681)
12fb8eb is described below

commit 12fb8eb76dd0fb0d256f8e4091fe74c4c4e64877
Author: Cliff Su 
AuthorDate: Fri Feb 26 17:56:32 2021 +0800

docs: fix broken links (#3681)
---
 README.md| 2 +-
 README_CN.md | 2 +-
 README_ES.md | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index aaa628d..c5d8281 100644
--- a/README.md
+++ b/README.md
@@ -326,7 +326,7 @@ Users are encouraged to add themselves to the [Powered 
By](docs/en/latest/powere
 
 https://landscape.cncf.io/images/left-logo.svg; 
width="150">https://landscape.cncf.io/images/right-logo.svg; width="200">
 
-APISIX enriches the https://landscape.cncf.io/category=api-gateway=card-mode=category;>
+APISIX enriches the https://landscape.cncf.io/card-mode?category=api-gateway=category;>
 CNCF API Gateway Landscape.
 
 
diff --git a/README_CN.md b/README_CN.md
index 246565c..316892d 100644
--- a/README_CN.md
+++ b/README_CN.md
@@ -330,7 +330,7 @@ CentOS 7, Ubuntu 16.04, Ubuntu 18.04, Debian 9, Debian 10, 
macOS, **ARM64** Ubun
 
 https://landscape.cncf.io/images/left-logo.svg; 
width="150">https://landscape.cncf.io/images/right-logo.svg; width="200">
 
-APISIX 被纳入 https://landscape.cncf.io/category=api-gateway=card-mode=category;>
 云原生软件基金会 API 网关全景图
+APISIX 被纳入 https://landscape.cncf.io/card-mode?category=api-gateway=category;>
 云原生软件基金会 API 网关全景图
 
 
 ## Logo
diff --git a/README_ES.md b/README_ES.md
index 6ea5869..ba761d8 100644
--- a/README_ES.md
+++ b/README_ES.md
@@ -326,7 +326,7 @@ Se alienta a los usuarios a sumarse a la página [Powered 
By](docs/en/latest/pow
 
 https://landscape.cncf.io/images/left-logo.svg; 
width="150">https://landscape.cncf.io/images/right-logo.svg; width="200">
 
-APISIX enriquece el https://landscape.cncf.io/category=api-gateway=card-mode=category;>
+APISIX enriquece el https://landscape.cncf.io/card-mode?category=api-gateway=category;>
 CNCF API Gateway Landscape.
 
 

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1518: feat: rewrite e2e test(upstream_chash_hash_on_test) with ginkgo

[GitBox]

nic-chen commented on pull request #1518:
URL: https://github.com/apache/apisix-dashboard/pull/1518#issuecomment-786540248


   @Jaycean  is this pr ready ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #272: chore: fix spelling

[GitBox]

tokers commented on pull request #272:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/272#issuecomment-786537451


   @jbampton Could we add this feature to CI?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers merged pull request #273: chore: fix whitespace

[GitBox]

tokers merged pull request #273:
URL: https://github.com/apache/apisix-ingress-controller/pull/273


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-ingress-controller] branch master updated: chore: fix whitespace (#273)

[tokers]

This is an automated email from the ASF dual-hosted git repository.

tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git


The following commit(s) were added to refs/heads/master by this push:
 new 2890cf9  chore: fix whitespace (#273)
2890cf9 is described below

commit 2890cf9b58f92b73406ab7a5da5d9c9a82a1f413
Author: John Bampton 
AuthorDate: Fri Feb 26 19:50:08 2021 +1000

chore: fix whitespace (#273)
---
 docs/en/latest/CRD-specification.md | 2 +-
 pkg/kube/translation/ingress.go | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/en/latest/CRD-specification.md 
b/docs/en/latest/CRD-specification.md
index c694350..87c8930 100644
--- a/docs/en/latest/CRD-specification.md
+++ b/docs/en/latest/CRD-specification.md
@@ -357,6 +357,6 @@ spec：
 | hosts | array| The domain list to identify which hosts (matched 
with SNI) can use the TLS certificate stored in the Secret.  |
 | secret| object   | The definition of the related Secret object with 
current ApisixTls object.   |
 | name  | string   | The name of secret, the secret contains key and 
cert for `TLS`.   |
-| namespace | string   | The namespace of secret , the secret contains key 
and cert for `TLS`.  |
+| namespace | string   | The namespace of secret, the secret contains key 
and cert for `TLS`.  |
 
 [Back to top](#crd-types)
diff --git a/pkg/kube/translation/ingress.go b/pkg/kube/translation/ingress.go
index d6fc60b..32eca07 100644
--- a/pkg/kube/translation/ingress.go
+++ b/pkg/kube/translation/ingress.go
@@ -56,7 +56,7 @@ func (t *translator) translateIngressV1(ing 
*networkingv1.Ingress) ([]*apisixv1.
if pathRule.PathType != nil && *pathRule.PathType == 
networkingv1.PathTypePrefix {
// As per the specification of Ingress path 
matching rule:
// if the last element of the path is a 
substring of the
-   // last element in request path, it is not a 
match ,e.g. /foo/bar
+   // last element in request path, it is not a 
match, e.g. /foo/bar
// matches /foo/bar/baz, but does not match 
/foo/barbaz.
// While in APISIX, /foo/bar matches both 
/foo/bar/baz and
// /foo/barbaz.
@@ -116,7 +116,7 @@ func (t *translator) translateIngressV1beta1(ing 
*networkingv1beta1.Ingress) ([]
if pathRule.PathType != nil && *pathRule.PathType == 
networkingv1beta1.PathTypePrefix {
// As per the specification of Ingress path 
matching rule:
// if the last element of the path is a 
substring of the
-   // last element in request path, it is not a 
match ,e.g. /foo/bar
+   // last element in request path, it is not a 
match, e.g. /foo/bar
// matches /foo/bar/baz, but does not match 
/foo/barbaz.
// While in APISIX, /foo/bar matches both 
/foo/bar/baz and
// /foo/barbaz.

[GitHub] [apisix] Firstsawyou edited a comment on pull request #2586: chore: `limit-req` plugin code optimization #2448

[GitBox]

Firstsawyou edited a comment on pull request #2586:
URL: https://github.com/apache/apisix/pull/2586#issuecomment-786533638


   > @Firstsawyou Yes, Any pointers to that help me to complete this will be 
highly appreciated.
   
   @tashiya-menuri 
   You need to solve it like this:
   1. You need to merge the master branch code locally.
   2. Delete the following test cases：
   
https://github.com/apache/apisix/blob/a6fbcce2c27f38fb93c94e149fd7fa423c3d5f9d/t/plugin/limit-req.t#L629-L700



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on pull request #2586: chore: `limit-req` plugin code optimization #2448

[GitBox]

Firstsawyou commented on pull request #2586:
URL: https://github.com/apache/apisix/pull/2586#issuecomment-786533638


   > @Firstsawyou Yes, Any pointers to that help me to complete this will be 
highly appreciated.
   
   @tashiya-menuri 
   You need to solve it like this:
   1. 1. You need to merge the master branch code locally.
   2. Delete the following test cases：
   
https://github.com/apache/apisix/blob/a6fbcce2c27f38fb93c94e149fd7fa423c3d5f9d/t/plugin/limit-req.t#L629-L700



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #3680: docs: plugin-develop.md add to view all plugin priorities

[GitBox]

spacewander commented on a change in pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#discussion_r583507500



##
File path: docs/en/latest/plugin-develop.md
##
@@ -103,7 +103,7 @@ local _M = {
 }
 ```
 
-Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin. In addition, plugins with a high priority value will be 
executed first in a given phase (see the definition of `phase` in 
[choose-phase-to-run](#choose-phase-to-run)). For example, the priority of 
example-plugin is 0 and the priority of ip-restriction is 3000. Therefore, the 
ip-restriction plugin will be executed first, then the example-plugin plugin.
+Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin, you can view the priority of all plugins in the 
[t/debug/debug-mode.t](../../../t/debug/debug-mode.t) file. In addition, 
plugins with a high priority value will be executed first in a given phase (see 
the definition of `phase` in [choose-phase-to-run](#choose-phase-to-run)). For 
example, the priority of example-plugin is 0 and the priority of ip-restriction 
is 3000. Therefore, the ip-restriction plugin will be executed first, then the 
example-plugin plugin.

Review comment:
   No. Don't make thing complex. The method is called rarely.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on pull request #3665: fix: cache server picker for nodes without port

[GitBox]

Firstsawyou commented on pull request #3665:
URL: https://github.com/apache/apisix/pull/3665#issuecomment-786517472


   LGTM.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3682: chore: add safe limit to avoid infinite loop caused by bug

[GitBox]

Firstsawyou commented on a change in pull request #3682:
URL: https://github.com/apache/apisix/pull/3682#discussion_r583490823



##
File path: apisix/balancer/roundrobin.lua
##
@@ -18,12 +18,19 @@
 local roundrobin  = require("resty.roundrobin")
 local core = require("apisix.core")
 local nkeys = core.table.nkeys
+local pairs = pairs
 
 
 local _M = {}
 
 
 function _M.new(up_nodes, upstream)
+local safe_limit = 0
+for _, weight in pairs(up_nodes) do
+-- the weight can be zero
+safe_limit = safe_limit + weight + 1

Review comment:
   Thanks, got it.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3680: docs: plugin-develop.md add to view all plugin priorities

[GitBox]

Firstsawyou commented on a change in pull request #3680:
URL: https://github.com/apache/apisix/pull/3680#discussion_r583483511



##
File path: docs/en/latest/plugin-develop.md
##
@@ -103,7 +103,7 @@ local _M = {
 }
 ```
 
-Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin. In addition, plugins with a high priority value will be 
executed first in a given phase (see the definition of `phase` in 
[choose-phase-to-run](#choose-phase-to-run)). For example, the priority of 
example-plugin is 0 and the priority of ip-restriction is 3000. Therefore, the 
ip-restriction plugin will be executed first, then the example-plugin plugin.
+Note : The priority of the new plugin cannot be the same as the priority of 
any existing plugin, you can view the priority of all plugins in the 
[t/debug/debug-mode.t](../../../t/debug/debug-mode.t) file. In addition, 
plugins with a high priority value will be executed first in a given phase (see 
the definition of `phase` in [choose-phase-to-run](#choose-phase-to-run)). For 
example, the priority of example-plugin is 0 and the priority of ip-restriction 
is 3000. Therefore, the ip-restriction plugin will be executed first, then the 
example-plugin plugin.

Review comment:
   Okay, but I think there is too much data obtained through `/v1/schema`. 
We should add a new API interface, such as `/v1/plugins/priority`, this API 
only returns the priority value of all plugins, and they are ordered. What do 
you think?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-helm-chart] jbampton opened a new pull request #35: chore: remove unneeded trailing whitespace

[GitBox]

jbampton opened a new pull request #35:
URL: https://github.com/apache/apisix-helm-chart/pull/35


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-docker] Yiyiyimu closed pull request #143: test: [NOT MERGE] test to build under apisix directory

[GitBox]

Yiyiyimu closed pull request #143:
URL: https://github.com/apache/apisix-docker/pull/143


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] jbampton opened a new pull request #1520: chore: remove whitespace before commas

[GitBox]

jbampton opened a new pull request #1520:
URL: https://github.com/apache/apisix-dashboard/pull/1520


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   ___
   ### Please add the corresponding test cases if necessary.
   
   ___
   ### Backport patches
   - Why need to backport?
   
   - Source branch
   
   - Related commits and pull requests
   
   - Target branch
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org