[GitHub] [apisix] iamayushdas removed a comment on issue #3711: improve screenshots in docs
iamayushdas removed a comment on issue #3711: URL: https://github.com/apache/apisix/issues/3711#issuecomment-789517697 http://139.217.190.60/ - link is not loading @juzhiyuan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas commented on issue #3711: improve screenshots in docs
iamayushdas commented on issue #3711: URL: https://github.com/apache/apisix/issues/3711#issuecomment-789517697 http://139.217.190.60/ - link is not loading @juzhiyuan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] akshitadixit commented on issue #218: support "Edit this page" in docs
akshitadixit commented on issue #218: URL: https://github.com/apache/apisix-website/issues/218#issuecomment-789510192 @qier222 @juzhiyuan I am extremely sorry about taking up your time, but this is currently advanced for a beginner like me. I'm afraid I cannot solve this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] pengtaochang commented on issue #3722: request help: How to set path supports regular matching like nginx
pengtaochang commented on issue #3722: URL: https://github.com/apache/apisix/issues/3722#issuecomment-789509088 Now, I have to change the code of ngx_tpl.lua. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] pengtaochang commented on issue #3722: request help: How to set path supports regular matching like nginx
pengtaochang commented on issue #3722: URL: https://github.com/apache/apisix/issues/3722#issuecomment-789508769 This is a common feature and hopefully can be supported later This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] pengtaochang commented on issue #3722: request help: How to set path supports regular matching like nginx
pengtaochang commented on issue #3722: URL: https://github.com/apache/apisix/issues/3722#issuecomment-789508211 Yes, that's redirect with uri matching parameters. I also read the doc of redirect. It doesn't look like it's supported This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou opened a new issue #3740: bug: the traffic-split plugin is invalid to bind upstream services via upstream_id
Firstsawyou opened a new issue #3740:
URL: https://github.com/apache/apisix/issues/3740
### Issue description
When both the routing and traffic-split plugins use upstream_id to bind
upstream, the request distribution is not accurate.
1、add route and bind plugin
The upstream_id is 1, the response data is 1980, and the upstream_id is 2
the response data is 1981.
```shell
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"create_time":1614743731,
"update_time":1614745342,
"uris":[
"/*"
],
"name":"luarocks_cn",
"methods":[
"GET",
"HEAD",
"POST",
"PUT",
"DELETE",
"OPTIONS",
"PATCH"
],
"vars":[
],
"plugins":{
"proxy-rewrite":{
"disable":false,
"scheme":"http"
},
"traffic-split":{
"disable":false,
"rules":[
{
"match":[
{
"vars":[
[
"uri",
"==",
"/hello"
]
]
}
],
"weighted_upstreams":[
{
"upstream_id":"2"
}
]
}
]
}
},
"upstream_id":"1",
"status":1
}
'
```
2、Test plugin
The vars rule passes:
```shell
$ curl http://127.0.0.1:9080/hello
1981
```
The vars rule failed：
```shell
$ curl http://127.0.0.1:9080/hello12
1980
```
The vars rule passes:
```shell
$ curl http://127.0.0.1:9080/hello
1981
```
The vars rule failed (an exception occurred)：
```shell
$ curl http://127.0.0.1:9080/hello12
1981
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1545: feat: rewrite e2e test(service_test) with ginkgo
nic-chen commented on pull request #1545: URL: https://github.com/apache/apisix-dashboard/pull/1545#issuecomment-789502836 merged. @Jaycean thanks very much. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: rewrite e2e test(service_test) with ginkgo (#1545)
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 845cf99 feat: rewrite e2e test(service_test) with ginkgo (#1545)
845cf99 is described below
commit 845cf9915e1538f356f35f338a5d577747ba14a0
Author: JinChen <36916582+jayc...@users.noreply.github.com>
AuthorDate: Wed Mar 3 15:26:54 2021 +0800
feat: rewrite e2e test(service_test) with ginkgo (#1545)
---
api/test/e2e/service_test.go | 357
api/test/e2enew/service/service_suite_test.go | 36 ++
api/test/e2enew/service/service_test.go | 464 ++
3 files changed, 500 insertions(+), 357 deletions(-)
diff --git a/api/test/e2e/service_test.go b/api/test/e2e/service_test.go
deleted file mode 100644
index 9e03fca..000
--- a/api/test/e2e/service_test.go
+++ /dev/null
@@ -1,357 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package e2e
-
-import (
- "net/http"
- "testing"
- "time"
-
- "github.com/stretchr/testify/assert"
-)
-
-func TestService(t *testing.T) {
- tests := []HttpTestCase{
- {
- Desc:"create service without plugin",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path:"/apisix/admin/services/s1",
- Headers: map[string]string{"Authorization": token},
- Body: `{
- "name": "testservice",
- "upstream": {
- "type": "roundrobin",
- "nodes": [{
- "host": "172.16.238.20",
- "port": 1980,
- "weight": 1
- },
- {
- "host": "172.16.238.20",
- "port": 1981,
- "weight": 2
- },
- {
- "host": "172.16.238.20",
- "port": 1982,
- "weight": 3
- }]
- }
- }`,
- ExpectStatus: http.StatusOK,
- ExpectBody: []string{"\"id\":\"s1\"",
"\"name\":\"testservice\""},
- },
- {
- Desc: "get the service s1",
- Object: ManagerApiExpect(t),
- Method: http.MethodGet,
- Path: "/apisix/admin/services/s1",
- Headers:map[string]string{"Authorization": token},
- ExpectCode: http.StatusOK,
- ExpectBody:
"\"name\":\"testservice\",\"upstream\":{\"nodes\":[{\"host\":\"172.16.238.20\",\"port\":1980,\"weight\":1},{\"host\":\"172.16.238.20\",\"port\":1981,\"weight\":2},{\"host\":\"172.16.238.20\",\"port\":1982,\"weight\":3}],\"type\":\"roundrobin\"}",
- },
- {
- Desc: "create route using the service just created",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path: "/apisix/admin/routes/r1",
- Body: `{
- "uri": "/server_port",
- "service_id": "s1"
- }`,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- Sleep:sleepTime,
- },
- }
- for _, tc := range tests {
-
[GitHub] [apisix-dashboard] nic-chen merged pull request #1545: feat: rewrite e2e test(service_test) with ginkgo
nic-chen merged pull request #1545: URL: https://github.com/apache/apisix-dashboard/pull/1545 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1509: feat: support plugin config
nic-chen commented on a change in pull request #1509:
URL: https://github.com/apache/apisix-dashboard/pull/1509#discussion_r586171786
##
File path: api/test/e2e/label_test.go
##
@@ -302,6 +333,14 @@ func TestLabel(t *testing.T) {
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusOK,
},
+ {
Review comment:
updated.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] dhawal-kamdar commented on pull request #233: fix: Wrong doc url (#231)
dhawal-kamdar commented on pull request #233: URL: https://github.com/apache/apisix-website/pull/233#issuecomment-789498680 Thank you @LiteSun for reviewing and merging my code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] rockXiaofeng commented on issue #3725: request help: about dubbo proxy
rockXiaofeng commented on issue #3725:
URL: https://github.com/apache/apisix/issues/3725#issuecomment-789496262
We tried again not long ago, and the configuration was the same as
yesterday. This time we got 504 Gateway Time-out. The error.log information is
as follows:
```
2021/03/03 15:13:54 [warn] 12168#257902: *79096 multi: multi connection
detach not empty 7FE03F400E10
2021/03/03 15:13:54 [error] 12168#257902: *79095 upstream timed out (60:
Operation timed out) while connecting to upstream, client: ::1, server: ,
subrequest: "/foobar", upstream: "dubbo://127.0.0.1:2"
```
The provider server error log:
```
2021-03-03T15:04:52.251+0800INFOgetty/listener.go:195 got
session:session
{server:TCP_SERVER:7:172.20.216.72:2<->172.20.216.72:62586}, Read Bytes: 0,
Write Bytes: 0, Read Pkgs: 0, Write Pkgs: 0
2021-03-03T15:04:52.251+0800ERROR dubbo/dubbo_codec.go:199
pkg.Unmarshal(len(@data):0) = error:get wrong attachments:
github.com/apache/dubbo-go/protocol/dubbo/impl.unmarshalRequestBody
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] qier222 commented on issue #218: support "Edit this page" in docs
qier222 commented on issue #218: URL: https://github.com/apache/apisix-website/issues/218#issuecomment-789496113 https://v2.docusaurus.io/docs/next/api/plugins/@docusaurus/plugin-content-docs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #275: updated technical architecture of apisix-ingress-controller
codecov-io edited a comment on pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-787224463 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=h1) Report > Merging [#275](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=desc) (a3dbe63) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0c8f306cac9911ababb3c23700ac7ca1efc21833?el=desc) (0c8f306) will **decrease** coverage by `1.65%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #275 +/- ## == - Coverage 53.85% 52.19% -1.66% == Files 33 33 Lines2245 2320 +75 == + Hits 1209 1211 +2 - Misses879 952 +73 Partials 157 157 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | | | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `74.32% <0.00%> (+0.35%)` | :arrow_up: | | [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.48% <0.00%> (+0.48%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=footer). Last update [0c8f306...a3dbe63](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] DHB-liuhong opened a new issue #3739: bug: Ssl certificate domain access issue
DHB-liuhong opened a new issue #3739:
URL: https://github.com/apache/apisix/issues/3739
### Issue description
Why restrict "." in sni/snis?
### Environment
* apisix version (cmd: `apisix version`): 2.1 or master
* OS (cmd: `uname -a`): centos7
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
* etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
* apisix-dashboard version, if have:
### Minimal test code / Steps to reproduce the issue
1. My SSL Certificate Domain Name is "eos-1.cloud.cn", i use apisix to
access s3 interface, i create two buckets bucket01 and bucket.1 in s3, i want
to host stype to(https://bucket01.eos-1.cloud.cn) access this bucket
2. Configure for ssl in apisix
- TEST 1
"snis":["eos-1.cloud.cn","*.eos-1.cloud.cn"]
- TEST 2
"sni":"*.eos-1.cloud.cn"
- TEST 3
"sni":"*eos-1.cloud.cn"
- TEST 3
"sni":"eos-1.cloud.cn"
### What's the actual result? (including assertion message & call stack if
applicable)
- TEST 1-result
[root@kcpn1 ~]# curl -i https://eos-1.cloud.cn
HTTP/1.1 200 OK
[root@kcpn1 ~]# curl -i https://bucket01.eos-1.cloud.cn
HTTP/1.1 200 OK
[root@kcpn1 ~]# curl -i https://bucket.1.eos-1.cloud.cn
**curl: (35) Peer reports it experienced an internal error.**
because:
if str_find(sni_rev, ".", #api_ctx.matched_sni) then
core.log.warn("failed to find any SSL certificate by SNI: ",
sni, " matched SNI: ",
api_ctx.matched_sni:reverse())
return fals
- TEST 2-result
[root@kcpn1 ~]# curl -i https://eos-1.cloud.cn
**curl: (35) Peer reports it experienced an internal error.**
[root@kcpn1 ~]# curl -i https://bucket01.eos-1.cloud.cn
HTTP/1.1 200 OK
[root@kcpn1 ~]# curl -i https://bucket.1.eos-1.cloud.cn
**curl: (35) Peer reports it experienced an internal error.**
- TEST 3-result
[root@kcpn1 ~]# curl -i https://eos-1.cloud.cn
HTTP/1.1 200 OK
[root@kcpn1 ~]# curl -i https://bucket01.eos-1.cloud.cn
**curl: (35) Peer reports it experienced an internal error.**
[root@kcpn1 ~]# curl -i https://bucket.1.eos-1.cloud.cn
**curl: (35) Peer reports it experienced an internal error.**
- TEST 4-result
[root@kcpn1 ~]# curl -i https://eos-1.cloud.cn
HTTP/1.1 200 OK
[root@kcpn1 ~]# curl -i https://bucket01.eos-1.cloud.cn
**curl: (35) Peer reports it experienced an internal error.**
[root@kcpn1 ~]# curl -i https://bucket.1.eos-1.cloud.cn
**curl: (35) Peer reports it experienced an internal error.**
**But i use "sni":"*eos-1.cloud.cn" is good in apisix 1.2**
### What's the expected result?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #275: updated technical architecture of apisix-ingress-controller
codecov-io edited a comment on pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-787224463 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=h1) Report > Merging [#275](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=desc) (a3dbe63) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0c8f306cac9911ababb3c23700ac7ca1efc21833?el=desc) (0c8f306) will **decrease** coverage by `1.67%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #275 +/- ## == - Coverage 53.85% 52.17% -1.68% == Files 33 32 -1 Lines2245 2319 +74 == + Hits 1209 1210 +1 - Misses879 952 +73 Partials 157 157 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | | | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `74.32% <0.00%> (+0.35%)` | :arrow_up: | | [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.48% <0.00%> (+0.48%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=footer). Last update [0c8f306...a3dbe63](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new issue #277: update deployment docs to use https://charts.apiseven.com
tokers opened a new issue #277:
URL: https://github.com/apache/apisix-ingress-controller/issues/277
Now we have a helm charts repository https://charts.apiseven.com, while in
all deployment related docs like azure.md, aws.md, we still use the charts in
apisix-helm-chart to install APISIX and apisix-ingress-controller, we should
change to use the online repository.
We can change the above to:
```shell
cd /path/to/apisix-helm-chart
helm repo add bitnami https://charts.bitnami.com/bitnami
helm repo add apisix https://charts.apiseven.com
# Use `hem search repo apisix` to search charts about apisix
helm repo update
helm install apisix apisix/apisix \
--set gateway.type=LoadBalancer \
--set allow.ipList="{0.0.0.0/0}" \
--namespace ingress-apisix
kubectl get service --namespace ingress-apisix
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto generate and check for rpm package
Yiyiyimu commented on a change in pull request #3621: URL: https://github.com/apache/apisix/pull/3621#discussion_r586159933 ## File path: .github/workflows/centos7-ci.yml ## @@ -2,11 +2,9 @@ name: CI Centos7 on: push: -branches: - - master +branches: [master, 'release/**'] pull_request: -branches: - - master +branches: [master] Review comment: BTW, your change request still blocks the merging 🤣 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3738: test: improve the unique request id check
spacewander opened a new pull request #3738: URL: https://github.com/apache/apisix/pull/3738 Fix #3734 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto generate and check for rpm package
Yiyiyimu commented on a change in pull request #3621: URL: https://github.com/apache/apisix/pull/3621#discussion_r586158142 ## File path: .github/workflows/centos7-ci.yml ## @@ -2,11 +2,9 @@ name: CI Centos7 on: push: -branches: - - master +branches: [master, 'release/**'] pull_request: -branches: - - master +branches: [master] Review comment: Yes and relevant discussion is in #3726. Welcome have some discussion~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #256: Migrate charts to repo apisix-helm-charts
tokers commented on issue #256: URL: https://github.com/apache/apisix-ingress-controller/issues/256#issuecomment-789481035 @Junnplus Thanks for your contribution. Now it's time to close it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers closed issue #256: Migrate charts to repo apisix-helm-charts
tokers closed issue #256: URL: https://github.com/apache/apisix-ingress-controller/issues/256 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers closed issue #241: Support Kubernetes Ingress resources
tokers closed issue #241: URL: https://github.com/apache/apisix-ingress-controller/issues/241 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #241: Support Kubernetes Ingress resources
tokers commented on issue #241: URL: https://github.com/apache/apisix-ingress-controller/issues/241#issuecomment-789480270 Solved by https://github.com/apache/apisix-ingress-controller/pull/250 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] rockXiaofeng edited a comment on issue #3725: request help: about dubbo proxy
rockXiaofeng edited a comment on issue #3725: URL: https://github.com/apache/apisix/issues/3725#issuecomment-789479388 > Strange. There is definitely a `set $dubbo_service_name '';` in the nginx.conf... > The generated configuration is almost mine but I can't reproduce it. Maybe you can try to use dubbo-go's example to start the provider ? (helloworld/dubbo/go-server/app (http://github.com/dubbogo/dubbo-samples) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] rockXiaofeng commented on issue #3725: request help: about dubbo proxy
rockXiaofeng commented on issue #3725: URL: https://github.com/apache/apisix/issues/3725#issuecomment-789479388 > Strange. There is definitely a `set $dubbo_service_name '';` in the nginx.conf... > The generated configuration is almost mine but I can't reproduce it. Maybe you can try to use dubbo-go's example to start the provider ? (helloworld/dubbo/go-server/app (http://github.com/dubbogo/dubbo-samples) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #275: updated technical architecture of apisix-ingress-controller
tokers commented on a change in pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#discussion_r586155688 ## File path: README.md ## @@ -29,7 +29,7 @@ All configurations in `apisix-ingress-controller` are defined with Kubernetes CR The technical architecture of `apisix-ingress-controller`: - + Review comment: We are writing them and will push them to GitHub as soon as possible :) Also, Would you like to use this [image](https://user-images.githubusercontent.com/6814606/109374178-521b4300-78ee-11eb-8315-4da896383f53.png) to replace the current one? It's more clear (though it's a high level interpretation). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #276: bug: Service cannot be dynamically aware of changes to the service when it is deleted and rebuilt again
tokers commented on issue #276: URL: https://github.com/apache/apisix-ingress-controller/issues/276#issuecomment-789477905 @pioneer-hash From the error log, we can see the `10.96.0.10:53` reporting error ahout the DNS server misbehaving, have you configured the CoreDNS correctly? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3726: [Discuss] standardize release guide & branch/tag relations
tokers commented on issue #3726: URL: https://github.com/apache/apisix/issues/3726#issuecomment-789477321 I think it's a clear way, agree it + 1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3726: [Discuss] standardize release guide & branch/tag relations
tokers commented on issue #3726: URL: https://github.com/apache/apisix/issues/3726#issuecomment-789477103 Personally, I prefer the `release/` branch, it has significant difference with tag, while `va.b.c` is more confused. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun opened a new issue #1548: Clicking on a mask while editing a plugin does not allow the drawer to be closed
LiteSun opened a new issue #1548: URL: https://github.com/apache/apisix-dashboard/issues/1548 # Feature request Users may click on the mask by mistake when editing complex plugins, and the drawer will close after clicking on the mask, resulting in the loss of data edited by the user.  ## Describe the solution you'd like Clicking on the mask does not allow the drawer to be closed We can set `maskClosable ` to `false` to do this. Refer link: https://ant.design/components/drawer/#API cc @tokers This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1509: feat: support plugin config
tokers commented on a change in pull request #1509:
URL: https://github.com/apache/apisix-dashboard/pull/1509#discussion_r586151927
##
File path: api/test/e2e/label_test.go
##
@@ -302,6 +333,14 @@ func TestLabel(t *testing.T) {
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusOK,
},
+ {
Review comment:
Can `plugin_config` be updated? If so, we should also add update test
suites.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] qier222 commented on a change in pull request #234: docs: added Integrate with Projects documentations
qier222 commented on a change in pull request #234: URL: https://github.com/apache/apisix-website/pull/234#discussion_r586149965 ## File path: website/docs/general/integrate-with-project-docs.md ## @@ -0,0 +1,80 @@ +--- +id: integrate-with-project-docs +title: Integrate with Project documentations +--- + +## docs directory structure + +Put all Markdown files into the latest directory + +``` +/docs +├── assets # 存放静态文件 +│ ├── images +│ │ ├── x.png +│ └── other +│ └── x.xxx +├── en +│ └── latest +│ ├── doc1.md +│ ├── folder +│ │ └── doc2.md +│ │ └── folder2 +│ │ └── doc3.md +│ └── config.json +├── es +│ └── latest +│ └── ... +└── zh +└── latest +└── ... +``` + +## Configuration file + +This file is located in /docs//latest/config.json, where locale is locale codes, please refer to https://www.science.co.il/language/Locale-codes.php, locale is all lowercase. Don't forget to remove the comment after copying JSON. + +More information about sidebar can be found at https://v2.docusaurus.io/docs/next/sidebar + +```json Review comment: Maybe we should use jsonc instead of json since these codes have comments? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3722: request help: How to set path supports regular matching like nginx
tokers commented on issue #3722: URL: https://github.com/apache/apisix/issues/3722#issuecomment-789473173 > I have used the proxy-rewrite plugin. It can redirect to right page in apisix and return right html file. But, the client Browser need to redirect to another path so that display correctly. I have read the doc of response-rewrite, but I still can't find how to get regular value in uri. That's not rewrite, that's redirect. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3727: request help: How do I know which node the response came from
tokers commented on issue #3727: URL: https://github.com/apache/apisix/issues/3727#issuecomment-789472440 > > I mean the upstream info added in the response, not in other log, maybe we need a new plugin, modify the response like `response-rewrite`. > > Got it. I think there is no need to add a new plugin, it should be implemented in the response-rewrite plugin. > @spacewander What do you think? These headers can be controlled in the core. It's not related with response-rewrite. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #234: docs: added Integrate with Projects documentations
juzhiyuan commented on a change in pull request #234: URL: https://github.com/apache/apisix-website/pull/234#discussion_r586149599 ## File path: website/docs/general/integrate-with-project-docs.md ## @@ -0,0 +1,80 @@ +--- +id: integrate-with-project-docs +title: Integrate with Project documentations +--- + +## docs directory structure + +Put all Markdown files into the latest directory + +``` +/docs +├── assets # 存放静态文件 +│ ├── images +│ │ ├── x.png +│ └── other +│ └── x.xxx +├── en +│ └── latest +│ ├── doc1.md +│ ├── folder +│ │ └── doc2.md +│ │ └── folder2 +│ │ └── doc3.md +│ └── config.json +├── es +│ └── latest +│ └── ... +└── zh +└── latest +└── ... +``` + +## Configuration file + +This file is located in /docs//latest/config.json, where locale is locale codes, please refer to https://www.science.co.il/language/Locale-codes.php, locale is all lowercase. Don't forget to remove the comment after copying JSON. Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] qier222 commented on a change in pull request #234: docs: added Integrate with Projects documentations
qier222 commented on a change in pull request #234: URL: https://github.com/apache/apisix-website/pull/234#discussion_r586149010 ## File path: website/docs/general/integrate-with-project-docs.md ## @@ -0,0 +1,80 @@ +--- +id: integrate-with-project-docs +title: Integrate with Project documentations +--- + +## docs directory structure + +Put all Markdown files into the latest directory + +``` +/docs +├── assets # 存放静态文件 +│ ├── images +│ │ ├── x.png +│ └── other +│ └── x.xxx +├── en +│ └── latest +│ ├── doc1.md +│ ├── folder +│ │ └── doc2.md +│ │ └── folder2 +│ │ └── doc3.md +│ └── config.json +├── es +│ └── latest +│ └── ... +└── zh +└── latest +└── ... +``` + +## Configuration file + +This file is located in /docs//latest/config.json, where locale is locale codes, please refer to https://www.science.co.il/language/Locale-codes.php, locale is all lowercase. Don't forget to remove the comment after copying JSON. Review comment: Why not wrap /docs//latest/config.json with ``? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #234: docs: added Integrate with Projects documentations
juzhiyuan commented on pull request #234: URL: https://github.com/apache/apisix-website/pull/234#issuecomment-789471292  Netlify is down due to unknown reasons 🤔 ignore it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #234: docs: added Integrate with Projects documentations
juzhiyuan commented on pull request #234: URL: https://github.com/apache/apisix-website/pull/234#issuecomment-789471196 good catch, just updated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] LiteSun closed issue #231: the doc url is wrong
LiteSun closed issue #231: URL: https://github.com/apache/apisix-website/issues/231 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] LiteSun merged pull request #233: fix: Wrong doc url (#231)
LiteSun merged pull request #233: URL: https://github.com/apache/apisix-website/pull/233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated (f3580d3 -> 22bb459)
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from f3580d3 docs: added blog `Get Front-End Test Coverage with Cypress` (#227) add 22bb459 fix: Wrong doc url (#231) No new revisions were added by this update. Summary of changes: website/src/pages/help.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[GitHub] [apisix-website] qier222 commented on pull request #234: docs: added Integrate with Projects documentations
qier222 commented on pull request #234: URL: https://github.com/apache/apisix-website/pull/234#issuecomment-789470420 The docs directory structure is incorrect   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1545: feat: rewrite e2e test(service_test) with ginkgo
Jaycean commented on a change in pull request #1545:
URL: https://github.com/apache/apisix-dashboard/pull/1545#discussion_r586147851
##
File path: api/test/e2enew/service/service_test.go
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package service
+
+import (
+ "encoding/json"
+ "net/http"
+ "time"
+
+ "github.com/onsi/ginkgo"
+ "github.com/stretchr/testify/assert"
+
+ "e2enew/base"
+)
+
+var _ = ginkgo.Describe("create service without plugin", func() {
+ ginkgo.It("create service without plugin", func() {
+ t := ginkgo.GinkgoT()
+ var createServiceBody map[string]interface{} =
map[string]interface{}{
+ "name": "testservice",
+ "upstream": map[string]interface{}{
+ "type": "roundrobin",
+ "nodes": []map[string]interface{}{
+ {
+ "host": base.UpstreamIp,
+ "port": 1980,
+ "weight": 1,
+ },
+ {
+ "host": base.UpstreamIp,
+ "port": 1981,
+ "weight": 2,
+ },
+ {
+ "host": base.UpstreamIp,
+ "port": 1982,
+ "weight": 3,
+ },
+ },
+ },
+ }
+ _createServiceBody, err := json.Marshal(createServiceBody)
+ assert.Nil(t, err)
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/services/s1",
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ Body: string(_createServiceBody),
+ ExpectStatus: http.StatusOK,
+ ExpectBody: []string{"\"id\":\"s1\"",
"\"name\":\"testservice\""},
+ })
+ })
+ ginkgo.It("get the service s1", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodGet,
+ Path: "/apisix/admin/services/s1",
+ Headers:map[string]string{"Authorization":
base.GetToken()},
+ ExpectCode: http.StatusOK,
+ ExpectBody:
"\"name\":\"testservice\",\"upstream\":{\"nodes\":[{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1980,\"weight\":1},{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1981,\"weight\":2},{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1982,\"weight\":3}],\"type\":\"roundrobin\"}",
+ })
+ })
+ ginkgo.It("create route using the service just created", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/routes/r1",
+ Body: `{
+ "uri": "/server_port",
+ "service_id": "s1"
+ }`,
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ Sleep:base.SleepTime,
+ })
+ })
+ ginkgo.It("batch test /server_port api", func() {
+ t := ginkgo.GinkgoT()
+ time.Sleep(time.Duration(500) * time.Millisecond)
+ res := base.BatchTestServerP
[GitHub] [apisix-website] juzhiyuan commented on issue #218: support "Edit this page" in docs
juzhiyuan commented on issue #218: URL: https://github.com/apache/apisix-website/issues/218#issuecomment-789470207 ok, @akshitadixit, could you please have a Google search about `Edit this page in docusaurus` first? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #220: improve Subscribe Mailing-list more clear
juzhiyuan commented on issue #220: URL: https://github.com/apache/apisix-website/issues/220#issuecomment-789469790 > two primary buttons ya, two primary buttons would lead users to the confusion 🤔 we may keep one primary and a history mailing list link? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #234: docs: added Integrate with Projects documentations
juzhiyuan commented on pull request #234: URL: https://github.com/apache/apisix-website/pull/234#issuecomment-789467698 cc @qier222 to review :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers closed issue #248: discuss: ApisixRoute change struct
tokers closed issue #248: URL: https://github.com/apache/apisix-ingress-controller/issues/248 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #262: feat: ApisixRoute v2alpha1
tokers merged pull request #262: URL: https://github.com/apache/apisix-ingress-controller/pull/262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: feat: ApisixRoute v2alpha1 (#262)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new c65cc23 feat: ApisixRoute v2alpha1 (#262)
c65cc23 is described below
commit c65cc2384a68b3bd17f886ee2c03e72aafea1206
Author: Alex Zhang
AuthorDate: Wed Mar 3 14:08:06 2021 +0800
feat: ApisixRoute v2alpha1 (#262)
---
cmd/ingress/ingress.go | 1 +
conf/config-default.yaml | 3 +
go.mod | 3 +-
go.sum | 56 ++-
pkg/config/config.go | 30 +-
pkg/config/config_test.go | 13 +-
pkg/ingress/controller/apisix_route.go | 420 ++---
pkg/ingress/controller/apisix_upstream.go | 10 +-
pkg/ingress/controller/controller.go | 34 +-
pkg/ingress/controller/ingress.go | 1 +
pkg/kube/apisix/apis/config/v2alpha1/doc.go| 18 +
pkg/kube/apisix/apis/config/v2alpha1/register.go | 50 +++
pkg/kube/apisix/apis/config/v2alpha1/types.go | 163
.../apis/config/v2alpha1/zz_generated.deepcopy.go | 256 +
.../apisix/client/clientset/versioned/clientset.go | 16 +-
.../versioned/fake/clientset_generated.go | 7 +
.../client/clientset/versioned/fake/register.go| 2 +
.../client/clientset/versioned/scheme/register.go | 2 +
.../versioned/typed/config/v2alpha1/apisixroute.go | 178 +
.../typed/config/v2alpha1/config_client.go | 89 +
.../versioned/typed/config/v2alpha1/doc.go | 20 +
.../versioned/typed/config/v2alpha1/fake/doc.go| 20 +
.../typed/config/v2alpha1/fake/fake_apisixroute.go | 130 +++
.../config/v2alpha1/fake/fake_config_client.go | 40 ++
.../typed/config/v2alpha1/generated_expansion.go | 21 ++
.../informers/externalversions/config/interface.go | 8 +
.../config/v2alpha1/apisixroute.go | 90 +
.../config/{ => v2alpha1}/interface.go | 19 +-
.../client/informers/externalversions/generic.go | 5 +
.../client/listers/config/v2alpha1/apisixroute.go | 99 +
.../listers/config/v2alpha1/expansion_generated.go | 27 ++
pkg/kube/apisix_route.go | 175 +
pkg/kube/translation/apisix_route.go | 117 ++
pkg/kube/translation/translator.go | 4 +
pkg/types/apisix/v1/types.go | 19 +
pkg/types/apisix/v1/zz_generated.deepcopy.go | 10 +
samples/deploy/crd/v1beta1/ApisixRoute.yaml| 3 +
test/e2e/endpoints/endpoints.go| 2 +-
test/e2e/go.mod| 4 +-
test/e2e/go.sum| 19 +
test/e2e/ingress/resourcepushing.go| 48 ++-
test/e2e/scaffold/ingress.go | 4 +-
test/e2e/scaffold/scaffold.go | 6 +
43 files changed, 1954 insertions(+), 288 deletions(-)
diff --git a/cmd/ingress/ingress.go b/cmd/ingress/ingress.go
index d43f1cd..381024f 100644
--- a/cmd/ingress/ingress.go
+++ b/cmd/ingress/ingress.go
@@ -139,6 +139,7 @@ the apisix cluster and others are created`,
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.IngressClass,
"ingress-class", config.IngressClass, "the class of an Ingress object is set
using the field IngressClassName in Kubernetes clusters version v1.18.0 or
higher or the annotation \"kubernetes.io/ingress.class\" (deprecated)")
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ElectionID,
"election-id", config.IngressAPISIXLeader, "election id used for campaign the
controller leader")
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.IngressVersion,
"ingress-version", config.IngressNetworkingV1, "the supported ingress api group
version, can be \"networking/v1beta1\" or \"networking/v1\" (for Kubernetes
version v1.19.0 or higher)")
+ cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ApisixRouteVersion,
"apisix-route-version", config.ApisixRouteV2alpha1, "the supported apisixroute
api group version, can be \"apisix.apache.org/v1\" or
\"apisix.apache.org/v2alpha1\"")
cmd.PersistentFlags().StringVar(&cfg.APISIX.BaseURL, "apisix-base-url",
"", "the base URL for APISIX admin api / manager api")
cmd.PersistentFlags().StringVar(&cfg.APISIX.AdminKey,
"apisix-admin-key", "", "admin key used for the authorization of APISIX admin
api / manager api")
diff --git a/conf/config-default.yaml b/conf/config-default.yaml
index b5d81da..73d1866 100644
--- a/conf/config-default.yaml
+++ b/conf/config-default.yaml
@@ -51,6 +51,9 @@ kubernetes:
# or "networking/v1" (for Kubernetes
version v1.19.0 or high
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #262: feat: ApisixRoute v2alpha1
tokers commented on a change in pull request #262:
URL:
https://github.com/apache/apisix-ingress-controller/pull/262#discussion_r586137386
##
File path: test/e2e/ingress/resourcepushing.go
##
@@ -64,19 +76,21 @@ spec:
ginkgo.It("create and then remove", func() {
backendSvc, backendSvcPort := s.DefaultHTTPBackend()
apisixRoute := fmt.Sprintf(`
-apiVersion: apisix.apache.org/v1
+apiVersion: apisix.apache.org/v2alpha1
kind: ApisixRoute
metadata:
name: httpbin-route
spec:
- rules:
- - host: httpbin.com
-http:
+ http:
+ - name: rule1
+match:
+ hosts:
+ - httpbin.com
paths:
- - backend:
- serviceName: %s
- servicePort: %d
-path: /ip
+ - /ip
+backend:
+ serviceName: %s
+ servicePort: %d
Review comment:
OK.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1509: feat: support plugin config
codecov-io edited a comment on pull request #1509: URL: https://github.com/apache/apisix-dashboard/pull/1509#issuecomment-787705132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1545: feat: rewrite e2e test(service_test) with ginkgo
codecov-io edited a comment on pull request #1545: URL: https://github.com/apache/apisix-dashboard/pull/1545#issuecomment-789059742 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1545?src=pr&el=h1) Report > Merging [#1545](https://codecov.io/gh/apache/apisix-dashboard/pull/1545?src=pr&el=desc) (69cef16) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/76e0e05c86b83dedf4afa7d3fcc7a00f320453e7?el=desc) (76e0e05) will **increase** coverage by `2.76%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1545?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1545 +/- ## == + Coverage 68.96% 71.73% +2.76% == Files 48 81 +33 Lines3055 2176 -879 Branches0 549 +549 == - Hits 2107 1561 -546 + Misses708 615 -93 + Partials 2400 -240 ``` | Flag | Coverage Δ | | |---|---|---| | frontend-e2e-test | `71.73% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1545?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1545/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | | | [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1545/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1545/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | | | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1545/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1545/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1545/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | | | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1545/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | | | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1545/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1545/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1545/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | | | ... and [119 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1545/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1545?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1545?src=pr&el=footer). Last update [76e0e05...69cef16](https://codecov.io/gh/apache/apisix-dashboard/pull/1545?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1509: feat: support plugin config
codecov-io edited a comment on pull request #1509: URL: https://github.com/apache/apisix-dashboard/pull/1509#issuecomment-787705132 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=h1) Report > Merging [#1509](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=desc) (25ea754) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/2dbd204d1f42fb9eb425b4cdc7f190adedfc667e?el=desc) (2dbd204) will **decrease** coverage by `31.84%`. > The diff coverage is `58.26%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1509 +/- ## === - Coverage 70.12% 38.27% -31.85% === Files 129 49 -80 Lines5231 3164 -2067 Branches 5490 -549 === - Hits 3668 1211 -2457 - Misses 1323 1699 +376 - Partials 240 254 +14 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `38.27% <58.26%> (+4.69%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <ø> (-25.00%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <54.54%> (-71.76%)` | :arrow_down: | | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | `56.38% <56.38%> (ø)` | | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `59.81% <77.77%> (-14.68%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `77.14% <100.00%> (-8.16%)` | :arrow_down: | | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `21.27% <0.00%> (-70.22%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | ... and [107 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=footer). Last update [2dbd204...25ea754](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message,
[GitHub] [apisix-website] juzhiyuan commented on issue #229: improve the description for users to join Slack
juzhiyuan commented on issue #229: URL: https://github.com/apache/apisix-website/issues/229#issuecomment-789458861 @ashwindevx Hi, could we add a mouseover tip for it? or add some text description? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] qier222 commented on issue #218: support "Edit this page" in docs
qier222 commented on issue #218: URL: https://github.com/apache/apisix-website/issues/218#issuecomment-789458057 I prefer to add "Edit this page" on every docs page, just like docusaurus. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu closed pull request #145: [DO NOT MERGE] need local image for local test
Yiyiyimu closed pull request #145: URL: https://github.com/apache/apisix-docker/pull/145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Ylikj opened a new pull request #234: Create how-to-add-docs.md
Ylikj opened a new pull request #234: URL: https://github.com/apache/apisix-website/pull/234 Fixes: #[Add issue number here] Changes: Screenshots of the change: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3625: ci: chaos test need to build image from source
spacewander closed issue #3625: URL: https://github.com/apache/apisix/issues/3625 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3675: ci: run chaos test on HEAD of PR
spacewander merged pull request #3675: URL: https://github.com/apache/apisix/pull/3675 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: ci: run chaos test on HEAD of PR (#3675)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new fc7a466 ci: run chaos test on HEAD of PR (#3675)
fc7a466 is described below
commit fc7a4666814fb9de96f7120a347cdd5512b0eed6
Author: Shuyang Wu
AuthorDate: Wed Mar 3 13:40:33 2021 +0800
ci: run chaos test on HEAD of PR (#3675)
---
.github/workflows/chaos.yml | 4
t/chaos/setup_chaos_utils.sh | 1 +
2 files changed, 5 insertions(+)
diff --git a/.github/workflows/chaos.yml b/.github/workflows/chaos.yml
index 8712a60..e4447b2 100644
--- a/.github/workflows/chaos.yml
+++ b/.github/workflows/chaos.yml
@@ -15,6 +15,10 @@ jobs:
- name: Creating minikube cluster
run: |
bash ./t/chaos/setup_chaos_utils.sh start_minikube
+ wget
https://raw.githubusercontent.com/apache/apisix-docker/master/alpine-local/Dockerfile
+ mkdir logs
+ docker build -t apache/apisix:alpine-local --build-arg APISIX_PATH=.
-f Dockerfile .
+ minikube cache add apache/apisix:alpine-local -v 7 --alsologtostderr
- name: Print cluster information
run: |
diff --git a/t/chaos/setup_chaos_utils.sh b/t/chaos/setup_chaos_utils.sh
index 7a250b8..7584dd4 100755
--- a/t/chaos/setup_chaos_utils.sh
+++ b/t/chaos/setup_chaos_utils.sh
@@ -36,6 +36,7 @@ modify_config() {
etcd:
host:
- \"http://etcd-cluster-client.default.svc.cluster.local:2379\"; " >
./conf/config.yaml
+sed -i -e 's/apisix:latest/apisix:alpine-local/g'
kubernetes/deployment.yaml
}
ensure_pods_ready() {
[GitHub] [apisix-website] qier222 commented on issue #220: improve Subscribe Mailing-list more clear
qier222 commented on issue #220: URL: https://github.com/apache/apisix-website/issues/220#issuecomment-789432404 I think the history mails should be placed inside Subscribe Guide page. The UI is fine, but the UX of the buttons is not good enough. You use two primary buttons, when users see this, they will think "which button should I click?", It makes users feel confused. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1509: feat: support plugin config
codecov-io edited a comment on pull request #1509: URL: https://github.com/apache/apisix-dashboard/pull/1509#issuecomment-787705132 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=h1) Report > Merging [#1509](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=desc) (b3644c8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/2dbd204d1f42fb9eb425b4cdc7f190adedfc667e?el=desc) (2dbd204) will **decrease** coverage by `18.43%`. > The diff coverage is `50.87%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1509 +/- ## === - Coverage 70.12% 51.68% -18.44% === Files 129 40 -89 Lines5231 2707 -2524 Branches 5490 -549 === - Hits 3668 1399 -2269 + Misses 1323 1127 -196 + Partials 240 181 -59 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.68% <50.87%> (+0.04%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.49%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `70.75% <45.45%> (-10.44%)` | :arrow_down: | | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | `56.38% <56.38%> (ø)` | | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | ... and [114 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1509/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=footer). Last update [2dbd204...b3644c8](https://codecov.io/gh/apache/apisix-dashboard/pull/1509?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] qier222 commented on pull request #214: fix: additional increase in button size due to #213
qier222 commented on pull request #214: URL: https://github.com/apache/apisix-website/pull/214#issuecomment-789429091 In my opinion, use full-width buttons in this hero section will improve 20% of UI, not use full-width buttons will improve 3% of UX, I won't trade 20% UI improvement for 3% UX improvement. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] qier222 commented on issue #229: improve the description for users to join Slack
qier222 commented on issue #229: URL: https://github.com/apache/apisix-website/issues/229#issuecomment-789428087 I haven't used Slack, I can't help you with this right now, sorry. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3725: request help: about dubbo proxy
spacewander commented on issue #3725: URL: https://github.com/apache/apisix/issues/3725#issuecomment-789417299 Strange. There is definitely a `set $dubbo_service_name '';` in the nginx.conf... The generated configuration is almost mine but I can't reproduce it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] ashwindevx commented on issue #229: improve the description for users to join Slack
ashwindevx commented on issue #229: URL: https://github.com/apache/apisix-website/issues/229#issuecomment-789417142 @qier222 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #3718: fix: fail to run `make deps` on macOS
nic-chen commented on pull request #3718: URL: https://github.com/apache/apisix/pull/3718#issuecomment-789414966 will update later This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1547: show the running step detail info about this API
nic-chen commented on issue #1547: URL: https://github.com/apache/apisix-dashboard/issues/1547#issuecomment-789414711 I think we could consider allowing debug routes that status is 0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3737: refactor: extract desc definition from the schema
spacewander opened a new pull request #3737: URL: https://github.com/apache/apisix/pull/3737 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1545: feat: rewrite e2e test(service_test) with ginkgo
nic-chen commented on a change in pull request #1545:
URL: https://github.com/apache/apisix-dashboard/pull/1545#discussion_r586092998
##
File path: api/test/e2enew/service/service_test.go
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package service
+
+import (
+ "encoding/json"
+ "net/http"
+ "time"
+
+ "github.com/onsi/ginkgo"
+ "github.com/stretchr/testify/assert"
+
+ "e2enew/base"
+)
+
+var _ = ginkgo.Describe("create service without plugin", func() {
+ ginkgo.It("create service without plugin", func() {
+ t := ginkgo.GinkgoT()
+ var createServiceBody map[string]interface{} =
map[string]interface{}{
+ "name": "testservice",
+ "upstream": map[string]interface{}{
+ "type": "roundrobin",
+ "nodes": []map[string]interface{}{
+ {
+ "host": base.UpstreamIp,
+ "port": 1980,
+ "weight": 1,
+ },
+ {
+ "host": base.UpstreamIp,
+ "port": 1981,
+ "weight": 2,
+ },
+ {
+ "host": base.UpstreamIp,
+ "port": 1982,
+ "weight": 3,
+ },
+ },
+ },
+ }
+ _createServiceBody, err := json.Marshal(createServiceBody)
+ assert.Nil(t, err)
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/services/s1",
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ Body: string(_createServiceBody),
+ ExpectStatus: http.StatusOK,
+ ExpectBody: []string{"\"id\":\"s1\"",
"\"name\":\"testservice\""},
+ })
+ })
+ ginkgo.It("get the service s1", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodGet,
+ Path: "/apisix/admin/services/s1",
+ Headers:map[string]string{"Authorization":
base.GetToken()},
+ ExpectCode: http.StatusOK,
+ ExpectBody:
"\"name\":\"testservice\",\"upstream\":{\"nodes\":[{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1980,\"weight\":1},{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1981,\"weight\":2},{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1982,\"weight\":3}],\"type\":\"roundrobin\"}",
+ })
+ })
+ ginkgo.It("create route using the service just created", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/routes/r1",
+ Body: `{
+ "uri": "/server_port",
+ "service_id": "s1"
+ }`,
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ Sleep:base.SleepTime,
+ })
+ })
+ ginkgo.It("batch test /server_port api", func() {
+ t := ginkgo.GinkgoT()
+ time.Sleep(time.Duration(500) * time.Millisecond)
+ res := base.BatchTestServer
[GitHub] [apisix] juzhiyuan closed issue #1533: [discuss] need a way to debug API (router rules)
juzhiyuan closed issue #1533: URL: https://github.com/apache/apisix/issues/1533 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1545: feat: rewrite e2e test(service_test) with ginkgo
nic-chen commented on a change in pull request #1545:
URL: https://github.com/apache/apisix-dashboard/pull/1545#discussion_r586092845
##
File path: api/test/e2enew/service/service_test.go
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package service
+
+import (
+ "encoding/json"
+ "net/http"
+ "time"
+
+ "github.com/onsi/ginkgo"
+ "github.com/stretchr/testify/assert"
+
+ "e2enew/base"
+)
+
+var _ = ginkgo.Describe("create service without plugin", func() {
+ ginkgo.It("create service without plugin", func() {
+ t := ginkgo.GinkgoT()
+ var createServiceBody map[string]interface{} =
map[string]interface{}{
+ "name": "testservice",
+ "upstream": map[string]interface{}{
+ "type": "roundrobin",
+ "nodes": []map[string]interface{}{
+ {
+ "host": base.UpstreamIp,
+ "port": 1980,
+ "weight": 1,
+ },
+ {
+ "host": base.UpstreamIp,
+ "port": 1981,
+ "weight": 2,
+ },
+ {
+ "host": base.UpstreamIp,
+ "port": 1982,
+ "weight": 3,
+ },
+ },
+ },
+ }
+ _createServiceBody, err := json.Marshal(createServiceBody)
+ assert.Nil(t, err)
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/services/s1",
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ Body: string(_createServiceBody),
+ ExpectStatus: http.StatusOK,
+ ExpectBody: []string{"\"id\":\"s1\"",
"\"name\":\"testservice\""},
+ })
+ })
+ ginkgo.It("get the service s1", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodGet,
+ Path: "/apisix/admin/services/s1",
+ Headers:map[string]string{"Authorization":
base.GetToken()},
+ ExpectCode: http.StatusOK,
+ ExpectBody:
"\"name\":\"testservice\",\"upstream\":{\"nodes\":[{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1980,\"weight\":1},{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1981,\"weight\":2},{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1982,\"weight\":3}],\"type\":\"roundrobin\"}",
+ })
+ })
+ ginkgo.It("create route using the service just created", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/routes/r1",
+ Body: `{
+ "uri": "/server_port",
+ "service_id": "s1"
+ }`,
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ Sleep:base.SleepTime,
+ })
+ })
+ ginkgo.It("batch test /server_port api", func() {
+ t := ginkgo.GinkgoT()
+ time.Sleep(time.Duration(500) * time.Millisecond)
+ res := base.BatchTestServer
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1545: feat: rewrite e2e test(service_test) with ginkgo
nic-chen commented on a change in pull request #1545:
URL: https://github.com/apache/apisix-dashboard/pull/1545#discussion_r586092645
##
File path: api/test/e2enew/service/service_test.go
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package service
+
+import (
+ "encoding/json"
+ "net/http"
+ "time"
+
+ "github.com/onsi/ginkgo"
+ "github.com/stretchr/testify/assert"
+
+ "e2enew/base"
+)
+
+var _ = ginkgo.Describe("create service without plugin", func() {
+ ginkgo.It("create service without plugin", func() {
+ t := ginkgo.GinkgoT()
+ var createServiceBody map[string]interface{} =
map[string]interface{}{
+ "name": "testservice",
+ "upstream": map[string]interface{}{
+ "type": "roundrobin",
+ "nodes": []map[string]interface{}{
+ {
+ "host": base.UpstreamIp,
+ "port": 1980,
+ "weight": 1,
+ },
+ {
+ "host": base.UpstreamIp,
+ "port": 1981,
+ "weight": 2,
+ },
+ {
+ "host": base.UpstreamIp,
+ "port": 1982,
+ "weight": 3,
+ },
+ },
+ },
+ }
+ _createServiceBody, err := json.Marshal(createServiceBody)
+ assert.Nil(t, err)
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/services/s1",
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ Body: string(_createServiceBody),
+ ExpectStatus: http.StatusOK,
+ ExpectBody: []string{"\"id\":\"s1\"",
"\"name\":\"testservice\""},
+ })
+ })
+ ginkgo.It("get the service s1", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodGet,
+ Path: "/apisix/admin/services/s1",
+ Headers:map[string]string{"Authorization":
base.GetToken()},
+ ExpectCode: http.StatusOK,
+ ExpectBody:
"\"name\":\"testservice\",\"upstream\":{\"nodes\":[{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1980,\"weight\":1},{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1981,\"weight\":2},{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1982,\"weight\":3}],\"type\":\"roundrobin\"}",
Review comment:
need to sleep for data sync
##
File path: api/test/e2enew/service/service_test.go
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1547: Hi @membphis, we have supported the first three steps, as for `show the running step detail info about this API`, I need to consider thi
juzhiyuan opened a new issue #1547: URL: https://github.com/apache/apisix-dashboard/issues/1547 Hi @membphis, we have supported the first three steps, as for `show the running step detail info about this API`, I need to consider this one with @liuxiran. We could close this issue now, let me create a new one at Dashboard to track. _Originally posted by @juzhiyuan in https://github.com/apache/apisix/issues/1533#issuecomment-789413114_ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #1533: [discuss] need a way to debug API (router rules)
juzhiyuan commented on issue #1533: URL: https://github.com/apache/apisix/issues/1533#issuecomment-789413114 Hi @membphis, we have supported the first three steps, as for `show the running step detail info about this API`, I need to consider this one with @liuxiran. We could close this issue now, let me create a new one at Dashboard to track. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1545: feat: rewrite e2e test(service_test) with ginkgo
nic-chen commented on a change in pull request #1545:
URL: https://github.com/apache/apisix-dashboard/pull/1545#discussion_r586092310
##
File path: api/test/e2enew/service/service_test.go
##
@@ -0,0 +1,455 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package service
+
+import (
+ "encoding/json"
+ "net/http"
+ "time"
+
+ "github.com/onsi/ginkgo"
+ "github.com/stretchr/testify/assert"
+
+ "e2enew/base"
+)
+
+var _ = ginkgo.Describe("create service without plugin", func() {
+ ginkgo.It("create service without plugin", func() {
+ t := ginkgo.GinkgoT()
+ var createServiceBody map[string]interface{} =
map[string]interface{}{
+ "name": "testservice",
+ "upstream": map[string]interface{}{
+ "type": "roundrobin",
+ "nodes": []map[string]interface{}{
+ {
+ "host": base.UpstreamIp,
+ "port": 1980,
+ "weight": 1,
+ },
+ {
+ "host": base.UpstreamIp,
+ "port": 1981,
+ "weight": 2,
+ },
+ {
+ "host": base.UpstreamIp,
+ "port": 1982,
+ "weight": 3,
+ },
+ },
+ },
+ }
+ _createServiceBody, err := json.Marshal(createServiceBody)
+ assert.Nil(t, err)
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/services/s1",
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ Body: string(_createServiceBody),
+ ExpectStatus: http.StatusOK,
+ ExpectBody: []string{"\"id\":\"s1\"",
"\"name\":\"testservice\""},
+ })
+ })
+ ginkgo.It("get the service s1", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodGet,
+ Path: "/apisix/admin/services/s1",
+ Headers:map[string]string{"Authorization":
base.GetToken()},
+ ExpectCode: http.StatusOK,
+ ExpectBody:
"\"name\":\"testservice\",\"upstream\":{\"nodes\":[{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1980,\"weight\":1},{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1981,\"weight\":2},{\"host\":\"" +
base.UpstreamIp + "\",\"port\":1982,\"weight\":3}],\"type\":\"roundrobin\"}",
+ })
+ })
+ ginkgo.It("create route using the service just created", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/routes/r1",
+ Body: `{
+ "uri": "/server_port",
+ "service_id": "s1"
+ }`,
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ Sleep:base.SleepTime,
+ })
+ })
+ ginkgo.It("batch test /server_port api", func() {
+ t := ginkgo.GinkgoT()
+ time.Sleep(time.Duration(500) * time.Millisecond)
+ res := base.BatchTestServer
[GitHub] [apisix-dashboard] spacewander closed issue #1546: request help: discovery setting in dashboard
spacewander closed issue #1546: URL: https://github.com/apache/apisix-dashboard/issues/1546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] spacewander commented on issue #1546: request help: discovery setting in dashboard
spacewander commented on issue #1546: URL: https://github.com/apache/apisix-dashboard/issues/1546#issuecomment-789411959 It seems it is impossible as the configuration is written in the yaml file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #3621: ci: auto generate and check for rpm package
starsz commented on a change in pull request #3621: URL: https://github.com/apache/apisix/pull/3621#discussion_r586090871 ## File path: .github/workflows/centos7-ci.yml ## @@ -2,11 +2,9 @@ name: CI Centos7 on: push: -branches: - - master +branches: [master, 'release/**'] pull_request: -branches: - - master +branches: [master] Review comment: In fact, we will create PR to `release/**` right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1509: feat: support plugin config
nic-chen commented on a change in pull request #1509:
URL: https://github.com/apache/apisix-dashboard/pull/1509#discussion_r586086963
##
File path: api/test/e2enew/plugin_config/plugin_config_test.go
##
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package plugin_config
+
+import (
+ "net/http"
+
+ "github.com/onsi/ginkgo"
+ "github.com/onsi/ginkgo/extensions/table"
+
+ "e2enew/base"
+)
+
+var _ = ginkgo.Describe("Plugin Config", func() {
+ table.DescribeTable("test plugin config",
+ func(tc base.HttpTestCase) {
+ base.RunTestCase(tc)
+ },
+ table.Entry("make sure the route doesn't exist",
base.HttpTestCase{
+ Object: base.APISIXExpect(),
+ Method: http.MethodGet,
+ Path: "/hello",
+ ExpectStatus: http.StatusNotFound,
+ ExpectBody: `{"error_msg":"404 Route Not Found"}`,
+ }),
+ table.Entry("create plugin config", base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Path: "/apisix/admin/plugin_configs/1",
+ Method: http.MethodPut,
+ Body: `{
+ "plugins": {
+ "response-rewrite": {
+ "headers": {
+ "X-VERSION":"1.0"
+ }
+ },
+ "uri-blocker": {
+ "block_rules":
["select.+(from|limit)", "(?:(union(.*?)select))"]
+ }
+ }
+ }`,
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ }),
+ table.Entry("create plugin config", base.HttpTestCase{
Review comment:
fixed.
##
File path: api/test/e2enew/plugin_config/plugin_config_test.go
##
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package plugin_config
+
+import (
+ "net/http"
+
+ "github.com/onsi/ginkgo"
+ "github.com/onsi/ginkgo/extensions/table"
+
+ "e2enew/base"
+)
+
+var _ = ginkgo.Describe("Plugin Config", func() {
+ table.DescribeTable("test plugin config",
+ func(tc base.HttpTestCase) {
+ base.RunTestCase(tc)
+ },
+ table.Entry("make sure the route doesn't exist",
base.HttpTestCase{
+ Object: base.APISIXExpect(),
+ Method: http.MethodGet,
+ Path: "/hello",
+ ExpectStatus: http.StatusNotFound,
+ ExpectBody: `{"error_msg":"404 Route Not Found"}`,
+ }),
+ table.Entry("create plugin config", base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Path: "/apisix/admin/plugin_configs/1",
+ Method: http.MethodPut,
+ Body: `{
+
[GitHub] [apisix-website] imjoey commented on issue #220: improve Subscribe Mailing-list more clear
imjoey commented on issue #220: URL: https://github.com/apache/apisix-website/issues/220#issuecomment-789405900 @1502shivam-singh @juzhiyuan +1 agreed with Subscribe leading to the Subscribe Guide page. Regarding to the history mails, how about use `Mailing list` here as the mails may still be under discussions at present. In addition, it would be better to add the mailing list in `Subscribe Guide` page, as another entrance to mailing list page. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #3726: [Discuss] standardize release guide & branch/tag relations
juzhiyuan commented on issue #3726: URL: https://github.com/apache/apisix/issues/3726#issuecomment-789403965 Hi @imjoey @membphis @pahud @tokers, we are reviewing the release process, please take a look at this issue when you have time :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on issue #1533: [discuss] need a way to debug API (router rules)
moonming commented on issue #1533: URL: https://github.com/apache/apisix/issues/1533#issuecomment-789403942 @juzhiyuan is dashoard debug feature support this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new issue #3736: Support Nacos in a native way
spacewander opened a new issue #3736: URL: https://github.com/apache/apisix/issues/3736 See https://issues.apache.org/jira/browse/APISIX-11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #1533: [discuss] need a way to debug API (router rules)
spacewander commented on issue #1533: URL: https://github.com/apache/apisix/issues/1533#issuecomment-789399949 Is it still on the roadmap? As summer 2020 has been passed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] xvjialing opened a new issue #1546: request help: discovery setting in dashboard
xvjialing opened a new issue #1546: URL: https://github.com/apache/apisix-dashboard/issues/1546 ### Issue description Can add service discovery settings in the dashboard interface, such as eureka, consul, nacos ### Environment * apisix version (cmd: `apisix version`): 2.3 * OS (cmd: `uname -a`): ubuntu 16.0.4 * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): * etcd version: 3.4.9 * apisix-dashboard version, 2.3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] lilien1010 commented on a change in pull request #3718: fix: fail to run `make deps` on macOS
lilien1010 commented on a change in pull request #3718: URL: https://github.com/apache/apisix/pull/3718#discussion_r586077543 ## File path: docs/en/latest/install-dependencies.md ## @@ -150,7 +150,10 @@ nohup etcd & ```shell # install OpenResty, etcd and some compilation tools -brew install openresty/brew/openresty etcd luarocks curl git +brew install openresty/brew/openresty openresty-openssl111 etcd curl git Review comment: yep, or-openssl111 will be autoaticll installed when you install openresty This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xvjialing opened a new issue #3735: request help: discovery setting in dashboard
xvjialing opened a new issue #3735: URL: https://github.com/apache/apisix/issues/3735 ### Issue description You can add service discovery settings in the dashboard interface, such as eureka, consul, nacos ### Environment * apisix version (cmd: `apisix version`): 2.3 * OS (cmd: `uname -a`): ubuntu 16.0.4 * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): * etcd version: 3.4.9 * apisix-dashboard version, 2.3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus opened a new pull request #36: fix: break change with affinity
Junnplus opened a new pull request #36: URL: https://github.com/apache/apisix-helm-chart/pull/36 fix https://github.com/apache/apisix-helm-chart/issues/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1526: feat: rewrite e2e test(ssl_test) with ginkgo
nic-chen commented on pull request #1526: URL: https://github.com/apache/apisix-dashboard/pull/1526#issuecomment-789388706 merged. thanks a lot! @Jaycean This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen merged pull request #1526: feat: rewrite e2e test(ssl_test) with ginkgo
nic-chen merged pull request #1526: URL: https://github.com/apache/apisix-dashboard/pull/1526 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: rewrite e2e test(ssl_test) with ginkgo (#1526)
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new c775e3e feat: rewrite e2e test(ssl_test) with ginkgo (#1526)
c775e3e is described below
commit c775e3e2442ff985d99e57e30792a30e855138c8
Author: JinChen <36916582+jayc...@users.noreply.github.com>
AuthorDate: Wed Mar 3 10:56:00 2021 +0800
feat: rewrite e2e test(ssl_test) with ginkgo (#1526)
---
api/test/e2e/ssl_test.go | 221 -
api/test/e2enew/ssl/ssl_suite_test.go | 36 ++
api/test/e2enew/ssl/ssl_test.go | 225 ++
3 files changed, 261 insertions(+), 221 deletions(-)
diff --git a/api/test/e2e/ssl_test.go b/api/test/e2e/ssl_test.go
deleted file mode 100644
index 2c3096c..000
--- a/api/test/e2e/ssl_test.go
+++ /dev/null
@@ -1,221 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package e2e
-
-import (
- "context"
- "crypto/tls"
- "encoding/json"
- "io/ioutil"
- "net"
- "net/http"
- "testing"
- "time"
-
- "github.com/stretchr/testify/assert"
-)
-
-func TestSSL_Basic(t *testing.T) {
- // build test body
- testCert, err := ioutil.ReadFile("../certs/test2.crt")
- assert.Nil(t, err)
- testKey, err := ioutil.ReadFile("../certs/test2.key")
- assert.Nil(t, err)
- apisixKey, err := ioutil.ReadFile("../certs/apisix.key")
- assert.Nil(t, err)
- body, err := json.Marshal(map[string]interface{}{
- "id": "1",
- "cert": string(testCert),
- "key": string(testKey),
- "labels": map[string]string{
- "build": "16",
- "env": "production",
- "version": "v3",
- },
- })
- assert.Nil(t, err)
- invalidBody, err := json.Marshal(map[string]string{
- "id": "1",
- "cert": string(testCert),
- "key": string(apisixKey),
- })
-
- // Before configuring SSL, make a HTTPS request
- // If use the test framework, errors will cause failure, so we need to
make a separate https request for testing.
- http.DefaultTransport.(*http.Transport).TLSClientConfig =
&tls.Config{InsecureSkipVerify: true}
- http.DefaultTransport.(*http.Transport).DialContext = func(ctx
context.Context, network, addr string) (net.Conn, error) {
- if addr == "www.test2.com:9443" {
- addr = "127.0.0.1:9443"
- }
- dialer := &net.Dialer{}
- return dialer.DialContext(ctx, network, addr)
- }
- _, err = http.Get("https://www.test2.com:9443";)
- assert.NotNil(t, err)
- assert.EqualError(t, err, "Get https://www.test2.com:9443: remote
error: tls: internal error")
-
- // main test cases
- tests := []HttpTestCase{
- {
- Desc: "create ssl fail - key and cert not
match",
- Object: ManagerApiExpect(t),
- Method: http.MethodPost,
- Path: "/apisix/admin/ssl",
- Body: string(invalidBody),
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusBadRequest,
- },
- {
- Desc: "create ssl successfully",
- Object: ManagerApiExpect(t),
- Method: http.MethodPost,
- Path: "/apisix/admin/ssl",
- Body: string(body),
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- Sleep:sleepTime,
- },
- {
- Desc: "check ssl labels",
- Object: ManagerAp
[GitHub] [apisix] juzhiyuan commented on pull request #3710: resolve #3708
juzhiyuan commented on pull request #3710: URL: https://github.com/apache/apisix/pull/3710#issuecomment-789386740 aha yes! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan closed issue #3708: update User Wall picture in README
juzhiyuan closed issue #3708: URL: https://github.com/apache/apisix/issues/3708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] pengtaochang commented on issue #3722: request help: How to set path supports regular matching like nginx
pengtaochang commented on issue #3722: URL: https://github.com/apache/apisix/issues/3722#issuecomment-789382430 I have used the proxy-rewrite plugin. It can redirect to right page in apisix and return right html file. But, the client Browser need to redirect to another path so that display correctly. I have read the doc of response-rewrite, but I still can't find how to get regular value in uri. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3727: request help: How do I know which node the response came from
Firstsawyou commented on issue #3727: URL: https://github.com/apache/apisix/issues/3727#issuecomment-789378456 > I mean the upstream info added in the response, not in other log, maybe we need a new plugin, modify the response like `response-rewrite`. Got it. I think there is no need to add a new plugin, it should be implemented in the response-rewrite plugin. @spacewander What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #201: How to integrate with other projects' docs
juzhiyuan commented on issue #201: URL: https://github.com/apache/apisix-website/issues/201#issuecomment-789376363 Please NOTE: this guide only works on the latest docs, @qier222 please add the description about how to add multiple versions when you are free, not urgent as far as I know. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #201: How to integrate with other projects' docs
juzhiyuan commented on issue #201: URL: https://github.com/apache/apisix-website/issues/201#issuecomment-789375730 LGTM, and anyone would like to file a PR to add this one under the `General` section in English? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
