[GitHub] [apisix-dashboard] batman-ezio commented on issue #1487: Support duplicate one existing Route
batman-ezio commented on issue #1487: URL: https://github.com/apache/apisix-dashboard/issues/1487#issuecomment-791235204 I'll do this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch release/2.4 updated (6a64540 -> a4af128)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch release/2.4
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 6a64540 ci: auto generate and check for rpm package (#3621)
add 573b488 docs: updated users image part in README.md (#3715)
add a82e31d chore: use the # operator to get the length of the Lua string
(#3716)
add 210f76d fix: invalid links in markdown files (#3712)
add 1591842 docs: update request-id.md doc (#3713)
add 3413ebb docs: tweak discovery via DNS doc (#3731)
add 1c4b21f chore: only package this version's rockspec (#3724)
add 29b1e2d docs: fix invalid link (#3733)
add fc7a466 ci: run chaos test on HEAD of PR (#3675)
add 01849b9 ci: auto generate and check for rpm package (#3621)
add a97ba0d refactor: extract desc definition from the schema (#3737)
add 0d40f81 test: improve the unique request id check (#3738)
add 9885103 test: clean up malformed etcd data (#3743)
add 66539b3 feat: support conditional response rewrite (#3577)
add 7a5b35d docs: fix openid-connect's subtitles (#3745)
add a40a4d6 docs: updated screenshots from v2.x dashboard (#3741)
add 8e3fd22 docs: fix wrong dir when install from source code. (#3748)
add 4820ad9 ci: ensure the fuzzing work under Python3 (#3747)
add 8c2d7c9 docs: Missing plugins doc of apisix shown in website (#3754)
add b7751d5 docs: updated remaining screenshots of plugins (#3761)
add a4af128 Merge branch 'master' into release/2.4
No new revisions were added by this update.
Summary of changes:
.github/workflows/chaos.yml | 4 +
Makefile | 3 +-
README.md | 10 +-
apisix/plugins/log-rotate.lua | 2 +-
apisix/plugins/proxy-cache.lua| 2 +-
apisix/plugins/response-rewrite.lua | 43 +++-
apisix/schema_def.lua | 16 +-
docs/assets/images/plugin/basic-auth-1.png| Bin 22997 -> 69203 bytes
docs/assets/images/plugin/basic-auth-2.png| Bin 43549 -> 88754 bytes
docs/assets/images/plugin/hmac-auth-1.png | Bin 0 -> 68701 bytes
docs/assets/images/plugin/hmac-auth-2.png | Bin 0 -> 88280 bytes
docs/assets/images/plugin/jwt-auth-1.png | Bin 38204 -> 65449 bytes
docs/assets/images/plugin/jwt-auth-2.png | Bin 227769 -> 82630 bytes
docs/assets/images/plugin/key-auth-1.png | Bin 37526 -> 65554 bytes
docs/assets/images/plugin/key-auth-2.png | Bin 182157 -> 81728 bytes
docs/assets/images/plugin/wolf-rbac-1.png | Bin 79987 -> 68988 bytes
docs/assets/images/plugin/wolf-rbac-2.png | Bin 85769 -> 89248 bytes
docs/en/latest/architecture-design.md | 2 +-
docs/en/latest/config.json| 36 ++-
docs/en/latest/discovery.md | 11 +-
docs/en/latest/{ => discovery}/dns.md | 0
docs/en/latest/install-dependencies.md| 5 +-
docs/en/latest/plugin-develop.md | 70 +++---
docs/en/latest/plugins/hmac-auth.md | 78 +++---
docs/en/latest/plugins/openid-connect.md | 9 +-
docs/en/latest/plugins/request-id.md | 4 +-
docs/en/latest/plugins/response-rewrite.md| 8 +-
docs/en/latest/stream-proxy.md| 8 +-
docs/es/latest/README.md | 4 +-
docs/zh/latest/FAQ.md | 56 ++---
docs/zh/latest/README.md | 16 +-
docs/zh/latest/admin-api.md | 349 +-
docs/zh/latest/architecture-design.md | 8 +-
docs/zh/latest/config.json| 28 ++-
docs/zh/latest/discovery.md | 85 +++
docs/zh/latest/health-check.md| 52 ++--
docs/zh/latest/install-dependencies.md| 4 +-
docs/zh/latest/plugin-develop.md | 66 ++---
docs/zh/latest/plugins/batch-requests.md | 78 +++---
docs/zh/latest/plugins/hmac-auth.md | 60 ++---
docs/zh/latest/plugins/jwt-auth.md| 18 +-
docs/zh/latest/plugins/limit-count.md | 4 +-
docs/zh/latest/plugins/openid-connect.md | 13 +-
docs/zh/latest/plugins/prometheus.md | 28 +--
docs/zh/latest/plugins/request-id.md | 6 +-
docs/zh/latest/plugins/response-rewrite.md| 8 +-
docs/zh/latest/plugins/server-info.md | 29 +--
docs/zh/latest/plugins/udp-logger.md | 25 +-
docs/zh/latest/plugins/wolf-rbac.md | 28 +--
docs/zh/latest/stream-proxy.md| 14 +-
docs/en/latest/powered-by.md => powered-by.md | 0
t/chaos/setup_chaos_utils.sh | 1 +
t/fuzzing/public.py | 8 +-
t/node/plugin-configs.t | 2 +
t/plugin/request-id.t | 63 +++--
[apisix] branch release/2.4 updated (b94d3fc -> 6a64540)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch release/2.4 in repository https://gitbox.apache.org/repos/asf/apisix.git. from b94d3fc feat: release 2.4 add 484d810 docs: fix wrong dir when install from source code. (#3748) add 6a64540 ci: auto generate and check for rpm package (#3621) No new revisions were added by this update. Summary of changes: .github/workflows/build.yml | 1 + .github/workflows/centos7-ci.yml | 51 docs/en/latest/how-to-build.md | 2 +- docs/zh/latest/how-to-build.md | 2 +- utils/centos7-ci.sh | 6 ++--- 5 files changed, 47 insertions(+), 15 deletions(-)
[apisix] tag 2.4 created (now b94d3fc)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to tag 2.4 in repository https://gitbox.apache.org/repos/asf/apisix.git. at b94d3fc (commit) No new revisions were added by this update.
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
Firstsawyou commented on a change in pull request #3758:
URL: https://github.com/apache/apisix/pull/3758#discussion_r588085262
##
File path: t/plugin/traffic-split.t
##
@@ -1615,7 +1615,134 @@ passed
-=== TEST 46: the upstream_id is used in the plugin
+=== TEST 46: set route(id: 1, upstream_id: 1, upstream_id in plugin: 2), and
`weighted_upstreams` does not have a structure with only `weight`
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+[=[{
+"uri": "/hello*",
+"plugins": {
+"traffic-split": {
+"rules": [
+{
+"match": [
+{
+"vars": [["uri", "==", "/hello"]]
+}
+],
+"weighted_upstreams": [
+{"upstream_id": 2}
+]
+}
+]
+}
+},
+"upstream_id":"1"
+}]=]
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 47: when `match` rule passed, use the `upstream_id` in plugin, and
when it failed, use the `upstream_id` in route
+--- pipelined_requests eval
+["GET /hello", "GET /hello1", "GET /hello", "GET /hello1", "GET /hello", "GET
/hello1"]
+--- response_body eval
+["hello world\n", "hello1 world\n", "hello world\n", "hello1 world\n", "hello
world\n", "hello1 world\n"]
+--- grep_error_log_out eval
+[
+"match_flag: true",
+"upstream_id: 2",
+"match_flag: false",
+"original_uid: 1"
+]
+
+
+
+=== TEST 48: set route(id: 1, upstream_id: 1, upstream_id in plugin: 2), and
`weighted_upstreams` has a structure with only `weight`
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+[=[{
+"uri": "/server_port",
+"plugins": {
+"traffic-split": {
+"rules": [
+{
+"match": [
+{
+"vars": [["uri", "==",
"/server_port"]]
+}
+],
+"weighted_upstreams": [
+{"upstream_id": 2, "weight": 1},
+{"weight": 1}
+]
+}
+]
+}
+},
+"upstream_id":"1"
+}]=]
+)
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 49: all requests `match` rule passed, proxy requests to the upstream
of route based on the structure with only `weight` in `weighted_upstreams`
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local bodys = {}
+local headers = {}
Review comment:
I think it is not used by `headers` and we should remove it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] caukie commented on issue #1549: feat: support `discovery_type` in Dashboard
caukie commented on issue #1549: URL: https://github.com/apache/apisix-dashboard/issues/1549#issuecomment-791214984 > hi @caukie > I have submit a PR for it , you could have a look: > #1557 i think there still need some code for dashboard show, so i can't check the feature from dashboard now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #1974: apisix latest version with skywalking register failed
spacewander closed issue #1974: URL: https://github.com/apache/apisix/issues/1974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3229: request help: Here is a big confusion about self.running in config.etcd.lua?
spacewander closed issue #3229: URL: https://github.com/apache/apisix/issues/3229 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou edited a comment on issue #3762: request help:
Firstsawyou edited a comment on issue #3762: URL: https://github.com/apache/apisix/issues/3762#issuecomment-791200573 In the config.yaml configuration file, you have not added the `cors` plugin name to the plugins. You need to add the cors plugin name to the `plugins` list like this: ``` .. plugins: # plugin list (sorted in alphabetical order) - skywalking - cors ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3762: request help:
Firstsawyou commented on issue #3762: URL: https://github.com/apache/apisix/issues/3762#issuecomment-791200573 In the config.yaml configuration file, you have not added the `cors` plugin name to the plugins. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3759: request help: cors plugins support domain limit
spacewander commented on issue #3759: URL: https://github.com/apache/apisix/issues/3759#issuecomment-791196882 I prefer to add regex match. Create an issue as https://github.com/apache/apisix/issues/3763, pull is welcome! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new issue #3763: feat: add "allow_origins_by_regex" to cors plugin
spacewander opened a new issue #3763: URL: https://github.com/apache/apisix/issues/3763 We can use regex to match if the request' Origin header is in the allow list. People who want to implement it can take a look at: https://github.com/apache/apisix/blob/master/apisix/plugins/uri-blocker.lua This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
spacewander commented on a change in pull request #3758: URL: https://github.com/apache/apisix/pull/3758#discussion_r588063801 ## File path: apisix/plugins/traffic-split.lua ## @@ -309,7 +314,8 @@ function _M.access(conf, ctx) return end -local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams) +local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams, Review comment: `lrucache` accepts an extra key as the second argument. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dingwood commented on issue #3599: request help: How to config etcd with https
dingwood commented on issue #3599: URL: https://github.com/apache/apisix/issues/3599#issuecomment-791192362 hope the mtls function coming soon . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
tzssangglass commented on a change in pull request #3758: URL: https://github.com/apache/apisix/pull/3758#discussion_r588056323 ## File path: apisix/plugins/traffic-split.lua ## @@ -309,7 +314,8 @@ function _M.access(conf, ctx) return end -local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams) +local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams, Review comment: update This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] cgc1983 opened a new issue #3762: request help:
cgc1983 opened a new issue #3762:
URL: https://github.com/apache/apisix/issues/3762
### Issue description
apisix version:2.1
OS：Linux 2d6df599090f 4.4.0-198-generic #230-Ubuntu SMP Sat Nov 28 01:30:29
UTC 2020 x86_64 Linux
Nginx Version:openresty/1.19.3.1
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri": "/hello",
"plugins": {
"cors": {}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"127.0.0.1:8080": 1
}
}
}'
{"error_msg":"unknown plugin [cors]"}
bash-5.0# cat config.yaml
apisix:
admin_key:
- key: edd1c9f034335f136f87ad84b625c8f1
name: admin
role: admin
allow_admin:
- 0.0.0.0/0
enable_ipv6: false
node_listen: 9080
plugin_attr:
skywalking:
endpoint_addr: http://172.17.16.68:12800
service_instance_name: APISIX Instance Name
service_name: APISIX
plugins:
- skywalking
### Environment
why the curl request return error message?
* apisix version (cmd: `apisix version`):
* OS (cmd: `uname -a`):
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
* etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
* apisix-dashboard version, if have:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
tzssangglass commented on a change in pull request #3758: URL: https://github.com/apache/apisix/pull/3758#discussion_r588053853 ## File path: apisix/plugins/traffic-split.lua ## @@ -309,7 +314,8 @@ function _M.access(conf, ctx) return end -local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams) +local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams, Review comment: you mean ```lua local route_upstream_id = ctx.matched_route.value.upstream_id local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams, route_upstream_id) ``` ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] tokers opened a new issue #243: fix the sidebar missing of apisix-ingress-controller design doc
tokers opened a new issue #243:
URL: https://github.com/apache/apisix-website/issues/243
**Actual Behaviour**
When we open the design page of apisix ingress controller doc site, we don't
see the sidebar there.
**Expected Behaviour**
The sidebar should be shown. the
[config.json](https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/config.json),
should add an item to record the `design`, for instance:
```json
{
"type": "category",
"label": "How It Works",
"items": [
"design"
]
}
```
**Steps to reproduce it**
**Screenshots of the issue**
**Would you like to work on the issue?**
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] yongboy commented on a change in pull request #3742: feat: add control api for discovery module
yongboy commented on a change in pull request #3742:
URL: https://github.com/apache/apisix/pull/3742#discussion_r588040516
##
File path: apisix/control/router.lua
##
@@ -66,6 +68,38 @@ function fetch_control_api_router()
end
end
+local discovery_type =
require("apisix.core.config_local").local_conf().discovery
+if discovery_type then
+local discovery = require("apisix.discovery.init").discovery
+local dump_apis = {}
+for key, _ in pairs(discovery_type) do
Review comment:
if use `for key, dis_mod in pairs(discovery) do`, the `dis_mod` is
`function` type, not a table object.
So, we can't do it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
spacewander commented on a change in pull request #3758: URL: https://github.com/apache/apisix/pull/3758#discussion_r588037942 ## File path: apisix/plugins/traffic-split.lua ## @@ -309,7 +314,8 @@ function _M.access(conf, ctx) return end -local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams) +local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams, Review comment: Need to use `ctx.matched_route.value.upstream_id` as the extra key. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1540: feat: add plugin template config feature
LiteSun merged pull request #1540: URL: https://github.com/apache/apisix-dashboard/pull/1540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: add plugin template config feature (#1540)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 938b2b9 feat: add plugin template config feature (#1540)
938b2b9 is described below
commit 938b2b9f34c5fa5e7ef6fddef29acb29b25c09a1
Author: litesun
AuthorDate: Fri Mar 5 12:33:09 2021 +0800
feat: add plugin template config feature (#1540)
Co-authored-by: guoqqqi <979918...@qq.com>
---
.gitignore | 3 +
web/config/routes.ts | 12 ++
web/cypress/fixtures/data.json | 8 +-
web/cypress/fixtures/selector.json | 7 +-
.../consumer/create_and_delete_consumer.spec.js| 9 +-
.../create-edit-delete-plugin-template.spec.js | 84 +++
.../create-plugin-template-with-route.spec.js | 102 +
.../route/create-edit-delete-route.spec.js | 5 +-
.../LabelsfDrawer}/LabelsDrawer.tsx| 17 ++-
.../locales/en-US.ts => LabelsfDrawer/index.ts}| 5 +-
web/src/components/Plugin/PluginPage.tsx | 78 --
web/src/components/Plugin/locales/en-US.ts | 4 +
web/src/components/Plugin/locales/zh-CN.ts | 4 +
web/src/components/Plugin/service.ts | 6 +
web/src/helpers.tsx| 30
web/src/locales/en-US/menu.ts | 1 +
web/src/locales/zh-CN/menu.ts | 1 +
web/src/pages/PluginTemplate/Create.tsx| 121
web/src/pages/PluginTemplate/List.tsx | 160 +
.../PluginTemplate/components/Preview.tsx} | 23 ++-
.../components/Step1.tsx} | 109 +-
web/src/pages/PluginTemplate/service.ts| 59
.../en-US.ts => pages/PluginTemplate/typing.d.ts} | 17 ++-
web/src/pages/Route/Create.tsx | 13 +-
web/src/pages/Route/List.tsx | 6 +-
.../Route/components/CreateStep4/CreateStep4.tsx | 8 +-
web/src/pages/Route/components/Step1/MetaView.tsx | 6 +-
web/src/pages/Route/components/Step3/index.tsx | 11 +-
web/src/pages/Route/constants.ts | 1 +
web/src/pages/Route/locales/en-US.ts | 1 +
web/src/pages/Route/locales/zh-CN.ts | 1 +
web/src/pages/Route/service.ts | 4 +-
web/src/pages/Route/transform.ts | 36 +
web/src/pages/Route/typing.d.ts| 12 +-
web/src/typings.d.ts | 4 +
35 files changed, 798 insertions(+), 170 deletions(-)
diff --git a/.gitignore b/.gitignore
index 04f148e..1997f52 100644
--- a/.gitignore
+++ b/.gitignore
@@ -51,3 +51,6 @@ api/build-tools/apisix
api/coverage.txt
api/dag-to-lua/
+# frontend e2e test output
+web/.nyc_output
+web/coverage
diff --git a/web/config/routes.ts b/web/config/routes.ts
index 097102d..b47c7cd 100644
--- a/web/config/routes.ts
+++ b/web/config/routes.ts
@@ -100,6 +100,18 @@ const routes = [
component: './Setting',
},
{
+path: '/plugin-template/list',
+component: './PluginTemplate/List',
+ },
+ {
+path: 'plugin-template/create',
+component: './PluginTemplate/Create',
+ },
+ {
+path: '/plugin-template/:id/edit',
+component: './PluginTemplate/Create',
+ },
+ {
path: '/user/login',
component: './User/Login',
layout: false,
diff --git a/web/cypress/fixtures/data.json b/web/cypress/fixtures/data.json
index 536a71b..94be061 100644
--- a/web/cypress/fixtures/data.json
+++ b/web/cypress/fixtures/data.json
@@ -27,5 +27,11 @@
"updateSuccessfully": "Update Configuration Successfully",
"deleteSSLSuccess": "Remove target SSL successfully",
"sslErrorAlert": "key and cert don't match",
- "pluginErrorAlert": "Invalid plugin data"
+ "pluginErrorAlert": "Invalid plugin data",
+ "pluginTemplateName": "test_plugin_template1",
+ "pluginTemplateName2": "test_plugin_template2",
+ "createPluginTemplateSuccess": "Create Plugin Template Successfully",
+ "editPluginTemplateSuccess": "Edit Plugin Template Successfully",
+ "deletePluginTemplateSuccess": "Delete Plugin Template Successfully",
+ "pluginTemplateErrorAlert": "Request Error Code: 1"
}
diff --git a/web/cypress/fixtures/selector.json
b/web/cypress/fixtures/selector.json
index ffb125a..e7b2abb 100644
--- a/web/cypress/fixtures/selector.json
+++ b/web/cypress/fixtures/selector.json
@@ -64,5 +64,10 @@
"passwordInput": "#control-ref_password",
"drawer": ".ant-drawer-content",
"codemirrorScroll": ".CodeMirror-scroll",
- "drawerClose": ".ant-drawer-close"
+ "drawerClose": ".ant-drawer-close",
+ "descriptionSelector": "[title=Description]",
+ "customSelector": "[title=Custom]",
+
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1557: feat: sync fields of `upstream` from APISIX
codecov-io edited a comment on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-791091588 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=h1) Report > Merging [#1557](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=desc) (0e45fca) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/77b42e839f8a79bbae8e0dd097195bf922076bbb?el=desc) (77b42e8) will **decrease** coverage by `18.54%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1557 +/- ## === - Coverage 70.22% 51.68% -18.55% === Files 130 40 -90 Lines5340 2707 -2633 Branches 5490 -549 === - Hits 3750 1399 -2351 + Misses 1342 1127 -215 + Partials 248 181 -67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.68% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | ... and [112 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=footer). Last update [77b42e8...0e45fca](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (8c2d7c9 -> b7751d5)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 8c2d7c9 docs: Missing plugins doc of apisix shown in website (#3754)
add b7751d5 docs: updated remaining screenshots of plugins (#3761)
No new revisions were added by this update.
Summary of changes:
README.md | 2 +-
docs/assets/images/plugin/basic-auth-1.png | Bin 22997 -> 69203 bytes
docs/assets/images/plugin/basic-auth-2.png | Bin 43549 -> 88754 bytes
.../plugin/{jwt-auth-1.png => hmac-auth-1.png} | Bin 65449 -> 68701 bytes
docs/assets/images/plugin/hmac-auth-2.png | Bin 0 -> 88280 bytes
docs/assets/images/plugin/wolf-rbac-1.png | Bin 79987 -> 68988 bytes
docs/assets/images/plugin/wolf-rbac-2.png | Bin 85769 -> 89248 bytes
docs/en/latest/plugins/hmac-auth.md | 6 ++
8 files changed, 7 insertions(+), 1 deletion(-)
copy docs/assets/images/plugin/{jwt-auth-1.png => hmac-auth-1.png} (61%)
create mode 100644 docs/assets/images/plugin/hmac-auth-2.png
[GitHub] [apisix] spacewander merged pull request #3761: docs: updated remaining screenshots of plugins
spacewander merged pull request #3761: URL: https://github.com/apache/apisix/pull/3761 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1549: feat: support `discovery_type` in Dashboard
nic-chen commented on issue #1549: URL: https://github.com/apache/apisix-dashboard/issues/1549#issuecomment-791136803 hi @caukie I have submit a PR for it , you could have a look: https://github.com/apache/apisix-dashboard/pull/1557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1557: feat: sync fields of `upstream` from APISIX
nic-chen commented on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-791136194 > No Backend coverage? sometimes Codecov unstable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1547: show the running step detail info about this API
juzhiyuan commented on issue #1547: URL: https://github.com/apache/apisix-dashboard/issues/1547#issuecomment-791132704 Here have feedbacks from AISPEECH. 1. the core point is that unpublished routes should only allow test traffic access, no official traffic can be put in. 2. Suggestion: APISIX supports defining global test traffic characteristics, such as defining special fields in the request header to indicate that this is test traffic; route match is done in the full set of routes (including published routes and unpublished routes) when processing test traffic, and after testing and verifying that it meets expectations After testing and verifying that it meets expectations, then publish. cc @membphis @liuxiran to take a look This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan edited a comment on issue #229: improve the description for users to join Slack
juzhiyuan edited a comment on issue #229: URL: https://github.com/apache/apisix-website/issues/229#issuecomment-791128285 1. https://github.com/apache/apisix-website/blob/master/website/src/pages/help.js#L71 2. add `TEXT` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #229: improve the description for users to join Slack
juzhiyuan commented on issue #229: URL: https://github.com/apache/apisix-website/issues/229#issuecomment-791128285 1. https://github.com/apache/apisix-website/blob/master/website/src/pages/help.js#L71 2. add `TEXT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1557: feat: sync fields of `upstream` from APISIX
juzhiyuan commented on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-791126474 No Backend coverage? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3761: docs: updated remaining screenshots of plugins
juzhiyuan commented on a change in pull request #3761: URL: https://github.com/apache/apisix/pull/3761#discussion_r588005649 ## File path: docs/en/latest/plugins/hmac-auth.md ## @@ -69,6 +69,12 @@ curl http://127.0.0.1:9080/apisix/admin/consumers -H 'X-API-KEY: edd1c9f034335f1 The default `keep_headers` is false and `encode_uri_params` is true. +You can visit the dashboard: `http://127.0.0.1:9080/apisix/dashboard/`, to complete the above operations through the web interface, first add a consumer: Review comment: ```suggestion You can visit the dashboard to complete the above operations through the web interface, first add a consumer: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] miaoyb commented on issue #3757: bug: cors插件和redirect插件组合跨域访问有问题
miaoyb commented on issue #3757: URL: https://github.com/apache/apisix/issues/3757#issuecomment-791124312 > I doubt whether it is allowed to use CORS and redirect together. I find a documentation https://developer.mozilla.org/zh-CN/docs/Web/HTTP/CORS/Errors/CORSExternalRedirectNotAllowed which says that "CORS request external redirect not allowed" OK，thanks~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] miaoyb closed issue #3757: bug: cors插件和redirect插件组合跨域访问有问题
miaoyb closed issue #3757: URL: https://github.com/apache/apisix/issues/3757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #1304: feature: introduce memory-based proxy-cache plugin.
spacewander closed issue #1304: URL: https://github.com/apache/apisix/issues/1304 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #1304: feature: introduce memory-based proxy-cache plugin.
spacewander commented on issue #1304: URL: https://github.com/apache/apisix/issues/1304#issuecomment-791124178 Yes. We can implement it via existent plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] miaoyb commented on issue #3759: request help: cors plugins support domain limit
miaoyb commented on issue #3759: URL: https://github.com/apache/apisix/issues/3759#issuecomment-791122587 > Currently wildcard is not supported. So if you want to match "http://a.xxx.cn; and "https://b.xxx.cn;, you need to write "http://a.xxx.cn,https://b.xxx.cn;. Note that the scheme is required. so,Is there a plan to support wildcard matching？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1540: feat: add plugin template config feature
codecov-io edited a comment on pull request #1540: URL: https://github.com/apache/apisix-dashboard/pull/1540#issuecomment-788786709 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=h1) Report > Merging [#1540](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=desc) (71b8e87) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/77b42e839f8a79bbae8e0dd097195bf922076bbb?el=desc) (77b42e8) will **decrease** coverage by `14.72%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1540 +/- ## === - Coverage 70.22% 55.49% -14.73% === Files 130 49 -81 Lines5340 3164 -2176 Branches 5490 -549 === - Hits 3750 1756 -1994 + Misses 1342 1104 -238 - Partials 248 304 +56 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `55.49% <ø> (-0.19%)` | :arrow_down: | | backend-e2e-test-ginkgo | `39.79% <ø> (-0.13%)` | :arrow_down: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `57.44% <0.00%> (-34.05%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `38.46% <0.00%> (-30.77%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `57.22% <0.00%> (-30.73%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: | | ... and [85 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=footer). Last update [77b42e8...71b8e87](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1540: feat: add plugin template config feature
codecov-io edited a comment on pull request #1540: URL: https://github.com/apache/apisix-dashboard/pull/1540#issuecomment-788786709 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=h1) Report > Merging [#1540](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=desc) (71b8e87) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/77b42e839f8a79bbae8e0dd097195bf922076bbb?el=desc) (77b42e8) will **decrease** coverage by `22.81%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1540 +/- ## === - Coverage 70.22% 47.40% -22.82% === Files 130 49 -81 Lines5340 3164 -2176 Branches 5490 -549 === - Hits 3750 1500 -2250 - Misses 1342 1419 +77 + Partials 248 245-3 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `47.40% <ø> (-8.29%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `5.88% <0.00%> (-68.63%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `11.79% <0.00%> (-57.44%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `33.33% <0.00%> (-57.15%)` | :arrow_down: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `33.64% <0.00%> (-55.15%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | ... and [89 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1540/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=footer). Last update [77b42e8...71b8e87](https://codecov.io/gh/apache/apisix-dashboard/pull/1540?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the
[GitHub] [apisix] spacewander edited a comment on issue #3759: request help: cors plugins support domain limit
spacewander edited a comment on issue #3759: URL: https://github.com/apache/apisix/issues/3759#issuecomment-791117611 Currently wildcard is not supported. So if you want to match "http://a.xxx.cn; and "https://b.xxx.cn;, you need to write "http://a.xxx.cn,https://b.xxx.cn;. Note that the scheme is required. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3759: request help: cors plugins support domain limit
spacewander commented on issue #3759: URL: https://github.com/apache/apisix/issues/3759#issuecomment-791117611 Currently wildcard is not supported. So if you want to match "a.xxx.cn" and "b.xxx.cn", you need to write "a.xxx.cn,b.xxx.cn". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #3761: docs: updated remaining screenshots of plugins
iamayushdas commented on pull request #3761: URL: https://github.com/apache/apisix/pull/3761#issuecomment-791116371 # updated screenshots of following plugins till now * [x] basic-auth * [x] Jwt-auth * [x] hmac-auth * [x] wolf-brac This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1557: feat: sync fields of `upstream` from APISIX
codecov-io edited a comment on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-791091588 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=h1) Report > Merging [#1557](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=desc) (d9c109d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9130e09837f7e6283ba4645fab5c482b18a61949?el=desc) (9130e09) will **increase** coverage by `1.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1557 +/- ## == + Coverage 70.18% 71.64% +1.45% == Files 130 81 -49 Lines5340 2176-3164 Branches 549 549 == - Hits 3748 1559-2189 + Misses 1344 617 -727 + Partials 2480 -248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `71.64% <ø> (-0.10%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `80.64% <0.00%> (-6.46%)` | :arrow_down: | | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | | | | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | | | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | | | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | | | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | | | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | | | | ... and [39 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=footer). Last update [9130e09...d9c109d](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas opened a new pull request #3761: docs: updated remaining screenshots of plugins
iamayushdas opened a new pull request #3761: URL: https://github.com/apache/apisix/pull/3761 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] miaoyb edited a comment on issue #3759: request help: cors plugins support domain limit
miaoyb edited a comment on issue #3759: URL: https://github.com/apache/apisix/issues/3759#issuecomment-791100711 > We already support this feature. Please read the doc: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/cors.md > > > | allow_origins| string | optional| "*" | | Which Origins is allowed to enable CORS, format as：`scheme`://`host`:`port`, for example: https://somehost.com:8081. Multiple origin use `,` to split. if i want allowed *.xxx.cn,What should I write,like "\*.xxx.cn" or "xxx.cn"? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] miaoyb edited a comment on issue #3759: request help: cors plugins support domain limit
miaoyb edited a comment on issue #3759: URL: https://github.com/apache/apisix/issues/3759#issuecomment-791100711 > We already support this feature. Please read the doc: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/cors.md > > > | allow_origins| string | optional| "*" | | Which Origins is allowed to enable CORS, format as：`scheme`://`host`:`port`, for example: https://somehost.com:8081. Multiple origin use `,` to split. if i want allowed *.xxx.cn,What should I write,like "*.xxx.cn" or "xxx.cn"? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] miaoyb commented on issue #3759: request help: cors plugins support domain limit
miaoyb commented on issue #3759: URL: https://github.com/apache/apisix/issues/3759#issuecomment-791100711 > We already support this feature. Please read the doc: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/cors.md > > > | allow_origins| string | optional| "*" | | Which Origins is allowed to enable CORS, format as：`scheme`://`host`:`port`, for example: https://somehost.com:8081. Multiple origin use `,` to split. if i want allowed *.xxx.cn,What should I write,like"*.xxx.cn" or "xxx.cn"? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1556: feat: rewrite e2e test(route_with_vars_test) with ginkgo
starsz commented on a change in pull request #1556:
URL: https://github.com/apache/apisix-dashboard/pull/1556#discussion_r587979585
##
File path: api/test/e2enew/route/route_with_vars_test.go
##
@@ -0,0 +1,325 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package route
+
+import (
+ "encoding/json"
+ "net/http"
+
+ "github.com/onsi/ginkgo"
+ "github.com/stretchr/testify/assert"
+
+ "e2enew/base"
+)
+
+var upstream map[string]interface{} = map[string]interface{}{
+ "type": "roundrobin",
+ "nodes": []map[string]interface{}{
+ {
+ "host": base.UpstreamIp,
+ "port": 1980,
+ "weight": 1,
+ },
+ },
+}
+
+var _ = ginkgo.Describe("test route with vars (args)", func() {
+ ginkgo.It("add route with vars (args)", func() {
+ t := ginkgo.GinkgoT()
+ var createRouteBody map[string]interface{} =
map[string]interface{}{
+ "uri": "/hello",
+ "vars": [][]string{
+ {"arg_name", "==", "aaa"},
+ },
+ "upstream": upstream,
+ }
+ _createRouteBody, err := json.Marshal(createRouteBody)
+ assert.Nil(t, err)
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/routes/r1",
+ Body: string(_createRouteBody),
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ })
+ })
+ ginkgo.It("hit the route with right args", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.APISIXExpect(),
+ Method: http.MethodGet,
+ Path: `/hello`,
+ Query:"name=aaa",
+ ExpectStatus: http.StatusOK,
+ Sleep:base.SleepTime,
+ })
+ })
+ ginkgo.It("hit the route with wrong args", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.APISIXExpect(),
+ Method: http.MethodGet,
+ Path: `/hello`,
+ Query:"name=bbb",
+ ExpectStatus: http.StatusNotFound,
+ Sleep:base.SleepTime,
+ })
+ })
+ ginkgo.It("hit the route with no args", func() {
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.APISIXExpect(),
+ Method: http.MethodGet,
+ Path: `/hello`,
+ ExpectStatus: http.StatusNotFound,
+ Sleep:base.SleepTime,
+ })
+ })
+
+ ginkgo.It("update route with vars (header)", func() {
+ t := ginkgo.GinkgoT()
+ var createRouteBody map[string]interface{} =
map[string]interface{}{
+ "uri": "/hello",
+ "vars": [][]string{
+ {"http_k", "==", "header"},
+ },
+ "upstream": upstream,
+ }
+ _createRouteBody, err := json.Marshal(createRouteBody)
+ assert.Nil(t, err)
+ base.RunTestCase(base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
+ Method: http.MethodPut,
+ Path: "/apisix/admin/routes/r1",
+ Body: string(_createRouteBody),
+ Headers: map[string]string{"Authorization":
base.GetToken()},
+ ExpectStatus: http.StatusOK,
+ })
+ })
+ ginkgo.It("hit the route with right
[GitHub] [apisix-dashboard] nic-chen commented on issue #1552: health check disable not work
nic-chen commented on issue #1552: URL: https://github.com/apache/apisix-dashboard/issues/1552#issuecomment-791098332 > sorry, I got the wrong version in the test environment, this problem happened on the old version. > The new version looks like it has fixed the problem. OK, thanks for the feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on pull request #1557: feat: sync fields of `upstream` from APISIX
starsz commented on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-791097089 cc @juzhiyuan @LiteSun @liuxiran FE should know this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1557: feat: sync fields of `upstream` from APISIX
codecov-io edited a comment on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-791091588 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=h1) Report > Merging [#1557](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=desc) (ce74769) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9130e09837f7e6283ba4645fab5c482b18a61949?el=desc) (9130e09) will **decrease** coverage by `14.46%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1557 +/- ## === - Coverage 70.18% 55.72% -14.47% === Files 130 49 -81 Lines5340 3164 -2176 Branches 5490 -549 === - Hits 3748 1763 -1985 + Misses 1344 1097 -247 - Partials 248 304 +56 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `55.72% <ø> (+0.03%)` | :arrow_up: | | backend-e2e-test-ginkgo | `40.01% <ø> (+0.41%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `100.00% <ø> (ø)` | | | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `57.44% <0.00%> (-34.05%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `38.46% <0.00%> (-30.77%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.43% <0.00%> (-29.52%)` | :arrow_down: | | ... and [98 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=footer). Last update [9130e09...ce74769](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.
[GitHub] [apisix-dashboard] to2false commented on issue #1552: health check disable not work
to2false commented on issue #1552: URL: https://github.com/apache/apisix-dashboard/issues/1552#issuecomment-791091596 sorry, I got the wrong version in the test environment, this problem happened on the old version. The new version looks like it has fixed the problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] to2false closed issue #1552: health check disable not work
to2false closed issue #1552: URL: https://github.com/apache/apisix-dashboard/issues/1552 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1557: feat: sync fields of `upstream` from APISIX
codecov-io commented on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-791091588 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=h1) Report > Merging [#1557](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=desc) (ce74769) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9130e09837f7e6283ba4645fab5c482b18a61949?el=desc) (9130e09) will **decrease** coverage by `30.17%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1557 +/- ## === - Coverage 70.18% 40.01% -30.18% === Files 130 49 -81 Lines5340 3164 -2176 Branches 5490 -549 === - Hits 3748 1266 -2482 - Misses 1344 1629 +285 - Partials 248 269 +21 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `40.01% <ø> (+0.41%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <ø> (-25.00%)` | :arrow_down: | | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `33.47% <0.00%> (-44.77%)` | :arrow_down: | | ... and [103 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=footer). Last update [9130e09...ce74769](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the
[GitHub] [apisix] spacewander closed issue #3752: request help: error occured at start-up time of apisix(installed mode: compiling)
spacewander closed issue #3752: URL: https://github.com/apache/apisix/issues/3752 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3752: request help: error occured at start-up time of apisix(installed mode: compiling)
spacewander commented on issue #3752: URL: https://github.com/apache/apisix/issues/3752#issuecomment-791088544 Yes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] libeio commented on issue #3752: request help: error occured at start-up time of apisix(installed mode: compiling)
libeio commented on issue #3752: URL: https://github.com/apache/apisix/issues/3752#issuecomment-791088194 > > > My bad! I didn't notice the compile option. You need to add `--with-pcre-jit` for the `./configure`. add option `--with-pcre-jit` when `./configure` the OpenResty? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3757: bug: cors插件和redirect插件组合跨域访问有问题
spacewander commented on issue #3757: URL: https://github.com/apache/apisix/issues/3757#issuecomment-791087985 I doubt whether it is allowed to use CORS and redirect together. I find a documentation https://developer.mozilla.org/zh-CN/docs/Web/HTTP/CORS/Errors/CORSExternalRedirectNotAllowed which says that "CORS request external redirect not allowed" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1557: feat: sync fields of `upstream` from APISIX
nic-chen opened a new pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches We has added two fields for `upstream` in APISIX. We only synchronized the schema in the previous version, and now we need to update the corresponding struct. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yongboy commented on a change in pull request #3742: feat: add control api for discovery module
yongboy commented on a change in pull request #3742:
URL: https://github.com/apache/apisix/pull/3742#discussion_r587964567
##
File path: t/control/discovery.t
##
@@ -0,0 +1,102 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+no_shuffle();
+log_level("info");
+
+
+our $yaml_config = <<_EOC_;
+apisix:
+ enable_control: true
+ node_listen: 1984
+ config_center: yaml
+ enable_admin: false
+
+discovery:
+ eureka:
+host:
+ - "http://127.0.0.1:8761;
+prefix: "/eureka/"
+fetch_interval: 10
+weight: 80
+timeout:
+ connect: 1500
+ send: 1500
+ read: 1500
+ consul_kv:
+servers:
+ - "http://127.0.0.1:8500;
+ - "http://127.0.0.1:8600;
+ dns:
+servers:
+ - "127.0.0.1:1053"
+_EOC_
+
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: test consul_kv dump_data api
+--- yaml_config eval: $::yaml_config
+--- request
+GET /v1/discovery/consul_kv/dump
+--- error_code: 200
+--- response_body_unlike
+^{}$
Review comment:
Y
##
File path: t/control/discovery.t
##
@@ -0,0 +1,102 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+no_shuffle();
+log_level("info");
+
+
+our $yaml_config = <<_EOC_;
+apisix:
+ enable_control: true
+ node_listen: 1984
+ config_center: yaml
+ enable_admin: false
+
+discovery:
+ eureka:
+host:
+ - "http://127.0.0.1:8761;
+prefix: "/eureka/"
+fetch_interval: 10
+weight: 80
+timeout:
+ connect: 1500
+ send: 1500
+ read: 1500
+ consul_kv:
+servers:
+ - "http://127.0.0.1:8500;
+ - "http://127.0.0.1:8600;
+ dns:
+servers:
+ - "127.0.0.1:1053"
+_EOC_
+
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: test consul_kv dump_data api
+--- yaml_config eval: $::yaml_config
+--- request
+GET /v1/discovery/consul_kv/dump
+--- error_code: 200
+--- response_body_unlike
+^{}$
+
+
+
+=== TEST 2: test eureka dump_data api
+--- yaml_config eval: $::yaml_config
+--- request
+GET /v1/discovery/eureka/dump
+--- error_code: 200
+--- response_body_unlike
+^{}$
Review comment:
Y
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] yongboy commented on a change in pull request #3742: feat: add control api for discovery module
yongboy commented on a change in pull request #3742:
URL: https://github.com/apache/apisix/pull/3742#discussion_r587963525
##
File path: docs/en/latest/discovery.md
##
@@ -92,6 +95,11 @@ Then implement the `_M.init_worker()` function for
initialization and the `_M.no
end
+ function _M.dump_data()
+ ... ...
Review comment:
for example ?
```lua
function _M.dump_data()
return {config = your_config, services = your_services, other = ... }
end
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] caukie commented on issue #1549: feat: support `discovery_type` in Dashboard
caukie commented on issue #1549: URL: https://github.com/apache/apisix-dashboard/issues/1549#issuecomment-791081402 > > > @caukie Good suggestion. Thank you very much. > > > PRs are welcomed : ) > > > > > > pretty sorry, i'm not good at nodejs, so which version will you support it? > > what about golang ? : ) i'm a javaer, but i can try with golang if you wish. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3759: request help: cors plugins support domain limit
spacewander closed issue #3759: URL: https://github.com/apache/apisix/issues/3759 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3759: request help: cors plugins support domain limit
spacewander commented on issue #3759: URL: https://github.com/apache/apisix/issues/3759#issuecomment-791079713 We already support this feature. Please read the doc: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/cors.md > | allow_origins| string | optional| "*" | | Which Origins is allowed to enable CORS, format as：`scheme`://`host`:`port`, for example: https://somehost.com:8081. Multiple origin use `,` to split. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: Missing plugins doc of apisix shown in website (#3754)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 8c2d7c9 docs: Missing plugins doc of apisix shown in website (#3754)
8c2d7c9 is described below
commit 8c2d7c9e0842198fdc5b1958f2c702e5e0959ada
Author: Dhawal Kamdar <55776390+dhawal-kam...@users.noreply.github.com>
AuthorDate: Fri Mar 5 07:05:54 2021 +0530
docs: Missing plugins doc of apisix shown in website (#3754)
Co-authored-by: 琚致远
---
docs/en/latest/config.json | 28 ++--
docs/zh/latest/config.json | 28 ++--
2 files changed, 44 insertions(+), 12 deletions(-)
diff --git a/docs/en/latest/config.json b/docs/en/latest/config.json
index 6e70d45..2e24ca5 100644
--- a/docs/en/latest/config.json
+++ b/docs/en/latest/config.json
@@ -23,7 +23,9 @@
"items": [
"plugins/batch-requests",
"plugins/serverless",
-"plugins/redirect"
+"plugins/redirect",
+"plugins/echo",
+"plugins/server-info"
]
},
{
@@ -45,7 +47,8 @@
"plugins/basic-auth",
"plugins/authz-keycloak",
"plugins/wolf-rbac",
-"plugins/openid-connect"
+"plugins/openid-connect",
+"plugins/hmac-auth"
]
},
{
@@ -55,7 +58,8 @@
"plugins/cors",
"plugins/uri-blocker",
"plugins/ip-restriction",
-"plugins/referer-restriction"
+"plugins/referer-restriction",
+"plugins/consumer-restriction"
]
},
{
@@ -69,7 +73,8 @@
"plugins/request-validation",
"plugins/proxy-mirror",
"plugins/api-breaker",
-"plugins/traffic-split"
+"plugins/traffic-split",
+"plugins/request-id"
]
},
{
@@ -78,7 +83,8 @@
"items": [
"plugins/prometheus",
"plugins/zipkin",
-"plugins/skywalking"
+"plugins/skywalking",
+"plugins/node-status"
]
},
{
@@ -90,7 +96,17 @@
"plugins/kafka-logger",
"plugins/udp-logger",
"plugins/syslog",
-"plugins/log-rotate"
+"plugins/log-rotate",
+"plugins/error-log-logger",
+"plugins/sls-logger"
+ ]
+},
+{
+ "type": "category",
+ "label": "Other Protocols",
+ "items": [
+"plugins/dubbo-proxy",
+"plugins/mqtt-proxy"
]
}
]
diff --git a/docs/zh/latest/config.json b/docs/zh/latest/config.json
index 8300073..29b1974 100644
--- a/docs/zh/latest/config.json
+++ b/docs/zh/latest/config.json
@@ -19,7 +19,9 @@
"items": [
"plugins/batch-requests",
"plugins/serverless",
-"plugins/redirect"
+"plugins/redirect",
+"plugins/echo",
+"plugins/server-info"
]
},
{
@@ -41,7 +43,8 @@
"plugins/key-auth",
"plugins/jwt-auth",
"plugins/basic-auth",
-"plugins/openid-connect"
+"plugins/openid-connect",
+"plugins/hmac-auth"
]
},
{
@@ -51,7 +54,8 @@
"plugins/cors",
"plugins/uri-blocker",
"plugins/ip-restriction",
-"plugins/referer-restriction"
+"plugins/referer-restriction",
+"plugins/consumer-restriction"
]
},
{
@@ -65,7 +69,8 @@
"plugins/request-validation",
"plugins/proxy-mirror",
"plugins/api-breaker",
-"plugins/traffic-split"
+"plugins/traffic-split",
+"plugins/request-id"
]
},
{
@@ -74,7 +79,8 @@
"items": [
"plugins/prometheus",
"plugins/zipkin",
-"plugins/skywalking"
+"plugins/skywalking",
+"plugins/node-status"
]
},
{
@@ -86,7 +92,17 @@
"plugins/kafka-logger",
"plugins/udp-logger",
"plugins/syslog",
-"plugins/log-rotate"
+"plugins/log-rotate",
+"plugins/error-log-logger",
+"plugins/sls-logger"
+ ]
+},
+{
+ "type": "category",
+ "label": "其它",
+ "items": [
+"plugins/dubbo-proxy",
+"plugins/mqtt-proxy"
]
}
]
[GitHub] [apisix-website] spacewander closed issue #236: Missing plugins doc of apisix shown in website
spacewander closed issue #236: URL: https://github.com/apache/apisix-website/issues/236 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3754: docs: Missing plugins doc of apisix shown in website
spacewander merged pull request #3754: URL: https://github.com/apache/apisix/pull/3754 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3752: request help: error occured at start-up time of apisix(installed mode: compiling)
spacewander commented on issue #3752: URL: https://github.com/apache/apisix/issues/3752#issuecomment-791076313 My bad! I didn't notice the compile option. You need to add `--with-pcre-jit` for the `./configure`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
tzssangglass commented on a change in pull request #3758:
URL: https://github.com/apache/apisix/pull/3758#discussion_r587953009
##
File path: apisix/plugins/traffic-split.lua
##
@@ -320,6 +324,7 @@ function _M.access(conf, ctx)
core.log.info("upstream: ", core.json.encode(upstream))
return set_upstream(upstream, ctx)
elseif upstream and upstream ~= "plugin#upstream#is#empty" then
+ctx.matched_route.value["original_uid"] =
ctx.matched_route.value.upstream_id
Review comment:
yes, it will be overridden, I continue to fix it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3754: fix: Missing plugins doc of apisix shown in website (#236)
spacewander commented on pull request #3754: URL: https://github.com/apache/apisix/pull/3754#issuecomment-791065981 > > > Hello, @juzhiyuan can you please help me figure out why one check is failing? > In details, it is showing this error: > >  The test failed because: ``` # Failed test 'TEST 1: generate different random number in different worker process - response_body - response is expected (repeated req 0, req 0)' # at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm line 1589. # @@ -1,4 +1,4 @@ # random[1] == random[2]: false # random[2] == random[3]: false # random[3] == random[4]: false # -random[4] == random[5]: false # +random[4] == random[5]: true # Looks like you failed 1 test of 3. t/core/random.t Dubious, test returned 1 (wstat 256, 0x100) ``` Look like this case is unstable. The error message in the image is expected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander removed a comment on pull request #3754: fix: Missing plugins doc of apisix shown in website (#236)
spacewander removed a comment on pull request #3754: URL: https://github.com/apache/apisix/pull/3754#issuecomment-791065250 > > > Hello, @juzhiyuan can you please help me figure out why one check is failing? > In details, it is showing this error: > >  The check is passed. The error message is expected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3754: fix: Missing plugins doc of apisix shown in website (#236)
spacewander commented on pull request #3754: URL: https://github.com/apache/apisix/pull/3754#issuecomment-791065250 > > > Hello, @juzhiyuan can you please help me figure out why one check is failing? > In details, it is showing this error: > >  The check is passed. The error message is expected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3742: feat: add control api for discovery module
spacewander commented on a change in pull request #3742: URL: https://github.com/apache/apisix/pull/3742#discussion_r587945948 ## File path: docs/en/latest/discovery.md ## @@ -66,7 +67,9 @@ It is very easy for APISIX to extend the discovery client, the basic steps are a 2. Implement the `_M. init_worker()` function for initialization and the `_M. nodes(service_name)` function for obtaining the list of service instance nodes; -3. Convert the registry data into data in APISIX; +3. If you need the discovery module to export the debugging information online, implement the `_M. dump_data()` function; Review comment: Yes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #3718: fix: fail to run `make deps` on macOS
nic-chen commented on pull request #3718: URL: https://github.com/apache/apisix/pull/3718#issuecomment-791043598 > In the mac os scenario, we should do this: > > 1. Install lua 5.1: `brew install lua@5.1` > > 2. When calling the luarocks command in make deps, add the parameter `--lua-dir=/usr/local/opt/lua@5.1`, eg: `luarocks --lua-dir=/usr/local/opt/lua@5.1 ***` we use `utils/linux-install-luarocks.sh` to install luarocks, so we use luajit for luarock, and don't need to set lua 5.1 for it. @membphis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1490: feat: support yaml to config plugin in plugin config page
liuxiran commented on pull request #1490: URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-791029918 > Front-end e2e test required. got it, I`ll add it soon, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1540: feat: add plugin template config feature
liuxiran commented on pull request #1540: URL: https://github.com/apache/apisix-dashboard/pull/1540#issuecomment-791029091 > > https://github.com/apache/apisix-dashboard/blob/77b42e839f8a79bbae8e0dd097195bf922076bbb/web/src/pages/Route/components/CreateStep4/CreateStep4.tsx#L63 > > > > also need to support select plugin template configuration > > updated LGTM, it seems that there are some thing wrong with Ci , maybe it need to force push to rerun. and it would be better to add a test case to test for the content of step4 after pr merged thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] ashwindevx commented on issue #229: improve the description for users to join Slack
ashwindevx commented on issue #229: URL: https://github.com/apache/apisix-website/issues/229#issuecomment-790753933 Sorry man. I don't know React yet. I thought the code was in JS. All the code is in react. I don't think I can fix this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1556: feat: rewrite e2e test(route_with_vars_test) with ginkgo
Jaycean opened a new pull request #1556: URL: https://github.com/apache/apisix-dashboard/pull/1556 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues #1500 ___ ### New feature or improvement - Rewrite e2e test(route_with_vars_test) with ginkgo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1540: feat: add plugin template config feature
LiteSun commented on pull request #1540: URL: https://github.com/apache/apisix-dashboard/pull/1540#issuecomment-790714331 > https://github.com/apache/apisix-dashboard/blob/77b42e839f8a79bbae8e0dd097195bf922076bbb/web/src/pages/Route/components/CreateStep4/CreateStep4.tsx#L63 > > also need to support select plugin template configuration updated This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dhawal-kamdar commented on pull request #3754: fix: Missing plugins doc of apisix shown in website (#236)
dhawal-kamdar commented on pull request #3754: URL: https://github.com/apache/apisix/pull/3754#issuecomment-790712536 > @dhawal-kamdar Hi, let's wait for others help :) Okay This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #229: improve the description for users to join Slack
juzhiyuan commented on issue #229: URL: https://github.com/apache/apisix-website/issues/229#issuecomment-790705442  As far as I know, it will expire in over 30 days. @ashwindevx Please use this one `https://join.slack.com/t/the-asf/shared_invite/zt-mrougyeu-2aG7BnFaV0VnAT9_JIUVaA` instead./ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1540: feat: add plugin template config feature
LiteSun commented on pull request #1540: URL: https://github.com/apache/apisix-dashboard/pull/1540#issuecomment-790704003 > LGTM expect that > > https://github.com/apache/apisix-dashboard/blob/77b42e839f8a79bbae8e0dd097195bf922076bbb/web/src/pages/Route/components/CreateStep4/CreateStep4.tsx#L63 > > also need to support select plugin template configuration good catch! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #3754: fix: Missing plugins doc of apisix shown in website (#236)
juzhiyuan commented on pull request #3754: URL: https://github.com/apache/apisix/pull/3754#issuecomment-790703235 @dhawal-kamdar Hi, let's wait for others help :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] moonming commented on issue #229: improve the description for users to join Slack
moonming commented on issue #229: URL: https://github.com/apache/apisix-website/issues/229#issuecomment-790699674 > We should update the link to https://join.slack.com/t/the-asf/shared_invite/zt-lcbw4olf-_5s17RLU0Cx8xTvj2bNbjg Will this link become invalid after some time? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] moonming removed a comment on issue #229: improve the description for users to join Slack
moonming removed a comment on issue #229: URL: https://github.com/apache/apisix-website/issues/229#issuecomment-790696302 how about `http://s.apache.org/apachecon-slack` as the slack link? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran closed issue #1217: support debug file transfer in online debug
liuxiran closed issue #1217: URL: https://github.com/apache/apisix-dashboard/issues/1217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] moonming commented on issue #229: improve the description for users to join Slack
moonming commented on issue #229: URL: https://github.com/apache/apisix-website/issues/229#issuecomment-790696302 how about `http://s.apache.org/apachecon-slack` as the slack link? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1540: feat: add plugin template config feature
liuxiran commented on pull request #1540: URL: https://github.com/apache/apisix-dashboard/pull/1540#issuecomment-790693471 LGTM expect that https://github.com/apache/apisix-dashboard/blob/77b42e839f8a79bbae8e0dd097195bf922076bbb/web/src/pages/Route/components/CreateStep4/CreateStep4.tsx#L63 also need to support select plugin template configuration This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dhawal-kamdar commented on pull request #3754: fix: Missing plugins doc of apisix shown in website (#236)
dhawal-kamdar commented on pull request #3754: URL: https://github.com/apache/apisix/pull/3754#issuecomment-790687343 Hello, @juzhiyuan can you please help me figure out why one check is failing? In details, it is showing this error:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1555: discuss: select upstream in the "Define API Backend Server" should provide a search function
Jaycean commented on issue #1555: URL: https://github.com/apache/apisix-dashboard/issues/1555#issuecomment-790678677 Agree +1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #229: improve the description for users to join Slack
juzhiyuan commented on issue #229: URL: https://github.com/apache/apisix-website/issues/229#issuecomment-790672062 https://github.com/apache/apisix-website/tree/master/website/src/pages This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #3718: fix: fail to run `make deps` on macOS
starsz commented on a change in pull request #3718: URL: https://github.com/apache/apisix/pull/3718#discussion_r587511487 ## File path: Makefile ## @@ -31,6 +31,15 @@ ifeq ($(shell test -d $(addprefix $(OR_PREFIX), openssl111) && echo -n yes), yes OPENSSL_PREFIX=$(addprefix $(OR_PREFIX), openssl111) endif +ifeq ($(UNAME), Darwin) +ifeq ($(shell test -d /usr/local/opt/openresty-openssl && echo yes), yes) + OPENSSL_PREFIX=/usr/local/opt/openresty-openssl +endif +ifeq ($(shell test -d /usr/local/opt/openresty-openssl111 && echo yes), yes) Review comment: I think @nic-chen's explanation is clear. This situation is `if if ` not `if else`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3742: feat: add control api for discovery module
tokers commented on a change in pull request #3742: URL: https://github.com/apache/apisix/pull/3742#discussion_r587481740 ## File path: docs/en/latest/discovery.md ## @@ -92,6 +95,11 @@ Then implement the `_M.init_worker()` function for initialization and the `_M.no end + function _M.dump_data() + ... ... Review comment: I think an example return data shoul be written here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3759: request help: cors plugins support domain limit
tokers commented on issue #3759: URL: https://github.com/apache/apisix/issues/3759#issuecomment-790624305 Would you like to submit a pr? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] ashwindevx commented on issue #229: improve the description for users to join Slack
ashwindevx commented on issue #229: URL: https://github.com/apache/apisix-website/issues/229#issuecomment-790624154 I can't find the `index.html` file. Which folder has the `help` page? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3760: feat: support the upstream configuration keepalive related parameters in nginx.conf.
tokers commented on issue #3760: URL: https://github.com/apache/apisix/issues/3760#issuecomment-790623370 It may not support per upstream, but supports to customize in config.y'all. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3718: fix: fail to run `make deps` on macOS
tokers commented on a change in pull request #3718: URL: https://github.com/apache/apisix/pull/3718#discussion_r587471688 ## File path: Makefile ## @@ -31,6 +31,15 @@ ifeq ($(shell test -d $(addprefix $(OR_PREFIX), openssl111) && echo -n yes), yes OPENSSL_PREFIX=$(addprefix $(OR_PREFIX), openssl111) endif +ifeq ($(UNAME), Darwin) +ifeq ($(shell test -d /usr/local/opt/openresty-openssl && echo yes), yes) + OPENSSL_PREFIX=/usr/local/opt/openresty-openssl +endif +ifeq ($(shell test -d /usr/local/opt/openresty-openssl111 && echo yes), yes) Review comment: Sorry I didn't capture your mean. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1553: fix: Frontend e2e test for#1538
LiteSun merged pull request #1553: URL: https://github.com/apache/apisix-dashboard/pull/1553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: fix: Frontend e2e test for#1538 (#1553)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 77b42e8 fix: Frontend e2e test for#1538 (#1553)
77b42e8 is described below
commit 77b42e839f8a79bbae8e0dd097195bf922076bbb
Author: guoqqqi <72343596+guoq...@users.noreply.github.com>
AuthorDate: Thu Mar 4 20:41:45 2021 +0800
fix: Frontend e2e test for#1538 (#1553)
* fix: update code
* fix: CI error
---
web/cypress/integration/route/import_export_route.spec.js | 7 +++
web/cypress/integration/route/search-route.spec.js| 2 +-
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/web/cypress/integration/route/import_export_route.spec.js
b/web/cypress/integration/route/import_export_route.spec.js
index d8730cf..dcf9c1a 100644
--- a/web/cypress/integration/route/import_export_route.spec.js
+++ b/web/cypress/integration/route/import_export_route.spec.js
@@ -42,6 +42,7 @@ context('import and export routes', () => {
cy.login();
cy.fixture('selector.json').as('domSelector');
+cy.fixture('data.json').as('data');
cy.fixture('export-route-dataset.json').as('exportFile');
});
it('should create route1 and route2', function () {
@@ -129,8 +130,7 @@ context('import and export routes', () => {
.click();
cy.contains('button',
componentLocaleUS['component.global.confirm']).click();
cy.get(this.domSelector.notification).should(
-'contain',
-`${componentLocaleUS['component.global.delete']}
${menuLocaleUS['menu.routes']}
${componentLocaleUS['component.status.success']}`,
+'contain', this.data.deleteRouteSuccess
);
}
});
@@ -154,8 +154,7 @@ context('import and export routes', () => {
cy.contains(componentLocaleUS['component.global.cancel']).click();
} else {
cy.get(this.domSelector.notification).should(
- 'contain',
- `${routeLocaleUS['page.route.button.importOpenApi']}
${componentLocaleUS['component.status.success']}`,
+ 'contain', 'Success'
);
cy.get(this.domSelector.notificationCloseIcon).click();
// delete route just imported
diff --git a/web/cypress/integration/route/search-route.spec.js
b/web/cypress/integration/route/search-route.spec.js
index d6ffa17..be3e0c2 100644
--- a/web/cypress/integration/route/search-route.spec.js
+++ b/web/cypress/integration/route/search-route.spec.js
@@ -103,7 +103,7 @@ context('Create and Search Route', () => {
// search one label
cy.get(this.domSelector.refresh).click();
cy.get(this.domSelector.labelSelector).click();
-cy.get(this.domSelector.dropdown).within(() => {
+cy.get(this.domSelector.dropdown).should('be.visible').within(() => {
cy.contains(data.value0).click();
});
cy.contains('Search').click();
[GitHub] [apisix] Firstsawyou commented on pull request #3556: feat: support rewrite HTTP method
Firstsawyou commented on pull request #3556: URL: https://github.com/apache/apisix/pull/3556#issuecomment-790588373 @54corbin You need to resolve the conflict first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
