[GitHub] [apisix-docker] gxthrj merged pull request #146: feat: release 2.4
gxthrj merged pull request #146: URL: https://github.com/apache/apisix-docker/pull/146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-docker] branch master updated: feat: release 2.4 (#146)
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-docker.git
The following commit(s) were added to refs/heads/master by this push:
new 60cd292 feat: release 2.4 (#146)
60cd292 is described below
commit 60cd292e6937398a420dcbbab230b00c678cb0f4
Author: Shuyang Wu
AuthorDate: Mon Mar 8 15:59:34 2021 +0800
feat: release 2.4 (#146)
* feat: release 2.4
Signed-off-by: yiyiyimu
* change all 2.3 to 2.4
Signed-off-by: yiyiyimu
* change all 2.3 to 2.4
Signed-off-by: yiyiyimu
* fix some other version issue
Signed-off-by: yiyiyimu
* revert compose version
Signed-off-by: yiyiyimu
---
.github/workflows/apisix-docker-test.yaml | 2 +-
Makefile | 2 +-
README.md | 6 +++---
alpine/Dockerfile | 2 +-
centos/Dockerfile | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/.github/workflows/apisix-docker-test.yaml
b/.github/workflows/apisix-docker-test.yaml
index f83fb3b..6b1b882 100644
--- a/.github/workflows/apisix-docker-test.yaml
+++ b/.github/workflows/apisix-docker-test.yaml
@@ -21,7 +21,7 @@ jobs:
runs-on: ubuntu-latest
env:
APISIX_PATH: "./apisix-local"
- APISIX_DOCKER_TAG: 2.3-${{ matrix.platform }}
+ APISIX_DOCKER_TAG: 2.4-${{ matrix.platform }}
steps:
- uses: actions/checkout@v2
diff --git a/Makefile b/Makefile
index f6337d7..4671949 100644
--- a/Makefile
+++ b/Makefile
@@ -16,7 +16,7 @@
#
default: help
-APISIX_VERSION ?= 2.3
+APISIX_VERSION ?= 2.4
IMAGE_NAME = apache/apisix
IMAGE_TAR_NAME = apache_apisix
diff --git a/README.md b/README.md
index c16fd2a..444cc5e 100644
--- a/README.md
+++ b/README.md
@@ -8,9 +8,9 @@
1. Build from release version:
```
-# Assign Apache release version number to variable `APISIX_VERSION`, for
example: 2.2. The latest version can be find at
`https://github.com/apache/apisix/releases`
+# Assign Apache release version number to variable `APISIX_VERSION`, for
example: 2.4. The latest version can be find at
`https://github.com/apache/apisix/releases`
-export APISIX_VERSION=2.2
+export APISIX_VERSION=2.4
docker build -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine
```
@@ -63,7 +63,7 @@ $ docker run -v
`pwd`/all-in-one/apisix/config.yaml:/usr/local/apisix/conf/confi
**The latest version of `apisix-dashboard` is 2.4 and should be used with
APISIX 2.3.**
```shell
-$ docker build --build-arg APISIX_VERSION=2.2 --build-arg
APISIX_DASHBOARD_VERSION=v2.3 -t apache/apisix-dashboard:whole -f
./all-in-one/apisix-dashboard/Dockerfile .
+$ docker build --build-arg APISIX_VERSION=2.3 --build-arg
APISIX_DASHBOARD_VERSION=v2.4 -t apache/apisix-dashboard:whole -f
./all-in-one/apisix-dashboard/Dockerfile .
$ docker run -v
`pwd`/all-in-one/apisix/config.yaml:/usr/local/apisix/conf/config.yaml -v
`pwd`/all-in-one/apisix-dashboard/conf.yaml:/usr/local/apisix-dashboard/conf/conf.yaml
-p 9080:9080 -p 2379:2379 -p 9000:9000 -d apache/apisix-dashboard:whole
```
diff --git a/alpine/Dockerfile b/alpine/Dockerfile
index f981722..27c46a8 100644
--- a/alpine/Dockerfile
+++ b/alpine/Dockerfile
@@ -2,7 +2,7 @@ ARG ENABLE_PROXY=false
FROM openresty/openresty:alpine-fat AS production-stage
-ARG APISIX_VERSION=2.3
+ARG APISIX_VERSION=2.4
LABEL apisix_version="${APISIX_VERSION}"
ARG ENABLE_PROXY
diff --git a/centos/Dockerfile b/centos/Dockerfile
index 3c26392..dbf557a 100644
--- a/centos/Dockerfile
+++ b/centos/Dockerfile
@@ -1,6 +1,6 @@
FROM centos:7
-ARG APISIX_VERSION=2.3
+ARG APISIX_VERSION=2.4
LABEL apisix_version="${APISIX_VERSION}"
RUN yum -y install yum-utils\
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1556: feat: rewrite e2e test(route_with_vars_test) with ginkgo
Jaycean commented on pull request #1556: URL: https://github.com/apache/apisix-dashboard/pull/1556#issuecomment-792549781 cc @starsz PTAL Thks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on issue #250: incorrect powered-by.md link
KishaniKandasamy commented on issue #250: URL: https://github.com/apache/apisix-website/issues/250#issuecomment-792548740 > it sees that @KishaniKandasamy is working on this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] liuxiran merged pull request #251: docs: fixed broken powered-by.md link
liuxiran merged pull request #251: URL: https://github.com/apache/apisix-website/pull/251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] liuxiran closed issue #250: incorrect powered-by.md link
liuxiran closed issue #250: URL: https://github.com/apache/apisix-website/issues/250 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: docs: fixed broken powered-by.md link (#251)
This is an automated email from the ASF dual-hosted git repository.
liuxiran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 1dd7bd6 docs: fixed broken powered-by.md link (#251)
1dd7bd6 is described below
commit 1dd7bd69293298a7c9b6802044963e376c720b0a
Author: Ayush das
AuthorDate: Mon Mar 8 13:02:42 2021 +0530
docs: fixed broken powered-by.md link (#251)
---
website/src/pages/index.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/website/src/pages/index.js b/website/src/pages/index.js
index 497b319..8764552 100644
--- a/website/src/pages/index.js
+++ b/website/src/pages/index.js
@@ -136,7 +136,7 @@ const Showcase = () => {
Are you using this project?
https://github.com/apache/apisix/blob/master/docs/en/latest/powered-by.md;
+href="https://github.com/apache/apisix/blob/master/powered-by.md;
target="_blank"
rel="noopener"
>
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (428485d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/938b2b9f34c5fa5e7ef6fddef29acb29b25c09a1?el=desc) (938b2b9) will **decrease** coverage by `31.02%`. > The diff coverage is `26.31%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1558 +/- ## === - Coverage 70.86% 39.83% -31.03% === Files 135 49 -86 Lines5485 3173 -2312 Branches 5830 -583 === - Hits 3887 1264 -2623 - Misses 1350 1637 +287 - Partials 248 272 +24 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `39.83% <26.31%> (-0.21%)` | :arrow_down: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `34.27% <26.31%> (-43.97%)` | :arrow_down: | | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `30.55% <0.00%> (-41.67%)` | :arrow_down: | | ... and [106 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [938b2b9...428485d](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please
[GitHub] [apisix] No-sleeping opened a new issue #3777: request help: plz ，i wanne konw why this result linear .can u offer more detail configuration parameter？
No-sleeping opened a new issue #3777: URL: https://github.com/apache/apisix/issues/3777 ### Issue description 想问下，这里是怎么能够达到线性得。 能提供下这里执行得wrk命令么， 请问下这这里压测得时用得是长连接还是短链接？ ### Environment  * apisix version (cmd: `apisix version`): * OS (cmd: `uname -a`): * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): * apisix-dashboard version, if have: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #284: feat: support secret controller
tokers commented on pull request #284: URL: https://github.com/apache/apisix-ingress-controller/pull/284#issuecomment-792507886 @gxthrj PR's look good to me, but we should add more descriptions about `ApisixTLS` to document, both the typical usage and API references should be recorded, I think we can create an issue to do it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu opened a new issue #148: Use Github Actions to automate upload image to Dockerhub
Yiyiyimu opened a new issue #148: URL: https://github.com/apache/apisix-docker/issues/148 Currently we need maintainers to upload release images to Dockerhub manually. Following https://docs.github.com/en/actions/guides/publishing-docker-images, we could find how to use GitHub actions to do the upload step, for example, triggered by release branch. However, due to Apache rules, there are chances that we are not allowed to use Github Actions provided by docker. So we might need to use Docker API to write the auto-upload scripts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan closed issue #3774: docs: modify the document table of contents to make it easier to read.
juzhiyuan closed issue #3774: URL: https://github.com/apache/apisix/issues/3774 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan merged pull request #3776: docs: split architecture-design
juzhiyuan merged pull request #3776: URL: https://github.com/apache/apisix/pull/3776 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: split architecture-design (#3776)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 9d97b73 docs: split architecture-design (#3776) 9d97b73 is described below commit 9d97b7368f65ad9259fc982465ddd28943a4a1e7 Author: 罗泽轩 AuthorDate: Mon Mar 8 14:28:05 2021 +0800 docs: split architecture-design (#3776) --- docs/en/latest/architecture-design.md | 811 - docs/en/latest/architecture-design/apisix.md | 56 ++ docs/en/latest/architecture-design/consumer.md | 126 docs/en/latest/architecture-design/debug-mode.md | 78 ++ docs/en/latest/architecture-design/global-rule.md | 51 ++ .../en/latest/architecture-design/plugin-config.md | 141 docs/en/latest/architecture-design/plugin.md | 65 ++ docs/en/latest/architecture-design/route.md| 62 ++ docs/en/latest/architecture-design/router.md | 39 + docs/en/latest/architecture-design/script.md | 39 + docs/en/latest/architecture-design/service.md | 87 +++ docs/en/latest/architecture-design/upstream.md | 217 ++ docs/en/latest/config.json | 17 +- 13 files changed, 976 insertions(+), 813 deletions(-) diff --git a/docs/en/latest/architecture-design.md b/docs/en/latest/architecture-design.md deleted file mode 100644 index e751da8..000 --- a/docs/en/latest/architecture-design.md +++ /dev/null @@ -1,811 +0,0 @@ -title: Architecture Design - - - -## Table of Contents - -- [Table of Contents](#table-of-contents) -- [APISIX](#apisix) - - [Plugin Loading Process](#plugin-loading-process) - - [Plugin Hierarchy Structure](#plugin-hierarchy-structure) -- [APISIX Config](#apisix-config) -- [Route](#route) -- [Service](#service) -- [Plugin](#plugin) -- [Script](#script) -- [Upstream](#upstream) - - [Configuration](#configuration) -- [Consumer](#consumer) -- [Cookie](#cookie) -- [Header](#header) -- [Router](#router) -- [Consumer](#consumer-1) -- [Global Rule](#global-rule) -- [Plugin Config](#plugin-config) -- [Debug mode](#debug-mode) - - [Basic Debug Mode](#basic-debug-mode) - - [Advanced Debug Mode](#advanced-debug-mode) - -## APISIX - -### Plugin Loading Process - - - -### Plugin Hierarchy Structure - - - -## APISIX Config - -There are two methods to configure APISIX: directly change `conf/config.yaml`, or add file path argument using `-c` or `--config` flag when start APISIX like `apisix start -c ` - -For example, set the default listening port of APISIX to 8000, and keep other configurations as default. The configuration in `config.yaml` should be like this: - -```yaml -apisix: - node_listen: 8000 # APISIX listening port -``` - -Set the default listening port of APISIX to 8000, set the `etcd` address to `http://foo:2379`, -and keep other configurations as default. The configuration in `config.yaml` should be like this: - -```yaml -apisix: - node_listen: 8000 # APISIX listening port - -etcd: - host: "http://foo:2379; # etcd address -``` - -Other default configurations can be found in the `conf/config-default.yaml` file, which is bound to the APISIX source code. **Never** manually modify the `conf/config-default.yaml` file. If you need to customize any configuration, you should update the `config.yaml` file. - -**Note** `APISIX` will generate `conf/nginx.conf` file automatically, so please _DO NOT EDIT_ `conf/nginx.conf` file too. - -[Back to top](#table-of-contents) - -## Route - -The route matches the client's request by defining rules, then loads and executes the corresponding plugin based on the matching result, and forwards the request to the specified Upstream. - -The route mainly consists of three parts: matching rules (e.g uri, host, remote_addr, etc.), plugin configuration (current-limit & rate-limit, etc.) and upstream information. - -The following image shows an example of some Route rules. When some attribute values are the same, the figure is identified by the same color. - - - -We configure all the parameters directly in the Route, it's easy to set up, and each Route has a relatively high degree of freedom. But when our Route has more repetitive configurations (such as enabling the same plugin configuration or upstream information), once we need update these same properties, we have to traverse all the Routes and modify them, so it's adding a lot of complexity of management and maintenance. - -The shortcomings mentioned above are independently abstracted in APISIX by the two concepts [Service](#service) and [Upstream](#upstream). - -The route example created below is to proxy the request with URL `/index.html` to the Upstream
[GitHub] [apisix-website] juzhiyuan commented on issue #250: incorrect powered-by.md link
juzhiyuan commented on issue #250: URL: https://github.com/apache/apisix-website/issues/250#issuecomment-792504015 it sees that @KishaniKandasamy is working on this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan closed issue #3767: docs: fix powered-by link
juzhiyuan closed issue #3767: URL: https://github.com/apache/apisix/issues/3767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #3767: docs: fix powered-by link
juzhiyuan commented on issue #3767: URL: https://github.com/apache/apisix/issues/3767#issuecomment-792503348 Ya This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #286: Proposal: Need to block the ip and id that appear in the declarative configuration
gxthrj opened a new issue #286: URL: https://github.com/apache/apisix-ingress-controller/issues/286 ### Issue description We need a simpler configuration to block some specific implementations of APISIX. Need to make a layer of abstraction, Just like the traffic-split plugin, you don’t want upstream Id or node IP to appear in the declarative configuration. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (3bfcbde) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/938b2b9f34c5fa5e7ef6fddef29acb29b25c09a1?el=desc) (938b2b9) will **decrease** coverage by `30.90%`. > The diff coverage is `26.31%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1558 +/- ## === - Coverage 70.86% 39.96% -30.91% === Files 135 49 -86 Lines5485 3173 -2312 Branches 5830 -583 === - Hits 3887 1268 -2619 - Misses 1350 1632 +282 - Partials 248 273 +25 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `39.96% <26.31%> (-0.09%)` | :arrow_down: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `34.27% <26.31%> (-43.97%)` | :arrow_down: | | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `30.55% <0.00%> (-41.67%)` | :arrow_down: | | ... and [106 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [938b2b9...fec3d8b](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please
[GitHub] [apisix-website] iamayushdas opened a new pull request #251: docs: fixed broken powered-by.md link
iamayushdas opened a new pull request #251: URL: https://github.com/apache/apisix-website/pull/251 Fixes: #[Add issue number here] Changes: Screenshots of the change: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Firstsawyou opened a new issue #1563: discuss: the "Host" in the active health check should be optional
Firstsawyou opened a new issue #1563: URL: https://github.com/apache/apisix-dashboard/issues/1563 # Feature request ## Please describe your feature In the active health check, Host is the host name of the HTTP request used to discover the health of the upstream node. It is required only when the upstream node has restrictions on Host, otherwise it is optional. In the current active check configuration, `Host` is a required option. I think it would be better if Host should be an optional option. ## Describe the solution you'd like It would be better if the `Host` configuration is an option in the active check configuration. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] rockXiaofeng removed a comment on issue #3725: request help: about dubbo proxy
rockXiaofeng removed a comment on issue #3725: URL: https://github.com/apache/apisix/issues/3725#issuecomment-792435805 > I submitted a bug report to dubbo-go previously: [apache/dubbo-go#993](https://github.com/apache/dubbo-go/issues/993) Hi, we found AlexanderStocks of the dubbo-go project, maybe we can work together to solve this problem? (My wechat: xfaitmt) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] rockXiaofeng commented on issue #3725: request help: about dubbo proxy
rockXiaofeng commented on issue #3725: URL: https://github.com/apache/apisix/issues/3725#issuecomment-792478460 > If there is any new update with [apache/dubbo-go#993](https://github.com/apache/dubbo-go/issues/993), please discuss in that issue directly. We are working with open source project, not something need to be private. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] stu01509 commented on issue #3767: docs: fix powered-by link
stu01509 commented on issue #3767: URL: https://github.com/apache/apisix/issues/3767#issuecomment-792471670 Hi @juzhiyuan Seems like this issue has been solved, we can close it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] stu01509 commented on issue #250: incorrect powered-by.md link
stu01509 commented on issue #250: URL: https://github.com/apache/apisix-website/issues/250#issuecomment-792470227 Anyone is working on this issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers edited a comment on issue #3775: plugin server-info will write data to etcd
tokers edited a comment on issue #3775: URL: https://github.com/apache/apisix/issues/3775#issuecomment-792468016 It's difficult to do it without introducing any other components. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3775: plugin server-info will write data to etcd
tokers commented on issue #3775: URL: https://github.com/apache/apisix/issues/3775#issuecomment-792468016 It's difficult to do ti without introducing any other components. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #239: feat: fixes #220
1502shivam-singh commented on a change in pull request #239:
URL: https://github.com/apache/apisix-website/pull/239#discussion_r589173542
##
File path: website/src/pages/index.js
##
@@ -134,7 +134,7 @@ const Showcase = () => {
This project is used by all these folks
- Are you using this project?
+ Are you using this project?
https://github.com/apache/apisix/blob/master/docs/en/latest/powered-by.md;
Review comment:
Okay, will fix this issue, in #250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] stu01509 commented on pull request #3721: chore: update skywalking plugin to v0.4.0
stu01509 commented on pull request #3721: URL: https://github.com/apache/apisix/pull/3721#issuecomment-792464906 Hi @spacewander Updated the commit. cc @juzhiyuan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1560: feat: rewrite e2e test(route-with-valid-remote-addr-test) with ginkgo
Jaycean commented on pull request #1560: URL: https://github.com/apache/apisix-dashboard/pull/1560#issuecomment-792457300 > Using `table.Entry` is better for us, and we could clearly see the comparison before and after the modification. Here also need to create route and replace upstream_ id，`table.entry` There is no way to create a new variable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1561: feat: rewrite e2e test(route_with_uri_uris_test) with ginkgo
Jaycean commented on pull request #1561: URL: https://github.com/apache/apisix-dashboard/pull/1561#issuecomment-792454932 > I think using `table.Entry` is better for us Yes, but creating route requires replacing upstream_id `table.entry` There is no way to create a new variable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #284: feat: support secret controller
codecov-io edited a comment on pull request #284: URL: https://github.com/apache/apisix-ingress-controller/pull/284#issuecomment-792198315 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=h1) Report > Merging [#284](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=desc) (8fb5f0d) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/c65cc2384a68b3bd17f886ee2c03e72aafea1206?el=desc) (c65cc23) will **increase** coverage by `0.06%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=tree) ```diff @@Coverage Diff @@ ## master #284 +/- ## == + Coverage 52.19% 52.26% +0.06% == Files 33 32 -1 Lines2320 2319 -1 == + Hits 1211 1212 +1 + Misses952 950 -2 Partials 157 157 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `4.00% <ø> (+2.00%)` | :arrow_up: | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284/diff?src=pr=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=footer). Last update [c65cc23...8fb5f0d](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #284: feat: support secret controller
gxthrj commented on a change in pull request #284:
URL:
https://github.com/apache/apisix-ingress-controller/pull/284#discussion_r589160009
##
File path: pkg/ingress/controller/secret.go
##
@@ -0,0 +1,203 @@
+package controller
+
+import (
+ "context"
+ "fmt"
+ "sync"
+ "time"
+
+ "go.uber.org/zap"
+ corev1 "k8s.io/api/core/v1"
+ k8serrors "k8s.io/apimachinery/pkg/api/errors"
+ "k8s.io/apimachinery/pkg/util/runtime"
+ "k8s.io/client-go/tools/cache"
+ "k8s.io/client-go/util/workqueue"
+
+ "github.com/apache/apisix-ingress-controller/pkg/log"
+ "github.com/apache/apisix-ingress-controller/pkg/seven/state"
+ "github.com/apache/apisix-ingress-controller/pkg/types"
+ apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+type secretController struct {
+ controller *Controller
+ workqueue workqueue.RateLimitingInterface
+ workersint
+}
+
+func (c *Controller) newSecretController() *secretController {
+ ctl := {
+ controller: c,
+ workqueue:
workqueue.NewNamedRateLimitingQueue(workqueue.NewItemFastSlowRateLimiter(1*time.Second,
60*time.Second, 5), "Secrets"),
+ workers:1,
+ }
+
+ ctl.controller.secretInformer.AddEventHandler(
+ cache.ResourceEventHandlerFuncs{
+ AddFunc:ctl.onAdd,
+ UpdateFunc: ctl.onUpdate,
+ DeleteFunc: ctl.onDelete,
+ },
+ )
+
+ return ctl
+}
+
+func (c *secretController) run(ctx context.Context) {
+ log.Info("secret controller started")
+ defer log.Info("secret controller exited")
+
+ if ok := cache.WaitForCacheSync(ctx.Done(),
c.controller.secretInformer.HasSynced); !ok {
+ log.Error("informers sync failed")
+ return
+ }
+
+ handler := func() {
+ for {
+ obj, shutdown := c.workqueue.Get()
+ if shutdown {
+ return
+ }
+ err := func(obj interface{}) error {
+ defer c.workqueue.Done(obj)
+ var key string
+ event := obj.(*types.Event)
+ if secret, ok := event.Object.(*corev1.Secret);
!ok {
+ c.workqueue.Forget(obj)
+ return fmt.Errorf("expected Secret in
workqueue but got %#v", obj)
+ } else {
+ if err := c.sync(ctx,
obj.(*types.Event)); err != nil {
+ c.workqueue.AddRateLimited(obj)
+ log.Errorf("sync secret with
ssl %s failed", secret.Namespace+"_"+secret.Name)
+ return fmt.Errorf("error
syncing '%s': %s", key, err.Error())
+ }
+ c.workqueue.Forget(obj)
+ return nil
+ }
+ }(obj)
+ if err != nil {
+ runtime.HandleError(err)
+ }
+ }
+ }
+
+ for i := 0; i < c.workers; i++ {
+ go handler()
+ }
+
+ <-ctx.Done()
+ c.workqueue.ShutDown()
+}
+
+func (c *secretController) sync(ctx context.Context, ev *types.Event) error {
+ obj := ev.Object.(*corev1.Secret)
+ sec, err :=
c.controller.secretLister.Secrets(obj.Namespace).Get(obj.Name)
+
+ key := obj.Namespace + "_" + obj.Name
+ if err != nil {
+ if !k8serrors.IsNotFound(err) {
+ log.Errorw("failed to get Secret",
+ zap.String("version", obj.ResourceVersion),
+ zap.String("key", key),
+ zap.Error(err),
+ )
+ return err
+ }
+
+ if ev.Type != types.EventDelete {
+ log.Warnw("Secret was deleted before it can be
delivered",
+ zap.String("key", key),
+ zap.String("version", obj.ResourceVersion),
+ )
+ return nil
+ }
+ }
+ if ev.Type == types.EventDelete {
+ if sec != nil {
+ // We still find the resource while we are processing
the DELETE event,
+ // that means object with same namespace and name was
created, discarding
+ // this stale DELETE event.
+ log.Warnw("discard the stale
[apisix-website] branch master updated: docs: added event about releasing APISIX 2.4 (#248)
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new b5d900b docs: added event about releasing APISIX 2.4 (#248)
b5d900b is described below
commit b5d900b48b85e04cf8c71019546a8d912a7a769c
Author: Shivam Singh <57267960+1502shivam-si...@users.noreply.github.com>
AuthorDate: Mon Mar 8 09:42:19 2021 +0530
docs: added event about releasing APISIX 2.4 (#248)
---
.../events/2021-03-05-release-apache-apisix-2.4.md | 33 ++
website/static/data/events.json| 4 +++
2 files changed, 37 insertions(+)
diff --git a/website/events/2021-03-05-release-apache-apisix-2.4.md
b/website/events/2021-03-05-release-apache-apisix-2.4.md
new file mode 100644
index 000..6629056
--- /dev/null
+++ b/website/events/2021-03-05-release-apache-apisix-2.4.md
@@ -0,0 +1,33 @@
+---
+title: Release Apache APISIX 2.4
+---
+
+
+
+### Change
+
+- change: global rules should not be executed on the internal api by default
[#3396](https://github.com/apache/apisix/pull/3396)
+- change: default to cache DNS record according to the TTL
[#3530](https://github.com/apache/apisix/pull/3530)
+
+### Core
+
+- :sunrise: feat: support SRV record
[#3686](https://github.com/apache/apisix/pull/3686)
+- :sunrise: feat: add dns discovery
[#3629](https://github.com/apache/apisix/pull/3629)
+- :sunrise: feat: add consul kv discovery module
[#3615](https://github.com/apache/apisix/pull/3615)
+- :sunrise: feat: support to bind plugin config by `plugin_config_id`
[#3567](https://github.com/apache/apisix/pull/3567)
+- :sunrise: feat: support listen http2 with plaintext
[#3547](https://github.com/apache/apisix/pull/3547)
+- :sunrise: feat: support DNS record
[#3484](https://github.com/apache/apisix/pull/3484)
+
+### Plugin
+
+- :sunrise: feat: the traffic-split plugin supports `upstream_id`
[#3512](https://github.com/apache/apisix/pull/3512)
+- :sunrise: feat(zipkin): support b3 req header
[#3551](https://github.com/apache/apisix/pull/3551)
+
+### Bugfix
+
+- fix(chash): ensure retry can try every node
[#3651](https://github.com/apache/apisix/pull/3651)
+- fix: script does not work when the route is bound to a service
[#3678](https://github.com/apache/apisix/pull/3678)
+- fix: use openssl111 in openresty dir in precedence
[#3603](https://github.com/apache/apisix/pull/3603)
+- fix(zipkin): don't cache the per-req sample ratio
[#3522](https://github.com/apache/apisix/pull/3522)
+
+For more changes, please refer to
[Milestone](https://github.com/apache/apisix/milestone/13)
diff --git a/website/static/data/events.json b/website/static/data/events.json
index 4b46066..ef979d9 100644
--- a/website/static/data/events.json
+++ b/website/static/data/events.json
@@ -1,5 +1,9 @@
[
{
+"title": "Release Apache APISIX 2.4",
+"fileName": "2021-03-05-release-apache-apisix-2.4"
+ },
+ {
"title": "Release Apache APISIX Dashboard 2.4",
"fileName": "2021-02-12-release-apache-apisix-dashboard-2.4"
},
[GitHub] [apisix-website] membphis closed issue #246: docs: added event about releasing APISIX 2.4
membphis closed issue #246: URL: https://github.com/apache/apisix-website/issues/246 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] membphis merged pull request #248: docs: added event about releasing APISIX 2.4
membphis merged pull request #248: URL: https://github.com/apache/apisix-website/pull/248 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #3718: fix: fail to run `make deps` on macOS
nic-chen commented on pull request #3718: URL: https://github.com/apache/apisix/pull/3718#issuecomment-792447973 > In the mac os scenario, we should do this: > > 1. Install lua 5.1: `brew install lua@5.1` > 2. When calling the luarocks command in make deps, add the parameter `--lua-dir=/usr/local/opt/lua@5.1`, eg: `luarocks --lua-dir=/usr/local/opt/lua@5.1 ***` update to use brew to install luarocks. please have a look when you have time. @membphis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (5ef0297) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/938b2b9f34c5fa5e7ef6fddef29acb29b25c09a1?el=desc) (938b2b9) will **decrease** coverage by `30.90%`. > The diff coverage is `26.31%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1558 +/- ## === - Coverage 70.86% 39.96% -30.91% === Files 135 49 -86 Lines5485 3173 -2312 Branches 5830 -583 === - Hits 3887 1268 -2619 - Misses 1350 1632 +282 - Partials 248 273 +25 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `39.96% <26.31%> (-0.09%)` | :arrow_down: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `34.27% <26.31%> (-43.97%)` | :arrow_down: | | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `30.55% <0.00%> (-41.67%)` | :arrow_down: | | ... and [106 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [938b2b9...5ef0297](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please
[GitHub] [apisix-docker] starsz commented on issue #147: Replace `docker build` command with `make` command in README
starsz commented on issue #147: URL: https://github.com/apache/apisix-docker/issues/147#issuecomment-792447453 > Another problem is that there are too many hardcoded VERSION in this repo, say we don't need a default one in alpine/Dockerfile when we tend to set VERSION each time we build image. We could also fix this problem at the same time. Agree +1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan opened a new issue #250: incorrect powered-by.md link
juzhiyuan opened a new issue #250: URL: https://github.com/apache/apisix-website/issues/250 Hi, would you mind fixing this link in this PR? The correct one is `https://github.com/apache/apisix/blob/master/powered-by.md` _Originally posted by @juzhiyuan in https://github.com/apache/apisix-website/pull/239#discussion_r589125799_ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #239: feat: fixes #220
juzhiyuan merged pull request #239: URL: https://github.com/apache/apisix-website/pull/239 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: fix: #220 (#239)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new d406a66 fix: #220 (#239)
d406a66 is described below
commit d406a6662550af46486a9fc9e26391302a781db0
Author: Shivam Singh <57267960+1502shivam-si...@users.noreply.github.com>
AuthorDate: Mon Mar 8 09:35:34 2021 +0530
fix: #220 (#239)
---
website/docs/general/subscribe-guide.md | 2 ++
website/src/css/customTheme.css | 38 +
website/src/pages/index.js | 32 +++
3 files changed, 72 insertions(+)
diff --git a/website/docs/general/subscribe-guide.md
b/website/docs/general/subscribe-guide.md
index f568439..d5131c4 100644
--- a/website/docs/general/subscribe-guide.md
+++ b/website/docs/general/subscribe-guide.md
@@ -13,3 +13,5 @@ During the process of using Apache APISIX, if there has any
problems, suggestion
3. Receive the Welcome e-mail. After finishing the two steps above, an e-mail
with the subject of WELCOME to d...@apisix.apache.org will be sent to your
e-mail address. Until now, you have succeeded in subscribing Apache APISIX
mailing-list.
4. Until now, you can interact with community by your subscribed email or
track email conversations by Archived email list.
+
+5. To view the Archived email lists, check out [history
mailing-list](https://lists.apache.org/list.html?apisix.apache.org).
diff --git a/website/src/css/customTheme.css b/website/src/css/customTheme.css
index 21af8fa..ecf9ad4 100644
--- a/website/src/css/customTheme.css
+++ b/website/src/css/customTheme.css
@@ -134,6 +134,7 @@ header h2 {
padding-right: 0;
margin-left: 0;
margin-right: 0;
+ margin-bottom: 70px;
}
.showcase .container {
padding-left: 0;
@@ -501,3 +502,40 @@ a:hover {
.help-page .card .buttons {
display: flex;
}
+
+/*newsletter section*/
+
+.center-elem{
+ display: flex;
+ justify-content: center;
+}
+
+.news-logo{
+ margin-bottom: 20px;
+}
+
+.news-button{
+ border: #111827;
+ padding: 5px 30px;
+ border-style: solid;
+ border-radius: 9px;
+ background: #111827;
+ color: white;
+ margin: 4px;
+ text-decoration: none;
+ transition: all 0.3s;
+}
+.news-button:hover{
+ background: black;
+ color: white;
+ text-decoration: none;
+}
+
+.news-logo-svg{
+ height: 42px;
+}
+
+.news-text{
+ color: var(--color-primary);
+ text-align: center;
+}
diff --git a/website/src/pages/index.js b/website/src/pages/index.js
index dc8eee6..497b319 100644
--- a/website/src/pages/index.js
+++ b/website/src/pages/index.js
@@ -205,6 +205,37 @@ const EventsSection = () => {
);
};
+const NewsletterSection = () => {
+
+ return (
+
+
+http://www.w3.org/2000/svg;>
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+Stay up to date about all Apache APISIX™ News
+
+
+Subscribe
+
+
+ );
+};
+
const Index = (props) => {
return (
@@ -212,6 +243,7 @@ const Index = (props) => {
+
);
};
[GitHub] [apisix-website] juzhiyuan closed issue #220: improve Subscribe Mailing-list more clear
juzhiyuan closed issue #220: URL: https://github.com/apache/apisix-website/issues/220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3725: request help: about dubbo proxy
spacewander commented on issue #3725: URL: https://github.com/apache/apisix/issues/3725#issuecomment-792446219 If there is any new update with https://github.com/apache/dubbo-go/issues/993, please discuss in that issue directly. We are working with open source project, not something need to be private. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
spacewander commented on pull request #3758:
URL: https://github.com/apache/apisix/pull/3758#issuecomment-792443816
After apply this change:
```
diff --git apisix/plugins/traffic-split.lua apisix/plugins/traffic-split.lua
index eb7a2028..3d5e7d8f 100644
--- apisix/plugins/traffic-split.lua
+++ apisix/plugins/traffic-split.lua
@@ -315,8 +315,7 @@ function _M.access(conf, ctx)
end
local route_upstream_id = ctx.matched_route.value.upstream_id
-local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj,
weighted_upstreams,
-route_upstream_id)
+local rr_up, err = new_rr_obj(weighted_upstreams, route_upstream_id)
if not rr_up then
core.log.error("lrucache roundrobin failed: ", err)
return 500
```
many test cases are failed. Look like `new_rr_obj` corrupts the route's
configuration. This may happen once the cache is evicted.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu opened a new issue #147: Replace `docker build` command with `make` command in README
Yiyiyimu opened a new issue #147: URL: https://github.com/apache/apisix-docker/issues/147 After we refactor CI (#140) in this repo, we could build docker image more easily with make command. But the commands in README were not updated. Another problem is that there are too many hardcoded `VERSION` in this repo, say we don't need a default one in `alpine/Dockerfile` when we tend to set `VERSION` each time we build image. We could also fix this problem at the same time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] rockXiaofeng removed a comment on issue #3725: request help: about dubbo proxy
rockXiaofeng removed a comment on issue #3725: URL: https://github.com/apache/apisix/issues/3725#issuecomment-792398647 > I submitted a bug report to dubbo-go previously: [apache/dubbo-go#993](https://github.com/apache/dubbo-go/issues/993) okay, got it ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] rockXiaofeng commented on issue #3725: request help: about dubbo proxy
rockXiaofeng commented on issue #3725: URL: https://github.com/apache/apisix/issues/3725#issuecomment-792435805 > I submitted a bug report to dubbo-go previously: [apache/dubbo-go#993](https://github.com/apache/dubbo-go/issues/993) Hi, we found AlexanderStocks of the dubbo-go project, maybe we can work together to solve this problem? (My wechat: xfaitmt) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu opened a new pull request #146: release: 2.4
Yiyiyimu opened a new pull request #146: URL: https://github.com/apache/apisix-docker/pull/146 Signed-off-by: yiyiyimu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3776: docs: split architecture-design
spacewander commented on a change in pull request #3776:
URL: https://github.com/apache/apisix/pull/3776#discussion_r589146219
##
File path: docs/en/latest/config.json
##
@@ -2,8 +2,54 @@
"version": 2.4,
"sidebar": [
{
- "type": "doc",
- "id": "architecture-design"
+ "type": "category",
+ "label": "architecture design",
+ "items": [
+{
+ "type": "doc",
+ "id": "apisix"
Review comment:
Fixed in the new commit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] LiteSun merged pull request #245: fix: fix the version number in mobile size overflow
LiteSun merged pull request #245: URL: https://github.com/apache/apisix-website/pull/245 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] LiteSun closed issue #224: The top `version` is not set for phone layout
LiteSun closed issue #224: URL: https://github.com/apache/apisix-website/issues/224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: fix: fix the version number in mobile size overflow (#245)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 1008d90 fix: fix the version number in mobile size overflow (#245)
1008d90 is described below
commit 1008d90d7f702cd57f5f6fc9f59bd447c4c3f6ff
Author: Cliff Su
AuthorDate: Mon Mar 8 11:14:03 2021 +0800
fix: fix the version number in mobile size overflow (#245)
---
website/src/theme/DocSidebar/styles.module.css | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/website/src/theme/DocSidebar/styles.module.css
b/website/src/theme/DocSidebar/styles.module.css
index e2fbd32..29f1c0e 100644
--- a/website/src/theme/DocSidebar/styles.module.css
+++ b/website/src/theme/DocSidebar/styles.module.css
@@ -21,16 +21,6 @@
transition: opacity 50ms ease;
}
- .sidebarVersionSwitch {
-display: flex;
-align-items: center;
-padding: 4px 1rem;
-margin: 1rem;
-border-radius: 0.5rem;
-border: 1px solid #eee;
-box-shadow: 0 1px 2px 0 rgba(0, 0, 0, 0.03);
- }
-
.sidebarWithHideableNavbar {
padding-top: 0;
}
@@ -120,6 +110,20 @@
width: 24px;
}
+.sidebarVersionSwitch {
+ display: flex;
+ align-items: center;
+ padding: 4px 1rem;
+ margin: 1rem;
+ border-radius: 0.5rem;
+ border: 1px solid #eee;
+ box-shadow: 0 1px 2px 0 rgba(0, 0, 0, 0.03);
+}
+
+.sidebarVersionSwitch a {
+ display: inline-block;
+}
+
:global(.menu__list) :global(.menu__list) {
overflow-y: hidden;
will-change: height;
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3776: docs: split architecture-design
juzhiyuan commented on a change in pull request #3776:
URL: https://github.com/apache/apisix/pull/3776#discussion_r589145485
##
File path: docs/en/latest/config.json
##
@@ -2,8 +2,54 @@
"version": 2.4,
"sidebar": [
{
- "type": "doc",
- "id": "architecture-design"
+ "type": "category",
+ "label": "architecture design",
Review comment:
```suggestion
"label": "Architecture Design",
```
##
File path: docs/en/latest/config.json
##
@@ -2,8 +2,54 @@
"version": 2.4,
"sidebar": [
{
- "type": "doc",
- "id": "architecture-design"
+ "type": "category",
+ "label": "architecture design",
+ "items": [
+{
+ "type": "doc",
+ "id": "apisix"
Review comment:
Hi, because we don't have `id` in markdown's meta fields, so we have to
use the relative path here.
Please refer to
```json
{
"type": "category",
"label": "General",
"items": [
"plugins/batch-requests",
"plugins/serverless",
"plugins/redirect",
"plugins/echo",
"plugins/server-info"
]
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix-website] branch master updated: fix: rectify the index doc page for apisix ingress controller (#249)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 868e05c fix: rectify the index doc page for apisix ingress controller
(#249)
868e05c is described below
commit 868e05c4ecd8b7983f8f9dc222ddf98bcafeff2b
Author: Alex Zhang
AuthorDate: Mon Mar 8 11:10:07 2021 +0800
fix: rectify the index doc page for apisix ingress controller (#249)
---
website/docusaurus.config.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index ab89147..0c44dae 100644
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -193,7 +193,7 @@ module.exports = {
},
{
label: "APISIX™️ Ingress Controller",
- to: "/docs/ingress-controller/design/",
+ to: "/docs/ingress-controller/getting-started/",
},
{
label: "General",
[GitHub] [apisix-website] juzhiyuan merged pull request #249: fix: rectify the index doc page for apisix ingress controller
juzhiyuan merged pull request #249: URL: https://github.com/apache/apisix-website/pull/249 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #3726: [Discuss] standardize release guide & branch/tag relations
juzhiyuan commented on issue #3726: URL: https://github.com/apache/apisix/issues/3726#issuecomment-792422959 any update here? cc @spacewander @imjoey @membphis @liuxiran to check this solution, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3721: chore: update skywalking plugin to v0.4.0
spacewander commented on pull request #3721: URL: https://github.com/apache/apisix/pull/3721#issuecomment-792415644 @stu01509 Try 0.4-1? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3776: docs: split architecture-design
spacewander opened a new pull request #3776: URL: https://github.com/apache/apisix/pull/3776 Fix #3774 TODO: update Chinese version Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (495c791) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/938b2b9f34c5fa5e7ef6fddef29acb29b25c09a1?el=desc) (938b2b9) will **decrease** coverage by `31.12%`. > The diff coverage is `26.31%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1558 +/- ## === - Coverage 70.86% 39.74% -31.13% === Files 135 49 -86 Lines5485 3173 -2312 Branches 5830 -583 === - Hits 3887 1261 -2626 - Misses 1350 1640 +290 - Partials 248 272 +24 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `39.74% <26.31%> (-0.31%)` | :arrow_down: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `34.27% <26.31%> (-43.97%)` | :arrow_down: | | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `30.55% <0.00%> (-41.67%)` | :arrow_down: | | ... and [106 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [938b2b9...495c791](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1559: test: update test
codecov-io edited a comment on pull request #1559: URL: https://github.com/apache/apisix-dashboard/pull/1559#issuecomment-791552197 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1559?src=pr=h1) Report > Merging [#1559](https://codecov.io/gh/apache/apisix-dashboard/pull/1559?src=pr=desc) (9b80eda) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/938b2b9f34c5fa5e7ef6fddef29acb29b25c09a1?el=desc) (938b2b9) will **increase** coverage by `2.46%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1559?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1559 +/- ## == + Coverage 70.86% 73.33% +2.46% == Files 135 86 -49 Lines5485 2321-3164 Branches 583 583 == - Hits 3887 1702-2185 + Misses 1350 619 -731 + Partials 2480 -248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.33% <ø> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1559?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1559/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | | | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1559/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | | | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1559/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | | | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1559/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1559/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | | | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1559/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | | | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1559/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1559/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1559/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | | | [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1559/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | | | | ... and [40 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1559/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1559?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1559?src=pr=footer). Last update [938b2b9...9b80eda](https://codecov.io/gh/apache/apisix-dashboard/pull/1559?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] tokers opened a new pull request #249: fix: rectify the index doc page for apisix ingress controller
tokers opened a new pull request #249: URL: https://github.com/apache/apisix-website/pull/249 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] 01/01: fix: rectify the index doc page for apisix ingress controller
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch fix/doc-index-page-of-ingress-controller
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
commit 33051a8092e28f7c95d2c0c2071e48c0e177bf00
Author: tokers
AuthorDate: Mon Mar 8 09:55:05 2021 +0800
fix: rectify the index doc page for apisix ingress controller
---
website/docusaurus.config.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index ab89147..0c44dae 100644
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -193,7 +193,7 @@ module.exports = {
},
{
label: "APISIX™️ Ingress Controller",
- to: "/docs/ingress-controller/design/",
+ to: "/docs/ingress-controller/getting-started/",
},
{
label: "General",
[apisix-website] branch fix/doc-index-page-of-ingress-controller created (now 33051a8)
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch fix/doc-index-page-of-ingress-controller in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at 33051a8 fix: rectify the index doc page for apisix ingress controller This branch includes the following new commits: new 33051a8 fix: rectify the index doc page for apisix ingress controller The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [apisix] stu01509 commented on pull request #3766: docs: add --server option for the use of luarocks
stu01509 commented on pull request #3766: URL: https://github.com/apache/apisix/pull/3766#issuecomment-792407290 > The original title is confusing, people might be associated with the apisix command line tool, like "./bin/apisix --server", but it's actually an option of luarocks, so I changed it. Ok, Thanks for your help. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: fix: add to the blog markdown files #240 (#247)
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 3e5b29a fix: add to the blog markdown files #240 (#247) 3e5b29a is described below commit 3e5b29a4113273895f64e37e483ad98708a55f94 Author: Kishani Kandasamy <53715187+kishanikandas...@users.noreply.github.com> AuthorDate: Mon Mar 8 07:19:01 2021 +0530 fix: add to the blog markdown files #240 (#247) --- website/blog/2020-12-16-another-way-to-implement-envoy-filter.md| 3 +++ website/blog/2020-12-18-a-first-look-at-kubernetes-service-api.md | 3 +++ website/blog/2021-01-21-run-ingress-apisix-on-amazon-eks.md | 3 +++ website/blog/2021-02-08-stable-product-delivery-with-cypress.md | 3 +++ website/blog/2021-02-26-install-apache-apisix-from-helm-charts.md | 3 +++ website/blog/2021-03-02-get-front-end-test-coverage-with-cypress.md | 3 +++ 6 files changed, 18 insertions(+) diff --git a/website/blog/2020-12-16-another-way-to-implement-envoy-filter.md b/website/blog/2020-12-16-another-way-to-implement-envoy-filter.md index fb7e016..f367ab3 100644 --- a/website/blog/2020-12-16-another-way-to-implement-envoy-filter.md +++ b/website/blog/2020-12-16-another-way-to-implement-envoy-filter.md @@ -7,6 +7,9 @@ authorImageURL: "https://avatars0.githubusercontent.com/u/33000667; > [@nic-chen](https://github.com/nic-chen), Apache APISIX PMC from [Shenzhen > Zhiliu Technology Co.](https://www.apiseven.com/) > + + + > Source: > https://www.apiseven.com/en/blog/another-way-to-implement-envoy-filter ## Ways to implement Envoy filter diff --git a/website/blog/2020-12-18-a-first-look-at-kubernetes-service-api.md b/website/blog/2020-12-18-a-first-look-at-kubernetes-service-api.md index 8daa6f5..374b911 100644 --- a/website/blog/2020-12-18-a-first-look-at-kubernetes-service-api.md +++ b/website/blog/2020-12-18-a-first-look-at-kubernetes-service-api.md @@ -7,6 +7,9 @@ authorImageURL: "https://avatars2.githubusercontent.com/u/4413028?s=400=e140a6 > [@gxthrj](https://github.com/gxthrj), Apache APISIX PMC & Apache > apisix-ingress-controller Founder from [Shenzhen Zhiliu Technology > Co.](https://www.apiseven.com/) > + + + > Source: > > - https://github.com/apache/apisix diff --git a/website/blog/2021-01-21-run-ingress-apisix-on-amazon-eks.md b/website/blog/2021-01-21-run-ingress-apisix-on-amazon-eks.md index 7deded9..a4e9eb2 100644 --- a/website/blog/2021-01-21-run-ingress-apisix-on-amazon-eks.md +++ b/website/blog/2021-01-21-run-ingress-apisix-on-amazon-eks.md @@ -7,6 +7,9 @@ authorImageURL: "https://avatars0.githubusercontent.com/u/10428333?s=60=4; > [@Chao Zhang](https://github.com/tokers), Apache APISIX Committer from > [Shenzhen Zhiliu Technology Co.](https://www.apiseven.com/) > + + + > Source: > > - https://github.com/apache/apisix diff --git a/website/blog/2021-02-08-stable-product-delivery-with-cypress.md b/website/blog/2021-02-08-stable-product-delivery-with-cypress.md index 2ce32e3..26ba5f2 100644 --- a/website/blog/2021-02-08-stable-product-delivery-with-cypress.md +++ b/website/blog/2021-02-08-stable-product-delivery-with-cypress.md @@ -7,6 +7,9 @@ authorImageURL: "https://avatars.githubusercontent.com/u/31329157?s=400=e81b4b > [@LiteSun](https://github.com/LiteSun), Apache APISIX Committer from > [Shenzhen Zhiliu Technology Co.](https://www.apiseven.com/) > + + + > Source: > > - https://github.com/apache/apisix diff --git a/website/blog/2021-02-26-install-apache-apisix-from-helm-charts.md b/website/blog/2021-02-26-install-apache-apisix-from-helm-charts.md index 6f14fe1..205de6f 100644 --- a/website/blog/2021-02-26-install-apache-apisix-from-helm-charts.md +++ b/website/blog/2021-02-26-install-apache-apisix-from-helm-charts.md @@ -7,6 +7,9 @@ authorImageURL: "https://avatars.githubusercontent.com/u/10428333?s=400=f48ef5 > [@tokers](https://github.com/tokers), Apache APISIX Committer from [Shenzhen > Zhiliu Technology Co.](https://www.apiseven.com/) > + + + > Source: > > - https://github.com/apache/apisix diff --git a/website/blog/2021-03-02-get-front-end-test-coverage-with-cypress.md b/website/blog/2021-03-02-get-front-end-test-coverage-with-cypress.md index 826b7e4..6e4ef5b 100644 --- a/website/blog/2021-03-02-get-front-end-test-coverage-with-cypress.md +++ b/website/blog/2021-03-02-get-front-end-test-coverage-with-cypress.md @@ -7,6 +7,9 @@ authorImageURL: "https://avatars.githubusercontent.com/u/31329157?s=400=e81b4b > [@LiteSun](https://github.com/LiteSun), Apache APISIX Committer from > [Shenzhen Zhiliu Technology Co.](https://www.apiseven.com/) > + + + > Source: > > - https://github.com/apache/apisix
[GitHub] [apisix-website] LiteSun merged pull request #247: fix: add to the blog markdown files #240
LiteSun merged pull request #247: URL: https://github.com/apache/apisix-website/pull/247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] LiteSun closed issue #240: Add `` to the blog markdown files
LiteSun closed issue #240: URL: https://github.com/apache/apisix-website/issues/240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1557: feat: sync fields of `upstream` from APISIX
LiteSun commented on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-792406012 >  > > BTW, @LiteSun Please create an issue about why CodeCov misses some data occasionally. Issue created.https://github.com/apache/apisix-dashboard/issues/1562 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun opened a new issue #1562: Codecov unstable
LiteSun opened a new issue #1562: URL: https://github.com/apache/apisix-dashboard/issues/1562 # Bug report ## Describe the bug We use codecov to display the test reports in pr comments, but sometimes codecov randomly loses some data and needs to be investigated ## Expected behavior Codecov reports full data ## Screenshots  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #239: feat: fixes #220
juzhiyuan commented on a change in pull request #239:
URL: https://github.com/apache/apisix-website/pull/239#discussion_r589125799
##
File path: website/src/pages/index.js
##
@@ -134,7 +134,7 @@ const Showcase = () => {
This project is used by all these folks
- Are you using this project?
+ Are you using this project?
https://github.com/apache/apisix/blob/master/docs/en/latest/powered-by.md;
Review comment:
Hi, would you mind fixing this link in this PR?
The correct one is
`https://github.com/apache/apisix/blob/master/powered-by.md`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1558: feat:Support duplicate one existing Route
nic-chen commented on pull request #1558:
URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-792404725
> > need some test cases for duplicate check, thanks. @batman-ezio
>
> @nic-chen after I check duplicate name in create/update route api. some
test cases failed. I think they are use the same route name to test before.
some errors throw from the route test are very strange , like this
>
> ```
> === RUN TestRoute_Create/create_route_success
> panic:
> assert: mock: I don't know what to return because the method call was
unexpected.
>Either do Mock.On("List").Return(...) first, or remove the List() call.
>This method was unexpected:
>List(store.ListInput)
>0: store.ListInput{Predicate:(func(interface {})
bool)(0x11bf5a0), Format:(func(interface {}) interface {})(nil), PageSize:0,
PageNumber:0, Less:(func(interface {}, interface {}) bool)(nil)}
>at: [store_mock.go:35 route.go:537 route.go:311 route_test.go:1005]
[recovered]
>panic:
> assert: mock: I don't know what to return because the method call was
unexpected.
>Either do Mock.On("List").Return(...) first, or remove the List() call.
>This method was unexpected:
>List(store.ListInput)
>0: store.ListInput{Predicate:(func(interface {})
bool)(0x11bf5a0), Format:(func(interface {}) interface {})(nil), PageSize:0,
PageNumber:0, Less:(func(interface {}, interface {}) bool)(nil)}
>at: [store_mock.go:35 route.go:537 route.go:311 route_test.go:1005]
> ```
>
> I have change the route name but still got this. can you help?
hi @batman-ezio , you need to mock `routeStore.List` for
`checkDuplicateName`
you could refer to:
https://github.com/apache/apisix-dashboard/blob/2de2c72cfa8899e98045c3059d281b90cf544404/api/internal/handler/plugin_config/plugin_config_test.go#L694-L709
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #247: fix: add to the blog markdown files #240
juzhiyuan commented on pull request #247: URL: https://github.com/apache/apisix-website/pull/247#issuecomment-792404712 ping @LiteSun This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #284: feat: support secret controller
gxthrj commented on a change in pull request #284:
URL:
https://github.com/apache/apisix-ingress-controller/pull/284#discussion_r589124526
##
File path: pkg/ingress/controller/secret.go
##
@@ -0,0 +1,203 @@
+package controller
+
+import (
+ "context"
+ "fmt"
+ "sync"
+ "time"
+
+ "go.uber.org/zap"
+ corev1 "k8s.io/api/core/v1"
+ k8serrors "k8s.io/apimachinery/pkg/api/errors"
+ "k8s.io/apimachinery/pkg/util/runtime"
+ "k8s.io/client-go/tools/cache"
+ "k8s.io/client-go/util/workqueue"
+
+ "github.com/apache/apisix-ingress-controller/pkg/log"
+ "github.com/apache/apisix-ingress-controller/pkg/seven/state"
+ "github.com/apache/apisix-ingress-controller/pkg/types"
+ apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+type secretController struct {
+ controller *Controller
+ workqueue workqueue.RateLimitingInterface
+ workersint
+}
+
+func (c *Controller) newSecretController() *secretController {
+ ctl := {
+ controller: c,
+ workqueue:
workqueue.NewNamedRateLimitingQueue(workqueue.NewItemFastSlowRateLimiter(1*time.Second,
60*time.Second, 5), "Secrets"),
+ workers:1,
+ }
+
+ ctl.controller.secretInformer.AddEventHandler(
+ cache.ResourceEventHandlerFuncs{
+ AddFunc:ctl.onAdd,
+ UpdateFunc: ctl.onUpdate,
+ DeleteFunc: ctl.onDelete,
+ },
+ )
+
+ return ctl
+}
+
+func (c *secretController) run(ctx context.Context) {
+ log.Info("secret controller started")
+ defer log.Info("secret controller exited")
+
+ if ok := cache.WaitForCacheSync(ctx.Done(),
c.controller.secretInformer.HasSynced); !ok {
+ log.Error("informers sync failed")
+ return
+ }
+
+ handler := func() {
+ for {
+ obj, shutdown := c.workqueue.Get()
+ if shutdown {
+ return
+ }
+ err := func(obj interface{}) error {
+ defer c.workqueue.Done(obj)
+ var key string
+ event := obj.(*types.Event)
+ if secret, ok := event.Object.(*corev1.Secret);
!ok {
+ c.workqueue.Forget(obj)
+ return fmt.Errorf("expected Secret in
workqueue but got %#v", obj)
+ } else {
+ if err := c.sync(ctx,
obj.(*types.Event)); err != nil {
+ c.workqueue.AddRateLimited(obj)
+ log.Errorf("sync secret with
ssl %s failed", secret.Namespace+"_"+secret.Name)
+ return fmt.Errorf("error
syncing '%s': %s", key, err.Error())
+ }
+ c.workqueue.Forget(obj)
+ return nil
+ }
+ }(obj)
+ if err != nil {
+ runtime.HandleError(err)
+ }
+ }
+ }
+
+ for i := 0; i < c.workers; i++ {
+ go handler()
+ }
+
+ <-ctx.Done()
+ c.workqueue.ShutDown()
+}
+
+func (c *secretController) sync(ctx context.Context, ev *types.Event) error {
+ obj := ev.Object.(*corev1.Secret)
+ sec, err :=
c.controller.secretLister.Secrets(obj.Namespace).Get(obj.Name)
+
+ key := obj.Namespace + "_" + obj.Name
+ if err != nil {
+ if !k8serrors.IsNotFound(err) {
+ log.Errorw("failed to get Secret",
+ zap.String("version", obj.ResourceVersion),
+ zap.String("key", key),
+ zap.Error(err),
+ )
+ return err
+ }
+
+ if ev.Type != types.EventDelete {
+ log.Warnw("Secret was deleted before it can be
delivered",
+ zap.String("key", key),
+ zap.String("version", obj.ResourceVersion),
+ )
+ return nil
+ }
+ }
+ if ev.Type == types.EventDelete {
+ if sec != nil {
+ // We still find the resource while we are processing
the DELETE event,
+ // that means object with same namespace and name was
created, discarding
+ // this stale DELETE event.
+ log.Warnw("discard the stale
[GitHub] [apisix] membphis commented on issue #3775: plugin server-info will write data to etcd
membphis commented on issue #3775: URL: https://github.com/apache/apisix/issues/3775#issuecomment-792401611 DP is read-only to etcd data, making it easier to control security. I suggest keeping it read-only for DP. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] rockXiaofeng commented on issue #3725: request help: about dubbo proxy
rockXiaofeng commented on issue #3725: URL: https://github.com/apache/apisix/issues/3725#issuecomment-792398647 > I submitted a bug report to dubbo-go previously: [apache/dubbo-go#993](https://github.com/apache/dubbo-go/issues/993) okay, got it ... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio commented on pull request #1558: feat:Support duplicate one existing Route
batman-ezio commented on pull request #1558:
URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-792398132
> need some test cases for duplicate check, thanks. @batman-ezio
@nic-chen after I check duplicate name in create/update route api. some test
cases failed. I think they are use the same route name to test before. some
errors throw from the route test are very strange , like this
```
=== RUN TestRoute_Create/create_route_success
panic:
assert: mock: I don't know what to return because the method call was
unexpected.
Either do Mock.On("List").Return(...) first, or remove the List() call.
This method was unexpected:
List(store.ListInput)
0: store.ListInput{Predicate:(func(interface {})
bool)(0x11bf5a0), Format:(func(interface {}) interface {})(nil), PageSize:0,
PageNumber:0, Less:(func(interface {}, interface {}) bool)(nil)}
at: [store_mock.go:35 route.go:537 route.go:311 route_test.go:1005]
[recovered]
panic:
assert: mock: I don't know what to return because the method call was
unexpected.
Either do Mock.On("List").Return(...) first, or remove the List() call.
This method was unexpected:
List(store.ListInput)
0: store.ListInput{Predicate:(func(interface {})
bool)(0x11bf5a0), Format:(func(interface {}) interface {})(nil), PageSize:0,
PageNumber:0, Less:(func(interface {}, interface {}) bool)(nil)}
at: [store_mock.go:35 route.go:537 route.go:311 route_test.go:1005]
```
I have change the route name but still got this. can you help?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3772: request help: how to config "location /m { alias /mnt/www/saas-h5/; index index.html; }"
spacewander commented on issue #3772: URL: https://github.com/apache/apisix/issues/3772#issuecomment-792397141 See https://github.com/apache/apisix/blob/master/docs/en/latest/customize-nginx-configuration.md You can add it into ``` # put this in config.yaml: nginx_config: http_server_configuration_snippet： ... ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #3766: docs: add --server option for the use of luarocks
tokers commented on pull request #3766: URL: https://github.com/apache/apisix/pull/3766#issuecomment-792395886 The original title is confusing, people might be associated with the apisix command line tool, like "./bin/apisix --server", but it's actually an option of luarocks, so I changed it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #284: feat: support secret controller
tokers commented on a change in pull request #284:
URL:
https://github.com/apache/apisix-ingress-controller/pull/284#discussion_r589118124
##
File path: pkg/ingress/controller/secret.go
##
@@ -0,0 +1,203 @@
+package controller
+
+import (
+ "context"
+ "fmt"
+ "sync"
+ "time"
+
+ "go.uber.org/zap"
+ corev1 "k8s.io/api/core/v1"
+ k8serrors "k8s.io/apimachinery/pkg/api/errors"
+ "k8s.io/apimachinery/pkg/util/runtime"
+ "k8s.io/client-go/tools/cache"
+ "k8s.io/client-go/util/workqueue"
+
+ "github.com/apache/apisix-ingress-controller/pkg/log"
+ "github.com/apache/apisix-ingress-controller/pkg/seven/state"
+ "github.com/apache/apisix-ingress-controller/pkg/types"
+ apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+type secretController struct {
+ controller *Controller
+ workqueue workqueue.RateLimitingInterface
+ workersint
+}
+
+func (c *Controller) newSecretController() *secretController {
+ ctl := {
+ controller: c,
+ workqueue:
workqueue.NewNamedRateLimitingQueue(workqueue.NewItemFastSlowRateLimiter(1*time.Second,
60*time.Second, 5), "Secrets"),
+ workers:1,
+ }
+
+ ctl.controller.secretInformer.AddEventHandler(
+ cache.ResourceEventHandlerFuncs{
+ AddFunc:ctl.onAdd,
+ UpdateFunc: ctl.onUpdate,
+ DeleteFunc: ctl.onDelete,
+ },
+ )
+
+ return ctl
+}
+
+func (c *secretController) run(ctx context.Context) {
+ log.Info("secret controller started")
+ defer log.Info("secret controller exited")
+
+ if ok := cache.WaitForCacheSync(ctx.Done(),
c.controller.secretInformer.HasSynced); !ok {
+ log.Error("informers sync failed")
+ return
+ }
+
+ handler := func() {
+ for {
+ obj, shutdown := c.workqueue.Get()
+ if shutdown {
+ return
+ }
+ err := func(obj interface{}) error {
+ defer c.workqueue.Done(obj)
+ var key string
+ event := obj.(*types.Event)
+ if secret, ok := event.Object.(*corev1.Secret);
!ok {
+ c.workqueue.Forget(obj)
+ return fmt.Errorf("expected Secret in
workqueue but got %#v", obj)
+ } else {
+ if err := c.sync(ctx,
obj.(*types.Event)); err != nil {
+ c.workqueue.AddRateLimited(obj)
+ log.Errorf("sync secret with
ssl %s failed", secret.Namespace+"_"+secret.Name)
+ return fmt.Errorf("error
syncing '%s': %s", key, err.Error())
+ }
+ c.workqueue.Forget(obj)
+ return nil
+ }
+ }(obj)
+ if err != nil {
+ runtime.HandleError(err)
+ }
+ }
+ }
+
+ for i := 0; i < c.workers; i++ {
+ go handler()
+ }
+
+ <-ctx.Done()
+ c.workqueue.ShutDown()
+}
+
+func (c *secretController) sync(ctx context.Context, ev *types.Event) error {
+ obj := ev.Object.(*corev1.Secret)
+ sec, err :=
c.controller.secretLister.Secrets(obj.Namespace).Get(obj.Name)
+
+ key := obj.Namespace + "_" + obj.Name
+ if err != nil {
+ if !k8serrors.IsNotFound(err) {
+ log.Errorw("failed to get Secret",
+ zap.String("version", obj.ResourceVersion),
+ zap.String("key", key),
+ zap.Error(err),
+ )
+ return err
+ }
+
+ if ev.Type != types.EventDelete {
+ log.Warnw("Secret was deleted before it can be
delivered",
+ zap.String("key", key),
+ zap.String("version", obj.ResourceVersion),
+ )
+ return nil
+ }
+ }
+ if ev.Type == types.EventDelete {
+ if sec != nil {
+ // We still find the resource while we are processing
the DELETE event,
+ // that means object with same namespace and name was
created, discarding
+ // this stale DELETE event.
+ log.Warnw("discard the stale
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #284: feat: support secret controller
tokers commented on a change in pull request #284:
URL:
https://github.com/apache/apisix-ingress-controller/pull/284#discussion_r589118124
##
File path: pkg/ingress/controller/secret.go
##
@@ -0,0 +1,203 @@
+package controller
+
+import (
+ "context"
+ "fmt"
+ "sync"
+ "time"
+
+ "go.uber.org/zap"
+ corev1 "k8s.io/api/core/v1"
+ k8serrors "k8s.io/apimachinery/pkg/api/errors"
+ "k8s.io/apimachinery/pkg/util/runtime"
+ "k8s.io/client-go/tools/cache"
+ "k8s.io/client-go/util/workqueue"
+
+ "github.com/apache/apisix-ingress-controller/pkg/log"
+ "github.com/apache/apisix-ingress-controller/pkg/seven/state"
+ "github.com/apache/apisix-ingress-controller/pkg/types"
+ apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+type secretController struct {
+ controller *Controller
+ workqueue workqueue.RateLimitingInterface
+ workersint
+}
+
+func (c *Controller) newSecretController() *secretController {
+ ctl := {
+ controller: c,
+ workqueue:
workqueue.NewNamedRateLimitingQueue(workqueue.NewItemFastSlowRateLimiter(1*time.Second,
60*time.Second, 5), "Secrets"),
+ workers:1,
+ }
+
+ ctl.controller.secretInformer.AddEventHandler(
+ cache.ResourceEventHandlerFuncs{
+ AddFunc:ctl.onAdd,
+ UpdateFunc: ctl.onUpdate,
+ DeleteFunc: ctl.onDelete,
+ },
+ )
+
+ return ctl
+}
+
+func (c *secretController) run(ctx context.Context) {
+ log.Info("secret controller started")
+ defer log.Info("secret controller exited")
+
+ if ok := cache.WaitForCacheSync(ctx.Done(),
c.controller.secretInformer.HasSynced); !ok {
+ log.Error("informers sync failed")
+ return
+ }
+
+ handler := func() {
+ for {
+ obj, shutdown := c.workqueue.Get()
+ if shutdown {
+ return
+ }
+ err := func(obj interface{}) error {
+ defer c.workqueue.Done(obj)
+ var key string
+ event := obj.(*types.Event)
+ if secret, ok := event.Object.(*corev1.Secret);
!ok {
+ c.workqueue.Forget(obj)
+ return fmt.Errorf("expected Secret in
workqueue but got %#v", obj)
+ } else {
+ if err := c.sync(ctx,
obj.(*types.Event)); err != nil {
+ c.workqueue.AddRateLimited(obj)
+ log.Errorf("sync secret with
ssl %s failed", secret.Namespace+"_"+secret.Name)
+ return fmt.Errorf("error
syncing '%s': %s", key, err.Error())
+ }
+ c.workqueue.Forget(obj)
+ return nil
+ }
+ }(obj)
+ if err != nil {
+ runtime.HandleError(err)
+ }
+ }
+ }
+
+ for i := 0; i < c.workers; i++ {
+ go handler()
+ }
+
+ <-ctx.Done()
+ c.workqueue.ShutDown()
+}
+
+func (c *secretController) sync(ctx context.Context, ev *types.Event) error {
+ obj := ev.Object.(*corev1.Secret)
+ sec, err :=
c.controller.secretLister.Secrets(obj.Namespace).Get(obj.Name)
+
+ key := obj.Namespace + "_" + obj.Name
+ if err != nil {
+ if !k8serrors.IsNotFound(err) {
+ log.Errorw("failed to get Secret",
+ zap.String("version", obj.ResourceVersion),
+ zap.String("key", key),
+ zap.Error(err),
+ )
+ return err
+ }
+
+ if ev.Type != types.EventDelete {
+ log.Warnw("Secret was deleted before it can be
delivered",
+ zap.String("key", key),
+ zap.String("version", obj.ResourceVersion),
+ )
+ return nil
+ }
+ }
+ if ev.Type == types.EventDelete {
+ if sec != nil {
+ // We still find the resource while we are processing
the DELETE event,
+ // that means object with same namespace and name was
created, discarding
+ // this stale DELETE event.
+ log.Warnw("discard the stale
[GitHub] [apisix] spacewander commented on a change in pull request #3766: docs: add --server command
spacewander commented on a change in pull request #3766: URL: https://github.com/apache/apisix/pull/3766#discussion_r589118059 ## File path: docs/en/latest/FAQ.md ## @@ -71,6 +71,10 @@ There are two possibilities when encountering slow luarocks: For the first problem, you can use https_proxy or use the `--server` option to specify a luarocks server that you can access or access faster. Run the `luarocks config rocks_servers` command(this command is supported after luarocks 3.0) to see which server are available. +```shell +luarocks install apisix --server https://luarocks.cn Review comment: @stu01509 See my first comment. "We should wrap the server option in `make deps` ...". We need to introduce something like `LUAROCKS_SERVER=https://luarocks.cn make deps`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3742: feat: add control api for discovery module
spacewander merged pull request #3742: URL: https://github.com/apache/apisix/pull/3742 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #283: docs: update deployments repository url
tokers commented on a change in pull request #283:
URL:
https://github.com/apache/apisix-ingress-controller/pull/283#discussion_r589117700
##
File path: docs/en/latest/deployments/ack.md
##
@@ -38,6 +38,8 @@ This document explains how to install Ingress APISIX on
[ali-cloud ACK](https://
```shell
cd /path/to/apisix-helm-chart
helm repo add bitnami https://charts.bitnami.com/bitnami
+helm repo add apisix https://charts.apiseven.com
+# Use `hem search repo apisix` to search charts about apisix
helm dependency update ./charts/apisix
helm install apisix ./charts/apisix \
Review comment:
Try this :), and we suggest you to run it locally
```suggestion
cd /path/to/apisix-helm-chart
helm repo add bitnami https://charts.bitnami.com/bitnami
helm repo add apisix https://charts.apiseven.com
# Use `hem search repo apisix` to search charts about apisix
helm repo update
helm install apisix apisix/apisix \
--set gateway.type=LoadBalancer \
--set allow.ipList="{0.0.0.0/0}" \
--namespace ingress-apisix \
kubectl get service --namespace ingress-apisix
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix] branch master updated: feat: add control api for discovery module (#3742)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 34f60ee feat: add control api for discovery module (#3742)
34f60ee is described below
commit 34f60ee2ccee9b2f4b0bda96b864cc011023508b
Author: yongboy
AuthorDate: Mon Mar 8 08:58:46 2021 +0800
feat: add control api for discovery module (#3742)
Co-authored-by: nieyong
---
apisix/control/router.lua | 34 ++
apisix/discovery/consul_kv.lua| 1 +
apisix/discovery/eureka.lua | 5 +
docs/en/latest/discovery.md | 39 ++-
docs/en/latest/discovery/consul_kv.md | 75 -
t/control/discovery.t | 196 ++
t/discovery/consul_kv.t | 4 +-
7 files changed, 349 insertions(+), 5 deletions(-)
diff --git a/apisix/control/router.lua b/apisix/control/router.lua
index 821cee8..49fdc23 100644
--- a/apisix/control/router.lua
+++ b/apisix/control/router.lua
@@ -19,8 +19,10 @@ local router = require("apisix.utils.router")
local builtin_v1_routes = require("apisix.control.v1")
local plugin_mod = require("apisix.plugin")
local core = require("apisix.core")
+
local str_sub = string.sub
local ipairs = ipairs
+local pairs = pairs
local type = type
local ngx = ngx
local get_method = ngx.req.get_method
@@ -66,6 +68,38 @@ function fetch_control_api_router()
end
end
+local discovery_type =
require("apisix.core.config_local").local_conf().discovery
+if discovery_type then
+local discovery = require("apisix.discovery.init").discovery
+local dump_apis = {}
+for key, _ in pairs(discovery_type) do
+local dis_mod = discovery[key]
+-- if discovery module has control_api method, support it
+local api_fun = dis_mod.control_api
+if api_fun then
+local api_route = api_fun()
+register_api_routes(routes, api_route)
+end
+
+local dump_data = dis_mod.dump_data
+if dump_data then
+local item = {
+methods = {"GET"},
+uris = {"/v1/discovery/" .. key .. "/dump"},
+handler = function()
+return 200, dump_data()
+end
+}
+core.table.insert(dump_apis, item)
+end
+end
+
+if #dump_apis > 0 then
+core.log.notice("dump_apis: ", core.json.encode(dump_apis, true))
+register_api_routes(routes, dump_apis)
+end
+end
+
core.table.clear(v1_routes)
register_api_routes(v1_routes, builtin_v1_routes)
diff --git a/apisix/discovery/consul_kv.lua b/apisix/discovery/consul_kv.lua
index dac442e..5f53231 100644
--- a/apisix/discovery/consul_kv.lua
+++ b/apisix/discovery/consul_kv.lua
@@ -410,4 +410,5 @@ function _M.dump_data()
return {config = local_conf.discovery.consul_kv, services = applications}
end
+
return _M
diff --git a/apisix/discovery/eureka.lua b/apisix/discovery/eureka.lua
index 82ee89a..1dd3563 100644
--- a/apisix/discovery/eureka.lua
+++ b/apisix/discovery/eureka.lua
@@ -252,4 +252,9 @@ function _M.init_worker()
end
+function _M.dump_data()
+return {config = local_conf.discovery.eureka, services = applications or
{}}
+end
+
+
return _M
diff --git a/docs/en/latest/discovery.md b/docs/en/latest/discovery.md
index d3ef9b2..75d4525 100644
--- a/docs/en/latest/discovery.md
+++ b/docs/en/latest/discovery.md
@@ -32,6 +32,7 @@ title: Integration service discovery registry
* [**Initial service discovery**](#initial-service-discovery)
* [**Configuration for Eureka**](#configuration-for-eureka)
* [**Upstream setting**](#upstream-setting)
+* [**Embedded control api for debugging**](#embedded-control-api-for-debugging)
* [**Discovery modules**](#discovery-modules)
## Summary
@@ -64,9 +65,11 @@ It is very easy for APISIX to extend the discovery client,
the basic steps are a
1. Add the implementation of registry client in the 'apisix/discovery/'
directory;
-2. Implement the `_M. init_worker()` function for initialization and the `_M.
nodes(service_name)` function for obtaining the list of service instance nodes;
+2. Implement the `_M.init_worker()` function for initialization and the
`_M.nodes(service_name)` function for obtaining the list of service instance
nodes;
-3. Convert the registry data into data in APISIX;
+3. If you need the discovery module to export the debugging information
online, implement the `_M.dump_data()` function;
+
+4. Convert the registry data into data in APISIX;
### the example of Eureka
@@ -92,6 +95,11 @@ Then implement the `_M.init_worker()` function for
initialization and the `_M.no
end
+ function
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=desc) (520f999) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/938b2b9f34c5fa5e7ef6fddef29acb29b25c09a1?el=desc) (938b2b9) will **increase** coverage by `2.40%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1558 +/- ## == + Coverage 70.86% 73.27% +2.40% == Files 135 86 -49 Lines5485 2320-3165 Branches 583 581 -2 == - Hits 3887 1700-2187 + Misses 1350 620 -730 + Partials 2480 -248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.27% <66.66%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==) | `83.08% <0.00%> (-0.62%)` | :arrow_down: | | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | `90.65% <100.00%> (-0.18%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | | | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | | | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | | | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | | | ... and [41 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=footer). Last update [938b2b9...24d612f](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh opened a new pull request #248: docs: added event about releasing APISIX 2.4
1502shivam-singh opened a new pull request #248: URL: https://github.com/apache/apisix-website/pull/248 Fixes: #246 Changes: added event about releasing APISIX 2.4 Screenshots of the change: check #246 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #246: docs: added event about releasing APISIX 2.4
juzhiyuan commented on issue #246: URL: https://github.com/apache/apisix-website/issues/246#issuecomment-792302945 Hi @1502shivam-singh, the release date is `2021-03-05` :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan opened a new issue #3775: plugin server-info will write data to etcd
juzhiyuan opened a new issue #3775: URL: https://github.com/apache/apisix/issues/3775 # Question ## Please describe which part of docs should be improved or typo fixed Hi, the Apache APISIX implements the `server-info` plugin in #2926 #2821, and this plugin will set data to `etcd` here[1] 樂 this will lead to conflicts with the original design: **DP will only READ data from etcd.**  I'm not sure if we need to have some changes to this plugin 樂 [1] https://github.com/apache/apisix/pull/2926/files#diff-874bdf83da087cde5a431f91ce48ffc6bc042c5b3a64c6e21b1ca799b9261f66R137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1556: feat: rewrite e2e test(route_with_vars_test) with ginkgo
codecov-io edited a comment on pull request #1556: URL: https://github.com/apache/apisix-dashboard/pull/1556#issuecomment-792269521 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=h1) Report > Merging [#1556](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=desc) (02f9b85) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9130e09837f7e6283ba4645fab5c482b18a61949?el=desc) (9130e09) will **decrease** coverage by `18.50%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1556 +/- ## === - Coverage 70.18% 51.68% -18.51% === Files 130 40 -90 Lines5340 2707 -2633 Branches 5490 -549 === - Hits 3748 1399 -2349 + Misses 1344 1127 -217 + Partials 248 181 -67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.68% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [111 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=footer). Last update [9130e09...02f9b85](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1556: feat: rewrite e2e test(route_with_vars_test) with ginkgo
codecov-io edited a comment on pull request #1556: URL: https://github.com/apache/apisix-dashboard/pull/1556#issuecomment-792269521 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=h1) Report > Merging [#1556](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=desc) (8d7e581) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9130e09837f7e6283ba4645fab5c482b18a61949?el=desc) (9130e09) will **decrease** coverage by `1.25%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1556 +/- ## == - Coverage 70.18% 68.93% -1.26% == Files 130 49 -81 Lines5340 3164-2176 Branches 5490 -549 == - Hits 3748 2181-1567 + Misses 1344 735 -609 Partials 248 248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `55.49% <ø> (-0.19%)` | :arrow_down: | | backend-e2e-test-ginkgo | `39.79% <ø> (+0.18%)` | :arrow_up: | | backend-unit-test | `51.68% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `43.63% <0.00%> (-3.64%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `86.74% <0.00%> (-1.21%)` | :arrow_down: | | [web/src/pages/Plugin/PluginMarket.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW4vUGx1Z2luTWFya2V0LnRzeA==) | | | | [web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=) | | | | [web/src/pages/Setting/Setting.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL1NldHRpbmcudHN4) | | | | [web/src/pages/Setting/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL3NlcnZpY2UudHM=) | | | | [web/src/pages/Service/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0xpc3QudHN4) | | | | [web/src/pages/User/Login.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ2luLnRzeA==) | | | | [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | | | | [web/src/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-d2ViL3NyYy9jb25zdGFudHMudHM=) | | | | ... and [73 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=footer). Last update [9130e09...8d7e581](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1556: feat: rewrite e2e test(route_with_vars_test) with ginkgo
codecov-io edited a comment on pull request #1556: URL: https://github.com/apache/apisix-dashboard/pull/1556#issuecomment-792269521 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=h1) Report > Merging [#1556](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=desc) (8d7e581) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9130e09837f7e6283ba4645fab5c482b18a61949?el=desc) (9130e09) will **decrease** coverage by `5.68%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1556 +/- ## == - Coverage 70.18% 64.50% -5.69% == Files 130 49 -81 Lines5340 3164-2176 Branches 5490 -549 == - Hits 3748 2041-1707 + Misses 1344 869 -475 - Partials 248 254 +6 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `39.79% <ø> (+0.18%)` | :arrow_up: | | backend-unit-test | `51.68% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `77.14% <0.00%> (-8.58%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `63.55% <0.00%> (-7.48%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `71.96% <0.00%> (-6.28%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `49.57% <0.00%> (-5.89%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `41.81% <0.00%> (-5.46%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | ... and [84 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=footer). Last update [9130e09...8d7e581](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1556: feat: rewrite e2e test(route_with_vars_test) with ginkgo
codecov-io edited a comment on pull request #1556: URL: https://github.com/apache/apisix-dashboard/pull/1556#issuecomment-792269521 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=h1) Report > Merging [#1556](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=desc) (8d7e581) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9130e09837f7e6283ba4645fab5c482b18a61949?el=desc) (9130e09) will **decrease** coverage by `18.50%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1556 +/- ## === - Coverage 70.18% 51.68% -18.51% === Files 130 40 -90 Lines5340 2707 -2633 Branches 5490 -549 === - Hits 3748 1399 -2349 + Misses 1344 1127 -217 + Partials 248 181 -67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.68% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [111 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1556/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=footer). Last update [9130e09...8d7e581](https://codecov.io/gh/apache/apisix-dashboard/pull/1556?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #284: feat: support secret controller
gxthrj commented on a change in pull request #284:
URL:
https://github.com/apache/apisix-ingress-controller/pull/284#discussion_r589043713
##
File path: pkg/ingress/controller/secret.go
##
@@ -0,0 +1,203 @@
+package controller
+
+import (
+ "context"
+ "fmt"
+ "sync"
+ "time"
+
+ "go.uber.org/zap"
+ corev1 "k8s.io/api/core/v1"
+ k8serrors "k8s.io/apimachinery/pkg/api/errors"
+ "k8s.io/apimachinery/pkg/util/runtime"
+ "k8s.io/client-go/tools/cache"
+ "k8s.io/client-go/util/workqueue"
+
+ "github.com/apache/apisix-ingress-controller/pkg/log"
+ "github.com/apache/apisix-ingress-controller/pkg/seven/state"
+ "github.com/apache/apisix-ingress-controller/pkg/types"
+ apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+type secretController struct {
+ controller *Controller
+ workqueue workqueue.RateLimitingInterface
+ workersint
+}
+
+func (c *Controller) newSecretController() *secretController {
+ ctl := {
+ controller: c,
+ workqueue:
workqueue.NewNamedRateLimitingQueue(workqueue.NewItemFastSlowRateLimiter(1*time.Second,
60*time.Second, 5), "Secrets"),
+ workers:1,
+ }
+
+ ctl.controller.secretInformer.AddEventHandler(
+ cache.ResourceEventHandlerFuncs{
+ AddFunc:ctl.onAdd,
+ UpdateFunc: ctl.onUpdate,
+ DeleteFunc: ctl.onDelete,
+ },
+ )
+
+ return ctl
+}
+
+func (c *secretController) run(ctx context.Context) {
+ log.Info("secret controller started")
+ defer log.Info("secret controller exited")
+
+ if ok := cache.WaitForCacheSync(ctx.Done(),
c.controller.secretInformer.HasSynced); !ok {
+ log.Error("informers sync failed")
+ return
+ }
+
+ handler := func() {
+ for {
+ obj, shutdown := c.workqueue.Get()
+ if shutdown {
+ return
+ }
+ err := func(obj interface{}) error {
+ defer c.workqueue.Done(obj)
+ var key string
+ event := obj.(*types.Event)
+ if secret, ok := event.Object.(*corev1.Secret);
!ok {
+ c.workqueue.Forget(obj)
+ return fmt.Errorf("expected Secret in
workqueue but got %#v", obj)
+ } else {
+ if err := c.sync(ctx,
obj.(*types.Event)); err != nil {
+ c.workqueue.AddRateLimited(obj)
+ log.Errorf("sync secret with
ssl %s failed", secret.Namespace+"_"+secret.Name)
+ return fmt.Errorf("error
syncing '%s': %s", key, err.Error())
+ }
+ c.workqueue.Forget(obj)
+ return nil
+ }
+ }(obj)
+ if err != nil {
+ runtime.HandleError(err)
+ }
+ }
+ }
+
+ for i := 0; i < c.workers; i++ {
+ go handler()
+ }
+
+ <-ctx.Done()
+ c.workqueue.ShutDown()
+}
+
+func (c *secretController) sync(ctx context.Context, ev *types.Event) error {
+ obj := ev.Object.(*corev1.Secret)
+ sec, err :=
c.controller.secretLister.Secrets(obj.Namespace).Get(obj.Name)
+
+ key := obj.Namespace + "_" + obj.Name
+ if err != nil {
+ if !k8serrors.IsNotFound(err) {
+ log.Errorw("failed to get Secret",
+ zap.String("version", obj.ResourceVersion),
+ zap.String("key", key),
+ zap.Error(err),
+ )
+ return err
+ }
+
+ if ev.Type != types.EventDelete {
+ log.Warnw("Secret was deleted before it can be
delivered",
+ zap.String("key", key),
+ zap.String("version", obj.ResourceVersion),
+ )
+ return nil
+ }
+ }
+ if ev.Type == types.EventDelete {
+ if sec != nil {
+ // We still find the resource while we are processing
the DELETE event,
+ // that means object with same namespace and name was
created, discarding
+ // this stale DELETE event.
+ log.Warnw("discard the stale
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #284: feat: support secret controller
codecov-io edited a comment on pull request #284: URL: https://github.com/apache/apisix-ingress-controller/pull/284#issuecomment-792198315 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=h1) Report > Merging [#284](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=desc) (3857b9f) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/c65cc2384a68b3bd17f886ee2c03e72aafea1206?el=desc) (c65cc23) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=tree) ```diff @@Coverage Diff @@ ## master #284 +/- ## == - Coverage 52.19% 52.17% -0.03% == Files 33 32 -1 Lines2320 2319 -1 == - Hits 1211 1210 -1 Misses952 952 Partials 157 157 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `2.00% <ø> (ø)` | | | [pkg/types/event.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284/diff?src=pr=tree#diff-cGtnL3R5cGVzL2V2ZW50Lmdv) | `100.00% <ø> (ø)` | | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284/diff?src=pr=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=footer). Last update [c65cc23...3857b9f](https://codecov.io/gh/apache/apisix-ingress-controller/pull/284?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3774: docs: modify the document table of contents to make it easier to read.
membphis commented on issue #3774: URL: https://github.com/apache/apisix/issues/3774#issuecomment-792288736 this is very important, I think @spacewander you can handle this issue by yourself This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis opened a new issue #3774: docs: modify the document table of contents to make it easier to read.
membphis opened a new issue #3774: URL: https://github.com/apache/apisix/issues/3774 current docs: https://apisix.apache.org/docs/apisix/architecture-design  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh edited a comment on issue #246: docs: added event about releasing APISIX 2.4
1502shivam-singh edited a comment on issue #246: URL: https://github.com/apache/apisix-website/issues/246#issuecomment-792282600 > You should remove the oldest event on the homepage. Was just writing when you commented, done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on issue #246: docs: added event about releasing APISIX 2.4
1502shivam-singh commented on issue #246: URL: https://github.com/apache/apisix-website/issues/246#issuecomment-792282600 > You should remove the oldest event on the homepage. Was just writing man This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] qier222 edited a comment on issue #246: docs: added event about releasing APISIX 2.4
qier222 edited a comment on issue #246: URL: https://github.com/apache/apisix-website/issues/246#issuecomment-792282508 You should remove the oldest event on the homepage. @1502shivam-singh This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
