[GitHub] [apisix] spacewander closed issue #3200: bug: authenticate(): request to the redirect_uri path but there's no session state found
spacewander closed issue #3200: URL: https://github.com/apache/apisix/issues/3200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3200: bug: authenticate(): request to the redirect_uri path but there's no session state found
spacewander commented on issue #3200: URL: https://github.com/apache/apisix/issues/3200#issuecomment-795040689 Closed as lack of response. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on pull request #1572: chore: add health e2e test
starsz commented on pull request #1572: URL: https://github.com/apache/apisix-dashboard/pull/1572#issuecomment-795040128 cc @Jaycean Can you review my code when you are free? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on pull request #1571: chore: improve ssl e2e test coverage
starsz commented on pull request #1571: URL: https://github.com/apache/apisix-dashboard/pull/1571#issuecomment-795039257 cc @Jaycean Can you review my code when you are free? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz opened a new pull request #1572: chore: add health e2e test
starsz opened a new pull request #1572: URL: https://github.com/apache/apisix-dashboard/pull/1572 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches Add health e2e test that we don't have before.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] pahud edited a comment on issue #149: [DISCUSS]Link access log and error log to stdout and stderr
pahud edited a comment on issue #149: URL: https://github.com/apache/apisix-docker/issues/149#issuecomment-795033768 Containerized apps with docker are usually designed to send its logs to `stdout` and `stderr` and the docker log drivers will capture it and route to the external destinations. In AWS, the default log driver is [awslogs](https://docs.aws.amazon.com/AmazonECS/latest/userguide/using_awslogs.html) which routes all the logs from `stdout` and `stderr` to Amazon CloudWatch Logs. It's also possible to run a sidecar container like `fluentd` or `fluentbit` as a log router to read the input from log files and send to external destinations. For single user local development, we can simply tail the log with [docker log](https://docs.docker.com/config/containers/logging/dual-logging/) or `kubectl logs`, however, in cloud environment, we need log drivers and log routers to ship the logs out to a centralized logging system or data ingestion system for further analysis. And the first thing we need to do is to ensure all the app logs in container always go to stdout and stderr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] pahud edited a comment on issue #149: [DISCUSS]Link access log and error log to stdout and stderr
pahud edited a comment on issue #149: URL: https://github.com/apache/apisix-docker/issues/149#issuecomment-795033768 Containerized apps with docker are usually designed to send its logs to `stdout` and `stderr` and the docker log drivers will capture it and route to the external destinations. In AWS, the default log driver is [awslogs](https://docs.aws.amazon.com/AmazonECS/latest/userguide/using_awslogs.html) which routes all the logs from `stdout` and `stderr` to Amazon CloudWatch Logs. It's also possible to run a sidecar container like `fluentd` or `fluentbit` as a log router to read the input from log files and send to external destinations. For single user local development, we can simply tail the log with [docker log](https://docs.docker.com/config/containers/logging/dual-logging/) or `kubectl logs`, however, in cloud environment, we need log drivers and log routers to ship the logs out. And the first thing we need to do is to ensure all the app logs in container always go to stdout and stderr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] pahud commented on issue #149: [DISCUSS]Link access log and error log to stdout and stderr
pahud commented on issue #149: URL: https://github.com/apache/apisix-docker/issues/149#issuecomment-795033768 Containerized apps with docker are usually designed to send its logs to `stdout` and `stderr` and the docker log drivers will capture it and route to the external destinations. In AWS, the default log driver is [awslogs](https://docs.aws.amazon.com/AmazonECS/latest/userguide/using_awslogs.html) which routes all the logs from `stdout` and `stderr` to Amazon CloudWatch Logs. It's also possible to run a sidecar container like `fluentd` or `fluentbit` as a log router to read the input from log files and send to external destinations. For single user local development, we can simply tail the log with [docker log](https://docs.docker.com/config/containers/logging/dual-logging/), however, in cloud environment, we need log drivers and log routers to ship the logs out. And the first thing we need to do is to ensure all the app logs in container always go to stdout and stderr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] libeio commented on issue #3798: request help: the response is '{"error_msg":"404 Route Not Found"}' while requesting the service proxyed by apisix
libeio commented on issue #3798: URL: https://github.com/apache/apisix/issues/3798#issuecomment-795030078 I Got! In the `Route UI`'s item `request basic definition`, filled the `client addr` blank with `192.168.2.0/24` required ip field. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] libeio closed issue #3798: request help: the response is '{"error_msg":"404 Route Not Found"}' while requesting the service proxyed by apisix
libeio closed issue #3798: URL: https://github.com/apache/apisix/issues/3798 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz opened a new pull request #1571: chore: improve ssl e2e test coverage
starsz opened a new pull request #1571: URL: https://github.com/apache/apisix-dashboard/pull/1571 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [x] Improve performance - [ ] Backport patches Because some function in SSL e2e test is not covered. This PR is to cover those functions.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3796: docs: sync English doc to Chinese
spacewander merged pull request #3796: URL: https://github.com/apache/apisix/pull/3796 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: sync English doc to Chinese (#3796)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 8609cd5 docs: sync English doc to Chinese (#3796)
8609cd5 is described below
commit 8609cd507a554c62474c3915160a4f9c1c47afef
Author: 罗泽轩
AuthorDate: Wed Mar 10 15:14:41 2021 +0800
docs: sync English doc to Chinese (#3796)
Signed-off-by: spacewander
---
docs/zh/latest/architecture-design.md | 824 -
docs/zh/latest/architecture-design/apisix.md | 58 ++
docs/zh/latest/architecture-design/consumer.md | 127
docs/zh/latest/architecture-design/debug-mode.md | 80 ++
docs/zh/latest/architecture-design/global-rule.md | 51 ++
.../zh/latest/architecture-design/plugin-config.md | 140
docs/zh/latest/architecture-design/plugin.md | 70 ++
docs/zh/latest/architecture-design/route.md| 62 ++
docs/zh/latest/architecture-design/router.md | 39 +
docs/zh/latest/architecture-design/script.md | 39 +
docs/zh/latest/architecture-design/service.md | 88 +++
docs/zh/latest/architecture-design/upstream.md | 218 ++
docs/zh/latest/config.json | 119 +--
13 files changed, 1044 insertions(+), 871 deletions(-)
diff --git a/docs/zh/latest/architecture-design.md
b/docs/zh/latest/architecture-design.md
deleted file mode 100644
index 9a1d560..000
--- a/docs/zh/latest/architecture-design.md
+++ /dev/null
@@ -1,824 +0,0 @@
-title: 架构设计
-
-
-
-## 目录
-
-- [目录](#目录)
-- [APISIX](#apisix)
- - [插件加载流程](#插件加载流程)
- - [插件内部结构](#插件内部结构)
-- [APISIX Config](#apisix-config)
-- [Route](#route)
-- [Service](#service)
-- [Plugin](#plugin)
-- [Script](#script)
-- [Upstream](#upstream)
- - [配置参数](#配置参数)
-- [Consumer](#consumer)
- - [Cookie](#cookie)
- - [Header](#header)
-- [Router](#router)
-- [Consumer](#consumer-1)
-- [Global Rule](#global-rule)
-- [Plugin Config](#plugin-config)
-- [Debug mode](#debug-mode)
- - [基本调试模式](#基本调试模式)
- - [高级调试模式](#高级调试模式)
-
-## APISIX
-
-### 插件加载流程
-
-
-
-### 插件内部结构
-
-
-
-## APISIX Config
-
-通过修改本地 `conf/config.yaml` 文件，或者在启动 APISIX 时使用 `-c` 或 `--config` 添加文件路径参数
`apisix start -c `，完成对 APISIX 服务本身的基本配置。
-
-比如修改 APISIX 默认监听端口为 8000，其他配置保持默认，在 `config.yaml` 中只需这样配置：
-
-```yaml
-apisix:
- node_listen: 8000 # APISIX listening port
-```
-
-比如指定 APISIX 默认监听端口为 8000，并且设置 etcd 地址为 `http://foo:2379`，
-其他配置保持默认。在 `config.yaml` 中只需这样配置：
-
-```yaml
-apisix:
- node_listen: 8000 # APISIX listening port
-
-etcd:
- host: "http://foo:2379"; # etcd address
-```
-
-其他默认配置，可以在 `conf/config-default.yaml` 文件中看到，该文件是与 APISIX 源码强绑定，
-**永远不要**手工修改 `conf/config-default.yaml` 文件。如果需要自定义任何配置，都应在 `config.yaml` 文件中完成。
-
-_注意_ 不要手工修改 APISIX 自身的 `conf/nginx.conf` 文件，当服务每次启动时，`apisix`
-会根据 `config.yaml` 配置自动生成新的 `conf/nginx.conf` 并自动启动服务。
-
-[返回目录](#目录)
-
-## Route
-
-Route 字面意思就是路由，通过定义一些规则来匹配客户端的请求，然后根据匹配结果加载并执行相应的
-插件，并把请求转发给到指定 Upstream。
-
-Route 中主要包含三部分内容：匹配规则(比如 uri、host、remote_addr 等)，插件配置(限流限速等)和上游信息。
-请看下图示例，是一些 Route 规则的实例，当某些属性值相同时，图中用相同颜色标识。
-
-
-
-我们直接在 Route 中完成所有参数的配置，优点是容易设置，每个 Route 都相对独立自由度比较高。但当我们的 Route
有比较多的重复配置（比如启用相同的插件配置或上游信息），一旦我们要更新这些相同属性时，就需要遍历所有 Route 并进行修改，给后期管理维护增加不少复杂度。
-
-上面提及重复的缺点在 APISIX 中独立抽象了 [Service](#service) 和 [Upstream](#upstream) 两个概念来解决。
-
-下面创建的 Route 示例，是把 URL 为 "/index.html" 的请求代理到地址为 "39.97.63.215:80" 的 Upstream
服务：
-
-```shell
-$ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
-{
-"uri": "/index.html",
-"upstream": {
-"type": "roundrobin",
-"nodes": {
-"39.97.63.215:80": 1
-}
-}
-}'
-
-HTTP/1.1 201 Created
-Date: Sat, 31 Aug 2019 01:17:15 GMT
-Content-Type: text/plain
-Transfer-Encoding: chunked
-Connection: keep-alive
-Server: APISIX web server
-
-{"node":{"value":{"uri":"\/index.html","upstream":{"nodes":{"39.97.63.215:80":1},"type":"roundrobin"}},"createdIndex":61925,"key":"\/apisix\/routes\/1","modifiedIndex":61925},"action":"create"}
-```
-
-当我们接收到成功应答，表示该 Route 已成功创建。
-
-有关 Route 的具体选项，可具体查阅 [Admin API 之 Route](admin-api.md#route)。
-
-[返回目录](#目录)
-
-## Service
-
-`Service` 是某类 API 的抽象（也可以理解为一组 Route 的抽象）。它通常与上游服务抽象是一一对应的，`Route`
-与 `Service` 之间，通常是 N:1 的关系，参看下图。
-
-
-
-不同 Route 规则同时绑定到一个 Service 上，这些 Route 将具有相同的上游和插件配置，减少冗余配置。
-
-比如下面的例子，创建了一个启用限流插件的 Service，然后把 id 为 `100`、`101` 的 Route 都绑定在这个 Service 上。
-
-```shell
-# create new Service
-$ curl http://127.0.0.1:9080/apisix/admin/services/200 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
-{
-"plugins": {
-"limit-count": {
-"count": 2,
-"time_window": 60,
[apisix] branch master updated (f7eb87c -> 8dcbe4e)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from f7eb87c docs: update the content of "Does APISIX have a console interface" in the FAQ doc (#3788) add 8dcbe4e feat: let balancer support priority (#3755) No new revisions were added by this update. Summary of changes: apisix/balancer.lua | 40 +++- apisix/balancer/chash.lua | 10 +- apisix/balancer/ewma.lua | 12 +- apisix/balancer/least_conn.lua| 15 +- apisix/balancer/priority.lua | 81 apisix/balancer/roundrobin.lua| 10 +- apisix/schema_def.lua | 5 + apisix/upstream.lua | 16 +- apisix/utils/upstream.lua | 2 +- docs/en/latest/admin-api.md | 36 docs/en/latest/control-api.md | 9 + docs/zh/latest/admin-api.md | 35 t/admin/balancer.t| 40 ++-- t/control/healthcheck.t | 12 +- t/discovery/consul_kv.t | 4 +- t/node/priority-balancer/health-checker.t | 187 + t/node/priority-balancer/sanity.t | 332 ++ t/node/upstream-discovery.t | 84 +++- 18 files changed, 880 insertions(+), 50 deletions(-) create mode 100644 apisix/balancer/priority.lua create mode 100644 t/node/priority-balancer/health-checker.t create mode 100644 t/node/priority-balancer/sanity.t
[GitHub] [apisix] spacewander merged pull request #3755: feat: let balancer support priority
spacewander merged pull request #3755: URL: https://github.com/apache/apisix/pull/3755 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #1809: request help: Health Checks can support Backup server?
spacewander closed issue #1809: URL: https://github.com/apache/apisix/issues/1809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1569: feat: supports changing number of executing cpu cores for manager api
codecov-io commented on pull request #1569: URL: https://github.com/apache/apisix-dashboard/pull/1569#issuecomment-794937325 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1569?src=pr&el=h1) Report > Merging [#1569](https://codecov.io/gh/apache/apisix-dashboard/pull/1569?src=pr&el=desc) (40dad6b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c8b235bb4a60c2d91840a4385649998bd1e9a841?el=desc) (c8b235b) will **increase** coverage by `4.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1569?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1569 +/- ## == + Coverage 69.15% 73.21% +4.05% == Files 49 86 +37 Lines3164 2322 -842 Branches0 584 +584 == - Hits 2188 1700 -488 + Misses728 622 -106 + Partials 2480 -248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.21% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1569?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1569/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1569/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1569/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1569/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1569/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | | | | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1569/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | | | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1569/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1569/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | | | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1569/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1569/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | | | ... and [124 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1569/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1569?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1569?src=pr&el=footer). Last update [c8b235b...40dad6b](https://codecov.io/gh/apache/apisix-dashboard/pull/1569?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
Jaycean opened a new pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues #1500 ___ ### New feature or improvement - Rewrite e2e test( route-with-scripte-luacode ) with ginkgo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] libeio opened a new issue #3798: request help: the response is '{"error_msg":"404 Route Not Found"}' while requesting the service proxyed by apisix
libeio opened a new issue #3798: URL: https://github.com/apache/apisix/issues/3798 hello dev. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #290: doc: add ApisixTls docs
tokers commented on a change in pull request #290: URL: https://github.com/apache/apisix-ingress-controller/pull/290#discussion_r591062230 ## File path: docs/en/latest/concepts/apisix_tls.md ## @@ -0,0 +1,48 @@ +--- +title: ApisixTls +--- + + + +ApisixTls associates with a Kubernetes [Secret](https://kubernetes.io/docs/concepts/configuration/secret/) resource and +generates an [APISIX SSL](http://apisix.apache.org/docs/apisix/admin-api#ssl) object. It asks the +Secret must have two keys `cert` and `key`, which used to store the certificate and private key in +PEM format respectively. + +```shell +apiVersion: apisix.apache.org/v1 +kind: ApisixTls +metadata: + name: sample-tls +spec: + hosts: + - httpbin.org + secret: +name: htpbin-cert +namespace: default +``` + +Note the `hosts` field should be written carefully, it's used by Apache APISIX to match the +correct certificate, what's more, it also should be matched with the [Server Name Indication](https://www.globalsign.com/en/blog/what-is-server-name-indication#:~:text=Server%20Name%20Indication%20(SNI)%20allows,in%20the%20CLIENT%20HELLO%20message) +extension in TLS, or the TLS handshaking might fail. + +The apisix-ingress-controller will watch Secret resources that referred by ApisixTls objects, once a +Secret changed, apisix-ingress-controller will re translate all referred ApisixTls objects, converting them to +APISIX SSL resources ultimately. Review comment: Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated (bb71f50 -> 038a047)
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. from bb71f50 fix: grammar error add 038a047 doc: update internal architecture diagram (#288) No new revisions were added by this update. Summary of changes: README.md | 36 ++--- .../images/apisix-ingress-controller-arch.png | Bin 0 -> 38825 bytes 2 files changed, 2 insertions(+), 34 deletions(-) create mode 100644 docs/assets/images/apisix-ingress-controller-arch.png
[GitHub] [apisix-ingress-controller] tokers merged pull request #288: doc: update internal architecture diagram
tokers merged pull request #288: URL: https://github.com/apache/apisix-ingress-controller/pull/288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on issue #149: [DISCUSS]Link access log and error log to stdout and stderr
tokers commented on issue #149: URL: https://github.com/apache/apisix-docker/issues/149#issuecomment-794904839 @pahud How does people going to collect the access log and error log if they were redirected to stdin and stdout. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1569: feat: supports changing number of executing cpu cores for manager api
bisakhmondal commented on a change in pull request #1569:
URL: https://github.com/apache/apisix-dashboard/pull/1569#discussion_r591057039
##
File path: api/internal/conf/conf.go
##
@@ -249,3 +254,16 @@ func initEtcdConfig(conf Etcd) {
Prefix:prefix,
}
}
+
+// initialize parallelism settings
+func initParallelism(choiceCores int) {
+ if choiceCores < 0 {
Review comment:
True. It makes sense.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #289: Support Traffic Split in ApisixRoute
tokers commented on issue #289: URL: https://github.com/apache/apisix-ingress-controller/issues/289#issuecomment-794897478 > Not familiar with this temporarily, just one point: how about using `serviceWithWeight` instead of `weightedBackends`? Just like @Junnplus , We can unify the `weightedBackends` and `backend`. ```yaml apiVersion: apisix.apache.org/v2alpha1 kind: ApisixRoute metadata: name: httpbin-route spec: http: - name: rule1 match: hosts: - httpbin.com paths: - /ip backend: serviceName: httpbin servicePort: 80 - name: rule2 match: hosts: - httpbin.com paths: - /status backends: - serviceName: httpbin servicePort: 80 weight: 100 - serviceName: httpbin2 servicePort: 8080 weight: 50 ``` But the `backend` is used as an object, we may use another field `backends`, and telling people to use the `backends` field.In the future release, we may deprecate the `backend` field and even delete it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #289: Support Traffic Split in ApisixRoute
tokers commented on issue #289: URL: https://github.com/apache/apisix-ingress-controller/issues/289#issuecomment-794895816 > `weightedBackends` and `backend` can be unified? But the weight are different, default weight 100. Maybe we can allow user to ignore the weight when there is only one backend. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] LiteSun opened a new pull request #3797: docs: update contributor over time image
LiteSun opened a new pull request #3797: URL: https://github.com/apache/apisix/pull/3797 ### What this PR does / why we need it: update contributor over time image ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] Junnplus commented on issue #289: Support Traffic Split in ApisixRoute
Junnplus commented on issue #289: URL: https://github.com/apache/apisix-ingress-controller/issues/289#issuecomment-794836780 `weightedBackends` and `backend` can be unified? But the weight are different, default weight 100. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #3796: docs: sync English doc to Chinese
juzhiyuan commented on pull request #3796: URL: https://github.com/apache/apisix/pull/3796#issuecomment-794827698 ok, wait for a while. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] starsz commented on issue #149: [DISCUSS]Link access log and error log to stdout and stderr
starsz commented on issue #149: URL: https://github.com/apache/apisix-docker/issues/149#issuecomment-794825532 @membphis What's your opinion? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1461: feat: Confirm whether the store related functions are still in use. If not, delete them
juzhiyuan closed issue #1461: URL: https://github.com/apache/apisix-dashboard/issues/1461 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1567: Delete the unused file in internal/core/store
juzhiyuan closed issue #1567: URL: https://github.com/apache/apisix-dashboard/issues/1567 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1568: chore: delete unused file
juzhiyuan merged pull request #1568: URL: https://github.com/apache/apisix-dashboard/pull/1568 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: chore: delete unused file (#1568)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 569c4bd chore: delete unused file (#1568)
569c4bd is described below
commit 569c4bdbb934ab6d6a063750b931b22db99bae90
Author: Peter Zhu
AuthorDate: Wed Mar 10 11:28:32 2021 +0800
chore: delete unused file (#1568)
---
api/internal/core/entity/query.go| 142
api/internal/core/store/query.go | 137
api/internal/core/store/selector.go | 128 ---
api/internal/core/store/selector_test.go | 269 ---
api/internal/core/store/store.go | 5 +
api/internal/handler/ssl/ssl.go | 70
6 files changed, 39 insertions(+), 712 deletions(-)
diff --git a/api/internal/core/entity/query.go
b/api/internal/core/entity/query.go
deleted file mode 100644
index ae38342..000
--- a/api/internal/core/entity/query.go
+++ /dev/null
@@ -1,142 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package entity
-
-import (
- "strings"
-
- "github.com/apisix/manager-api/internal/utils"
-)
-
-type PropertyName string
-
-const (
- IdProperty = "id"
- NameProperty = "name"
- SniProperty= "sni"
- SnisProperty = "snis"
- CreateTimeProperty = "create_time"
- UpdateTimeProperty = "update_time"
-)
-
-type ComparableValue interface {
- Compare(ComparableValue) int
- Contains(ComparableValue) bool
-}
-
-type ComparingString string
-
-func (comparing ComparingString) Compare(compared ComparableValue) int {
- other := compared.(ComparingString)
- return strings.Compare(string(comparing), string(other))
-}
-
-func (comparing ComparingString) Contains(compared ComparableValue) bool {
- other := compared.(ComparingString)
- return strings.Contains(string(comparing), string(other))
-}
-
-type ComparingStringArray []string
-
-func (comparing ComparingStringArray) Compare(compared ComparableValue) int {
- other := compared.(ComparingString)
- res := -1
- for _, str := range comparing {
- result := strings.Compare(str, string(other))
- if result == 0 {
- res = 0
- break
- }
- }
- return res
-}
-
-func (comparing ComparingStringArray) Contains(compared ComparableValue) bool {
- other := compared.(ComparingString)
- res := false
- for _, str := range comparing {
- if strings.Contains(str, string(other)) {
- res = true
- break
- }
- }
- return res
-}
-
-type ComparingInt int64
-
-func int64Compare(a, b int64) int {
- if a > b {
- return 1
- } else if a == b {
- return 0
- }
- return -1
-}
-
-func (comparing ComparingInt) Compare(compared ComparableValue) int {
- other := compared.(ComparingInt)
- return int64Compare(int64(comparing), int64(other))
-}
-
-func (comparing ComparingInt) Contains(compared ComparableValue) bool {
- return comparing.Compare(compared) == 0
-}
-
-func (info BaseInfo) GetProperty(name PropertyName) ComparableValue {
- switch name {
- case IdProperty:
- id := utils.InterfaceToString(info.ID)
- return ComparingString(id)
- case CreateTimeProperty:
- return ComparingInt(info.CreateTime)
- case UpdateTimeProperty:
- return ComparingInt(info.UpdateTime)
- default:
- return nil
- }
-}
-
-func (route Route) GetProperty(name PropertyName) ComparableValue {
- switch name {
- case NameProperty:
- return ComparingString(route.Name)
- default:
- return nil
- }
-}
-
-func (upstream Upstream) GetProperty(name PropertyName) ComparableValue {
- switch name {
- case NameProperty:
- return ComparingString(upstream.Name)
- defa
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1558: feat:Support duplicate one existing Route
nic-chen commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-794809084 backend CI had been resolved. please help check FE CI when you have time. @LiteSun This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] pahud commented on issue #149: [DISCUSS]Link access log and error log to stdout and stderr
pahud commented on issue #149: URL: https://github.com/apache/apisix-docker/issues/149#issuecomment-794791225 I am working on this issue https://github.com/pahud/cdk-apisix/issues/67 and will need the upstream apisix docker container output its log to stdout and stderr just like Nginx and OpenResty. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] pahud commented on issue #149: [DISCUSS]Link access log and error log to stdout and stderr
pahud commented on issue #149: URL: https://github.com/apache/apisix-docker/issues/149#issuecomment-794789522 Nginx official dockerfile https://github.com/nginxinc/docker-nginx/blob/fa2213a76da35137a5aee565cef5095a209aeb3d/mainline/debian/Dockerfile#L100-L102 OpenResty official dockerfile https://github.com/openresty/docker-openresty/blob/b464e27f22c7fad271c5822bd0812742223c9653/alpine/Dockerfile#L151-L152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1568: chore: delete unused file
Jaycean commented on pull request #1568: URL: https://github.com/apache/apisix-dashboard/pull/1568#issuecomment-794772888 > Hi @Jaycean, would you please have a review when you have time? no problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1568: chore: delete unused file
juzhiyuan commented on pull request #1568: URL: https://github.com/apache/apisix-dashboard/pull/1568#issuecomment-794766223 Hi @Jaycean, would you please have a review when you have time? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3792: discuss: the "active.host" in the active health check should be optional
spacewander commented on issue #3792: URL: https://github.com/apache/apisix/issues/3792#issuecomment-794765428 Just docs mistake This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3788: docs: update the content of "Does APISIX have a console interface" in the FAQ doc
spacewander merged pull request #3788: URL: https://github.com/apache/apisix/pull/3788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: update the content of "Does APISIX have a console interface" in the FAQ doc (#3788)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new f7eb87c docs: update the content of "Does APISIX have a console interface" in the FAQ doc (#3788) f7eb87c is described below commit f7eb87c8936f148f6f205aa6af2f42bb3ed47841 Author: Yuelin Zheng <2226815...@qq.com> AuthorDate: Wed Mar 10 10:34:29 2021 +0800 docs: update the content of "Does APISIX have a console interface" in the FAQ doc (#3788) --- docs/en/latest/FAQ.md | 2 +- docs/zh/latest/FAQ.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/en/latest/FAQ.md b/docs/en/latest/FAQ.md index b6f38d6..3f439ce 100644 --- a/docs/en/latest/FAQ.md +++ b/docs/en/latest/FAQ.md @@ -41,7 +41,7 @@ APISIX is the highest performance API gateway with a single-core QPS of 23,000, ## Does APISIX have a console interface? -Yes, in version 0.6 we have dashboard built in, you can operate APISIX through the web interface. +Yes, APISIX has a powerful Dashboard. APISIX and [APISIX Dashboard](https://github.com/apache/apisix-dashboard) are independent projects, you can deploy [APISIX Dashboard](https://github.com/apache/apisix-dashboard) to operate APISIX through the web interface. ## Can I write my own plugin? diff --git a/docs/zh/latest/FAQ.md b/docs/zh/latest/FAQ.md index 612294d..be7e782 100644 --- a/docs/zh/latest/FAQ.md +++ b/docs/zh/latest/FAQ.md @@ -40,7 +40,7 @@ APISIX 是当前性能最好的 API 网关，单核 QPS 达到 2.3 万，平均 ## APISIX 是否有控制台界面？ -是的，在 0.6 版本中我们内置了 dashboard，你可以通过 web 界面来操作 APISIX 了。 +是的，APISIX 具有功能强大的 Dashboard。APISIX 与 [APISIX Dashboard](https://github.com/apache/apisix-dashboard) 是相互独立的项目，你可以部署 [APISIX Dashboard](https://github.com/apache/apisix-dashboard) 通过 web 界面来操作 APISIX。 ## 我可以自己写插件吗？
[GitHub] [apisix-dashboard] Jaycean commented on issue #1461: feat: Confirm whether the store related functions are still in use. If not, delete them
Jaycean commented on issue #1461: URL: https://github.com/apache/apisix-dashboard/issues/1461#issuecomment-794753390 > > I see pr: #1568 issue: #1567 > > Think of this issue. > > Oh Yes.Sorry for forgetting this. It doesn't matter. Actually, I forgot it. It's my problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1461: feat: Confirm whether the store related functions are still in use. If not, delete them
starsz commented on issue #1461: URL: https://github.com/apache/apisix-dashboard/issues/1461#issuecomment-794752457 > I see pr: #1568 issue: #1567 > Think of this issue. Oh Yes.Sorry for forgetting this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3794: docs: fixed invalid URLs in translation docs
juzhiyuan commented on a change in pull request #3794: URL: https://github.com/apache/apisix/pull/3794#discussion_r590935613 ## File path: docs/zh/latest/discovery.md ## @@ -49,9 +49,9 @@ title: 集成服务发现注册中心 目前支持 Eureka / Consul 和基于 DNS 的服务注册发现。 -基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](../../en/latest/discovery/dns.md)。 +基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](https://github.com/apache/apisix/blob/master/docs/en/latest/discovery/dns.md)。 Review comment: no problem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] qier222 commented on a change in pull request #3794: docs: fixed invalid URLs in translation docs
qier222 commented on a change in pull request #3794: URL: https://github.com/apache/apisix/pull/3794#discussion_r590934493 ## File path: docs/zh/latest/discovery.md ## @@ -49,9 +49,9 @@ title: 集成服务发现注册中心 目前支持 Eureka / Consul 和基于 DNS 的服务注册发现。 -基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](../../en/latest/discovery/dns.md)。 +基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](https://github.com/apache/apisix/blob/master/docs/en/latest/discovery/dns.md)。 Review comment: I am available tomorrow or the day after tomorrow This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1568: improve: delete unused file
codecov-io edited a comment on pull request #1568: URL: https://github.com/apache/apisix-dashboard/pull/1568#issuecomment-794742803 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=h1) Report > Merging [#1568](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=desc) (9fa7d97) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b795db47d44f14ed7327fa30f0027ec266317b2?el=desc) (6b795db) will **increase** coverage by `2.31%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1568 +/- ## == + Coverage 70.90% 73.21% +2.31% == Files 135 86 -49 Lines5485 2322-3163 Branches 583 584 +1 == - Hits 3889 1700-2189 + Misses 1348 622 -726 + Partials 2480 -248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.21% <ø> (-0.12%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `75.38% <0.00%> (-1.54%)` | :arrow_down: | | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `77.64% <0.00%> (-0.93%)` | :arrow_down: | | [web/src/pages/Plugin/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW4vTGlzdC50c3g=) | `93.33% <0.00%> (ø)` | | | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.36% <0.00%> (ø)` | | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | | | | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | | | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | | | ... and [38 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=footer). Last update [6b795db...9fa7d97](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at
[GitHub] [apisix] juzhiyuan commented on issue #3792: discuss: the "active.host" in the active health check should be optional
juzhiyuan commented on issue #3792: URL: https://github.com/apache/apisix/issues/3792#issuecomment-794743460 Hi, this is due to `docs mistake` or should we modify `logics`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1568: improve: delete unused file
codecov-io commented on pull request #1568: URL: https://github.com/apache/apisix-dashboard/pull/1568#issuecomment-794742803 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=h1) Report > Merging [#1568](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=desc) (f96dfc5) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b795db47d44f14ed7327fa30f0027ec266317b2?el=desc) (6b795db) will **increase** coverage by `2.31%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1568 +/- ## == + Coverage 70.90% 73.21% +2.31% == Files 135 86 -49 Lines5485 2322-3163 Branches 583 584 +1 == - Hits 3889 1700-2189 + Misses 1348 622 -726 + Partials 2480 -248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.21% <ø> (-0.12%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `75.38% <0.00%> (-1.54%)` | :arrow_down: | | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `77.64% <0.00%> (-0.93%)` | :arrow_down: | | [web/src/pages/Plugin/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW4vTGlzdC50c3g=) | `93.33% <0.00%> (ø)` | | | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `97.36% <0.00%> (ø)` | | | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | | | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | | | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | | | ... and [39 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1568/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=footer). Last update [6b795db...9fa7d97](https://codecov.io/gh/apache/apisix-dashboard/pull/1568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #290: doc: add ApisixTls docs
gxthrj commented on a change in pull request #290: URL: https://github.com/apache/apisix-ingress-controller/pull/290#discussion_r590929428 ## File path: docs/en/latest/concepts/apisix_tls.md ## @@ -0,0 +1,48 @@ +--- +title: ApisixTls +--- + + + +ApisixTls associates with a Kubernetes [Secret](https://kubernetes.io/docs/concepts/configuration/secret/) resource and +generates an [APISIX SSL](http://apisix.apache.org/docs/apisix/admin-api#ssl) object. It asks the +Secret must have two keys `cert` and `key`, which used to store the certificate and private key in +PEM format respectively. + +```shell +apiVersion: apisix.apache.org/v1 +kind: ApisixTls +metadata: + name: sample-tls +spec: + hosts: + - httpbin.org + secret: +name: htpbin-cert +namespace: default +``` + +Note the `hosts` field should be written carefully, it's used by Apache APISIX to match the +correct certificate, what's more, it also should be matched with the [Server Name Indication](https://www.globalsign.com/en/blog/what-is-server-name-indication#:~:text=Server%20Name%20Indication%20(SNI)%20allows,in%20the%20CLIENT%20HELLO%20message) +extension in TLS, or the TLS handshaking might fail. + +The apisix-ingress-controller will watch Secret resources that referred by ApisixTls objects, once a +Secret changed, apisix-ingress-controller will re translate all referred ApisixTls objects, converting them to +APISIX SSL resources ultimately. Review comment: Should not in a new line. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3794: docs: fixed invalid URLs in translation docs
juzhiyuan commented on a change in pull request #3794: URL: https://github.com/apache/apisix/pull/3794#discussion_r590929230 ## File path: docs/zh/latest/discovery.md ## @@ -49,9 +49,9 @@ title: 集成服务发现注册中心 目前支持 Eureka / Consul 和基于 DNS 的服务注册发现。 -基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](../../en/latest/discovery/dns.md)。 +基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](https://github.com/apache/apisix/blob/master/docs/en/latest/discovery/dns.md)。 Review comment: ok 🤔 @qier222 would you have time to fix this issue? @iamayushdas and thanks for your contribution, but please be patient to wait for @qier222's update, he has better solutions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] anjia0532 commented on pull request #150: feat: add apisix-dashbaord
anjia0532 commented on pull request #150: URL: https://github.com/apache/apisix-docker/pull/150#issuecomment-794740342 我改的是md文档，不会触发这个错误。  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] nic-chen commented on pull request #150: feat: add apisix-dashbaord
nic-chen commented on pull request #150: URL: https://github.com/apache/apisix-docker/pull/150#issuecomment-794732297 @anjia0532 CI failed, please have a look This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] anjia0532 commented on pull request #150: feat: add apisix-dashbaord
anjia0532 commented on pull request #150: URL: https://github.com/apache/apisix-docker/pull/150#issuecomment-794730913 @nic-chen OK This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3796: docs: sync English doc to Chinese
spacewander opened a new pull request #3796: URL: https://github.com/apache/apisix/pull/3796 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3794: docs: fixed invalid URLs in translation docs
spacewander commented on a change in pull request #3794: URL: https://github.com/apache/apisix/pull/3794#discussion_r590915770 ## File path: docs/zh/latest/discovery.md ## @@ -49,9 +49,9 @@ title: 集成服务发现注册中心 目前支持 Eureka / Consul 和基于 DNS 的服务注册发现。 -基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](../../en/latest/discovery/dns.md)。 +基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](https://github.com/apache/apisix/blob/master/docs/en/latest/discovery/dns.md)。 Review comment: The current solution won't work if we introduce multiple versions of docs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] nic-chen commented on pull request #150: feat: add apisix-dashbaord
nic-chen commented on pull request #150: URL: https://github.com/apache/apisix-docker/pull/150#issuecomment-794722105 > 我这个PR是因为在看官方文档时想quickstart一个比较全的demo（包含dashboard），但是还得去别的地方找资料，自己改 Sorry, I was misled by pr title. What I said above should be done by another pr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1569: feat: supports changing number of executing cpu cores for manager api
nic-chen commented on a change in pull request #1569:
URL: https://github.com/apache/apisix-dashboard/pull/1569#discussion_r590911946
##
File path: api/internal/conf/conf.go
##
@@ -249,3 +254,16 @@ func initEtcdConfig(conf Etcd) {
Prefix:prefix,
}
}
+
+// initialize parallelism settings
+func initParallelism(choiceCores int) {
+ if choiceCores < 0 {
Review comment:
how about
```suggestion
if choiceCores < 1 {
```
because 0 means no limit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] anjia0532 commented on pull request #1566: fix(doc): fix some document url
anjia0532 commented on pull request #1566: URL: https://github.com/apache/apisix-dashboard/pull/1566#issuecomment-794702704 @juzhiyuan replace absolute path but relative path not This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] qier222 commented on a change in pull request #3794: docs: fixed invalid URLs in translation docs
qier222 commented on a change in pull request #3794: URL: https://github.com/apache/apisix/pull/3794#discussion_r590892978 ## File path: docs/zh/latest/discovery.md ## @@ -49,9 +49,9 @@ title: 集成服务发现注册中心 目前支持 Eureka / Consul 和基于 DNS 的服务注册发现。 -基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](../../en/latest/discovery/dns.md)。 +基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](https://github.com/apache/apisix/blob/master/docs/en/latest/discovery/dns.md)。 Review comment: We can modify `sync-docs.js` to replace URLs like this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3783: request help: SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number
spacewander commented on issue #3783: URL: https://github.com/apache/apisix/issues/3783#issuecomment-794691669 Will you provide a network capture file including the handshake with the upstream? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3794: docs: fixed invalid URLs in translation docs
juzhiyuan commented on a change in pull request #3794: URL: https://github.com/apache/apisix/pull/3794#discussion_r590889605 ## File path: docs/zh/latest/discovery.md ## @@ -49,9 +49,9 @@ title: 集成服务发现注册中心 目前支持 Eureka / Consul 和基于 DNS 的服务注册发现。 -基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](../../en/latest/discovery/dns.md)。 +基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](https://github.com/apache/apisix/blob/master/docs/en/latest/discovery/dns.md)。 Review comment: or @qier222, please check this issue to see if there have solutions to support this case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3792: discuss: the "active.host" in the active health check should be optional
spacewander commented on issue #3792: URL: https://github.com/apache/apisix/issues/3792#issuecomment-794689378 Yes. The `host` should be similar to the `port`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3794: docs: fixed invalid URLs in translation docs
juzhiyuan commented on a change in pull request #3794: URL: https://github.com/apache/apisix/pull/3794#discussion_r590889260 ## File path: docs/zh/latest/discovery.md ## @@ -49,9 +49,9 @@ title: 集成服务发现注册中心 目前支持 Eureka / Consul 和基于 DNS 的服务注册发现。 -基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](../../en/latest/discovery/dns.md)。 +基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](https://github.com/apache/apisix/blob/master/docs/en/latest/discovery/dns.md)。 Review comment: yes, when this framework building, broken links occurred. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3794: docs: fixed invalid URLs in translation docs
spacewander commented on a change in pull request #3794: URL: https://github.com/apache/apisix/pull/3794#discussion_r590888283 ## File path: docs/zh/latest/discovery.md ## @@ -49,9 +49,9 @@ title: 集成服务发现注册中心 目前支持 Eureka / Consul 和基于 DNS 的服务注册发现。 -基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](../../en/latest/discovery/dns.md)。 +基于 DNS 的服务注册发现见 [基于 DNS 的服务支持发现](https://github.com/apache/apisix/blob/master/docs/en/latest/discovery/dns.md)。 Review comment: The doc site doesn't support links across different language versions, @juzhiyuan ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3789: fix: don't override cache relative headers
spacewander merged pull request #3789: URL: https://github.com/apache/apisix/pull/3789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3677: bug: proxy-cache plugin has side-effect even if it's not configured in any route
spacewander closed issue #3677: URL: https://github.com/apache/apisix/issues/3677 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3373: request help: The proxy-cache plugin overrides `Cache-Control` in upstream header.
spacewander closed issue #3373: URL: https://github.com/apache/apisix/issues/3373 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: fix: don't override cache relative headers (#3789)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new d538105 fix: don't override cache relative headers (#3789)
d538105 is described below
commit d538105b1adcc76819f3c539d9c5bde7e9a5b482
Author: 罗泽轩
AuthorDate: Wed Mar 10 09:02:28 2021 +0800
fix: don't override cache relative headers (#3789)
---
apisix/cli/ngx_tpl.lua | 7 --
apisix/core/ctx.lua| 2 --
apisix/plugins/proxy-cache.lua | 15 +
t/APISIX.pm| 8 ---
t/plugin/proxy-cache.t | 49 ++
5 files changed, 60 insertions(+), 21 deletions(-)
diff --git a/apisix/cli/ngx_tpl.lua b/apisix/cli/ngx_tpl.lua
index 7255a10..b7c1e17 100644
--- a/apisix/cli/ngx_tpl.lua
+++ b/apisix/cli/ngx_tpl.lua
@@ -492,8 +492,6 @@ http {
set $upstream_cache_key '';
set $upstream_cache_bypass '';
set $upstream_no_cache '';
-set $upstream_hdr_expires '';
-set $upstream_hdr_cache_control '';
proxy_cache $upstream_cache_zone;
proxy_cache_valid any {% if
proxy_cache.cache_ttl then %} {* proxy_cache.cache_ttl *} {% else %} 10s {% end
%};
@@ -505,11 +503,6 @@ http {
proxy_no_cache $upstream_no_cache;
proxy_cache_bypass $upstream_cache_bypass;
-proxy_hide_header Cache-Control;
-proxy_hide_header Expires;
-add_header Cache-Control $upstream_hdr_cache_control;
-add_header Expires $upstream_hdr_expires;
-add_header Apisix-Cache-Status $upstream_cache_status always;
{% end %}
proxy_pass $upstream_scheme://apisix_backend$upstream_uri;
diff --git a/apisix/core/ctx.lua b/apisix/core/ctx.lua
index 962a270..d87342b 100644
--- a/apisix/core/ctx.lua
+++ b/apisix/core/ctx.lua
@@ -129,8 +129,6 @@ do
upstream_no_cache = true,
upstream_cache_key = true,
upstream_cache_bypass = true,
-upstream_hdr_expires = true,
-upstream_hdr_cache_control = true,
}
local mt = {
diff --git a/apisix/plugins/proxy-cache.lua b/apisix/plugins/proxy-cache.lua
index b3acbb0..78a2858 100644
--- a/apisix/plugins/proxy-cache.lua
+++ b/apisix/plugins/proxy-cache.lua
@@ -266,14 +266,21 @@ function _M.header_filter(conf, ctx)
end
end
+local upstream_hdr_cache_control
+local upstream_hdr_expires
+
if conf.hide_cache_headers == true then
-ctx.var.upstream_hdr_cache_control = ""
-ctx.var.upstream_hdr_expires = ""
+upstream_hdr_cache_control = ""
+upstream_hdr_expires = ""
else
-ctx.var.upstream_hdr_cache_control =
ctx.var.upstream_http_cache_control
-ctx.var.upstream_hdr_expires = ctx.var.upstream_http_expires
+upstream_hdr_cache_control = ctx.var.upstream_http_cache_control
+upstream_hdr_expires = ctx.var.upstream_http_expires
end
+core.response.set_header("Cache-Control", upstream_hdr_cache_control,
+ "Expires", upstream_hdr_expires,
+ "Apisix-Cache-Status",
ctx.var.upstream_cache_status)
+
ctx.var.upstream_no_cache = no_cache
core.log.info("proxy-cache no cache:", no_cache)
end
diff --git a/t/APISIX.pm b/t/APISIX.pm
index 1a51d1e..feb82d0 100644
--- a/t/APISIX.pm
+++ b/t/APISIX.pm
@@ -539,8 +539,6 @@ _EOC_
set \$upstream_cache_key '';
set \$upstream_cache_bypass '';
set \$upstream_no_cache '';
-set \$upstream_hdr_expires '';
-set \$upstream_hdr_cache_control '';
proxy_cache \$upstream_cache_zone;
proxy_cache_valid any 10s;
@@ -552,12 +550,6 @@ _EOC_
proxy_no_cache \$upstream_no_cache;
proxy_cache_bypass \$upstream_cache_bypass;
-proxy_hide_header Cache-Control;
-proxy_hide_header Expires;
-add_header Cache-Control \$upstream_hdr_cache_control;
-add_header Expires \$upstream_hdr_expires;
-add_header Apisix-Cache-Status \$upstream_cache_status always;
-
access_by_lua_block {
-- wait for etcd sync
ngx.sleep($wait_etcd_sync)
diff --git a/t/plugin/proxy-cache.t b/t/plugin/proxy-cache.t
index 5a1e244..c1d6dcd 100644
--- a/t/plugin/proxy-cache.t
[GitHub] [apisix] spacewander commented on pull request #3793: docs: updated the users wall of powered-by.md
spacewander commented on pull request #3793: URL: https://github.com/apache/apisix/pull/3793#issuecomment-794680171 Next time, please use "Fix #xxx" to refer to the issue in the commit message. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3793: docs: updated the users wall of powered-by.md
spacewander merged pull request #3793: URL: https://github.com/apache/apisix/pull/3793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3795: docs: update powered-by.md users wall image
spacewander closed issue #3795: URL: https://github.com/apache/apisix/issues/3795 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: updated the users wall of powered-by.md (#3793)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 3db716d docs: updated the users wall of powered-by.md (#3793) 3db716d is described below commit 3db716dd1bcb341d3d2c37f499f5657b03830341 Author: Ayush das AuthorDate: Wed Mar 10 06:28:13 2021 +0530 docs: updated the users wall of powered-by.md (#3793) Fix #3795 --- powered-by.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/powered-by.md b/powered-by.md index f3693fa..92aa124 100644 --- a/powered-by.md +++ b/powered-by.md @@ -71,8 +71,7 @@ Users are encouraged to add themselves to this page, [issue](https://github.com/ 1. https://www.zuzuche.com/"; rel="nofollow">zuzuche 租租车 1. https://www.zybang.com/"; rel="nofollow">zybang 作业帮 -https://raw.githubusercontent.com/iresty/iresty.com/master/user-wall.jpg"; width="900" height="500" /> - +https://user-images.githubusercontent.com/40708551/109484046-f7c4e280-7aa5-11eb-9d71-aab90830773a.png"; width="725" height="1700" /> ## User Cases ## NASA JPL
[GitHub] [apisix] juzhiyuan commented on pull request #3794: docs: fixed invalid URLs in translation docs
juzhiyuan commented on pull request #3794: URL: https://github.com/apache/apisix/pull/3794#issuecomment-794669065 > > LGTM, and there have some other cases like L72 > >  > > We could fix them in another PR :) > > but It is working properly in this state. do i still have to change it? Hi, you could have a try here: https://apisix.apache.org/zh/docs/apisix/discovery/#%E4%BB%A5-eureka-%E4%B8%BE%E4%BE%8B This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #3793: docs: updated the users wall of powered-by.md
iamayushdas commented on pull request #3793: URL: https://github.com/apache/apisix/pull/3793#issuecomment-794657240 #3795 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas opened a new issue #3795: docs: update powered-by.md users wall image
iamayushdas opened a new issue #3795: URL: https://github.com/apache/apisix/issues/3795 # Improve Docs ## powered-by.md needed to get the new users wall image. existing one is very old and outdated ## Describe the solution you'd like we could replace the url with new users wall image residing in README.md This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #3794: docs: fixed invalid URLs in translation docs
iamayushdas commented on pull request #3794: URL: https://github.com/apache/apisix/pull/3794#issuecomment-794650327 > LGTM, and there have some other cases like L72 > >  > > We could fix them in another PR :) but It is working properly in this state. do i still have to change it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan merged pull request #3790: feat: update contributor image
juzhiyuan merged pull request #3790: URL: https://github.com/apache/apisix/pull/3790 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (369c6d9 -> 01a0fff)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 369c6d9 refactor: remove unused etcd key node_status (#3786) add 01a0fff docs: update contibutor graph (#3790) No new revisions were added by this update. Summary of changes: docs/assets/images/contributor-over-time.png | Bin 199476 -> 47830 bytes 1 file changed, 0 insertions(+), 0 deletions(-)
[GitHub] [apisix] iamayushdas opened a new pull request #3794: docs: fixed invalid URLs in translation docs
iamayushdas opened a new pull request #3794: URL: https://github.com/apache/apisix/pull/3794 ### What this PR does / why we need it: Changing the URL. Fixed #3791 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1558: feat:Support duplicate one existing Route
codecov-io edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-791913462 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr&el=h1) Report > Merging [#1558](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr&el=desc) (958fa79) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b795db47d44f14ed7327fa30f0027ec266317b2?el=desc) (6b795db) will **decrease** coverage by `14.89%`. > The diff coverage is `57.89%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1558 +/- ## === - Coverage 70.90% 56.00% -14.90% === Files 135 49 -86 Lines5485 3173 -2312 Branches 5830 -583 === - Hits 3889 1777 -2112 + Misses 1348 1090 -258 - Partials 248 306 +58 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `56.00% <57.89%> (+0.31%)` | :arrow_up: | | backend-e2e-test-ginkgo | `39.86% <26.31%> (-0.18%)` | :arrow_down: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `62.50% <57.89%> (-15.75%)` | :arrow_down: | | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `57.44% <0.00%> (-34.05%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `38.46% <0.00%> (-30.77%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `60.24% <0.00%> (-27.72%)` | :arrow_down: | | ... and [104 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1558/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr&el=footer). Last update [6b795db...958fa79](https://codecov.io/gh/apache/apisix-dashboard/pull/1558?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Serv
[GitHub] [apisix] iamayushdas commented on issue #3791: invalid URLs in translation docs
iamayushdas commented on issue #3791: URL: https://github.com/apache/apisix/issues/3791#issuecomment-794617671 assign this to me @juzhiyuan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas opened a new pull request #3793: doc: updated the users wall of powered-by.md
iamayushdas opened a new pull request #3793: URL: https://github.com/apache/apisix/pull/3793 ### What this PR does / why we need it: updates the old users wall image by new. no ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1569: feat: supports changing number of executing cpu cores for manager api
bisakhmondal commented on a change in pull request #1569:
URL: https://github.com/apache/apisix-dashboard/pull/1569#discussion_r590556229
##
File path: api/internal/conf/conf.go
##
@@ -249,3 +254,16 @@ func initEtcdConfig(conf Etcd) {
Prefix:prefix,
}
}
+
+// initialize parallelism settings
+func initParallelism(choiceCores int) {
+ if choiceCores < 0 {
+ return
+ }
+ maxSupportedCores := runtime.NumCPU()
+
+ runtime.GOMAXPROCS(maxSupportedCores)
+ if choiceCores < maxSupportedCores {
+ runtime.GOMAXPROCS(choiceCores)
+ }
Review comment:
yeah, sure. Thanks for the review.
Edit 1: One thing, I missed putting that the changes for making the default
value of `GOMAXPROCS` from 1 to `NumCPU` have been made on go version 1.5
([thread](https://groups.google.com/g/golang-dev/c/POSw7qrelso/m/dI3YPTeGbkMJ)).
Though in 1.13, manual resetting is not required, still I was trying to be
extra sure. haha.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] fredster33 opened a new pull request #291: Grammar fix
fredster33 opened a new pull request #291: URL: https://github.com/apache/apisix-ingress-controller/pull/291 Please answer these questions before submitting a pull request - Why submit this pull request? - [X] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description This is a grammar fix to the README. - How to fix? N/A ___ ### New feature or improvement - Describe the details and related test reports. N/A ___ ### Backport patches - Why need to backport? N/A - Source branch patch-2 - Related commits and pull requests N/A - Target branch master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1569: feat: supports changing number of executing cpu cores for manager api
bisakhmondal commented on a change in pull request #1569:
URL: https://github.com/apache/apisix-dashboard/pull/1569#discussion_r590556229
##
File path: api/internal/conf/conf.go
##
@@ -249,3 +254,16 @@ func initEtcdConfig(conf Etcd) {
Prefix:prefix,
}
}
+
+// initialize parallelism settings
+func initParallelism(choiceCores int) {
+ if choiceCores < 0 {
+ return
+ }
+ maxSupportedCores := runtime.NumCPU()
+
+ runtime.GOMAXPROCS(maxSupportedCores)
+ if choiceCores < maxSupportedCores {
+ runtime.GOMAXPROCS(choiceCores)
+ }
Review comment:
yeah, sure. Thanks for the review.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1461: feat: Confirm whether the store related functions are still in use. If not, delete them
Jaycean commented on issue #1461: URL: https://github.com/apache/apisix-dashboard/issues/1461#issuecomment-794158337 I see pr: #1568 issue: #1567 Think of this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1565: The upstream timeout unit is seconds instead of milliseconds
juzhiyuan commented on issue #1565: URL: https://github.com/apache/apisix-dashboard/issues/1565#issuecomment-794097113 OK This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1565: The upstream timeout unit is seconds instead of milliseconds
nic-chen commented on issue #1565: URL: https://github.com/apache/apisix-dashboard/issues/1565#issuecomment-794093972 @juzhiyuan it's in seconds. see: https://github.com/apache/apisix/blob/master/apisix/balancer.lua#L108 https://github.com/apache/apisix/blob/master/apisix/balancer.lua#L23 https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/balancer.md#set_timeouts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1569: feat: supports changing number of executing cpu cores for manager api
starsz commented on a change in pull request #1569:
URL: https://github.com/apache/apisix-dashboard/pull/1569#discussion_r590496205
##
File path: api/internal/conf/conf.go
##
@@ -249,3 +254,16 @@ func initEtcdConfig(conf Etcd) {
Prefix:prefix,
}
}
+
+// initialize parallelism settings
+func initParallelism(choiceCores int) {
+ if choiceCores < 0 {
+ return
+ }
+ maxSupportedCores := runtime.NumCPU()
+
+ runtime.GOMAXPROCS(maxSupportedCores)
+ if choiceCores < maxSupportedCores {
+ runtime.GOMAXPROCS(choiceCores)
+ }
Review comment:
> GOMAXPROCS sets the maximum number of CPUs that can be executing
simultaneously and returns the previous setting. It defaults to the value of
runtime.NumCPU. If n < 1, it does not change the current setting. This call
will go away when the scheduler improves.
As the doc said, I think this will be more clear.
```golang
maxSupportedCores := runtime.NumCPU()
if choiceCores > maxSupportedCores {
choiceCores = maxSupportedCores
}
runtime.GOMAXPROCS(choiceCores)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1569: feat: supports changing number of executing cpu cores for manager api
bisakhmondal opened a new pull request #1569: URL: https://github.com/apache/apisix-dashboard/pull/1569 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues resolves #682 ___ ### New feature or improvement Supports changing the number of os threads attached to the goroutines. For performance reason, if in the configuration file, the defined `max_cpu` is greater than the number of available cpu cores (including hyperthreading), the `manager api` will stick to the max available cores. As it has a certain limit to boost the performance since the context switching of goroutines from the same os thread is a lot faster than goroutines from different threads. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz opened a new pull request #1568: improve: delete unused file
starsz opened a new pull request #1568: URL: https://github.com/apache/apisix-dashboard/pull/1568 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [x] Improve performance - [ ] Backport patches - Related issues fix #1567 ___ ### New feature or improvement - Describe the details and related test reports. Delete the unused file in internal/core/store. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: disable closing plugin drawer on clicking the mask (#1564)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new c8b235b feat: disable closing plugin drawer on clicking the mask
(#1564)
c8b235b is described below
commit c8b235bb4a60c2d91840a4385649998bd1e9a841
Author: Bisakh Mondal
AuthorDate: Tue Mar 9 20:25:54 2021 +0530
feat: disable closing plugin drawer on clicking the mask (#1564)
Co-authored-by: 琚致远
Co-authored-by: 琚致远
---
web/src/components/Plugin/PluginDetail.tsx | 3 +++
web/src/components/Plugin/PluginPage.tsx | 1 +
web/src/pages/Plugin/List.tsx | 1 +
3 files changed, 5 insertions(+)
diff --git a/web/src/components/Plugin/PluginDetail.tsx
b/web/src/components/Plugin/PluginDetail.tsx
index 476d74f..23685e8 100644
--- a/web/src/components/Plugin/PluginDetail.tsx
+++ b/web/src/components/Plugin/PluginDetail.tsx
@@ -46,6 +46,7 @@ type Props = {
pluginList: PluginComponent.Meta[];
readonly?: boolean;
visible: boolean;
+ maskClosable?: boolean;
onClose?: () => void;
onChange?: (data: any) => void;
};
@@ -83,6 +84,7 @@ const PluginDetail: React.FC = ({
visible,
pluginList = [],
readonly = false,
+ maskClosable = true,
initialData = {},
onClose = () => {},
onChange = () => {},
@@ -168,6 +170,7 @@ const PluginDetail: React.FC = ({
visible={visible}
placement="right"
closable={false}
+maskClosable={maskClosable}
onClose={onClose}
width={700}
footer={
diff --git a/web/src/components/Plugin/PluginPage.tsx
b/web/src/components/Plugin/PluginPage.tsx
index 03d2fec..e03aa82 100644
--- a/web/src/components/Plugin/PluginPage.tsx
+++ b/web/src/components/Plugin/PluginPage.tsx
@@ -241,6 +241,7 @@ const PluginPage: React.FC = ({
visible={name !== NEVER_EXIST_PLUGIN_FLAG}
schemaType={schemaType}
initialData={initialData}
+ maskClosable={false}
pluginList={pluginList}
onClose={() => {
setName(NEVER_EXIST_PLUGIN_FLAG);
diff --git a/web/src/pages/Plugin/List.tsx b/web/src/pages/Plugin/List.tsx
index 0723855..31e4fc0 100644
--- a/web/src/pages/Plugin/List.tsx
+++ b/web/src/pages/Plugin/List.tsx
@@ -110,6 +110,7 @@ const Page: React.FC = () => {
schemaType="route"
initialData={initialData}
pluginList={pluginList}
+ maskClosable={false}
onClose={() => {
setVisible(false);
}}
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1564: feat: disable closing plugin drawer on clicking the mask
juzhiyuan merged pull request #1564: URL: https://github.com/apache/apisix-dashboard/pull/1564 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1548: Clicking on a mask while editing a plugin does not allow the drawer to be closed
juzhiyuan closed issue #1548: URL: https://github.com/apache/apisix-dashboard/issues/1548 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou opened a new issue #3792: discuss: the "active.host" in the active health check should be optional
Firstsawyou opened a new issue #3792:
URL: https://github.com/apache/apisix/issues/3792
### Issue description
Related issues: https://github.com/apache/apisix-dashboard/issues/1563
In the active health check, Host is the host name of the HTTP request used
to discover the health of the upstream node. It is required only when the
upstream node has restrictions on Host, otherwise it is optional. I think it
would be better if `active.host` should be an optional.
In the current active check configuration, I tested that `active.host` is an
option (I'm not sure if my test is correct), but the documentation doesn't
explain that. Maybe we need to state in the documentation that `active.host` is
an option.
https://user-images.githubusercontent.com/52862365/110487564-aa411900-8128-11eb-96eb-293710133356.png";>
`active.host` is missing：
```shell
$ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri":"/index.html",
"upstream":{
"nodes":{
"127.0.0.1:1980":1,
"127.0.0.1:1970":1
},
"type":"roundrobin",
"retries":2,
"checks":{
"active":{
"timeout":5,
"http_path":"/status",
"healthy":{
"interval":2,
"successes":1
},
"unhealthy":{
"interval":1,
"http_failures":2
}
},
"passive":{
"healthy":{
"http_statuses":[
200,
201
],
"successes":3
},
"unhealthy":{
"http_statuses":[
500
],
"http_failures":3,
"tcp_failures":3
}
}
}
}
}'
{"node":{"key":"\/apisix\/routes\/1","value":{"uri":"\/index.html","status":1,"id":"1","upstream":{"nodes":{"127.0.0.1:1980":1,"127.0.0.1:1970":1},"pass_host":"pass","checks":{"active":{"unhealthy":{"http_statuses":[429,404,500,501,502,503,504,505],"http_failures":2,"tcp_failures":2,"interval":1,"timeouts":3},"http_path":"\/status","https_verify_certificate":true,"healthy":{"http_statuses":[200,302],"interval":2,"successes":1},"type":"http","concurrency":10,"timeout":5},"passive":{"unhealthy":{"http_failures":3,"tcp_failures":3,"http_statuses":[500],"timeouts":7},"type":"http","healthy":{"http_statuses":[200,201],"successes":3}}},"scheme":"http","type":"roundrobin","hash_on":"vars","retries":2},"update_time":1615300539,"priority":0,"create_time":1613722689}},"action":"set"}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] juzhiyuan opened a new issue #3791: invalid URLs in translation docs
juzhiyuan opened a new issue #3791:
URL: https://github.com/apache/apisix/issues/3791
# Improve Docs
## Please describe which part of docs should be improved or typo fixed
Hi, we have contributors who noticed that there have some broken links in
translated docs:
e.g.: https://apisix.apache.org/zh/docs/apisix/discovery/
and this doc is targeted to
https://github.com/apache/apisix/edit/master/docs/zh/latest/discovery.md
## Describe the solution you'd like
Those broken links are due to our doc site doesn't support relative
reference yet, for example:
In this file, there have 2 links which are targeted the outside files. Here
is the solution to fix this issue:
For those referenced links, please use
`https://github.com/apache/apisix/blob/master/docs/en/latest/{FILE_PATH}`
instead, e.g:
`https://github.com/apache/apisix/blob/master/docs/en/latest/discovery/dns.md`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] juzhiyuan commented on issue #289: Support Traffic Split in ApisixRoute
juzhiyuan commented on issue #289: URL: https://github.com/apache/apisix-ingress-controller/issues/289#issuecomment-793972457 Not familiar with this temporarily, just one point: how about using `serviceWithWeight` instead of `weightedBackends`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou closed pull request #3645: docs: update install-dependencies.md doc
Firstsawyou closed pull request #3645: URL: https://github.com/apache/apisix/pull/3645 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #3645: docs: update install-dependencies.md doc
Firstsawyou commented on pull request #3645: URL: https://github.com/apache/apisix/pull/3645#issuecomment-793879331 It has been fixed by https://github.com/apache/apisix/pull/3718. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
