[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1574: chore: add plugin test
starsz commented on a change in pull request #1574: URL: https://github.com/apache/apisix-dashboard/pull/1574#discussion_r592133420 ## File path: api/test/e2enew/plugin/plugin_test.go ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package ssl + +import ( + "e2enew/base" + "github.com/onsi/ginkgo" + "github.com/onsi/ginkgo/extensions/table" + "net/http" Review comment: Go it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1574: chore: add plugin test
starsz commented on a change in pull request #1574:
URL: https://github.com/apache/apisix-dashboard/pull/1574#discussion_r592133355
##
File path: api/test/e2enew/plugin/plugin_suite_test.go
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package ssl
+
+import (
+ "github.com/onsi/ginkgo"
+ "testing"
+)
+
+func TestRoute(t *testing.T) {
Review comment:
Oh no.My fault.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus opened a new pull request #40: feat: upgrade dependency
Junnplus opened a new pull request #40: URL: https://github.com/apache/apisix-helm-chart/pull/40 - apisix-ingress-controller upgrade to 0.3.0 / helm chart 0.2.0 - apisix upgrade to 2.3.0 / helm chart 0.2.0 @tokers This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1571: chore: improve ssl e2e test coverage
Jaycean commented on a change in pull request #1571:
URL: https://github.com/apache/apisix-dashboard/pull/1571#discussion_r592113035
##
File path: api/test/e2enew/ssl/ssl_suite_test.go
##
@@ -25,12 +25,11 @@ import (
"e2enew/base"
)
-func TestRoute(t *testing.T) {
+func TestSSL(t *testing.T) {
ginkgo.RunSpecs(t, "ssl suite")
}
var _ = ginkgo.AfterSuite(func() {
base.CleanResource("ssl")
- base.CleanResource("routes")
Review comment:
@starsz @nic-chen
I have a question here. If we create a route in the test case and delete the
route, and verify that the route is indeed deleted, do we still need to execute
AfterSuite(base.CleanResource("resource") to ensure the deletion of resources?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
codecov-io edited a comment on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795454945 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=h1) Report > Merging [#1570](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=desc) (f2221d5) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/d5babce089da475240abfc21abe7c815cc31bc27?el=desc) (d5babce) will **increase** coverage by `1.85%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1570 +/- ## == + Coverage 71.35% 73.21% +1.85% == Files 132 86 -46 Lines5341 2322-3019 Branches 584 584 == - Hits 3811 1700-2111 + Misses 1282 622 -660 + Partials 2480 -248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.21% <ø> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `75.38% <0.00%> (-1.54%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | | | [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | | | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | | | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | | | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | | | | ... and [37 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=footer). Last update [d5babce...f2221d5](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1571: chore: improve ssl e2e test coverage
Jaycean commented on a change in pull request #1571:
URL: https://github.com/apache/apisix-dashboard/pull/1571#discussion_r592113035
##
File path: api/test/e2enew/ssl/ssl_suite_test.go
##
@@ -25,12 +25,11 @@ import (
"e2enew/base"
)
-func TestRoute(t *testing.T) {
+func TestSSL(t *testing.T) {
ginkgo.RunSpecs(t, "ssl suite")
}
var _ = ginkgo.AfterSuite(func() {
base.CleanResource("ssl")
- base.CleanResource("routes")
Review comment:
@starsz @nic-chen
I have a question here. If we create a route in the test case and delete the
route, and verify that the route is indeed deleted, do we still need to
executeAfterSuite(base.CleanResource("resource") to ensure the deletion of
resources?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] Jaycean opened a new pull request #254: chore: Add new committer jinchen in committer list
Jaycean opened a new pull request #254: URL: https://github.com/apache/apisix-website/pull/254 Signed-off-by: Jaycean jinc...@apache.org Changes: Add the new committer jinchen into committer list in team.json. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1538: fix: Incomplete i18n coverage
nic-chen commented on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-796508562 After I synchronized the master code, it did not appear again. I feel that it was affected by the github CI mechanism. The backend cli test has not been updated for a while. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] manzusaka opened a new issue #3806: need to a new feature
manzusaka opened a new issue #3806: URL: https://github.com/apache/apisix/issues/3806 When Apisix is run as a cluster, control plane need to defines some Apisix metadata besed on business requirements,Can Apisix support this feature? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3766: docs: add --server option for the use of luarocks
spacewander commented on a change in pull request #3766: URL: https://github.com/apache/apisix/pull/3766#discussion_r592105318 ## File path: docs/en/latest/FAQ.md ## @@ -71,6 +71,10 @@ There are two possibilities when encountering slow luarocks: For the first problem, you can use https_proxy or use the `--server` option to specify a luarocks server that you can access or access faster. Run the `luarocks config rocks_servers` command(this command is supported after luarocks 3.0) to see which server are available. +```shell +luarocks install apisix --server https://luarocks.cn Review comment: @stu01509 Hi, will you continue on this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
Jaycean commented on issue #1500: URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-796502504 > Hi @Jaycean, would you mind if I rewrite the `route import test` in the e2enew test suite :) Thank you very much. It has been allocated in to do list. You can @ me if you have any questions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3805: docs: update the admin-api.md document
Firstsawyou commented on a change in pull request #3805: URL: https://github.com/apache/apisix/pull/3805#discussion_r592101753 ## File path: docs/en/latest/admin-api.md ## @@ -547,11 +547,11 @@ In addition to the basic complex equalization algorithm selection, APISIX's Upst `hash_on` can be set to different types: 1. when it is `vars`, the `key` is required. The `key` can be any [Nginx builtin variables](http://nginx.org/en/docs/varindex.html), without the prefix '$'. -1. when it is `header`, the `key` is required. It is equal to "http_`key`". Review comment: updated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #2093: bug: kubenetes ingress install error
spacewander commented on issue #2093: URL: https://github.com/apache/apisix/issues/2093#issuecomment-796501262 Closed as lack of response. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #2093: bug: kubenetes ingress install error
spacewander closed issue #2093: URL: https://github.com/apache/apisix/issues/2093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1500: Feat: Rewrite all E2E tests using the Ginkgo
bisakhmondal commented on issue #1500: URL: https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-796499085 Hi @Jaycean, would you mind if I rewrite the `route import test` in the e2enew test suite :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
spacewander commented on a change in pull request #3758:
URL: https://github.com/apache/apisix/pull/3758#discussion_r592092002
##
File path: apisix/plugins/traffic-split.lua
##
@@ -309,7 +314,8 @@ function _M.access(conf, ctx)
return
end
-local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj,
weighted_upstreams)
+local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj,
weighted_upstreams,
Review comment:
Try?
```diff
diff --git apisix/plugins/traffic-split.lua apisix/plugins/traffic-split.lua
index eb7a2028..966275f9 100644
--- apisix/plugins/traffic-split.lua
+++ apisix/plugins/traffic-split.lua
@@ -315,8 +315,8 @@ function _M.access(conf, ctx)
end
local route_upstream_id = ctx.matched_route.value.upstream_id
-local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj,
weighted_upstreams,
-route_upstream_id)
+local rr_up, err = core.lrucache.plugin_ctx(lrucache, ctx, nil,
new_rr_obj, weighted_upstreams,
+route_upstream_id)
if not rr_up then
core.log.error("lrucache roundrobin failed: ", err)
return 500
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] MrLibra commented on issue #3803: request help:
MrLibra commented on issue #3803: URL: https://github.com/apache/apisix/issues/3803#issuecomment-796488902 Installing https://luarocks.org/luaxxhash-1.0.0-1.rockspec Error: Failed installing dependency: https://luarocks.org/lua-resty-dns-client-5.2.0-1.src.rock - Failed installing dependency: https://luarocks.org/luaxxhash-1.0.0-1.rockspec - Unknown protocol git make: *** [deps] 错误 1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3805: docs: update the admin-api.md document
spacewander commented on a change in pull request #3805: URL: https://github.com/apache/apisix/pull/3805#discussion_r592089091 ## File path: docs/en/latest/admin-api.md ## @@ -547,11 +547,11 @@ In addition to the basic complex equalization algorithm selection, APISIX's Upst `hash_on` can be set to different types: 1. when it is `vars`, the `key` is required. The `key` can be any [Nginx builtin variables](http://nginx.org/en/docs/varindex.html), without the prefix '$'. -1. when it is `header`, the `key` is required. It is equal to "http_`key`". Review comment: We don't need to change this. Markdown will handle the order automatically. There is no need to maintain the order by us. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
codecov-io edited a comment on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795454945 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=h1) Report > Merging [#1570](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=desc) (078fcfb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/d5babce089da475240abfc21abe7c815cc31bc27?el=desc) (d5babce) will **increase** coverage by `1.94%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1570 +/- ## == + Coverage 71.35% 73.29% +1.94% == Files 132 86 -46 Lines5341 2322-3019 Branches 584 584 == - Hits 3811 1702-2109 + Misses 1282 620 -662 + Partials 2480 -248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.29% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | | | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | ... and [36 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=footer). Last update [d5babce...078fcfb](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou opened a new pull request #3805: docs: update the admin-api.md document
Firstsawyou opened a new pull request #3805: URL: https://github.com/apache/apisix/pull/3805 ### What this PR does / why we need it: close #3802 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage
codecov-io edited a comment on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage
codecov-io edited a comment on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) Report > Merging [#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) (81d7bb4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6dce9e09640b1c81f14dbb88e5f6f8c43371af31?el=desc) (6dce9e0) will **decrease** coverage by `19.32%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1538 +/- ## === - Coverage 70.82% 51.50% -19.33% === Files 135 37 -98 Lines5485 2555 -2930 Branches 5830 -583 === - Hits 3885 1316 -2569 + Misses 1352 1058 -294 + Partials 248 181 -67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.50% <ø> (-0.18%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [118 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer). Last update [6dce9e0...81d7bb4](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
nic-chen commented on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-796450463 wait for CI This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
tzssangglass commented on a change in pull request #3758: URL: https://github.com/apache/apisix/pull/3758#discussion_r592063112 ## File path: apisix/plugins/traffic-split.lua ## @@ -309,7 +314,8 @@ function _M.access(conf, ctx) return end -local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams) +local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams, Review comment: I tried it and it still doesn't work, because this plugin still need to control the weight by modifying the `upstream_id` in the route, even if `core.lrucache.plugin_ctx` is used, since `route_upstream_id` is in the key and `route_upstream_id` will be overwritten by the `plugin_upstream_id`, it will result in two keys and inaccurate data obtained. use `weighted_upstreams` as key because `weighted_upstreams` do not change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage
codecov-io edited a comment on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) Report > Merging [#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) (45e8b49) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6dce9e09640b1c81f14dbb88e5f6f8c43371af31?el=desc) (6dce9e0) will **decrease** coverage by `11.96%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1538 +/- ## === - Coverage 70.82% 58.86% -11.97% === Files 135 46 -89 Lines5485 3019 -2466 Branches 5830 -583 === - Hits 3885 1777 -2108 + Misses 1352 938 -414 - Partials 248 304 +56 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `58.86% <ø> (+3.29%)` | :arrow_up: | | backend-e2e-test-ginkgo | `42.39% <ø> (+2.60%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `57.44% <0.00%> (-34.05%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `39.26% <0.00%> (-29.97%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `60.24% <0.00%> (-26.51%)` | :arrow_down: | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: | | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | `56.38% <0.00%> (-21.28%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `64.51% <0.00%> (-19.36%)` | :arrow_down: | | ... and [106 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer). Last update [6dce9e0...45e8b49](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage
codecov-io edited a comment on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) Report > Merging [#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) (45e8b49) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6dce9e09640b1c81f14dbb88e5f6f8c43371af31?el=desc) (6dce9e0) will **decrease** coverage by `28.43%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1538 +/- ## === - Coverage 70.82% 42.39% -28.44% === Files 135 46 -89 Lines5485 3019 -2466 Branches 5830 -583 === - Hits 3885 1280 -2605 - Misses 1352 1469 +117 - Partials 248 270 +22 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `42.39% <ø> (+2.60%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `33.47% <0.00%> (-44.77%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `30.55% <0.00%> (-41.67%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `52.12% <0.00%> (-39.37%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | ... and [108 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer). Last update [6dce9e0...45e8b49](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1574: chore: add plugin test
nic-chen commented on a change in pull request #1574: URL: https://github.com/apache/apisix-dashboard/pull/1574#discussion_r592054024 ## File path: api/test/e2enew/plugin/plugin_test.go ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package ssl + +import ( + "e2enew/base" + "github.com/onsi/ginkgo" + "github.com/onsi/ginkgo/extensions/table" + "net/http" Review comment: style This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1574: chore: add plugin test
nic-chen commented on a change in pull request #1574:
URL: https://github.com/apache/apisix-dashboard/pull/1574#discussion_r592053949
##
File path: api/test/e2enew/plugin/plugin_suite_test.go
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package ssl
+
+import (
+ "github.com/onsi/ginkgo"
+ "testing"
+)
+
+func TestRoute(t *testing.T) {
Review comment:
need to update the function name
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3804: request help: How to log upstream.name in access log?
spacewander commented on issue #3804: URL: https://github.com/apache/apisix/issues/3804#issuecomment-796425693 You can add an Nginx variable and write a plugin to assign the value to it in the log phase. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3801: request help: support kubernetes as service discovery
spacewander commented on issue #3801: URL: https://github.com/apache/apisix/issues/3801#issuecomment-796424197 Maybe you can export them via DNS: https://github.com/apache/apisix/blob/master/docs/en/latest/discovery/dns.md https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yangxikun opened a new issue #3804: request help: How to log upstream.name in access log?
yangxikun opened a new issue #3804: URL: https://github.com/apache/apisix/issues/3804 ### Issue description How to log https://github.com/apache/apisix/blob/master/docs/zh/latest/admin-api.md#upstream name in access log? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Junnplus edited a comment on issue #3801: request help: support kubernetes as service discovery
Junnplus edited a comment on issue #3801: URL: https://github.com/apache/apisix/issues/3801#issuecomment-796418800 I know Ingress Controller of APISIX, but it depends on the realization of crds, I want to synchronize services in the specified namespaces, but in ingress controller, need to create an ApisixUpstream for each service. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Junnplus commented on issue #3801: request help: support kubernetes as service discovery
Junnplus commented on issue #3801: URL: https://github.com/apache/apisix/issues/3801#issuecomment-796418800 I know Ingress Controller of APISIX, but it depends on the realization of crds, I want to synchronize services in the specified namespaces, but need to create an ApisixUpstream for each service in ingress controller. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus commented on issue #13: I want apisix-helm-chart to add a mechanism to clean up pvc in the uninstall process
Junnplus commented on issue #13: URL: https://github.com/apache/apisix-helm-chart/issues/13#issuecomment-796413371 pvc is managed by `volumeClaimTemplates`, have a lifetime independent of pods. (This is intentional behavior in k8s.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] MrLibra opened a new issue #3803: request help:
MrLibra opened a new issue #3803: URL: https://github.com/apache/apisix/issues/3803 ### Issue description [root@geek_apisix_dev_bjh01 apisix]# make deps luarocks install rockspec/apisix-master-0.rockspec --tree=deps --only-deps --local Using rockspec/apisix-master-0.rockspec... switching to 'build' mode Stopping after installing dependencies for apisix master-0 [root@geek_apisix_dev_bjh01 apisix]# ./bin/apisix version 2.2 [root@geek_apisix_dev_bjh01 apisix]# ./bin/apisix start lua: /workspace/apisix/deps/share/lua/5.1/tinyyaml.lua:728: parse error: apisix: stack traceback: [C]: in function 'error' /workspace/apisix/deps/share/lua/5.1/tinyyaml.lua:728: in function 'parsedocuments' /workspace/apisix/deps/share/lua/5.1/tinyyaml.lua:760: in function 'parse' ./apisix/cli/file.lua:196: in function 'read_yaml_conf' ./apisix/cli/ops.lua:133: in function 'init' ./apisix/cli/ops.lua:393: in function '?' ./apisix/cli/ops.lua:455: in function 'execute' ./bin/apisix:36: in main chunk [C]: ? ### Environment * apisix version (cmd: `apisix version`):2.2 * OS (cmd: `uname -a`):centos7.4 * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):3.4 * apisix-dashboard version, if have: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus commented on issue #8: BUG：install fail ‘pod has unbound immediate PersistentVolumeClaims’ on Qcloud/TencentCloud TKE
Junnplus commented on issue #8: URL: https://github.com/apache/apisix-helm-chart/issues/8#issuecomment-796406271 You need to specify `etcd.persistence.storageClass` to automatically create pvc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus commented on issue #11: PVC problems in etcd deployment
Junnplus commented on issue #11: URL: https://github.com/apache/apisix-helm-chart/issues/11#issuecomment-796404168 Duplicate with https://github.com/apache/apisix-helm-chart/issues/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus commented on issue #15: One-click deployment of helm-chart cannot be linked with apisix-ingress-controller fast
Junnplus commented on issue #15: URL: https://github.com/apache/apisix-helm-chart/issues/15#issuecomment-796403157 Supported by https://github.com/apache/apisix-helm-chart/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus commented on issue #12: How to set the PVC storage of etcd when deploying apisix-helm-chart?
Junnplus commented on issue #12: URL: https://github.com/apache/apisix-helm-chart/issues/12#issuecomment-796401598 You can set values `etcd.persistence.size=100G` and `etcd.persistence.enabled=true` when creating apisix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated: fix: dashboard ingress apiVersion newline bug and add apisix gateway ingress suppurt (#32)
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git
The following commit(s) were added to refs/heads/master by this push:
new 682853e fix: dashboard ingress apiVersion newline bug and add apisix
gateway ingress suppurt (#32)
682853e is described below
commit 682853ed8f9628a9e96c78945f8891898e435c2b
Author: Shaddock
AuthorDate: Thu Mar 11 10:56:30 2021 +0800
fix: dashboard ingress apiVersion newline bug and add apisix gateway
ingress suppurt (#32)
Co-authored-by: shaddock
---
.gitignore | 3 ++-
charts/apisix-dashboard/Chart.yaml | 2 +-
charts/apisix-dashboard/templates/ingress.yaml | 2 +-
.../templates/ingress.yaml | 20 ++--
4 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/.gitignore b/.gitignore
index 946867d..9eebac1 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,4 @@
.DS_Store
*.tgz
-*.lock
\ No newline at end of file
+*.lock
+test_**.yaml
\ No newline at end of file
diff --git a/charts/apisix-dashboard/Chart.yaml
b/charts/apisix-dashboard/Chart.yaml
index aab2eab..541baf7 100644
--- a/charts/apisix-dashboard/Chart.yaml
+++ b/charts/apisix-dashboard/Chart.yaml
@@ -31,7 +31,7 @@ type: application
# This is the chart version. This version number should be incremented each
time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.0
+version: 0.1.1
# This is the version number of the application being deployed. This version
number should be
# incremented each time you make changes to the application. Versions are not
expected to
diff --git a/charts/apisix-dashboard/templates/ingress.yaml
b/charts/apisix-dashboard/templates/ingress.yaml
index 8f43e91..0058d94 100644
--- a/charts/apisix-dashboard/templates/ingress.yaml
+++ b/charts/apisix-dashboard/templates/ingress.yaml
@@ -17,7 +17,7 @@
{{- if .Values.ingress.enabled -}}
{{- $fullName := include "apisix-dashboard.fullname" . -}}
{{- $svcPort := .Values.service.port -}}
-{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
+{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion }}
apiVersion: networking.k8s.io/v1beta1
{{- else -}}
apiVersion: extensions/v1beta1
diff --git a/charts/apisix-dashboard/templates/ingress.yaml
b/charts/apisix/templates/ingress.yaml
similarity index 77%
copy from charts/apisix-dashboard/templates/ingress.yaml
copy to charts/apisix/templates/ingress.yaml
index 8f43e91..960331f 100644
--- a/charts/apisix-dashboard/templates/ingress.yaml
+++ b/charts/apisix/templates/ingress.yaml
@@ -14,10 +14,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-{{- if .Values.ingress.enabled -}}
-{{- $fullName := include "apisix-dashboard.fullname" . -}}
-{{- $svcPort := .Values.service.port -}}
-{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
+{{- if .Values.gateway.ingress.enabled -}}
+{{- $fullName := include "apisix.fullname" . -}}
+{{- $svcPort := .Values.gateway.http.servicePort -}}
+{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion }}
apiVersion: networking.k8s.io/v1beta1
{{- else -}}
apiVersion: extensions/v1beta1
@@ -26,15 +26,15 @@ kind: Ingress
metadata:
name: {{ $fullName }}
labels:
-{{- include "apisix-dashboard.labels" . | nindent 4 }}
- {{- with .Values.ingress.annotations }}
+{{- include "apisix.labels" . | nindent 4 }}
+ {{- with .Values.gateway.ingress.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
- {{- if .Values.ingress.tls }}
+ {{- if .Values.gateway.ingress.tls }}
tls:
-{{- range .Values.ingress.tls }}
+{{- range .Values.gateway.ingress.tls }}
- hosts:
{{- range .hosts }}
- {{ . | quote }}
@@ -43,14 +43,14 @@ spec:
{{- end }}
{{- end }}
rules:
-{{- range .Values.ingress.hosts }}
+{{- range .Values.gateway.ingress.hosts }}
- host: {{ .host | quote }}
http:
paths:
{{- range .paths }}
- path: {{ . }}
backend:
- serviceName: {{ $fullName }}
+ serviceName: {{ $fullName }}-gateway
servicePort: {{ $svcPort }}
{{- end }}
{{- end }}
[GitHub] [apisix-helm-chart] gxthrj merged pull request #32: fix: dashboard ingress and apisix gateway ingress
gxthrj merged pull request #32: URL: https://github.com/apache/apisix-helm-chart/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated: feat: add dashboard and ingress-controller as component of apisix (#39)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 1eea8b7 feat: add dashboard and ingress-controller as component of apisix (#39) 1eea8b7 is described below commit 1eea8b7c12c623e8af2db950b9b3782a0923ca6f Author: Jun AuthorDate: Thu Mar 11 10:54:36 2021 +0800 feat: add dashboard and ingress-controller as component of apisix (#39) --- charts/apisix/Chart.yaml | 10 ++ charts/apisix/values.yaml | 6 ++ 2 files changed, 16 insertions(+) diff --git a/charts/apisix/Chart.yaml b/charts/apisix/Chart.yaml index 5c0ed23..25cd735 100644 --- a/charts/apisix/Chart.yaml +++ b/charts/apisix/Chart.yaml @@ -43,3 +43,13 @@ dependencies: version: 5.2.1 repository: https://charts.bitnami.com/bitnami condition: etcd.enabled + - name: apisix-dashboard +version: 0.1.0 +repository: file://../apisix-dashboard +condition: dashboard.enabled +alias: dashboard + - name: apisix-ingress-controller +version: 0.1.0 +repository: file://../apisix-ingress-controller +condition: ingressController.enabled +alias: ingress-controller diff --git a/charts/apisix/values.yaml b/charts/apisix/values.yaml index d806a5b..37e1973 100644 --- a/charts/apisix/values.yaml +++ b/charts/apisix/values.yaml @@ -115,6 +115,12 @@ admin: admin: edd1c9f034335f136f87ad84b625c8f1 viewer: 4054f7cf07e344346cd3f287985e76a2 +dashboard: + enabled: false + +ingressController: + enabled: false + allow: # The ip range for allowing access to Apache APISIX ipList:
[GitHub] [apisix-helm-chart] gxthrj merged pull request #39: feat: add dashboard and ingress-controller as component of apisix
gxthrj merged pull request #39: URL: https://github.com/apache/apisix-helm-chart/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1572: chore: add health e2e test
starsz commented on a change in pull request #1572:
URL: https://github.com/apache/apisix-dashboard/pull/1572#discussion_r592023437
##
File path: api/test/e2enew/healthz/healthz_suite_test.go
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package healthz
+
+import (
+ "testing"
+
+ "github.com/onsi/ginkgo"
+)
+
+func TestRoute(t *testing.T) {
Review comment:
Sorry, my mistake.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1571: chore: improve ssl e2e test coverage
starsz commented on a change in pull request #1571:
URL: https://github.com/apache/apisix-dashboard/pull/1571#discussion_r592023103
##
File path: api/test/e2enew/ssl/ssl_test.go
##
@@ -26,38 +26,80 @@ import (
"time"
"github.com/onsi/ginkgo"
+ "github.com/onsi/ginkgo/extensions/table"
"github.com/stretchr/testify/assert"
"e2enew/base"
)
var _ = ginkgo.Describe("SSL Basic", func() {
- ginkgo.It("test ssl basic", func() {
- // build test body
- t := ginkgo.GinkgoT()
- testCert, err := ioutil.ReadFile("../../certs/test2.crt")
- assert.Nil(t, err)
- testKey, err := ioutil.ReadFile("../../certs/test2.key")
- assert.Nil(t, err)
- apisixKey, err := ioutil.ReadFile("../../certs/apisix.key")
- assert.Nil(t, err)
- body, err := json.Marshal(map[string]interface{}{
- "id": "1",
- "cert": string(testCert),
- "key": string(testKey),
- "labels": map[string]string{
- "build": "16",
- "env": "production",
- "version": "v3",
+ t := ginkgo.GinkgoT()
+ var (
Review comment:
Yes. I had used `ginkgo.BeforeEach()` before, but we use those variables
as the parameter later.So the `BeforeEach` can't modify those variables.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
codecov-io edited a comment on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795454945 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=h1) Report > Merging [#1570](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=desc) (0a710f8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c8b235bb4a60c2d91840a4385649998bd1e9a841?el=desc) (c8b235b) will **increase** coverage by `4.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1570 +/- ## == + Coverage 69.15% 73.21% +4.05% == Files 49 86 +37 Lines3164 2322 -842 Branches0 584 +584 == - Hits 2188 1700 -488 + Misses728 622 -106 + Partials 2480 -248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.21% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | | | | [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | | | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | | | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | | | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | | | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | | | | ... and [125 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=footer). Last update [c8b235b...0a710f8](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module
juzhiyuan commented on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-796368917 cc @guoqqqi to take a review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module
juzhiyuan commented on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-796368769 Wow! A big step! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj merged pull request #38: chore: remove invalid values
gxthrj merged pull request #38: URL: https://github.com/apache/apisix-helm-chart/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated: remove invalid values (#38)
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git
The following commit(s) were added to refs/heads/master by this push:
new 233f12c remove invalid values (#38)
233f12c is described below
commit 233f12c6a6ace9ff701fe7b544bd73178896e180
Author: Jun
AuthorDate: Thu Mar 11 09:57:47 2021 +0800
remove invalid values (#38)
---
charts/apisix/Chart.yaml| 2 +-
charts/apisix/templates/configmap.yaml | 2 +-
charts/apisix/templates/deployment.yaml | 2 +-
charts/apisix/values.yaml | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/charts/apisix/Chart.yaml b/charts/apisix/Chart.yaml
index 5d3c785..5c0ed23 100644
--- a/charts/apisix/Chart.yaml
+++ b/charts/apisix/Chart.yaml
@@ -31,7 +31,7 @@ type: application
# This is the chart version. This version number should be incremented each
time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.2
+version: 0.1.3
# This is the version number of the application being deployed. This version
number should be
# incremented each time you make changes to the application. Versions are not
expected to
diff --git a/charts/apisix/templates/configmap.yaml
b/charts/apisix/templates/configmap.yaml
index 31d0d3a..2b7820e 100644
--- a/charts/apisix/templates/configmap.yaml
+++ b/charts/apisix/templates/configmap.yaml
@@ -146,7 +146,7 @@ data:
etcd:
{{- if .Values.etcd.enabled }}
host: # it's possible to define multiple
etcd hosts addresses of the same etcd cluster.
-- "http://{{ .Release.Name }}-etcd.{{ .Release.Namespace }}.svc.{{
.Values.gateway.k8s_domain }}:{{ .Values.etcd.defaultPort }}"
+- "http://{{ .Release.Name }}-etcd.{{ .Release.Namespace }}.svc.{{
.Values.etcd.clusterDomain }}:{{ .Values.etcd.service.port }}"
{{- else }}
host: # it's possible to define multiple
etcd hosts addresses of the same etcd cluster.
{{- range $value := .Values.etcd.host }}
diff --git a/charts/apisix/templates/deployment.yaml
b/charts/apisix/templates/deployment.yaml
index e8df5ca..318cff2 100644
--- a/charts/apisix/templates/deployment.yaml
+++ b/charts/apisix/templates/deployment.yaml
@@ -87,7 +87,7 @@ spec:
initContainers:
- name: wait-etcd
image: busybox:1.28
-command: ['sh', '-c', "until nc -z {{ .Release.Name }}-etcd.{{
.Release.Namespace }}.svc.{{ .Values.gateway.k8s_domain }} {{
.Values.etcd.defaultPort }}; do echo waiting for etcd `date`; sleep 2; done;"]
+command: ['sh', '-c', "until nc -z {{ .Release.Name }}-etcd.{{
.Release.Namespace }}.svc.{{ .Values.etcd.clusterDomain }} {{
.Values.etcd.service.port }}; do echo waiting for etcd `date`; sleep 2; done;"]
{{- end }}
volumes:
- configMap:
diff --git a/charts/apisix/values.yaml b/charts/apisix/values.yaml
index 5cb53ed..d806a5b 100644
--- a/charts/apisix/values.yaml
+++ b/charts/apisix/values.yaml
@@ -42,7 +42,6 @@ securityContext:
gateway:
type: NodePort
- k8s_domain: cluster.local
# type: LoadBalancer
# annotations:
# service.beta.kubernetes.io/aws-load-balancer-type: nlb
@@ -79,7 +78,8 @@ etcd:
- http://etcd.host:2379 # host or ip e.g. http://172.20.128.89:2379
prefix: "/apisix"
timeout: 30
- defaultPort: 2379
+
+ # if etcd.enabled is true, set more values of bitnami/etcd helm chart
auth:
rbac:
# No authentication by default
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #38: chore: remove invalid values
gxthrj commented on a change in pull request #38:
URL: https://github.com/apache/apisix-helm-chart/pull/38#discussion_r592011064
##
File path: charts/apisix/templates/deployment.yaml
##
@@ -87,7 +87,7 @@ spec:
initContainers:
- name: wait-etcd
image: busybox:1.28
-command: ['sh', '-c', "until nc -z {{ .Release.Name }}-etcd.{{
.Release.Namespace }}.svc.{{ .Values.gateway.k8s_domain }} {{
.Values.etcd.defaultPort }}; do echo waiting for etcd `date`; sleep 2; done;"]
+command: ['sh', '-c', "until nc -z {{ .Release.Name }}-etcd.{{
.Release.Namespace }}.svc.{{ .Values.etcd.clusterDomain }} {{
.Values.etcd.service.port }}; do echo waiting for etcd `date`; sleep 2; done;"]
Review comment:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] xuyancheng24 commented on issue #3800: request help: 用openssl生成证书和秘钥后，不能直接用，还要把私有CA证书cacert.pem文件内容，追加到/etc/pkis/certs/ca-bundle.crt，才能用https访问
xuyancheng24 commented on issue #3800: URL: https://github.com/apache/apisix/issues/3800#issuecomment-796363623 you mean if I don't access APISIX in the local host, and it as a server-side certificate,or Client access does not affect，I don't need the CA cert (/etc/pkis/certs/ca-bundle.crt)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on issue #3787: [discuss]: does the traffic-split plugin has a way to implement the original capabilities without corrupting the data?
moonming commented on issue #3787: URL: https://github.com/apache/apisix/issues/3787#issuecomment-796357425 @Firstsawyou This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1572: chore: add health e2e test
tokers commented on a change in pull request #1572:
URL: https://github.com/apache/apisix-dashboard/pull/1572#discussion_r592001598
##
File path: api/test/e2enew/healthz/healthz_suite_test.go
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package healthz
+
+import (
+ "testing"
+
+ "github.com/onsi/ginkgo"
+)
+
+func TestRoute(t *testing.T) {
Review comment:
It has nothing to do with `Route`, the title is confusing, man.
##
File path: api/test/e2enew/healthz/healthz_test.go
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package healthz
+
+import (
+ "net/http"
+
+ "github.com/onsi/ginkgo"
+
+ "e2enew/base"
Review comment:
We'd better add the module prefix, or we may think the "e2enew/base" is
a standard package.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on issue #149: [DISCUSS]Link access log and error log to stdout and stderr
tokers commented on issue #149: URL: https://github.com/apache/apisix-docker/issues/149#issuecomment-796354207 > Containerized apps with docker are usually designed to send its logs to `stdout` and `stderr` and the docker log drivers will capture it and route to the external destinations. In AWS, the default log driver is [awslogs](https://docs.aws.amazon.com/AmazonECS/latest/userguide/using_awslogs.html) which routes all the logs from `stdout` and `stderr` to Amazon CloudWatch Logs. It's also possible to run a sidecar container like `fluentd` or `fluentbit` as a log router to read the input from log files and send to external destinations. > > For single user local development, we can simply tail the log with [docker log](https://docs.docker.com/config/containers/logging/dual-logging/) or `kubectl logs`, however, in cloud environment, we need log drivers and log routers to ship the logs out to a centralized logging system or data ingestion system for further analysis. And the first thing we need to do is to ensure all the app logs in container always go to stdout and stderr. Cool, good to know that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3800: request help: 用openssl生成证书和秘钥后，不能直接用，还要把私有CA证书cacert.pem文件内容，追加到/etc/pkis/certs/ca-bundle.crt，才能用https访问
tokers commented on issue #3800: URL: https://github.com/apache/apisix/issues/3800#issuecomment-796353465 @xuyancheng24 `ssl_trusted_certificate` is used to fill the Nginx directive `lua_ssl_trusted_certificate`, which is used by APISIX itself when it talks to external components (to verify these components). You didn't say how you use the self-signed certificate, maybe as a server-side certificate? In such a case, this depends on your clients' to ignore the verification of the certificate. It has nothing to do with putting the CA cert to /etc/pkis/certs/ca-bundle.crt unless you access APISIX in the local host. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3778: bug: 跨域请求bug
Firstsawyou commented on issue #3778: URL: https://github.com/apache/apisix/issues/3778#issuecomment-796352580 > @Firstsawyou I will reproduce it locally later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3801: request help: support kubernetes as service discovery
tokers commented on issue #3801: URL: https://github.com/apache/apisix/issues/3801#issuecomment-796350165 @Junnplus Use Ingress Controller is a better way, or we have to communicate with API Server in APISIX core, which is complex and the ecosystem is lack. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] anjia0532 edited a comment on pull request #150: feat: add apisix-dashbaord
anjia0532 edited a comment on pull request #150: URL: https://github.com/apache/apisix-docker/pull/150#issuecomment-794740342 @nic-chen 我改的是md文档，不会触发这个错误。  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1571: chore: improve ssl e2e test coverage
tokers commented on a change in pull request #1571:
URL: https://github.com/apache/apisix-dashboard/pull/1571#discussion_r591995166
##
File path: api/test/e2enew/ssl/ssl_test.go
##
@@ -26,38 +26,80 @@ import (
"time"
"github.com/onsi/ginkgo"
+ "github.com/onsi/ginkgo/extensions/table"
"github.com/stretchr/testify/assert"
"e2enew/base"
)
var _ = ginkgo.Describe("SSL Basic", func() {
- ginkgo.It("test ssl basic", func() {
- // build test body
- t := ginkgo.GinkgoT()
- testCert, err := ioutil.ReadFile("../../certs/test2.crt")
- assert.Nil(t, err)
- testKey, err := ioutil.ReadFile("../../certs/test2.key")
- assert.Nil(t, err)
- apisixKey, err := ioutil.ReadFile("../../certs/apisix.key")
- assert.Nil(t, err)
- body, err := json.Marshal(map[string]interface{}{
- "id": "1",
- "cert": string(testCert),
- "key": string(testKey),
- "labels": map[string]string{
- "build": "16",
- "env": "production",
- "version": "v3",
+ t := ginkgo.GinkgoT()
+ var (
Review comment:
A better pattern is to put all these initialization logic to
`ginkgo.BeforeEach()`, anyway, it's just a suggestion, you can optimize them in
the future.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1538: fix: Incomplete i18n coverage
nic-chen commented on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-796328473 Strange, there is no problem with other PRs. Could you sync the master code first please? @Baoyuantop This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1565: The upstream timeout unit is seconds instead of milliseconds
nic-chen commented on issue #1565: URL: https://github.com/apache/apisix-dashboard/issues/1565#issuecomment-796327521 ok, thanks. @stu01509 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on issue #1565: The upstream timeout unit is seconds instead of milliseconds
stu01509 commented on issue #1565: URL: https://github.com/apache/apisix-dashboard/issues/1565#issuecomment-796317721 I want to fix this issue, please assign this issue to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module
codecov-io commented on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-795836615 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=h1) Report > Merging [#1576](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=desc) (8dc46ec) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9a92ff95ddbe43432247a8b49ba63a9de115e726?el=desc) (9a92ff9) will **decrease** coverage by `19.33%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1576 +/- ## === - Coverage 70.88% 51.54% -19.34% === Files 135 37 -98 Lines5485 2555 -2930 Branches 5830 -583 === - Hits 3888 1317 -2571 + Misses 1349 1057 -292 + Partials 248 181 -67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.54% <ø> (-0.14%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [115 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=footer). Last update [9a92ff9...8dc46ec](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this
[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1576: fix: config proxy-rewrite out of the plugin market in route module
liuxiran opened a new pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues fix: #1241 ___ ### Bugfix - Description - How to fix?  add a new PanelSection called `Request Override` in Step 1 of create/edit route ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Please add the corresponding test cases if necessary. - [ ] add test case ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
guoqqqi edited a comment on pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795670862
> cc @juzhiyuan @guoqqqi FE CI failed. PTAL
>
https://github.com/apache/apisix-dashboard/pull/1570/checks?check_run_id=2077434026
The error is due to the element being fetched before the data has finished
loading, creating a separation from the element after the data has finished
loading.
You can add ` cy.contains('Custom').should('be.visible');`after line 43 of
`web/cypress/integration/pluginTemplate/create-plugin-template-with-route.spec.js`
Resolve the error.
If I have something wrong, please help me to point out the correction.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
guoqqqi edited a comment on pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795670862
> cc @juzhiyuan @guoqqqi FE CI failed. PTAL
>
https://github.com/apache/apisix-dashboard/pull/1570/checks?check_run_id=2077434026
The error is due to the element being fetched before the data has finished
loading, creating a separation from the element after the data has finished
loading.
You can add ` cy.contains('Custom').should('be .visible');`after line 43 of
`web/cypress/integration/pluginTemplate/create-plugin-template-with-route.spec.js`
Resolve the error.
If I have something wrong, please help me to point out the correction.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
guoqqqi edited a comment on pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795670862
> cc @juzhiyuan @guoqqqi FE CI failed. PTAL
>
https://github.com/apache/apisix-dashboard/pull/1570/checks?check_run_id=2077434026
The error is due to the element being fetched before the data has finished
loading, creating a separation from the element after the data has finished
loading. You can add ` cy.contains('Custom').should('be .visible');`after line
43 of
`web/cypress/integration/pluginTemplate/create-plugin-template-with-route.spec.js`
Resolve the error.
If I have something wrong, please help me to point out the correction.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
guoqqqi edited a comment on pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795670862
> cc @juzhiyuan @guoqqqi FE CI failed. PTAL
>
https://github.com/apache/apisix-dashboard/pull/1570/checks?check_run_id=2077434026
The error is due to the element being fetched before the data has finished
loading, creating a separation from the element after the data has finished
loading. You can add ` cy.contains('Custom').should('be .visible');`after line
43 of
`web/cypress/integration/pluginTemplate/create-plugin-template-with-route.spec.js`
Resolve the error.
Feel free to help me out if there is something wrong.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
guoqqqi commented on pull request #1570:
URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795670862
> cc @juzhiyuan @guoqqqi FE CI failed. PTAL
>
https://github.com/apache/apisix-dashboard/pull/1570/checks?check_run_id=2077434026
The error is due to the element being fetched before the data has finished
loading, creating a separation from the element after the data has finished
loading. You can add ` cy.contains('Custom').should('be .visible');` Resolve
the error.
Feel free to help me out if there is something wrong.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz opened a new pull request #1575: chore: cover plugin config create function
starsz opened a new pull request #1575: URL: https://github.com/apache/apisix-dashboard/pull/1575 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ chore: cover the plugin config create function.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz opened a new pull request #1574: chore: add plugin test
starsz opened a new pull request #1574: URL: https://github.com/apache/apisix-dashboard/pull/1574 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ Add plugin e2e test that we don't have before.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou opened a new issue #3802: docs: update the admin-api.md document
Firstsawyou opened a new issue #3802: URL: https://github.com/apache/apisix/issues/3802 # Improve Docs ## Please describe which part of docs should be improved or typo fixed The `pass_host` part of the upstream object in the admin-api.md document needs more detailed explanation. The current description is difficult to understand. https://user-images.githubusercontent.com/52862365/110651917-d88d2a00-81f6-11eb-825d-5d75b4c228ee.png;> Secondly, the table data in the `upstream` part of the Chinese document of admin-api.md is messy and needs to be fixed. https://user-images.githubusercontent.com/52862365/110652665-8b5d8800-81f7-11eb-8d09-c11b5eb8cda5.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
Jaycean commented on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795563467 cc @juzhiyuan @guoqqqi FE CI failed. PTAL https://github.com/apache/apisix-dashboard/pull/1570/checks?check_run_id=2077434026 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan merged pull request #3797: docs: update contributor over time image
juzhiyuan merged pull request #3797: URL: https://github.com/apache/apisix/pull/3797 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: update contributor over time image (#3797)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new f05debb docs: update contributor over time image (#3797) f05debb is described below commit f05debba6e172ce23b3cd3726d7836ed5e04ad05 Author: litesun AuthorDate: Wed Mar 10 22:54:10 2021 +0800 docs: update contributor over time image (#3797) --- docs/assets/images/contributor-over-time.png | Bin 47830 -> 49306 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/docs/assets/images/contributor-over-time.png b/docs/assets/images/contributor-over-time.png index 1f93780..2c17864 100644 Binary files a/docs/assets/images/contributor-over-time.png and b/docs/assets/images/contributor-over-time.png differ
[GitHub] [apisix] moonming commented on issue #3778: bug: 跨域请求bug
moonming commented on issue #3778: URL: https://github.com/apache/apisix/issues/3778#issuecomment-795540038 @Firstsawyou This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus opened a new pull request #39: feat: add dashboard and ingress-controller as component of apisix
Junnplus opened a new pull request #39: URL: https://github.com/apache/apisix-helm-chart/pull/39 add dashboard and ingress-controller as component of apisix. We can deploy `apisix`, `apisix-dashboard` and `apisix-ingress-controller` together. `helm install apisix --set dashboard.enabled=true --set ingressController.enabled=true` ``` apisix-etcd-01/1 Running 0 22m apisix-dashboard-94f89d48-r79sf 1/1 Running 3 22m apisix-d9744dc9f-fg47x 1/1 Running 0 22m apisix-ingress-controller-5cf7cc8bbc-wm2wx 1/1 Running 0 3m5s ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #3799: feat: load etcd configuration when apisix starts
tokers commented on pull request #3799: URL: https://github.com/apache/apisix/pull/3799#issuecomment-795477416 > This is an interesting PR, welcome @tokers to take a look OK. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
codecov-io edited a comment on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795454945 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=h1) Report > Merging [#1570](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=desc) (55fd1a4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c8b235bb4a60c2d91840a4385649998bd1e9a841?el=desc) (c8b235b) will **decrease** coverage by `17.60%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1570 +/- ## === - Coverage 69.15% 51.54% -17.61% === Files 49 37 -12 Lines3164 2555 -609 === - Hits 2188 1317 -871 - Misses728 1057 +329 + Partials 248 181 -67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.54% <ø> (-0.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [34 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=footer). Last update [c8b235b...55fd1a4](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1571: chore: improve ssl e2e test coverage
codecov-io edited a comment on pull request #1571: URL: https://github.com/apache/apisix-dashboard/pull/1571#issuecomment-795057724 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1571?src=pr=h1) Report > Merging [#1571](https://codecov.io/gh/apache/apisix-dashboard/pull/1571?src=pr=desc) (822e0d9) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/569c4bdbb934ab6d6a063750b931b22db99bae90?el=desc) (569c4bd) will **increase** coverage by `5.58%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1571?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1571 +/- ## == + Coverage 67.62% 73.21% +5.58% == Files 46 86 +40 Lines3012 2322 -690 Branches0 584 +584 == - Hits 2037 1700 -337 + Misses735 622 -113 + Partials 2400 -240 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.21% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1571?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1571/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1571/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | | | | [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1571/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1571/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1571/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1571/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | | | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1571/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | | | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1571/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | | | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1571/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | | | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1571/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | | | ... and [122 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1571/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1571?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1571?src=pr=footer). Last update [569c4bd...822e0d9](https://codecov.io/gh/apache/apisix-dashboard/pull/1571?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
codecov-io edited a comment on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795454945 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=h1) Report > Merging [#1570](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=desc) (be6ac94) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c8b235bb4a60c2d91840a4385649998bd1e9a841?el=desc) (c8b235b) will **decrease** coverage by `3.40%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1570 +/- ## == - Coverage 69.15% 65.75% -3.41% == Files 49 46 -3 Lines3164 3019 -145 == - Hits 2188 1985 -203 - Misses728 786 +58 Partials 248 248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `43.75% <ø> (+3.71%)` | :arrow_up: | | backend-unit-test | `51.54% <ø> (-0.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `77.14% <0.00%> (-8.58%)` | :arrow_down: | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `54.05% <0.00%> (-5.41%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `69.01% <0.00%> (-2.87%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=footer). Last update [c8b235b...be6ac94](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
codecov-io commented on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795454945 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=h1) Report > Merging [#1570](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=desc) (be6ac94) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c8b235bb4a60c2d91840a4385649998bd1e9a841?el=desc) (c8b235b) will **decrease** coverage by `17.60%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1570 +/- ## === - Coverage 69.15% 51.54% -17.61% === Files 49 37 -12 Lines3164 2555 -609 === - Hits 2188 1317 -871 - Misses728 1057 +329 + Partials 248 181 -67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.54% <ø> (-0.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [34 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1570/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=footer). Last update [c8b235b...be6ac94](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1569: feat: supports changing number of executing cpu cores for manager api
bisakhmondal commented on pull request #1569: URL: https://github.com/apache/apisix-dashboard/pull/1569#issuecomment-795429313 You're welcome. Thanks for the review guys. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: fix(doc): fix some document url (#1566)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new d5babce fix(doc): fix some document url (#1566)
d5babce is described below
commit d5babce089da475240abfc21abe7c815cc31bc27
Author: AnJia
AuthorDate: Wed Mar 10 19:58:19 2021 +0800
fix(doc): fix some document url (#1566)
---
docs/en/latest/FAQ.md | 4 ++--
docs/en/latest/IMPORT_OPENAPI_USER_GUIDE.md| 2 +-
docs/en/latest/back-end-e2e.md | 2 +-
web/src/components/RawDataEditor/RawDataEditor.tsx | 2 +-
web/src/pages/Route/List.tsx | 2 +-
web/src/pages/ServerInfo/List.tsx | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/docs/en/latest/FAQ.md b/docs/en/latest/FAQ.md
index 448d0f5..a83f005 100644
--- a/docs/en/latest/FAQ.md
+++ b/docs/en/latest/FAQ.md
@@ -39,7 +39,7 @@ Since the Dashboard caches the jsonschema data of the plugins
in Apache APISIX,
1. Confirm that your APISIX is running and has enabled control API (enabled by
default and only runs local access)
Refer to the beginning in:
- https://github.com/apache/apisix/blob/master/docs/en/latest/control-api.md
+
[https://apisix.apache.org/docs/apisix/control-api](https://apisix.apache.org/docs/apisix/control-api)
2. Execute the following commands to export jsonchema on your APISIX server
(if it is configured for non-local access, it does not need to be executed on
your APISIX server, and the access IP and port should be modified accordingly)
@@ -47,7 +47,7 @@ Since the Dashboard caches the jsonschema data of the plugins
in Apache APISIX,
curl 127.0.0.1:9090/v1/schema > schema.json
```
-Refer to
https://github.com/apache/apisix/blob/master/docs/en/latest/control-api.md#get-v1schema
+Refer to
[https://apisix.apache.org/docs/apisix/control-api#get-v1schema](https://apisix.apache.org/docs/apisix/control-api#get-v1schema)
3. Copy the exported `schema.json` to the `conf` directory in the Dashboard
working directory (About working directory, please refer to
https://github.com/apache/apisix-dashboard/blob/master/docs/en/latest/deploy.md#working-directory)
diff --git a/docs/en/latest/IMPORT_OPENAPI_USER_GUIDE.md
b/docs/en/latest/IMPORT_OPENAPI_USER_GUIDE.md
index 67281bb..45c5d15 100644
--- a/docs/en/latest/IMPORT_OPENAPI_USER_GUIDE.md
+++ b/docs/en/latest/IMPORT_OPENAPI_USER_GUIDE.md
@@ -41,7 +41,7 @@ when we import routes from OAS3.0, some fields in OAS will be
missed because the
## Extended fields
-There are some fields required in APISIX Route but are not included in the
properties of OAS3.0, we added some extended fields such as upstream, plugins,
hosts and so on. All extensions start with x-apisix. See
[reference](https://github.com/apache/apisix/blob/master/doc/admin-api.md#route)
For more details of the APISIX Route Properties
+There are some fields required in APISIX Route but are not included in the
properties of OAS3.0, we added some extended fields such as upstream, plugins,
hosts and so on. All extensions start with x-apisix. See
[reference](https://apisix.apache.org/docs/apisix/admin-api/#route) For more
details of the APISIX Route Properties
| Extended fields | APISIX Route Properties |
| - | --- |
diff --git a/docs/en/latest/back-end-e2e.md b/docs/en/latest/back-end-e2e.md
index d6aabf3..7b81dd5 100644
--- a/docs/en/latest/back-end-e2e.md
+++ b/docs/en/latest/back-end-e2e.md
@@ -29,7 +29,7 @@ This document describes how to use E2E test locally.
2. To start the `manager-api` project locally, please refer to
[develop](./develop.md) web section.
-3. To start the etcd locally, please refer to [etcd
start](https://github.com/apache/apisix/blob/master/docs/en/latest/install-dependencies.md)
web section.
+3. To start the etcd locally, please refer to [etcd
start](https://apisix.apache.org/docs/apisix/install-dependencies/) web section.
4. To start the `apisix` project locally, please refer to [apisix
start](https://github.com/apache/apisix#get-started) web section.
diff --git a/web/src/components/RawDataEditor/RawDataEditor.tsx
b/web/src/components/RawDataEditor/RawDataEditor.tsx
index 9274148..ad8e209 100644
--- a/web/src/components/RawDataEditor/RawDataEditor.tsx
+++ b/web/src/components/RawDataEditor/RawDataEditor.tsx
@@ -50,7 +50,7 @@ const RawDataEditor: React.FC = ({ visible, readonly =
true, type, data =
icon={}
onClick={() => {
window.open(
-
`https://github.com/apache/apisix/blob/master/doc/admin-api.md#${type}`,
+ `https://apisix.apache.org/docs/apisix/admin-api#${type}`,
);
}}
key={1}
diff --git
[GitHub] [apisix-dashboard] LiteSun merged pull request #1566: fix(doc): fix some document url
LiteSun merged pull request #1566: URL: https://github.com/apache/apisix-dashboard/pull/1566 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: fix: improved the description for users to join slack (#253)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 7f4c6c3 fix: improved the description for users to join slack (#253)
7f4c6c3 is described below
commit 7f4c6c3a4980cced903a05ae5899b2be76692ed2
Author: Ayush das
AuthorDate: Wed Mar 10 17:25:28 2021 +0530
fix: improved the description for users to join slack (#253)
---
website/src/pages/help.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/website/src/pages/help.js b/website/src/pages/help.js
index 1afee42..ce7b6f2 100644
--- a/website/src/pages/help.js
+++ b/website/src/pages/help.js
@@ -69,7 +69,7 @@ function Help(props) {
https://join.slack.com/t/the-asf/shared_invite/zt-lcbw4olf-_5s17RLU0Cx8xTvj2bNbjg;
+
href="https://join.slack.com/t/the-asf/shared_invite/zt-mrougyeu-2aG7BnFaV0VnAT9_JIUVaA;
target="_blank"
>
Slack
[GitHub] [apisix-website] LiteSun closed issue #229: improve the description for users to join Slack
LiteSun closed issue #229: URL: https://github.com/apache/apisix-website/issues/229 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] LiteSun merged pull request #253: fix: improved the description for users to join slack
LiteSun merged pull request #253: URL: https://github.com/apache/apisix-website/pull/253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1538: fix: Incomplete i18n coverage
LiteSun commented on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-795302500 @nic-chen Backend CLI Test failed，please take a look when you have time This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #32: fix: dashboard ingress and apisix gateway ingress
tokers commented on pull request #32: URL: https://github.com/apache/apisix-helm-chart/pull/32#issuecomment-795251132 @gxthrj please take a look when you have time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus commented on pull request #32: fix: dashboard ingress and apisix gateway ingress
Junnplus commented on pull request #32: URL: https://github.com/apache/apisix-helm-chart/pull/32#issuecomment-795249293 LGTM, @tokers we can merge this ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] cgc1983 closed issue #3762: request help:
cgc1983 closed issue #3762: URL: https://github.com/apache/apisix/issues/3762 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] cgc1983 commented on issue #3762: request help:
cgc1983 commented on issue #3762: URL: https://github.com/apache/apisix/issues/3762#issuecomment-795247883 thx > In the config.yaml configuration file, you have not added the `cors` plugin name to the plugins. > You need to add the cors plugin name to the `plugins` list like this: > > ``` > .. > plugins: # plugin list (sorted in alphabetical order) > - skywalking > - cors > ``` thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] Junnplus opened a new pull request #38: chore: remove invalid values
Junnplus opened a new pull request #38: URL: https://github.com/apache/apisix-helm-chart/pull/38 `gateway.k8s_domain` and `etcd.defaultPort` is invalid for etcd, use `etcd.clusterDomain` and `etcd.service.port` instead them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1573: discuss: Support raw data editor edit mode
nic-chen commented on issue #1573: URL: https://github.com/apache/apisix-dashboard/issues/1573#issuecomment-795215859 @LiteSun The backend has schema to verify data, so there is no need to worry about dirty data. What we need to worry about is that the data saved through the Admin API is lost because of missing fields in the FE form. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (569c4bd -> e8256c2)
This is an automated email from the ASF dual-hosted git repository. starsz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 569c4bd chore: delete unused file (#1568) add e8256c2 feat: supports changing number of executing cpu cores for manager api (#1569) No new revisions were added by this update. Summary of changes: api/conf/conf.yaml| 2 ++ api/internal/conf/conf.go | 26 ++ 2 files changed, 24 insertions(+), 4 deletions(-)
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1569: feat: supports changing number of executing cpu cores for manager api
nic-chen commented on pull request #1569: URL: https://github.com/apache/apisix-dashboard/pull/1569#issuecomment-795208991 @bisakhmondal merged, thanks a lot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo
nic-chen commented on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795208222 cli test failed.. @Jaycean This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz merged pull request #1569: feat: supports changing number of executing cpu cores for manager api
starsz merged pull request #1569: URL: https://github.com/apache/apisix-dashboard/pull/1569 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
