[GitHub] [apisix] spacewander opened a new pull request #3907: fix: use the builtin server by default
spacewander opened a new pull request #3907: URL: https://github.com/apache/apisix/pull/3907 Fix #3906 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1666: feat: improved plugin #1631
guoqqqi commented on pull request #1666: URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806400475 Hi, @iamayushdas I think the headings should be left-justified.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #1660: doc: Improve docs about route import and export
liuxiran edited a comment on issue #1660: URL: https://github.com/apache/apisix-dashboard/issues/1660#issuecomment-806378650 > > ~~duplicate with #1646~~ > > @nic-chen sorry for late response for this issue, and pr is on the way > > thanks for remind. but the issue id seems wrong… it should be https://github.com/apache/apisix-dashboard/issues/1660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #1660: doc: Improve docs about route import and export
liuxiran edited a comment on issue #1660: URL: https://github.com/apache/apisix-dashboard/issues/1660#issuecomment-806302537 ~~duplicate with #1646~~ @nic-chen sorry for late response for this issue, and pr is on the way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #311: fix: workqueue need to retry when failed
tokers commented on a change in pull request #311:
URL:
https://github.com/apache/apisix-ingress-controller/pull/311#discussion_r601083816
##
File path: pkg/ingress/controller/apisix_route.go
##
@@ -188,15 +188,11 @@ func (c *apisixRouteController) handleSyncErr(obj
interface{}, err error) {
c.workqueue.Forget(obj)
return
}
- if c.workqueue.NumRequeues(obj) < _maxRetries {
Review comment:
See the use pattern in
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/endpoint/endpoints_controller.go#L356.
We just reference it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #45: add allow_admin rest support
tokers commented on pull request #45: URL: https://github.com/apache/apisix-helm-chart/pull/45#issuecomment-806390348 @riskgod This step can be done to add a `set` option to append the `0.0.0.0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] riskgod commented on issue #44: After update the apisix-admin to NodePort, still can't visit it on local
riskgod commented on issue #44: URL: https://github.com/apache/apisix-helm-chart/issues/44#issuecomment-806386771 https://github.com/apache/apisix-helm-chart/pull/45 Add pr support here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] riskgod opened a new pull request #45: add allow_admin rest support
riskgod opened a new pull request #45: URL: https://github.com/apache/apisix-helm-chart/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1664: feat: use gomega match assertion
bisakhmondal commented on issue #1664: URL: https://github.com/apache/apisix-dashboard/issues/1664#issuecomment-806379391 +1 `gomega` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1660: doc: Improve docs about route import and export
liuxiran commented on issue #1660: URL: https://github.com/apache/apisix-dashboard/issues/1660#issuecomment-806378650 > > duplicate with #1646 > > @nic-chen sorry for late response for this issue, and pr is on the way > > thanks for remind. but the issue id seems wrong… it should be https://github.com/apache/apisix-dashboard/issues/1660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on issue #1664: feat: use gomega match assertion
tokers commented on issue #1664: URL: https://github.com/apache/apisix-dashboard/issues/1664#issuecomment-806376512 It seems the output is more friendly, we mat try it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1610: feat: improve the config plugin button enable disable status
codecov-io edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=h1) Report > Merging [#1610](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=desc) (0736cf0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **decrease** coverage by `1.40%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1610 +/- ## == - Coverage 72.59% 71.18% -1.41% == Files 133 47 -86 Lines5728 3116-2612 Branches 6660 -666 == - Hits 4158 2218-1940 + Misses 1327 654 -673 - Partials 243 244 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.84% <ø> (-0.29%)` | :arrow_down: | | backend-e2e-test-ginkgo | `48.04% <ø> (-0.23%)` | :arrow_down: | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `71.02% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.27% <0.00%> (-1.82%)` | :arrow_down: | | [web/src/pages/Setting/Setting.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL1NldHRpbmcudHN4) | | | | [...c/pages/Route/components/ResultView/ResultView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1Jlc3VsdFZpZXcvUmVzdWx0Vmlldy50c3g=) | | | | [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | | | | [web/src/pages/Dashboard/Dashboard.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9EYXNoYm9hcmQvRGFzaGJvYXJkLnRzeA==) | | | | [web/src/pages/Upstream/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9zZXJ2aWNlLnRz) | | | | [web/src/components/HeaderDropdown/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0hlYWRlckRyb3Bkb3duL2luZGV4LnRzeA==) | | | | [web/src/pages/SSL/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TU0wvc2VydmljZS50cw==) | | | | [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | | | | ... and [78 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=footer). Last update [c6c5d14...0736cf0](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1610: feat: improve the config plugin button enable disable status
codecov-io edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=h1) Report > Merging [#1610](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=desc) (0736cf0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **decrease** coverage by `5.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1610 +/- ## == - Coverage 72.59% 67.45% -5.14% == Files 133 47 -86 Lines5728 3116-2612 Branches 6660 -666 == - Hits 4158 2102-2056 + Misses 1327 767 -560 - Partials 243 247 +4 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `48.04% <ø> (-0.23%)` | :arrow_down: | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-7.48%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.27% <0.00%> (-1.82%)` | :arrow_down: | | ... and [86 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=footer). Last update [c6c5d14...0736cf0](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1610: feat: improve the config plugin button enable disable status
codecov-io edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=h1) Report > Merging [#1610](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=desc) (0736cf0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **decrease** coverage by `20.77%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1610 +/- ## === - Coverage 72.59% 51.81% -20.78% === Files 133 38 -95 Lines5728 2650 -3078 Branches 6660 -666 === - Hits 4158 1373 -2785 + Misses 1327 1089 -238 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.77%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [118 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=footer). Last update [c6c5d14...0736cf0](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact
[GitHub] [apisix-dashboard] nic-chen commented on issue #1660: doc: Improve docs about route import and export
nic-chen commented on issue #1660: URL: https://github.com/apache/apisix-dashboard/issues/1660#issuecomment-806362640 > duplicate with #1646 > > > > @nic-chen sorry for late response for this issue, and pr is on the way thanks for remind. but the issue id seems wrong… -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] stu01509 commented on pull request #270: Feat #266 speed up static file
stu01509 commented on pull request #270: URL: https://github.com/apache/apisix-website/pull/270#issuecomment-806361951 Hi @juzhiyuan Update the commit :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1666: feat: improved plugin #1631
iamayushdas edited a comment on pull request #1666: URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806344710 @juzhiyuan @LiteSun @bzp2010 @guoqqqi @liuxiran please review this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hackeryutu opened a new issue #3906: Why do I limit the server_name value, but still go to the snippet server block
hackeryutu opened a new issue #3906: URL: https://github.com/apache/apisix/issues/3906 ### Issue description I enter m.qa.com in the browser and it will go to the server block of qa.com www.qa.com ### Environment  * apisix version (cmd: `apisix version`): * OS (cmd: `uname -a`): * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): * apisix-dashboard version, if have: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1666: feat: improved plugin #1631
iamayushdas commented on pull request #1666: URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806344710 @juzhiyuan @LiteSun @bzp2010 @guoqqqi please review this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] logonmy closed issue #1665: 当编辑已有路由，修改重定向这个内容，由禁用改为 启用https的时候，提交报10005
logonmy closed issue #1665: URL: https://github.com/apache/apisix-dashboard/issues/1665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1666: feat: improved plugin #1631
codecov-io commented on pull request #1666: URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806333238 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1666?src=pr&el=h1) Report > Merging [#1666](https://codecov.io/gh/apache/apisix-dashboard/pull/1666?src=pr&el=desc) (3f6da41) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b5c5056bcd1dcae6601b453adabc849c87b52a89?el=desc) (b5c5056) will **increase** coverage by `1.58%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1666?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1666 +/- ## == + Coverage 72.46% 74.05% +1.58% == Files 134 86 -48 Lines5738 2613-3125 Branches 666 666 == - Hits 4158 1935-2223 + Misses 1336 678 -658 + Partials 2440 -244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `74.05% <100.00%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1666?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [web/src/pages/Plugin/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1666/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW4vTGlzdC50c3g=) | `96.22% <100.00%> (+0.07%)` | :arrow_up: | | [web/src/pages/User/Login.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1666/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ2luLnRzeA==) | `72.00% <100.00%> (ø)` | | | [web/src/pages/User/Logout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1666/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ291dC50c3g=) | `100.00% <100.00%> (ø)` | | | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1666/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `78.08% <0.00%> (-1.37%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1666/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | | | | [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1666/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | | | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1666/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1666/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1666/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1666/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | | | | ... and [41 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1666/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1666?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1666?src=pr&el=footer). Last update [b5c5056...3f6da41](https://codecov.io/gh/apache/apisix-dashboard/pull/1666?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] logonmy commented on issue #1665: 当编辑已有路由，修改重定向这个内容，由禁用改为 启用https的时候，提交报10005
logonmy commented on issue #1665: URL: https://github.com/apache/apisix-dashboard/issues/1665#issuecomment-806330707 > which version are you use? i find a fix at #1527 and will release soon at 2.5 version thank you, version is 2.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1660: doc: Improve docs about route import and export
liuxiran commented on issue #1660: URL: https://github.com/apache/apisix-dashboard/issues/1660#issuecomment-806302537 duplicate with #1646 @nic-chen sorry for late response for this issue, and pr is on the way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] stu01509 commented on a change in pull request #270: Feat #266 speed up static file
stu01509 commented on a change in pull request #270:
URL: https://github.com/apache/apisix-website/pull/270#discussion_r600988537
##
File path: website/src/pages/index.js
##
@@ -120,7 +120,7 @@ const Showcase = () => {
}
const showcases = siteConfig.customFields.showcases.map((user) => (
-
+ https://cdn.jsdelivr.net/gh/apache/apisix-website@master/website/static/'
+ user.image} alt={user.caption} />
Review comment:
yup. missing the `/img` path, I will fix it later 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #270: Feat #266 speed up static file
juzhiyuan commented on a change in pull request #270:
URL: https://github.com/apache/apisix-website/pull/270#discussion_r600979393
##
File path: website/src/pages/index.js
##
@@ -120,7 +120,7 @@ const Showcase = () => {
}
const showcases = siteConfig.customFields.showcases.map((user) => (
-
+ https://cdn.jsdelivr.net/gh/apache/apisix-website@master/website/static/'
+ user.image} alt={user.caption} />
Review comment:
https://deploy-preview-270--apisix.netlify.app/
Broken, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1630: improve Consumer module
juzhiyuan commented on issue #1630: URL: https://github.com/apache/apisix-dashboard/issues/1630#issuecomment-806290189 #3? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1631: improve Plugin & Plugin Editor & Meta Raw Data Editor module
juzhiyuan commented on issue #1631: URL: https://github.com/apache/apisix-dashboard/issues/1631#issuecomment-806289537 cc @LiteSun @bzp2010 @guoqqqi to review this PR, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1664: feat: use gomega match assertion
juzhiyuan commented on issue #1664: URL: https://github.com/apache/apisix-dashboard/issues/1664#issuecomment-806289325 Not sure 🤔 I'm not familiar with Go currently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1631: improve Plugin & Plugin Editor & Meta Raw Data Editor module
juzhiyuan commented on issue #1631: URL: https://github.com/apache/apisix-dashboard/issues/1631#issuecomment-806288565 > is there any exact/specific icon to be chosen? in > > * [ ] Add icon for Plugin Marketplace plugins. > > @juzhiyuan I'm back, actually, no for now 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1666: feat: improved plugin #1631
juzhiyuan commented on pull request #1666: URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806288351 no, maybe Cypress's CDN is unstable? let's retrigger -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #842: feat: support run `manager api` as OS service
juzhiyuan commented on issue #842: URL: https://github.com/apache/apisix-dashboard/issues/842#issuecomment-806288203 cc @starsz @nic-chen to help when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1659: release: new version 2.5
juzhiyuan commented on a change in pull request #1659: URL: https://github.com/apache/apisix-dashboard/pull/1659#discussion_r600976013 ## File path: CHANGELOG.md ## @@ -28,6 +29,37 @@ - [1.5.0](#150) - [1.0.0](#100) +# 2.5.0 + +This release mainly improves basic features, bugfix and adds test cases. + +`Manager API` 2.5 should be used with [Apache APISIX 2.4](https://github.com/apache/apisix/releases/tag/2.4). It is not recommended to use with other Apache APISIX versions. Review comment: Would better use `http://apisix.apache.org/downloads` or `https://www.apache.org/dyn/closer.cgi/apisix/2.4/apache-apisix-2.4-src.tgz` instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3902: Do you have any development plans to get config data even when etcd is down, such as saving configuration files
spacewander closed issue #3902: URL: https://github.com/apache/apisix/issues/3902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (472ea3f -> baf8434)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 472ea3f docs: add missing index of discovery (#3899) add baf8434 fix: allow addr:port format in stream_proxy (#3900) No new revisions were added by this update. Summary of changes: apisix/cli/ngx_tpl.lua| 8 apisix/cli/ops.lua| 24 conf/config-default.yaml | 4 ++-- t/cli/test_validate_config.sh | 22 ++ 4 files changed, 48 insertions(+), 10 deletions(-)
[GitHub] [apisix] spacewander merged pull request #3900: fix: allow addr:port format in stream_proxy
spacewander merged pull request #3900: URL: https://github.com/apache/apisix/pull/3900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1667: feat: run manager-api as a systemd daemon/service
bisakhmondal commented on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-806073350
Backend CLI Test is failing for changing
`log.Infof("The Manager API server receive %s and start shutting down",
sig.String())`
to
`log.Infof("The Manager API server receives %s and starts acting up",
sig.String())`
hehe :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #842: feat: support run `manager api` as OS service
bisakhmondal commented on issue #842: URL: https://github.com/apache/apisix-dashboard/issues/842#issuecomment-806070292 Hii everyone, I have opened a draft PR. Though it is not fully complete, I would love to have this reviewed by you all. Currently, the config is facing a write permission error to write logs in `error.log` file Here's the last log in reverse ordering ```-- Logs begin at Mon 2021-03-15 21:16:03 IST, end at Wed 2021-03-24 23:52:48 IST. -- Mar 24 23:42:50 turing systemd[1]: Stopped Manager-API service. Mar 24 23:42:45 turing systemd[1]: manager-api.service: Failed with result 'exit-code'. Mar 24 23:42:45 turing systemd[1]: manager-api.service: Main process exited, code=exited, status=2/INVALIDARGUMENT Mar 24 23:42:45 turing manager-api[377717]: /home/bisakh/Desktop/OSS/apisix-dashboard/api/cmd/manager/main.go:27 +0x2b Mar 24 23:42:45 turing manager-api[377717]: main.main() Mar 24 23:42:45 turing manager-api[377717]: /home/bisakh/go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:800 Mar 24 23:42:45 turing manager-api[377717]: github.com/spf13/cobra.(*Command).Execute(...) Mar 24 23:42:45 turing manager-api[377717]: /home/bisakh/go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:852 +0x2fe Mar 24 23:42:45 turing manager-api[377717]: github.com/spf13/cobra.(*Command).ExecuteC(0xc0004f2c80, 0xc00180, 0xc31f78, 0x407d85) Mar 24 23:42:45 turing manager-api[377717]: /home/bisakh/go/pkg/mod/github.com/spf13/cobra@v0.0.3/command.go:762 +0x47c Mar 24 23:42:45 turing manager-api[377717]: github.com/spf13/cobra.(*Command).execute(0xc0004f2c80, 0xc0001181b0, 0x0, 0x0, 0xc0004f2c80, 0xc0001181b0) Mar 24 23:42:45 turing manager-api[377717]: /home/bisakh/Desktop/OSS/apisix-dashboard/api/cmd/managerapi.go:76 +0xbb Mar 24 23:42:45 turing manager-api[377717]: github.com/apisix/manager-api/cmd.NewManagerAPICommand.func1(0xc0004f2c80, 0x1721268, 0x0, 0x0, 0x0, 0x0) Mar 24 23:42:45 turing manager-api[377717]: /home/bisakh/Desktop/OSS/apisix-dashboard/api/internal/log/zap.go:39 Mar 24 23:42:45 turing manager-api[377717]: github.com/apisix/manager-api/internal/log.InitLogger(...) Mar 24 23:42:45 turing manager-api[377717]: /home/bisakh/Desktop/OSS/apisix-dashboard/api/internal/log/zap.go:43 +0x3f Mar 24 23:42:45 turing manager-api[377717]: github.com/apisix/manager-api/internal/log.GetLogger(0x0, 0x3) Mar 24 23:42:45 turing manager-api[377717]: /home/bisakh/Desktop/OSS/apisix-dashboard/api/internal/log/zap.go:103 +0x208 Mar 24 23:42:45 turing manager-api[377717]: github.com/apisix/manager-api/internal/log.fileWriter(0x0, 0x0, 0x0) Mar 24 23:42:45 turing manager-api[377717]: goroutine 1 [running]: Mar 24 23:42:45 turing manager-api[377717]: panic: couldn't open sink "/home/bisakh/Desktop/OSS/apisix-dashboard/output/logs/error.log": open /home/bisakh/Desktop/OSS/apisix-dashboard/output/logs/error.log: permission denied Mar 24 23:42:45 turing systemd[1]: Started Manager-API service. Mar 24 23:42:45 turing systemd[1]: Starting Manager-API service... Mar 24 23:42:45 turing systemd[1]: Stopped Manager-API service. Mar 24 23:42:45 turing systemd[1]: manager-api.service: Scheduled restart job, restart counter is at 74. Mar 24 23:42:40 turing systemd[1]: manager-api.service: Failed with result 'exit-code'. ``` is this issue regarding `writer, _, err := zap.Open(logPath)` for not providing any permission/umask explicitly. It would be great if you guys could provide any sort of guide/help. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1667: feat: run manager-api as a systemd daemon/service
bisakhmondal opened a new pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Currently to run manager-api as a background process is through nohup to avoid unintended SIGHUP from the shell used for initialization. This PR focuses on running manager-api as a systemd service. Tasks - [x] interface for handling multiple SIGHUPs and single SIGKILL/SIGTERM signals through its lifetime - [x] systemd service unit configuration file - [ ] Behaviour on SIGHUP - [ ] fixing permission error bug while writing error logs to run, ```sh # update user, group, directory in service file first sudo cp api/manager-api.service /etc/systemd/system systemctl daemon-reload service manager-api start ``` **Related issues** #842 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1666: feat: improved plugin #1631
iamayushdas edited a comment on pull request #1666: URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806022032  Is this an issue from my side or something else? @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1666: feat: improved plugin #1631
iamayushdas commented on pull request #1666: URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806022032  Is this an issue from my side or something else? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1666: feat: improved plugin #1631
iamayushdas commented on pull request #1666: URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-806003102 @juzhiyuan @liuxiran @nic-chen @imjoey Please review this PR #1666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1631: improve Plugin & Plugin Editor & Meta Raw Data Editor module
iamayushdas commented on issue #1631: URL: https://github.com/apache/apisix-dashboard/issues/1631#issuecomment-805992915 > Here are some minor issues on the Plugin & Plugin Editor & Meta Raw Data Editor page we could resolve. > > ## Plugin TODO > * [ ] Search area, using Table's own, using fuzzy search. > * [ ] page title not internationalized: configure global plugins/Configure Global Plugin. > * [ ] Add icon for Plugin Marketplace plugins. > * [x] list page top title, add description: list of enabled plugins. > * [x] list page, edit button in action area modified to: `配置/Configure`. > > ## Plugin Editor > * [ ] Some Auth plugins do not need to be configured, in the Data Editor, to disable the input of content. > * [ ] The button is not internationalized. > * [ ] Document button fits too close to JSON button. > * [ ] JSONSchema checks for error messages, which can be divided into: error message + view details. > * [ ] CodeMirror code error highlighting. > > ## Meta Raw data editor (Route List page) > * [ ] Button not internationalized. > * [ ] layout needs to be adjusted, with additional scrolling axes.   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1666: feat: improved plugin #1631
iamayushdas opened a new pull request #1666: URL: https://github.com/apache/apisix-dashboard/pull/1666 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** * [x] list page top title, add description: list of enabled plugins. * [x] list page, edit button in action area modified to: `配置/Configure`. **Related issues** fix/resolve #1631 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on issue #1664: feat: use gomega match assertion
gxthrj commented on issue #1664: URL: https://github.com/apache/apisix-dashboard/issues/1664#issuecomment-805961918 @Jaycean +1 `Gomega` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1631: improve Plugin & Plugin Editor & Meta Raw Data Editor module
iamayushdas commented on issue #1631: URL: https://github.com/apache/apisix-dashboard/issues/1631#issuecomment-805901923 Assign this to me. I am working on this. @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on issue #43: CRD definition of ApisixRoute/v2alpha1 is missing from charts/apisix-ingress-control/crds
gxthrj commented on issue #43: URL: https://github.com/apache/apisix-helm-chart/issues/43#issuecomment-805874117 @pioneer-hash Are you interested in submitting a PR about this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: reset etcd before every test run (#1648)
This is an automated email from the ASF dual-hosted git repository.
sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new c6c5d14 feat: reset etcd before every test run (#1648)
c6c5d14 is described below
commit c6c5d147ef3e63a87a5f238aac8597357d2589d4
Author: litesun
AuthorDate: Wed Mar 24 21:58:32 2021 +0800
feat: reset etcd before every test run (#1648)
---
web/cypress/support/index.js | 8
1 file changed, 8 insertions(+)
diff --git a/web/cypress/support/index.js b/web/cypress/support/index.js
index 5a97ea8..a1d4cfc 100644
--- a/web/cypress/support/index.js
+++ b/web/cypress/support/index.js
@@ -17,6 +17,14 @@
/* eslint-disable no-undef */
import './commands';
import '@cypress/code-coverage/support';
+const { SERVE_ENV = 'dev' } = Cypress.env();
+
+before(() => {
+ // reset etcd before test
+ if (SERVE_ENV === 'test') {
+cy.exec('etcdctl del --prefix /', { failOnNonZeroExit: false });
+ }
+});
Cypress.on('uncaught:exception', () => {
// returning false here prevents Cypress from
[GitHub] [apisix-dashboard] LiteSun merged pull request #1648: feat: reset etcd before every test run.
LiteSun merged pull request #1648: URL: https://github.com/apache/apisix-dashboard/pull/1648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1660: doc: Improve docs about route import and export
nic-chen commented on issue #1660: URL: https://github.com/apache/apisix-dashboard/issues/1660#issuecomment-805837910 > are there any existing documents can refer to ? > what about put some steps and screenshoots the document and list success and fails cases? updated. thanks for reminding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1663: feat: rewrite e2e test route with plugin orchestration test with ginkgo
nic-chen commented on a change in pull request #1663:
URL: https://github.com/apache/apisix-dashboard/pull/1663#discussion_r600485211
##
File path: api/test/e2enew/route/route_with_plugin_orchestration_test.go
##
@@ -14,100 +14,98 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package e2e
+package route
import (
"io/ioutil"
"net/http"
- "testing"
- "github.com/stretchr/testify/assert"
+ "github.com/onsi/ginkgo"
+ "github.com/onsi/ginkgo/extensions/table"
+ "github.com/onsi/gomega"
+
+ "github.com/apisix/manager-api/test/e2enew/base"
)
-func TestRoute_With_Plugin_Orchestration(t *testing.T) {
- bytes, err := ioutil.ReadFile("../testdata/dag-conf.json")
- assert.Nil(t, err)
+var _ = ginkgo.Describe("route with plugin orchestration", func() {
Review comment:
@tokers
It contains DP test, please see:
https://github.com/apache/apisix-dashboard/pull/1663/files#diff-b90858ef419a6b85e041becb1896e393f699a6e4c3c61ecd6b8822b3a2ffb22dR79-R88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] stu01509 opened a new pull request #270: Feat #266 speed up static file
stu01509 opened a new pull request #270: URL: https://github.com/apache/apisix-website/pull/270 Fixes: #266 Changes: speed up static file Screenshots of the change: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1633: feat: add the service page upstream select option
codecov-io edited a comment on pull request #1633: URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-803316539 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=h1) Report > Merging [#1633](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=desc) (59a97c4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc) (bec8f1b) will **increase** coverage by `1.55%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1633 +/- ## == + Coverage 72.48% 74.04% +1.55% == Files 133 86 -47 Lines5728 2612-3116 Branches 666 666 == - Hits 4152 1934-2218 + Misses 1332 678 -654 + Partials 2440 -244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `74.04% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | `61.53% <ø> (ø)` | | | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | | | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | | | [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | | | | ... and [38 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=footer). Last update [bec8f1b...59a97c4](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio commented on issue #1665: 当编辑已有路由，修改重定向这个内容，由禁用改为 启用https的时候，提交报10005
batman-ezio commented on issue #1665: URL: https://github.com/apache/apisix-dashboard/issues/1665#issuecomment-805793410 which version are you use? i find a fix at https://github.com/apache/apisix-dashboard/pull/1527 and will release soon at 2.5 version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3902: Do you have any development plans to get config data even when etcd is down, such as saving configuration files
tokers commented on issue #3902: URL: https://github.com/apache/apisix/issues/3902#issuecomment-805771583 In a production environment, multiple nodes (typically `3` or `5` nodes) ETCD cluster is desired, due to Raft consensus algorithm, it's not common if whole nodes in the cluster are down together, unless the networking is partitioned. Even in such a case, it doesn't influence APISIX's behavior since APISIX caches all config data in its per-worker process memory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1663: feat: rewrite e2e test route with plugin orchestration test with ginkgo
tokers commented on a change in pull request #1663:
URL: https://github.com/apache/apisix-dashboard/pull/1663#discussion_r600417361
##
File path: api/test/e2enew/route/route_with_plugin_orchestration_test.go
##
@@ -14,100 +14,98 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package e2e
+package route
import (
"io/ioutil"
"net/http"
- "testing"
- "github.com/stretchr/testify/assert"
+ "github.com/onsi/ginkgo"
+ "github.com/onsi/ginkgo/extensions/table"
+ "github.com/onsi/gomega"
+
+ "github.com/apisix/manager-api/test/e2enew/base"
)
-func TestRoute_With_Plugin_Orchestration(t *testing.T) {
- bytes, err := ioutil.ReadFile("../testdata/dag-conf.json")
- assert.Nil(t, err)
+var _ = ginkgo.Describe("route with plugin orchestration", func() {
Review comment:
Test cases here only check the admin API, but not concerned about the
data use in DP, it's not a closed loop, we may request DP to verify DP's
behaviors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on issue #44: After update the apisix-admin to NodePort, still can't visit it on local
tokers commented on issue #44: URL: https://github.com/apache/apisix-helm-chart/issues/44#issuecomment-805766526 @riskgod Please give your step to help us reproduce your problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on pull request #263: feat: broken link checker script
bzp2010 commented on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-805760521 The generic code in the link check module has been splited.(such as document path generation) The code in the document synchronization module will be implemented in the new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 edited a comment on pull request #263: feat: broken link checker script
bzp2010 edited a comment on pull request #263: URL: https://github.com/apache/apisix-website/pull/263#issuecomment-805760521 The common code in the link-checker module has been splited. (such as document path generation) The code in the document synchronization module will be implemented in the new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] bzp2010 commented on a change in pull request #263: feat: broken link checker script
bzp2010 commented on a change in pull request #263:
URL: https://github.com/apache/apisix-website/pull/263#discussion_r600407823
##
File path: link-checker.js
##
@@ -0,0 +1,186 @@
+const fs = require("fs");
+const path = require("path");
+const childProcess = require("child_process");
+
+const projects = ["apisix-ingress-controller", "apisix", "apisix-dashboard"];
Review comment:
The generic code in the link check module has been splited.(such as
document path generation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3903: request help: Accessing ctx.var.upstream_uri in global rule causes failure of proxy-rewrite
Firstsawyou commented on issue #3903: URL: https://github.com/apache/apisix/issues/3903#issuecomment-805742477 Hi, @Gary-Airwallex I did not reproduce this problem locally. I will provide a recurring use case later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3830: bug: [error] 43#43: init_worker_by_lua error: /usr/local/apisix/apisix/plugin.lua:264: attempt to index upvalue 'local_conf' (a nil value)
tokers commented on issue #3830: URL: https://github.com/apache/apisix/issues/3830#issuecomment-805739135 > thanks and waiting for this. @tokers Could you please provide the file permission of apisix config.yaml in the container. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3905: feat: support mTLS with etcd
spacewander opened a new pull request #3905: URL: https://github.com/apache/apisix/pull/3905 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3904: bug:
spacewander commented on issue #3904: URL: https://github.com/apache/apisix/issues/3904#issuecomment-805691501 Fixed by https://github.com/apache/apisix/pull/3394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] riskgod opened a new issue #44: After update the apisix-admin to NodePort, still can't visit it on local
riskgod opened a new issue #44: URL: https://github.com/apache/apisix-helm-chart/issues/44 Hey, I'm try to curl the apisix's api to define the router and the upsteams, but it failed(403 Forbidden) to call the local apisix's api, after research, is the allow_admin not setting in apisix's value.yaml? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ZanderMo opened a new issue #3904: bug:
ZanderMo opened a new issue #3904:
URL: https://github.com/apache/apisix/issues/3904
### Issue description
### Environment
* apisix version (cmd: `apisix version`): v2.2
config_center: yaml
apisix.yaml 配置 :
routes:
- uri: /systemconf/admin/*
upstream_id: 8014
plugins:
jwt-auth: {}
consumer-restriction: {
whitelist: [
admin
]
}
consumers:
- username: admin
plugins:
jwt-auth:
key: admin
secret: 123
- username: app
plugins:
jwt-auth:
key: app
secret: 123
jwt的key无论用admin还是app都提示
{"message":"The consumer_name is forbidden."}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] logonmy opened a new issue #1665: 当编辑已有路由，修改重定向这个内容，由禁用改为 启用https的时候，提交报10005
logonmy opened a new issue #1665: URL: https://github.com/apache/apisix-dashboard/issues/1665  看我的截图，提示，我是编辑已经存在的路由。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] anjia0532 commented on issue #3830: bug: [error] 43#43: init_worker_by_lua error: /usr/local/apisix/apisix/plugin.lua:264: attempt to index upvalue 'local_conf' (a nil value)
anjia0532 commented on issue #3830: URL: https://github.com/apache/apisix/issues/3830#issuecomment-805655176 thanks and waiting for this. @tokers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3894: feat: Add ldap-auth plugin
spacewander commented on pull request #3894: URL: https://github.com/apache/apisix/pull/3894#issuecomment-805626518 > The spirit of the license is that you are free to use LuaLDAP for any purpose at no cost without having to ask us. The only requirement is that if you do use LuaLDAP, then you should give us credit by including the appropriate copyright notice somewhere in your product or its documentation. IMHO, it seems we can use it after adding the copyright notice. There is the raw file of the License page: https://github.com/lualdap/lualdap/blob/master/docs/license.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on pull request #1657: fix: Removed the sample login from the landing page #1626
imjoey commented on pull request #1657: URL: https://github.com/apache/apisix-dashboard/pull/1657#issuecomment-805623346 @iamayushdas it's merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey closed issue #1626: improve Login module
imjoey closed issue #1626: URL: https://github.com/apache/apisix-dashboard/issues/1626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey merged pull request #1657: fix: Removed the sample login from the landing page #1626
imjoey merged pull request #1657: URL: https://github.com/apache/apisix-dashboard/pull/1657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: fix: Removed the sample login from the landing page #1626 (#1657)
This is an automated email from the ASF dual-hosted git repository.
majunjie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new bec8f1b fix: Removed the sample login from the landing page #1626
(#1657)
bec8f1b is described below
commit bec8f1bf020f99a12ac6e8137d624a54b37c18d4
Author: Ayush das
AuthorDate: Wed Mar 24 14:28:41 2021 +0530
fix: Removed the sample login from the landing page #1626 (#1657)
---
web/src/pages/User/Login.tsx | 3 +-
web/src/pages/User/Logout.tsx | 3 +-
.../pages/User/components/LoginMethodExample.tsx | 43 --
web/src/pages/User/locales/en-US.ts| 5 +--
web/src/pages/User/locales/zh-CN.ts| 2 -
5 files changed, 3 insertions(+), 53 deletions(-)
diff --git a/web/src/pages/User/Login.tsx b/web/src/pages/User/Login.tsx
index b9b33bb..799b3d4 100644
--- a/web/src/pages/User/Login.tsx
+++ b/web/src/pages/User/Login.tsx
@@ -20,7 +20,6 @@ import { Button, notification, Tabs } from 'antd';
import { SelectLang } from '@@/plugin-locale/SelectLang';
import { Link, useIntl, history } from 'umi';
import LoginMethodPassword from '@/pages/User/components/LoginMethodPassword';
-import LoginMethodExample from '@/pages/User/components/LoginMethodExample';
import type { UserModule } from '@/pages/User/typing';
import logo from '@/assets/logo.svg';
import { getUrlQuery } from '@/helpers';
@@ -32,7 +31,7 @@ const Tab = Tabs.TabPane;
/**
* Login Methods List
*/
-const loginMethods: UserModule.LoginMethod[] = [LoginMethodPassword,
LoginMethodExample];
+const loginMethods: UserModule.LoginMethod[] = [LoginMethodPassword];
/**
* User Login Page
diff --git a/web/src/pages/User/Logout.tsx b/web/src/pages/User/Logout.tsx
index d643061..6ea2333 100644
--- a/web/src/pages/User/Logout.tsx
+++ b/web/src/pages/User/Logout.tsx
@@ -17,14 +17,13 @@
import type React from 'react';
import LoginMethodPassword from '@/pages/User/components/LoginMethodPassword';
-import LoginMethodExample from '@/pages/User/components/LoginMethodExample';
import type { UserModule } from '@/pages/User/typing';
import { getUrlQuery } from '@/helpers';
/**
* Login Methods List
*/
-const loginMethods: UserModule.LoginMethod[] = [LoginMethodPassword,
LoginMethodExample];
+const loginMethods: UserModule.LoginMethod[] = [LoginMethodPassword];
/**
* User Logout Page
diff --git a/web/src/pages/User/components/LoginMethodExample.tsx
b/web/src/pages/User/components/LoginMethodExample.tsx
deleted file mode 100644
index afed587..000
--- a/web/src/pages/User/components/LoginMethodExample.tsx
+++ /dev/null
@@ -1,43 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-import React from 'react';
-import type { UserModule } from '@/pages/User/typing';
-import { formatMessage } from '@@/plugin-locale/localeExports';
-
-const LoginMethodExample: UserModule.LoginMethod = {
- id: 'example',
- name: formatMessage({ id: 'component.user.loginMethodExample' }),
- render: () => {
-return https://www.example.com";>example;
- },
- getData(): UserModule.LoginData {
-return {};
- },
- checkData: async () => {
-return true;
- },
- submit: async (data) => {
-return {
- status: false,
- message: formatMessage({ id: 'component.user.loginMethodExample.message'
}),
- data,
-};
- },
- logout() {},
-};
-
-export default LoginMethodExample;
diff --git a/web/src/pages/User/locales/en-US.ts
b/web/src/pages/User/locales/en-US.ts
index bdf6b9c..763f174 100644
--- a/web/src/pages/User/locales/en-US.ts
+++ b/web/src/pages/User/locales/en-US.ts
@@ -27,7 +27,4 @@ export default {
'component.user.loginMethodPassword.success': 'Login Success',
'component.user.loginMethodPassword.changeDefaultAccount': 'How to update
username/password?',
'component.user.loginMethodPassword.modificationMethod': 'Please modify the
users field in the /api/conf/conf.yaml file',
- 'component.user.loginMethodExample': 'Example',
- 'component.user.loginMethodExample.message':
-'Example Login Method, It is on
[GitHub] [apisix] Firstsawyou commented on issue #3903: request help: Accessing ctx.var.upstream_uri in global rule causes failure of proxy-rewrite
Firstsawyou commented on issue #3903: URL: https://github.com/apache/apisix/issues/3903#issuecomment-805622830 Not sure if this problem is fixed, maybe you can try the latest version. Let me check if I have this problem in the latest version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: add missing index of discovery (#3899)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 472ea3f docs: add missing index of discovery (#3899)
472ea3f is described below
commit 472ea3f1db52677f0c079c73345690a0d2b74d3f
Author: 罗泽轩
AuthorDate: Wed Mar 24 16:50:25 2021 +0800
docs: add missing index of discovery (#3899)
Also remove useless TOC
Signed-off-by: spacewander
---
docs/en/latest/config.json | 9 +
docs/en/latest/discovery.md | 13 -
2 files changed, 9 insertions(+), 13 deletions(-)
diff --git a/docs/en/latest/config.json b/docs/en/latest/config.json
index ff66c66..902ea8a 100644
--- a/docs/en/latest/config.json
+++ b/docs/en/latest/config.json
@@ -147,6 +147,15 @@
"label": "Others",
"items": [
{
+ "type": "category",
+ "label": "Discovery",
+ "items": [
+"discovery",
+"discovery/dns",
+"discovery/consul_kv"
+ ]
+},
+{
"type": "doc",
"id": "health-check"
},
diff --git a/docs/en/latest/discovery.md b/docs/en/latest/discovery.md
index b692151..9986723 100644
--- a/docs/en/latest/discovery.md
+++ b/docs/en/latest/discovery.md
@@ -21,19 +21,6 @@ title: Integration service discovery registry
#
-->
-* [**Summary**](#summary)
-* [**Supported discovery registries**](#supported-discovery-registries)
-* [**How to extend the discovery
client?**](#how-to-extend-the-discovery-client)
-* [**Basic steps**](#basic-steps)
-* [**the example of Eureka**](#the-example-of-eureka)
-* [**Implementation of eureka.lua**](#implementation-of-eurekalua)
-* [**How convert Eureka's instance data to APISIX's
node?**](#how-convert-eurekas-instance-data-to-apisixs-node)
-* [**Configuration for discovery client**](#configuration-for-discovery-client)
-* [**Initial service discovery**](#initial-service-discovery)
-* [**Configuration for Eureka**](#configuration-for-eureka)
-* [**Upstream setting**](#upstream-setting)
-* [**Embedded control api for debugging**](#embedded-control-api-for-debugging)
-
## Summary
When system traffic changes, the number of servers of the upstream service
also increases or decreases, or the server needs to be replaced due to its
hardware failure. If the gateway maintains upstream service information through
configuration, the maintenance costs in the microservices architecture pattern
are unpredictable. Furthermore, due to the untimely update of these
information, will also bring a certain impact for the business, and the impact
of human error operation can not be [...]
[GitHub] [apisix] spacewander merged pull request #3899: docs: add missing index of discovery
spacewander merged pull request #3899: URL: https://github.com/apache/apisix/pull/3899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1657: fix: Removed the sample login from the landing page #1626
iamayushdas commented on pull request #1657: URL: https://github.com/apache/apisix-dashboard/pull/1657#issuecomment-805614579 @juzhiyuan all 4 reviews have been done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1664: feat: use gomega match assertion
imjoey commented on issue #1664: URL: https://github.com/apache/apisix-dashboard/issues/1664#issuecomment-805594656 @Jaycean +1 for me. Gomega is a much better choice. Looking forward to this awesome improvements. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1624: Discussion: Is the name field required or not when BE create a route
imjoey commented on issue #1624: URL: https://github.com/apache/apisix-dashboard/issues/1624#issuecomment-805592495 Since #1647 has been merged which regards the route name as mandatory, we could close this issue for now. Please feel free to reopen this if anything is unexpected. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey closed issue #1624: Discussion: Is the name field required or not when BE create a route
imjoey closed issue #1624: URL: https://github.com/apache/apisix-dashboard/issues/1624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey merged pull request #1647: chore(BE): Change route name feild required
imjoey merged pull request #1647: URL: https://github.com/apache/apisix-dashboard/pull/1647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: chore(BE): Change route name feild required (#1647)
This is an automated email from the ASF dual-hosted git repository.
majunjie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 31700b3 chore(BE): Change route name feild required (#1647)
31700b3 is described below
commit 31700b355c6a106d915bf1823e21aca085c41d30
Author: JinChen
AuthorDate: Wed Mar 24 16:00:36 2021 +0800
chore(BE): Change route name feild required (#1647)
* chore: change route name feild required and add e2enew test name field
---
api/internal/core/entity/entity.go | 2 +-
api/internal/core/store/validate_test.go | 12 +++
api/test/e2e/balancer_test.go | 1 +
api/test/e2e/consumer_test.go | 2 ++
api/test/e2e/global_rule_test.go | 2 ++
api/test/e2e/id_compatible_test.go | 5 +++
api/test/e2e/json_schema_validate_test.go | 1 +
api/test/e2e/label_test.go | 1 +
api/test/e2e/route_export_test.go | 15 +---
api/test/e2e/route_remote_addr_test.go | 3 ++
api/test/e2e/route_service_upstream_test.go| 5 +++
api/test/e2e/route_test.go | 13 +++
api/test/e2e/route_with_management_fileds_test.go | 7
api/test/e2e/route_with_methods_test.go| 6
api/test/e2e/route_with_plugin_cors_test.go| 41 --
api/test/e2e/route_with_plugin_http_logger_test.go | 1 +
api/test/e2e/route_with_plugin_jwt_test.go | 2 ++
api/test/e2e/route_with_plugin_limit_count_test.go | 4 +++
.../e2e/skywalking/route_with_trace_plugin_test.go | 2 ++
.../e2enew/plugin_config/plugin_config_test.go | 1 +
api/test/e2enew/route/host_test.go | 9 +
.../route/route_with_plugin_prometheus_test.go | 2 ++
.../route/route_with_plugin_proxy_rewrite_test.go | 4 +++
api/test/e2enew/route/route_with_priority_test.go | 1 +
.../e2enew/route/route_with_script_luacode_test.go | 11 ++
api/test/e2enew/route/route_with_uri_uris_test.go | 2 ++
.../route/route_with_valid_remote_addr_test.go | 5 +++
api/test/e2enew/route/route_with_vars_test.go | 15 +---
.../route_online_debug/route_online_debug_test.go | 12 +--
api/test/e2enew/service/service_test.go| 3 ++
api/test/e2enew/ssl/ssl_test.go| 1 +
.../e2enew/upstream/upstream_chash_hash_on_test.go | 7 +++-
.../upstream_chash_query_string_arg_xxx_test.go| 2 ++
api/test/e2enew/upstream/upstream_test.go | 8 +
api/test/shell/manager_smoking.sh | 2 +-
35 files changed, 176 insertions(+), 34 deletions(-)
diff --git a/api/internal/core/entity/entity.go
b/api/internal/core/entity/entity.go
index d6c9516..c42d31f 100644
--- a/api/internal/core/entity/entity.go
+++ b/api/internal/core/entity/entity.go
@@ -73,7 +73,7 @@ type Route struct {
BaseInfo
URI string `json:"uri,omitempty"`
Uris[]string `json:"uris,omitempty"`
- Namestring `json:"name,omitempty"
validate:"max=50"`
+ Namestring `json:"name" validate:"max=50"`
Descstring `json:"desc,omitempty"
validate:"max=256"`
Priorityint`json:"priority,omitempty"`
Methods []string `json:"methods,omitempty"`
diff --git a/api/internal/core/store/validate_test.go
b/api/internal/core/store/validate_test.go
index 0bc549b..795fab3 100644
--- a/api/internal/core/store/validate_test.go
+++ b/api/internal/core/store/validate_test.go
@@ -147,6 +147,7 @@ func TestAPISIXJsonSchemaValidator_checkUpstream(t
*testing.T) {
route := &entity.Route{}
reqBody := `{
"id": "1",
+ "name": "route1",
"methods": ["GET"],
"upstream": {
"nodes": {
@@ -167,6 +168,7 @@ func TestAPISIXJsonSchemaValidator_checkUpstream(t
*testing.T) {
route2 := &entity.Route{}
reqBody = `{
"id": "1",
+ "name": "route1",
"methods": ["GET"],
"upstream": {
"nodes": {
@@ -187,6 +189,7 @@ func TestAPISIXJsonSchemaValidator_checkUpstream(t
*testing.T) {
route3 := &entity.Route{}
reqBody = `{
"id": "1",
+ "name": "route1",
"methods": ["GET"],
"upstream": {
"nodes": {
@@ -208,6 +211,7 @@ func TestAPISIXJsonSchemaValidator_checkUpstream(t
*testing.T) {
route4 := &entity.Route{}
reqBody = `{
"id": "1",
+ "name": "route1",
"methods": ["GET"],
"upstream"
[GitHub] [apisix] Firstsawyou commented on issue #3893: request help: openid-connect plugin 401 Unauthorized
Firstsawyou commented on issue #3893: URL: https://github.com/apache/apisix/issues/3893#issuecomment-805588129 > I had set bearer_only : true，still get 401 code and i cannot redirect wso2 login page ，i can get authorization code successfully when set `"bearer_only": false`, the question is whether this plugin can check wso2 jwt token，how it works in use introspection_endpoint? i can not find the code block check this token from lua source code，maybe tell me how can i debugger api six in local You can try to debug in the following code file: https://github.com/apache/apisix/blob/master/apisix/plugins/openid-connect.lua `apisix/deps/share/lua/5.1/resty/openidc.lua` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zcgewu commented on issue #3901: bug: vars cookie route match failure 高级路由匹配条件，apisix运行时间久了路由匹配条件失效
zcgewu commented on issue #3901:
URL: https://github.com/apache/apisix/issues/3901#issuecomment-805585457
> Feel free to reopen this issue if you can reproduce it in the latest
APISIX.
我们在测试和线上环境都重现了，你看下是否跟多次执行【PUT】/apisix/admin/routes/{id} 接口有关系
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3899: docs: add missing index of discovery
spacewander commented on a change in pull request #3899:
URL: https://github.com/apache/apisix/pull/3899#discussion_r600243075
##
File path: docs/en/latest/config.json
##
@@ -146,6 +146,15 @@
"type": "category",
"label": "Others",
"items": [
+{
+ "type": "category",
+ "label": "discovery",
Review comment:
@juzhiyuan
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Gary-Airwallex opened a new issue #3903: request help: Accessing ctx.var.upstream_uri in global rule causes failure of proxy-rewrite
Gary-Airwallex opened a new issue #3903: URL: https://github.com/apache/apisix/issues/3903 ### Issue description Minimum steps to reproduce: In `init.lua`, add ### Environment * apisix version (cmd: `apisix version`): * OS (cmd: `uname -a`): * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): * apisix-dashboard version, if have: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #3883: feat: add 5xx error page
starsz commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r600238296
##
File path: t/cli/test_error_page.sh
##
@@ -0,0 +1,63 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# 'make init' operates scripts and related configuration files in the current
directory
+# The 'apisix' command is a command in the /usr/local/apisix,
+# and the configuration file for the operation is in the /usr/local/apisix/conf
+
+. ./t/cli/common.sh
+
+git checkout conf/config.yaml
+make init
+
+make run
+sleep 0.1
+
+# set route
+code=$(curl -XPUT -k -i -m 20 -o /dev/null -s -w %{http_code}
http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -d '{
+"uri": "/error_page",
+"plugins": {
+"serverless-pre-function": {
+"phase": "rewrite",
+"functions" : ["return function() local status =
ngx.var.http_X_Test_Status ;ngx.exit(tonumber(status));end"]
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #3883: feat: add 5xx error page
starsz commented on a change in pull request #3883: URL: https://github.com/apache/apisix/pull/3883#discussion_r600237896 ## File path: t/cli/test_error_page.sh ## @@ -0,0 +1,63 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# 'make init' operates scripts and related configuration files in the current directory +# The 'apisix' command is a command in the /usr/local/apisix, +# and the configuration file for the operation is in the /usr/local/apisix/conf + +. ./t/cli/common.sh + +git checkout conf/config.yaml +make init Review comment: OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #3883: feat: add 5xx error page
starsz commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r600237702
##
File path: apisix/error_handler.lua
##
@@ -0,0 +1,54 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local ngx = ngx
+
+
+local html_5xx = [[
+
+
+
+
+
+Error
+
+body {
+width: 35em;
+margin: 0 auto;
+font-family: Tahoma, Verdana, Arial, sans-serif;
+}
+
+
+
+An error occurred.
+Sorry, the page you are looking for is currently unavailable.
+Please try again later.
+If you are the system administrator of this resource then you should check
+the https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L135";>error
log
Review comment:
Is permalink really good? Because permalink contains the commit info.
Maybe we need a doc to introduce the config. So that I can add the link to
the error page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #3883: feat: add 5xx error page
starsz commented on a change in pull request #3883: URL: https://github.com/apache/apisix/pull/3883#discussion_r600235923 ## File path: t/cli/test_error_page.sh ## @@ -0,0 +1,63 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# 'make init' operates scripts and related configuration files in the current directory Review comment: OK.Got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #3883: feat: add 5xx error page
starsz commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r600234800
##
File path: t/cli/test_error_page.sh
##
@@ -0,0 +1,63 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# 'make init' operates scripts and related configuration files in the current
directory
+# The 'apisix' command is a command in the /usr/local/apisix,
+# and the configuration file for the operation is in the /usr/local/apisix/conf
+
+. ./t/cli/common.sh
+
+git checkout conf/config.yaml
+make init
+
+make run
+sleep 0.1
+
+# set route
+code=$(curl -XPUT -k -i -m 20 -o /dev/null -s -w %{http_code}
http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -d '{
+"uri": "/error_page",
+"plugins": {
+"serverless-pre-function": {
+"phase": "rewrite",
+"functions" : ["return function() local status =
ngx.var.http_X_Test_Status ;ngx.exit(tonumber(status));end"]
+}
+}
+}')
+if [ ! $code -eq 201 ]; then
+echo "failed: add route failed"
+exit 1
+fi
+
+sleep 0.1
+# test 5xx html
+for status in 500 502 503 504;
+do
+resp=$(curl http://127.0.0.1:9080/error_page -H 'X-Test-Status: '${status})
+if [[ `echo $resp | grep -c "apisix.apache.org"` -eq '0' ]]; then
+ echo "failed: the error page is not customized"
+ exit 1
+fi
+done
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3899: docs: add missing index of discovery
juzhiyuan commented on a change in pull request #3899:
URL: https://github.com/apache/apisix/pull/3899#discussion_r600229552
##
File path: docs/en/latest/config.json
##
@@ -146,6 +146,15 @@
"type": "category",
"label": "Others",
"items": [
+{
+ "type": "category",
+ "label": "discovery",
Review comment:
Do we need to use the UpperCase? Like Discovery
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3900: fix: allow addr:port format in stream_proxy
spacewander commented on pull request #3900: URL: https://github.com/apache/apisix/pull/3900#issuecomment-805569720 @Firstsawyou Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3902: Do you have any development plans to get config data even when etcd is down, such as saving configuration files
spacewander commented on issue #3902: URL: https://github.com/apache/apisix/issues/3902#issuecomment-805563628 At least not in the near future. It is hard to get it right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (654b1a9 -> fb358e5)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 654b1a9 fix: corrent SRV record priority (#3896) add fb358e5 fix: priority for nonarray upstream node in stream (#3897) No new revisions were added by this update. Summary of changes: apisix/upstream.lua | 13 +++- t/stream-node/priority-balancer.t | 158 ++ 2 files changed, 167 insertions(+), 4 deletions(-) create mode 100644 t/stream-node/priority-balancer.t
