[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
bisakhmondal commented on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-808664239 Okay, @Jaycean, I'm opening an issue. See the ci is also failing with a 404 for that particular test.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
bisakhmondal edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-808663653 pinging @nic-chen for review when you have time. ps. reverted all the changes made to manger-api back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1667: feat: run manager-api as a systemd daemon/service
bisakhmondal commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-808663653 ping @nic-chen for review when you have time. ps. reverted all the changes made to manger-api back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #312: bug: Modify the route.yaml configuration to not update apisix synchronously
tokers commented on issue #312: URL: https://github.com/apache/apisix-ingress-controller/issues/312#issuecomment-808662482 It seems that the route synchronization logic is pathological, we may fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #312: bug: Modify the route.yaml configuration to not update apisix synchronously
gxthrj commented on issue #312: URL: https://github.com/apache/apisix-ingress-controller/issues/312#issuecomment-808658420 Do you have any error logs in the container of INGRESS ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #315: fix: make ingress controller compatible with ingress.extensions/v1beta1
codecov-io edited a comment on pull request #315: URL: https://github.com/apache/apisix-ingress-controller/pull/315#issuecomment-808636332 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=h1) Report > Merging [#315](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=desc) (026040d) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b5cba04a9039ba47cb4991102ba80cbcf653db8b?el=desc) (b5cba04) will **increase** coverage by `45.74%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #315 +/- ## + Coverage 54.25% 100.00% +45.74% Files 35 1 -34 Lines2479 1 -2478 - Hits 1345 1 -1344 + Misses974 0 -974 + Partials 160 0 -160 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/version/version.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL3ZlcnNpb24vdmVyc2lvbi5nbw==) | | | | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | | | | [pkg/seven/state/route\_worker.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL3JvdXRlX3dvcmtlci5nbw==) | | | | [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | | | | [pkg/types/errors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL3R5cGVzL2Vycm9ycy5nbw==) | | | | [pkg/id/idgen.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2lkL2lkZ2VuLmdv) | | | | [pkg/log/default\_logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2xvZy9kZWZhdWx0X2xvZ2dlci5nbw==) | | | | [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | | | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | | | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | | | | ... and [21 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=footer). Last update [b5cba04...026040d](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3820: feat: add nacos support
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r602672250
##
File path: .travis/linux_tengine_runner.sh
##
@@ -40,6 +40,9 @@ before_install() {
# start consul servers
docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul agent
-server -bootstrap-expect=1 -client 0.0.0.0 -log-level info
-data-dir=/consul/data
docker run --rm --name consul_2 -d -p 8600:8500 consul:1.7 consul agent
-server -bootstrap-expect=1 -client 0.0.0.0 -log-level info
-data-dir=/consul/data
+
+# start nacos server
+docker run --rm --name nacos_1 -d --env PREFER_HOST_MODE=hostname --env
MODE=standalone --env JVM_XMS=512m --env JVM_XMX=512m --env JVM_XMN=256m
-p8848:8848 nacos/nacos-server:latest
Review comment:
You can export the auth function:
https://github.com/apache/apisix/pull/3820/files#diff-46fd008790f9ea29612a92ca5c94212ae43c81ab6b902ef3014d3d6b4bdfc5b3R202
and call it in the test file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers merged pull request #48: fix: updated the apisixroute definition (add v2alpha1 version)
tokers merged pull request #48: URL: https://github.com/apache/apisix-helm-chart/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated: fix: updated the apisixroute definition (add v2alpha1 version) (#48)
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 8900b83 fix: updated the apisixroute definition (add v2alpha1 version) (#48) 8900b83 is described below commit 8900b83af66312ac75667f4dcd342f70eb0b0653 Author: Alex Zhang AuthorDate: Sat Mar 27 13:02:42 2021 +0800 fix: updated the apisixroute definition (add v2alpha1 version) (#48) --- charts/apisix-ingress-controller/Chart.yaml | 2 +- charts/apisix-ingress-controller/crds/customresourcedefinitions.yaml | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/charts/apisix-ingress-controller/Chart.yaml b/charts/apisix-ingress-controller/Chart.yaml index 66d61cd..c491dd2 100644 --- a/charts/apisix-ingress-controller/Chart.yaml +++ b/charts/apisix-ingress-controller/Chart.yaml @@ -24,5 +24,5 @@ keywords: - nginx - crd type: application -version: 0.2.0 +version: 0.3.0 appVersion: 0.4.0 diff --git a/charts/apisix-ingress-controller/crds/customresourcedefinitions.yaml b/charts/apisix-ingress-controller/crds/customresourcedefinitions.yaml index 58544a0..bbbe99f 100644 --- a/charts/apisix-ingress-controller/crds/customresourcedefinitions.yaml +++ b/charts/apisix-ingress-controller/crds/customresourcedefinitions.yaml @@ -24,6 +24,9 @@ spec: versions: - name: v1 served: true + storage: false +- name: v2alpha1 + served: true storage: true scope: Namespaced names:
[GitHub] [apisix-helm-chart] tokers opened a new pull request #48: fix: updated the apisixroute definition (add v2alpha1 version)
tokers opened a new pull request #48: URL: https://github.com/apache/apisix-helm-chart/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support
benx203 commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r602668288
##
File path: .travis/linux_tengine_runner.sh
##
@@ -40,6 +40,9 @@ before_install() {
# start consul servers
docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul agent
-server -bootstrap-expect=1 -client 0.0.0.0 -log-level info
-data-dir=/consul/data
docker run --rm --name consul_2 -d -p 8600:8500 consul:1.7 consul agent
-server -bootstrap-expect=1 -client 0.0.0.0 -log-level info
-data-dir=/consul/data
+
+# start nacos server
+docker run --rm --name nacos_1 -d --env PREFER_HOST_MODE=hostname --env
MODE=standalone --env JVM_XMS=512m --env JVM_XMX=512m --env JVM_XMN=256m
-p8848:8848 nacos/nacos-server:latest
Review comment:
But if nacos start with auth mode,in nacos.t add services to nacos need
send auth token.
How can i save auth token in nacos.t?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #230: docs: tell users where they are
iamayushdas commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-808649010 https://github.com/apache/apisix-ingress-controller/pull/316 have i done this right. i am not sure. i have read the documentation of Docusaurus as suggested by @juzhiyuan . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #316: docs: tells users where they are
codecov-io commented on pull request #316: URL: https://github.com/apache/apisix-ingress-controller/pull/316#issuecomment-808648200 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316?src=pr=h1) Report > Merging [#316](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316?src=pr=desc) (7445bb6) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/16e309b5971a92920d01f4c522d9a215fea6cb02?el=desc) (16e309b) will **increase** coverage by `2.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316?src=pr=tree) ```diff @@Coverage Diff @@ ## master #316 +/- ## == + Coverage 52.21% 54.23% +2.01% == Files 33 34 +1 Lines2321 2478 +157 == + Hits 1212 1344 +132 - Misses952 974 +22 - Partials 157 160 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316?src=pr=tree) | Coverage Δ | | |---|---|---| | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316/diff?src=pr=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | | | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | `100.00% <0.00%> (ø)` | | | [pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv) | `100.00% <0.00%> (ø)` | | | [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `78.00% <0.00%> (+0.22%)` | :arrow_up: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `41.29% <0.00%> (+0.76%)` | :arrow_up: | | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `56.06% <0.00%> (+3.03%)` | :arrow_up: | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `30.34% <0.00%> (+30.34%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316?src=pr=footer). Last update [16e309b...7445bb6](https://codecov.io/gh/apache/apisix-ingress-controller/pull/316?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] iamayushdas opened a new pull request #316: docs: tells users where they are
iamayushdas opened a new pull request #316: URL: https://github.com/apache/apisix-ingress-controller/pull/316 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description tells users where they are in sidebar - How to fix? added a label of Apisix ingress controller to sidebar ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch https://github.com/iamayushdas/apisix-ingress-controller/tree/master - Related commits and pull requests https://github.com/apache/apisix-website/issues/230 - Target branch https://github.com/apache/apisix-ingress-controller/tree/master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1674: feat: improved plugin #1631
iamayushdas edited a comment on pull request #1674: URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808124365 @nic-chen @juzhiyuan @LiteSun @guoqqqi can i have the review please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3912: fix(error-log-logger): the logger should be run in each process
spacewander merged pull request #3912: URL: https://github.com/apache/apisix/pull/3912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3911: bug: error-log-logger call ngx.worker.id() in privileged agent
spacewander closed issue #3911: URL: https://github.com/apache/apisix/issues/3911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: chore: remove unused shared dict (#3918)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new c9df9fc chore: remove unused shared dict (#3918)
c9df9fc is described below
commit c9df9fca652d14d32c8331820640ed9344c4529a
Author: 罗泽轩
AuthorDate: Sat Mar 27 11:39:32 2021 +0800
chore: remove unused shared dict (#3918)
Signed-off-by: spacewander
---
apisix/cli/ngx_tpl.lua | 1 -
t/APISIX.pm| 1 -
2 files changed, 2 deletions(-)
diff --git a/apisix/cli/ngx_tpl.lua b/apisix/cli/ngx_tpl.lua
index 00cda09..b1e95a7 100644
--- a/apisix/cli/ngx_tpl.lua
+++ b/apisix/cli/ngx_tpl.lua
@@ -133,7 +133,6 @@ http {
lua_shared_dict upstream-healthcheck 10m;
lua_shared_dict worker-events10m;
lua_shared_dict lrucache-lock10m;
-lua_shared_dict skywalking-tracing-buffer100m;
lua_shared_dict balancer_ewma10m;
lua_shared_dict balancer_ewma_locks 10m;
lua_shared_dict balancer_ewma_last_touched_at 10m;
diff --git a/t/APISIX.pm b/t/APISIX.pm
index 060394e..2c96712 100644
--- a/t/APISIX.pm
+++ b/t/APISIX.pm
@@ -386,7 +386,6 @@ _EOC_
lua_shared_dict upstream-healthcheck 32m;
lua_shared_dict worker-events10m;
lua_shared_dict lrucache-lock10m;
-lua_shared_dict skywalking-tracing-buffer100m;
lua_shared_dict balancer_ewma 1m;
lua_shared_dict balancer_ewma_locks 1m;
lua_shared_dict balancer_ewma_last_touched_at 1m;
[GitHub] [apisix] spacewander merged pull request #3918: chore: remove unused shared dict
spacewander merged pull request #3918: URL: https://github.com/apache/apisix/pull/3918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3820: feat: add nacos support
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r602663539
##
File path: .travis/linux_tengine_runner.sh
##
@@ -40,6 +40,9 @@ before_install() {
# start consul servers
docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul agent
-server -bootstrap-expect=1 -client 0.0.0.0 -log-level info
-data-dir=/consul/data
docker run --rm --name consul_2 -d -p 8600:8500 consul:1.7 consul agent
-server -bootstrap-expect=1 -client 0.0.0.0 -log-level info
-data-dir=/consul/data
+
+# start nacos server
+docker run --rm --name nacos_1 -d --env PREFER_HOST_MODE=hostname --env
MODE=standalone --env JVM_XMS=512m --env JVM_XMX=512m --env JVM_XMN=256m
-p8848:8848 nacos/nacos-server:latest
Review comment:
If the auth enable nacos can be used, the auth is successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix] branch master updated: fix(error-log-logger): the logger should be run in each process (#3912)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 95d313e fix(error-log-logger): the logger should be run in each
process (#3912)
95d313e is described below
commit 95d313ecf2efaa99a3b64948ae2e5a8b34f7aa65
Author: 罗泽轩
AuthorDate: Sat Mar 27 11:39:17 2021 +0800
fix(error-log-logger): the logger should be run in each process (#3912)
---
apisix/plugins/error-log-logger.lua | 9 +++--
t/plugin/error-log-logger.t | 1 +
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/apisix/plugins/error-log-logger.lua
b/apisix/plugins/error-log-logger.lua
index c2d6d74..70d5b1c 100644
--- a/apisix/plugins/error-log-logger.lua
+++ b/apisix/plugins/error-log-logger.lua
@@ -73,7 +73,7 @@ local log_level = {
local config = {}
-local buffers = {}
+local log_buffer
local _M = {
@@ -149,7 +149,6 @@ local function process()
end
-local id = ngx.worker.id()
local entries = {}
local logs = errlog.get_logs(9)
while ( logs and #logs>0 ) do
@@ -164,7 +163,6 @@ local function process()
return
end
-local log_buffer = buffers[id]
if log_buffer then
for _, v in ipairs(entries) do
log_buffer:push(v)
@@ -189,7 +187,6 @@ local function process()
return
end
-buffers[id] = log_buffer
for _, v in ipairs(entries) do
log_buffer:push(v)
end
@@ -198,12 +195,12 @@ end
function _M.init()
-timers.register_timer("plugin#error-log-logger", process, true)
+timers.register_timer("plugin#error-log-logger", process)
end
function _M.destroy()
-timers.unregister_timer("plugin#error-log-logger", true)
+timers.unregister_timer("plugin#error-log-logger")
end
diff --git a/t/plugin/error-log-logger.t b/t/plugin/error-log-logger.t
index 7c139a1..3ecbd0c 100644
--- a/t/plugin/error-log-logger.t
+++ b/t/plugin/error-log-logger.t
@@ -19,6 +19,7 @@ use t::APISIX 'no_plan';
repeat_each(1);
no_long_string();
no_root_location();
+master_on();
add_block_preprocessor(sub {
my ($block) = @_;
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #315: fix: make ingress controller compatible with ingress.extensions/v1beta1
codecov-io commented on pull request #315: URL: https://github.com/apache/apisix-ingress-controller/pull/315#issuecomment-808636332 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=h1) Report > Merging [#315](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=desc) (f56e3d2) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b5cba04a9039ba47cb4991102ba80cbcf653db8b?el=desc) (b5cba04) will **decrease** coverage by `14.96%`. > The diff coverage is `80.59%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #315 +/- ## === - Coverage 54.25% 39.28% -14.97% === Files 35 41+6 Lines2479 3576 +1097 === + Hits 1345 1405 +60 - Misses974 2010 +1036 - Partials 160 161+1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/ingress/controller/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci9jb250cm9sbGVyLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `81.81% <75.00%> (+1.33%)` | :arrow_up: | | [pkg/ingress/controller/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci9pbmdyZXNzLmdv) | `8.76% <91.66%> (ø)` | | | [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `91.92% <91.89%> (-0.02%)` | :arrow_down: | | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `75.94% <100.00%> (+1.62%)` | :arrow_up: | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | | | [pkg/ingress/controller/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci9zZWNyZXQuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci9hcGlzaXhfdXBzdHJlYW0uZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci9hcGlzaXhfcm91dGUuZ28=) | `0.00% <0.00%> (ø)` | | | ... and [4 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=footer). Last update [b5cba04...f56e3d2](https://codecov.io/gh/apache/apisix-ingress-controller/pull/315?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1633: feat: add the service page upstream select option
codecov-io edited a comment on pull request #1633: URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-803316539 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=h1) Report > Merging [#1633](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=desc) (125518a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc) (bec8f1b) will **decrease** coverage by `10.57%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1633 +/- ## === - Coverage 72.48% 61.90% -10.58% === Files 133 47 -86 Lines5728 3116 -2612 Branches 6660 -666 === - Hits 4152 1929 -2223 + Misses 1332 874 -458 - Partials 244 313 +69 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.90% <ø> (ø)` | | | backend-e2e-test-ginkgo | `48.45% <ø> (+0.41%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `47.22% <0.00%> (-30.56%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-29.57%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.43% <0.00%> (-29.52%)` | :arrow_down: | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `64.51% <0.00%> (-19.36%)` | :arrow_down: | | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | `59.57% <0.00%> (-18.09%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `44.82% <0.00%> (-13.80%)` | :arrow_down: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `77.14% <0.00%> (-13.58%)` | :arrow_down: | | ... and [96 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=footer). Last update [bec8f1b...125518a](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1633: feat: add the service page upstream select option
codecov-io edited a comment on pull request #1633: URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-803316539 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=h1) Report > Merging [#1633](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=desc) (125518a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc) (bec8f1b) will **decrease** coverage by `24.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1633 +/- ## === - Coverage 72.48% 48.45% -24.03% === Files 133 47 -86 Lines5728 3116 -2612 Branches 6660 -666 === - Hits 4152 1510 -2642 + Misses 1332 1319 -13 - Partials 244 287 +43 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `48.45% <ø> (+0.41%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `36.11% <0.00%> (-41.67%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `56.02% <0.00%> (-31.93%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-29.57%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `65.95% <0.00%> (-25.54%)` | :arrow_down: | | ... and [102 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=footer). Last update [bec8f1b...125518a](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #315: fix: make ingress controller compatible with ingress.extensions/v1beta1
tokers opened a new pull request #315: URL: https://github.com/apache/apisix-ingress-controller/pull/315 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues #313 ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio commented on a change in pull request #1672: doc: add more details and examples to import openapi guide
batman-ezio commented on a change in pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#discussion_r602655880 ## File path: docs/en/latest/IMPORT_OPENAPI_USER_GUIDE.md ## @@ -21,34 +21,21 @@ title: Import OpenAPI Guide # --> -The OpenAPI Specification (OAS) defines a standard, language-agnostic interface to RESTful APIs which allows both humans and computers to discover and understand the capabilities of the service without access to source code, documentation, or through network traffic inspection. - -Apache APISIX Dashboard supports importing [OpenApi3.0](https://swagger.io/specification/)(we will use OAS3.0 for short) files to create the Route. Currently we support support most of the OpenApi specifications, but there are some differences, which are in terms of compatibility and extended fields. - -## OAS3.0 Compatibility - -when we import routes from OAS3.0, some fields in OAS will be missed because there are not corresponding fields in APISIX's Route: - -1. [API General Info](https://swagger.io/docs/specification/api-general-info/): used to describe the general information about your API, some times, a oas file contains a series of apis which belong to a app, so this info is different from the api's name and extra basic info. - -2. [API server and base path](https://swagger.io/docs/specification/api-host-and-base-path/): upsream url + url prefix(options). - -3. [Path params](https://swagger.io/docs/specification/describing-parameters/): api params described in path. +## Overview -4. [Query params](https://swagger.io/docs/specification/describing-parameters/): api params described in query. +The OpenAPI Specification (OAS) defines a standard, language-agnostic interface to RESTful APIs which allows both humans and computers to discover and understand the capabilities of the service without access to source code, documentation, or through network traffic inspection. -5. [Responses description and links](https://swagger.io/docs/specification/describing-responses/): Define the responses for a API operations. +Apache APISIX Dashboard supports importing [OpenApi3.0](https://swagger.io/specification/)(we will use OAS3.0 for short) files, both `json` and `yaml` are supported, to create one or more Routes. Currently we support most of the OpenApi specifications, but there are some differences, which are in terms of compatibility and extended fields. ## Extended fields -There are some fields required in APISIX Route but are not included in the properties of OAS3.0, we added some extended fields such as upstream, plugins, hosts and so on. All extensions start with x-apisix. See [reference](https://apisix.apache.org/docs/apisix/admin-api/#route) For more details of the APISIX Route Properties +There are some fields required in APISIX Route but are not included in the properties of OAS3.0, inorder to provide convenience for extending custom route entities based on OAS3.0, we added some extended fields such as upstream, plugins, hosts and so on. All extensions start with x-apisix. See [reference](https://apisix.apache.org/docs/apisix/admin-api/#route) For more details of the APISIX Route Properties Review comment: inorder to `in order to ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support
benx203 commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r602649771
##
File path: .travis/linux_tengine_runner.sh
##
@@ -40,6 +40,9 @@ before_install() {
# start consul servers
docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul agent
-server -bootstrap-expect=1 -client 0.0.0.0 -log-level info
-data-dir=/consul/data
docker run --rm --name consul_2 -d -p 8600:8500 consul:1.7 consul agent
-server -bootstrap-expect=1 -client 0.0.0.0 -log-level info
-data-dir=/consul/data
+
+# start nacos server
+docker run --rm --name nacos_1 -d --env PREFER_HOST_MODE=hostname --env
MODE=standalone --env JVM_XMS=512m --env JVM_XMX=512m --env JVM_XMN=256m
-p8848:8848 nacos/nacos-server:latest
Review comment:
How to check nacos in discovery plugin whether authed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1679: feat: autocomplete when people input http header
juzhiyuan commented on pull request #1679: URL: https://github.com/apache/apisix-dashboard/pull/1679#issuecomment-808593293 BTW, @guoqqqi, would you have time to guide @qian0817 to write E2E tests for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1678: chore: use gomega match assertion
codecov-io edited a comment on pull request #1678: URL: https://github.com/apache/apisix-dashboard/pull/1678#issuecomment-808093117 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=h1) Report > Merging [#1678](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=desc) (1f3a9c7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/88f323285f2bdbafca027da9aef357b2e3eb4008?el=desc) (88f3232) will **increase** coverage by `1.62%`. > The diff coverage is `n/a`. > :exclamation: Current head 1f3a9c7 differs from pull request most recent head 5315aad. Consider uploading reports for the commit 5315aad to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1678 +/- ## == + Coverage 72.41% 74.04% +1.62% == Files 133 86 -47 Lines5728 2612-3116 Branches 666 666 == - Hits 4148 1934-2214 + Misses 1337 678 -659 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `74.04% <ø> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | | | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | | | | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | | | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | | | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | | | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | | | | ... and [38 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=footer). Last update [88f3232...5315aad](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
Jaycean commented on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-808400367 > Hello guys, > > Can't we edit the URI of a route after it has been created? We can, right? > > It seems when we are editing/adding the existing/new URI nginx putting a 404 error, not the apisix. > > it is how apisix put error for forbidden methods or non-existing URI > (before updating the URI) > >  > > But here (after editing) > >  > > Am I missing something here? > Thanks I have just tested in my local area, and there is no 404 error, so I think you can create a new issue and write out the created data and process. Let's discuss this problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1678: chore: use gomega match assertion
Jaycean commented on a change in pull request #1678:
URL: https://github.com/apache/apisix-dashboard/pull/1678#discussion_r602430883
##
File path: api/test/e2enew/upstream/upstream_chash_query_string_arg_xxx_test.go
##
@@ -197,7 +193,7 @@ var _ = ginkgo.Describe("Upstream chash query string",
func() {
counts = append(counts, value)
}
sort.Ints(counts)
- assert.True(t, float64(counts[2]-counts[0])/float64(counts[1])
< 0.4)
+ gomega.Expect(float64(counts[2]-counts[0])/float64(counts[1]) <
0.4).Should(gomega.BeTrue())
Review comment:
nice suggestions, Thks, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1678: chore: use gomega match assertion
Jaycean commented on a change in pull request #1678:
URL: https://github.com/apache/apisix-dashboard/pull/1678#discussion_r602430807
##
File path: api/test/e2enew/service/service_test.go
##
@@ -139,12 +135,11 @@ var _ = ginkgo.Describe("create service without plugin",
func() {
})
})
ginkgo.It("batch test /server_port api", func() {
- t := ginkgo.GinkgoT()
time.Sleep(time.Duration(500) * time.Millisecond)
res := base.BatchTestServerPort(18)
- assert.True(t, res["1980"] == 3)
- assert.True(t, res["1981"] == 6)
- assert.True(t, res["1982"] == 9)
+ gomega.Expect(res["1980"] == 3).Should(gomega.BeTrue())
+ gomega.Expect(res["1981"] == 6).Should(gomega.BeTrue())
+ gomega.Expect(res["1982"] == 9).Should(gomega.BeTrue())
Review comment:
nice suggestions, Thks, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
bisakhmondal commented on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-808342453 Hello guys, Can't we edit the URI of a route after it has been created? We can, right? It seems when we are editing/adding the existing/new URI nginx putting a 404 error, not the apisix. it is how apisix put error for forbidden methods or non-existing URI (before updating the URI)  But here (after editing)  Am I missing something here? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1633: feat: add the service page upstream select option
guoqqqi commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r602412604
##
File path:
web/cypress/integration/route/can-skip-upstream-when-select-service-id.spec.js
##
@@ -89,7 +89,7 @@ context('Can select service_id skip upstream in route', () =>
{
cy.contains('None').click();
cy.contains('Next').click();
cy.get(this.domSelector.upstream_id).click();
-cy.contains('None').should('not.exist');
+cy.contains('None').should('exist');
Review comment:
```suggestion
cy.contains('None').should('not.exist');
```
CI error
##
File path:
web/cypress/integration/route/can-skip-upstream-when-select-service-id.spec.js
##
@@ -58,7 +58,7 @@ context('Can select service_id skip upstream in route', () =>
{
cy.get(this.domSelector.name).type(this.data.routeName);
cy.contains('Next').click();
cy.get(this.domSelector.upstreamSelector).click();
-cy.contains('None').should('not.exist');
+cy.contains('None').should('exist');
Review comment:
```suggestion
cy.contains('None').should('not.exist');
```
CI error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1679: feat: autocomplete when people input http header
qian0817 commented on pull request #1679: URL: https://github.com/apache/apisix-dashboard/pull/1679#issuecomment-808332014 I'm confused why the behavior of component input and autocomplete appear inconsistent when delete form item. 樂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1677: feat: rewrite e2e test route with plugin limit count test with ginkgo
Jaycean commented on pull request #1677: URL: https://github.com/apache/apisix-dashboard/pull/1677#issuecomment-808332156 > Hi, you could request proper reviewers :) ok, Thks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #311: fix: workqueue need to retry when failed
gxthrj merged pull request #311: URL: https://github.com/apache/apisix-ingress-controller/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #311: fix: workqueue need to retry when failed
gxthrj commented on a change in pull request #311:
URL:
https://github.com/apache/apisix-ingress-controller/pull/311#discussion_r602386231
##
File path: pkg/ingress/controller/apisix_route.go
##
@@ -188,15 +188,11 @@ func (c *apisixRouteController) handleSyncErr(obj
interface{}, err error) {
c.workqueue.Forget(obj)
return
}
- if c.workqueue.NumRequeues(obj) < _maxRetries {
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix-ingress-controller] branch master updated: fix: workqueue need to retry when failed (#311)
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 244b556 fix: workqueue need to retry when failed (#311)
244b556 is described below
commit 244b5566851164e5b0fd9422d69a2615353c1882
Author: kv
AuthorDate: Fri Mar 26 23:28:52 2021 +0800
fix: workqueue need to retry when failed (#311)
* fix: workqueue need to retry when failed
* fix: rm _maxRetries
---
pkg/ingress/controller/apisix_route.go| 23 +--
pkg/ingress/controller/apisix_upstream.go | 17 +++--
pkg/ingress/controller/endpoint.go| 21 ++---
pkg/ingress/controller/ingress.go | 17 +++--
4 files changed, 29 insertions(+), 49 deletions(-)
diff --git a/pkg/ingress/controller/apisix_route.go
b/pkg/ingress/controller/apisix_route.go
index 707cdd9..d8fcb99 100644
--- a/pkg/ingress/controller/apisix_route.go
+++ b/pkg/ingress/controller/apisix_route.go
@@ -16,19 +16,18 @@ package controller
import (
"context"
-
- "github.com/apache/apisix-ingress-controller/pkg/kube"
-
- apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+ "time"
"go.uber.org/zap"
k8serrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/client-go/tools/cache"
"k8s.io/client-go/util/workqueue"
+ "github.com/apache/apisix-ingress-controller/pkg/kube"
"github.com/apache/apisix-ingress-controller/pkg/log"
"github.com/apache/apisix-ingress-controller/pkg/seven/state"
"github.com/apache/apisix-ingress-controller/pkg/types"
+ apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
)
type apisixRouteController struct {
@@ -40,7 +39,7 @@ type apisixRouteController struct {
func (c *Controller) newApisixRouteController() *apisixRouteController {
ctl := {
controller: c,
- workqueue:
workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(),
"ApisixRoute"),
+ workqueue:
workqueue.NewNamedRateLimitingQueue(workqueue.NewItemFastSlowRateLimiter(1*time.Second,
60*time.Second, 5), "ApisixRoute"),
workers:1,
}
c.apisixRouteInformer.AddEventHandler(
@@ -189,15 +188,11 @@ func (c *apisixRouteController) handleSyncErr(obj
interface{}, err error) {
c.workqueue.Forget(obj)
return
}
- if c.workqueue.NumRequeues(obj) < _maxRetries {
- log.Infow("sync ApisixRoute failed, will retry",
- zap.Any("object", obj),
- )
- c.workqueue.AddRateLimited(obj)
- } else {
- c.workqueue.Forget(obj)
- log.Warnf("drop ApisixRoute %+v out of the queue", obj)
- }
+ log.Warnw("sync ApisixRoute failed, will retry",
+ zap.Any("object", obj),
+ zap.Error(err),
+ )
+ c.workqueue.AddRateLimited(obj)
}
func (c *apisixRouteController) onAdd(obj interface{}) {
diff --git a/pkg/ingress/controller/apisix_upstream.go
b/pkg/ingress/controller/apisix_upstream.go
index c03ed9c..75dd1ba 100644
--- a/pkg/ingress/controller/apisix_upstream.go
+++ b/pkg/ingress/controller/apisix_upstream.go
@@ -16,6 +16,7 @@ package controller
import (
"context"
+ "time"
"go.uber.org/zap"
k8serrors "k8s.io/apimachinery/pkg/api/errors"
@@ -38,7 +39,7 @@ type apisixUpstreamController struct {
func (c *Controller) newApisixUpstreamController() *apisixUpstreamController {
ctl := {
controller: c,
- workqueue:
workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(),
"ApisixUpstream"),
+ workqueue:
workqueue.NewNamedRateLimitingQueue(workqueue.NewItemFastSlowRateLimiter(1*time.Second,
60*time.Second, 5), "ApisixUpstream"),
workers:1,
}
@@ -178,15 +179,11 @@ func (c *apisixUpstreamController) handleSyncErr(obj
interface{}, err error) {
c.workqueue.Forget(obj)
return
}
- if c.workqueue.NumRequeues(obj) < _maxRetries {
- log.Infow("sync ApisixUpstream failed, will retry",
- zap.Any("object", obj),
- )
- c.workqueue.AddRateLimited(obj)
- } else {
- c.workqueue.Forget(obj)
- log.Warnf("drop ApisixUpstream %+v out of the queue", obj)
- }
+ log.Warnw("sync ApisixUpstream failed, will retry",
+ zap.Any("object", obj),
+ zap.Error(err),
+ )
+ c.workqueue.AddRateLimited(obj)
}
func (c *apisixUpstreamController) onAdd(obj interface{}) {
diff --git
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1679: feat: autocomplete when people input http header
guoqqqi commented on pull request #1679: URL: https://github.com/apache/apisix-dashboard/pull/1679#issuecomment-808293244 Very good! I found a small problem: when clicking on the delete icon, the key in the last row is not deleted, shouldn't we delete the key in the last row as well?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on pull request #1679: feat: autocomplete when people input http header
qian0817 commented on pull request #1679: URL: https://github.com/apache/apisix-dashboard/pull/1679#issuecomment-808273060 @juzhiyuan I dont't konw how to use cypress,so I may need some help to write test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
bisakhmondal commented on a change in pull request #1675:
URL: https://github.com/apache/apisix-dashboard/pull/1675#discussion_r602342175
##
File path: api/test/e2enew/route/route_with_methods_test.go
##
@@ -110,73 +111,66 @@ func TestRoute_with_methods(t *testing.T) {
}]
}
}`,
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
- },
- {
- Desc: "verify route by post",
- Object: APISIXExpect(t),
+ }),
+ table.Entry("verify route by post", base.HttpTestCase{
+ Object: base.APISIXExpect(),
Method: http.MethodPost,
Path: "/hello",
Body: `test=test`,
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
ExpectBody: "hello world",
- Sleep:sleepTime,
- },
- {
- Desc: "verify route by put",
- Object: APISIXExpect(t),
+ Sleep:base.SleepTime,
+ }),
+ table.Entry("verify route by put", base.HttpTestCase{
+ Object: base.APISIXExpect(),
Method: http.MethodPut,
Path: "/hello",
Body: `test=test`,
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
ExpectBody: "hello world",
- Sleep:sleepTime,
- },
- {
- Desc: "verify route by get",
- Object: APISIXExpect(t),
+ Sleep:base.SleepTime,
+ }),
+ table.Entry("verify route by get", base.HttpTestCase{
+ Object: base.APISIXExpect(),
Method: http.MethodGet,
Path: "/hello",
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
ExpectBody: "hello world",
- Sleep:sleepTime,
- },
- {
- Desc: "verify route by delete",
- Object: APISIXExpect(t),
+ Sleep:base.SleepTime,
+ }),
+ table.Entry("verify route by delete", base.HttpTestCase{
+ Object: base.APISIXExpect(),
Method: http.MethodDelete,
Path: "/hello",
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
ExpectBody: "hello world",
- Sleep:sleepTime,
- },
- {
- Desc: "verify route by patch",
- Object: APISIXExpect(t),
+ Sleep:base.SleepTime,
+ }),
+ table.Entry("verify route by patch", base.HttpTestCase{
+ Object: base.APISIXExpect(),
Method: http.MethodPatch,
Path: "/hello",
Body: `test=test`,
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
ExpectBody: "hello world",
- Sleep:sleepTime,
- },
- {
- Desc: "delete route",
- Object: ManagerApiExpect(t),
+ Sleep:base.SleepTime,
+ }),
Review comment:
looking into it.
--
This is an automated message
[GitHub] [apisix-ingress-controller] iamayushdas closed pull request #314: docs: tell users where the are #230
iamayushdas closed pull request #314: URL: https://github.com/apache/apisix-ingress-controller/pull/314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1674: feat: improved plugin #1631
juzhiyuan commented on pull request #1674: URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808250598 got it, please be patient for GitHub is not realtime always :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] iamayushdas opened a new pull request #314: docs: tell users where the are #230
iamayushdas opened a new pull request #314: URL: https://github.com/apache/apisix-ingress-controller/pull/314 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues https://github.com/apache/apisix-website/issues/230 ___ ### Bugfix - Description Add a new sidebar object which tells user where they are. - How to fix? Add a new sidebar object which tells user where they are. ___ ### New feature or improvement - Describe the details and related test reports. Add a new sidebar object which tells user where they are. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch https://github.com/apache/apisix-website/tree/master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
tokers commented on a change in pull request #1675:
URL: https://github.com/apache/apisix-dashboard/pull/1675#discussion_r602318828
##
File path: api/test/e2enew/route/route_with_methods_test.go
##
@@ -110,73 +111,66 @@ func TestRoute_with_methods(t *testing.T) {
}]
}
}`,
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
- },
- {
- Desc: "verify route by post",
- Object: APISIXExpect(t),
+ }),
+ table.Entry("verify route by post", base.HttpTestCase{
+ Object: base.APISIXExpect(),
Method: http.MethodPost,
Path: "/hello",
Body: `test=test`,
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
ExpectBody: "hello world",
- Sleep:sleepTime,
- },
- {
- Desc: "verify route by put",
- Object: APISIXExpect(t),
+ Sleep:base.SleepTime,
+ }),
+ table.Entry("verify route by put", base.HttpTestCase{
+ Object: base.APISIXExpect(),
Method: http.MethodPut,
Path: "/hello",
Body: `test=test`,
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
ExpectBody: "hello world",
- Sleep:sleepTime,
- },
- {
- Desc: "verify route by get",
- Object: APISIXExpect(t),
+ Sleep:base.SleepTime,
+ }),
+ table.Entry("verify route by get", base.HttpTestCase{
+ Object: base.APISIXExpect(),
Method: http.MethodGet,
Path: "/hello",
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
ExpectBody: "hello world",
- Sleep:sleepTime,
- },
- {
- Desc: "verify route by delete",
- Object: APISIXExpect(t),
+ Sleep:base.SleepTime,
+ }),
+ table.Entry("verify route by delete", base.HttpTestCase{
+ Object: base.APISIXExpect(),
Method: http.MethodDelete,
Path: "/hello",
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
ExpectBody: "hello world",
- Sleep:sleepTime,
- },
- {
- Desc: "verify route by patch",
- Object: APISIXExpect(t),
+ Sleep:base.SleepTime,
+ }),
+ table.Entry("verify route by patch", base.HttpTestCase{
+ Object: base.APISIXExpect(),
Method: http.MethodPatch,
Path: "/hello",
Body: `test=test`,
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
ExpectBody: "hello world",
- Sleep:sleepTime,
- },
- {
- Desc: "delete route",
- Object: ManagerApiExpect(t),
+ Sleep:base.SleepTime,
+ }),
Review comment:
Also, we may update the `methods` list and verify the
[GitHub] [apisix-docker] stu01509 commented on pull request #153: docs: move the md files to /docs/en/latest foleder
stu01509 commented on pull request #153: URL: https://github.com/apache/apisix-docker/pull/153#issuecomment-808229375 >  > > @stu01509 Hi, please fix the Lint issue when you are free :) Update the commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1674: feat: improved plugin #1631
iamayushdas commented on pull request #1674: URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808229264 > @iamayushdas of course! Everyone could review PRs in our community :) I meant ,Can you review this for approval -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] juzhiyuan commented on pull request #153: docs: move the md files to /docs/en/latest foleder
juzhiyuan commented on pull request #153: URL: https://github.com/apache/apisix-docker/pull/153#issuecomment-808227951  @stu01509 Hi, please fix the Lint issue when you are free :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1674: feat: improved plugin #1631
juzhiyuan commented on pull request #1674: URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808227126 Just review & comment if needed :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1674: feat: improved plugin #1631
juzhiyuan commented on pull request #1674: URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808226909 @iamayushdas of course! Everyone could review PRs in our community :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated: docs: create docs folder and move README.md (#47)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 508569f docs: create docs folder and move README.md (#47) 508569f is described below commit 508569feff769d8c6679cfd2f6f2d5182f22a5d8 Author: Cliff Su AuthorDate: Fri Mar 26 21:37:11 2021 +0800 docs: create docs folder and move README.md (#47) --- .../README.md => docs/en/latest/apisix-dashboard.md| 4 .../README.md => docs/en/latest/apisix-ingress-controller.md | 4 charts/apisix/README.md => docs/en/latest/apisix.md| 4 docs/en/latest/config.json | 10 ++ 4 files changed, 22 insertions(+) diff --git a/charts/apisix-dashboard/README.md b/docs/en/latest/apisix-dashboard.md similarity index 95% rename from charts/apisix-dashboard/README.md rename to docs/en/latest/apisix-dashboard.md index fd746cf..b759bc1 100644 --- a/charts/apisix-dashboard/README.md +++ b/docs/en/latest/apisix-dashboard.md @@ -1,3 +1,7 @@ +--- +title: Apache APISIX Dashboard Helm Chart +--- +
[GitHub] [apisix-helm-chart] juzhiyuan merged pull request #47: docs: create docs folder and move README.md
juzhiyuan merged pull request #47: URL: https://github.com/apache/apisix-helm-chart/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1678: chore: use gomega match assertion
bisakhmondal commented on a change in pull request #1678:
URL: https://github.com/apache/apisix-dashboard/pull/1678#discussion_r602221848
##
File path: api/test/e2enew/service/service_test.go
##
@@ -139,12 +135,11 @@ var _ = ginkgo.Describe("create service without plugin",
func() {
})
})
ginkgo.It("batch test /server_port api", func() {
- t := ginkgo.GinkgoT()
time.Sleep(time.Duration(500) * time.Millisecond)
res := base.BatchTestServerPort(18)
- assert.True(t, res["1980"] == 3)
- assert.True(t, res["1981"] == 6)
- assert.True(t, res["1982"] == 9)
+ gomega.Expect(res["1980"] == 3).Should(gomega.BeTrue())
+ gomega.Expect(res["1981"] == 6).Should(gomega.BeTrue())
+ gomega.Expect(res["1982"] == 9).Should(gomega.BeTrue())
Review comment:
Just a suggestion, we could also use
`gomega.Expect(res["1980"]).Should(gomega.Equal(3))` here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1678: chore: use gomega match assertion
bisakhmondal commented on a change in pull request #1678:
URL: https://github.com/apache/apisix-dashboard/pull/1678#discussion_r602232948
##
File path: api/test/e2enew/upstream/upstream_chash_query_string_arg_xxx_test.go
##
@@ -197,7 +193,7 @@ var _ = ginkgo.Describe("Upstream chash query string",
func() {
counts = append(counts, value)
}
sort.Ints(counts)
- assert.True(t, float64(counts[2]-counts[0])/float64(counts[1])
< 0.4)
+ gomega.Expect(float64(counts[2]-counts[0])/float64(counts[1]) <
0.4).Should(gomega.BeTrue())
Review comment:
```suggestion
gomega.Expect(float64(counts[2]-counts[0])/float64(counts[1])).Should(gomega.BeNumerically("<",
0.4))
```
what do you say?
##
File path: api/test/e2enew/service/service_test.go
##
@@ -139,12 +135,11 @@ var _ = ginkgo.Describe("create service without plugin",
func() {
})
})
ginkgo.It("batch test /server_port api", func() {
- t := ginkgo.GinkgoT()
time.Sleep(time.Duration(500) * time.Millisecond)
res := base.BatchTestServerPort(18)
- assert.True(t, res["1980"] == 3)
- assert.True(t, res["1981"] == 6)
- assert.True(t, res["1982"] == 9)
+ gomega.Expect(res["1980"] == 3).Should(gomega.BeTrue())
+ gomega.Expect(res["1981"] == 6).Should(gomega.BeTrue())
+ gomega.Expect(res["1982"] == 9).Should(gomega.BeTrue())
Review comment:
Just a suggestion, you could also use
`gomega.Expect(res["1980"]).Should(gomega.Equal(3))` here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3918: chore: remove unused shared dict
spacewander opened a new pull request #3918: URL: https://github.com/apache/apisix/pull/3918 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1667: feat: run manager-api as a systemd daemon/service
bisakhmondal commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-808154939 ya sure :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #842: feat: support run `manager api` as OS service
bisakhmondal commented on issue #842: URL: https://github.com/apache/apisix-dashboard/issues/842#issuecomment-808154327 hii @nic-chen thanks for the heads up, its working perfectly now, latest logs in reverse order ``` -- Logs begin at Mon 2021-03-15 21:16:03 IST, end at Fri 2021-03-26 17:12:41 IST. -- Mar 26 17:12:09 turing manager-api[571177]: Logfile : /home/bisakh/Desktop/OSS/apisix-dashboard/output/logs/error.log Mar 26 17:12:09 turing manager-api[571177]: Loglevel: warn Mar 26 17:12:09 turing manager-api[571177]: Listen : 127.0.0.1:9000 Mar 26 17:12:09 turing manager-api[571177]: GitHash : efdb869 Mar 26 17:12:09 turing manager-api[571177]: Version : 2.4 Mar 26 17:12:09 turing manager-api[571177]: The manager-api is running successfully! Mar 26 17:12:09 turing systemd[1]: Started Manager-API service. Mar 26 17:12:09 turing systemd[1]: Starting Manager-API service... ``` it was causing by `PermissionsStartOnly=true` which was overriding user & group info to provide syslog access over the generated logs(stdout & stderr). so putting ``` User=<> Group=<> ``` after syslog initialization (which was put before the statement by me earlier), solves it. Thanks, pushing the changes soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1678: chore: use gomega match assertion
codecov-io edited a comment on pull request #1678: URL: https://github.com/apache/apisix-dashboard/pull/1678#issuecomment-808093117 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=h1) Report > Merging [#1678](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=desc) (b2f2c79) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/88f323285f2bdbafca027da9aef357b2e3eb4008?el=desc) (88f3232) will **decrease** coverage by `25.17%`. > The diff coverage is `n/a`. > :exclamation: Current head b2f2c79 differs from pull request most recent head 42d64c6. Consider uploading reports for the commit 42d64c6 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1678 +/- ## === - Coverage 72.41% 47.24% -25.18% === Files 133 47 -86 Lines5728 3116 -2612 Branches 6660 -666 === - Hits 4148 1472 -2676 - Misses 1337 1386 +49 - Partials 243 258 +15 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `47.24% <ø> (-14.61%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | `15.00% <0.00%> (-85.00%)` | :arrow_down: | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `23.80% <0.00%> (-76.20%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `5.55% <0.00%> (-70.38%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `12.04% <0.00%> (-61.26%)` | :arrow_down: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `31.42% <0.00%> (-59.29%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `33.33% <0.00%> (-57.15%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `41.73% <0.00%> (-50.44%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | ... and [107 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=footer). Last update [88f3232...42d64c6](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=lastupdated). Read the [comment
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1674: feat: improved plugin #1631
iamayushdas commented on pull request #1674: URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808124365 @nic-chen @juzhiyuan can i have the review please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #1679: feat: autocomplete when people input http header
juzhiyuan edited a comment on pull request #1679: URL: https://github.com/apache/apisix-dashboard/pull/1679#issuecomment-808108875 also cc @guoqqqi to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1679: feat: autocomplete when people input http header
juzhiyuan commented on pull request #1679: URL: https://github.com/apache/apisix-dashboard/pull/1679#issuecomment-808108817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #1679: feat: autocomplete when people input http header
juzhiyuan edited a comment on pull request #1679: URL: https://github.com/apache/apisix-dashboard/pull/1679#issuecomment-808108817 Wow! Good feature indeed! @qian0817 Would you like to write the test cases for this PR? or need some help about this? BTW, please update the Checklist :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] stu01509 commented on pull request #153: docs: move the md files to /docs/en/latest foleder
stu01509 commented on pull request #153: URL: https://github.com/apache/apisix-docker/pull/153#issuecomment-808110765 Update the commit :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1677: feat: rewrite e2e test route with plugin limit count test with ginkgo
juzhiyuan commented on pull request #1677: URL: https://github.com/apache/apisix-dashboard/pull/1677#issuecomment-808110219 Hi, you could request proper reviewers :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 opened a new issue #1680: feat: show http response header in debug view
qian0817 opened a new issue #1680: URL: https://github.com/apache/apisix-dashboard/issues/1680 # Feature request ## Please describe your feature Currently only the response body is displayed, consider displaying the response header at the same time。  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] stu01509 commented on a change in pull request #47: docs: create docs folder and move README.md
stu01509 commented on a change in pull request #47:
URL: https://github.com/apache/apisix-helm-chart/pull/47#discussion_r602176949
##
File path: docs/en/latest/config.json
##
@@ -1,10 +1,14 @@
{
-"version": 0.4,
-"sidebar": [
- {
-"type": "category",
-"label": "Installation",
-"items": ["apisix", "apisix-dashboard", "apisix-ingress-controller"]
- }
-]
- }
\ No newline at end of file
+ "version": 0.4,
+ "sidebar": [
+{
+ "type": "category",
+ "label": "Installation",
+ "items": [
+"apisix",
+"apisix-dashboard",
+"apisix-ingress-controller"
+ ]
+}
+ ]
+}
Review comment:
Sorry, the auto prettier remove this, update the commit :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] stu01509 commented on a change in pull request #153: docs: move the md files to /docs/en/latest foleder
stu01509 commented on a change in pull request #153:
URL: https://github.com/apache/apisix-docker/pull/153#discussion_r602176897
##
File path: docs/en/latest/config.json
##
@@ -1,10 +1,10 @@
{
-"version": 1.0,
-"sidebar": [
- {
-"type": "category",
-"label": "Installation",
-"items": ["build", "manual", "example"]
- }
-]
- }
\ No newline at end of file
+ "version": 1.0,
+ "sidebar": [
+{
+ "type": "category",
+ "label": "Installation",
+ "items": [ "build", "manual", "example"]
+}
+ ]
+}
Review comment:
Sorry, the auto prettier remove this, update the commit :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #153: docs: move the md files to /docs/en/latest foleder
juzhiyuan commented on a change in pull request #153: URL: https://github.com/apache/apisix-docker/pull/153#discussion_r602176412 ## File path: docs/en/latest/manual.md ## @@ -1,3 +1,27 @@ +--- +title: Manual deploy apisix via docker Review comment: ```suggestion title: Deploy Apache APISIX with Docker ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #153: docs: move the md files to /docs/en/latest foleder
juzhiyuan commented on a change in pull request #153: URL: https://github.com/apache/apisix-docker/pull/153#discussion_r602176552 ## File path: docs/en/latest/build.md ## @@ -1,3 +1,26 @@ +--- +title: Build an image from source Review comment: ```suggestion title: Build an image from the source codes ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #153: docs: move the md files to /docs/en/latest foleder
juzhiyuan commented on a change in pull request #153:
URL: https://github.com/apache/apisix-docker/pull/153#discussion_r602176033
##
File path: docs/en/latest/config.json
##
@@ -1,10 +1,10 @@
{
-"version": 1.0,
-"sidebar": [
- {
-"type": "category",
-"label": "Installation",
-"items": ["build", "manual", "example"]
- }
-]
- }
\ No newline at end of file
+ "version": 1.0,
+ "sidebar": [
+{
+ "type": "category",
+ "label": "Installation",
+ "items": [ "build", "manual", "example"]
+}
+ ]
+}
Review comment:
new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] juzhiyuan commented on a change in pull request #47: docs: create docs folder and move README.md
juzhiyuan commented on a change in pull request #47:
URL: https://github.com/apache/apisix-helm-chart/pull/47#discussion_r602174269
##
File path: docs/en/latest/config.json
##
@@ -1,10 +1,14 @@
{
-"version": 0.4,
-"sidebar": [
- {
-"type": "category",
-"label": "Installation",
-"items": ["apisix", "apisix-dashboard", "apisix-ingress-controller"]
- }
-]
- }
\ No newline at end of file
+ "version": 0.4,
+ "sidebar": [
+{
+ "type": "category",
+ "label": "Installation",
+ "items": [
+"apisix",
+"apisix-dashboard",
+"apisix-ingress-controller"
+ ]
+}
+ ]
+}
Review comment:
Need a blank line at the ned of file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] juzhiyuan commented on pull request #153: docs: move the md files to /docs/en/latest foleder
juzhiyuan commented on pull request #153: URL: https://github.com/apache/apisix-docker/pull/153#issuecomment-808105996 @stu01509 It seems that no changes happened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3820: feat: add nacos support
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r602173854
##
File path: .travis/linux_tengine_runner.sh
##
@@ -40,6 +40,9 @@ before_install() {
# start consul servers
docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul agent
-server -bootstrap-expect=1 -client 0.0.0.0 -log-level info
-data-dir=/consul/data
docker run --rm --name consul_2 -d -p 8600:8500 consul:1.7 consul agent
-server -bootstrap-expect=1 -client 0.0.0.0 -log-level info
-data-dir=/consul/data
+
+# start nacos server
+docker run --rm --name nacos_1 -d --env PREFER_HOST_MODE=hostname --env
MODE=standalone --env JVM_XMS=512m --env JVM_XMX=512m --env JVM_XMN=256m
-p8848:8848 nacos/nacos-server:latest
Review comment:
You can use different conf in different tests, one for auth success and
another for auth fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 opened a new pull request #1679: feat: autocomplete when people input http header
qian0817 opened a new pull request #1679: URL: https://github.com/apache/apisix-dashboard/pull/1679 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** autocomplete when people input http header  **Related issues** None **Checklist:** - [ ] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] stu01509 commented on pull request #153: docs: move the md files to /docs/en/latest foleder
stu01509 commented on pull request #153: URL: https://github.com/apache/apisix-docker/pull/153#issuecomment-808100986 Hi @juzhiyuan Update the commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] anjia0532 edited a comment on issue #3830: bug: [error] 43#43: init_worker_by_lua error: /usr/local/apisix/apisix/plugin.lua:264: attempt to index upvalue 'local_conf' (a nil value)
anjia0532 edited a comment on issue #3830: URL: https://github.com/apache/apisix/issues/3830#issuecomment-808099788 > > thanks and waiting for this. @tokers > > Could you please provide the file permission of apisix config.yaml in the container. yeah, default permission is `400` , `6xx`(rw,xx,xx) is ok. thanks. why apisix need to write permission abount config.yaml ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] anjia0532 commented on issue #3830: bug: [error] 43#43: init_worker_by_lua error: /usr/local/apisix/apisix/plugin.lua:264: attempt to index upvalue 'local_conf' (a nil value)
anjia0532 commented on issue #3830: URL: https://github.com/apache/apisix/issues/3830#issuecomment-808099788 > > thanks and waiting for this. @tokers > > Could you please provide the file permission of apisix config.yaml in the container. yeah, default permission is `400` , `6xx`(rw,xx,xx) is ok. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] anjia0532 closed issue #3830: bug: [error] 43#43: init_worker_by_lua error: /usr/local/apisix/apisix/plugin.lua:264: attempt to index upvalue 'local_conf' (a nil value)
anjia0532 closed issue #3830: URL: https://github.com/apache/apisix/issues/3830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1676: feat: rewrite e2e test(test-e2e-route-with-plugin-CORS) using ginkgo
codecov-io commented on pull request #1676: URL: https://github.com/apache/apisix-dashboard/pull/1676#issuecomment-808098113 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1676?src=pr=h1) Report > Merging [#1676](https://codecov.io/gh/apache/apisix-dashboard/pull/1676?src=pr=desc) (a27cafc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/88f323285f2bdbafca027da9aef357b2e3eb4008?el=desc) (88f3232) will **increase** coverage by `1.55%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1676?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1676 +/- ## == + Coverage 72.41% 73.96% +1.55% == Files 133 86 -47 Lines5728 2612-3116 Branches 666 666 == - Hits 4148 1932-2216 + Misses 1337 680 -657 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1676?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1676/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1676/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | | | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1676/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | | | | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1676/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1676/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1676/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | | | | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1676/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1676/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1676/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1676/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | | | ... and [37 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1676/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1676?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1676?src=pr=footer). Last update [88f3232...a27cafc](https://codecov.io/gh/apache/apisix-dashboard/pull/1676?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1335: Align dashboard menu options to the left
juzhiyuan commented on issue #1335: URL: https://github.com/apache/apisix-dashboard/issues/1335#issuecomment-808096044 @nic-chen Hi, this is is a UI issue :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1678: chore: use gomega match assertion
codecov-io commented on pull request #1678: URL: https://github.com/apache/apisix-dashboard/pull/1678#issuecomment-808093117 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=h1) Report > Merging [#1678](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=desc) (f074bba) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/88f323285f2bdbafca027da9aef357b2e3eb4008?el=desc) (88f3232) will **decrease** coverage by `20.60%`. > The diff coverage is `n/a`. > :exclamation: Current head f074bba differs from pull request most recent head 42d64c6. Consider uploading reports for the commit 42d64c6 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1678 +/- ## === - Coverage 72.41% 51.81% -20.61% === Files 133 38 -95 Lines5728 2650 -3078 Branches 6660 -666 === - Hits 4148 1373 -2775 + Misses 1337 1089 -248 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [119 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1678/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=footer). Last update [88f3232...42d64c6](https://codecov.io/gh/apache/apisix-dashboard/pull/1678?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and
[GitHub] [apisix-dashboard] nic-chen commented on issue #1662: Duplicate def upstream on api doc
nic-chen commented on issue #1662: URL: https://github.com/apache/apisix-dashboard/issues/1662#issuecomment-808091221 oh, it's not a bug. UpsteamDef is a public structure, route, upstream and service all refer to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on pull request #1667:
URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-808089921
> Backend CLI Test is failing for changing
> `log.Infof("The Manager API server receive %s and start shutting down",
sig.String())`
> to
> `log.Infof("The Manager API server receives %s and starts acting up",
sig.String())`
> hehe :)
hi
Can it be solved by modifying the test's assertion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1658: Test: check the e2e test whether the data plane is tested
nic-chen commented on issue #1658: URL: https://github.com/apache/apisix-dashboard/issues/1658#issuecomment-808088588 No DP test files: ``` *_suite_test.go This type of file is equivalent to the entry file of the test scenario, there is no specific test: apisix-dashboard/api/test/e2enew/route_online_debug/route_online_debug_suite_test.go apisix-dashboard/api/test/e2enew/ssl/ssl_suite_test.go apisix-dashboard/api/test/e2enew/route/route_suite_test.go apisix-dashboard/api/test/e2enew/server_info/server_info_suite_test.go apisix-dashboard/api/test/e2enew/schema/schema_suite_test.go apisix-dashboard/api/test/e2enew/version/version_suite_test.go apisix-dashboard/api/test/e2enew/healthz/healthz_suite_test.go apisix-dashboard/api/test/e2enew/service/service_suite_test.go apisix-dashboard/api/test/e2enew/plugin_config/plugin_config_suite_test.go apisix-dashboard/api/test/e2enew/upstream/upstream_suite_test.go apisix-dashboard/api/test/e2enew/base/http.go - http package apisix-dashboard/api/test/e2enew/version/version_test.go - dashboard version test apisix-dashboard/api/test/e2enew/healthz/healthz_test.go - dashboard survival api test apisix-dashboard/api/test/e2e/label_test.go - There is currently no application scenario for label on the DP side apisix-dashboard/api/test/e2e/authentication_test.go - login test of dashboard apisix-dashboard/api/test/e2enew/server_info/server_info_test.go - service-info plug-in test, DP is to report data, no interface apisix-dashboard/api/test/e2enew/schema/schema_test.go - Expose the schema interface, no interaction with DP apisix-dashboard/api/test/e2enew/schema/plugin_test.go - Expose the interface of the plug-in list and plug-in schema, no need to test the DP ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1674: feat: improved plugin #1631
nic-chen commented on pull request #1674: URL: https://github.com/apache/apisix-dashboard/pull/1674#issuecomment-808081783 > @nic-chen @starsz Plz take a look at the failed CI. It may be because apisix-docker failed to start. This problem has been fixed: https://github.com/apache/apisix-docker/pull/154 I ran again to take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1678: chore: use gomega match assertion
Jaycean opened a new pull request #1678: URL: https://github.com/apache/apisix-dashboard/pull/1678 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** e2e test use gomega match assertion. **Related issues** fix/resolve #1664 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [x] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1335: Align dashboard menu options to the left
nic-chen commented on issue #1335: URL: https://github.com/apache/apisix-dashboard/issues/1335#issuecomment-808078653 @Caelebs Is there still a problem with the wrong etcd version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1677: feat: rewrite e2e test route with plugin limit count test with ginkgo
Jaycean opened a new pull request #1677: URL: https://github.com/apache/apisix-dashboard/pull/1677 **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **Related issues** #1500 rewrite e2e test route with plugin limit count test with ginkgo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #842: feat: support run `manager api` as OS service
nic-chen commented on issue #842: URL: https://github.com/apache/apisix-dashboard/issues/842#issuecomment-808076065 hi @bisakhmondal Need to confirm, is the owner of the logs directory and running manager-api the same user? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1676: feat: rewrite e2e test(test-e2e-route-with-plugin-CORS) using ginkgo
bisakhmondal opened a new pull request #1676: URL: https://github.com/apache/apisix-dashboard/pull/1676 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **Related issues** #1500 **Checklist:** - [ ] Did you explain what problem does this PR solve? Or what new features have been added? - [x] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1673: fix: unable to export route with nil methods field
codecov-io edited a comment on pull request #1673: URL: https://github.com/apache/apisix-dashboard/pull/1673#issuecomment-808061722 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=h1) Report > Merging [#1673](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=desc) (0fb644b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **decrease** coverage by `10.24%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1673 +/- ## === - Coverage 72.59% 62.34% -10.25% === Files 133 47 -86 Lines5728 3126 -2602 Branches 6660 -666 === - Hits 4158 1949 -2209 + Misses 1327 865 -462 - Partials 243 312 +69 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.34% <100.00%> (+0.21%)` | :arrow_up: | | backend-e2e-test-ginkgo | `48.36% <0.00%> (+0.10%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `72.46% <100.00%> (+3.29%)` | :arrow_up: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `47.22% <0.00%> (-30.56%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-29.57%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `59.63% <0.00%> (-27.11%)` | :arrow_down: | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `64.51% <0.00%> (-19.36%)` | :arrow_down: | | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | `59.57% <0.00%> (-18.09%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `44.82% <0.00%> (-13.80%)` | :arrow_down: | | ... and [101 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=footer). Last update [c6c5d14...0fb644b](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message,
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1673: fix: unable to export route with nil methods field
codecov-io commented on pull request #1673: URL: https://github.com/apache/apisix-dashboard/pull/1673#issuecomment-808061722 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=h1) Report > Merging [#1673](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=desc) (0fb644b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **decrease** coverage by `24.67%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1673 +/- ## === - Coverage 72.59% 47.92% -24.68% === Files 133 47 -86 Lines5728 3126 -2602 Branches 6660 -666 === - Hits 4158 1498 -2660 - Misses 1327 1369 +42 - Partials 243 259 +16 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `47.92% <100.00%> (-14.22%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `72.46% <100.00%> (+3.29%)` | :arrow_up: | | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | `15.00% <0.00%> (-85.00%)` | :arrow_down: | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `23.80% <0.00%> (-76.20%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `5.55% <0.00%> (-70.38%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `12.04% <0.00%> (-61.26%)` | :arrow_down: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `31.42% <0.00%> (-59.29%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `33.33% <0.00%> (-57.15%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `41.73% <0.00%> (-50.44%)` | :arrow_down: | | ... and [108 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1673/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=footer). Last update [c6c5d14...0fb644b](https://codecov.io/gh/apache/apisix-dashboard/pull/1673?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log
[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support
benx203 commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r60254
##
File path: .travis/linux_tengine_runner.sh
##
@@ -40,6 +40,9 @@ before_install() {
# start consul servers
docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul agent
-server -bootstrap-expect=1 -client 0.0.0.0 -log-level info
-data-dir=/consul/data
docker run --rm --name consul_2 -d -p 8600:8500 consul:1.7 consul agent
-server -bootstrap-expect=1 -client 0.0.0.0 -log-level info
-data-dir=/consul/data
+
+# start nacos server
+docker run --rm --name nacos_1 -d --env PREFER_HOST_MODE=hostname --env
MODE=standalone --env JVM_XMS=512m --env JVM_XMX=512m --env JVM_XMN=256m
-p8848:8848 nacos/nacos-server:latest
Review comment:
If add NACOS_AUTH_ENABLE=true, file nacos.t need login too.
Could you give me a t file login demo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3917: request help: question about Prometheus memory consumption
spacewander commented on issue #3917: URL: https://github.com/apache/apisix/issues/3917#issuecomment-808043371 https://github.com/apache/apisix/blob/83931ba0a5c95e04ec867a4ffd0821d426ca0d27/apisix/cli/ngx_tpl.lua#L131 I would appreciate it if you can make it configurable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3910: fix: limit-count plugin connect error
spacewander commented on a change in pull request #3910:
URL: https://github.com/apache/apisix/pull/3910#discussion_r602062170
##
File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua
##
@@ -32,7 +32,7 @@ local mt = {
local function new_redis_cluster(conf)
local config = {
-name = "apisix-redis-cluster",
+name = "apisix-redis-cluster-" .. conf.name,
Review comment:
I read through the `resty.rediscluster`. Look like this library uses a
module-level `slot_cache`, and the key is the `config.name`.
So it is no doubted that different configurations with the same name will
collide.
~~What about using `"apisix-redis-cluster-" .. tostring(conf)` directly?~~
Better to add a comment about this change as future maintainers may not read
through the library.
~~Different routes using the same cluster will still need to share the
slot_cache. Would it be better to use crc32(nodes) to generate the suffix?~~
Sorry for my fickle mind. It seems the library doesn't provide a way to
clean up stale cached slots. So using auto-generated name is unsafe. My latest
idea is to require user to specify the name of redis cluster. It is a break
change but it is reasonable to introduce break change to fix bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
codecov-io edited a comment on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-808024334 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=h1) Report > Merging [#1675](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=desc) (2c96d73) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/88f323285f2bdbafca027da9aef357b2e3eb4008?el=desc) (88f3232) will **decrease** coverage by `25.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1675 +/- ## === - Coverage 72.41% 47.36% -25.05% === Files 133 47 -86 Lines5728 3116 -2612 Branches 6660 -666 === - Hits 4148 1476 -2672 - Misses 1337 1382 +45 - Partials 243 258 +15 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `47.36% <ø> (-14.48%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | `15.00% <0.00%> (-85.00%)` | :arrow_down: | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `23.80% <0.00%> (-76.20%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `5.55% <0.00%> (-70.38%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `12.04% <0.00%> (-61.26%)` | :arrow_down: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `31.42% <0.00%> (-59.29%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `33.33% <0.00%> (-57.15%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `41.73% <0.00%> (-50.44%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | ... and [107 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=footer). Last update [88f3232...2c96d73](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
codecov-io commented on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-808024334 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=h1) Report > Merging [#1675](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=desc) (832ef22) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/88f323285f2bdbafca027da9aef357b2e3eb4008?el=desc) (88f3232) will **decrease** coverage by `5.40%`. > The diff coverage is `n/a`. > :exclamation: Current head 832ef22 differs from pull request most recent head 2c96d73. Consider uploading reports for the commit 2c96d73 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1675 +/- ## == - Coverage 72.41% 67.00% -5.41% == Files 133 47 -86 Lines5728 3116-2612 Branches 6660 -666 == - Hits 4148 2088-2060 + Misses 1337 783 -554 - Partials 243 245 +2 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `48.29% <ø> (-0.36%)` | :arrow_down: | | backend-unit-test | `51.77% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `32.25% <0.00%> (-32.67%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `54.05% <0.00%> (-5.41%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | ... and [87 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=footer). Last update [88f3232...2c96d73](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to
[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
bisakhmondal opened a new pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **Related issues** #1500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3910: fix: limit-count plugin connect error
spacewander commented on a change in pull request #3910:
URL: https://github.com/apache/apisix/pull/3910#discussion_r602062170
##
File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua
##
@@ -32,7 +32,7 @@ local mt = {
local function new_redis_cluster(conf)
local config = {
-name = "apisix-redis-cluster",
+name = "apisix-redis-cluster-" .. conf.name,
Review comment:
I read through the `resty.rediscluster`. Look like this library uses a
module-level `slot_cache`, and the key is the `config.name`.
So it is no doubted that different configurations with the same name will
collide.
~~What about using `"apisix-redis-cluster-" .. tostring(conf)` directly?~~
Better to add a comment about this change as future maintainers may not read
through the library.
Different routes using the same cluster will still need to share the
slot_cache. Would it be better to use crc32(nodes) to generate the suffix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
