[GitHub] [apisix-dashboard] codecov-io commented on pull request #1679: feat: autocomplete when people input http header
codecov-io commented on pull request #1679: URL: https://github.com/apache/apisix-dashboard/pull/1679#issuecomment-808860155 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1679?src=pr&el=h1) Report > Merging [#1679](https://codecov.io/gh/apache/apisix-dashboard/pull/1679?src=pr&el=desc) (7f7d503) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/88f323285f2bdbafca027da9aef357b2e3eb4008?el=desc) (88f3232) will **increase** coverage by `1.67%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1679?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1679 +/- ## == + Coverage 72.41% 74.09% +1.67% == Files 133 86 -47 Lines5728 2617-3111 Branches 666 667 +1 == - Hits 4148 1939-2209 + Misses 1337 678 -659 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `74.09% <100.00%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1679?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1679/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `78.08% <ø> (ø)` | | | [...es/Route/components/DebugViews/DebugParamsView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1679/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdQYXJhbXNWaWV3LnRzeA==) | `100.00% <100.00%> (ø)` | | | [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1679/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <100.00%> (ø)` | | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1679/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1679/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1679/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | | | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1679/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | | | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1679/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1679/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1679/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | | | | ... and [41 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1679/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1679?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1679?src=pr&el=footer). Last update [88f3232...7f7d503](https://codecov.io/gh/apache/apisix-dashboard/pull/1679?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #3921: docs: tells users where they are
iamayushdas commented on pull request #3921: URL: https://github.com/apache/apisix/pull/3921#issuecomment-808877673 @juzhiyuan have a look , in to this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-808878108 @juzhiyuan @guoqqqi @LiteSun @gxthrj have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #3921: docs: tells users where they are
nic-chen commented on pull request #3921:
URL: https://github.com/apache/apisix/pull/3921#issuecomment-808880055
@iamayushdas
please have a look at TEST 9 in `t/admin/plugins.t`
```
# Failed test 'TEST 9: confirm the plugin of auth type - response_body -
like (repeated req 0, req 0)'
# at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm
line 1586.
#
'[{"name":"openid-connect","priority":2599},{"name":"wolf-rbac","priority":2555},{"name":"hmac-auth","priority":2530},{"name":"basic-auth","priority":2520},{"name":"jwt-auth","priority":2510},{"name":"key-auth","priority":2500},{"name":"authz-keycloak","priority":2000}]
# '
# doesn't match
'(?^:\[\{"name":"wolf-rbac","priority":2555\},\{"name":"hmac-auth","priority":2530\},\{"name":"basic-auth","priority":2520\},\{"name":"jwt-auth","priority":2510\},\{"name":"key-auth","priority":2500\}\])'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3921: docs: tells users where they are
juzhiyuan commented on a change in pull request #3921:
URL: https://github.com/apache/apisix/pull/3921#discussion_r602869421
##
File path: apisix/plugins/openid-connect.lua
##
@@ -101,6 +101,7 @@ local schema = {
local _M = {
version = 0.1,
priority = 2599,
+type = 'auth',
Review comment:
🤔 This is not belonged to Auth plugin AFAIK, there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix-docker] branch master updated: docs: move the md files to /docs/en/latest foleder (#153)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-docker.git
The following commit(s) were added to refs/heads/master by this push:
new 02d19b9 docs: move the md files to /docs/en/latest foleder (#153)
02d19b9 is described below
commit 02d19b9467332b5ea1e0c3f3b28edf416ec83812
Author: Cliff Su
AuthorDate: Sun Mar 28 19:51:09 2021 +0800
docs: move the md files to /docs/en/latest foleder (#153)
---
README.md | 4 +--
build.md | 16 ---
docs/en/latest/build.md| 39 ++
docs/en/latest/config.json | 10 +++
example/README.md => docs/en/latest/example.md | 23 +++
manual.md => docs/en/latest/manual.md | 23 +++
6 files changed, 97 insertions(+), 18 deletions(-)
diff --git a/README.md b/README.md
index 444cc5e..374c7cc 100644
--- a/README.md
+++ b/README.md
@@ -36,7 +36,7 @@ $ docker build -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${A
### Manual deploy apisix via docker
-[Manual deploy](manual.md)
+[Manual deploy](docs/en/latest/manual.md)
### QuickStart via docker-compose
@@ -47,7 +47,7 @@ $ cd example
$ docker-compose -p docker-apisix up -d
```
-You can refer to [the docker-compose example](example/README.md) for more try.
+You can refer to [the docker-compose example](docs/en/latest/example.md) for
more try.
### Quick test with all dependencies in one Docker container
diff --git a/build.md b/build.md
deleted file mode 100644
index 00e633a..000
--- a/build.md
+++ /dev/null
@@ -1,16 +0,0 @@
-## Build an image from source
-
-**Docker images are not official ASF releases but provided for convenience.
Recommended usage is always to build the source.**
-
-1. install release version (Apache releases are beginning from version 0.9):
-```
-# Assign Apache release version number to variable `APISIX_VERSION`, for
example: 2.2. The latest version can be find at
`https://github.com/apache/apisix/releases`
-
-APISIX_VERSION=2.2
-docker build -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine
-```
-
-2. install master branch version, which has latest code(ONLY for the
developer's convenience):
-```
-docker build -t apisix:master-alpine -f alpine/Dockerfile alpine
-```
diff --git a/docs/en/latest/build.md b/docs/en/latest/build.md
new file mode 100644
index 000..5a07b9a
--- /dev/null
+++ b/docs/en/latest/build.md
@@ -0,0 +1,39 @@
+---
+title: Build an image from the source codes
+---
+
+
+
+## Build an image from source
+
+**Docker images are not official ASF releases but provided for convenience.
Recommended usage is always to build the source.**
+
+1. install release version (Apache releases are beginning from version 0.9):
+```
+# Assign Apache release version number to variable `APISIX_VERSION`, for
example: 2.2. The latest version can be find at
`https://github.com/apache/apisix/releases`
+
+APISIX_VERSION=2.2
+docker build -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine
+```
+
+2. install master branch version, which has latest code(ONLY for the
developer's convenience):
+```
+docker build -t apisix:master-alpine -f alpine/Dockerfile alpine
+```
diff --git a/docs/en/latest/config.json b/docs/en/latest/config.json
new file mode 100644
index 000..62bbcfa
--- /dev/null
+++ b/docs/en/latest/config.json
@@ -0,0 +1,10 @@
+{
+ "version": 1.0,
+ "sidebar": [
+{
+ "type": "category",
+ "label": "Installation",
+ "items": [ "build", "manual", "example"]
+}
+ ]
+}
diff --git a/example/README.md b/docs/en/latest/example.md
similarity index 71%
rename from example/README.md
rename to docs/en/latest/example.md
index 8fdc676..185218d 100644
--- a/example/README.md
+++ b/docs/en/latest/example.md
@@ -1,3 +1,26 @@
+---
+title: Example
+---
+
+
+
**This example is used for functional verification and is not recommended for
performance testing. For performance testing, please refer to
[benchmark](https://github.com/apache/apisix#benchmark).**
### Run
diff --git a/manual.md b/docs/en/latest/manual.md
similarity index 68%
rename from manual.md
rename to docs/en/latest/manual.md
index 156eb66..5760ada 100644
--- a/manual.md
+++ b/docs/en/latest/manual.md
@@ -1,3 +1,26 @@
+---
+title: Deploy Apache APISIX with Docker
+---
+
+
+
## Manual deploy apisix via docker
### Create a network `apisix`
[GitHub] [apisix-docker] juzhiyuan merged pull request #153: docs: move the md files to /docs/en/latest foleder
juzhiyuan merged pull request #153: URL: https://github.com/apache/apisix-docker/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: feat: #216 add helm-chart project (#273)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 8184dc3 feat: #216 add helm-chart project (#273)
8184dc3 is described below
commit 8184dc31052cbb0a50d8e2538b57d1a226732440
Author: Cliff Su
AuthorDate: Sun Mar 28 19:52:00 2021 +0800
feat: #216 add helm-chart project (#273)
---
sync-docs.js | 5 ++---
website/docs/apisix-helm-chart/IGNORE_DOC.md | 1 +
website/docs/apisix-helm-chart/sidebars.json | 3 +++
website/docusaurus.config.js | 15 +++
4 files changed, 21 insertions(+), 3 deletions(-)
diff --git a/sync-docs.js b/sync-docs.js
index bab0749..df5cba6 100644
--- a/sync-docs.js
+++ b/sync-docs.js
@@ -3,9 +3,8 @@ console.log("Start sync-docs.js");
const childProcess = require("child_process");
const fs = require("fs");
const path = require("path");
-
-// NOTE: disable "apisix-docker" "apisix-helm-chart" currently
-const projects = ["apisix-ingress-controller", "apisix", "apisix-dashboard"];
+// "apisix-docker",
+const projects = ["apisix-ingress-controller", "apisix", "apisix-dashboard",
"apisix-helm-chart"];
const langs = ["en", "zh", "es"];
diff --git a/website/docs/apisix-helm-chart/IGNORE_DOC.md
b/website/docs/apisix-helm-chart/IGNORE_DOC.md
new file mode 100644
index 000..cb65e30
--- /dev/null
+++ b/website/docs/apisix-helm-chart/IGNORE_DOC.md
@@ -0,0 +1 @@
+# IGNORE_DOC
diff --git a/website/docs/apisix-helm-chart/sidebars.json
b/website/docs/apisix-helm-chart/sidebars.json
new file mode 100644
index 000..b0cd5aa
--- /dev/null
+++ b/website/docs/apisix-helm-chart/sidebars.json
@@ -0,0 +1,3 @@
+{
+ "docs": {}
+}
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index f470f50..6f35645 100644
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -49,6 +49,17 @@ module.exports = {
releaseDate: "2021-03-12",
firstDocPath: "/getting-started",
},
+ {
+name: "APISIX™ Helm Charts",
+nameInParamCase: "helm-charts",
+description: "An Apache APISIX Helm Charts provide the installation of
Apache APISIX components for kubernetes.",
+shape: "hexagon",
+color: "#2563EB",
+githubRepo: "apache/apisix-helm-chart",
+version: "0.4.0",
+releaseDate: "2021-03-12",
+firstDocPath: "/apisix",
+ },
],
team: require("./static/data/team.json"),
allRepos: [
@@ -196,6 +207,10 @@ module.exports = {
to: "/docs/ingress-controller/getting-started/",
},
{
+ label: "Apache™️ APISIX Helm Charts",
+ to: "/docs/helm-chart/apisix/",
+},
+{
label: "General",
to: "/docs/general/security",
},
[GitHub] [apisix-website] juzhiyuan closed issue #216: add more projects to /docs
juzhiyuan closed issue #216: URL: https://github.com/apache/apisix-website/issues/216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #273: Feat #216 add project
juzhiyuan merged pull request #273: URL: https://github.com/apache/apisix-website/pull/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas closed pull request #3921: docs: tells users where they are
iamayushdas closed pull request #3921: URL: https://github.com/apache/apisix/pull/3921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas opened a new pull request #3922: docs: tells users where they are
iamayushdas opened a new pull request #3922: URL: https://github.com/apache/apisix/pull/3922 Please answer these questions before submitting a pull request - Why submit this pull request? * [ ] Bugfix * [x] New feature provided * [ ] Improve performance * [ ] Backport patches ___ ### Bugfix - Description tells users where they are in sidebar - How to fix? added a label of Apache Apisix to sidebar ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch https://github.com/iamayushdas/apisix/tree/sidebar - Related commits and pull requests https://github.com/apache/apisix-website/issues/230 - Target branch https://github.com/apache/apisix/tree/master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Mm0mMMMM opened a new pull request #1686: chore: improve System Info module
Mm0m opened a new pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [x] Improve performance - [ ] Backport patches **What changes will this PR take into?** Update menu "System status", system status modified to System Info. Please update this section with detailed description.  **Related issues** related #1629 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [x] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Mm0mMMMM commented on pull request #1686: chore: improve System Info module
Mm0m commented on pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686#issuecomment-808890168 Hi, I see that the system info name needs to be changed in this issue and I have completed it. 😊😊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1686: chore: improve System Info module
codecov-io commented on pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686#issuecomment-808890206 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=h1) Report > Merging [#1686](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=desc) (0c54bc9) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/7adefe147f99a6422f02fa652bb1534b71c1c65f?el=desc) (7adefe1) will **decrease** coverage by `19.33%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1686 +/- ## === - Coverage 71.14% 51.81% -19.34% === Files 47 38-9 Lines3116 2650 -466 === - Hits 2217 1373 -844 - Misses655 1089 +434 + Partials 244 188 -56 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [33 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=footer). Last update [7adefe1...0c54bc9](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas commented on a change in pull request #3921: docs: tells users where they are
iamayushdas commented on a change in pull request #3921:
URL: https://github.com/apache/apisix/pull/3921#discussion_r602873810
##
File path: apisix/plugins/openid-connect.lua
##
@@ -101,6 +101,7 @@ local schema = {
local _M = {
version = 0.1,
priority = 2599,
+type = 'auth',
Review comment:
Oh yes yes, I forgot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1686: chore: improve System Info module
codecov-io edited a comment on pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686#issuecomment-808890206 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=h1) Report > Merging [#1686](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=desc) (0c54bc9) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/7adefe147f99a6422f02fa652bb1534b71c1c65f?el=desc) (7adefe1) will **decrease** coverage by `3.81%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1686 +/- ## == - Coverage 71.14% 67.32% -3.82% == Files 47 47 Lines3116 3116 == - Hits 2217 2098 -119 - Misses655 771 +116 - Partials 244 247 +3 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `48.58% <ø> (ø)` | | | backend-unit-test | `51.81% <ø> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `43.63% <0.00%> (-3.64%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | ... and [1 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=footer). Last update [7adefe1...0c54bc9](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1686: chore: improve System Info module
codecov-io edited a comment on pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686#issuecomment-808890206 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=h1) Report > Merging [#1686](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=desc) (0c54bc9) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/7adefe147f99a6422f02fa652bb1534b71c1c65f?el=desc) (7adefe1) will **decrease** coverage by `0.09%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1686 +/- ## == - Coverage 71.14% 71.05% -0.10% == Files 47 47 Lines3116 3116 == - Hits 2217 2214 -3 - Misses655 658 +3 Partials 244 244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.77% <ø> (-0.07%)` | :arrow_down: | | backend-e2e-test-ginkgo | `48.58% <ø> (ø)` | | | backend-unit-test | `51.81% <ø> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `43.63% <0.00%> (-3.64%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.95% <0.00%> (+0.60%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=footer). Last update [7adefe1...0c54bc9](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #3922: docs: tells users where they are
iamayushdas commented on pull request #3922: URL: https://github.com/apache/apisix/pull/3922#issuecomment-808893336 There's an error from Centos test only, i guess , what say @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1673: fix: unable to export route with nil methods field
nic-chen commented on a change in pull request #1673:
URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r602877478
##
File path: web/cypress/fixtures/export-route-dataset.json
##
@@ -131,7 +129,6 @@
}
},
"x-apisix-enable_websocket": false,
- "x-apisix-plugins": {},
Review comment:
@Jaycean do we have some test case for `x-apisix-plugins` not empty ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1686: chore: improve System Info module
codecov-io edited a comment on pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686#issuecomment-808890206 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=h1) Report > Merging [#1686](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=desc) (0c54bc9) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/7adefe147f99a6422f02fa652bb1534b71c1c65f?el=desc) (7adefe1) will **increase** coverage by `1.23%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1686 +/- ## == + Coverage 71.14% 72.38% +1.23% == Files 47 133 +86 Lines3116 5728+2612 Branches0 666 +666 == + Hits 2217 4146+1929 - Misses655 1338 +683 Partials 244 244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.77% <ø> (-0.07%)` | :arrow_down: | | backend-e2e-test-ginkgo | `48.58% <ø> (ø)` | | | backend-unit-test | `51.81% <ø> (+0.03%)` | :arrow_up: | | frontend-e2e-test | `73.96% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `43.63% <0.00%> (-3.64%)` | :arrow_down: | | [web/src/components/RightContent/AvatarDropdown.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9BdmF0YXJEcm9wZG93bi50c3g=) | `82.14% <0.00%> (ø)` | | | [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | `41.37% <0.00%> (ø)` | | | [web/src/components/RightContent/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9pbmRleC50c3g=) | `85.71% <0.00%> (ø)` | | | [web/src/pages/Dashboard/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9EYXNoYm9hcmQvc2VydmljZS50cw==) | `100.00% <0.00%> (ø)` | | | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <0.00%> (ø)` | | | [web/src/pages/Service/components/Preview.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL2NvbXBvbmVudHMvUHJldmlldy50c3g=) | `100.00% <0.00%> (ø)` | | | [...c/pages/Route/components/ResultView/ResultView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1Jlc3VsdFZpZXcvUmVzdWx0Vmlldy50c3g=) | `80.00% <0.00%> (ø)` | | | [.../src/pages/Route/components/Step1/ProxyRewrite.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1Byb3h5UmV3cml0ZS50c3g=) | `92.85% <0.00%> (ø)` | | | [web/src/pages/SSL/components/Step2/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMi9pbmRleC50c3g=) | `100.00% <0.00%> (ø)` | | | ... and [78 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1686/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=footer). Last update [7adefe1...0c54bc9](https://codecov.io/gh/apache/apisix-dashboard/pull/1686?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1673: fix: unable to export route with nil methods field
Jaycean commented on a change in pull request #1673:
URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r602878978
##
File path: web/cypress/fixtures/export-route-dataset.json
##
@@ -131,7 +129,6 @@
}
},
"x-apisix-enable_websocket": false,
- "x-apisix-plugins": {},
Review comment:
Yes, most of the other test cases have data in `x-apisix-plugins`
For example, this test case:
https://github.com/apache/apisix-dashboard/blob/73e96357c64ddc92551854577879b86a4ecee341/api/internal/handler/data_loader/route_export_test.go#L34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3920: request help: nginx: [emerg] invalid port in "table:" of the "listen" directive in ...
spacewander closed issue #3920: URL: https://github.com/apache/apisix/issues/3920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3920: request help: nginx: [emerg] invalid port in "table:" of the "listen" directive in ...
spacewander commented on issue #3920: URL: https://github.com/apache/apisix/issues/3920#issuecomment-808899494 The `enable_http2` feature is first added in 2.4. See: https://github.com/apache/apisix/pull/3547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #274: fix: add a bundle of good first issues links to homepage
1502shivam-singh commented on pull request #274: URL: https://github.com/apache/apisix-website/pull/274#issuecomment-808904115 > LGTM, and needs @1502shivam-singh's review :) > >  Just one minor thing can you make that GitHub logo png center aligned vertically with some padding like below -  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on pull request #274: fix: add a bundle of good first issues links to homepage
KishaniKandasamy commented on pull request #274: URL: https://github.com/apache/apisix-website/pull/274#issuecomment-808905764 > > LGTM, and needs @1502shivam-singh's review :) > >  > > Just one minor thing can you make that GitHub logo png center aligned vertically with some padding like below - >  yeah Sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3922: docs: tells users where they are
juzhiyuan commented on a change in pull request #3922:
URL: https://github.com/apache/apisix/pull/3922#discussion_r60261
##
File path: docs/en/latest/config.json
##
@@ -1,6 +1,11 @@
{
"version": 2.4,
"sidebar": [
+{
+ "type": "link",
+ "label": "Apache Apisix",
Review comment:
```suggestion
"label": "Apache APISIX",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #274: fix: add a bundle of good first issues links to homepage
juzhiyuan commented on pull request #274: URL: https://github.com/apache/apisix-website/pull/274#issuecomment-808907716  Hi, it looks like the icon is not aligned with text? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] whl739 opened a new issue #3923: request help: cancelable timer
whl739 opened a new issue #3923: URL: https://github.com/apache/apisix/issues/3923 Currently, apisix provides a background timer for logger related plugins, whitch is not universal. See this demand: a plugin may register a timer in `init` function, the timer will be recurring to pull data, and unregister it in `destroy` function, the phase functions may use these pulled data. But the current timer implemention is not possible to do that. How can i do this, any suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3924: test: make consul_kv stable
spacewander opened a new pull request #3924: URL: https://github.com/apache/apisix/pull/3924 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3923: request help: cancelable timer
spacewander commented on issue #3923: URL: https://github.com/apache/apisix/issues/3923#issuecomment-808910477 The timer is not logger only, we can use it in other plugins too. See: https://github.com/apache/apisix/blob/c9df9fca652d14d32c8331820640ed9344c4529a/apisix/plugins/server-info.lua#L241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-website] branch master updated: fix: add a bundle of good first issues links to homepage (#274)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new d68dc25 fix: add a bundle of good first issues links to homepage
(#274)
d68dc25 is described below
commit d68dc25c7847f1e932c77b80f82aec35eb6147bc
Author: Kishani Kandasamy <53715187+kishanikandas...@users.noreply.github.com>
AuthorDate: Sun Mar 28 20:45:52 2021 +0530
fix: add a bundle of good first issues links to homepage (#274)
---
website/docs/general/contributor-guide.md | 12 ++
website/src/css/customTheme.css | 39 ++-
website/src/pages/index.js| 23 ++
3 files changed, 68 insertions(+), 6 deletions(-)
diff --git a/website/docs/general/contributor-guide.md
b/website/docs/general/contributor-guide.md
index 6b30911..11670c4 100644
--- a/website/docs/general/contributor-guide.md
+++ b/website/docs/general/contributor-guide.md
@@ -39,6 +39,18 @@ git remote add upstream https://github.com/apache/apisix.git
3. Find a mentor from the Team page and your mentor will give you feedback
about your PR or issue in time.
+ **Good First Issues**:
+
+Good First Issue curates easy pickings from this project, and helps you make
your first contribution to Apache APISIX™.
+
+- [Apache
APISIX](https://github.com/apache/apisix/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
+- [Apache APISIX Ingress
Controller](https://github.com/apache/apisix-ingress-controller/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
+- [Apache APISIX
dashboard](https://github.com/apache/apisix-dashboard/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
+- [Apache APISIX Helm
Chart](https://github.com/apache/apisix-helm-chart/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
+- [Docker distribution for
APISIX](https://github.com/apache/apisix-docker/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
+- [Apache APISIX
Website](https://github.com/apache/apisix-website/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
+- [The Control-Plane for
APISIX](https://github.com/apache/apisix-control-plane/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
+
### Create your branch
Switch to your forked master branch, pull codes from upstream, then create a
new branch.
diff --git a/website/src/css/customTheme.css b/website/src/css/customTheme.css
index ecf9ad4..5d2d613 100644
--- a/website/src/css/customTheme.css
+++ b/website/src/css/customTheme.css
@@ -503,18 +503,45 @@ a:hover {
display: flex;
}
+/*contribution section*/
+.contribution {
+ justify-content: center;
+ margin-bottom: 100px;
+}
+
+.center-elem {
+ display: flex;
+ justify-content: center;
+}
+
+.contribution-text {
+ color: var(--color-primary);
+ text-align: center;
+}
+
+.contribution-link {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+}
+
+.contribution-logo {
+ vertical-align: middle;
+ margin: 0 12px 1px 0px;
+}
+
/*newsletter section*/
-.center-elem{
+.center-elem {
display: flex;
justify-content: center;
}
-.news-logo{
+.news-logo {
margin-bottom: 20px;
}
-.news-button{
+.news-button {
border: #111827;
padding: 5px 30px;
border-style: solid;
@@ -525,17 +552,17 @@ a:hover {
text-decoration: none;
transition: all 0.3s;
}
-.news-button:hover{
+.news-button:hover {
background: black;
color: white;
text-decoration: none;
}
-.news-logo-svg{
+.news-logo-svg {
height: 42px;
}
-.news-text{
+.news-text {
color: var(--color-primary);
text-align: center;
}
diff --git a/website/src/pages/index.js b/website/src/pages/index.js
index 8764552..d9a5269 100644
--- a/website/src/pages/index.js
+++ b/website/src/pages/index.js
@@ -205,6 +205,28 @@ const EventsSection = () => {
);
};
+const ContributionSection = () => {
+
+ return (
+
+
+Make your first contribution to Apache APISIX™
+
+
+Find a good first issue to get you started !
+
+
+
+
+ Good First Issues
+
+
+
+ );
+};
+
const NewsletterSection = () => {
return (
@@ -243,6 +265,7 @@ const Index = (props) => {
+
);
[GitHub] [apisix-website] juzhiyuan merged pull request #274: fix: add a bundle of good first issues links to homepage
juzhiyuan merged pull request #274: URL: https://github.com/apache/apisix-website/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #274: fix: add a bundle of good first issues links to homepage
juzhiyuan commented on pull request #274: URL: https://github.com/apache/apisix-website/pull/274#issuecomment-808910548 good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan closed issue #178: Add a bundle of Good first issues links to Homepage
juzhiyuan closed issue #178: URL: https://github.com/apache/apisix-website/issues/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1686: chore: improve System Info module
juzhiyuan commented on pull request #1686: URL: https://github.com/apache/apisix-dashboard/pull/1686#issuecomment-808910790 Hi! Thanks for your first contribution :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3922: docs: tells users where they are
spacewander merged pull request #3922: URL: https://github.com/apache/apisix/pull/3922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: tells users where they are (#3922)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 2b60d18 docs: tells users where they are (#3922)
2b60d18 is described below
commit 2b60d1801058e6351007696ce589c2df85748872
Author: Ayush das
AuthorDate: Sun Mar 28 20:53:47 2021 +0530
docs: tells users where they are (#3922)
Co-authored-by: 琚致远
---
docs/en/latest/config.json | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/en/latest/config.json b/docs/en/latest/config.json
index 902ea8a..f9eaad8 100644
--- a/docs/en/latest/config.json
+++ b/docs/en/latest/config.json
@@ -2,6 +2,11 @@
"version": 2.4,
"sidebar": [
{
+ "type": "link",
+ "label": "Apache APISIX",
+ "href" : "https://apisix.apache.org/docs/apisix/getting-started";
+},
+{
"type": "category",
"label": "Architecture Design",
"items": [
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1679: feat: autocomplete when people input http header
guoqqqi commented on pull request #1679: URL: https://github.com/apache/apisix-dashboard/pull/1679#issuecomment-808912724 LGTM! Hi, I can help you to add an E2E test to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1685: docs: tells users where they are
guoqqqi commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-808918555 Hi, @iamayushdas If we are sure to use Configure to replace Edit, the Chinese version of the Upstream page has not yet been replaced with Configure. Then I found a small problem when editing the page, the title should be `Edit **`, but now when editing it is `Create **`.  Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-808919338 > Hi, @iamayushdas If we are sure to use Configure to replace Edit, the Chinese version of the Upstream page has not yet been replaced with Configure. > > Then I found a small problem when editing the page, the title should be `Edit **`, but now when editing it is `Create **`. > >  > > Thank you. > > Okay let me look into this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1672: doc: add more details and examples to import openapi guide
liuxiran commented on a change in pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#discussion_r602901727 ## File path: docs/en/latest/IMPORT_OPENAPI_USER_GUIDE.md ## @@ -21,34 +21,21 @@ title: Import OpenAPI Guide # --> -The OpenAPI Specification (OAS) defines a standard, language-agnostic interface to RESTful APIs which allows both humans and computers to discover and understand the capabilities of the service without access to source code, documentation, or through network traffic inspection. - -Apache APISIX Dashboard supports importing [OpenApi3.0](https://swagger.io/specification/)(we will use OAS3.0 for short) files to create the Route. Currently we support support most of the OpenApi specifications, but there are some differences, which are in terms of compatibility and extended fields. - -## OAS3.0 Compatibility - -when we import routes from OAS3.0, some fields in OAS will be missed because there are not corresponding fields in APISIX's Route: - -1. [API General Info](https://swagger.io/docs/specification/api-general-info/): used to describe the general information about your API, some times, a oas file contains a series of apis which belong to a app, so this info is different from the api's name and extra basic info. - -2. [API server and base path](https://swagger.io/docs/specification/api-host-and-base-path/): upsream url + url prefix(options). - -3. [Path params](https://swagger.io/docs/specification/describing-parameters/): api params described in path. +## Overview -4. [Query params](https://swagger.io/docs/specification/describing-parameters/): api params described in query. +The OpenAPI Specification (OAS) defines a standard, language-agnostic interface to RESTful APIs which allows both humans and computers to discover and understand the capabilities of the service without access to source code, documentation, or through network traffic inspection. -5. [Responses description and links](https://swagger.io/docs/specification/describing-responses/): Define the responses for a API operations. +Apache APISIX Dashboard supports importing [OpenApi3.0](https://swagger.io/specification/)(we will use OAS3.0 for short) files, both `json` and `yaml` are supported, to create one or more Routes. Currently we support most of the OpenApi specifications, but there are some differences, which are in terms of compatibility and extended fields. ## Extended fields -There are some fields required in APISIX Route but are not included in the properties of OAS3.0, we added some extended fields such as upstream, plugins, hosts and so on. All extensions start with x-apisix. See [reference](https://apisix.apache.org/docs/apisix/admin-api/#route) For more details of the APISIX Route Properties +There are some fields required in APISIX Route but are not included in the properties of OAS3.0, inorder to provide convenience for extending custom route entities based on OAS3.0, we added some extended fields such as upstream, plugins, hosts and so on. All extensions start with x-apisix. See [reference](https://apisix.apache.org/docs/apisix/admin-api/#route) For more details of the APISIX Route Properties Review comment: fixed, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1672: doc: add more details and examples to import openapi guide
codecov-io edited a comment on pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#issuecomment-807310922 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=h1) Report > Merging [#1672](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=desc) (ca8ccfd) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **increase** coverage by `1.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1672 +/- ## == + Coverage 72.59% 74.04% +1.45% == Files 133 86 -47 Lines5728 2612-3116 Branches 666 666 == - Hits 4158 1934-2224 + Misses 1327 678 -649 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `74.04% <ø> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `77.04% <0.00%> (-3.28%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | | | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | | | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | | | | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | | | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | | | ... and [38 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=footer). Last update [c6c5d14...ca8ccfd](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1672: doc: add more details and examples to import openapi guide
codecov-io edited a comment on pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#issuecomment-807310922 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=h1) Report > Merging [#1672](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=desc) (b4af311) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **increase** coverage by `1.37%`. > The diff coverage is `n/a`. > :exclamation: Current head b4af311 differs from pull request most recent head ca8ccfd. Consider uploading reports for the commit ca8ccfd to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1672 +/- ## == + Coverage 72.59% 73.96% +1.37% == Files 133 86 -47 Lines5728 2612-3116 Branches 666 666 == - Hits 4158 1932-2226 + Misses 1327 680 -647 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.96% <ø> (-0.16%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `77.04% <0.00%> (-3.28%)` | :arrow_down: | | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `78.08% <0.00%> (-1.37%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | | | | [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | | | | [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | | | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | | | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | | | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | | | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | | | ... and [39 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=footer). Last update [c6c5d14...ca8ccfd](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1672: doc: add more details and examples to import openapi guide
codecov-io edited a comment on pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#issuecomment-807310922 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=h1) Report > Merging [#1672](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=desc) (d1960db) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **increase** coverage by `1.37%`. > The diff coverage is `n/a`. > :exclamation: Current head d1960db differs from pull request most recent head d502f5c. Consider uploading reports for the commit d502f5c to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1672 +/- ## == + Coverage 72.59% 73.96% +1.37% == Files 133 86 -47 Lines5728 2612-3116 Branches 666 666 == - Hits 4158 1932-2226 + Misses 1327 680 -647 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.96% <ø> (-0.16%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `77.04% <0.00%> (-3.28%)` | :arrow_down: | | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `78.08% <0.00%> (-1.37%)` | :arrow_down: | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | | | [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | | | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | | | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | | | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | | | ... and [39 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=footer). Last update [c6c5d14...d502f5c](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] diaosj commented on issue #3917: request help: question about Prometheus memory consumption
diaosj commented on issue #3917: URL: https://github.com/apache/apisix/issues/3917#issuecomment-808949145 > https://github.com/apache/apisix/blob/83931ba0a5c95e04ec867a4ffd0821d426ca0d27/apisix/cli/ngx_tpl.lua#L131 > > I would appreciate it if you can make it configurable. Thanks! Looks like I can config it in `config-default.yaml`. I will try this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio commented on issue #1684: program panic when failed to initialize etcd store is unreasonable
batman-ezio commented on issue #1684: URL: https://github.com/apache/apisix-dashboard/issues/1684#issuecomment-808980058 that also happens when ectd is unable to connect -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1610: feat: improve the config plugin button enable disable status
codecov-io edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=h1) Report > Merging [#1610](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=desc) (714c999) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **decrease** coverage by `20.77%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#1610 +/- ## === - Coverage 72.59% 51.81% -20.78% === Files 133 38 -95 Lines5728 2650 -3078 Branches 6660 -666 === - Hits 4158 1373 -2785 + Misses 1327 1089 -238 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.77%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [118 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=footer). Last update [c6c5d14...714c999](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1610: feat: improve the config plugin button enable disable status
codecov-io edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=h1) Report > Merging [#1610](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=desc) (714c999) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **decrease** coverage by `5.13%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1610 +/- ## == - Coverage 72.59% 67.45% -5.14% == Files 133 47 -86 Lines5728 3116-2612 Branches 6660 -666 == - Hits 4158 2102-2056 + Misses 1327 767 -560 - Partials 243 247 +4 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `48.71% <ø> (+0.44%)` | :arrow_up: | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-7.48%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.27% <0.00%> (-1.82%)` | :arrow_down: | | ... and [86 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=footer). Last update [c6c5d14...714c999](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1610: feat: improve the config plugin button enable disable status
codecov-io edited a comment on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-803254054 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=h1) Report > Merging [#1610](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=desc) (714c999) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **decrease** coverage by `1.40%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1610 +/- ## == - Coverage 72.59% 71.18% -1.41% == Files 133 47 -86 Lines5728 3116-2612 Branches 6660 -666 == - Hits 4158 2218-1940 + Misses 1327 654 -673 - Partials 243 244 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.90% <ø> (-0.23%)` | :arrow_down: | | backend-e2e-test-ginkgo | `48.71% <ø> (+0.44%)` | :arrow_up: | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `71.02% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.27% <0.00%> (-1.82%)` | :arrow_down: | | [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | | | | [...Route/components/DebugViews/AuthenticationView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvQXV0aGVudGljYXRpb25WaWV3LnRzeA==) | | | | [...eb/src/pages/PluginTemplate/components/Preview.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1ByZXZpZXcudHN4) | | | | [web/src/pages/User/Login.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ2luLnRzeA==) | | | | [web/src/pages/Setting/Setting.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TZXR0aW5nL1NldHRpbmcudHN4) | | | | [web/src/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb25zdGFudHMudHM=) | | | | [web/src/pages/Service/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0xpc3QudHN4) | | | | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | | | | ... and [78 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1610/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=footer). Last update [c6c5d14...714c999](https://codecov.io/gh/apache/apisix-dashboard/pull/1610?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] stu01509 opened a new pull request #275: Feat #216 add project 2
stu01509 opened a new pull request #275: URL: https://github.com/apache/apisix-website/pull/275 Fixes: #216 Changes: Add the **apisix-project** project. Screenshots of the change: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1682: Updating URI of an existing route causes 404 error
nic-chen commented on issue #1682: URL: https://github.com/apache/apisix-dashboard/issues/1682#issuecomment-808996364 @bisakhmondal what is the content in nginx.conf and is there error log for this？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: test: show how to bypass the ctx.var cache (#3914)
This is an automated email from the ASF dual-hosted git repository. shuyangw pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 3ba24c4 test: show how to bypass the ctx.var cache (#3914) 3ba24c4 is described below commit 3ba24c47d45bf47bf81abf93394bc45bacf0eb6c Author: 罗泽轩 AuthorDate: Mon Mar 29 08:53:32 2021 +0800 test: show how to bypass the ctx.var cache (#3914) Signed-off-by: spacewander --- t/plugin/proxy-rewrite2.t | 34 ++ 1 file changed, 34 insertions(+) diff --git a/t/plugin/proxy-rewrite2.t b/t/plugin/proxy-rewrite2.t index b1a4461..5045792 100644 --- a/t/plugin/proxy-rewrite2.t +++ b/t/plugin/proxy-rewrite2.t @@ -70,3 +70,37 @@ upstreams: --- error_code: 503 --- error_log Can't detect upstream's scheme + + + +=== TEST 2: access $upstream_uri before proxy-rewrite +--- apisix_yaml +global_rules: + - +id: 1 +plugins: + serverless-pre-function: +phase: rewrite +functions: +- "return function() ngx.log(ngx.WARN, 'serverless [', ngx.var.upstream_uri, ']') end" +routes: + - +id: 1 +uri: /hello +plugins: +proxy-rewrite: +uri: "/plugin_proxy_rewrite" +upstream_id: 1 +upstreams: + - +id: 1 +nodes: +"127.0.0.1:1980": 1 +type: roundrobin +#END +--- error_log +serverless [] +--- response_body +uri: /plugin_proxy_rewrite +host: localhost +scheme: http
[GitHub] [apisix] Yiyiyimu merged pull request #3914: test: show how to bypass the ctx.var cache
Yiyiyimu merged pull request #3914: URL: https://github.com/apache/apisix/pull/3914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] tokers commented on a change in pull request #275: Feat #216 add project 2
tokers commented on a change in pull request #275:
URL: https://github.com/apache/apisix-website/pull/275#discussion_r602963516
##
File path: website/docusaurus.config.js
##
@@ -60,6 +60,17 @@ module.exports = {
releaseDate: "2021-03-12",
firstDocPath: "/apisix",
},
+ {
+name: "APISIX™ Docker",
+nameInParamCase: "docker",
+description: "The docker for Apache APISIX.",
Review comment:
What about "Docker tooling for Apache APISIX."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on issue #1684: program panic when failed to initialize etcd store is unreasonable
tokers commented on issue #1684: URL: https://github.com/apache/apisix-dashboard/issues/1684#issuecomment-809001865 > that also happens when ectd is unable to connect Yep, let it crash is not a good way here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3247: feat: add basic EditorConfig file to help maintain consistent coding …
Yiyiyimu commented on pull request #3247: URL: https://github.com/apache/apisix/pull/3247#issuecomment-809002482 > Yes we should move this PR and include it in the GitHub Super Linter PR #3045 Hi @jbampton I thought we've already moved this PR to #3045 🤣 Besides, if I take it right, we could only check `EditorConfig` when we have `Super Linter`, so it would be better to merge #3045 first and then this one I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1673: fix: unable to export route with nil methods field
tokers commented on a change in pull request #1673:
URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r602968683
##
File path: api/internal/handler/data_loader/route_export.go
##
@@ -245,8 +246,14 @@ func (h *Handler) RouteToOpenAPI3(c droplet.Context,
routes []*entity.Route) (*o
path.RequestBody = &openapi3.RequestBodyRef{Value: requestBody}
path.Responses = openapi3.NewResponses()
- for i := range route.Methods {
- switch strings.ToUpper(route.Methods[i]) {
+ if route.Methods != nil && len(route.Methods) > 0 {
+ routeMethods = route.Methods
+ } else {
+ routeMethods = []string{http.MethodGet,
http.MethodPost, http.MethodPut, http.MethodDelete, http.MethodPatch,
http.MethodHead, http.MethodConnect, http.MethodTrace, http.MethodOptions}
Review comment:
I mean creating a variable `_allHTTPMethods`, which is:
```go
var (
_allHTTPMethods = []string{http.MethodGet, http.MethodPost, ...}
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #312: bug: Modify the route.yaml configuration to not update apisix synchronously
tokers commented on issue #312: URL: https://github.com/apache/apisix-ingress-controller/issues/312#issuecomment-809011741 @pioneer-hash Thanks for your report, I have captured this bug, I will fix it as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1673: fix: unable to export route with nil methods field
starsz commented on a change in pull request #1673:
URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r602973125
##
File path: web/cypress/fixtures/export-route-dataset.json
##
@@ -131,7 +129,6 @@
}
},
"x-apisix-enable_websocket": false,
- "x-apisix-plugins": {},
Review comment:
Thank you for the explanation.Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1673: fix: unable to export route with nil methods field
starsz commented on a change in pull request #1673:
URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r602973342
##
File path: api/test/e2e/route_export_test.go
##
@@ -2505,6 +2503,499 @@ func TestRoute_Export_Equal_URI(t *testing.T) {
}
+func TestRoute_Export_Methods_Feild_Empty(t *testing.T) {
+ exportStr := `{
+ "components": {},
+ "info": {
+ "title": "RoutesExport",
+ "version": "3.0.0"
+ },
+ "openapi": "3.0.0",
+ "paths": {
+ "/test-test": {
+ "connect": {
+ "operationId": "route_allCONNECT",
+ "requestBody": {},
+ "responses": {
+ "default": {
+ "description": ""
+ }
+ },
+ "summary": "所有",
+ "x-apisix-enable_websocket": false,
+ "x-apisix-hosts": ["test.com"],
+ "x-apisix-priority": 0,
+ "x-apisix-status": 1,
+ "x-apisix-upstream": {
+ "nodes": {
+ "172.16.238.20:1980": 1
+ },
+ "type": "roundrobin"
+ }
+ },
+ "delete": {
+ "operationId": "route_allDELETE",
+ "requestBody": {},
+ "responses": {
+ "default": {
+ "description": ""
+ }
+ },
+ "summary": "所有",
+ "x-apisix-enable_websocket": false,
+ "x-apisix-hosts": ["test.com"],
+ "x-apisix-priority": 0,
+ "x-apisix-status": 1,
+ "x-apisix-upstream": {
+ "nodes": {
+ "172.16.238.20:1980": 1
+ },
+ "type": "roundrobin"
+ }
+ },
+ "get": {
+ "operationId": "route_allGET",
+ "requestBody": {},
+ "responses": {
+ "default": {
+ "description": ""
+ }
+ },
+ "summary": "所有",
+ "x-apisix-enable_websocket": false,
+ "x-apisix-hosts": ["test.com"],
+ "x-apisix-priority": 0,
+ "x-apisix-status": 1,
+ "x-apisix-upstream": {
+ "nodes": {
+ "172.16.238.20:1980": 1
+ },
+ "type": "roundrobin"
+ }
+ },
+ "head": {
+ "operationId": "route_allHEAD",
+ "requestBody": {},
+ "responses": {
+ "default": {
+ "description": ""
+ }
+ },
+ "summary": "所有",
+ "x-apisix-enable_websocket": false,
+ "x-apisix-hosts": ["test.com"],
+ "x-apisix-priority": 0,
+ "x-apisix-status": 1,
+
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1673: fix: unable to export route with nil methods field
Jaycean commented on a change in pull request #1673:
URL: https://github.com/apache/apisix-dashboard/pull/1673#discussion_r602977216
##
File path: api/internal/handler/data_loader/route_export.go
##
@@ -245,8 +246,14 @@ func (h *Handler) RouteToOpenAPI3(c droplet.Context,
routes []*entity.Route) (*o
path.RequestBody = &openapi3.RequestBodyRef{Value: requestBody}
path.Responses = openapi3.NewResponses()
- for i := range route.Methods {
- switch strings.ToUpper(route.Methods[i]) {
+ if route.Methods != nil && len(route.Methods) > 0 {
+ routeMethods = route.Methods
+ } else {
+ routeMethods = []string{http.MethodGet,
http.MethodPost, http.MethodPut, http.MethodDelete, http.MethodPatch,
http.MethodHead, http.MethodConnect, http.MethodTrace, http.MethodOptions}
Review comment:
Sorry, I misunderstood.
Done. Thks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] zhangguanzhang commented on issue #487: Who is using APISIX？（欢迎使用 APISIX 的个人和公司在此留言）
zhangguanzhang commented on issue #487: URL: https://github.com/apache/apisix/issues/487#issuecomment-809019375 组织：金山办公 地址：中国:武汉，珠海 联系方式：zhangguanzh...@qq.com 使用场景：产品线较多，入口需要一个网关来管理所有url -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
Jaycean commented on pull request #1675:
URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-809023973
> Okay, @Jaycean, I'm opening an issue.
> See the ci is also failing with a 404 for that particular test.
>
@bisakhmondal
This error is that the URI created by APISIX is forwarded to the upstream,
and the corresponding interface is also required. I checked the conf in the
upstream image and found that the supporting interface is `hello` `hello1`
`hello_` You can change update URI to `hello_`
File path：In the docker container: johz/upstream
/usr/local/openresty/nginx/conf/lua/server.lua
```
function _M.hello()
ngx.say("hello world")
end
function _M.hello1()
ngx.say("hello1 world")
end
function _M.hello_()
ngx.say("hello world")
end
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
Jaycean edited a comment on pull request #1675:
URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-809023973
> Okay, @Jaycean, I'm opening an issue.
> See the ci is also failing with a 404 for that particular test.
>
@bisakhmondal
This error is that the URI created by APISIX is forwarded to the upstream,
and the corresponding interface is also required. I checked the conf in the
upstream image and found that the supporting interface is `hello` `hello1`
`hello_` You can change update URI to `hello_`
File path：In the docker container: johz/upstream
/usr/local/openresty/nginx/conf/lua/server.lua
```
function _M.hello()
ngx.say("hello world")
end
function _M.hello1()
ngx.say("hello1 world")
end
function _M.hello_()
ngx.say("hello world")
end
```
`hellohello` is not supported in the upstream interface, so the error
returned is 404.
```
function _M.go()
local action = string.sub(ngx.var.uri, 2)
action = string.gsub(action, "[/\\.]", "_")
if not action or not _M[action] then
return ngx.exit(404)
end
inject_headers()
return _M[action]()
end
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809025188 > > Hi, @iamayushdas If we are sure to use Configure to replace Edit, the Chinese version of the Upstream page has not yet been replaced with Configure. > > Then I found a small problem when editing the page, the title should be `Edit **`, but now when editing it is `Create **`. > >  > > Thank you. > > Okay let me look into this @juzhiyuan after looking into the fix raised by @guoqqqi this, i got to know many of the routings was wrongly done like "Service and upstream". parameters were not set correctly. so should i fix this in the same PR or should i raise an issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1685: docs: tells users where they are
iamayushdas commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809031431 @juzhiyuan should i change the path name of edit to configure for all or not, i guess that would be good. What say? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1685: docs: tells users where they are
iamayushdas edited a comment on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809025188 > > Hi, @iamayushdas If we are sure to use Configure to replace Edit, the Chinese version of the Upstream page has not yet been replaced with Configure. > > Then I found a small problem when editing the page, the title should be `Edit **`, but now when editing it is `Create **`. > >  > > Thank you. > > Okay let me look into this @juzhiyuan after looking into the fix suggested by @guoqqqi above, i got to know many of the routings was wrongly done like "Service and upstream". parameters were not set correctly. so should i fix this in the same PR or should i raise an issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3925: feat(skywalking): allow destory and configure report interval for rep…
spacewander opened a new pull request #3925: URL: https://github.com/apache/apisix/pull/3925 …orter Fix #2895 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1672: doc: add more details and examples to import openapi guide
codecov-io edited a comment on pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#issuecomment-807310922 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=h1) Report > Merging [#1672](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=desc) (d502f5c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **increase** coverage by `1.37%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1672 +/- ## == + Coverage 72.59% 73.96% +1.37% == Files 133 86 -47 Lines5728 2612-3116 Branches 666 666 == - Hits 4158 1932-2226 + Misses 1327 680 -647 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.96% <ø> (-0.16%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `77.04% <0.00%> (-3.28%)` | :arrow_down: | | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `78.08% <0.00%> (-1.37%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | | | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | | | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | | | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | | | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | | | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | | | ... and [39 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=footer). Last update [c6c5d14...d502f5c](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3883: feat: add 5xx error page
spacewander commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r602991217
##
File path: apisix/error_handler.lua
##
@@ -0,0 +1,54 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local ngx = ngx
+
+
+local html_5xx = [[
+
+
+
+
+
+Error
+
+body {
+width: 35em;
+margin: 0 auto;
+font-family: Tahoma, Verdana, Arial, sans-serif;
+}
+
+
+
+An error occurred.
+Sorry, the page you are looking for is currently unavailable.
+Please try again later.
+If you are the system administrator of this resource then you should check
+the https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L135";>error
log
Review comment:
What about removing the entire link? People may have their error log
configuration in the `config.yaml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1685: docs: tells users where they are
iamayushdas edited a comment on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809025188 > > Hi, @iamayushdas If we are sure to use Configure to replace Edit, the Chinese version of the Upstream page has not yet been replaced with Configure. > > Then I found a small problem when editing the page, the title should be `Edit **`, but now when editing it is `Create **`. > >  > > Thank you. > > Okay let me look into this @juzhiyuan after looking into the fix suggested by @guoqqqi above, i got to know many of the routings was wrongly done like "Service ,upstream, consumer". parameters were not set correctly. so should i fix this in the same PR or should i raise an issue? fixed: (see screenshots)    -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] whl739 commented on issue #3923: request help: cancelable timer
whl739 commented on issue #3923: URL: https://github.com/apache/apisix/issues/3923#issuecomment-809036856 The background timer can not set a interval time, and the callback function have to check the time by itself, it's not easy to use. It's implemention is that spawn registed timer threads, and wait them to finish, if one timer cost too much time, other timers will be affected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] pioneer-hash opened a new issue #317: request help: Could not resolve host:
pioneer-hash opened a new issue #317:
URL: https://github.com/apache/apisix-ingress-controller/issues/317
### Issue description
When I install INGRESS-Controller I start creating the route , unable to
synchronize configuration.
this is my ingress-log:
2021-03-29T10:35:41+08:00 error apisix/upstream.go:119 failed to
get upstream from APISIX {"fullname": "default_web-huido_80", "url":
"http://apisix-admin:9180/apisix/admin/upstreams/450a096f";, "cluster": "",
"error": "Get http://apisix-admin:9180/apisix/admin/upstreams/450a096f:
net/http: request canceled while waiting for connection (Client.Timeout
exceeded while awaiting headers)"}
2021-03-29T10:35:41+08:00 error state/builder.go:176failed to
find upstream default_web-huido_80: Get
http://apisix-admin:9180/apisix/admin/upstreams/450a096f: net/http: request
canceled while waiting for connection (Client.Timeout exceeded while awaiting
headers)
2021-03-29T10:36:44+08:00 error apisix/upstream.go:119 failed to
get upstream from APISIX {"fullname": "default_web-huido_80", "url":
"http://apisix-admin:9180/apisix/admin/upstreams/450a096f";, "cluster": "",
"error": "Get http://apisix-admin:9180/apisix/admin/upstreams/450a096f:
net/http: request canceled while waiting for connection (Client.Timeout
exceeded while awaiting headers)"}
2021-03-29T10:36:44+08:00 error controller/endpoint.go:146
failed to get upstream {"upstream": "default_web-huido_80", "cluster": "name=;
base_url=http://apisix-admin:9180/apisix/admin";, "error": "Get
http://apisix-admin:9180/apisix/admin/upstreams/450a096f: net/http: request
canceled while waiting for connection (Client.Timeout exceeded while awaiting
headers)"}
this is Request inside the container :
curl http://apisix-admin:9180/apisix/admin/upstreams/450a096f
curl: (6) Could not resolve host: apisix-admin; Unknown error
### Environment
* your apisix-ingress-controller version (output of
`apisix-ingress-controller version --long`);
* your Kubernetes cluster version (output of `kubectl version`);
* if you run apisix-ingress-controller in Bare-metal environment, also show
your OS version (`uname -a`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1685: docs: tells users where they are
iamayushdas edited a comment on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809025188 @juzhiyuan after looking into the fix suggested by @guoqqqi above, i got to know many of the routings was wrongly done like "Service ,upstream, consumer". parameters were not set correctly. so should i fix this in the same PR or should i raise an issue? fixed: (see screenshots)    Plugin market title also internationalised:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1685: docs: tells users where they are
iamayushdas edited a comment on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809025188 @juzhiyuan after looking into the fix suggested by @guoqqqi above, i got to know many of the routings was wrongly done like "Service ,upstream, consumer". parameters were not set correctly. so should i fix this in the same PR or should i raise an issue? fixed: (see screenshots)    Plugin market title also internationalised:  should i push this now? @guoqqqi @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3923: request help: timer enhancement
spacewander commented on issue #3923: URL: https://github.com/apache/apisix/issues/3923#issuecomment-809050063 > The background timer can not set a interval time, and the callback function have to check the time by itself, it's not easy to use. Yes, as OpenResty doesn't provide a cancel_timer API, we have to do the "cancel" job in the callback. > if one timer cost too much time, other timers will be affected Not exactly. The `core.timer` use `timer.every` API, so each group of timers' fire time is not affected by the last timer group. And each timer in the same group is run in a separate thread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3926: ci: the last day of travis
spacewander opened a new pull request #3926: URL: https://github.com/apache/apisix/pull/3926 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3927: test: enable master-worker mode by default
spacewander opened a new pull request #3927: URL: https://github.com/apache/apisix/pull/3927 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] whl739 commented on issue #3923: request help: timer enhancement
whl739 commented on issue #3923: URL: https://github.com/apache/apisix/issues/3923#issuecomment-809056944 But also `core.timer` provides `self.running` to prevent callback function to run repeatly, timers are still affected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] KMFtcy opened a new issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
KMFtcy opened a new issue #3928:
URL: https://github.com/apache/apisix/issues/3928
### Issue description
Hi there!
I'm running apisix in a docker container. The docker image built from
project https://github.com/apache/apisix-docker with command below
```
docker build --build-arg APISIX_VERSION=2.3 --build-arg
APISIX_DASHBOARD_VERSION=v2.4 -t apache/apisix-dashboard:whole -f
./all-in-one/apisix-dashboard/Dockerfile .
```
But when I access one route, it says:
```
{"message":"Missing JWT token in request"}
```
But I set no plugin at all.
Here is my apisix config
```
apisix:
node_listen: 2# APISIX listening port
```
And here's what returns when execute ”curl
"http://localhost:2/apisix/admin/routes/"; -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' | jq”
```
{
"node": {
"key": "/apisix/routes",
"dir": true,
"nodes": [
{
"createdIndex": 435,
"key": "/apisix/routes/347805553193389723",
"value": {
"vars": {},
"uris": [
"/grafana/*"
],
"update_time": 1616917694,
"upstream_id": "347806311959760539",
"hosts": [
"***" # a normal host
],
"status": 1,
"id": "347805553193389723",
"methods": [
"GET",
"HEAD",
"POST",
"PUT",
"DELETE",
"OPTIONS",
"PATCH"
],
"create_time": 1616837864,
"name": "grafana"
},
"modifiedIndex": 1794
},
..
]
},
"count": "1",
"action": "get"
}
```
And this is what it returns when I execute "curl localhost:2/grafana/ -H
'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1"
```
{"message":"Missing JWT token in request"}
```
Please tell me how to turn off JWT authentication.
### Environment
* apisix version (cmd: `apisix version`): build from master
* OS (cmd: `uname -a`): Linux 6a472e73906d 5.4.0-67-generic #75-Ubuntu SMP
Fri Feb 19 18:03:38 UTC 2021 x86_64 Linux (run in docker)
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
openresty/1.19.3.1
* etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): 3.4
* apisix-dashboard version, if have:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] qian0817 opened a new pull request #3929: docs: Improve proxy-rewrite plugin docs
qian0817 opened a new pull request #3929: URL: https://github.com/apache/apisix/pull/3929 change proxy rewrite to proxy-rewrite ### What this PR does / why we need it: In the proxy-rewrite.md document, some plugin names are proxy rewrite, which is a typo. related issue : #3145 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
tokers commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809077781 @KMFtcy Is there any consumer data in your APISIX? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #317: request help: Could not resolve host:
tokers commented on issue #317: URL: https://github.com/apache/apisix-ingress-controller/issues/317#issuecomment-809079408 @pioneer-hash I have re-organized the description so that it can be more clear. BTW, please add the environment information in the text. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
bisakhmondal commented on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-809080765 Wonderful @Jaycean❤️. Thank you for the elaborated information. So the whole time the 404 was thrown by upstream itself😶. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
Jaycean commented on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-809081483 > Wonderful @Jaycean. Thank you for the elaborated information. > So the whole time the 404 was thrown by upstream itself. Yes, after all, this upstream is just for testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
bisakhmondal commented on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-809088311 > Yes, after all, this upstream is just for testing No issues. Totally agree with you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1682: Updating URI of an existing route causes 404 error
bisakhmondal commented on issue #1682: URL: https://github.com/apache/apisix-dashboard/issues/1682#issuecomment-809093438 Thanks, @nic-chen, @starsz for looking into this. Actually, the error has nothing to do with manager-api. Thanks to @Jaycean, only `/hello`, `/hello_` and `/hello1` routes are whitelisted on the upstream docker image that we are currently using for testing [ [ref](https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-809023973) ]. So in the case of `newhello` it's a 404 from upstream itself. The issue isn't relevant anymore to keep it open. Thanks again, everyone. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal closed issue #1682: Updating URI of an existing route causes 404 error
bisakhmondal closed issue #1682: URL: https://github.com/apache/apisix-dashboard/issues/1682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809095854 @tokers No. Is it necessary to bind a consumer to a route? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #3929: docs: Improve proxy-rewrite plugin docs
Firstsawyou commented on pull request #3929: URL: https://github.com/apache/apisix/pull/3929#issuecomment-809097623 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aiyiyi121 opened a new issue #3930: request help: What’s the function of export OpenAPI on the dashboard
aiyiyi121 opened a new issue #3930: URL: https://github.com/apache/apisix/issues/3930 ### Issue description What’s the function of export OpenAPI on the dashboard, why can't I export the configuration of routes and upstreams correctly through it. And how can I export API configuration to yaml configuration? ### Environment apisix version (cmd: apisix version): 2.4 OS (cmd: uname -a): Ubuntu 16.04.2 LTS OpenResty / Nginx version (cmd: nginx -V or openresty -V): openresty/1.19.3.1 etcd version, if have (cmd: run curl http://127.0.0.1:9090/v1/server_info to get the info from server-info API): 3.4.13 apisix-dashboard version, if have: 2.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
codecov-io edited a comment on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-808024334 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr&el=h1) Report > Merging [#1675](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr&el=desc) (a30f011) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/88f323285f2bdbafca027da9aef357b2e3eb4008?el=desc) (88f3232) will **increase** coverage by `1.55%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#1675 +/- ## == + Coverage 72.41% 73.96% +1.55% == Files 133 86 -47 Lines5728 2612-3116 Branches 666 666 == - Hits 4148 1932-2216 + Misses 1337 680 -657 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | | | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | | | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | | | ... and [37 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr&el=footer). Last update [88f3232...a30f011](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
Firstsawyou commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809104963 @KMFtcy You need to check the following two points: 1. Is the jwt-auth plugin configured in your consumer object? If so, you need to check whether the jwt-auth plugin is enabled in the route? 2. Is the jwt-auth plugin enabled in `global_rules`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] aiyiyi121 opened a new issue #1687: request help: What’s the function of export OpenAPI on the dashboard
aiyiyi121 opened a new issue #1687: URL: https://github.com/apache/apisix-dashboard/issues/1687 ### Issue description What’s the function of export OpenAPI on the dashboard, why can't I export the configuration of routes and upstreams correctly through it. And how can I export API configuration to yaml configuration? ### Environment apisix version (cmd: apisix version): 2.4 OS (cmd: uname -a): Ubuntu 16.04.2 LTS OpenResty / Nginx version (cmd: nginx -V or openresty -V): openresty/1.19.3.1 etcd version, if have (cmd: run curl http://127.0.0.1:9090/v1/server_info to get the info from server-info API): 3.4.13 apisix-dashboard version, if have: 2.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3870: feat(traffic-split): the upstream pass_host needs to support IP mode
spacewander commented on a change in pull request #3870: URL: https://github.com/apache/apisix/pull/3870#discussion_r603046994 ## File path: apisix/plugins/traffic-split.lua ## @@ -148,26 +148,18 @@ end local function set_pass_host(ctx, upstream_info, host) --- Currently only supports a single upstream of the domain name. --- When the upstream is `IP`, do not do any `pass_host` operation. -if not core.utils.parse_ipv4(host) - and not core.utils.parse_ipv6(host) -then -local pass_host = upstream_info.pass_host or "pass" -if pass_host == "pass" then -ctx.var.upstream_host = ctx.var.host -return -end - -if pass_host == "rewrite" then -ctx.var.upstream_host = upstream_info.upstream_host -return -end +local pass_host = upstream_info.pass_host or "pass" +if pass_host == "pass" then +return +end -ctx.var.upstream_host = host +if pass_host == "rewrite" then +ctx.var.upstream_host = upstream_info.upstream_host return end +-- only support single node for `node` mode currently +ctx.var.upstream_host = host return Review comment: We don't need an extra `return` at the end of the function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809118141 @Firstsawyou Thanks for your reply. 1. I have check and I'm sure jwt-auth is not enabled in my routes. 2. Where can I config `global_rules` ? I cannot find it in `config-default.yaml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809118653 And By the way, I have tried to create a consumer but it always says `invalid json data` like this:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
