[GitHub] [apisix] membphis commented on a change in pull request #3925: feat(skywalking): allow destory and configure report interval for rep…
membphis commented on a change in pull request #3925:
URL: https://github.com/apache/apisix/pull/3925#discussion_r603401795
##
File path: docs/en/latest/plugins/skywalking.md
##
@@ -91,7 +91,8 @@ We can set the endpoint by specified the configuration in
`conf/config.yaml`.
| | -- | |
|
| service_name | string | "APISIX" | service name for skywalking reporter
|
|service_instance_name|string|"APISIX Instance Name" | service instance name
for skywalking reporter |
-| endpoint | string | "http://127.0.0.1:12800; | the http endpoint of
Skywalking, for example: http://127.0.0.1:12800 |
+| endpoint_addr| string | "http://127.0.0.1:12800; | the http endpoint of
Skywalking, for example: http://127.0.0.1:12800 |
Review comment:
nice catch!!
##
File path: apisix/plugins/skywalking.lua
##
@@ -127,8 +130,22 @@ function _M.init()
metadata_shdict:set('serviceInstanceName',
local_plugin_info.service_instance_name)
local sk_cli = require("skywalking.client")
+if local_plugin_info.report_interval then
+sk_cli.backendTimerDelay = local_plugin_info.report_interval
+end
+
sk_cli:startBackendTimer(local_plugin_info.endpoint_addr)
end
+function _M.destroy()
+if process.type() ~= "worker" and process.type() ~= "single" then
Review comment:
we can remove `process.type() ~= "single"`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] membphis merged pull request #3927: test: enable master-worker mode by default
membphis merged pull request #3927: URL: https://github.com/apache/apisix/pull/3927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: test: enable master-worker mode by default (#3927)
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 86e168e test: enable master-worker mode by default (#3927)
86e168e is described below
commit 86e168e711713531eeafdd0a75682b150e0d0109
Author: 罗泽轩
AuthorDate: Mon Mar 29 23:38:07 2021 +0800
test: enable master-worker mode by default (#3927)
---
apisix/debug.lua | 2 +-
apisix/plugins/skywalking.lua | 2 +-
apisix/timers.lua | 2 +-
t/APISIX.pm | 1 +
t/admin/plugins-reload.t | 1 -
t/config-center-yaml/plugin-configs.t | 1 -
t/config-center-yaml/plugin.t | 2 ++
t/core/config_etcd.t | 1 +
t/core/random.t | 1 -
t/debug/debug-mode.t | 4 +---
t/discovery/dns/mix.t | 1 -
t/discovery/dns/sanity.t | 1 -
t/node/healthcheck-discovery.t| 1 -
t/node/healthcheck-ipv6.t | 1 -
t/node/healthcheck-multiple-worker.t | 1 -
t/node/healthcheck-passive.t | 1 -
t/node/healthcheck-stop-checker.t | 1 -
t/node/healthcheck.t | 1 -
t/node/healthcheck2.t | 1 -
t/node/plugin-configs.t | 1 -
t/node/route-delete.t | 5 +
t/node/upstream-discovery.t | 1 -
t/plugin/error-log-logger.t | 1 -
t/plugin/fault-injection2.t | 1 -
t/plugin/node-status.t| 1 -
t/plugin/server-info.t| 1 -
t/plugin/traffic-split2.t | 1 -
t/stream-node/random.t| 1 -
28 files changed, 13 insertions(+), 26 deletions(-)
diff --git a/apisix/debug.lua b/apisix/debug.lua
index b0ab038..8cd0135 100644
--- a/apisix/debug.lua
+++ b/apisix/debug.lua
@@ -201,7 +201,7 @@ end
function _M.init_worker()
-if process.type() ~= "worker" and process.type() ~= "single" then
+if process.type() ~= "worker" then
return
end
diff --git a/apisix/plugins/skywalking.lua b/apisix/plugins/skywalking.lua
index cd66035..c0f74f3 100644
--- a/apisix/plugins/skywalking.lua
+++ b/apisix/plugins/skywalking.lua
@@ -102,7 +102,7 @@ end
function _M.init()
-if process.type() ~= "worker" and process.type() ~= "single" then
+if process.type() ~= "worker" then
return
end
diff --git a/apisix/timers.lua b/apisix/timers.lua
index a08f651..b30c269 100644
--- a/apisix/timers.lua
+++ b/apisix/timers.lua
@@ -53,7 +53,7 @@ end
local function is_privileged()
-return process.type() == "privileged agent" or process.type() == "single"
+return process.type() == "privileged agent"
end
diff --git a/t/APISIX.pm b/t/APISIX.pm
index 2c96712..2182430 100644
--- a/t/APISIX.pm
+++ b/t/APISIX.pm
@@ -26,6 +26,7 @@ no_long_string();
no_shuffle();
no_root_location(); # avoid generated duplicate 'location /'
worker_connections(128);
+master_on();
my $apisix_home = $ENV{APISIX_HOME} || cwd();
my $nginx_binary = $ENV{'TEST_NGINX_BINARY'} || 'nginx';
diff --git a/t/admin/plugins-reload.t b/t/admin/plugins-reload.t
index d0dc15a..e46b25a 100644
--- a/t/admin/plugins-reload.t
+++ b/t/admin/plugins-reload.t
@@ -22,7 +22,6 @@ no_root_location();
no_shuffle();
log_level("info");
workers(2);
-master_on();
add_block_preprocessor(sub {
my ($block) = @_;
diff --git a/t/config-center-yaml/plugin-configs.t
b/t/config-center-yaml/plugin-configs.t
index 309388d..e7a22b7 100644
--- a/t/config-center-yaml/plugin-configs.t
+++ b/t/config-center-yaml/plugin-configs.t
@@ -20,7 +20,6 @@ repeat_each(1);
log_level('info');
no_root_location();
no_shuffle();
-master_on();
add_block_preprocessor(sub {
my ($block) = @_;
diff --git a/t/config-center-yaml/plugin.t b/t/config-center-yaml/plugin.t
index bcd4575..1a5d95d 100644
--- a/t/config-center-yaml/plugin.t
+++ b/t/config-center-yaml/plugin.t
@@ -77,6 +77,8 @@ qr/load\(\): new plugins/
--- grep_error_log_out
load(): new plugins
load(): new plugins
+load(): new plugins
+load(): new plugins
diff --git a/t/core/config_etcd.t b/t/core/config_etcd.t
index ec03aff..fbffc9f 100644
--- a/t/core/config_etcd.t
+++ b/t/core/config_etcd.t
@@ -258,3 +258,4 @@ qr/etcd auth failed/
etcd auth failed
etcd auth failed
etcd auth failed
+etcd auth failed
diff --git a/t/core/random.t b/t/core/random.t
index 8d7d403..afadec0 100644
--- a/t/core/random.t
+++ b/t/core/random.t
@@ -17,7 +17,6 @@
use t::APISIX 'no_plan';
-master_on();
workers(4);
repeat_each(1);
no_long_string();
diff --git a/t/debug/debug-mode.t b/t/debug/debug-mode.t
index d6a729d..87f3e19 100644
--- a/t/debug/debug-mode.t
+++ b/t/debug/debug-mode.t
@@ -43,9 +43,7 @@ __DATA__
GET /t
--- response_body
done
grep_error_log eval
-qr/loaded plugin and sort by priority: [-\d]+ name: [\w-]+/
[GitHub] [apisix] membphis merged pull request #3926: ci: the last day of travis
membphis merged pull request #3926: URL: https://github.com/apache/apisix/pull/3926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: ci: the last day of travis (#3926)
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 664c760 ci: the last day of travis (#3926)
664c760 is described below
commit 664c76016786c7070bee9e4bf2ffcd6916279444
Author: 罗泽轩
AuthorDate: Mon Mar 29 23:34:01 2021 +0800
ci: the last day of travis (#3926)
---
.github/workflows/build.yml | 8
.gitignore | 3 +--
Makefile| 8
{.travis => ci}/ASF-Release.cfg | 2 +-
{.travis => ci}/ASFLicenseHeaderMarkdown.txt| 0
{.travis => ci}/common.sh | 0
{.travis => ci}/linux_apisix_current_luarocks_runner.sh | 2 +-
{.travis => ci}/linux_apisix_master_luarocks_runner.sh | 2 +-
{.travis => ci}/linux_openresty_1_15_runner.sh | 2 +-
{.travis => ci}/linux_openresty_1_17_runner.sh | 2 +-
{.travis => ci}/linux_openresty_common_runner.sh| 6 +++---
{.travis => ci}/linux_openresty_mtls_runner.sh | 6 +++---
{.travis => ci}/linux_openresty_runner.sh | 2 +-
{.travis => ci}/linux_tengine_runner.sh | 6 +++---
docs/en/latest/install-dependencies.md | 2 +-
docs/zh/latest/install-dependencies.md | 2 +-
t/node/healthcheck-ipv6.t | 10 +-
t/node/remote-addr-ipv6.t | 10 +-
t/node/upstream-ipv6.t | 10 +-
utils/centos7-ci.sh | 2 +-
20 files changed, 30 insertions(+), 55 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index ce34539..9110be8 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -70,14 +70,14 @@ jobs:
- name: Remove source code
if: ${{ startsWith(github.ref, 'refs/heads/release/') &&
!endsWith(matrix.os_name, 'luarocks') }}
run: |
- rm -rf $(ls -1 --ignore=*.tgz --ignore=.travis --ignore=t
--ignore=utils --ignore=.github)
+ rm -rf $(ls -1 --ignore=*.tgz --ignore=ci --ignore=t --ignore=utils
--ignore=.github)
tar zxvf ${{ steps.branch_env.outputs.fullname }}
- name: Linux Get dependencies
run: sudo apt install -y cpanminus build-essential libncurses5-dev
libreadline-dev libssl-dev perl
- name: Linux Before install
-run: sudo ./.travis/${{ matrix.os_name }}_runner.sh before_install
+run: sudo ./ci/${{ matrix.os_name }}_runner.sh before_install
- name: Start Dubbo Backend
if: matrix.os_name == 'linux_openresty'
@@ -140,10 +140,10 @@ jobs:
- name: Linux Install
run: |
sudo --preserve-env=OPENRESTY_VERSION \
-./.travis/${{ matrix.os_name }}_runner.sh do_install
+./ci/${{ matrix.os_name }}_runner.sh do_install
- name: Linux Script
-run: sudo ./.travis/${{ matrix.os_name }}_runner.sh script
+run: sudo ./ci/${{ matrix.os_name }}_runner.sh script
- name: Publish Artifact
if: ${{ startsWith(github.ref, 'refs/heads/release/') &&
matrix.os_name == 'linux_openresty' }}
diff --git a/.gitignore b/.gitignore
index 691ed4e..98b0b7e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -61,8 +61,7 @@ t/lib/dubbo-backend/dubbo-backend-provider/target/
*.iml
\.*
!.github/
-!.travis/
-.travis/openwhisk-utilities/
+ci/openwhisk-utilities/
!.gitmodules
!.markdownlint.yml
!.yamllint
diff --git a/Makefile b/Makefile
index 83fd0a7..f4d1e97 100644
--- a/Makefile
+++ b/Makefile
@@ -240,11 +240,11 @@ test:
### license-check:Check Lua source code for Apache License
.PHONY: license-check
license-check:
-ifeq ("$(wildcard .travis/openwhisk-utilities/scancode/scanCode.py)", "")
- git clone https://github.com/apache/openwhisk-utilities.git
.travis/openwhisk-utilities
- cp .travis/ASF* .travis/openwhisk-utilities/scancode/
+ifeq ("$(wildcard ci/openwhisk-utilities/scancode/scanCode.py)", "")
+ git clone https://github.com/apache/openwhisk-utilities.git
ci/openwhisk-utilities
+ cp ci/ASF* ci/openwhisk-utilities/scancode/
endif
- .travis/openwhisk-utilities/scancode/scanCode.py --config
.travis/ASF-Release.cfg ./
+ ci/openwhisk-utilities/scancode/scanCode.py --config ci/ASF-Release.cfg
./
release-src: compress-tar
diff --git a/.travis/ASF-Release.cfg b/ci/ASF-Release.cfg
similarity index 99%
rename from .travis/ASF-Release.cfg
rename to ci/ASF-Release.cfg
index b4ba843..10de19f 100644
--- a/.travis/ASF-Release.cfg
+++ b/ci/ASF-Release.cfg
@@ -90,7 +90,7 @@ t/lib/dubbo-backend/dubbo-backend-provider/target
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1685: docs: tells users where they are
juzhiyuan commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809464238 I would prefer only to update the Title, keep the path as `/create/edit/`, it's more clear for users to know what happened to this URL. As for the title, `Create Route` -> `/create`, `Configure Route` or `Edit Route` or `Update Route` -> `/edit` are ok for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou opened a new issue #3939: docs: update limit-count.md document
Firstsawyou opened a new issue #3939: URL: https://github.com/apache/apisix/issues/3939 # Improve Docs ## Please describe which part of docs should be improved or typo fixed In fact, the `redis-cluster` strategy in the limit-count plug-in already supports the configuration of passwords (redis_password), but there is no related description in the plug-in documentation, only instructions related to the `redis` strategy. We need to add corresponding instructions to the `redis-cluster` strategy. https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/limit-count.md#attributes https://github.com/apache/apisix/blob/master/apisix/plugins/limit-count.lua#L57-L107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
juzhiyuan merged pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo (#1675)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new e25afe3 feat: rewrite e2e test(test-e2e-route-with-method) using
ginkgo (#1675)
e25afe3 is described below
commit e25afe3f9c5eaac4cd42b9afdfee5050bf945d55
Author: Bisakh Mondal
AuthorDate: Mon Mar 29 20:41:20 2021 +0530
feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo (#1675)
---
api/test/e2e/route_with_methods_test.go | 303 ---
api/test/e2enew/route/route_with_methods_test.go | 351 +++
2 files changed, 351 insertions(+), 303 deletions(-)
diff --git a/api/test/e2e/route_with_methods_test.go
b/api/test/e2e/route_with_methods_test.go
deleted file mode 100644
index ea1006f..000
--- a/api/test/e2e/route_with_methods_test.go
+++ /dev/null
@@ -1,303 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package e2e
-
-import (
- "net/http"
- "testing"
-)
-
-func TestRoute_with_methods(t *testing.T) {
- tests := []HttpTestCase{
- {
- Desc: "add route with invalid method",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path: "/apisix/admin/routes/r1",
- Body: `{
-"name": "route1",
-"uri": "/hello",
-"methods": ["TEST"],
-"upstream": {
-"type": "roundrobin",
-"nodes": [{
-"host":
"172.16.238.20",
-"port": 1980,
-"weight": 1
-}]
-}
-}`,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusBadRequest,
- },
- {
- Desc: "verify route",
- Object: APISIXExpect(t),
- Method: http.MethodGet,
- Path: "/hello",
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusNotFound,
- Sleep:sleepTime,
- },
- {
- Desc: "add route with valid method",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path: "/apisix/admin/routes/r1",
- Body: `{
-"name": "route1",
-"uri": "/hello",
-"methods": ["GET"],
-"upstream": {
-"type": "roundrobin",
-"nodes": [{
-"host":
"172.16.238.20",
-"port": 1980,
-"weight": 1
-}]
-}
-}`,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- },
- {
- Desc: "verify route",
- Object: APISIXExpect(t),
- Method: http.MethodGet,
- Path: "/hello",
- Headers:
[apisix-website] branch master updated: feat: support apisix-docker (#275)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 1bcaba3 feat: support apisix-docker (#275)
1bcaba3 is described below
commit 1bcaba3da9096b0736ed6ea0a43772bf404e9296
Author: Cliff Su
AuthorDate: Mon Mar 29 23:06:48 2021 +0800
feat: support apisix-docker (#275)
---
sync-docs.js | 3 +--
website/docs/apisix-docker/IGNORE_DOC.md | 1 +
website/docs/apisix-docker/sidebars.json | 3 +++
website/docusaurus.config.js | 15 +++
4 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/sync-docs.js b/sync-docs.js
index df5cba6..4e937c0 100644
--- a/sync-docs.js
+++ b/sync-docs.js
@@ -3,9 +3,8 @@ console.log("Start sync-docs.js");
const childProcess = require("child_process");
const fs = require("fs");
const path = require("path");
-// "apisix-docker",
-const projects = ["apisix-ingress-controller", "apisix", "apisix-dashboard",
"apisix-helm-chart"];
+const projects = ["apisix-ingress-controller", "apisix", "apisix-dashboard",
"apisix-helm-chart", "apisix-docker"];
const langs = ["en", "zh", "es"];
const projectPaths = projects.map((project) => {
diff --git a/website/docs/apisix-docker/IGNORE_DOC.md
b/website/docs/apisix-docker/IGNORE_DOC.md
new file mode 100644
index 000..cb65e30
--- /dev/null
+++ b/website/docs/apisix-docker/IGNORE_DOC.md
@@ -0,0 +1 @@
+# IGNORE_DOC
diff --git a/website/docs/apisix-docker/sidebars.json
b/website/docs/apisix-docker/sidebars.json
new file mode 100644
index 000..b0cd5aa
--- /dev/null
+++ b/website/docs/apisix-docker/sidebars.json
@@ -0,0 +1,3 @@
+{
+ "docs": {}
+}
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
index 6f35645..c728092 100644
--- a/website/docusaurus.config.js
+++ b/website/docusaurus.config.js
@@ -60,6 +60,17 @@ module.exports = {
releaseDate: "2021-03-12",
firstDocPath: "/apisix",
},
+ {
+name: "APISIX™ Docker",
+nameInParamCase: "docker",
+description: "Docker tooling for Apache APISIX.",
+shape: "square",
+color: "#2563EB",
+githubRepo: "apache/apisix-helm-chart",
+version: "1.0.0",
+releaseDate: "2020-12-1",
+firstDocPath: "/docker",
+ },
],
team: require("./static/data/team.json"),
allRepos: [
@@ -211,6 +222,10 @@ module.exports = {
to: "/docs/helm-chart/apisix/",
},
{
+ label: "Apache™️ APISIX Docker",
+ to: "/docs/docker/build/",
+},
+{
label: "General",
to: "/docs/general/security",
},
[GitHub] [apisix-website] juzhiyuan merged pull request #275: Feat #216 add project 2
juzhiyuan merged pull request #275: URL: https://github.com/apache/apisix-website/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #3926: ci: the last day of travis
juzhiyuan commented on a change in pull request #3926:
URL: https://github.com/apache/apisix/pull/3926#discussion_r603370855
##
File path: Makefile
##
@@ -240,11 +240,11 @@ test:
### license-check:Check Lua source code for Apache License
.PHONY: license-check
license-check:
-ifeq ("$(wildcard .travis/openwhisk-utilities/scancode/scanCode.py)", "")
- git clone https://github.com/apache/openwhisk-utilities.git
.travis/openwhisk-utilities
- cp .travis/ASF* .travis/openwhisk-utilities/scancode/
+ifeq ("$(wildcard ci/openwhisk-utilities/scancode/scanCode.py)", "")
+ git clone https://github.com/apache/openwhisk-utilities.git
ci/openwhisk-utilities
+ cp ci/ASF* ci/openwhisk-utilities/scancode/
Review comment:
I see SkyWalking has one Action called
https://github.com/apache/skywalking-eyes , we may have a try haha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] supermario1990 opened a new pull request #3938: docs: add chinese version of dubbo-proxy.md
supermario1990 opened a new pull request #3938: URL: https://github.com/apache/apisix/pull/3938 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou opened a new issue #3937: [discuss]: when a node in the etcd cluster fails, no error log is output
Firstsawyou opened a new issue #3937: URL: https://github.com/apache/apisix/issues/3937 ### Issue description In an etcd cluster (3 nodes), when one of the nodes fails. The following error message will be printed in the error.log:  But this does not affect the normal operation of APISIX. Such error log information can make people misunderstand that etcd is unavailable. Can we not output error log information when a node fails in etcd cluster? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #319: fix: ApisixRoute update operations is not effective
gxthrj commented on a change in pull request #319:
URL:
https://github.com/apache/apisix-ingress-controller/pull/319#discussion_r603331684
##
File path: test/e2e/ingress/resourcepushing.go
##
@@ -99,14 +98,56 @@ spec:
err = s.EnsureNumApisixUpstreamsCreated(1)
assert.Nil(ginkgo.GinkgoT(), err, "Checking number of
upstreams")
+ s.NewAPISIXClient().GET("/ip").WithHeader("Host",
"httpbin.com").Expect().Status(http.StatusOK)
+
+ // update
+ apisixRoute = fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
Review comment:
I mean add test cases:
1. In the same `ApisixRoute` yaml ,but change `spec.http.name` when update
2. In the different `ApisixRoute` yaml, but have the same `spec.http.name`,
which means name is conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] defp commented on issue #1397: feat: Customize the configurations of Semantic-Pull-Request check in CI
defp commented on issue #1397: URL: https://github.com/apache/apisix-dashboard/issues/1397#issuecomment-809411576 > By default types specified in commitizen/conventional-commit-types is used. > See: https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json No `backport` type in index.json -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] defp opened a new pull request #1688: feat: added policy for semantic-pr
defp opened a new pull request #1688: URL: https://github.com/apache/apisix-dashboard/pull/1688 Please answer these questions before submitting a pull request, **or your PR will get closed**. - [x] New feature provided **What changes will this PR take into?** Please update this section with detailed description. **Related issues** https://github.com/apache/apisix-dashboard/issues/1397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support
benx203 commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r603319995
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,324 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local local_conf = require("apisix.core.config_local").local_conf()
+local http = require("resty.http")
+local core = require("apisix.core")
+local ipairs = ipairs
+local tostring = tostring
+local type = type
+local math = math
+local math_random= math.random
+local error = error
+local ngx= ngx
+local ngx_re = require("ngx.re")
+local ngx_timer_at = ngx.timer.at
+local ngx_timer_every= ngx.timer.every
+local string = string
+local table = table
+local string_sub = string.sub
+local str_byte = string.byte
+local str_find = core.string.find
+local str_format = string.format
+local log= core.log
+
+local default_weight
+local applications
+local auth_path
+local service_list_path
+local page_size
+local instance_list_path
+
+local schema = {
+type = "object",
+properties = {
+host = {
+type = "array",
+minItems = 1,
+items = {
+type = "string",
+},
+},
+fetch_interval = {type = "integer", minimum = 1, default = 30},
+prefix = {type = "string", default = "/nacos/v1/"},
+page_size = {type = "integer", minimum = 1, default = 100},
+weight = {type = "integer", minimum = 1, default = 100},
+timeout = {
+type = "object",
+properties = {
+connect = {type = "integer", minimum = 1, default = 2000},
+send = {type = "integer", minimum = 1, default = 2000},
+read = {type = "integer", minimum = 1, default = 5000},
+},
+default = {
+connect = 2000,
+send = 2000,
+read = 5000,
+}
+},
+},
+required = {"host"}
+}
+
+
+local _M = {
+version = 0.1,
+}
+
+
+local function service_info()
+local host = local_conf.discovery and
+local_conf.discovery.nacos and local_conf.discovery.nacos.host
+if not host then
+log.error("do not set nacos.host")
+return
+end
+
+local username, password
+-- TODO Add health check to get healthy nodes.
+local url = host[math_random(#host)]
+local auth_idx = str_find(url, "#")
Review comment:
If use @,when run test file,will throw error:
Possible unintended interpolation of @127 in string at t/discovery/nacos.t
line 70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #318: request help:
gxthrj commented on issue #318: URL: https://github.com/apache/apisix-ingress-controller/issues/318#issuecomment-809382637 Please show the APISIX version， you had better use APISIX 2.4 version . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] pioneer-hash commented on issue #318: request help:
pioneer-hash commented on issue #318: URL: https://github.com/apache/apisix-ingress-controller/issues/318#issuecomment-809345678 > Please add the apisix version and apisix-ingress-controller version. > > Also, please add title. apisix version is apache/apisix:latest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] pioneer-hash commented on issue #318: request help:
pioneer-hash commented on issue #318: URL: https://github.com/apache/apisix-ingress-controller/issues/318#issuecomment-809340430 > Please add the apisix version and apisix-ingress-controller version. > > Also, please add title. The packaged image of the current master version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on issue #49: apisix error:failed to fetch data from etcd: xxxx could not be resolved
tokers commented on issue #49: URL: https://github.com/apache/apisix-helm-chart/issues/49#issuecomment-809324765 It seems APISIX doens't use the resolver in `/etc/resolv.conf`. Could you please paste the nginx.conf in your APISIX container? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou opened a new pull request #3936: docs(FAQ.md): add a configuration example in How to modify the log level
Firstsawyou opened a new pull request #3936: URL: https://github.com/apache/apisix/pull/3936 Signed-off-by: Firstsawyou yuelin...@gmail.com ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809271644 > Thanks for your contribution. > However, we already have an ongoing PR: #3820 > > I take a first look at yours. Your implementation has namespaceId and groupName, and an individual way to refresh the token. > > Maybe you can optimize that PR after it's merged? OK~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3927: test: enable master-worker mode by default
spacewander commented on pull request #3927: URL: https://github.com/apache/apisix/pull/3927#issuecomment-809268244 To make sure bug in https://github.com/apache/apisix/pull/3912 won't happen again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: feat(traffic-split): the upstream pass_host needs to support IP mode (#3870)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new da83328 feat(traffic-split): the upstream pass_host needs to support
IP mode (#3870)
da83328 is described below
commit da83328af9d22a07406f0395fbd4a3dbf7ef6add
Author: Yuelin Zheng <2226815...@qq.com>
AuthorDate: Mon Mar 29 18:27:22 2021 +0800
feat(traffic-split): the upstream pass_host needs to support IP mode (#3870)
---
apisix/plugins/traffic-split.lua | 25 ++---
t/plugin/traffic-split2.t| 209 +++
2 files changed, 217 insertions(+), 17 deletions(-)
diff --git a/apisix/plugins/traffic-split.lua b/apisix/plugins/traffic-split.lua
index 1767c4a..da44d3e 100644
--- a/apisix/plugins/traffic-split.lua
+++ b/apisix/plugins/traffic-split.lua
@@ -148,27 +148,18 @@ end
local function set_pass_host(ctx, upstream_info, host)
--- Currently only supports a single upstream of the domain name.
--- When the upstream is `IP`, do not do any `pass_host` operation.
-if not core.utils.parse_ipv4(host)
- and not core.utils.parse_ipv6(host)
-then
-local pass_host = upstream_info.pass_host or "pass"
-if pass_host == "pass" then
-ctx.var.upstream_host = ctx.var.host
-return
-end
-
-if pass_host == "rewrite" then
-ctx.var.upstream_host = upstream_info.upstream_host
-return
-end
+local pass_host = upstream_info.pass_host or "pass"
+if pass_host == "pass" then
+return
+end
-ctx.var.upstream_host = host
+if pass_host == "rewrite" then
+ctx.var.upstream_host = upstream_info.upstream_host
return
end
-return
+-- only support single node for `node` mode currently
+ctx.var.upstream_host = host
end
diff --git a/t/plugin/traffic-split2.t b/t/plugin/traffic-split2.t
index 655885a..071853a 100644
--- a/t/plugin/traffic-split2.t
+++ b/t/plugin/traffic-split2.t
@@ -103,3 +103,212 @@ GET /server_port?name=jack=17
GET /server_port?name=jack=18
--- response_body chomp
1980
+
+
+
+=== TEST 4: the upstream node is IP and pass_host is `pass`
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+[=[{
+"uri": "/uri",
+"plugins": {
+"traffic-split": {
+"rules": [
+{
+"match": [
+{
+"vars": [["arg_name", "==",
"jack"]]
+}
+],
+"weighted_upstreams": [
+{
+"upstream": {
+"type": "roundrobin",
+"pass_host": "pass",
+"nodes": {
+"127.0.0.1:1981":1
+}
+}
+}
+]
+}
+]
+}
+},
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+"127.0.0.1:1980": 1
+}
+}
+}]=]
+)
+if code >= 300 then
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 5: upstream_host is `127.0.0.1`
+--- request
+GET /uri?name=jack
+--- more_headers
+host: 127.0.0.1
+--- response_body
+uri: /uri
+host: 127.0.0.1
+x-real-ip: 127.0.0.1
+--- no_error_log
+[error]
+
+
+
+=== TEST 6: the upstream node is IP and pass_host is `rewrite`
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ngx.HTTP_PATCH,
+[=[{
+"uri": "/uri",
+"plugins": {
+"traffic-split": {
+"rules": [
+{
+"match": [
+
[GitHub] [apisix] spacewander merged pull request #3870: feat(traffic-split): the upstream pass_host needs to support IP mode
spacewander merged pull request #3870: URL: https://github.com/apache/apisix/pull/3870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #3927: test: enable master-worker mode by default
tokers commented on pull request #3927: URL: https://github.com/apache/apisix/pull/3927#issuecomment-809265994 @spacewander Where can I find the context about why we should do this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #318: request help:
tokers commented on issue #318: URL: https://github.com/apache/apisix-ingress-controller/issues/318#issuecomment-809263515 Please add the apisix version and apisix-ingress-controller version. Also, please add title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3820: feat: add nacos support
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r603173738
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,324 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local local_conf = require("apisix.core.config_local").local_conf()
+local http = require("resty.http")
+local core = require("apisix.core")
+local ipairs = ipairs
+local tostring = tostring
+local type = type
+local math = math
+local math_random= math.random
+local error = error
+local ngx= ngx
+local ngx_re = require("ngx.re")
+local ngx_timer_at = ngx.timer.at
+local ngx_timer_every= ngx.timer.every
+local string = string
+local table = table
+local string_sub = string.sub
+local str_byte = string.byte
+local str_find = core.string.find
+local str_format = string.format
+local log= core.log
+
+local default_weight
+local applications
+local auth_path
+local service_list_path
+local page_size
+local instance_list_path
+
+local schema = {
+type = "object",
+properties = {
+host = {
+type = "array",
+minItems = 1,
+items = {
+type = "string",
+},
+},
+fetch_interval = {type = "integer", minimum = 1, default = 30},
+prefix = {type = "string", default = "/nacos/v1/"},
+page_size = {type = "integer", minimum = 1, default = 100},
+weight = {type = "integer", minimum = 1, default = 100},
+timeout = {
+type = "object",
+properties = {
+connect = {type = "integer", minimum = 1, default = 2000},
+send = {type = "integer", minimum = 1, default = 2000},
+read = {type = "integer", minimum = 1, default = 5000},
+},
+default = {
+connect = 2000,
+send = 2000,
+read = 5000,
+}
+},
+},
+required = {"host"}
+}
+
+
+local _M = {
+version = 0.1,
+}
+
+
+local function service_info()
+local host = local_conf.discovery and
+local_conf.discovery.nacos and local_conf.discovery.nacos.host
+if not host then
+log.error("do not set nacos.host")
+return
+end
+
+local username, password
+-- TODO Add health check to get healthy nodes.
+local url = host[math_random(#host)]
+local auth_idx = str_find(url, "#")
+if auth_idx then
+local protocol_idx = str_find(url, "://")
+local protocol = string_sub(url, 1, protocol_idx + 2)
+local user_and_password = string_sub(url, protocol_idx + 3, auth_idx -
1)
+local arr = ngx_re.split(user_and_password, ":")
+if #arr == 2 then
+username = arr[1]
+password = arr[2]
+end
+local other = string_sub(url, auth_idx + 1)
+url = protocol .. other
+end
+if local_conf.discovery.nacos.prefix then
+url = url .. local_conf.discovery.nacos.prefix
+end
+if str_byte(url, #url) ~= str_byte("/") then
+url = url .. "/"
+end
+
+return url, username, password
+end
+
+
+local function request(request_uri, path, body, method, basic_auth)
+local url = request_uri .. path
+log.info("request url:", url)
+local headers = core.table.new(0, 0)
+headers['Connection'] = 'Keep-Alive'
+headers['Accept'] = 'application/json'
+
+if basic_auth then
+headers['Authorization'] = basic_auth
+end
+
+if body and 'table' == type(body) then
+local err
+body, err = core.json.encode(body)
+if not body then
+return nil, 'invalid body : ' .. err
+end
+-- log.warn(method, url, body)
+headers['Content-Type'] = 'application/json'
+end
+
+local httpc = http.new()
+local timeout = local_conf.discovery.nacos.timeout
+local connect_timeout = timeout.connect
+local send_timeout = timeout.send
+local read_timeout =
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #320: test: add e2e test cases for redirect and fault-injection plugins
codecov-io commented on pull request #320: URL: https://github.com/apache/apisix-ingress-controller/pull/320#issuecomment-809257457 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320?src=pr=h1) Report > Merging [#320](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320?src=pr=desc) (11f81d1) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/827799506aef644e42e25a5ef60476e722f1edf1?el=desc) (8277995) will **increase** coverage by `60.74%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #320 +/- ## + Coverage 39.25% 100.00% +60.74% Files 42 1 -41 Lines3577 1 -3576 - Hits 1404 1 -1403 + Misses 2012 0 -2012 + Partials 161 0 -161 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320?src=pr=tree) | Coverage Δ | | |---|---|---| | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320/diff?src=pr=tree#diff-dGVzdC9lMmUvZTJlLmdv) | `100.00% <ø> (ø)` | | | [pkg/types/errors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320/diff?src=pr=tree#diff-cGtnL3R5cGVzL2Vycm9ycy5nbw==) | | | | [pkg/ingress/apisix/tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Rscy5nbw==) | | | | [pkg/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320/diff?src=pr=tree#diff-cGtnL2FwaXNpeC91cHN0cmVhbS5nbw==) | | | | [pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=) | | | | [pkg/log/default\_logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320/diff?src=pr=tree#diff-cGtnL2xvZy9kZWZhdWx0X2xvZ2dlci5nbw==) | | | | [pkg/ingress/controller/endpoint.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci9lbmRwb2ludC5nbw==) | | | | [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | | | | [pkg/types/timeduration.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320/diff?src=pr=tree#diff-cGtnL3R5cGVzL3RpbWVkdXJhdGlvbi5nbw==) | | | | [pkg/ingress/controller/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320/diff?src=pr=tree#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci9pbmdyZXNzLmdv) | | | | ... and [32 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320?src=pr=footer). Last update [8277995...11f81d1](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3934: feat: Discovery Nacos
spacewander commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809255632 Thanks for your contribution. However, we already have an ongoing PR: https://github.com/apache/apisix/pull/3820 I take a first look at yours. Your implementation has namespaceId and groupName, and an individual way to refresh the token. Maybe you can optimize that PR after it's merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] stu01509 commented on a change in pull request #275: Feat #216 add project 2
stu01509 commented on a change in pull request #275:
URL: https://github.com/apache/apisix-website/pull/275#discussion_r603169141
##
File path: website/docusaurus.config.js
##
@@ -60,6 +60,17 @@ module.exports = {
releaseDate: "2021-03-12",
firstDocPath: "/apisix",
},
+ {
+name: "APISIX™ Docker",
+nameInParamCase: "docker",
+description: "The docker for Apache APISIX.",
Review comment:
Sure :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3820: feat: add nacos support
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r603167933
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,324 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local local_conf = require("apisix.core.config_local").local_conf()
+local http = require("resty.http")
+local core = require("apisix.core")
+local ipairs = ipairs
+local tostring = tostring
+local type = type
+local math = math
+local math_random= math.random
+local error = error
+local ngx= ngx
+local ngx_re = require("ngx.re")
+local ngx_timer_at = ngx.timer.at
+local ngx_timer_every= ngx.timer.every
+local string = string
+local table = table
+local string_sub = string.sub
+local str_byte = string.byte
+local str_find = core.string.find
+local str_format = string.format
+local log= core.log
+
+local default_weight
+local applications
+local auth_path
+local service_list_path
+local page_size
+local instance_list_path
+
+local schema = {
+type = "object",
+properties = {
+host = {
+type = "array",
+minItems = 1,
+items = {
+type = "string",
+},
+},
+fetch_interval = {type = "integer", minimum = 1, default = 30},
+prefix = {type = "string", default = "/nacos/v1/"},
+page_size = {type = "integer", minimum = 1, default = 100},
+weight = {type = "integer", minimum = 1, default = 100},
+timeout = {
+type = "object",
+properties = {
+connect = {type = "integer", minimum = 1, default = 2000},
+send = {type = "integer", minimum = 1, default = 2000},
+read = {type = "integer", minimum = 1, default = 5000},
+},
+default = {
+connect = 2000,
+send = 2000,
+read = 5000,
+}
+},
+},
+required = {"host"}
+}
+
+
+local _M = {
+version = 0.1,
+}
+
+
+local function service_info()
+local host = local_conf.discovery and
+local_conf.discovery.nacos and local_conf.discovery.nacos.host
+if not host then
+log.error("do not set nacos.host")
+return
+end
+
+local username, password
+-- TODO Add health check to get healthy nodes.
+local url = host[math_random(#host)]
+local auth_idx = str_find(url, "#")
Review comment:
Is there any need to change `@` to `#`? Maybe I miss something?
It is the standard to use `@` to separate the authority part from the rest:
https://en.wikipedia.org/wiki/URL#Syntax
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,324 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local local_conf = require("apisix.core.config_local").local_conf()
+local http = require("resty.http")
+local core = require("apisix.core")
+local ipairs = ipairs
+local tostring = tostring
+local type = type
+local math = math
+local math_random= math.random
+local error = error
+local ngx= ngx
+local ngx_re =
[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support
benx203 commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r603156071
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,285 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local local_conf = require("apisix.core.config_local").local_conf()
+local http = require("resty.http")
+local core = require("apisix.core")
+local ipairs = ipairs
+local tostring = tostring
+local type = type
+local math_random= math.random
+local error = error
+local ngx= ngx
+local ngx_timer_at = ngx.timer.at
+local ngx_timer_every= ngx.timer.every
+local string = string
+local table = table
+local string_sub = string.sub
+local str_byte = string.byte
+local str_find = core.string.find
+local log= core.log
+
+local default_weight
+local applications
+local auth_path
+local service_list_path
+local instance_list_path
+
+local schema = {
+type = "object",
+properties = {
+host = {
+type = "array",
+minItems = 1,
+items = {
+type = "string",
+},
+},
+fetch_interval = {type = "integer", minimum = 1, default = 30},
+prefix = {type = "string", default = "/nacos/v1/"},
+auth_path = {type = "string", default = "auth/login"},
+service_list_path = {type = "string", default =
"ns/service/list?pageNo=1=20"},
Review comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3935: request help: Specify an upstream and remove it from all routes
tokers commented on issue #3935: URL: https://github.com/apache/apisix/issues/3935#issuecomment-809234414 @hackeryutu You don't show your problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hackeryutu opened a new issue #3935: request help: Specify an upstream and remove it from all routes
hackeryutu opened a new issue #3935: URL: https://github.com/apache/apisix/issues/3935 ### Issue description request help: Specify an upstream and remove it from all routes ### Environment * apisix version (cmd: `apisix version`): * OS (cmd: `uname -a`): * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): * apisix-dashboard version, if have: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #321: Add e2e test cases for plugins
gxthrj commented on issue #321: URL: https://github.com/apache/apisix-ingress-controller/issues/321#issuecomment-809228790 Great Job ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #321: Add e2e test cases for plugins
gxthrj commented on issue #321: URL: https://github.com/apache/apisix-ingress-controller/issues/321#issuecomment-809228552 Great Job ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] imxhf opened a new pull request #3934: feat: Discovery Nacos
imxhf opened a new pull request #3934: URL: https://github.com/apache/apisix/pull/3934 Nacos is wildly used as service discovery registery. Here add the nacos in APISIX discovery. The codes considers followings: When use Nacos in produce env, nacos_username and nacos_password are needed to get the access_token, which is used in Nacos admin API, and access_token's ttl is 18000s. In Nacos, namespaceId, groupName and serviceName are used together to confirm one specific sercie. And the default namespaceId is public, default groupName is DEFAULT_GROUP. Only fetch instances of those Nacos services that are used in APISIX, but not fetch instances of all services in Nacos. There is cache for instances of Nacos services and the intances fetch interval could be configured. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] imxhf closed pull request #3933: Feature discovery nacos
imxhf closed pull request #3933: URL: https://github.com/apache/apisix/pull/3933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new issue #321: Add e2e test cases for plugins
tokers opened a new issue #321: URL: https://github.com/apache/apisix-ingress-controller/issues/321 ### Issue description We don't cover plugins in e2e test suites, although we support them already. Here I want to initiate a plan to add test cases for most of all plugins in Apache APISIX. - [ ] [batch-requests](http://apisix.apache.org/docs/apisix/plugins/batch-requests) - [ ] [serverless](http://apisix.apache.org/docs/apisix/plugins/serverless) - [x] [redirect](http://apisix.apache.org/docs/apisix/plugins/redirect) - [ ] [echo](http://apisix.apache.org/docs/apisix/plugins/echo) - [ ] [server-info](http://apisix.apache.org/docs/apisix/plugins/server-info) - [ ] [response-rewrite](http://apisix.apache.org/docs/apisix/plugins/response-rewrite) - [ ] [proxy-rewrite](http://apisix.apache.org/docs/apisix/plugins/proxy-rewrite) - [ ] [grpc-transcode](http://apisix.apache.org/docs/apisix/plugins/grpc-transcode) - [ ] [fault-injection](http://apisix.apache.org/docs/apisix/plugins/fault-injection) - [ ] [key-auth](http://apisix.apache.org/docs/apisix/plugins/key-auth) - [ ] [jwt-auth](http://apisix.apache.org/docs/apisix/plugins/jwt-auth) - [ ] [basic-auth](http://apisix.apache.org/docs/apisix/plugins/basic-auth) - [ ] [authz-keycloak](http://apisix.apache.org/docs/apisix/plugins/authz-keycloak) - [ ] [wolf-rbac](http://apisix.apache.org/docs/apisix/plugins/wolf-rbac) - [ ] [openid-connect](http://apisix.apache.org/docs/apisix/plugins/openid-connect/) - [ ] [hmac-auth](http://apisix.apache.org/docs/apisix/plugins/hmac-auth) - [ ] [cors](http://apisix.apache.org/docs/apisix/plugins/cors) - [ ] [uri-blocker](http://apisix.apache.org/docs/apisix/plugins/uri-blocker) - [ ] [ip-restriction](http://apisix.apache.org/docs/apisix/plugins/ip-restriction) - [ ] [referer-restriction](http://apisix.apache.org/docs/apisix/plugins/referer-restriction) - [ ] [consumer-restriction](http://apisix.apache.org/docs/apisix/plugins/consumer-restriction) - [ ] [limit-req](http://apisix.apache.org/docs/apisix/plugins/limit-req) - [ ] [limit-conn](http://apisix.apache.org/docs/apisix/plugins/limit-conn) - [ ] [limit-count](http://apisix.apache.org/docs/apisix/plugins/limit-count) - [ ] [proxy-cache](http://apisix.apache.org/docs/apisix/plugins/proxy-cache) - [ ] [request-validation](http://apisix.apache.org/docs/apisix/plugins/request-validation) - [ ] [proxy-mirror](http://apisix.apache.org/docs/apisix/plugins/proxy-mirror) - [ ] [api-breaker](http://apisix.apache.org/docs/apisix/plugins/api-breaker) - [x] [traffic-split](http://apisix.apache.org/docs/apisix/plugins/traffic-split), supported by ApisixRoute in first-class. - [ ] [request-id](http://apisix.apache.org/docs/apisix/plugins/request-id) - [ ] [prometheus](http://apisix.apache.org/docs/apisix/plugins/prometheus) - [ ] [zipkin](http://apisix.apache.org/docs/apisix/plugins/zipkin) - [ ] [skywalking](http://apisix.apache.org/docs/apisix/plugins/skywalking) - [ ] [node-status](http://apisix.apache.org/docs/apisix/plugins/node-status) - [ ] [http-logger](http://apisix.apache.org/docs/apisix/plugins/http-logger) - [ ] [tcp-logger](http://apisix.apache.org/docs/apisix/plugins/tcp-logger) - [ ] [kafka-logger](http://apisix.apache.org/docs/apisix/plugins/kafka-logger) - [ ] [udp-logger](http://apisix.apache.org/docs/apisix/plugins/udp-logger) - [ ] [syslog](http://apisix.apache.org/docs/apisix/plugins/syslog) - [ ] [log-rotate](http://apisix.apache.org/docs/apisix/plugins/log-rotate) - [ ] [error-log-logger](http://apisix.apache.org/docs/apisix/plugins/error-log-logger) - [ ] [sls-logger](http://apisix.apache.org/docs/apisix/plugins/sls-logger) - [ ] [dubbo-proxy](http://apisix.apache.org/docs/apisix/plugins/dubbo-proxy) - [ ] [mqtt-proxy](http://apisix.apache.org/docs/apisix/plugins/mqtt-proxy) If you're interested in writing some test cases for several plugins, please writing comments like: ``` I'd like to write e2e test cases for plugin "fault-injection". ``` Then, I'll create a dedicated issue and assign it to you. After the PR is merged, the checkbox in this description will be clicked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #320: test: add e2e test cases for redirect and fault-injection plugins
tokers opened a new pull request #320: URL: https://github.com/apache/apisix-ingress-controller/pull/320 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] imxhf opened a new pull request #3933: Feature discovery nacos
imxhf opened a new pull request #3933: URL: https://github.com/apache/apisix/pull/3933 Nacos is wildly used as service discovery registery. Here add the nacos in APISIX discovery. The codes considers followings: 1. When use Nacos in produce env, nacos_username and nacos_password are needed to get the access_token, which is used in Nacos admin API, and access_token's ttl is 18000s. 2. In Nacos, namespaceId, groupName and serviceName are used together to confirm one specific sercie. And the default namespaceId is public, default groupName is DEFAULT_GROUP. 3. Only fetch instances of those Nacos services that are used in APISIX, but not fetch instances of all services in Nacos. 4. There is cache for instances of Nacos services and the intances fetch interval could be configured. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] wgy-home opened a new issue #49: apisix error:failed to fetch data from etcd: xxxx could not be resolved
wgy-home opened a new issue #49:
URL: https://github.com/apache/apisix-helm-chart/issues/49
# way to install
```shell
git clone https://github.com/apache/apisix-helm-chart.git
cd apisix-helm-chart/charts/apisix
helm dependency update .
helm install apisix . --set gateway.type=NodePort --set
allow.ipList="{0.0.0.0/0}" --namespace ingress-apisix
```
apisix image tag : apache/apisix:2.3-alpine
## apisix error log
```
2021/03/29 08:51:52 [error] 49#49: *282942 [lua] config_etcd.lua:530: failed
to fetch data from etcd: apisix-etcd.ingress-apisix.svc.cluster.local could not
be resolved (3: Host not found), etcd key: /apisix/plugin_metadata, context:
ngx.timer
2021/03/29 08:51:53 [error] 73#73: *285218 [lua] config_etcd.lua:530: failed
to fetch data from etcd: apisix-etcd.ingress-apisix.svc.cluster.local could not
be resolved (3: Host not found), etcd key: /apisix/consumers, context:
ngx.timer
2021/03/29 08:51:53 [error] 51#51: *272261 [lua] config_etcd.lua:530: failed
to fetch data from etcd: apisix-etcd.ingress-apisix.svc.cluster.local could not
be resolved (3: Host not found), etcd key: /apisix/proto, context: ngx.timer
2021/03/29 08:51:53 [error] 43#43: *281732 [lua] config_etcd.lua:530: failed
to fetch data from etcd: apisix-etcd.ingress-apisix.svc.cluster.local could not
be resolved (3: Host not found), etcd key: /apisix/upstreams, context:
ngx.timer
2021/03/29 08:51:53 [error] 45#45: *283202 [lua] config_etcd.lua:530: failed
to fetch data from etcd: apisix-etcd.ingress-apisix.svc.cluster.local could not
be resolved (3: Host not found), etcd key: /apisix/services, context: ngx.timer
2021/03/29 08:51:53 [error] 65#65: *277404 [lua] config_etcd.lua:530: failed
to fetch data from etcd: apisix-etcd.ingress-apisix.svc.cluster.local could not
be resolved (3: Host not found), etcd key: /apisix/proto, context: ngx.timer
2021/03/29 08:51:53 [error] 55#55: *284742 [lua] config_etcd.lua:530: failed
to fetch data from etcd: apisix-etcd.ingress-apisix.svc.cluster.local could not
be resolved (3: Host not found), etcd key: /apisix/plugin_metadata, context:
ngx.timer
2021/03/29 08:51:53 [error] 59#59: *285624 [lua] config_etcd.lua:530: failed
to fetch data from etcd: apisix-etcd.ingress-apisix.svc.cluster.local could not
be resolved (3: Host not found), etcd key: /apisix/upstreams, context:
ngx.timer
2021/03/29 08:51:53 [error] 70#70: *282262 [lua] config_etcd.lua:530: failed
to fetch data from etcd: apisix-etcd.ingress-apisix.svc.cluster.local could not
be resolved (3: Host not found), etcd key: /apisix/global_rules, context:
ngx.timer
2021/03/29 08:51:53 [error] 67#67: *279198 [lua] config_etcd.lua:530: failed
to fetch data from etcd: apisix-etcd.ingress-apisix.svc.cluster.local could not
be resolved (3: Host not found), etcd key: /apisix/routes, context: ngx.timer
```
**But it can be connected through ETCDCTL.**
```
I have no name!@apisix-etcd-0:/opt/bitnami/etcd$ etcdctl
--endpoints=apisix-etcd.ingress-apisix.svc.cluster.local:2379 put /test apisix
OK
I have no name!@apisix-etcd-0:/opt/bitnami/etcd$ etcdctl
--endpoints=apisix-etcd.ingress-apisix.svc.cluster.local:2379 get /test apisix
/test
apisix
```
Help me, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3870: feat(traffic-split): the upstream pass_host needs to support IP mode
Firstsawyou commented on a change in pull request #3870: URL: https://github.com/apache/apisix/pull/3870#discussion_r603113753 ## File path: apisix/plugins/traffic-split.lua ## @@ -148,26 +148,18 @@ end local function set_pass_host(ctx, upstream_info, host) --- Currently only supports a single upstream of the domain name. --- When the upstream is `IP`, do not do any `pass_host` operation. -if not core.utils.parse_ipv4(host) - and not core.utils.parse_ipv6(host) -then -local pass_host = upstream_info.pass_host or "pass" -if pass_host == "pass" then -ctx.var.upstream_host = ctx.var.host -return -end - -if pass_host == "rewrite" then -ctx.var.upstream_host = upstream_info.upstream_host -return -end +local pass_host = upstream_info.pass_host or "pass" +if pass_host == "pass" then +return +end -ctx.var.upstream_host = host +if pass_host == "rewrite" then +ctx.var.upstream_host = upstream_info.upstream_host return end +-- only support single node for `node` mode currently +ctx.var.upstream_host = host return Review comment: updated @spacewander -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #319: fix: ApisixRoute update operations is not effective
tokers commented on a change in pull request #319:
URL:
https://github.com/apache/apisix-ingress-controller/pull/319#discussion_r603112153
##
File path: test/e2e/ingress/resourcepushing.go
##
@@ -99,14 +98,56 @@ spec:
err = s.EnsureNumApisixUpstreamsCreated(1)
assert.Nil(ginkgo.GinkgoT(), err, "Checking number of
upstreams")
+ s.NewAPISIXClient().GET("/ip").WithHeader("Host",
"httpbin.com").Expect().Status(http.StatusOK)
+
+ // update
+ apisixRoute = fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
Review comment:
Cannot totally capture your mean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #319: fix: ApisixRoute update operations is not effective
tokers commented on a change in pull request #319:
URL:
https://github.com/apache/apisix-ingress-controller/pull/319#discussion_r603112153
##
File path: test/e2e/ingress/resourcepushing.go
##
@@ -99,14 +98,56 @@ spec:
err = s.EnsureNumApisixUpstreamsCreated(1)
assert.Nil(ginkgo.GinkgoT(), err, "Checking number of
upstreams")
+ s.NewAPISIXClient().GET("/ip").WithHeader("Host",
"httpbin.com").Expect().Status(http.StatusOK)
+
+ // update
+ apisixRoute = fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
Review comment:
Cannot capture your mean 100%.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers opened a new issue #3932: ret_code type in plugin redirect document is dubious
tokers opened a new issue #3932: URL: https://github.com/apache/apisix/issues/3932 # Improve Docs ## Please describe which part of docs should be improved or typo fixed The type of `ret_type` in attribution descriptions is `string`.  But when test cases are shown, the type is `integer`.  From the plugin schema definition, it's really an integer. ## Describe the solution you'd like Type in attributions should be changed to `integer`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey merged pull request #1676: feat: rewrite e2e test(test-e2e-route-with-plugin-CORS) using ginkgo
imjoey merged pull request #1676: URL: https://github.com/apache/apisix-dashboard/pull/1676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: rewrite e2e test (route with plugins cors test) using ginkgo (#1676)
This is an automated email from the ASF dual-hosted git repository.
majunjie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 4ebf467 feat: rewrite e2e test (route with plugins cors test) using
ginkgo (#1676)
4ebf467 is described below
commit 4ebf467daa0f55cade4d600bc4a7957e92726f93
Author: Bisakh Mondal
AuthorDate: Mon Mar 29 14:03:16 2021 +0530
feat: rewrite e2e test (route with plugins cors test) using ginkgo (#1676)
---
.../route}/route_with_plugin_cors_test.go | 119 ++---
1 file changed, 55 insertions(+), 64 deletions(-)
diff --git a/api/test/e2e/route_with_plugin_cors_test.go
b/api/test/e2enew/route/route_with_plugin_cors_test.go
similarity index 72%
rename from api/test/e2e/route_with_plugin_cors_test.go
rename to api/test/e2enew/route/route_with_plugin_cors_test.go
index 9811cf2..2fc6320 100644
--- a/api/test/e2e/route_with_plugin_cors_test.go
+++ b/api/test/e2enew/route/route_with_plugin_cors_test.go
@@ -14,26 +14,31 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package e2e
+package route
import (
"net/http"
- "testing"
+
+ "github.com/onsi/ginkgo"
+ "github.com/onsi/ginkgo/extensions/table"
+
+ "github.com/apisix/manager-api/test/e2enew/base"
)
-func TestRoute_With_Plugin_Cors(t *testing.T) {
- tests := []HttpTestCase{
- {
- Desc: "make sure the route is not created",
- Object: APISIXExpect(t),
+var _ = ginkgo.Describe("route with plugin cors", func() {
+ table.DescribeTable("test route with plugin cors",
+ func(tc base.HttpTestCase) {
+ base.RunTestCase(tc)
+ },
+ table.Entry("make sure the route is not created",
base.HttpTestCase{
+ Object: base.APISIXExpect(),
Method: http.MethodGet,
Path: "/hello",
ExpectStatus: http.StatusNotFound,
ExpectBody: `{"error_msg":"404 Route Not Found"}`,
- },
- {
- Desc: "create route with cors default setting",
- Object: ManagerApiExpect(t),
+ }),
+ table.Entry("create route with cors default setting",
base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
@@ -51,12 +56,11 @@ func TestRoute_With_Plugin_Cors(t *testing.T) {
}]
}
}`,
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
- },
- {
- Desc: "verify route with cors default setting",
- Object: APISIXExpect(t),
+ }),
+ table.Entry("verify route with cors default setting",
base.HttpTestCase{
+ Object: base.APISIXExpect(),
Method: http.MethodGet,
Path: "/hello",
ExpectStatus: http.StatusOK,
@@ -65,11 +69,10 @@ func TestRoute_With_Plugin_Cors(t *testing.T) {
"Access-Control-Allow-Methods": "*",
},
ExpectBody: "hello world",
- Sleep: sleepTime,
- },
- {
- Desc: "update route with specified setting",
- Object: ManagerApiExpect(t),
+ Sleep: base.SleepTime,
+ }),
+ table.Entry("update route with specified setting",
base.HttpTestCase{
+ Object: base.ManagerApiExpect(),
Method: http.MethodPut,
Path: "/apisix/admin/routes/r1",
Body: `{
@@ -94,12 +97,11 @@ func TestRoute_With_Plugin_Cors(t *testing.T) {
}]
}
}`,
- Headers: map[string]string{"Authorization": token},
+ Headers: map[string]string{"Authorization":
base.GetToken()},
ExpectStatus: http.StatusOK,
- },
- {
- Desc: "verify route with cors specified setting",
-
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #319: fix: ApisixRoute update operations is not effective
gxthrj commented on a change in pull request #319:
URL:
https://github.com/apache/apisix-ingress-controller/pull/319#discussion_r603099761
##
File path: test/e2e/ingress/resourcepushing.go
##
@@ -99,14 +98,56 @@ spec:
err = s.EnsureNumApisixUpstreamsCreated(1)
assert.Nil(ginkgo.GinkgoT(), err, "Checking number of
upstreams")
+ s.NewAPISIXClient().GET("/ip").WithHeader("Host",
"httpbin.com").Expect().Status(http.StatusOK)
+
+ // update
+ apisixRoute = fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
Review comment:
should add cases :
the diff `name` in the same `ApisixRoute`.
the same `name` in the diff `ApisixRoute`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3894: feat: Add ldap-auth plugin
membphis commented on pull request #3894: URL: https://github.com/apache/apisix/pull/3894#issuecomment-809177116 > @membphis there is a licence in their website https://lualdap.github.io/lualdap/license > We can open a ticket if the licence needs to be at project level https://github.com/lualdap/lualdap there is no information about `license`: https://github.com/lualdap/lualdap/search?q=license I created a new issue right now: https://github.com/lualdap/lualdap/issues/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3925: feat(skywalking): allow destory and configure report interval for rep…
spacewander commented on a change in pull request #3925: URL: https://github.com/apache/apisix/pull/3925#discussion_r603092533 ## File path: docs/zh/latest/plugins/skywalking.md ## @@ -96,6 +96,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1 | service_name | string | "APISIX" | skywalking 上报的 service 名称 | |service_instance_name|string| "APISIX Instance Name" | skywalking 上报的 service 实例名 | | endpoint | string | "http://127.0.0.1:12800; | Skywalking 的 HTTP endpoint 地址，例如：http://127.0.0.1:12800 | Review comment: @Firstsawyou Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers opened a new issue #3931: redirect plugins add curl test for `http_to_https`
tokers opened a new issue #3931: URL: https://github.com/apache/apisix/issues/3931 # Improve Docs ## Please describe which part of docs should be improved or typo fixed The document about redirect plugin contains the configuration about using `http_to_https` in redirect plugin, but it doesn't add a curl test case to show the result.  ## Describe the solution you'd like We should add a curl test case to show that a request is really redirected since the scheme is `HTTP`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3925: feat(skywalking): allow destory and configure report interval for rep…
Firstsawyou commented on a change in pull request #3925: URL: https://github.com/apache/apisix/pull/3925#discussion_r603075361 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -92,6 +92,7 @@ We can set the endpoint by specified the configuration in `conf/config.yaml`. | service_name | string | "APISIX" | service name for skywalking reporter | |service_instance_name|string|"APISIX Instance Name" | service instance name for skywalking reporter | | endpoint | string | "http://127.0.0.1:12800; | the http endpoint of Skywalking, for example: http://127.0.0.1:12800 | Review comment: ```suggestion | endpoint_addr | string | "http://127.0.0.1:12800; | the http endpoint of Skywalking, for example: http://127.0.0.1:12800 | ``` The `endpoint` field name is typo, we should fix it by the way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #3925: feat(skywalking): allow destory and configure report interval for rep…
Firstsawyou commented on a change in pull request #3925: URL: https://github.com/apache/apisix/pull/3925#discussion_r603075361 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -92,6 +92,7 @@ We can set the endpoint by specified the configuration in `conf/config.yaml`. | service_name | string | "APISIX" | service name for skywalking reporter | |service_instance_name|string|"APISIX Instance Name" | service instance name for skywalking reporter | | endpoint | string | "http://127.0.0.1:12800; | the http endpoint of Skywalking, for example: http://127.0.0.1:12800 | Review comment: ```suggestion | endpoint_addr | string | "http://127.0.0.1:12800; | the http endpoint of Skywalking, for example: http://127.0.0.1:12800 | ``` The `endpoint` field name is typo, we should fix it by the way. ## File path: docs/zh/latest/plugins/skywalking.md ## @@ -96,6 +96,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1 | service_name | string | "APISIX" | skywalking 上报的 service 名称 | |service_instance_name|string| "APISIX Instance Name" | skywalking 上报的 service 实例名 | | endpoint | string | "http://127.0.0.1:12800; | Skywalking 的 HTTP endpoint 地址，例如：http://127.0.0.1:12800 | Review comment: ditto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #319: fix: ApisixRoute update operations is not effective
tokers commented on pull request #319: URL: https://github.com/apache/apisix-ingress-controller/pull/319#issuecomment-809151542 @gxthrj Please take a look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #319: fix: ApisixRoute update operations is not effective
tokers opened a new pull request #319: URL: https://github.com/apache/apisix-ingress-controller/pull/319 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues #312 - What does this PR do: * Unify the route, upstream synchronization to the `manifest`, it's used by `ApisixRouteController`, `IngressController` and `EndpointController`. * Fixed the route synchronization bug. * Remove useless codes in `pkg/seven/state`. * Modify the e2e case `Create and remove the ApisixRoute`, adding update operation and sending requests to APISIX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] pioneer-hash opened a new issue #318: request help:
pioneer-hash opened a new issue #318:
URL: https://github.com/apache/apisix-ingress-controller/issues/318
### Issue description
When I install ingress-controller I start creating the route , unable to
synchronize configuration.
this is my ingress-log:
```
2021-03-29T14:51:53+08:00 error apisix/upstream.go:215 failed to
create upstream: unexpected status code 400; error message:
{"error_msg":"invalid configuration: additional properties forbidden, found
scheme"}
2021-03-29T14:51:53+08:00 error apisix/upstream.go:215 failed to
create upstream: unexpected status code 400; error message:
{"error_msg":"invalid configuration: additional properties forbidden, found
scheme"}
kubectl logs apisix-ingress-controller-b7b9565-rjx2p -n gray-publish | grep
test
2021-03-29T15:14:13+08:00 infocontroller/apisix_route.go:193 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"default/test","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null}}
2021-03-29T15:14:23+08:00 infocontroller/apisix_route.go:193 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"default/test","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null}}
2021-03-29T15:14:33+08:00 infocontroller/apisix_route.go:193 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"default/test","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null}}
2021-03-29T15:14:43+08:00 infocontroller/apisix_route.go:193 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"default/test","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null}}
2021-03-29T15:14:53+08:00 infocontroller/apisix_route.go:193 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"default/test","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null}}
2021-03-29T15:15:03+08:00 infocontroller/apisix_route.go:193 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"default/test","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null}}
2021-03-29T15:15:14+08:00 infocontroller/apisix_route.go:193 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"default/test","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null}}
2021-03-29T15:15:24+08:00 infocontroller/apisix_route.go:193 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"default/test","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null}}
2021-03-29T15:15:36+08:00 infocontroller/apisix_route.go:193 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"default/test","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null}}
2021-03-29T15:15:48+08:00 warncontroller/apisix_route.go:199 drop
ApisixRoute &{Type:add Object:{Key:default/test OldObject:
GroupVersion:apisix.apache.org/v2alpha1} Tombstone:} out of the queue
```
### Environment
* your apisix-ingress-controller version (output of
`apisix-ingress-controller version --long`);
* your Kubernetes cluster version (output of `kubectl version`);
* if you run apisix-ingress-controller in Bare-metal environment, also show
your OS version (`uname -a`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] pioneer-hash commented on issue #317: request help: Could not resolve host:
pioneer-hash commented on issue #317: URL: https://github.com/apache/apisix-ingress-controller/issues/317#issuecomment-809145301 This is because I changed the name generic type of the Charts.yaml file. The Apisix address domain name in the Ingress-Controller should be consistent with the Charts name installed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] pioneer-hash closed issue #317: request help: Could not resolve host:
pioneer-hash closed issue #317: URL: https://github.com/apache/apisix-ingress-controller/issues/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3145: docs: Improve proxy-rewrite plugin docs
spacewander closed issue #3145: URL: https://github.com/apache/apisix/issues/3145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3929: docs: Improve proxy-rewrite plugin docs
spacewander merged pull request #3929: URL: https://github.com/apache/apisix/pull/3929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: Improve proxy-rewrite plugin docs (#3929)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 49e4fd3 docs: Improve proxy-rewrite plugin docs (#3929) 49e4fd3 is described below commit 49e4fd307c65dc125e62987b3634a9e7358179bf Author: qian0817 <45898769+qian0...@users.noreply.github.com> AuthorDate: Mon Mar 29 15:14:13 2021 +0800 docs: Improve proxy-rewrite plugin docs (#3929) --- docs/en/latest/getting-started.md | 2 +- docs/en/latest/plugins/proxy-rewrite.md | 8 docs/zh/latest/plugins/proxy-rewrite.md | 8 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/en/latest/getting-started.md b/docs/en/latest/getting-started.md index 6592631..13f685c 100644 --- a/docs/en/latest/getting-started.md +++ b/docs/en/latest/getting-started.md @@ -219,7 +219,7 @@ curl -i -X GET http://127.0.0.1:9080/get -H "Host: httpbin.org" -H 'apikey: supe ## Add a prefix to the route Now lets say you want to add a prefix (eg: samplePrefix) to the route and do not want to use the `host` header then you can use -the proxy rewrite plugin to do it. +the proxy-rewrite plugin to do it. ```bash curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d ' diff --git a/docs/en/latest/plugins/proxy-rewrite.md b/docs/en/latest/plugins/proxy-rewrite.md index c4afb07..f5adf1f 100644 --- a/docs/en/latest/plugins/proxy-rewrite.md +++ b/docs/en/latest/plugins/proxy-rewrite.md @@ -45,7 +45,7 @@ The `proxy-rewrite` is an upstream proxy information rewriting plugin, which sup ## How To Enable -Here's an example, enable the `proxy rewrite` plugin on the specified route: +Here's an example, enable the `proxy-rewrite` plugin on the specified route: ```shell curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d ' @@ -87,11 +87,11 @@ Send the request and see upstream `access.log', if the output information is con 127.0.0.1 - [26/Sep/2019:10:52:20 +0800] iresty.com GET /test/home.html HTTP/1.1 200 38 - curl/7.29.0 - 0.000 199 107 ``` -This means that the `proxy rewrite` plugin is in effect. +This means that the `proxy-rewrite` plugin is in effect. ## Disable Plugin -When you want to disable the `proxy rewrite` plugin, it is very simple, +When you want to disable the `proxy-rewrite` plugin, it is very simple, you can delete the corresponding json configuration in the plugin configuration, no need to restart the service, it will take effect immediately : @@ -110,4 +110,4 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1 }' ``` -The `proxy rewrite` plugin has been disabled now. It works for other plugins. +The `proxy-rewrite` plugin has been disabled now. It works for other plugins. diff --git a/docs/zh/latest/plugins/proxy-rewrite.md b/docs/zh/latest/plugins/proxy-rewrite.md index 6e2d6d1..e544909 100644 --- a/docs/zh/latest/plugins/proxy-rewrite.md +++ b/docs/zh/latest/plugins/proxy-rewrite.md @@ -45,7 +45,7 @@ proxy-rewrite 是上游代理信息重写插件，支持对 `scheme`、`uri`、` ## 如何启用 -下面是一个示例，在指定的 route 上开启了 `proxy rewrite` 插件: +下面是一个示例，在指定的 route 上开启了 `proxy-rewrite` 插件: ```shell curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d ' @@ -87,11 +87,11 @@ curl -X GET http://127.0.0.1:9080/test/index.html 127.0.0.1 - [26/Sep/2019:10:52:20 +0800] iresty.com GET /test/home.html HTTP/1.1 200 38 - curl/7.29.0 - 0.000 199 107 ``` -即表示 `proxy rewrite` 插件生效了。 +即表示 `proxy-rewrite` 插件生效了。 ## 禁用插件 -当你想去掉 `proxy rewrite` 插件的时候，很简单，在插件的配置中把对应的 json 配置删除即可，无须重启服务，即刻生效： +当你想去掉 `proxy-rewrite` 插件的时候，很简单，在插件的配置中把对应的 json 配置删除即可，无须重启服务，即刻生效： ```shell curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d ' @@ -108,4 +108,4 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1 }' ``` -现在就已经移除了 `proxy rewrite` 插件了。其他插件的开启和移除也是同样的方法。 +现在就已经移除了 `proxy-rewrite` 插件了。其他插件的开启和移除也是同样的方法。
[GitHub] [apisix] KMFtcy edited a comment on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
KMFtcy edited a comment on issue #3928:
URL: https://github.com/apache/apisix/issues/3928#issuecomment-809124123
Gentlemen, I have located the problems. I found I accidentally I enable a
plugin in this page.
When I delete it , the error is gone. Sorry for my faults.
And the `invalid json data` problem was fixed when I paste this, coyied from
`https://github.com/apache/apisix/blob/master/docs/zh/latest/plugins/jwt-auth.md`
```
{
"key": "user-key",
"secret": "my-secret-key"
}
```
Thanks for all your helps. @tokers @Firstsawyou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] KMFtcy closed issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
KMFtcy closed issue #3928: URL: https://github.com/apache/apisix/issues/3928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
KMFtcy commented on issue #3928:
URL: https://github.com/apache/apisix/issues/3928#issuecomment-809124123
Gentlemen, I have located the problems. I found I accidentally I enable a
plugins in this page.
When I delete it , the error is gone. Sorry for my faults.
And the `invalid json data` problem was fixed when I paste this, coyied from
`https://github.com/apache/apisix/blob/master/docs/zh/latest/plugins/jwt-auth.md`
```
{
"key": "user-key",
"secret": "my-secret-key"
}
```
Thanks for all your helps. @tokers @Firstsawyou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809118653 And By the way, I have tried to create a consumer but it always says `invalid json data` like this:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809118141 @Firstsawyou Thanks for your reply. 1. I have check and I'm sure jwt-auth is not enabled in my routes. 2. Where can I config `global_rules` ? I cannot find it in `config-default.yaml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3870: feat(traffic-split): the upstream pass_host needs to support IP mode
spacewander commented on a change in pull request #3870: URL: https://github.com/apache/apisix/pull/3870#discussion_r603046994 ## File path: apisix/plugins/traffic-split.lua ## @@ -148,26 +148,18 @@ end local function set_pass_host(ctx, upstream_info, host) --- Currently only supports a single upstream of the domain name. --- When the upstream is `IP`, do not do any `pass_host` operation. -if not core.utils.parse_ipv4(host) - and not core.utils.parse_ipv6(host) -then -local pass_host = upstream_info.pass_host or "pass" -if pass_host == "pass" then -ctx.var.upstream_host = ctx.var.host -return -end - -if pass_host == "rewrite" then -ctx.var.upstream_host = upstream_info.upstream_host -return -end +local pass_host = upstream_info.pass_host or "pass" +if pass_host == "pass" then +return +end -ctx.var.upstream_host = host +if pass_host == "rewrite" then +ctx.var.upstream_host = upstream_info.upstream_host return end +-- only support single node for `node` mode currently +ctx.var.upstream_host = host return Review comment: We don't need an extra `return` at the end of the function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] aiyiyi121 opened a new issue #1687: request help: What’s the function of export OpenAPI on the dashboard
aiyiyi121 opened a new issue #1687: URL: https://github.com/apache/apisix-dashboard/issues/1687 ### Issue description What’s the function of export OpenAPI on the dashboard, why can't I export the configuration of routes and upstreams correctly through it. And how can I export API configuration to yaml configuration? ### Environment apisix version (cmd: apisix version): 2.4 OS (cmd: uname -a): Ubuntu 16.04.2 LTS OpenResty / Nginx version (cmd: nginx -V or openresty -V): openresty/1.19.3.1 etcd version, if have (cmd: run curl http://127.0.0.1:9090/v1/server_info to get the info from server-info API): 3.4.13 apisix-dashboard version, if have: 2.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
Firstsawyou commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809104963 @KMFtcy You need to check the following two points: 1. Is the jwt-auth plugin configured in your consumer object? If so, you need to check whether the jwt-auth plugin is enabled in the route? 2. Is the jwt-auth plugin enabled in `global_rules`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo
codecov-io edited a comment on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-808024334 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=h1) Report > Merging [#1675](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=desc) (a30f011) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/88f323285f2bdbafca027da9aef357b2e3eb4008?el=desc) (88f3232) will **increase** coverage by `1.55%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1675 +/- ## == + Coverage 72.41% 73.96% +1.55% == Files 133 86 -47 Lines5728 2612-3116 Branches 666 666 == - Hits 4148 1932-2216 + Misses 1337 680 -657 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.96% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | | | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | | | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | | | ... and [37 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1675/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=footer). Last update [88f3232...a30f011](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aiyiyi121 opened a new issue #3930: request help: What’s the function of export OpenAPI on the dashboard
aiyiyi121 opened a new issue #3930: URL: https://github.com/apache/apisix/issues/3930 ### Issue description What’s the function of export OpenAPI on the dashboard, why can't I export the configuration of routes and upstreams correctly through it. And how can I export API configuration to yaml configuration? ### Environment apisix version (cmd: apisix version): 2.4 OS (cmd: uname -a): Ubuntu 16.04.2 LTS OpenResty / Nginx version (cmd: nginx -V or openresty -V): openresty/1.19.3.1 etcd version, if have (cmd: run curl http://127.0.0.1:9090/v1/server_info to get the info from server-info API): 3.4.13 apisix-dashboard version, if have: 2.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #3929: docs: Improve proxy-rewrite plugin docs
Firstsawyou commented on pull request #3929: URL: https://github.com/apache/apisix/pull/3929#issuecomment-809097623 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809095854 @tokers No. Is it necessary to bind a consumer to a route? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal closed issue #1682: Updating URI of an existing route causes 404 error
bisakhmondal closed issue #1682: URL: https://github.com/apache/apisix-dashboard/issues/1682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1682: Updating URI of an existing route causes 404 error
bisakhmondal commented on issue #1682: URL: https://github.com/apache/apisix-dashboard/issues/1682#issuecomment-809093438 Thanks, @nic-chen, @starsz for looking into this. Actually, the error has nothing to do with manager-api. Thanks to @Jaycean, only `/hello`, `/hello_` and `/hello1` routes are whitelisted on the upstream docker image that we are currently using for testing [ [ref](https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-809023973) ]. So in the case of `newhello` it's a 404 from upstream itself. The issue isn't relevant anymore to keep it open. Thanks again, everyone. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
