[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1779: feat: Improve debug view
codecov-commenter edited a comment on pull request #1779: URL: https://github.com/apache/apisix-dashboard/pull/1779#issuecomment-821771297 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1779?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@1e2e0b7`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `64.10%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1779 +/- ## = Coverage ? 71.88% = Files ? 172 Lines ? 6071 Branches ? 709 = Hits ? 4364 Misses? 1464 Partials ? 243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.33% <56.25%> (?)` | | | backend-e2e-test-ginkgo | `49.20% <56.25%> (?)` | | | backend-unit-test | `52.23% <68.75%> (?)` | | | frontend-e2e-test | `72.11% <63.03%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1779/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `37.73% <ø> (ø)` | | | [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1779/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <ø> (ø)` | | | [...eb/src/components/Upstream/components/PassHost.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1779/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvUGFzc0hvc3QudHN4) | `90.90% <ø> (ø)` | | | [web/src/components/Upstream/components/Retries.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1779/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvUmV0cmllcy50c3g=) | `100.00% <ø> (ø)` | | | [web/src/components/Upstream/components/Timeout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1779/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVGltZW91dC50c3g=) | `100.00% <ø> (ø)` | | | [...tream/components/active-check/Healthy/Interval.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1779/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSW50ZXJ2YWwudHN4) | `33.33% <ø> (ø)` | | | [...ream/components/active-check/Healthy/Successes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1779/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1779: feat: Improve debug view
qian0817 commented on a change in pull request #1779:
URL: https://github.com/apache/apisix-dashboard/pull/1779#discussion_r615355085
##
File path: api/internal/handler/route_online_debug/route_online_debug.go
##
@@ -134,7 +132,20 @@ func (h *HTTPProtocolSupport) RequestForwarding(c
droplet.Context) (interface{},
defer resp.Body.Close()
- _body, err := ioutil.ReadAll(resp.Body)
+ // handle gzip content encoding
+ var reader io.ReadCloser
+ switch resp.Header.Get("Content-Encoding") {
Review comment:
fixed. The reason is that the default golang http client configuration
is to automatically remove the "Content-Encoding" header if "Accept-Encoding"
is not found in the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1745: change: remove ID of consumer
netlify[bot] edited a comment on pull request #1745: URL: https://github.com/apache/apisix-dashboard/pull/1745#issuecomment-817293771 Deploy preview for *apisix-dashboard* processing. Building with commit 15d1ce53b0be91e31aebde7ecd3fc72a036be847 https://app.netlify.com/sites/apisix-dashboard/deploys/607bdd4076eb9e00087a2b40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on a change in pull request #1779: feat: Improve debug view
qian0817 commented on a change in pull request #1779:
URL: https://github.com/apache/apisix-dashboard/pull/1779#discussion_r615355085
##
File path: api/internal/handler/route_online_debug/route_online_debug.go
##
@@ -134,7 +132,20 @@ func (h *HTTPProtocolSupport) RequestForwarding(c
droplet.Context) (interface{},
defer resp.Body.Close()
- _body, err := ioutil.ReadAll(resp.Body)
+ // handle gzip content encoding
+ var reader io.ReadCloser
+ switch resp.Header.Get("Content-Encoding") {
Review comment:
fixed. The reason is that the default golang http client configuration
is to automatically remove the "Content-Encoding" header if "Accept-Encoding"
not found in the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1745: change: remove ID of consumer
codecov-commenter edited a comment on pull request #1745: URL: https://github.com/apache/apisix-dashboard/pull/1745#issuecomment-821771533 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1745 +/- ## = Coverage ? 52.41% = Files ? 38 Lines ? 2675 Branches ?0 = Hits ? 1402 Misses? 1085 Partials ? 188 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `52.41% <50.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1745/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (ø)` | | | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1745/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1745/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `67.85% <69.23%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...15d1ce5](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1745: change: remove ID of consumer
codecov-commenter edited a comment on pull request #1745: URL: https://github.com/apache/apisix-dashboard/pull/1745#issuecomment-821771533 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1745 +/- ## = Coverage ? 71.46% = Files ? 47 Lines ? 3143 Branches ?0 = Hits ? 2246 Misses? 653 Partials ? 244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.04% <27.77%> (?)` | | | backend-e2e-test-ginkgo | `48.87% <16.66%> (?)` | | | backend-unit-test | `52.41% <50.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1745/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `100.00% <ø> (ø)` | | | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1745/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1745/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `91.07% <69.23%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...15d1ce5](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1745: change: remove ID of consumer
netlify[bot] edited a comment on pull request #1745: URL: https://github.com/apache/apisix-dashboard/pull/1745#issuecomment-817293771 Deploy preview for *apisix-dashboard* ready! Built with commit 15d1ce53b0be91e31aebde7ecd3fc72a036be847 https://deploy-preview-1745--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] sniper-xx opened a new issue #4074: request help: How to rewrite the data of backend server response?
sniper-xx opened a new issue #4074:
URL: https://github.com/apache/apisix/issues/4074
### Issue description
I want to developing a plugin of apisix to fulfill unified format
encapsulation. for example:
```json
{
"status": 200,
"msg": "ok",
"data": "datas real response from backend server..."
}
```
I writed a plugin , override the _M.body_filter method, but the funcation
is not work correct. the code:
```lua
function _M.body_filter(conf, ctx)
core.log.error("--body_filter->")
local result = {
msg="ok",
code=status_code,
success=true
}
local isFinished = ngx.arg[2]
local resp_code = tonumber(status_code)
if not isFinished then
backend_content = backend_content..ngx.arg[1]
core.log.error("reading:>
",string.len(backend_content))
ngx.arg[2] = false
end
if isFinished then
--ngx.arg[2] = false
core.log.error("end:> ",ngx.arg[1])
core.log.error("ending:==>
",string.len(backend_content))
--local r = "{\"mystatus\":200,\"data\":"..backend_content.."}";
result['data'] = cjson_decode(backend_content)
--ngx.arg[2] = true
ngx.arg[1] = cjson_encode(result)
ngx.arg[2] = true
end
end
```
the error is:
1、sometimes the client browser is not receive integrated json ;
2、the cjson_decode is error, printed error is : Expected end but
to_obejct_begin.
My Question is how to implements the uniform data form wrap? please.
### Environment
* apisix version (cmd: `apisix version`):
* OS (cmd: `uname -a`):
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
* etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
* apisix-dashboard version, if have:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] sniper-xx commented on issue #4074: request help: How to rewrite the data of backend server response?
sniper-xx commented on issue #4074: URL: https://github.com/apache/apisix/issues/4074#issuecomment-821948172 Or how get the upstream server addr and rewrited request uri, I send subrequest to get data from backend server in phase of rewrite or access. the resovlution is ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1745: change: remove ID of consumer
codecov-commenter edited a comment on pull request #1745: URL: https://github.com/apache/apisix-dashboard/pull/1745#issuecomment-821771533 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `52.63%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1745 +/- ## = Coverage ? 71.69% = Files ? 172 Lines ? 6049 Branches ? 699 = Hits ? 4337 Misses? 1468 Partials ? 244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.04% <27.77%> (?)` | | | backend-e2e-test-ginkgo | `48.87% <16.66%> (?)` | | | backend-unit-test | `52.41% <50.00%> (?)` | | | frontend-e2e-test | `71.95% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1745/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `100.00% <ø> (ø)` | | | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1745/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1745/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `91.07% <69.23%> (ø)` | | | [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1745/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `62.23% <100.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...15d1ce5](https://codecov.io/gh/apache/apisix-dashboard/pull/1745?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comm
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1785: chore: remove Chinese & update plugin type
LiteSun commented on a change in pull request #1785:
URL: https://github.com/apache/apisix-dashboard/pull/1785#discussion_r615362629
##
File path: web/src/pages/Route/transform.ts
##
@@ -158,7 +158,11 @@ export const transformStepData = ({
default:
key = `arg_${name}`;
}
- return [key, operator, value];
+ let finalValue = value
+ if (operator === "IN") {
+finalValue = JSON.parse(value as string)
Review comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1784: fix: show correct health checker
LiteSun commented on a change in pull request #1784:
URL: https://github.com/apache/apisix-dashboard/pull/1784#discussion_r615363809
##
File path: web/src/pages/Route/components/Step1/MetaView.tsx
##
@@ -285,27 +285,44 @@ const MetaView: React.FC = ({
disabled, form, isEdit
)
const ServiceSelector: React.FC = () => (
-
-
-
-
-
- {/* TODO: value === '' means no service_id select, need to find
a better way */}
-
-{formatMessage({ id: "page.route.service.none" })}
-
- {serviceList.map((item) => {
-return (
-
-{item.name}
-
-);
- })}
-
-
-
-
-
+
+
Review comment:
i18n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4074: request help: How to rewrite the data of backend server response?
Firstsawyou commented on issue #4074: URL: https://github.com/apache/apisix/issues/4074#issuecomment-821956134 How to rewrite the backend server response data, you can try to use the `response-rewrite` plugin, https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/response-rewrite.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* processing. Building with commit 60a7b4e14cd2de770947b7f91e159c1f4b023e1d https://app.netlify.com/sites/apisix-dashboard/deploys/607bfb141e586f0007e67d39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1784: fix: show correct health checker
juzhiyuan commented on a change in pull request #1784:
URL: https://github.com/apache/apisix-dashboard/pull/1784#discussion_r615370196
##
File path: web/src/pages/Route/components/Step1/MetaView.tsx
##
@@ -285,27 +285,44 @@ const MetaView: React.FC = ({
disabled, form, isEdit
)
const ServiceSelector: React.FC = () => (
-
-
-
-
-
- {/* TODO: value === '' means no service_id select, need to find
a better way */}
-
-{formatMessage({ id: "page.route.service.none" })}
-
- {serviceList.map((item) => {
-return (
-
-{item.name}
-
-);
- })}
-
-
-
-
-
+
+
Review comment:
Hi, this PR will fix this.
https://github.com/apache/apisix-dashboard/pull/1785/files#diff-48bf46c8113258031a14f9204041bb5ff51de312ef61c7686f41ea3499fe2c14R176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter commented on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 52.27% = Files ? 38 Lines ? 2661 Branches ?0 = Hits ? 1391 Misses? 1082 Partials ? 188 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `52.27% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...60a7b4e](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 71.36% = Files ? 47 Lines ? 3129 Branches ?0 = Hits ? 2233 Misses? 652 Partials ? 244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.19% <ø> (?)` | | | backend-e2e-test-ginkgo | `49.02% <ø> (?)` | | | backend-unit-test | `52.27% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...60a7b4e](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 66.82% = Files ? 47 Lines ? 3129 Branches ?0 = Hits ? 2091 Misses? 784 Partials ? 254 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.78% <ø> (?)` | | | backend-unit-test | `52.27% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...60a7b4e](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1610: feat: improve the config plugin button enable disable status
juzhiyuan commented on a change in pull request #1610:
URL: https://github.com/apache/apisix-dashboard/pull/1610#discussion_r615371124
##
File path:
web/cypress/integration/route/create-route-with-limit-count-plugin-form.spec.js
##
@@ -57,7 +57,7 @@ context('Create and delete route with limit-count form', ()
=> {
// config limit-count form with local policy
cy.contains(this.domSelector.pluginCard, 'limit-count').within(() => {
- cy.contains('Enable').click({
+ cy.get('button').click({
Review comment:
If we have multiple buttons, which one it will take?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* ready! Built with commit 60a7b4e14cd2de770947b7f91e159c1f4b023e1d https://deploy-preview-1767--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1610: feat: improve the config plugin button enable disable status
juzhiyuan commented on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-821962357 @guoqqqi Please recheck this PR, and merge the latest master codes to this one, and see if it's working properly, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* processing. Building with commit 962cb77e836452079c36d5be3f9878fcf0e63e1a https://app.netlify.com/sites/apisix-dashboard/deploys/607bff1594778b0008d18530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
juzhiyuan commented on pull request #1781: URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-821963150 @bisakhmondal Hi, please sync codes to your branch, the FE CI will get fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1705: fix: detailed error for store init failure and deferred execution of closers
juzhiyuan commented on pull request #1705: URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-821963186 emmm what happened then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. > :exclamation: Current head 60a7b4e differs from pull request most recent head 962cb77. Consider uploading reports for the commit 962cb77 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 71.69% = Files ? 172 Lines ? 6035 Branches ? 699 = Hits ? 4327 Misses? 1464 Partials ? 244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.19% <ø> (?)` | | | backend-e2e-test-ginkgo | `49.02% <ø> (?)` | | | backend-unit-test | `52.27% <ø> (?)` | | | frontend-e2e-test | `72.05% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...962cb77](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 52.27% = Files ? 38 Lines ? 2661 Branches ?0 = Hits ? 1391 Misses? 1082 Partials ? 188 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `52.27% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...962cb77](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 66.95% = Files ? 47 Lines ? 3129 Branches ?0 = Hits ? 2095 Misses? 777 Partials ? 257 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `46.91% <ø> (?)` | | | backend-unit-test | `52.27% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...962cb77](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 71.49% = Files ? 47 Lines ? 3129 Branches ?0 = Hits ? 2237 Misses? 647 Partials ? 245 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.32% <ø> (?)` | | | backend-e2e-test-ginkgo | `49.12% <ø> (?)` | | | backend-unit-test | `52.27% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...962cb77](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1391: feat: embed all generated web assets into api binary
juzhiyuan commented on issue #1391: URL: https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-821963799 nice job! Should we support this feature as a command, like `make build --bundle=true`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1783: docs: update default conf link (deploy-with-docker.md)
juzhiyuan commented on pull request #1783: URL: https://github.com/apache/apisix-dashboard/pull/1783#issuecomment-821963882 Thanks man! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* ready! Built with commit 962cb77e836452079c36d5be3f9878fcf0e63e1a https://deploy-preview-1767--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1767: change: remove listen.host from api/conf/conf.yaml
nic-chen commented on a change in pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#discussion_r615373662 ## File path: .github/workflows/deploy-with-docker.yml ## @@ -33,8 +33,9 @@ jobs: - name: Modify Config run: | sed -i 's/127.0.0.1:2379/172.16.238.10:2379/' api/conf/conf.yaml - sed -i 's/host: 127.0.0.1/host: 0.0.0.0/' api/conf/conf.yaml Review comment: added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1784: fix: show correct health checker
netlify[bot] edited a comment on pull request #1784: URL: https://github.com/apache/apisix-dashboard/pull/1784#issuecomment-821822616 Deploy preview for *apisix-dashboard* processing. Building with commit 2cf58bdb45a2287dfd5a7312436aaa2806c601d7 https://app.netlify.com/sites/apisix-dashboard/deploys/607c0365b222c200073ad258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 71.79% = Files ? 172 Lines ? 6035 Branches ? 699 = Hits ? 4333 Misses? 1457 Partials ? 245 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.32% <ø> (?)` | | | backend-e2e-test-ginkgo | `49.12% <ø> (?)` | | | backend-unit-test | `52.27% <ø> (?)` | | | frontend-e2e-test | `72.12% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...962cb77](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1784: fix: show correct health checker
netlify[bot] edited a comment on pull request #1784: URL: https://github.com/apache/apisix-dashboard/pull/1784#issuecomment-821822616 Deploy preview for *apisix-dashboard* ready! Built with commit 2cf58bdb45a2287dfd5a7312436aaa2806c601d7 https://deploy-preview-1784--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1784: fix: show correct health checker
codecov-commenter commented on pull request #1784: URL: https://github.com/apache/apisix-dashboard/pull/1784#issuecomment-821968697 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1784?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@1e2e0b7`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `67.96%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1784 +/- ## = Coverage ? 72.20% = Files ? 124 Lines ? 2907 Branches ? 697 = Hits ? 2099 Misses? 808 Partials ?0 ``` | Flag | Coverage Δ | | |---|---|---| | frontend-e2e-test | `72.20% <67.96%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <ø> (ø)` | | | [web/src/components/Upstream/components/Retries.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvUmV0cmllcy50c3g=) | `100.00% <ø> (ø)` | | | [web/src/components/Upstream/components/Timeout.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVGltZW91dC50c3g=) | `100.00% <ø> (ø)` | | | [...tream/components/active-check/Healthy/Interval.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSW50ZXJ2YWwudHN4) | `33.33% <ø> (ø)` | | | [...ream/components/active-check/Healthy/Successes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvU3VjY2Vzc2VzLnRzeA==) | `33.33% <ø> (ø)` | | | [...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4) | `33.33% <ø> (ø)` | | | [...ents/Upstream/components/active-check/HttpPath.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0h0dHBQYXRoLnRzeA==) | `33.33%
[GitHub] [apisix] sniper-xx commented on issue #4074: request help: How to rewrite the data of backend server response?
sniper-xx commented on issue #4074: URL: https://github.com/apache/apisix/issues/4074#issuecomment-821970382 @Firstsawyou I refer to this plugin to write a new plugin. there are tow defferences: 1、 The ‘body' which is not static, is from the backend service; 2、The body content is very large. function of body_filter executed many times; I try to concatenate the chunck of every body_filter function received from backend,but can't not correct serialize to integrated json document. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1786: fix: historical comments issues
juzhiyuan commented on a change in pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#discussion_r615379113
##
File path: web/src/components/Plugin/UI/cors.tsx
##
@@ -57,9 +57,9 @@ const Cors: React.FC = ({ form }) => {
{
-((value as string[]).join(","));
-if ((value as string[]).includes('*')) {
+ onChange={(value: string[]) => {
+value.join(",")
Review comment:
so why do we need this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: improve the config plugin button enable disable status (#1610)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new c9d2bd3 feat: improve the config plugin button enable disable status
(#1610)
c9d2bd3 is described below
commit c9d2bd328a5c7f48f1a7be27d7f0ec0af3748b64
Author: Cliff Su
AuthorDate: Sun Apr 18 18:43:36 2021 +0800
feat: improve the config plugin button enable disable status (#1610)
Co-authored-by: 琚致远
---
.../create-edit-delete-plugin-template.spec.js | 2 +-
.../route/create-route-with-limit-count-plugin-form.spec.js | 6 +++---
.../integration/service/edit-service-with-upstream.spec.js | 1 +
web/cypress/support/commands.js | 2 +-
web/src/components/Plugin/PluginPage.tsx| 13 +++--
web/src/components/Plugin/locales/en-US.ts | 2 ++
web/src/components/Plugin/locales/zh-CN.ts | 2 ++
7 files changed, 17 insertions(+), 11 deletions(-)
diff --git
a/web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
b/web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
index cd3a2a4..255740c 100644
---
a/web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
+++
b/web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
@@ -41,7 +41,7 @@ context('Create Configure and Delete PluginTemplate', () => {
cy.contains('proxy-rewrite').should('not.exist');
cy.contains(this.domSelector.pluginCard, 'basic-auth').within(() => {
- cy.contains('Enable').click({
+ cy.get('button').click({
force: true,
});
});
diff --git
a/web/cypress/integration/route/create-route-with-limit-count-plugin-form.spec.js
b/web/cypress/integration/route/create-route-with-limit-count-plugin-form.spec.js
index f9db28b..b1df99e 100644
---
a/web/cypress/integration/route/create-route-with-limit-count-plugin-form.spec.js
+++
b/web/cypress/integration/route/create-route-with-limit-count-plugin-form.spec.js
@@ -57,7 +57,7 @@ context('Create and delete route with limit-count form', ()
=> {
// config limit-count form with local policy
cy.contains(this.domSelector.pluginCard, 'limit-count').within(() => {
- cy.contains('Enable').click({
+ cy.get('button').click({
force: true,
});
});
@@ -75,7 +75,7 @@ context('Create and delete route with limit-count form', ()
=> {
// config limit-count form with redis policy
cy.contains(this.domSelector.pluginCard, 'limit-count').within(() => {
- cy.contains('Enable').click({
+ cy.get('button').click({
force: true,
});
});
@@ -97,7 +97,7 @@ context('Create and delete route with limit-count form', ()
=> {
// config limit-count form with redis policy
cy.contains(this.domSelector.pluginCard, 'limit-count').within(() => {
- cy.contains('Enable').click({
+ cy.get('button').click({
force: true,
});
});
diff --git a/web/cypress/integration/service/edit-service-with-upstream.spec.js
b/web/cypress/integration/service/edit-service-with-upstream.spec.js
index 87be509..66e9c2f 100644
--- a/web/cypress/integration/service/edit-service-with-upstream.spec.js
+++ b/web/cypress/integration/service/edit-service-with-upstream.spec.js
@@ -40,6 +40,7 @@ context('Edit Service with Upstream', () => {
it('should create a test service', function () {
cy.visit('/');
+cy.get('.ant-empty').should('be.visible');
cy.contains('Service').click();
cy.get(this.domSelector.empty).should('be.visible');
cy.contains('Create').click();
diff --git a/web/cypress/support/commands.js b/web/cypress/support/commands.js
index 590243c..4592efb 100644
--- a/web/cypress/support/commands.js
+++ b/web/cypress/support/commands.js
@@ -59,7 +59,7 @@ Cypress.Commands.add('configurePlugins', (cases) => {
cy.contains(name)
.parents(domSelector.parents)
.within(() => {
-cy.contains('Enable').click({
+cy.get('button').click({
force: true,
});
});
diff --git a/web/src/components/Plugin/PluginPage.tsx
b/web/src/components/Plugin/PluginPage.tsx
index 61e9bee..f47f9fd 100644
--- a/web/src/components/Plugin/PluginPage.tsx
+++ b/web/src/components/Plugin/PluginPage.tsx
@@ -183,16 +183,17 @@ const PluginPage: React.FC = ({
key={item.name}
actions={[
{
setName(item.name);
}}
>
- Enable
+ {
+initialData[item.name] &&
!initialData[item.name].disable
+ ? formatMessage({ id: 'component.plu
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1610: feat: improve the config plugin button enable disable status
juzhiyuan merged pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1586: Config Plugin button enable status
juzhiyuan closed issue #1586: URL: https://github.com/apache/apisix-dashboard/issues/1586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1767: change: remove listen.host from api/conf/conf.yaml
starsz commented on a change in pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#discussion_r615390927 ## File path: api/conf/conf.yaml ## @@ -17,10 +17,15 @@ conf: listen: -host: 127.0.0.1 # `manager api` listening ip or host name Review comment: We still support configuring the host. So can we comment on this instead of removing them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1767: change: remove listen.host from api/conf/conf.yaml
membphis commented on a change in pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#discussion_r615393394 ## File path: api/conf/conf.yaml ## @@ -17,10 +17,15 @@ conf: listen: -host: 127.0.0.1 # `manager api` listening ip or host name Review comment: @starsz your way is better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1767: change: remove listen.host from api/conf/conf.yaml
membphis commented on a change in pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#discussion_r615393922 ## File path: api/conf/conf.yaml ## @@ -17,10 +17,15 @@ conf: listen: -host: 127.0.0.1 # `manager api` listening ip or host name port: 9000 # `manager api` listening port allow_list: # If we don't set any IP list, then any IP access is allowed by default. - 127.0.0.0/24 +- 10.0.0.0/8 Review comment: only one `127.0.0.0/24` is enough. we can add more comment to show how to set it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (c9d2bd3 -> c35203a)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from c9d2bd3 feat: improve the config plugin button enable disable status
(#1610)
add c35203a chore: keep using English as comments & update plugin type
(#1785)
No new revisions were added by this update.
Summary of changes:
web/package.json | 1 -
.../Step2 => components/PanelSection}/index.tsx| 30 +-
web/src/components/Plugin/PluginPage.tsx | 2 +-
web/src/components/Plugin/data.tsx | 17 ++--
web/src/components/Plugin/locales/en-US.ts | 1 -
web/src/components/Plugin/locales/zh-CN.ts | 1 -
web/src/components/RightContent/AvatarDropdown.tsx | 3 ---
web/src/components/Upstream/UpstreamForm.tsx | 4 +--
web/src/components/Upstream/components/TLS.tsx | 4 +--
.../Upstream/components/passive-check/Type.tsx | 4 +--
web/src/components/Upstream/locales/en-US.ts | 2 ++
web/src/components/Upstream/locales/zh-CN.ts | 2 ++
web/src/global.less| 1 -
web/src/helpers.tsx| 3 ---
.../Route/components/DebugViews/DebugDrawView.tsx | 3 ++-
.../Route/components/Step1/MatchingRulesView.tsx | 24 -
web/src/pages/Route/components/Step1/MetaView.tsx | 8 +++---
.../pages/Route/components/Step1/ProxyRewrite.tsx | 3 ++-
.../Route/components/Step1/RequestConfigView.tsx | 3 ++-
web/src/pages/Route/locales/en-US.ts | 7 +
web/src/pages/Route/locales/zh-CN.ts | 7 +
web/src/pages/Route/transform.ts | 10 +---
web/src/pages/Route/typing.d.ts| 4 +--
web/src/pages/Upstream/Create.tsx | 3 +--
web/src/pages/Upstream/locales/en-US.ts| 4 ++-
web/src/pages/Upstream/locales/zh-CN.ts| 4 ++-
web/src/typings.d.ts | 1 -
web/yarn.lock | 5
28 files changed, 94 insertions(+), 67 deletions(-)
copy web/src/{pages/SSL/components/Step2 => components/PanelSection}/index.tsx
(59%)
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1785: chore: keep using English as comments & update plugin type
juzhiyuan merged pull request #1785: URL: https://github.com/apache/apisix-dashboard/pull/1785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1784: fix: show correct health checker
netlify[bot] edited a comment on pull request #1784: URL: https://github.com/apache/apisix-dashboard/pull/1784#issuecomment-821822616 Deploy preview for *apisix-dashboard* processing. Building with commit 508abbf4db4c57e5c0dea4af403e3ee15c811b3f https://app.netlify.com/sites/apisix-dashboard/deploys/607c2ccd920fc600070b86b7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1784: fix: show correct health checker
netlify[bot] edited a comment on pull request #1784: URL: https://github.com/apache/apisix-dashboard/pull/1784#issuecomment-821822616 Deploy preview for *apisix-dashboard* ready! Built with commit 508abbf4db4c57e5c0dea4af403e3ee15c811b3f https://deploy-preview-1784--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1784: fix: show correct health checker
codecov-commenter edited a comment on pull request #1784: URL: https://github.com/apache/apisix-dashboard/pull/1784#issuecomment-821968697 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1784?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1784](https://codecov.io/gh/apache/apisix-dashboard/pull/1784?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (508abbf) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c35203aa524d4ccf1e51990ae0855ad4cbd7608a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c35203a) will **increase** coverage by `0.05%`. > The diff coverage is `86.27%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1784 +/- ## == + Coverage 72.08% 72.14% +0.05% == Files 126 125 -1 Lines2920 2922 +2 Branches 705 703 -2 == + Hits 2105 2108 +3 + Misses815 814 -1 ``` | Flag | Coverage Δ | | |---|---|---| | frontend-e2e-test | `72.14% <86.27%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1784?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...mponents/Upstream/components/active-check/Host.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hvc3QudHN4) | `33.33% <ø> (ø)` | | | [...ents/Upstream/components/active-check/HttpPath.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0h0dHBQYXRoLnRzeA==) | `33.33% <ø> (ø)` | | | [...mponents/Upstream/components/active-check/Port.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1BvcnQudHN4) | `33.33% <ø> (ø)` | | | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | `90.74% <ø> (ø)` | | | [web/src/pages/Route/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9zZXJ2aWNlLnRz) | `88.23% <ø> (-0.66%)` | :arrow_down: | | [web/src/pages/Service/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL3NlcnZpY2UudHM=) | `100.00% <ø> (ø)` | | | [...eb/src/components/Upstream/components/PassHost.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1784/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvUGFzc
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
netlify[bot] edited a comment on pull request #1781: URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-820443115 Deploy preview for *apisix-dashboard* processing. Building with commit a559218e471af77eb1e6b14df76ac4361406f09f https://app.netlify.com/sites/apisix-dashboard/deploys/607c37f9b9dc940008ac5d6a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1781: feat: rewrite route-with-jwt-plugin-test using ginkgo
netlify[bot] edited a comment on pull request #1781: URL: https://github.com/apache/apisix-dashboard/pull/1781#issuecomment-820443115 Deploy preview for *apisix-dashboard* ready! Built with commit a559218e471af77eb1e6b14df76ac4361406f09f https://deploy-preview-1781--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1391: feat: embed all generated web assets into api binary
bisakhmondal commented on issue #1391: URL: https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-821995545 Hii, as of now, running `make build` includes the web assets and `./api/build.sh` doesn't. When the assets aren't included I've added a static HTML that is going to be rendered.  Do let me know, the commands that are going to be preferred. I'd be happy to update accordingly :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1779: feat: Improve debug view
liuxiran commented on a change in pull request #1779:
URL: https://github.com/apache/apisix-dashboard/pull/1779#discussion_r615403679
##
File path: web/src/pages/Route/components/DebugViews/DebugDrawView.tsx
##
@@ -229,8 +233,23 @@ const DebugDrawView: React.FC
= (props) => {
}, bodyFormData)
.then((req) => {
setLoading(false);
-setResponseBody(JSON.stringify(req.data.data, null, 2));
-setResponseHeader(JSON.stringify(req.data.header, null, 2));
+const resp: RouteModule.debugResponse= req.data;
+if (typeof (resp.data) !== 'string') {
Review comment:
got it, thanks for your interpretation, just cc @Jaycean to take a look,
this part may need to be optimized in a new pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1391: feat: embed all generated web assets into api binary
juzhiyuan commented on issue #1391: URL: https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-821997665 You mean we could support 3 ways like this? - Build ManagerAPI only; - Build Web & ManagerAPI together but separately; - Build Web & ManagerAPI together and bundle them together; The third one is good for me! But it will make the documentation complex, too 🤔 How about others? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* processing. Building with commit c265f14a1ab18c67f12b1fefce270a2bc8693d2d https://app.netlify.com/sites/apisix-dashboard/deploys/607c4152a949ee00085ac3cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 52.27% = Files ? 38 Lines ? 2661 Branches ?0 = Hits ? 1391 Misses? 1082 Partials ? 188 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `52.27% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...c265f14](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* ready! Built with commit c265f14a1ab18c67f12b1fefce270a2bc8693d2d https://deploy-preview-1767--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 62.60% = Files ? 164 Lines ? 5581 Branches ? 705 = Hits ? 3494 Misses? 1899 Partials ? 188 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `52.27% <ø> (?)` | | | frontend-e2e-test | `72.02% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...c265f14](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* processing. Building with commit 2ceb4e7ed4a49493df7affe0f5d30e239f5fca10 https://app.netlify.com/sites/apisix-dashboard/deploys/607c4873eefd350008cd8dcf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 52.23% = Files ? 38 Lines ? 2661 Branches ?0 = Hits ? 1390 Misses? 1083 Partials ? 188 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `52.23% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...2ceb4e7](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 67.05% = Files ? 47 Lines ? 3129 Branches ?0 = Hits ? 2098 Misses? 774 Partials ? 257 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `47.04% <ø> (?)` | | | backend-unit-test | `52.23% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...2ceb4e7](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 71.46% = Files ? 47 Lines ? 3129 Branches ?0 = Hits ? 2236 Misses? 648 Partials ? 245 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.32% <ø> (?)` | | | backend-e2e-test-ginkgo | `49.28% <ø> (?)` | | | backend-unit-test | `52.23% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...2ceb4e7](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* ready! Built with commit 2ceb4e7ed4a49493df7affe0f5d30e239f5fca10 https://deploy-preview-1767--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] fhuzero commented on issue #73: kubectl plugin support
fhuzero commented on issue #73: URL: https://github.com/apache/apisix-ingress-controller/issues/73#issuecomment-822007555 Hi @tokers and @masfbeca , it seems that this issue has not been updated for over two months. If possible, I would love to contribute to this repo starting from addressing this issue (#73). Would it be okay for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 71.76% = Files ? 173 Lines ? 6049 Branches ? 705 = Hits ? 4341 Misses? 1463 Partials ? 245 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.32% <ø> (?)` | | | backend-e2e-test-ginkgo | `49.28% <ø> (?)` | | | backend-unit-test | `52.23% <ø> (?)` | | | frontend-e2e-test | `72.08% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...2ceb4e7](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* processing. Building with commit fd6cd9998d9b43d7ea87d132196813e93881a02f https://app.netlify.com/sites/apisix-dashboard/deploys/607c54755d522a000776e0e6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 52.27% = Files ? 38 Lines ? 2661 Branches ?0 = Hits ? 1391 Misses? 1082 Partials ? 188 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `52.27% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...fd6cd99](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* ready! Built with commit fd6cd9998d9b43d7ea87d132196813e93881a02f https://deploy-preview-1767--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* processing. Building with commit a0f137a1c06830b325762e8955844f3a97296ac8 https://app.netlify.com/sites/apisix-dashboard/deploys/607c571c88aa3500071249e4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 52.23% = Files ? 38 Lines ? 2661 Branches ?0 = Hits ? 1390 Misses? 1083 Partials ? 188 ``` | Flag | Coverage Δ | | |---|---|---| | backend-unit-test | `52.23% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...a0f137a](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 67.05% = Files ? 47 Lines ? 3129 Branches ?0 = Hits ? 2098 Misses? 774 Partials ? 257 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `47.04% <ø> (?)` | | | backend-unit-test | `52.23% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...a0f137a](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 71.46% = Files ? 47 Lines ? 3129 Branches ?0 = Hits ? 2236 Misses? 648 Partials ? 245 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.32% <ø> (?)` | | | backend-e2e-test-ginkgo | `49.15% <ø> (?)` | | | backend-unit-test | `52.23% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...a0f137a](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* ready! Built with commit a0f137a1c06830b325762e8955844f3a97296ac8 https://deploy-preview-1767--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f1b8f0c`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master#1767 +/- ## = Coverage ? 71.74% = Files ? 173 Lines ? 6049 Branches ? 705 = Hits ? 4340 Misses? 1464 Partials ? 245 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.32% <ø> (?)` | | | backend-e2e-test-ginkgo | `49.15% <ø> (?)` | | | backend-unit-test | `52.23% <ø> (?)` | | | frontend-e2e-test | `72.05% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1b8f0c...a0f137a](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1391: feat: embed all generated web assets into api binary
bisakhmondal commented on issue #1391: URL: https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-822018739 I guess option 1 and 3 would be fine. Option 1 (say `make api-build`) for not bloating the binary size for the users who just need manager-api only and option 3 (`make build`) as a complete package. Also option 1 would be helpful for fast debugging as each time building the web would incur significant time. We may update the docs stating the benefits and options. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] fhuzero commented on issue #321: Add e2e test cases for plugins
fhuzero commented on issue #321: URL: https://github.com/apache/apisix-ingress-controller/issues/321#issuecomment-822023741 I'd like to write e2e test cases for plugin "server-info". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1784: fix: show correct health checker
liuxiran commented on a change in pull request #1784:
URL: https://github.com/apache/apisix-dashboard/pull/1784#discussion_r615463646
##
File path: web/src/components/Upstream/locales/zh-CN.ts
##
@@ -95,4 +94,10 @@ export default {
'component.upstream.fields.checks.passive.unhealthy.timeouts': '超时时间',
'component.upstream.fields.checks.passive.unhealthy.timeouts.tooltip':
'根据被动健康检查的观察，在代理中认为目标不健康的超时次数。',
+
+ 'component.upstream.other.none': '不选择（仅在绑定服务时可用）',
Review comment:
we will reuse `UpstreamForm` when creating a service
so remove `（仅在绑定服务时可用）` may be more general here or change another remark
^_^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1784: fix: show correct health checker
juzhiyuan commented on a change in pull request #1784:
URL: https://github.com/apache/apisix-dashboard/pull/1784#discussion_r615464564
##
File path: web/src/components/Upstream/locales/zh-CN.ts
##
@@ -95,4 +94,10 @@ export default {
'component.upstream.fields.checks.passive.unhealthy.timeouts': '超时时间',
'component.upstream.fields.checks.passive.unhealthy.timeouts.tooltip':
'根据被动健康检查的观察，在代理中认为目标不健康的超时次数。',
+
+ 'component.upstream.other.none': '不选择（仅在绑定服务时可用）',
Review comment:
sure, I will handle this case in a new PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1787: don't show None in UpstreamForm when creating Service
juzhiyuan opened a new issue #1787: URL: https://github.com/apache/apisix-dashboard/issues/1787 we will reuse `UpstreamForm` when creating a service  so remove `（仅在绑定服务时可用）` may be more general here or change another remark ^_^ _Originally posted by @liuxiran in https://github.com/apache/apisix-dashboard/pull/1784#discussion_r615463646_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1787: don't show None in UpstreamForm when creating Service
liuxiran commented on issue #1787: URL: https://github.com/apache/apisix-dashboard/issues/1787#issuecomment-822077028 refer to #1616 , we need `None` here, just change the remark for it ^-^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: update the Getting Started guide in Chinese (#3980)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 3549829 docs: update the Getting Started guide in Chinese (#3980)
3549829 is described below
commit 35498295f092347b087a188aa2b157228fe32976
Author: XianLei Gao <279483...@qq.com>
AuthorDate: Mon Apr 19 08:46:15 2021 +0800
docs: update the Getting Started guide in Chinese (#3980)
Co-authored-by: 琚致远
---
docs/en/latest/getting-started.md | 4 +-
docs/zh/latest/getting-started.md | 280 +-
2 files changed, 157 insertions(+), 127 deletions(-)
diff --git a/docs/en/latest/getting-started.md
b/docs/en/latest/getting-started.md
index aee66b5..faea360 100644
--- a/docs/en/latest/getting-started.md
+++ b/docs/en/latest/getting-started.md
@@ -216,7 +216,7 @@ $ curl http://127.0.0.1:9080/apisix/admin/consumers -H
'X-API-KEY: edd1c9f034335
Next, let's bind our `Consumer(John)` to that `Route`, we only need to
**Enable** the [key-auth](./plugins/key-auth.md) plugin for that `Route`:
```bash
-curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+$ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri": "/get",
"host": "httpbin.org",
@@ -241,7 +241,7 @@ Now lets say you want to add a prefix (eg: samplePrefix) to
the route and do not
the proxy-rewrite plugin to do it.
```bash
-curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+$ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri": "/samplePrefix/get",
"plugins": {
diff --git a/docs/zh/latest/getting-started.md
b/docs/zh/latest/getting-started.md
index ea7d60b..c86e015 100644
--- a/docs/zh/latest/getting-started.md
+++ b/docs/zh/latest/getting-started.md
@@ -21,33 +21,63 @@ title: 快速入门指南
#
-->
-本指南的目的是介绍如何使用 APISIX 来配置出一个安全的可以对外提供服务的 API。当您读完本指南，你需要自己安装一下 APISIX
应用，并准备好一个可以对外提供服务的 API，该服务将由 API key 进行访问保护。
+本指南旨在让大家入门 Apache APISIX，我们将配置一个对外提供公共 API 的服务，并由 API key 进行访问保护。
-本指南会使用到以下 GET 请求，该服务可以回显发送到这个 API 的传参。
+另外，我们将以下面的 `echo` 端点为例，它将返回我们传递的参数。
+
+**Request**
```bash
-$ curl --location --request GET "https://httpbin.org/get?foo1=bar1&foo2=bar2";
+$ curl --location --request GET "http://httpbin.org/get?foo1=bar1&foo2=bar2";
```
-让我们来分析一下这个 URL 请求
+**Response**
-- Scheme: HTTPS
-- Host/Address: httpbin.org
-- Port: 443
-- URI: /get
+```json
+{
+ "args": {
+"foo1": "bar1",
+"foo2": "bar2"
+ },
+ "headers": {
+"Accept":
"text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9",
+"Accept-Encoding": "gzip, deflate, br",
+"Accept-Language": "en,zh-CN;q=0.9,zh;q=0.8",
+"Cache-Control": "max-age=0",
+"Host": "httpbin.org",
+"Sec-Ch-Ua": "\"Google Chrome\";v=\"89\", \"Chromium\";v=\"89\", \";Not A
Brand\";v=\"99\"",
+"Sec-Ch-Ua-Mobile": "?0",
+"Sec-Fetch-Dest": "document",
+"Sec-Fetch-Mode": "navigate",
+"Sec-Fetch-Site": "none",
+"Sec-Fetch-User": "?1",
+"Upgrade-Insecure-Requests": "1",
+"User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 11_2_2)
AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.90 Safari/537.36",
+"X-Amzn-Trace-Id": "Root=1-606276ab-2b451d4b36057c186d666351"
+ },
+ "origin": "58.152.81.42",
+ "url": "http://httpbin.org/get?foo1=bar1&foo2=bar2";
+}
+```
+
+让我们来分析一下上面的请求 URL：
+
+- Protocol: HTTP
+- Port: 80
+- Host: `httpbin.org`
+- URI/Path: `/get`
- Query Parameters: foo1, foo2
## 前提
-- 本指南使用 docker 和 docker compose 来安装 Apache APISIX。 但是， 如果您已经以其他方式安装了 Apache
APISIX ，您只需跳到 [第二步](getting-started.md#第二步:-在-APISIX-中设置路由) 。
-- Curl：指南使用 Curl 命令进行 API 测试，但是您也可以使用您选择的任何其他工具（ 例如 Postman ）。
+> 如果您已经安装了 Apache APISIX，请直接阅读 [第二步](getting-started.md#第二步:-创建一个-Route)
-## 第一步: 安装 APISIX
+- 本指南使用 [Docker](https://www.docker.com/) 和 [Docker
Compose](https://docs.docker.com/compose/) 来安装 Apache APISIX。
+- `curl`：本指南使用 [curl](https://curl.se/docs/manpage.html) 命令行进行 API
测试，但是您也可以使用任何其它工具，例如 [Postman](https://www.postman.com/)。
-Apache APISIX 可以多种操作环境中安装。[如何安装文档](how-to-build.md#通过源码包安装) 显示了多个平台中的安装步骤。
-为了快速入门，让我们基于 docker 容器的安装方式进行安装。启动 Apache APISIX
服务，我们可以参照这个镜像文件[repository](https://github.com/apache/apisix-docker) 并切换到
example 文件夹下执行如下命令。
+## 第一步: 安装 Apache APISIX
-如下命令会启动 Apache APISIX 服务并默认在 9080 端口（ https 请求是 9443 端口） 提供 admin API 接口服务
+得益于 Docker，我们可以通过执行以下命令来启动 Apache APISIX 并启用 [Admin API](./admin-api.md)。
```bash
$ git clone https://github.com/apache/apisix-docker.git
@@ -55,204 +85,204 @@ $ cd apisix-docker/example
$ docker-compose -p docker-apisix up -d
```
-第一次下载源代码需要一段时间，之后将非常快。在 docker
[GitHub] [apisix] spacewander merged pull request #3980: docs: update the Getting Started guide in Chinese
spacewander merged pull request #3980: URL: https://github.com/apache/apisix/pull/3980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #4071: request help: Decode secret is not a valid cert, public key: bad base64 decode
spacewander commented on issue #4071: URL: https://github.com/apache/apisix/issues/4071#issuecomment-822100730 @Marco-Zheng Can you provide a pasteable version of the configuration so we can check it by ourselves? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: fix broken links in FAQ (#4053)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 43b6e0d docs: fix broken links in FAQ (#4053)
43b6e0d is described below
commit 43b6e0d1504cab9fe41dd517a7d3770d57e21613
Author: Kishani Kandasamy <53715187+kishanikandas...@users.noreply.github.com>
AuthorDate: Mon Apr 19 06:29:34 2021 +0530
docs: fix broken links in FAQ (#4053)
---
docs/en/latest/FAQ.md | 6 +++---
docs/en/latest/config.json | 4
docs/es/latest/FAQ.md | 2 +-
docs/zh/latest/FAQ.md | 6 +++---
docs/zh/latest/config.json | 4
5 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/docs/en/latest/FAQ.md b/docs/en/latest/FAQ.md
index f64eb58..8242cac 100644
--- a/docs/en/latest/FAQ.md
+++ b/docs/en/latest/FAQ.md
@@ -35,7 +35,7 @@ In addition, APISIX has dynamic routing and hot loading of
plug-ins, which is es
## What's the performance of APISIX?
-One of the goals of APISIX design and development is the highest performance
in the industry. Specific test data can be found
here：[benchmark](https://github.com/apache/apisix/blob/master/benchmark.md)
+One of the goals of APISIX design and development is the highest performance
in the industry. Specific test data can be found here：[benchmark](benchmark.md)
APISIX is the highest performance API gateway with a single-core QPS of
23,000, with an average delay of only 0.6 milliseconds.
@@ -59,7 +59,7 @@ For the configuration center, configuration storage is only
the most basic funct
4. Change Notification
5. High Performance
-See more [etcd
why](https://github.com/etcd-io/etcd/blob/master/Documentation/learning/why.md#comparison-chart).
+See more [etcd
why](https://github.com/etcd-io/website/blob/master/content/docs/next/learning/why.md#comparison-chart).
## Why is it that installing APISIX dependencies with Luarocks causes timeout,
slow or unsuccessful installation?
@@ -318,7 +318,7 @@ The high availability of APISIX can be divided into two
parts:
## Why does the `make deps` command fail in source installation?
-When executing the `make deps` command, an error such as the one shown below
occurs. This is caused by the missing openresty's `openssl` development kit,
you need to install it first. Please refer to the
[install-dependencies.md](install-dependencies.md) document for installation.
+When executing the `make deps` command, an error such as the one shown below
occurs. This is caused by the missing openresty's `openssl` development kit,
you need to install it first. Please refer to the [install
dependencies](install-dependencies.md) document for installation.
```shell
$ make deps
diff --git a/docs/en/latest/config.json b/docs/en/latest/config.json
index 6d9a0cf..599a556 100644
--- a/docs/en/latest/config.json
+++ b/docs/en/latest/config.json
@@ -194,6 +194,10 @@
"id": "benchmark"
},
{
+ "type": "doc",
+ "id": "install-dependencies"
+},
+{
"type": "link",
"label": "CODE_STYLE",
"href": "https://github.com/apache/apisix/blob/master/CODE_STYLE.md";
diff --git a/docs/es/latest/FAQ.md b/docs/es/latest/FAQ.md
index 97c96fd..20ca132 100644
--- a/docs/es/latest/FAQ.md
+++ b/docs/es/latest/FAQ.md
@@ -57,7 +57,7 @@ Para el centro de la configuración, la configuración del
almacenamiento es sol
4. Notificación de cambios
5. Alto rendimiento
-Más información en [Por qué
etcd](https://github.com/etcd-io/etcd/blob/master/Documentation/learning/why.md#comparison-chart).
+Más información en [Por qué
etcd](https://github.com/etcd-io/website/blob/master/content/docs/next/learning/why.md#comparison-chart).
## ¿Por qué sucede que instalar dependencias APISIX con Luarocks provoca
interrupciones por exceso de tiempo (timeout), o instalaciones lentas y
fallidas?
diff --git a/docs/zh/latest/FAQ.md b/docs/zh/latest/FAQ.md
index a3c349e..6e1fd54 100644
--- a/docs/zh/latest/FAQ.md
+++ b/docs/zh/latest/FAQ.md
@@ -34,7 +34,7 @@ APISIX 基于 etcd 来完成配置的保存和同步，而不是 postgres 或者
## APISIX 的性能怎么样？
-APISIX
设计和开发的目标之一，就是业界最高的性能。具体测试数据见这里：[benchmark](https://github.com/apache/apisix/blob/master/docs/en/latest/benchmark.md)
+APISIX 设计和开发的目标之一，就是业界最高的性能。具体测试数据见这里：[benchmark](benchmark.md)
APISIX 是当前性能最好的 API 网关，单核 QPS 达到 2.3 万，平均延时仅有 0.6 毫秒。
@@ -58,7 +58,7 @@ APISIX 是当前性能最好的 API 网关，单核 QPS 达到 2.3 万，平均
4. 变化通知
5. 高性能
-APISIX 需要一个配置中心，上面提到的很多功能是传统关系型数据库和 KV 数据库是无法提供的。与 etcd 同类软件还有
Consul、ZooKeeper 等，更详细比较可以参考这里：[etcd
why](https://etcd.io/docs/v3.4.0/learning/why/)，在将来也许会支持其他配置存储方案。
+APISIX 需要一个配置中心，上面提到的很多功能是传统关系型数据库和 KV 数据库是无法提供的。与 etcd 同类软件还有
Consul、ZooKeeper 等，更详细比较可以参考这里：[etcd
why](https://github.com/etcd-io/website/blob/master/content/docs/next/learning/why.md#comparison-chart)，在将来也许会支持其他配置存储方案。
## 为什么在用 Luarocks 安装 APISIX 依赖
[GitHub] [apisix] spacewander merged pull request #4053: docs: fix broken links in FAQ
spacewander merged pull request #4053: URL: https://github.com/apache/apisix/pull/4053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] spacewander closed issue #310: broken link in Apisix FAQ
spacewander closed issue #310: URL: https://github.com/apache/apisix-website/issues/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4069: feat: optimize skywalking instancename
spacewander commented on a change in pull request #4069: URL: https://github.com/apache/apisix/pull/4069#discussion_r615488366 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -90,9 +90,9 @@ We can set the endpoint by specified the configuration in `conf/config.yaml`. | Name | Type | Default | Description | | | -- | | | | service_name | string | "APISIX" | service name for skywalking reporter | -|service_instance_name|string|"APISIX Instance Name" | service instance name for skywalking reporter | -| endpoint_addr| string | "http://127.0.0.1:12800"; | the http endpoint of Skywalking, for example: http://127.0.0.1:12800 | -| report_interval| integer | use the value in the skywalking client library | the report interval, in seconds | +| service_instance_name | string |"APISIX Instance Name" | service instance name for skywalking reporter， set it to `$hostname` to get local hostname directly.| Review comment: ```suggestion | service_instance_name | string |"APISIX Instance Name" | service instance name for skywalking reporter. If you want to use the machine's hostname directly, set it to `$hostname`.| ``` A little tweak for the doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (c35203a -> 3ed0b07)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from c35203a chore: keep using English as comments & update plugin type (#1785) add 3ed0b07 fix: upstream host form warning message (#1782) No new revisions were added by this update. Summary of changes: web/src/components/Upstream/components/Nodes.tsx | 3 +++ web/src/pages/Upstream/locales/en-US.ts | 1 + web/src/pages/Upstream/locales/zh-CN.ts | 1 + 3 files changed, 5 insertions(+)
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1782: fix: upstream host form warning message
juzhiyuan merged pull request #1782: URL: https://github.com/apache/apisix-dashboard/pull/1782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #73: kubectl plugin support
tokers commented on issue #73: URL: https://github.com/apache/apisix-ingress-controller/issues/73#issuecomment-822104022 @fhuzero I will re-assign this issue for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj opened a new pull request #386: feat: add event & status for ApisixRoute v2
gxthrj opened a new pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3883: feat: add 5xx error page
tokers commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r615490453
##
File path: t/error_handler/error_handler.t
##
@@ -0,0 +1,214 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: set route with serverless-post-function plugin
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"serverless-post-function": {
+"functions" : ["return function() if
ngx.var.http_x_test_status ~= nil
then;ngx.exit(tonumber(ngx.var.http_x_test_status));end;end"]
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}]]
+)
+
+if code >= 300 then
+ngx.sleep(100)
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 2: test apisix with internal error code 500
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 500
+--- error_code: 500
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 3: test apisix with internal error code 502
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 502
+--- error_code: 502
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 4: test apisix with internal error code 503
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 503
+--- error_code: 503
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 5: test apisix with internal error code 504
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 504
+--- error_code: 504
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 6: test apisix with internal error code 400
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 400
+--- error_code: 400
+--- response_body
+
+400 Bad Request
+
+400 Bad Request
+ https://apisix.apache.org/";>APISIX
+
+
+
+
+
+=== TEST 7: test apisix with internal error code 401
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 401
+--- error_code: 401
+--- response_body
+
+401 Unauthorized
+
+401 Unauthorized
+ https://apisix.apache.org/";>APISIX
+
+
+
+
+
+=== TEST 8: test apisix with internal error code 403
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 403
+--- error_code: 403
+--- response_body
+
+403 Forbidden
+
+403 Forbidden
+ https://apisix.apache.org/";>APISIX
+
+
+
+
+
+=== TEST 9: test apisix with internal error code 404
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 404
+--- error_code: 404
+--- response_body
+
+404 Not Found
+
+404 Not Found
+ https://apisix.apache.org/";>APISIX
+
+
+
+
+
+=== TEST 10: test apisix with internal error code 405
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 405
+--- error_code: 405
+--- response_body
+
+405 Not Allowed
+
+405 Not Allowed
+ https://apisix.apache.org/";>APISIX
+
+
+
+
+
+=== TEST 12: test apisix with upstream error code 400
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 400
+--- error_code: 400
+--- response_body
+upstream status: 400
+
+
+
+=== TEST 11: test apisix with upstream error code 500
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 500
+--- error_code: 500
+--- response_body
+upstream status: 500
Review comment:
Please check the editor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #385: WIP: fix wrong group version for extensions/v1beta1.Ingress
tokers commented on pull request #385: URL: https://github.com/apache/apisix-ingress-controller/pull/385#issuecomment-822105520 @vincenthcui Hi, is this PR still in the progress? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #383: feat: apisixtls schema
gxthrj commented on pull request #383: URL: https://github.com/apache/apisix-ingress-controller/pull/383#issuecomment-822105772 Need some test-case for jsonschema -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #383: feat: apisixtls schema
tokers commented on pull request #383: URL: https://github.com/apache/apisix-ingress-controller/pull/383#issuecomment-822106406 @gxthrj e2e cases about SSL already test it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #384: chore: remove pkg/seven
tokers merged pull request #384: URL: https://github.com/apache/apisix-ingress-controller/pull/384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated (561708f -> f26ee93)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git.
from 561708f test: add e2e test cases for referer-restriction plugin (#375)
add f26ee93 chore: remove pkg/seven (#384)
No new revisions were added by this update.
Summary of changes:
pkg/apisix/resource_test.go| 1 +
pkg/kube/translation/annotations.go| 44 ++--
.../{annotations.go => annotations/cors.go}| 61 +--
.../{util_test.go => annotations/iprestriction.go} | 33 +++---
pkg/seven/apisix/plugins.go| 115 -
5 files changed, 46 insertions(+), 208 deletions(-)
copy pkg/kube/translation/{annotations.go => annotations/cors.go} (51%)
copy pkg/kube/translation/{util_test.go => annotations/iprestriction.go} (59%)
delete mode 100644 pkg/seven/apisix/plugins.go
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #383: feat: apisixtls schema
gxthrj commented on pull request #383: URL: https://github.com/apache/apisix-ingress-controller/pull/383#issuecomment-822106664 > @gxthrj e2e cases about SSL already test it. But no error case covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #383: feat: apisixtls schema
tokers commented on pull request #383: URL: https://github.com/apache/apisix-ingress-controller/pull/383#issuecomment-822107158 > > @gxthrj e2e cases about SSL already test it. > > But no error case covered. That'd will be a huge workload, as we also lacks the cases for ApisixRoute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4074: request help: How to rewrite the data of backend server response?
tokers commented on issue #4074: URL: https://github.com/apache/apisix/issues/4074#issuecomment-822107779 > @Firstsawyou I refer to this plugin to write a new plugin. there are tow defferences: > 1、 The ‘body' which is not static, is from the backend service; > 2、The body content is very large. function of body_filter executed many times; > I try to concatenate the chunck of every body_filter function received from backend,but can't not correct serialize to integrated json document. I took a glance of your custom `_M.body_filter`, where is your `backend_content` variable? Also, when the response body is large, the string concatenation is inefficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
