[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
netlify[bot] edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614 Deploy preview for *apisix-dashboard* ready! Built with commit ac71609b68479cd7ba79bd880e26e3c10e5e1895 https://deploy-preview-1667--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
netlify[bot] edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3883: feat: add 5xx error page
tokers commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r615554598
##
File path: t/error_handler/error_handler.t
##
@@ -0,0 +1,214 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: set route with serverless-post-function plugin
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"serverless-post-function": {
+"functions" : ["return function() if
ngx.var.http_x_test_status ~= nil
then;ngx.exit(tonumber(ngx.var.http_x_test_status));end;end"]
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}]]
+)
+
+if code >= 300 then
+ngx.sleep(100)
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 2: test apisix with internal error code 500
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 500
+--- error_code: 500
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 3: test apisix with internal error code 502
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 502
+--- error_code: 502
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 4: test apisix with internal error code 503
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 503
+--- error_code: 503
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 5: test apisix with internal error code 504
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 504
+--- error_code: 504
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 6: test apisix with internal error code 400
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 400
+--- error_code: 400
+--- response_body
+
+400 Bad Request
+
+400 Bad Request
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 7: test apisix with internal error code 401
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 401
+--- error_code: 401
+--- response_body
+
+401 Unauthorized
+
+401 Unauthorized
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 8: test apisix with internal error code 403
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 403
+--- error_code: 403
+--- response_body
+
+403 Forbidden
+
+403 Forbidden
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 9: test apisix with internal error code 404
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 404
+--- error_code: 404
+--- response_body
+
+404 Not Found
+
+404 Not Found
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 10: test apisix with internal error code 405
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 405
+--- error_code: 405
+--- response_body
+
+405 Not Allowed
+
+405 Not Allowed
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 12: test apisix with upstream error code 400
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 400
+--- error_code: 400
+--- response_body
+upstream status: 400
+
+
+
+=== TEST 11: test apisix with upstream error code 500
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 500
+--- error_code: 500
+--- response_body
+upstream status: 500
Review comment:
@moonming We should keep the upstream 4xx/5xx pages intact by default,
but we may add a switch like:
```
proxy_intercept_errors on | off;
```
This is a standard Nginx directive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[GitHub] [apisix] starsz commented on a change in pull request #3883: feat: add 5xx error page
starsz commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r615554190
##
File path: t/error_handler/error_handler.t
##
@@ -0,0 +1,214 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: set route with serverless-post-function plugin
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"serverless-post-function": {
+"functions" : ["return function() if
ngx.var.http_x_test_status ~= nil
then;ngx.exit(tonumber(ngx.var.http_x_test_status));end;end"]
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}]]
+)
+
+if code >= 300 then
+ngx.sleep(100)
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 2: test apisix with internal error code 500
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 500
+--- error_code: 500
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 3: test apisix with internal error code 502
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 502
+--- error_code: 502
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 4: test apisix with internal error code 503
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 503
+--- error_code: 503
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 5: test apisix with internal error code 504
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 504
+--- error_code: 504
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 6: test apisix with internal error code 400
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 400
+--- error_code: 400
+--- response_body
+
+400 Bad Request
+
+400 Bad Request
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 7: test apisix with internal error code 401
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 401
+--- error_code: 401
+--- response_body
+
+401 Unauthorized
+
+401 Unauthorized
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 8: test apisix with internal error code 403
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 403
+--- error_code: 403
+--- response_body
+
+403 Forbidden
+
+403 Forbidden
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 9: test apisix with internal error code 404
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 404
+--- error_code: 404
+--- response_body
+
+404 Not Found
+
+404 Not Found
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 10: test apisix with internal error code 405
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 405
+--- error_code: 405
+--- response_body
+
+405 Not Allowed
+
+405 Not Allowed
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 12: test apisix with upstream error code 400
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 400
+--- error_code: 400
+--- response_body
+upstream status: 400
+
+
+
+=== TEST 11: test apisix with upstream error code 500
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 500
+--- error_code: 500
+--- response_body
+upstream status: 500
Review comment:
In some situations. The info in the response body is useful. The user
will need the upstream error info.
cc @tokers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
[GitHub] [apisix] izayoi-akira removed a comment on issue #4078: request help:
izayoi-akira removed a comment on issue #4078: URL: https://github.com/apache/apisix/issues/4078#issuecomment-822182578 Access Restrictions is not what I want, I want upstream to know witch consumer is accessing it. for example: There are two consumers: consumers1 and consumers2,they got token1 and token2 with `/apisix/plugin/jwt/sign`. Then they both access the upstream api: `xxx.com/articel/add`,now xxx.com wants to know if it was consumers1 or consumers2 that access it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] izayoi-akira commented on issue #4078: request help:
izayoi-akira commented on issue #4078: URL: https://github.com/apache/apisix/issues/4078#issuecomment-822183015 > > 如何让apisix或者上游知道是哪个消费者访问的？ > > According to the existing configuration in the `consumer`, when you access authentication, it will be authenticated with the information configured in the consumer according to the token you use. > > You can refer to the consumer-restriction plugin, through which you can do corresponding access restrictions. Access Restrictions is not what I want, I want upstream to know witch consumer is accessing it. for example: There are two consumers: consumers1 and consumers2,they got token1 and token2 with /apisix/plugin/jwt/sign. Then they both access the upstream api: xxx.com/articel/add,now xxx.com wants to know if it was consumers1 or consumers2 that access it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1667: feat: run manager-api as a systemd daemon/service
codecov-commenter edited a comment on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1667](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ac71609) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bec8f1b) will **decrease** coverage by `1.27%`. > The diff coverage is `54.44%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1667 +/- ## == - Coverage 72.48% 71.20% -1.28% == Files 133 48 -85 Lines5728 3185-2543 Branches 6660 -666 == - Hits 4152 2268-1884 + Misses 1332 663 -669 - Partials 244 254 +10 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.91% <54.44%> (+<0.01%)` | :arrow_up: | | backend-e2e-test-ginkgo | `49.04% <54.44%> (+1.00%)` | :arrow_up: | | backend-unit-test | `52.41% <ø> (+0.59%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/cmd/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zZXJ2aWNlLmdv) | `24.13% <24.13%> (ø)` | | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `63.21% <68.85%> (+3.75%)` | :arrow_up: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `91.07% <0.00%> (-0.42%)` | :arrow_down: | | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | | | [web/src/pages/Upstream/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [web/src/pages/Upstream/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9DcmVhdGUudHN4) | | | | [web/src/pages/Route/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9DcmVhdGUudHN4) | | | |
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1667: feat: run manager-api as a systemd daemon/service
bisakhmondal commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822182633 > don't see the update? @bisakhmondal Updated :) Fully tested on Linux (ubuntu 20.04). I don't have macOS or windows. Please let me know if it is working or not when you have some time.  cc @nic-chen, @membphis, @tokers, @starsz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] izayoi-akira commented on issue #4078: request help:
izayoi-akira commented on issue #4078: URL: https://github.com/apache/apisix/issues/4078#issuecomment-822182578 Access Restrictions is not what I want, I want upstream to know witch consumer is accessing it. for example: There are two consumers: consumers1 and consumers2,they got token1 and token2 with `/apisix/plugin/jwt/sign`. Then they both access the upstream api: `xxx.com/articel/add`,now xxx.com wants to know if it was consumers1 or consumers2 that access it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #3883: feat: add 5xx error page
tokers commented on pull request #3883: URL: https://github.com/apache/apisix/pull/3883#issuecomment-822181613 I have no other questions but one: 1. Make sure it won't overwrite the 4xx and 5xx pages generated by upstream. 2. For those 4xx and 5xx codes generated by APISIX, we may need more information like "IP is forbidden" (ip-restriction plugin). For `1`, we may have a switch to control whether or not to override the upstream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1667: feat: run manager-api as a systemd daemon/service
codecov-commenter commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822181391 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1667](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ac71609) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bec8f1bf020f99a12ac6e8137d624a54b37c18d4?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (bec8f1b) will **decrease** coverage by `20.07%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1667 +/- ## === - Coverage 72.48% 52.41% -20.08% === Files 133 38 -95 Lines5728 2675 -3053 Branches 6660 -666 === - Hits 4152 1402 -2750 + Misses 1332 1085 -247 + Partials 244 188 -56 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.41% <ø> (+0.59%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1667?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1667/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1667: feat: run manager-api as a systemd daemon/service
netlify[bot] commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822179614 Deploy preview for *apisix-dashboard* processing. Building with commit ca1bfd347db42a6dbc074694e145cb8ae580e846 https://app.netlify.com/sites/apisix-dashboard/deploys/607d16097b6e2b000823c07a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: feat: apisixtls schema (#383)
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 4164486 feat: apisixtls schema (#383) 4164486 is described below commit 416448679e5bfed0d53646f2c57d9dce4daef993 Author: Alex Zhang AuthorDate: Mon Apr 19 13:22:22 2021 +0800 feat: apisixtls schema (#383) --- samples/deploy/crd/v1beta1/ApisixRoute.yaml | 4 +-- samples/deploy/crd/v1beta1/ApisixTls.yaml | 42 + 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/samples/deploy/crd/v1beta1/ApisixRoute.yaml b/samples/deploy/crd/v1beta1/ApisixRoute.yaml index 5ab8ccd..2dbda5f 100644 --- a/samples/deploy/crd/v1beta1/ApisixRoute.yaml +++ b/samples/deploy/crd/v1beta1/ApisixRoute.yaml @@ -21,10 +21,10 @@ metadata: name: apisixroutes.apisix.apache.org spec: additionalPrinterColumns: -- JSONPath: .spec.http[].match.hosts[] +- JSONPath: .spec.http[].match.hosts name: Hosts type: string -- JSONPath: .spec.http[].match.paths[] +- JSONPath: .spec.http[].match.paths name: URIs type: string - JSONPath: .spec.http[].match.backends[].serviceName diff --git a/samples/deploy/crd/v1beta1/ApisixTls.yaml b/samples/deploy/crd/v1beta1/ApisixTls.yaml index 9a828dd..45dc774 100644 --- a/samples/deploy/crd/v1beta1/ApisixTls.yaml +++ b/samples/deploy/crd/v1beta1/ApisixTls.yaml @@ -20,6 +20,19 @@ kind: CustomResourceDefinition metadata: name: apisixtlses.apisix.apache.org spec: + additionalPrinterColumns: +- JSONPath: .spec.hosts + name: SNIs + type: string +- JSONPath: .spec.secret.name + name: Secret Name + type: string +- JSONPath: .spec.secret.namespace + name: Secret Namespace + type: string +- JSONPath: .metadata.creationTimestamp + name: Age + type: date group: apisix.apache.org versions: - name: v1 @@ -32,3 +45,32 @@ spec: kind: ApisixTls shortNames: - atls + preserveUnknownFields: false + validation: +openAPIV3Schema: + type: object + properties: +spec: + type: object + required: +- hosts +- secret + properties: +hosts: + type: array + minItems: 1 + items: +type: string +pattern: "^\\*?[0-9a-zA-Z-.]+$" +secret: + type: object + required: +- name +- namespace + properties: +name: + type: string + minLength: 1 +namespace: + type: string + minLength: 1
[GitHub] [apisix-ingress-controller] tokers merged pull request #383: feat: apisixtls schema
tokers merged pull request #383: URL: https://github.com/apache/apisix-ingress-controller/pull/383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1773: add missing fields for limit-count plugin (redis cluster)
iamayushdas commented on issue #1773: URL: https://github.com/apache/apisix-dashboard/issues/1773#issuecomment-822170645 @juzhiyuan i think limit-count doc matches the json schema? if i am wrong could you please enlight me up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1787: update remark in UpstreamForm when creating Service
iamayushdas commented on issue #1787: URL: https://github.com/apache/apisix-dashboard/issues/1787#issuecomment-822165078 As far as i got we have to remove this 仅在绑定服务时可用 ? is it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1391: feat: embed all generated web assets into api binary
juzhiyuan commented on issue #1391: URL: https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-822159256 ok then let's cc @starsz @nic-chen @imjoey @liuxiran @membphis @LiteSun @bzp2010 @ShiningRush -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4077: passive healthcheck not working after configuration changing
Firstsawyou commented on issue #4077: URL: https://github.com/apache/apisix/issues/4077#issuecomment-822155627 You should provide the corresponding health check configuration information so that we can check it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4078: request help:
Firstsawyou commented on issue #4078: URL: https://github.com/apache/apisix/issues/4078#issuecomment-822154027 > 如何让apisix或者上游知道是哪个消费者访问的？ According to the existing configuration in the `consumer`, when you access authentication, it will be authenticated with the information configured in the consumer according to the token you use. You can refer to the consumer-restriction plugin, through which you can do corresponding access restrictions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1767](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (368163e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/5d9cd3fca2ecca51ff62b1e3623ae3159673b2bc?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5d9cd3f) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1767 +/- ## == + Coverage 71.81% 71.85% +0.03% == Files 172 172 Lines6064 6064 Branches 703 703 == + Hits 4355 4357 +2 + Misses 1466 1463 -3 - Partials 243 244 +1 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.39% <ø> (+0.22%)` | :arrow_up: | | backend-e2e-test-ginkgo | `48.83% <ø> (-0.23%)` | :arrow_down: | | backend-unit-test | `52.41% <ø> (ø)` | | | frontend-e2e-test | `72.06% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `66.19% <ø> (-2.82%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `86.82% <0.00%> (-1.20%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `49.09% <0.00%> (+1.81%)` | :arrow_up: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `74.76% <0.00%> (+3.73%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [5d9cd3f...368163e](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). --
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1788: feat: embed assets in api binary
codecov-commenter edited a comment on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-822144222 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1788?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1788](https://codecov.io/gh/apache/apisix-dashboard/pull/1788?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (dbf071b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1d2bc545c6e081f9ce0270ae12d61eecdaadab0e?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1d2bc54) will **decrease** coverage by `9.46%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1788?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1788 +/- ## == - Coverage 72.13% 62.66% -9.47% == Files 132 163 +31 Lines5721 5596 -125 Branches 649 703 +54 == - Hits 4127 3507 -620 - Misses 1350 1901 +551 + Partials 244 188 -56 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.41% <ø> (+0.11%)` | :arrow_up: | | frontend-e2e-test | `72.06% <ø> (-0.94%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1788?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1667: feat: run manager-api as a systemd daemon/service
nic-chen commented on pull request #1667: URL: https://github.com/apache/apisix-dashboard/pull/1667#issuecomment-822149835 don't see the update? @bisakhmondal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1778: excuse,how to do the fuzzy search of routing in the apisix-dashboard
nic-chen commented on issue #1778: URL: https://github.com/apache/apisix-dashboard/issues/1778#issuecomment-822147352 hi @StretchV The Manager API loops to match the values in cache (from ETCD), but it is not a regular match. For the detail, please see: https://github.com/apache/apisix-dashboard/blob/master/api/internal/core/store/store.go#L187-L195 https://github.com/apache/apisix-dashboard/blob/master/api/internal/handler/route/route.go#L222-L239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1788: feat: embed assets in api binary
bisakhmondal commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-822147200 As `go:embed` and related package `io/fs` has been introduced in stable go version 1.16, we need to update the CI in the master branch. We can cherry-pick the CI update commit from this PR. cc @nic-chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* ready! Built with commit 368163e987ea3532f1d381a9372b73d868962325 https://deploy-preview-1767--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
codecov-commenter edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-821961393 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1767](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (368163e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/5d9cd3fca2ecca51ff62b1e3623ae3159673b2bc?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (5d9cd3f) will **decrease** coverage by `19.40%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1767 +/- ## === - Coverage 71.81% 52.41% -19.41% === Files 172 38 -134 Lines6064 2675 -3389 Branches 7030 -703 === - Hits 4355 1402 -2953 + Misses 1466 1085 -381 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.41% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1767?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1767/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1788: feat: embed assets in api binary
netlify[bot] edited a comment on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-822143589 Deploy preview for *apisix-dashboard* ready! Built with commit dbf071b769b9baa17ae89664016f3f52eee2068c https://deploy-preview-1788--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Marco-Zheng commented on issue #4071: request help: Decode secret is not a valid cert, public key: bad base64 decode
Marco-Zheng commented on issue #4071:
URL: https://github.com/apache/apisix/issues/4071#issuecomment-822145739
> > public key
> > ```
> > ssh-rsa
B3NzaC1yc2EDAQABAAABAQDCatx836Ey9zMbM5DBBbdnMWAm8TN2fGOTpKGqaak/l8EzyCFzMyCuSMk6NMjssgehDukOlef9eJ73JJopsesjlMa8PDSrFhsdlMtbXkNBX0QESi9a87JPBC559vyXzy8T5pLpTXYsQYZWehkYkdXU7DQOV8LN4qZF51+yo3hYiMHpKYyrJ3Bntr22wCToYqljAc2rdah5PQ/2nuXIy/jJCuTYmv7lKXVEGoW0YoOTzfaKhBsnET5zMbPiwbA40huBxJ1Z89PUbqPplm8vhRfanYSDlgTZ2+aj8yo62I/lgmcurK1REpq72nIkAStoPMTs2agLGrgIodPDOIf+V9uB
root@VM-50-173-centos
> > ```
>
> It is not possible to use such a public key format, we need to use the
`PEM` format. You can convert to a public key in PEM format with the following
command:
>
> ```
> openssl rsa -in ${private}.key -pubout -outform PEM -out ${public}.key.pub
> ```
It works, thanks a lot, i'll close the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Marco-Zheng closed issue #4071: request help: Decode secret is not a valid cert, public key: bad base64 decode
Marco-Zheng closed issue #4071: URL: https://github.com/apache/apisix/issues/4071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] izayoi-akira commented on issue #4078: request help:
izayoi-akira commented on issue #4078: URL: https://github.com/apache/apisix/issues/4078#issuecomment-822144824 How can I get the consumer message which requeset the upstream by upstream or apisix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1788: feat: embed assets in api binary
codecov-commenter commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-822144222 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1788?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1788](https://codecov.io/gh/apache/apisix-dashboard/pull/1788?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (dbf071b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1d2bc545c6e081f9ce0270ae12d61eecdaadab0e?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1d2bc54) will **decrease** coverage by `19.72%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1788?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1788 +/- ## === - Coverage 72.13% 52.41% -19.73% === Files 132 38 -94 Lines5721 2675 -3046 Branches 6490 -649 === - Hits 4127 1402 -2725 + Misses 1350 1085 -265 + Partials 244 188 -56 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.41% <ø> (+0.11%)` | :arrow_up: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1788?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1788/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* processing. Building with commit 368163e987ea3532f1d381a9372b73d868962325 https://app.netlify.com/sites/apisix-dashboard/deploys/607cfb9f9a215c0007fc1d56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1788: feat: embed assets in api binary
netlify[bot] commented on pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788#issuecomment-822143589 Deploy preview for *apisix-dashboard* processing. Building with commit dbf071b769b9baa17ae89664016f3f52eee2068c https://app.netlify.com/sites/apisix-dashboard/deploys/607cfb2800cb380007526a5b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1788: feat: embed assets in api binary
bisakhmondal opened a new pull request #1788: URL: https://github.com/apache/apisix-dashboard/pull/1788 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** [Comment #1391 ](https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-821702445) **Related issues** resolve #1391 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] izayoi-akira opened a new issue #4078: request help:
izayoi-akira opened a new issue #4078: URL: https://github.com/apache/apisix/issues/4078 ### Issue description 关于jwt-auth，`/apisix/plugin/jwt/sign`可以获取token，并且访问成功 但是有个需求，是如何让apisix或者上游知道是哪个消费者访问的？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #388: test: add e2e test cases for ip-restriction plugin
codecov-commenter commented on pull request #388: URL: https://github.com/apache/apisix-ingress-controller/pull/388#issuecomment-822142124 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/388?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > :exclamation: No coverage uploaded for pull request base (`master@f26ee93`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#section-missing-base-commit). > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/388?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ## master #388 +/- ## = Coverage ? 39.98% = Files ? 38 Lines ? 3094 Branches ?0 = Hits ? 1237 Misses? 1712 Partials ? 145 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/388?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/388?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [f26ee93...93fa59e](https://codecov.io/gh/apache/apisix-ingress-controller/pull/388?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4071: request help: Decode secret is not a valid cert, public key: bad base64 decode
Firstsawyou commented on issue #4071:
URL: https://github.com/apache/apisix/issues/4071#issuecomment-822140033
> public key
>
> ```
> ssh-rsa
B3NzaC1yc2EDAQABAAABAQDCatx836Ey9zMbM5DBBbdnMWAm8TN2fGOTpKGqaak/l8EzyCFzMyCuSMk6NMjssgehDukOlef9eJ73JJopsesjlMa8PDSrFhsdlMtbXkNBX0QESi9a87JPBC559vyXzy8T5pLpTXYsQYZWehkYkdXU7DQOV8LN4qZF51+yo3hYiMHpKYyrJ3Bntr22wCToYqljAc2rdah5PQ/2nuXIy/jJCuTYmv7lKXVEGoW0YoOTzfaKhBsnET5zMbPiwbA40huBxJ1Z89PUbqPplm8vhRfanYSDlgTZ2+aj8yo62I/lgmcurK1REpq72nIkAStoPMTs2agLGrgIodPDOIf+V9uB
root@VM-50-173-centos
> ```
It is not possible to use such a public key format, we need to use the `PEM`
format. You can convert to a public key in PEM format with the following
command:
```
openssl rsa -in ${private}.key -pubout -outform PEM -out ${public}.key.pub
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Ben0625 opened a new issue #4077: passive healthcheck not working after configuration changing
Ben0625 opened a new issue #4077:
URL: https://github.com/apache/apisix/issues/4077
### Issue description
When both active and passive configuration are updated from only active
configuration, the http statuses of passive become an empty table which causes
passive healthcheck not working.
### Environment
* apisix version: 2.0
* OS: 3.10.0-693.el7.x86_64
* OpenResty version: openresty/1.17.8.2
* etcd version: 3.4.13
* apisix-dashboard version: 2.0
### Minimal test code / Steps to reproduce the issue
1. Set a route with two upstreams(/test.do) and healthcheck active
configuration(/check.do).
2. Send a request to trigger creating new checker.
3. Update this route only by changing healthcheck configuration to both
active and passive. Let one of the upstream return 500 code to act like a
unnormal node. Send some requests, but the unnormal node cannot be set to be
unhealthy even reaching the passive.unhealthy.http_failures.
### What's the actual result?
I prints some debug info inside this function:
https://github.com/Kong/lua-resty-healthcheck/blob/master/lib/resty/healthcheck.lua#L1372
I prints out the "defaults" table at line 1443.
After doing Step 2, the type of
defaults.checks.passive.unhealthy.http_statuses changes from array to dict!
-
defaults.checks.passive.unhealthy.http_statuses before to_set() function:
{
1 = 429,
2 = 500,
3 = 503,
}
defaults.checks.passive.unhealthy.http_statuses after to_set() function:
{
429 = true,
500 = true,
503 = true,
}
-
It seems that to_set() changes the "self" object, result in changing
"defaults" as well.
After doing Step 3, defaults.checks.passive.unhealthy.http_statuses becomes
an empty table after to_set() function.
### What's the expected result?
In my opinion, the "defaults" object should not be changed. Maybe there's
some problem with fill_in_settings() function at line 1377. Or am I doing
something wrong during these operations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[apisix-dashboard] branch master updated: change: remove ID of consumer (#1745)
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 5d9cd3f change: remove ID of consumer (#1745)
5d9cd3f is described below
commit 5d9cd3fca2ecca51ff62b1e3623ae3159673b2bc
Author: nic-chen <33000667+nic-c...@users.noreply.github.com>
AuthorDate: Mon Apr 19 11:21:25 2021 +0800
change: remove ID of consumer (#1745)
---
.github/workflows/backend-e2e-test.yml | 1 +
api/conf/schema.json | 242 +++--
api/internal/core/entity/entity.go | 11 +-
api/internal/core/store/store_mock.go | 10 +
api/internal/core/store/validate_test.go | 43 +---
api/internal/handler/consumer/consumer.go | 31 ++-
api/internal/handler/consumer/consumer_test.go | 46 ++--
api/internal/handler/label/label_test.go | 4 -
api/test/docker/apisix_config.yaml | 2 +-
api/test/docker/apisix_config2.yaml| 2 +-
api/test/docker/docker-compose.yaml| 4 +-
api/test/e2enew/schema/schema_test.go | 2 +-
web/cypress/fixtures/plugin-dataset.json | 4 +-
.../create-upstream-with-cors-form.spec.js | 10 +-
web/src/components/Plugin/PluginDetail.tsx | 4 +-
15 files changed, 213 insertions(+), 203 deletions(-)
diff --git a/.github/workflows/backend-e2e-test.yml
b/.github/workflows/backend-e2e-test.yml
index 6f226ad..2914e9b 100644
--- a/.github/workflows/backend-e2e-test.yml
+++ b/.github/workflows/backend-e2e-test.yml
@@ -46,6 +46,7 @@ jobs:
docker-compose up -d
sleep 5
docker logs docker_managerapi_1
+ docker logs docker_apisix_1
- name: run test
working-directory: ./api/test/e2e
diff --git a/api/conf/schema.json b/api/conf/schema.json
index e69c57a..ff58ff4 100644
--- a/api/conf/schema.json
+++ b/api/conf/schema.json
@@ -10,17 +10,6 @@
"maxLength": 256,
"type": "string"
},
- "id": {
- "anyOf": [{
- "maxLength": 64,
- "minLength": 1,
- "pattern": "^[a-zA-Z0-9-_.]+$",
- "type": "string"
- }, {
- "minimum": 1,
- "type": "integer"
- }]
- },
"labels": {
"description": "key/value pairs to
specify attributes",
"maxProperties": 16,
@@ -147,6 +136,27 @@
"maxLength": 1048576,
"minLength": 1,
"type": "string"
+ },
+ "create_time": {
+ "type": "integer"
+ },
+ "desc": {
+ "maxLength": 256,
+ "type": "string"
+ },
+ "id": {
+ "anyOf": [{
+ "maxLength": 64,
+ "minLength": 1,
+ "pattern": "^[a-zA-Z0-9-_.]+$",
+ "type": "string"
+ }, {
+ "minimum": 1,
+ "type": "integer"
+ }]
+ },
+ "update_time": {
+ "type": "integer"
}
},
"required": ["content"],
@@ -595,10 +605,6 @@
"description":
"discovery type",
"type": "string"
},
- "enable_websocket": {
- "description": "enable
websocket for request",
- "type": "boolean"
-
[GitHub] [apisix-dashboard] nic-chen merged pull request #1745: change: remove ID of consumer
nic-chen merged pull request #1745: URL: https://github.com/apache/apisix-dashboard/pull/1745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #1742: change: remove ID of consumer
nic-chen closed issue #1742: URL: https://github.com/apache/apisix-dashboard/issues/1742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1767: change: remove listen.host from api/conf/conf.yaml
nic-chen commented on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-822138820 > Emmm.Need to fix the link error. @nic-chen sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on pull request #1767: change: remove listen.host from api/conf/conf.yaml
starsz commented on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-822137855 Emmm.Need to fix the link error. @nic-chen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4071: request help: Decode secret is not a valid cert, public key: bad base64 decode
Firstsawyou commented on issue #4071: URL: https://github.com/apache/apisix/issues/4071#issuecomment-822137317 The format of the key you generated is wrong, you should use the key in `PEM` format. like this: public key: ``` -BEGIN PUBLIC KEY- MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC7PFEV21eMlqyw6uXUOGpuV+6f 2gaEnT6tTf5lMKZTUEJceLPK50dawo/c+5b9YeX7iue8XSGAQmksKu/URys9gaZh G4OZeciQ4aP3na+DiUjIV+950chEAKS1u655GZzpfSdUx+LfJGJ2guOJIPnQpq6c dwJIjlMWBHG1/vgV4QIDAQAB -END PUBLIC KEY- ``` private key: ``` -BEGIN RSA PRIVATE KEY- MIICXgIBAAKBgQC7PFEV21eMlqyw6uXUOGpuV+6f2gaEnT6tTf5lMKZTUEJceLPK 50dawo/c+5b9YeX7iue8XSGAQmksKu/URys9gaZhG4OZeciQ4aP3na+DiUjIV+95 0chEAKS1u655GZzpfSdUx+LfJGJ2guOJIPnQpq6cdwJIjlMWBHG1/vgV4QIDAQAB AoGANJohfa59zjWWlq2nnBOtcwqpM6ehJSi4LyA2VF9ymv11Z11RxbNsTIdUu5TD OrSCVEUWDclsXAhMW+hEMLM95jH9V3CUyPBoZ6jHdugrSJLrN/kz1bPYMNIyX2fr an1ttJfZgFJXN4Z0E6AZ5paQ4z08X3ZH5W+LJzEZZXg0E7ECQQD0iR0VvSA0gAJ0 pKlaHSbqosnMs6a733msFnQyF7NWi2wK8+M82IfTLxe+cdqgiNBb+A5n6tR5NBj/ fFdhGd83AkEAxAN+5KAFoOt0U1Ce20LulLIwiWap/Wl57p95gsO7dhfblQsCJYw7 4BVdQ2TaQ9PONUAxz5ZROBhjPOZfijbPpwJBALC/8p/l5cNMy3mYEzipXZm3NHmb WObu7rkuOaqDawMhH2UDR7qRIAvLPDRRgx8KBOCU+YSvPgilWXRBYb8zvh0CQQCf n6EkmdQ7mcMfXhYfxL/5w6qXGk3wmoa7do9DmBX/M6qUE2TqIutXrs5GZckBV2kk IGTwAh+eKO4X2BuRuNUdAkEAplAcYB68IyII2VxDeYSgKGJi9iNWaaGjVwXVt9Jq uJRavhUkHgxdTsw4ViZoyoITyKJe0jhE2noygPUPF9m9IA== -END RSA PRIVATE KEY- ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1745: change: remove ID of consumer
starsz commented on a change in pull request #1745: URL: https://github.com/apache/apisix-dashboard/pull/1745#discussion_r615517958 ## File path: api/test/docker/apisix_config2.yaml ## @@ -22,7 +22,7 @@ etcd: - "http://172.16.238.10:2379; - "http://172.16.238.11:2379; - "http://172.16.238.12:2379; - resync_delay: 0.1 # sync data from etcd quickly for e2e test + resync_delay: 0 # sync data from etcd quickly for e2e test Review comment: Got it.Thank you for your explanation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1767: change: remove listen.host from api/conf/conf.yaml
nic-chen commented on a change in pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#discussion_r615517798 ## File path: api/conf/conf.yaml ## @@ -17,10 +17,15 @@ conf: listen: -host: 127.0.0.1 # `manager api` listening ip or host name port: 9000 # `manager api` listening port allow_list: # If we don't set any IP list, then any IP access is allowed by default. - 127.0.0.0/24 +- 10.0.0.0/8 Review comment: updated. ## File path: api/conf/conf.yaml ## @@ -17,10 +17,15 @@ conf: listen: -host: 127.0.0.1 # `manager api` listening ip or host name Review comment: updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1745: change: remove ID of consumer
nic-chen commented on a change in pull request #1745: URL: https://github.com/apache/apisix-dashboard/pull/1745#discussion_r615517522 ## File path: api/test/docker/apisix_config2.yaml ## @@ -22,7 +22,7 @@ etcd: - "http://172.16.238.10:2379; - "http://172.16.238.11:2379; - "http://172.16.238.12:2379; - resync_delay: 0.1 # sync data from etcd quickly for e2e test + resync_delay: 0 # sync data from etcd quickly for e2e test Review comment: ping @starsz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on pull request #161: docs: Replace `docker build` command with `make`
Yiyiyimu commented on pull request #161: URL: https://github.com/apache/apisix-docker/pull/161#issuecomment-822135401 Thanks for the fix!! @iamayushdas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu closed issue #147: Replace `docker build` command with `make` command in README
Yiyiyimu closed issue #147: URL: https://github.com/apache/apisix-docker/issues/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu merged pull request #161: docs: Replace `docker build` command with `make`
Yiyiyimu merged pull request #161: URL: https://github.com/apache/apisix-docker/pull/161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-docker] branch master updated: docs: Replace `docker build` command with `make` (#161)
This is an automated email from the ASF dual-hosted git repository.
shuyangw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-docker.git
The following commit(s) were added to refs/heads/master by this push:
new 47122bf docs: Replace `docker build` command with `make` (#161)
47122bf is described below
commit 47122bf141cc08cf22a44fbafab15b67d45c0c77
Author: Ayush das
AuthorDate: Mon Apr 19 08:37:41 2021 +0530
docs: Replace `docker build` command with `make` (#161)
---
Makefile | 8
README.md | 34 +++---
2 files changed, 31 insertions(+), 11 deletions(-)
diff --git a/Makefile b/Makefile
index 9294026..90701bd 100644
--- a/Makefile
+++ b/Makefile
@@ -46,6 +46,14 @@ push-on-centos:
push-on-alpine:
docker push $(IMAGE_NAME):$(APISIX_VERSION)-alpine
+### build-on-alpine-cn: Build apache/apisix:xx-alpine image
(for chinese)
+build-on-alpine-cn:
+ docker build -t $(IMAGE_NAME):${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} --build-arg ENABLE_PROXY=true -f
alpine/Dockerfile alpine
+
+### build-all-in-one: Build All in one Docker container for Apache
APISIX
+build-all-in-one:
+ docker build -t $(IMAGE_NAME):whole -f ./all-in-one/apisix/Dockerfile .
+
### save-centos-tar: tar apache/apisix:xx-centos image
save-centos-tar:
mkdir -p package
diff --git a/README.md b/README.md
index 374c7cc..2044311 100644
--- a/README.md
+++ b/README.md
@@ -7,31 +7,43 @@
### Build an image from source
1. Build from release version:
-```
+```sh
# Assign Apache release version number to variable `APISIX_VERSION`, for
example: 2.4. The latest version can be find at
`https://github.com/apache/apisix/releases`
export APISIX_VERSION=2.4
-docker build -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine
+# alpine
+$ make build-on-alpine
+
+# centos
+$ make build-on-centos
```
2. Build from master branch version, which has latest code(ONLY for the
developer's convenience):
-```
+```sh
export APISIX_VERSION=master
-docker build -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine
+# alpine
+$ make build-on-alpine
+
+# centos
+$ make build-on-centos
```
3. Build from local code:
-```
+```sh
# To copy apisix into image, we need to include it in build context
-cd
-docker build -t apisix:alpine-local --build-arg APISIX_PATH=. -f
/alpine-local/Dockerfile alpine
+$ cd
+
+# alpine
+
+$ APISIX_PATH=/path/to/apisix make build-on-alpine-local
+
# Might need root privilege if encounter "error checking context: 'can't stat'"
```
**Note:** For Chinese, the following command is always recommended. The
additional build argument `ENABLE_PROXY=true` will enable proxy to definitely
accelerate the progress.
```sh
-$ docker build -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} --build-arg ENABLE_PROXY=true -f
alpine/Dockerfile alpine
+$ make build-on-alpine-cn
```
### Manual deploy apisix via docker
@@ -42,7 +54,7 @@ $ docker build -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${A
**start all modules with docker-compose**
-```
+```sh
$ cd example
$ docker-compose -p docker-apisix up -d
```
@@ -54,7 +66,7 @@ You can refer to [the docker-compose
example](docs/en/latest/example.md) for mor
* All in one Docker container for Apache APISIX
```shell
-$ docker build -t apache/apisix:whole -f ./all-in-one/apisix/Dockerfile .
+$ make build-all-in-one
$ docker run -v
`pwd`/all-in-one/apisix/config.yaml:/usr/local/apisix/conf/config.yaml -p
9080:9080 -p 2379:2379 -d apache/apisix:whole
```
@@ -63,7 +75,7 @@ $ docker run -v
`pwd`/all-in-one/apisix/config.yaml:/usr/local/apisix/conf/confi
**The latest version of `apisix-dashboard` is 2.4 and should be used with
APISIX 2.3.**
```shell
-$ docker build --build-arg APISIX_VERSION=2.3 --build-arg
APISIX_DASHBOARD_VERSION=v2.4 -t apache/apisix-dashboard:whole -f
./all-in-one/apisix-dashboard/Dockerfile .
+$ make build-dashboard
$ docker run -v
`pwd`/all-in-one/apisix/config.yaml:/usr/local/apisix/conf/config.yaml -v
`pwd`/all-in-one/apisix-dashboard/conf.yaml:/usr/local/apisix-dashboard/conf/conf.yaml
-p 9080:9080 -p 2379:2379 -p 9000:9000 -d apache/apisix-dashboard:whole
```
[GitHub] [apisix] moonming commented on a change in pull request #3883: feat: add 5xx error page
moonming commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r615513972
##
File path: t/error_handler/error_handler.t
##
@@ -0,0 +1,214 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: set route with serverless-post-function plugin
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"serverless-post-function": {
+"functions" : ["return function() if
ngx.var.http_x_test_status ~= nil
then;ngx.exit(tonumber(ngx.var.http_x_test_status));end;end"]
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}]]
+)
+
+if code >= 300 then
+ngx.sleep(100)
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 2: test apisix with internal error code 500
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 500
+--- error_code: 500
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 3: test apisix with internal error code 502
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 502
+--- error_code: 502
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 4: test apisix with internal error code 503
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 503
+--- error_code: 503
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 5: test apisix with internal error code 504
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 504
+--- error_code: 504
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 6: test apisix with internal error code 400
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 400
+--- error_code: 400
+--- response_body
+
+400 Bad Request
+
+400 Bad Request
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 7: test apisix with internal error code 401
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 401
+--- error_code: 401
+--- response_body
+
+401 Unauthorized
+
+401 Unauthorized
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 8: test apisix with internal error code 403
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 403
+--- error_code: 403
+--- response_body
+
+403 Forbidden
+
+403 Forbidden
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 9: test apisix with internal error code 404
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 404
+--- error_code: 404
+--- response_body
+
+404 Not Found
+
+404 Not Found
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 10: test apisix with internal error code 405
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 405
+--- error_code: 405
+--- response_body
+
+405 Not Allowed
+
+405 Not Allowed
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 12: test apisix with upstream error code 400
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 400
+--- error_code: 400
+--- response_body
+upstream status: 400
+
+
+
+=== TEST 11: test apisix with upstream error code 500
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 500
+--- error_code: 500
+--- response_body
+upstream status: 500
Review comment:
Do users need to care about the error of the Apache APISIX or the
upstream error? I remember that there are already corresponding HTTP headers to
distinguish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
[GitHub] [apisix] starsz commented on a change in pull request #3883: feat: add 5xx error page
starsz commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r615512964
##
File path: t/error_handler/error_handler.t
##
@@ -0,0 +1,214 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: set route with serverless-post-function plugin
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"serverless-post-function": {
+"functions" : ["return function() if
ngx.var.http_x_test_status ~= nil
then;ngx.exit(tonumber(ngx.var.http_x_test_status));end;end"]
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}]]
+)
+
+if code >= 300 then
+ngx.sleep(100)
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 2: test apisix with internal error code 500
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 500
+--- error_code: 500
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 3: test apisix with internal error code 502
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 502
+--- error_code: 502
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 4: test apisix with internal error code 503
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 503
+--- error_code: 503
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 5: test apisix with internal error code 504
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 504
+--- error_code: 504
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 6: test apisix with internal error code 400
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 400
+--- error_code: 400
+--- response_body
+
+400 Bad Request
+
+400 Bad Request
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 7: test apisix with internal error code 401
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 401
+--- error_code: 401
+--- response_body
+
+401 Unauthorized
+
+401 Unauthorized
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 8: test apisix with internal error code 403
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 403
+--- error_code: 403
+--- response_body
+
+403 Forbidden
+
+403 Forbidden
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 9: test apisix with internal error code 404
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 404
+--- error_code: 404
+--- response_body
+
+404 Not Found
+
+404 Not Found
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 10: test apisix with internal error code 405
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 405
+--- error_code: 405
+--- response_body
+
+405 Not Allowed
+
+405 Not Allowed
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 12: test apisix with upstream error code 400
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 400
+--- error_code: 400
+--- response_body
+upstream status: 400
+
+
+
+=== TEST 11: test apisix with upstream error code 500
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 500
+--- error_code: 500
+--- response_body
+upstream status: 500
Review comment:
> I mean, why doesn’t the upstream 5xx show the 5xx page of Apache
APISIX?
The upstream 5xx has its own mean.There maybe contains the error info like
`{"code": 5xx, "error_msg": "xxx"}.
So IMO we shouldn't modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #161: docs: Replace `docker build` command with `make`
Yiyiyimu commented on a change in pull request #161:
URL: https://github.com/apache/apisix-docker/pull/161#discussion_r615512813
##
File path: README.md
##
@@ -30,15 +30,18 @@ $ make build-on-centos
```
# To copy apisix into image, we need to include it in build context
$ cd
-# alpine-local
-$ make build-on-alpine-local
+
+# alpine
+
+$ APISIX_PATH=/path/to/apisix make build-on-alpine-local
+
# Might need root privilege if encounter "error checking context: 'can't stat'"
```
**Note:** For Chinese, the following command is always recommended. The
additional build argument `ENABLE_PROXY=true` will enable proxy to definitely
accelerate the progress.
```sh
-$ make build-on-alpine-cn
+$ docker build -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} --build-arg ENABLE_PROXY=true -f
alpine/Dockerfile alpine
Review comment:
Yes but it seems you de-comment out the wrong way 藍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3883: feat: add 5xx error page
moonming commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r615512328
##
File path: t/error_handler/error_handler.t
##
@@ -0,0 +1,214 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: set route with serverless-post-function plugin
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"serverless-post-function": {
+"functions" : ["return function() if
ngx.var.http_x_test_status ~= nil
then;ngx.exit(tonumber(ngx.var.http_x_test_status));end;end"]
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}]]
+)
+
+if code >= 300 then
+ngx.sleep(100)
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 2: test apisix with internal error code 500
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 500
+--- error_code: 500
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 3: test apisix with internal error code 502
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 502
+--- error_code: 502
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 4: test apisix with internal error code 503
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 503
+--- error_code: 503
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 5: test apisix with internal error code 504
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 504
+--- error_code: 504
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 6: test apisix with internal error code 400
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 400
+--- error_code: 400
+--- response_body
+
+400 Bad Request
+
+400 Bad Request
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 7: test apisix with internal error code 401
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 401
+--- error_code: 401
+--- response_body
+
+401 Unauthorized
+
+401 Unauthorized
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 8: test apisix with internal error code 403
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 403
+--- error_code: 403
+--- response_body
+
+403 Forbidden
+
+403 Forbidden
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 9: test apisix with internal error code 404
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 404
+--- error_code: 404
+--- response_body
+
+404 Not Found
+
+404 Not Found
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 10: test apisix with internal error code 405
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 405
+--- error_code: 405
+--- response_body
+
+405 Not Allowed
+
+405 Not Allowed
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 12: test apisix with upstream error code 400
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 400
+--- error_code: 400
+--- response_body
+upstream status: 400
+
+
+
+=== TEST 11: test apisix with upstream error code 500
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 500
+--- error_code: 500
+--- response_body
+upstream status: 500
Review comment:
I mean, why doesn’t the upstream 5xx show the 5xx page of Apache APISIX?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Marco-Zheng commented on issue #4071: request help: Decode secret is not a valid cert, public key: bad base64 decode
Marco-Zheng commented on issue #4071: URL: https://github.com/apache/apisix/issues/4071#issuecomment-822129971 > > Can you provide a pasteable version of the configuration so we can check it by ourselves? > > private key > > ``` > MIIEpAIBAAKCAQEAwmrcfN+hMvczGzOQwQW3ZzFgJvEzdnxjk6ShqmmpP5fBM8gh > czMgrkjJOjTI7LIHoQ7pDpXn/Xie9ySaKbHrI5TGvDw0qxYbHZTLW15DQV9EBEov > WvOyTwQuefb8l88vE+aS6U12LEGGVnoZGJHV1Ow0DlfCzeKmRedfsqN4WIjB6SmM > qydwZ7a9tsAk6GKpYwHNq3WoeT0P9p7lyMv4yQrk2Jr+5Sl1RBqFtGKDk832ioQb > JxE+czGz4sGwONIbgcSdWfPT1G6j6ZZvL4UX2p2Eg5YE2dvmo/MqOtiP5YJnLqyt > URKau9pyJAEraDzE7NmoCxq4CKHTwziH/lfbgQIDAQABAoIBACOqpQ6HnDQUY5zO > 5fRzTwUwarpaL53CDiaM4le4EKOo/Hm6cmCG9azjj38NJfs+YeXrLVhOqgO3ODqQ > zXNuv3uElLz9so/ce1b+8Buv/Fim2HyM+4kNAh463yfi5s4W5UUaXMNOQaq2zqVY > uvfl8TuhpZ8n/IX22ZgjbUwBb1eWVPxiuiXvdQP/k9KYvAXLge+OCDPJA5N/Z6CB > aZNlxNGNyzc+Y5526goBIhWxYwAUOAEoYGGEOm+aGyH/k23Ggo9zQEZODdWK6XOu > btYUDEb1pvVqE3dZHCr6KZw+E/XrbpuFpmOaDfifB/kWxVshfUK/IzYbYF8XIM1N > g502SVECgYEA9SSGvORfBoHv4GbN063Q7BEhbe+aO5cSgi1eeFKuR979eSzJvDzY > YjBkkJFTPqmS/jxCCCzH6Hp2BavlYEDVlbEzfU6u9jZCQa5wvkf17zL8qyiLoixG > maUTAvb2QJTtoUJvSeOMcbU6kOFzqCZtjKfwvRaRyv/AhwvzaAaGBc0CgYEAywcz > 2Ez6DC3yInztAJUt0cfWdPHvfxlV5xw03S/zJN3RRiyaXwWxwM3ud01Fzk5CCYts > ZGcOlzyfmfEMchfXYaO6lmsp3SMAZLseJHguNNV+cSt+Xk3W+ip0UMbnTypwGJ+6 > 88koWsA1ybU37bjGKYIo8f9yBrmOBuN3cN06OIUCgYAgKEN4geipPOBPqoyziOiQ > HwsolbbAvGeUJglvdUEhcnIDtEleZQjpkHmQsU+fN7Vtnk/3LJCowW+7/LmhL8AU > 2+LqPCkdaS612QE3JM9xKloUxcPTaUV1oD7nM6hH/oFRlxpsMepZfDGLkdePJkNW > oS0mUNCdNYF29a1fZwOrvQKBgQCTVj7BkdtES3OUo6Q68Ae4XZW8eHadff1hIo8a > lVmWP4NHsca1fqRojwmnemRWO2ShGJUop8Fm74/DX7LweWzMZs1Zq5tN58C5WTGe > tbiSjvyblDy4ozSHh5expyblxJ5kwEYj9K9cbHCcWO6ljZoBNXwRYpeVWcNALILZ > XTKLIQKBgQCEppj9BGGdqjb+KuAtmEVk717zGMul2fdR+UQoTxnrvW5Su1MQKkPc > cjrXYZPtVMRfgU6GRO8us+wJ/cLDuyOetNZg8oiOhMucC6rBhdRIXud0Q+jyE6kj > HIBOdtL+NP94Bek6uHaLi8GTkuYj2499rJRS93SGRc53uPFS81WQWQ== > ``` > > public key > > ``` > ssh-rsa B3NzaC1yc2EDAQABAAABAQDCatx836Ey9zMbM5DBBbdnMWAm8TN2fGOTpKGqaak/l8EzyCFzMyCuSMk6NMjssgehDukOlef9eJ73JJopsesjlMa8PDSrFhsdlMtbXkNBX0QESi9a87JPBC559vyXzy8T5pLpTXYsQYZWehkYkdXU7DQOV8LN4qZF51+yo3hYiMHpKYyrJ3Bntr22wCToYqljAc2rdah5PQ/2nuXIy/jJCuTYmv7lKXVEGoW0YoOTzfaKhBsnET5zMbPiwbA40huBxJ1Z89PUbqPplm8vhRfanYSDlgTZ2+aj8yo62I/lgmcurK1REpq72nIkAStoPMTs2agLGrgIodPDOIf+V9uB root@VM-50-173-centos > ``` please remind to delete the blank space for private key, here is the correct copy one ``` MIIEpAIBAAKCAQEAwmrcfN+hMvczGzOQwQW3ZzFgJvEzdnxjk6ShqmmpP5fBM8ghczMgrkjJOjTI7LIHoQ7pDpXn/Xie9ySaKbHrI5TGvDw0qxYbHZTLW15DQV9EBEovWvOyTwQuefb8l88vE+aS6U12LEGGVnoZGJHV1Ow0DlfCzeKmRedfsqN4WIjB6SmMqydwZ7a9tsAk6GKpYwHNq3WoeT0P9p7lyMv4yQrk2Jr+5Sl1RBqFtGKDk832ioQbJxE+czGz4sGwONIbgcSdWfPT1G6j6ZZvL4UX2p2Eg5YE2dvmo/MqOtiP5YJnLqytURKau9pyJAEraDzE7NmoCxq4CKHTwziH/lfbgQIDAQABAoIBACOqpQ6HnDQUY5zO5fRzTwUwarpaL53CDiaM4le4EKOo/Hm6cmCG9azjj38NJfs+YeXrLVhOqgO3ODqQzXNuv3uElLz9so/ce1b+8Buv/Fim2HyM+4kNAh463yfi5s4W5UUaXMNOQaq2zqVYuvfl8TuhpZ8n/IX22ZgjbUwBb1eWVPxiuiXvdQP/k9KYvAXLge+OCDPJA5N/Z6CBaZNlxNGNyzc+Y5526goBIhWxYwAUOAEoYGGEOm+aGyH/k23Ggo9zQEZODdWK6XOubtYUDEb1pvVqE3dZHCr6KZw+E/XrbpuFpmOaDfifB/kWxVshfUK/IzYbYF8XIM1Ng502SVECgYEA9SSGvORfBoHv4GbN063Q7BEhbe+aO5cSgi1eeFKuR979eSzJvDzYYjBkkJFTPqmS/jxCCCzH6Hp2BavlYEDVlbEzfU6u9jZCQa5wvkf17zL8qyiLoixGmaUTAvb2QJTtoUJvSeOMcbU6kOFzqCZtjKfwvRaRyv/AhwvzaAaGBc0CgYEAywcz2Ez6DC3yInztAJUt0cfWdPHvfxlV5xw03S/zJN3RRiyaXwWxwM3ud01Fzk5CCYtsZGcOlzyfmfEMchfXYaO6lmsp3SMAZLseJHg uNNV+cSt+Xk3W+ip0UMbnTypwGJ+688koWsA1ybU37bjGKYIo8f9yBrmOBuN3cN06OIUCgYAgKEN4geipPOBPqoyziOiQHwsolbbAvGeUJglvdUEhcnIDtEleZQjpkHmQsU+fN7Vtnk/3LJCowW+7/LmhL8AU2+LqPCkdaS612QE3JM9xKloUxcPTaUV1oD7nM6hH/oFRlxpsMepZfDGLkdePJkNWoS0mUNCdNYF29a1fZwOrvQKBgQCTVj7BkdtES3OUo6Q68Ae4XZW8eHadff1hIo8alVmWP4NHsca1fqRojwmnemRWO2ShGJUop8Fm74/DX7LweWzMZs1Zq5tN58C5WTGetbiSjvyblDy4ozSHh5expyblxJ5kwEYj9K9cbHCcWO6ljZoBNXwRYpeVWcNALILZXTKLIQKBgQCEppj9BGGdqjb+KuAtmEVk717zGMul2fdR+UQoTxnrvW5Su1MQKkPccjrXYZPtVMRfgU6GRO8us+wJ/cLDuyOetNZg8oiOhMucC6rBhdRIXud0Q+jyE6kjHIBOdtL+NP94Bek6uHaLi8GTkuYj2499rJRS93SGRc53uPFS81WQWQ== ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #388: test: add e2e test cases for ip-restriction plugin
tokers opened a new pull request #388: URL: https://github.com/apache/apisix-ingress-controller/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu opened a new issue #4076: docs: remove leading `$` of each bash command
Yiyiyimu opened a new issue #4076: URL: https://github.com/apache/apisix/issues/4076 # Improve Docs ## Please describe which part of docs should be improved or typo fixed Currently in [`getting-started`](https://github.com/apache/apisix/blob/master/docs/en/latest/getting-started.md), there would always be a `$` at the front of each command, which makes users hard to do three-click to directly copy the whole command and run without modification. They have to manually delete `$`. And it could be more annoying when on [website](http://apisix.incubator.apache.org/docs/apisix/getting-started) that users could directly use one-click copy button to do so. So it could be better if we remove all those dollar signs at the front of each command in docs. And the same problem that happens in `how-to-build`/`install-dependencies` also could be fixed. ## Describe the solution you'd like Remove them all~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #3883: feat: add 5xx error page
starsz commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r615511475
##
File path: t/error_handler/error_handler.t
##
@@ -0,0 +1,214 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: set route with serverless-post-function plugin
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"serverless-post-function": {
+"functions" : ["return function() if
ngx.var.http_x_test_status ~= nil
then;ngx.exit(tonumber(ngx.var.http_x_test_status));end;end"]
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}]]
+)
+
+if code >= 300 then
+ngx.sleep(100)
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 2: test apisix with internal error code 500
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 500
+--- error_code: 500
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 3: test apisix with internal error code 502
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 502
+--- error_code: 502
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 4: test apisix with internal error code 503
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 503
+--- error_code: 503
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 5: test apisix with internal error code 504
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 504
+--- error_code: 504
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 6: test apisix with internal error code 400
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 400
+--- error_code: 400
+--- response_body
+
+400 Bad Request
+
+400 Bad Request
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 7: test apisix with internal error code 401
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 401
+--- error_code: 401
+--- response_body
+
+401 Unauthorized
+
+401 Unauthorized
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 8: test apisix with internal error code 403
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 403
+--- error_code: 403
+--- response_body
+
+403 Forbidden
+
+403 Forbidden
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 9: test apisix with internal error code 404
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 404
+--- error_code: 404
+--- response_body
+
+404 Not Found
+
+404 Not Found
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 10: test apisix with internal error code 405
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 405
+--- error_code: 405
+--- response_body
+
+405 Not Allowed
+
+405 Not Allowed
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 12: test apisix with upstream error code 400
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 400
+--- error_code: 400
+--- response_body
+upstream status: 400
+
+
+
+=== TEST 11: test apisix with upstream error code 500
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 500
+--- error_code: 500
+--- response_body
+upstream status: 500
Review comment:
Here is a mock that I mock the upstream status.
You can see `t/lib/server.lua`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[GitHub] [apisix] tokers commented on a change in pull request #3883: feat: add 5xx error page
tokers commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r615511295
##
File path: apisix/error_handler.lua
##
@@ -0,0 +1,78 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local ngx = ngx
+local str_format = string.format
+
+
+local html_5xx = [[
+
+
+
+
+
+Error
+
+body {
+width: 35em;
+margin: 0 auto;
+font-family: Tahoma, Verdana, Arial, sans-serif;
+}
+
+
+
+An error occurred.
+You can report issue to https://github.com/apache/apisix/issues;>APISIX
+Faithfully yours, https://apisix.apache.org/;>APISIX.
+
+
+]]
+
+local html_4xx = [[
+
+%s
+
+%s
+ https://apisix.apache.org/;>APISIX
+
+
+]]
+
+local ngx_status_line = {
+[400] = "400 Bad Request",
+[401] = "401 Unauthorized",
+[403] = "403 Forbidden",
+[404] = "404 Not Found",
+[405] = "405 Not Allowed",
+}
+
Review comment:
Show status code in body is useful in the browser, I think we can
reserve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1784: fix: show correct health checker
juzhiyuan merged pull request #1784: URL: https://github.com/apache/apisix-dashboard/pull/1784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: fix: show correct health checker (#1784)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 5e46f60 fix: show correct health checker (#1784)
5e46f60 is described below
commit 5e46f6072113fc2d41807256a6786ed7c84d6674
Author: 琚致远
AuthorDate: Mon Apr 19 10:44:52 2021 +0800
fix: show correct health checker (#1784)
Co-authored-by: litesun <7sunm...@gmail.com>
---
...an-skip-upstream-when-select-service-id.spec.js | 23 ++--
.../route/create-route-with-upstream.spec.js | 13 ++-
.../service/edit-service-with-upstream.spec.js | 7 +-
web/src/components/Upstream/UpstreamForm.tsx | 129 +++--
.../components/Upstream/components/PassHost.tsx| 10 +-
.../Upstream/components/UpstreamSelector.tsx | 10 +-
.../Upstream/components/active-check/Host.tsx | 5 -
.../Upstream/components/active-check/HttpPath.tsx | 7 --
.../Upstream/components/active-check/Port.tsx | 4 +-
web/src/components/Upstream/locales/en-US.ts | 7 +-
web/src/components/Upstream/locales/zh-CN.ts | 7 +-
web/src/components/Upstream/service.ts | 91 ++-
web/src/components/Upstream/typings.d.ts | 3 +-
web/src/pages/Route/Create.tsx | 1 +
web/src/pages/Route/components/Step1/MetaView.tsx | 63 ++
.../Route/components/Step2/RequestRewriteView.tsx | 8 +-
web/src/pages/Route/locales/en-US.ts | 2 +
web/src/pages/Route/locales/zh-CN.ts | 2 +
web/src/pages/Route/service.ts | 7 --
web/src/pages/Route/transform.ts | 17 ++-
web/src/pages/Route/typing.d.ts| 30 +
web/src/pages/Service/Create.tsx | 14 ++-
web/src/pages/Service/components/Step1.tsx | 4 +-
web/src/pages/Service/service.ts | 7 --
web/src/pages/Upstream/Create.tsx | 17 +--
web/src/pages/Upstream/components/Step1.tsx| 13 +--
web/src/pages/Upstream/locales/zh-CN.ts| 2 +-
web/src/pages/Upstream/service.ts | 4 +-
web/src/pages/Upstream/transform.ts| 83 -
29 files changed, 297 insertions(+), 293 deletions(-)
diff --git
a/web/cypress/integration/route/can-skip-upstream-when-select-service-id.spec.js
b/web/cypress/integration/route/can-skip-upstream-when-select-service-id.spec.js
index d62cd87..aeb5118 100644
---
a/web/cypress/integration/route/can-skip-upstream-when-select-service-id.spec.js
+++
b/web/cypress/integration/route/can-skip-upstream-when-select-service-id.spec.js
@@ -61,7 +61,7 @@ context('Can select service_id skip upstream in route', () =>
{
cy.get(this.domSelector.name).type(this.data.routeName);
cy.contains('Next').click();
cy.get(this.domSelector.upstreamSelector).click();
-cy.contains('None').should('not.exist');
+cy.get('.ant-select-item-option-disabled >
.ant-select-item-option-content').contains('None');
cy.contains('Previous').click();
cy.wait(500);
@@ -91,9 +91,12 @@ context('Can select service_id skip upstream in route', ()
=> {
cy.contains(this.data.routeName).siblings().contains('Configure').click();
cy.get(this.domSelector.serviceSelector).click();
cy.contains('None').click();
+cy.get(this.domSelector.notification).should('contain', 'Please check the
configuration of binding service');
+cy.get(this.domSelector.notificationCloseIcon).click();
+
cy.contains('Next').click();
-cy.get(this.domSelector.upstream_id).click();
-cy.contains('None').should('not.exist');
+cy.wait(500);
+cy.get('[data-cy=upstream_selector]').click();
cy.contains(this.data.upstreamName).click();
cy.contains('Next').click();
cy.contains('Next').click();
@@ -101,13 +104,7 @@ context('Can select service_id skip upstream in route', ()
=> {
cy.contains(this.data.submitSuccess);
});
- it('should delete upstream, service and route', function () {
-cy.visit('/');
-cy.contains('Service').click();
-cy.contains(this.data.serviceName).siblings().contains('Delete').click();
-cy.contains('button', 'Confirm').click();
-cy.get(this.domSelector.notification).should('contain',
this.data.deleteServiceSuccess);
-
+ it('should delete route, service and upstream', function () {
cy.visit('/');
cy.contains('Route').click();
cy.contains(this.data.routeName).siblings().contains('More').click();
@@ -115,7 +112,13 @@ context('Can select service_id skip upstream in route', ()
=> {
cy.get(this.domSelector.deleteAlert).should('be.visible').within(() => {
cy.contains('OK').click();
});
+
cy.get(this.domSelector.notification).should('contain',
this.data.deleteRouteSuccess);
+
[GitHub] [apisix-dashboard] StretchV commented on issue #1778: excuse,how to do the fuzzy search of routing in the apisix-dashboard
StretchV commented on issue #1778: URL: https://github.com/apache/apisix-dashboard/issues/1778#issuecomment-822129024 @nic-chen 大佬可以帮解惑一下吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #3883: feat: add 5xx error page
starsz commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r615510914
##
File path: apisix/error_handler.lua
##
@@ -0,0 +1,78 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local ngx = ngx
+local str_format = string.format
+
+
+local html_5xx = [[
+
+
+
+
+
+Error
+
+body {
+width: 35em;
+margin: 0 auto;
+font-family: Tahoma, Verdana, Arial, sans-serif;
+}
+
+
+
+An error occurred.
+You can report issue to https://github.com/apache/apisix/issues;>APISIX
+Faithfully yours, https://apisix.apache.org/;>APISIX.
+
+
+]]
+
+local html_4xx = [[
+
+%s
+
+%s
+ https://apisix.apache.org/;>APISIX
+
+
+]]
+
+local ngx_status_line = {
+[400] = "400 Bad Request",
+[401] = "401 Unauthorized",
+[403] = "403 Forbidden",
+[404] = "404 Not Found",
+[405] = "405 Not Allowed",
+}
+
Review comment:
Because we should add it into 4xx html.
I can't find any API that contains this info.
@tokers @spacewander Do you have any opinions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1786: fix: historical comments issues
juzhiyuan merged pull request #1786: URL: https://github.com/apache/apisix-dashboard/pull/1786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: fix: historical comments issues (#1786)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new f57ad4e fix: historical comments issues (#1786)
f57ad4e is described below
commit f57ad4e0f666c50806e28d43587ce59aa1552c47
Author: litesun
AuthorDate: Mon Apr 19 10:42:18 2021 +0800
fix: historical comments issues (#1786)
---
web/src/components/Plugin/UI/api-breaker.tsx | 2 +-
web/src/components/Plugin/UI/cors.tsx| 8 +++
web/src/components/Plugin/UI/limit-count.tsx | 34 ++--
web/src/components/Plugin/locales/en-US.ts | 4 ++--
web/src/components/Plugin/locales/zh-CN.ts | 2 +-
5 files changed, 34 insertions(+), 16 deletions(-)
diff --git a/web/src/components/Plugin/UI/api-breaker.tsx
b/web/src/components/Plugin/UI/api-breaker.tsx
index 2ccf2dd..28f8518 100644
--- a/web/src/components/Plugin/UI/api-breaker.tsx
+++ b/web/src/components/Plugin/UI/api-breaker.tsx
@@ -67,7 +67,7 @@ const ApiBreaker: React.FC = ({ form }) => {
initialValue={300}
tooltip={formatMessage({ id:
'component.pluginForm.api-breaker.max_breaker_sec.tooltip' })}
>
-
+
diff --git a/web/src/components/Plugin/UI/cors.tsx
b/web/src/components/Plugin/UI/cors.tsx
index d075fc4..4bee0eb 100644
--- a/web/src/components/Plugin/UI/cors.tsx
+++ b/web/src/components/Plugin/UI/cors.tsx
@@ -57,9 +57,8 @@ const Cors: React.FC = ({ form }) => {
{
-((value as string[]).join(","));
-if ((value as string[]).includes('*')) {
+ onChange={(value: string[]) => {
+if (value.includes('*')) {
form.setFieldsValue({
allow_methods: ['*'],
});
@@ -80,7 +79,6 @@ const Cors: React.FC = ({ form }) => {
= ({ form }) => {
-
+
{(fields, { add, remove }) => {
return (
diff --git a/web/src/components/Plugin/UI/limit-count.tsx
b/web/src/components/Plugin/UI/limit-count.tsx
index bddeb94..77f47ba 100644
--- a/web/src/components/Plugin/UI/limit-count.tsx
+++ b/web/src/components/Plugin/UI/limit-count.tsx
@@ -64,11 +64,12 @@ const RedisForm: React.FC = () => {
-
+
{
{
-
+
)
}
-const RedisClusterForm: React.FC = () => {
+const RedisClusterForm: React.FC = () => {
const { formatMessage } = useIntl();
return (
@@ -109,7 +112,7 @@ const RedisClusterForm: React.FC = () => {
>
-
+
{(fields, { add, remove }) => {
return (
@@ -159,6 +162,21 @@ const RedisClusterForm: React.FC = () => {
);
}}
+
+
+
+
+
+
)
}
@@ -170,7 +188,6 @@ const LimitCount: React.FC = ({ form }) => {
= ({ form }) => {
= ({ form }) => {
= ({ form }) => {
{ setPoicy(e) }}>
- {["local", "redis", "redis-cluster"].map(item => ({item}))}
+ {["local", "redis", "redis-cluster"].map(item => ({item}))}
prev.policy !== next.policy}
style={{ display: 'none' }}>
@@ -221,7 +241,7 @@ const LimitCount: React.FC = ({ form }) => {
}}
{Boolean(policy === 'redis') && }
- {Boolean(policy === 'redis-cluster') && }
+ {Boolean(policy === 'redis-cluster') && }
);
}
diff --git a/web/src/components/Plugin/locales/en-US.ts
b/web/src/components/Plugin/locales/en-US.ts
index b1f3ae4..b1ed0d8 100644
--- a/web/src/components/Plugin/locales/en-US.ts
+++ b/web/src/components/Plugin/locales/en-US.ts
@@ -35,7 +35,7 @@ export default {
'component.pluginForm.cors.allow_origins.extra': 'For example:
https://somehost.com:8081',
'component.pluginForm.cors.allow_methods.tooltip': 'Which Method is allowed
to enable CORS, such as: GET, POST etc. Multiple method use , to split. When
allow_credential is false, you can use * to indicate allow all any method. You
also can allow any method forcefully using ** even already enable
allow_credential, but it will bring some security risks.',
'component.pluginForm.cors.allow_headers.tooltip': 'Which headers are
allowed to set in request when access cross-origin resource. Multiple value use
, to split. When allow_credential is false, you can use * to indicate allow all
request headers. You also can allow any header forcefully using ** even already
enable allow_credential, but it will bring some security risks.',
- 'component.pluginForm.cors.expose_headers.tooltip': 'Which headers
are allowed to set in response when access cross-origin resource. Multiple
value
[GitHub] [apisix] Marco-Zheng commented on issue #4071: request help: Decode secret is not a valid cert, public key: bad base64 decode
Marco-Zheng commented on issue #4071: URL: https://github.com/apache/apisix/issues/4071#issuecomment-822127894 > > I try to change another one , but also failed. > > Did you try to regenerate the token value, try again? Or provide a reproducible configuration, let's check it. Yeap, i paste the public key and private as above, and generate rsa key by using `ssh-keygen -t rsa -C` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Marco-Zheng removed a comment on issue #4071: request help: Decode secret is not a valid cert, public key: bad base64 decode
Marco-Zheng removed a comment on issue #4071: URL: https://github.com/apache/apisix/issues/4071#issuecomment-822120114 > @Marco-Zheng > Can you provide a pasteable version of the configuration so we can check it by ourselves? the public key as below(remark: ...@.cn is email, please ignore) ``` ssh-rsa B3NzaC1yc2EDAQABAAABAQDs2QEw1uMz8OKouWjNwMv+2mU4CtNixkt644Wn/mX1ZvBnxDLJh9Tac1KZockncL3LVZgQ1frdmRYhDWudPRhEoNjcDzO1HcovGp1vBYWfd3pZ6BJatjlaYcuAtdyORAdEf28r9qGEjNEO9y1BwyFEIsEvF3Cn05lvTsmZOeuw9Vn/LAbnsfqG28b+mrUmnnyoeeF2RQyztZiVtjoLMy0gNQna5uKHZirboHWYdzHlH/sdZ0b14ph03vqFFPnwP2+a8QO6xbqS4YA7bnudtXWi3dLjFU90EkPBovsXPHaNTO4ox5Rj8bMbDQWGA4C/hL6Q1IIshacx7r4tMfjOzHgt ...@.cn ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Marco-Zheng commented on issue #4071: request help: Decode secret is not a valid cert, public key: bad base64 decode
Marco-Zheng commented on issue #4071: URL: https://github.com/apache/apisix/issues/4071#issuecomment-822126971 > Can you provide a pasteable version of the configuration so we can check it by ourselves? private key ``` MIIEpAIBAAKCAQEAwmrcfN+hMvczGzOQwQW3ZzFgJvEzdnxjk6ShqmmpP5fBM8gh czMgrkjJOjTI7LIHoQ7pDpXn/Xie9ySaKbHrI5TGvDw0qxYbHZTLW15DQV9EBEov WvOyTwQuefb8l88vE+aS6U12LEGGVnoZGJHV1Ow0DlfCzeKmRedfsqN4WIjB6SmM qydwZ7a9tsAk6GKpYwHNq3WoeT0P9p7lyMv4yQrk2Jr+5Sl1RBqFtGKDk832ioQb JxE+czGz4sGwONIbgcSdWfPT1G6j6ZZvL4UX2p2Eg5YE2dvmo/MqOtiP5YJnLqyt URKau9pyJAEraDzE7NmoCxq4CKHTwziH/lfbgQIDAQABAoIBACOqpQ6HnDQUY5zO 5fRzTwUwarpaL53CDiaM4le4EKOo/Hm6cmCG9azjj38NJfs+YeXrLVhOqgO3ODqQ zXNuv3uElLz9so/ce1b+8Buv/Fim2HyM+4kNAh463yfi5s4W5UUaXMNOQaq2zqVY uvfl8TuhpZ8n/IX22ZgjbUwBb1eWVPxiuiXvdQP/k9KYvAXLge+OCDPJA5N/Z6CB aZNlxNGNyzc+Y5526goBIhWxYwAUOAEoYGGEOm+aGyH/k23Ggo9zQEZODdWK6XOu btYUDEb1pvVqE3dZHCr6KZw+E/XrbpuFpmOaDfifB/kWxVshfUK/IzYbYF8XIM1N g502SVECgYEA9SSGvORfBoHv4GbN063Q7BEhbe+aO5cSgi1eeFKuR979eSzJvDzY YjBkkJFTPqmS/jxCCCzH6Hp2BavlYEDVlbEzfU6u9jZCQa5wvkf17zL8qyiLoixG maUTAvb2QJTtoUJvSeOMcbU6kOFzqCZtjKfwvRaRyv/AhwvzaAaGBc0CgYEAywcz 2Ez6DC3yInztAJUt0cfWdPHvfxlV5xw03S/zJN3RRiyaXwWxwM3ud01Fzk5CCYts ZGcOlzyfmfEMchfXYaO6lmsp3SMAZLseJHguNNV+cSt+Xk3W+ip0UMbnTypwGJ+6 88koWsA1ybU37bjGKYIo8f9yBrmOBuN3cN06OIUCgYAgKEN4geipPOBPqoyziOiQ HwsolbbAvGeUJglvdUEhcnIDtEleZQjpkHmQsU+fN7Vtnk/3LJCowW+7/LmhL8AU 2+LqPCkdaS612QE3JM9xKloUxcPTaUV1oD7nM6hH/oFRlxpsMepZfDGLkdePJkNW oS0mUNCdNYF29a1fZwOrvQKBgQCTVj7BkdtES3OUo6Q68Ae4XZW8eHadff1hIo8a lVmWP4NHsca1fqRojwmnemRWO2ShGJUop8Fm74/DX7LweWzMZs1Zq5tN58C5WTGe tbiSjvyblDy4ozSHh5expyblxJ5kwEYj9K9cbHCcWO6ljZoBNXwRYpeVWcNALILZ XTKLIQKBgQCEppj9BGGdqjb+KuAtmEVk717zGMul2fdR+UQoTxnrvW5Su1MQKkPc cjrXYZPtVMRfgU6GRO8us+wJ/cLDuyOetNZg8oiOhMucC6rBhdRIXud0Q+jyE6kj HIBOdtL+NP94Bek6uHaLi8GTkuYj2499rJRS93SGRc53uPFS81WQWQ== ``` public key ``` ssh-rsa B3NzaC1yc2EDAQABAAABAQDCatx836Ey9zMbM5DBBbdnMWAm8TN2fGOTpKGqaak/l8EzyCFzMyCuSMk6NMjssgehDukOlef9eJ73JJopsesjlMa8PDSrFhsdlMtbXkNBX0QESi9a87JPBC559vyXzy8T5pLpTXYsQYZWehkYkdXU7DQOV8LN4qZF51+yo3hYiMHpKYyrJ3Bntr22wCToYqljAc2rdah5PQ/2nuXIy/jJCuTYmv7lKXVEGoW0YoOTzfaKhBsnET5zMbPiwbA40huBxJ1Z89PUbqPplm8vhRfanYSDlgTZ2+aj8yo62I/lgmcurK1REpq72nIkAStoPMTs2agLGrgIodPDOIf+V9uB root@VM-50-173-centos ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4071: request help: Decode secret is not a valid cert, public key: bad base64 decode
Firstsawyou commented on issue #4071: URL: https://github.com/apache/apisix/issues/4071#issuecomment-822126966 > I try to change another one , but also failed. Did you try to regenerate the token value, try again? Or provide a reproducible configuration, let's check it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #383: feat: apisixtls schema
tokers commented on pull request #383: URL: https://github.com/apache/apisix-ingress-controller/pull/383#issuecomment-822126652 https://github.com/apache/apisix-ingress-controller/issues/387 I have added an issue to track the test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new issue #387: Add test cases to verify CRD schemas
tokers opened a new issue #387: URL: https://github.com/apache/apisix-ingress-controller/issues/387 We may need some test cases to verify the CRD schemas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gy09535 closed issue #3959: proposal: Should apisix support host+path as route?
gy09535 closed issue #3959: URL: https://github.com/apache/apisix/issues/3959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Marco-Zheng commented on issue #4071: request help: Decode secret is not a valid cert, public key: bad base64 decode
Marco-Zheng commented on issue #4071: URL: https://github.com/apache/apisix/issues/4071#issuecomment-822120811 > This seems to be a problem with the configured `public_key`, you need to check it. I try to change another one , but also failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Marco-Zheng commented on issue #4071: request help: Decode secret is not a valid cert, public key: bad base64 decode
Marco-Zheng commented on issue #4071: URL: https://github.com/apache/apisix/issues/4071#issuecomment-822120114 > @Marco-Zheng > Can you provide a pasteable version of the configuration so we can check it by ourselves? the public key as below(remark: ...@.cn is email, please ignore) ``` ssh-rsa B3NzaC1yc2EDAQABAAABAQDs2QEw1uMz8OKouWjNwMv+2mU4CtNixkt644Wn/mX1ZvBnxDLJh9Tac1KZockncL3LVZgQ1frdmRYhDWudPRhEoNjcDzO1HcovGp1vBYWfd3pZ6BJatjlaYcuAtdyORAdEf28r9qGEjNEO9y1BwyFEIsEvF3Cn05lvTsmZOeuw9Vn/LAbnsfqG28b+mrUmnnyoeeF2RQyztZiVtjoLMy0gNQna5uKHZirboHWYdzHlH/sdZ0b14ph03vqFFPnwP2+a8QO6xbqS4YA7bnudtXWi3dLjFU90EkPBovsXPHaNTO4ox5Rj8bMbDQWGA4C/hL6Q1IIshacx7r4tMfjOzHgt ...@.cn ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #386: feat: add event & status for ApisixRoute v2
tokers commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r615502264
##
File path: pkg/kube/apisix/apis/config/v2alpha1/types.go
##
@@ -61,11 +62,18 @@ const (
)
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+// +kubebuilder:subresource:status
// ApisixRoute is used to define the route rules and upstreams for Apache
APISIX.
type ApisixRoute struct {
metav1.TypeMeta `json:",inline" yaml:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty" yaml:"metadata,omitempty"`
Spec *ApisixRouteSpec `json:"spec,omitempty"
yaml:"spec,omitempty"`
+ StatusApisixStatus `json:"status,omitempty"
yaml:"status,omitempty"`
+}
Review comment:
`ApisixTls` and `ApisixUpstream` should also have this field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] yiyiyimu-bot opened a new pull request #4075: Release/2.5
yiyiyimu-bot opened a new pull request #4075: URL: https://github.com/apache/apisix/pull/4075 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yiyiyimu-bot closed pull request #4075: Release/2.5
yiyiyimu-bot closed pull request #4075: URL: https://github.com/apache/apisix/pull/4075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #386: feat: add event & status for ApisixRoute v2
tokers commented on a change in pull request #386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/386#discussion_r615490868
##
File path: pkg/ingress/apisix_route.go
##
@@ -16,23 +16,33 @@ package ingress
import (
"context"
+ "fmt"
"time"
"go.uber.org/zap"
+ v1 "k8s.io/api/core/v1"
k8serrors "k8s.io/apimachinery/pkg/api/errors"
+ "k8s.io/apimachinery/pkg/api/meta"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+ "k8s.io/client-go/kubernetes/scheme"
"k8s.io/client-go/tools/cache"
+ "k8s.io/client-go/tools/record"
"k8s.io/client-go/util/workqueue"
"github.com/apache/apisix-ingress-controller/pkg/kube"
+
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/client/clientset/versioned/typed/config/v2alpha1"
"github.com/apache/apisix-ingress-controller/pkg/log"
"github.com/apache/apisix-ingress-controller/pkg/types"
apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
)
+const RouteController = "RouteController"
Review comment:
Since this constant is not exported, just using a small case.
```suggestion
const (
_routeController = "ApisixRouteController"
)
```
##
File path: pkg/ingress/controller.go
##
@@ -44,6 +44,17 @@ import (
apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
)
+const (
+ // SuccessSynced is used when a resource is synced successfully
+ SuccessSynced = "SyncSuccessfully"
Review comment:
We don't have to export all these constants.
##
File path: pkg/ingress/apisix_route.go
##
@@ -198,14 +210,50 @@ func (c *apisixRouteController) sync(ctx context.Context,
ev *types.Event) error
}
func (c *apisixRouteController) handleSyncErr(obj interface{}, err error) {
+ event := obj.(*types.Event)
+ route := event.Object.(kube.ApisixRouteEvent).OldObject
+ // conditions
+ condition := metav1.Condition{
+ Type: "APISIXSynced",
Review comment:
Not a good name. It's should be a noun like `"ResourcesReady"`.
##
File path: pkg/ingress/apisix_route.go
##
@@ -198,14 +210,50 @@ func (c *apisixRouteController) sync(ctx context.Context,
ev *types.Event) error
}
func (c *apisixRouteController) handleSyncErr(obj interface{}, err error) {
+ event := obj.(*types.Event)
+ route := event.Object.(kube.ApisixRouteEvent).OldObject
+ // conditions
+ condition := metav1.Condition{
+ Type: "APISIXSynced",
+ }
if err == nil {
+ message := fmt.Sprintf(MessageResourceSynced, RouteController)
+ if route.GroupVersion() == kube.ApisixRouteV1 {
+ c.recorder.Event(route.V1(), v1.EventTypeNormal,
SuccessSynced, message)
+ } else if route.GroupVersion() == kube.ApisixRouteV2alpha1 {
+ c.recorder.Event(route.V2alpha1(), v1.EventTypeNormal,
SuccessSynced, message)
+ // build condition
+ condition.Reason = "SyncSuccessfully"
+ condition.Status = "True"
+ condition.Message = "Sync Successfully"
+ // set to status
+ routev2 := route.V2alpha1()
+ meta.SetStatusCondition(routev2.Status.Conditions,
condition)
+
v2alpha1.New(kube.GetApisixClient().ApisixV2alpha1().RESTClient()).ApisixRoutes(routev2.Namespace).
+ Update(context.TODO(), routev2, nil)
+ }
c.workqueue.Forget(obj)
return
}
log.Warnw("sync ApisixRoute failed, will retry",
zap.Any("object", obj),
zap.Error(err),
)
+ message := fmt.Sprintf(MessageResourceFailed, RouteController,
err.Error())
+ if route.GroupVersion() == kube.ApisixRouteV1 {
+ c.recorder.Event(route.V1(), v1.EventTypeWarning, FailedSynced,
message)
+ } else if route.GroupVersion() == kube.ApisixRouteV2alpha1 {
+ c.recorder.Event(route.V2alpha1(), v1.EventTypeWarning,
FailedSynced, message)
+ // build condition
+ condition.Reason = "SyncFailed"
+ condition.Status = "False"
Review comment:
Use `metav1.ConditionFalse`.
##
File path: pkg/ingress/controller.go
##
@@ -44,6 +44,17 @@ import (
apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
)
+const (
+ // SuccessSynced is used when a resource is synced successfully
+ SuccessSynced = "SyncSuccessfully"
+ // MessageResourceSynced is used to specify controller
+ MessageResourceSynced = "%s synced successfully"
+ // FailedSynced is used when a resource synced failed
+
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #1786: fix: historical comments issues
codecov-commenter edited a comment on pull request #1786: URL: https://github.com/apache/apisix-dashboard/pull/1786#issuecomment-821920973 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1786](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (9c60193) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/17ff973a66b96547c2668b91178f3976710d2eed?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (17ff973) will **increase** coverage by `0.24%`. > The diff coverage is `60.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1786 +/- ## == + Coverage 71.79% 72.04% +0.24% == Files 172 126 -46 Lines6035 2919-3116 Branches 699 705 +6 == - Hits 4333 2103-2230 + Misses 1458 816 -642 + Partials 2440 -244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `72.04% <60.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1786?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/Plugin/UI/api-breaker.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9hcGktYnJlYWtlci50c3g=) | `62.96% <ø> (ø)` | | | [web/src/components/Plugin/UI/cors.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9jb3JzLnRzeA==) | `65.21% <0.00%> (+2.71%)` | :arrow_up: | | [web/src/components/Plugin/UI/limit-count.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb3VudC50c3g=) | `83.33% <100.00%> (ø)` | | | [...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==) | `50.46% <0.00%> (-1.50%)` | :arrow_down: | | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `68.85% <0.00%> (ø)` | | | [web/src/pages/Upstream/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9DcmVhdGUudHN4) | `79.41% <0.00%> (ø)` | | | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1786/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <0.00%> (ø)` | | |
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1786: fix: historical comments issues
netlify[bot] edited a comment on pull request #1786: URL: https://github.com/apache/apisix-dashboard/pull/1786#issuecomment-821919212 Deploy preview for *apisix-dashboard* ready! Built with commit 9c6019357d69a65c45d90ebc80a8ad93d72d0c2a https://deploy-preview-1786--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1786: fix: historical comments issues
LiteSun commented on a change in pull request #1786:
URL: https://github.com/apache/apisix-dashboard/pull/1786#discussion_r615496573
##
File path: web/src/components/Plugin/UI/cors.tsx
##
@@ -57,9 +57,9 @@ const Cors: React.FC = ({ form }) => {
{
-((value as string[]).join(","));
-if ((value as string[]).includes('*')) {
+ onChange={(value: string[]) => {
+value.join(",")
Review comment:
useless code. Just removed. cc @guoqqqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1786: fix: historical comments issues
netlify[bot] edited a comment on pull request #1786: URL: https://github.com/apache/apisix-dashboard/pull/1786#issuecomment-821919212 Deploy preview for *apisix-dashboard* processing. Building with commit 9c6019357d69a65c45d90ebc80a8ad93d72d0c2a https://app.netlify.com/sites/apisix-dashboard/deploys/607cdfa794778b0008e50a88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4074: request help: How to rewrite the data of backend server response?
Firstsawyou commented on issue #4074: URL: https://github.com/apache/apisix/issues/4074#issuecomment-822112126 > @Firstsawyou The problem has resovled. the reason is: > for the large json response, the _M.body_filter will execute many times. I store every ngx.arg[1] to variable backend_content, but the ngx.arg[1] not clear, so ,the final result is repeated. > solution: > > ```lua > if not isFinished then > backend_content = backend_content..ngx.arg[1] > ngx.arg[1] = nil -- have to clear ngx.arg[1] > end > ``` Got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] sniper-xx edited a comment on issue #4074: request help: How to rewrite the data of backend server response?
sniper-xx edited a comment on issue #4074: URL: https://github.com/apache/apisix/issues/4074#issuecomment-822111340 @Firstsawyou The problem has resovled. the reason is: for the large json response, the _M.body_filter will execute many times. I store every ngx.arg[1] to variable backend_content, but the ngx.arg[1] not clear, so ,the final result is repeated. solution: ```lua if not isFinished then backend_content = backend_content..ngx.arg[1] ngx.arg[1] = nil -- have to clear ngx.arg[1] end ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] sniper-xx commented on issue #4074: request help: How to rewrite the data of backend server response?
sniper-xx commented on issue #4074: URL: https://github.com/apache/apisix/issues/4074#issuecomment-822111340 @Firstsawyou The problem has resovled. the reason is: for the large json response, the _M.body_filter will execute many times. I store every ngx.arg[1] to variable backend_content, but the ngx.arg[1] not clear, so ,the final result is repeated. solution: ```lua if not isFinished then backend_content = backend_content..ngx.arg[1] **ngx.arg[1] = nil** end ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3883: feat: add 5xx error page
moonming commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r615494330
##
File path: t/error_handler/error_handler.t
##
@@ -0,0 +1,214 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: set route with serverless-post-function plugin
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"serverless-post-function": {
+"functions" : ["return function() if
ngx.var.http_x_test_status ~= nil
then;ngx.exit(tonumber(ngx.var.http_x_test_status));end;end"]
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}]]
+)
+
+if code >= 300 then
+ngx.sleep(100)
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 2: test apisix with internal error code 500
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 500
+--- error_code: 500
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 3: test apisix with internal error code 502
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 502
+--- error_code: 502
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 4: test apisix with internal error code 503
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 503
+--- error_code: 503
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 5: test apisix with internal error code 504
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 504
+--- error_code: 504
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 6: test apisix with internal error code 400
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 400
+--- error_code: 400
+--- response_body
+
+400 Bad Request
+
+400 Bad Request
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 7: test apisix with internal error code 401
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 401
+--- error_code: 401
+--- response_body
+
+401 Unauthorized
+
+401 Unauthorized
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 8: test apisix with internal error code 403
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 403
+--- error_code: 403
+--- response_body
+
+403 Forbidden
+
+403 Forbidden
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 9: test apisix with internal error code 404
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 404
+--- error_code: 404
+--- response_body
+
+404 Not Found
+
+404 Not Found
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 10: test apisix with internal error code 405
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 405
+--- error_code: 405
+--- response_body
+
+405 Not Allowed
+
+405 Not Allowed
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 12: test apisix with upstream error code 400
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 400
+--- error_code: 400
+--- response_body
+upstream status: 400
+
+
+
+=== TEST 11: test apisix with upstream error code 500
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 500
+--- error_code: 500
+--- response_body
+upstream status: 500
Review comment:
I am a little confused, why do special treatments for upstream status?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3883: feat: add 5xx error page
moonming commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r615492580
##
File path: apisix/error_handler.lua
##
@@ -0,0 +1,78 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+local ngx = ngx
+local str_format = string.format
+
+
+local html_5xx = [[
+
+
+
+
+
+Error
+
+body {
+width: 35em;
+margin: 0 auto;
+font-family: Tahoma, Verdana, Arial, sans-serif;
+}
+
+
+
+An error occurred.
+You can report issue to https://github.com/apache/apisix/issues;>APISIX
+Faithfully yours, https://apisix.apache.org/;>APISIX.
+
+
+]]
+
+local html_4xx = [[
+
+%s
+
+%s
+ https://apisix.apache.org/;>APISIX
+
+
+]]
+
+local ngx_status_line = {
+[400] = "400 Bad Request",
+[401] = "401 Unauthorized",
+[403] = "403 Forbidden",
+[404] = "404 Not Found",
+[405] = "405 Not Allowed",
+}
+
Review comment:
why we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #4074: request help: How to rewrite the data of backend server response?
tokers commented on issue #4074: URL: https://github.com/apache/apisix/issues/4074#issuecomment-822107779 > @Firstsawyou I refer to this plugin to write a new plugin. there are tow defferences: > 1、 The ‘body' which is not static, is from the backend service; > 2、The body content is very large. function of body_filter executed many times; > I try to concatenate the chunck of every body_filter function received from backend,but can't not correct serialize to integrated json document. I took a glance of your custom `_M.body_filter`, where is your `backend_content` variable? Also, when the response body is large, the string concatenation is inefficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #383: feat: apisixtls schema
tokers commented on pull request #383: URL: https://github.com/apache/apisix-ingress-controller/pull/383#issuecomment-822107158 > > @gxthrj e2e cases about SSL already test it. > > But no error case covered. That'd will be a huge workload, as we also lacks the cases for ApisixRoute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #383: feat: apisixtls schema
gxthrj commented on pull request #383: URL: https://github.com/apache/apisix-ingress-controller/pull/383#issuecomment-822106664 > @gxthrj e2e cases about SSL already test it. But no error case covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #384: chore: remove pkg/seven
tokers merged pull request #384: URL: https://github.com/apache/apisix-ingress-controller/pull/384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated (561708f -> f26ee93)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git.
from 561708f test: add e2e test cases for referer-restriction plugin (#375)
add f26ee93 chore: remove pkg/seven (#384)
No new revisions were added by this update.
Summary of changes:
pkg/apisix/resource_test.go| 1 +
pkg/kube/translation/annotations.go| 44 ++--
.../{annotations.go => annotations/cors.go}| 61 +--
.../{util_test.go => annotations/iprestriction.go} | 33 +++---
pkg/seven/apisix/plugins.go| 115 -
5 files changed, 46 insertions(+), 208 deletions(-)
copy pkg/kube/translation/{annotations.go => annotations/cors.go} (51%)
copy pkg/kube/translation/{util_test.go => annotations/iprestriction.go} (59%)
delete mode 100644 pkg/seven/apisix/plugins.go
[GitHub] [apisix-ingress-controller] tokers commented on pull request #383: feat: apisixtls schema
tokers commented on pull request #383: URL: https://github.com/apache/apisix-ingress-controller/pull/383#issuecomment-822106406 @gxthrj e2e cases about SSL already test it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #383: feat: apisixtls schema
gxthrj commented on pull request #383: URL: https://github.com/apache/apisix-ingress-controller/pull/383#issuecomment-822105772 Need some test-case for jsonschema -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #385: WIP: fix wrong group version for extensions/v1beta1.Ingress
tokers commented on pull request #385: URL: https://github.com/apache/apisix-ingress-controller/pull/385#issuecomment-822105520 @vincenthcui Hi, is this PR still in the progress? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3883: feat: add 5xx error page
tokers commented on a change in pull request #3883:
URL: https://github.com/apache/apisix/pull/3883#discussion_r615490453
##
File path: t/error_handler/error_handler.t
##
@@ -0,0 +1,214 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+log_level('debug');
+repeat_each(1);
+no_long_string();
+no_root_location();
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: set route with serverless-post-function plugin
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin").test
+local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+"plugins": {
+"serverless-post-function": {
+"functions" : ["return function() if
ngx.var.http_x_test_status ~= nil
then;ngx.exit(tonumber(ngx.var.http_x_test_status));end;end"]
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+},
+"uri": "/*"
+}]]
+)
+
+if code >= 300 then
+ngx.sleep(100)
+ngx.status = code
+end
+ngx.say(body)
+}
+}
+--- request
+GET /t
+--- response_body
+passed
+--- no_error_log
+[error]
+
+
+
+=== TEST 2: test apisix with internal error code 500
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 500
+--- error_code: 500
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 3: test apisix with internal error code 502
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 502
+--- error_code: 502
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 4: test apisix with internal error code 503
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 503
+--- error_code: 503
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 5: test apisix with internal error code 504
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 504
+--- error_code: 504
+--- response_body_like
+apisix.apache.org
+
+
+
+=== TEST 6: test apisix with internal error code 400
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 400
+--- error_code: 400
+--- response_body
+
+400 Bad Request
+
+400 Bad Request
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 7: test apisix with internal error code 401
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 401
+--- error_code: 401
+--- response_body
+
+401 Unauthorized
+
+401 Unauthorized
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 8: test apisix with internal error code 403
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 403
+--- error_code: 403
+--- response_body
+
+403 Forbidden
+
+403 Forbidden
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 9: test apisix with internal error code 404
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 404
+--- error_code: 404
+--- response_body
+
+404 Not Found
+
+404 Not Found
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 10: test apisix with internal error code 405
+--- request
+GET /hello
+--- more_headers
+X-Test-Status: 405
+--- error_code: 405
+--- response_body
+
+405 Not Allowed
+
+405 Not Allowed
+ https://apisix.apache.org/;>APISIX
+
+
+
+
+
+=== TEST 12: test apisix with upstream error code 400
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 400
+--- error_code: 400
+--- response_body
+upstream status: 400
+
+
+
+=== TEST 11: test apisix with upstream error code 500
+--- request
+GET /specific_status
+--- more_headers
+X-Test-Upstream-Status: 500
+--- error_code: 500
+--- response_body
+upstream status: 500
Review comment:
Please check the editor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj opened a new pull request #386: feat: add event & status for ApisixRoute v2
gxthrj opened a new pull request #386: URL: https://github.com/apache/apisix-ingress-controller/pull/386 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #73: kubectl plugin support
tokers commented on issue #73: URL: https://github.com/apache/apisix-ingress-controller/issues/73#issuecomment-822104022 @fhuzero I will re-assign this issue for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
